Re: [Qemu-devel] windows XP fail to enter standby mode

2011-09-15 Thread hkran
On 09/15/2011 06:42 PM, Alon Levy wrote: On Thu, Sep 15, 2011 at 05:23:01PM +0800, hkran wrote: Hi, If I select to let my guest XP enter standby mode by clicking the button manually. qemu will exit with the following message left: ioport_write: PANIC d->guest_slots[val].active failed the foll

[Qemu-devel] [PATCH] virtio-9p: Use 9P specific Lock constants

2011-09-15 Thread M. Mohan Kumar
Use 9P specific lock constants instead of arch specific lock constants. Signed-off-by: M. Mohan Kumar --- hw/9pfs/virtio-9p.c |2 +- hw/9pfs/virtio-9p.h |6 ++ 2 files changed, 7 insertions(+), 1 deletions(-) diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c index 668ea24..181c

[Qemu-devel] [PATCH] hw/9pfs: Add open flag mapping

2011-09-15 Thread M. Mohan Kumar
Guest and the host may not be running same architecture. Hence fcntl flag mapping is needed. Signed-off-by: Venkateswararao Jujjuri Signed-off-by: Aneesh Kumar K.V Signed-off-by: M. Mohan Kumar --- hw/9pfs/virtio-9p.c | 50 +- hw/9pfs/virtio-9p

Re: [Qemu-devel] [PATCH] Fix subtle integer overflow bug in memory API

2011-09-15 Thread David Gibson
On Thu, Sep 15, 2011 at 10:28:42AM +0300, Avi Kivity wrote: > On 09/15/2011 05:58 AM, David Gibson wrote: > >> Well.. I'm pretty sure that particular case can no longer be > >> triggered. But there may be other integer overflow bugs in this code, > >> though I didn't spot them at a glance. > >

Re: [Qemu-devel] [Qemu-ppc] [PATCH 01/58] spapr: proper qdevification

2011-09-15 Thread David Gibson
On Thu, Sep 15, 2011 at 09:01:38AM +0200, Paolo Bonzini wrote: > On 09/15/2011 05:14 AM, David Gibson wrote: > >Under PAPR, there is generally only > >supposed to be one SCSI target (disk / cd / whatever) per virtual scsi > >bus. But the generic qdev code will, by default, keep assigning > >device

Re: [Qemu-devel] [Qemu-ppc] [PATCH 28/58] device tree: give dt more size

2011-09-15 Thread David Gibson
On Thu, Sep 15, 2011 at 05:00:41PM +0200, Alexander Graf wrote: > > Am 15.09.2011 um 13:03 schrieb David Gibson : > > > On Thu, Sep 15, 2011 at 09:37:48AM +0200, Alexander Graf wrote: > >> > >> On 15.09.2011, at 05:19, David Gibson wrote: > >> > >>> On Wed, Sep 14, 2011 at 10:42:52AM +0200, Ale

Re: [Qemu-devel] [PATCH] usb: change VID/PID for usb-hub and usb-msd to prevent conflict

2011-09-15 Thread Roy Tam
2011/9/16 Gerd Hoffmann : > On 09/15/11 05:25, Roy Tam wrote: >> >> Some USB drivers, for example USBASPI.SYS, will skip different type of >> device which has same VID/PID. The following patch helps preventing >> usb-msd being skipped by the driver. > > How and why did you pick those IDs? > >>  sta

[Qemu-devel] [PATCH 3/3] milkymist: new interrupt map

2011-09-15 Thread Michael Walle
Due to the new uart core version the interrupt mapping has changed. Signed-off-by: Michael Walle --- hw/milkymist.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/milkymist.c b/hw/milkymist.c index 6d99260..b7a8c1c 100644 --- a/hw/milkymist.c +++ b/hw/milk

[Qemu-devel] [PATCH 2/3] milkymist_uart: support new core version

2011-09-15 Thread Michael Walle
The new version of the uart core introduces status and control bits. Signed-off-by: Michael Walle --- hw/milkymist-hw.h |5 +-- hw/milkymist-uart.c | 72 -- hw/milkymist.c |2 +- trace-events|4 +- 4 files changed, 68 i

[Qemu-devel] [PULL] lm32 fixes and new milkymist hardware support

2011-09-15 Thread Michael Walle
Hi Anthony, here is a patch for target-lm32, which is broken with the current master. Additionally, support for the new uart of the milkymist SoC is added. The following changes since commit ef4f97cba2a354656b00eb8659bf61ab2321fa4e: Merge remote-tracking branch 'qemu-kvm-tmp/memory/core' int

[Qemu-devel] [PATCH 1/3] lm32: add missing qemu_init_vcpu() call

2011-09-15 Thread Michael Walle
Signed-off-by: Michael Walle --- target-lm32/helper.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/target-lm32/helper.c b/target-lm32/helper.c index 014fd8d..fc0b444 100644 --- a/target-lm32/helper.c +++ b/target-lm32/helper.c @@ -218,6 +218,7 @@ CPUState *cpu_lm32_ini

[Qemu-devel] [PATCH] console: Properly switch consoles for screen dumps

2011-09-15 Thread Jan Kiszka
From: Jan Kiszka Do not mess with active_console, use console_select instead. This fixes corrupt virtual monitor consoles after issuing the screendump command. Signed-off-by: Jan Kiszka --- Looks still weird - we should enable dumping to an invisible display buffer - but it cures this symptom

[Qemu-devel] [PATCH] vga: Fix text mode screendumps

2011-09-15 Thread Jan Kiszka
From: Jan Kiszka In text mode, even a full refresh of the screen takes multiple updates. As we reset the dump file pointer after the first call, we only wrote the first line. Signed-off-by: Jan Kiszka --- hw/vga.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/h

Re: [Qemu-devel] qemu virtIO blocking operation - question

2011-09-15 Thread Sinha, Ani
On Sep 15, 2011, at 4:42 AM, Stefan Hajnoczi wrote: > On Tue, Sep 13, 2011 at 6:35 PM, Sinha, Ani wrote: >> Makes sense? > > I'm still not sure what the point of multiplexing host IPMI into > guests is. The guest should not be able to power off the host. It > shouldn't be able to mess with the

[Qemu-devel] [PATCH 1/1] slirp: Fill TCP/IP header template after SYN reception

2011-09-15 Thread Jan Kiszka
This ensures we can cleanly signal the drop in case the connection timer fires. So far we sent those frames to nowhere (target IP 0.0.0.0). Found by the new assertion on invalid IPs in arp_table_search. Signed-off-by: Jan Kiszka --- slirp/tcp_input.c |1 + 1 files changed, 1 insertions(+),

[Qemu-devel] [PULL] slirp fix

2011-09-15 Thread Jan Kiszka
The following changes since commit 44520db10b1b92f272348ab7028e7afc68ac3edf: Gdbstub: Fix back-trace on SPARC32 (2011-09-10 18:12:35 +) are available in the git repository at: git://git.kiszka.org/qemu.git queues/slirp Jan Kiszka (1): slirp: Fill TCP/IP header template after SYN re

Re: [Qemu-devel] [Bug 818673] Re: virtio: trying to map MMIO memory

2011-09-15 Thread Rick Vernam
On Thursday 15 September 2011 11:23:53 Rick Vernam wrote: > On Wednesday 14 September 2011 16:30:11 Rick Vernam wrote: > > On Wednesday 14 September 2011 14:42:09 vrozenfe wrote: > > > Thank you, Rick. > > > > > > Could you help me to narrow this problem down? > > > > Absolutely. > > > > > As I

[Qemu-devel] [PATCH 2/4] rbd: allow escaping in config string

2011-09-15 Thread Sage Weil
The config string is variously delimited by =, @, and /, depending on the field. Allow these characters to be escaped by preceeding them with \. Signed-off-by: Sage Weil --- block/rbd.c | 29 +++-- 1 files changed, 27 insertions(+), 2 deletions(-) diff --git a/block/r

[Qemu-devel] [PATCH 1/4] rbd: ignore failures when reading from default conf location

2011-09-15 Thread Sage Weil
If we are reading from the default config location, ignore any failures. It is perfectly legal for the user to specify exactly the options they need and to not rely on any config file. Signed-off-by: Sage Weil --- block/rbd.c | 14 -- 1 files changed, 4 insertions(+), 10 deletions(

[Qemu-devel] [PATCH] memory: fix subregion collision warning

2011-09-15 Thread Michael Walle
Instead of the offset property use the proper addr property to calculate the offsets. Additionally, be a little more verbose on the warning and print the subregion name. Signed-off-by: Michael Walle --- memory.c | 13 - 1 files changed, 8 insertions(+), 5 deletions(-) diff --git

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-15 Thread Anthony Liguori
On 09/15/2011 03:45 PM, Peter Maydell wrote: On 15 September 2011 21:29, Gleb Natapov wrote: 16650A is not a device. ISA card it resides on is a device. The 16550A is an encapsulated set of functionality with some well defined interfaces ("I provide a set of memory mapped registers", "I have

[Qemu-devel] [PATCH 3/4] rbd: update comment heading

2011-09-15 Thread Sage Weil
Properly document the configuration string syntax and semantics. Remove (out of date) details about the librbd implementation. Signed-off-by: Sage Weil --- block/rbd.c | 28 +--- 1 files changed, 13 insertions(+), 15 deletions(-) diff --git a/block/rbd.c b/block/rbd.c

[Qemu-devel] [PATCH 4/4] rbd: call flush, if available

2011-09-15 Thread Sage Weil
librbd recently added async writeback and flush support. If the new rbd_flush() call is available, call it. Signed-off-by: Sage Weil --- block/rbd.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/block/rbd.c b/block/rbd.c index 202e7ec..af65924 100644 --- a

[Qemu-devel] [PATCH 0/4] More RBD updates

2011-09-15 Thread Sage Weil
Hi, Here are a few more improvements to the qemu rbd support. The first patch makes the configuration file handling cleaner (do not error out if /etc/ceph/ceph.conf doesn't exist). One allows characters in the conf string to be escaped, so you can (for example) specify an ip\:port (':' is us

[Qemu-devel] [PATCH 5/9] Drop the incoming_expected global variable

2011-09-15 Thread Luiz Capitulino
Test against RSTATE_IN_MIGRATE instead. Please, note that the RSTATE_IN_MIGRATE state is only set when all the initial VM setup is done, while 'incoming_expected' was set right in the beginning when parsing command-line options. Shouldn't be a problem as far as I could check. Signed-off-by: Luiz

[Qemu-devel] [PATCH 3/9] RunState: Add additional states

2011-09-15 Thread Luiz Capitulino
Currently, only vm_start() and vm_stop() change the VM state. That's, the state is only changed when starting or stopping the VM. This commit adds the runstate_set() function, which makes it possible to also do state transitions when the VM is stopped or running. Additional states are also added

[Qemu-devel] [PATCH 9/9] HMP: info status: Print the VM state

2011-09-15 Thread Luiz Capitulino
Today our printf format for the "info status" command is: VM status: %s Where the string can be "running", "running (single step mode)" or "paused". This commit extends it to: VM status: %s (%s) The second string corresponds to the "status" field as returned by the query-status QMP command

[Qemu-devel] [PATCH 6/9] Drop the vm_running global variable

2011-09-15 Thread Luiz Capitulino
Use runstate_is_running() instead, which is introduced by this commit. Signed-off-by: Luiz Capitulino --- cpus.c|9 - gdbstub.c |4 ++-- hw/etraxfs_dma.c |2 +- hw/kvmclock.c |2 +- hw/virtio.c |2 +- migration.c |2 +- monitor

[Qemu-devel] [PATCH 4/9] runstate_set(): Check for valid transitions

2011-09-15 Thread Luiz Capitulino
This commit could have been folded with the previous one, however doing it separately will allow for easy bisect and revert if needed. Checking and testing all valid transitions wasn't trivial, chances are this will need broader testing to become more stable. This is a transition table as suggest

[Qemu-devel] [PATCH 7/9] Monitor/QMP: Don't allow cont on bad VM state

2011-09-15 Thread Luiz Capitulino
We have two states where issuing cont before system_reset can cause problems: RSTATE_SHUTDOWN (when -no-shutdown is used) and RSTATE_PANICKED (which only happens with kvm). This commit fixes that by doing the following when state is RSTATE_SHUTDOWN or RSTATE_PANICKED: 1. returning an error to th

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-15 Thread Anthony Liguori
On 09/15/2011 03:23 PM, Avi Kivity wrote: On 09/15/2011 04:26 PM, Anthony Liguori wrote: I think this model is the closest to what we have today and is the most obvious. For something like ne2k, I would expect: class NE2000 : public Device { // ne2k public functions }; class PCI_NE2000 : publ

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-15 Thread Anthony Liguori
On 09/15/2011 03:29 PM, Gleb Natapov wrote: On Thu, Sep 15, 2011 at 12:51:23PM -0500, Anthony Liguori wrote: On 09/15/2011 11:59 AM, Gleb Natapov wrote: On Thu, Sep 15, 2011 at 11:33:00AM -0500, Anthony Liguori wrote: On 09/15/2011 10:38 AM, Gleb Natapov wrote: On Thu, Sep 15, 2011 at 10:28:5

[Qemu-devel] [PATCH 2/2] build: Move tracing objects into libuser on usermode emulation targets

2011-09-15 Thread Lluís Vilanova
This will apply libuser-specific compilation flags (like the ones added by --enable-user-pie), but keep softmmu emulation targets "as-is". Signed-off-by: Lluís Vilanova --- Makefile.objs |7 --- Makefile.target |2 +- Makefile.user |4 +++- configure |1 + 4 files c

[Qemu-devel] [PATCH 1/2] build: Always have 'BUILD_DIR' variable pointing to the root of the build tree

2011-09-15 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- Makefile |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index 7e9382f..57cc399 100644 --- a/Makefile +++ b/Makefile @@ -1,5 +1,8 @@ # Makefile for QEMU. +# Always point to the root of the build tree +BUILD_DIR=

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-15 Thread Peter Maydell
On 15 September 2011 21:29, Gleb Natapov wrote: > 16650A is not a device. ISA card it resides on is a device. The 16550A is an encapsulated set of functionality with some well defined interfaces ("I provide a set of memory mapped registers", "I have an output gpio line (irq)"), which we need to b

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-15 Thread Gleb Natapov
On Thu, Sep 15, 2011 at 12:51:23PM -0500, Anthony Liguori wrote: > On 09/15/2011 11:59 AM, Gleb Natapov wrote: > >On Thu, Sep 15, 2011 at 11:33:00AM -0500, Anthony Liguori wrote: > >>On 09/15/2011 10:38 AM, Gleb Natapov wrote: > >>>On Thu, Sep 15, 2011 at 10:28:52AM -0500, Anthony Liguori wrote: >

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-15 Thread Avi Kivity
On 09/15/2011 04:26 PM, Anthony Liguori wrote: I think this model is the closest to what we have today and is the most obvious. For something like ne2k, I would expect: class NE2000 : public Device { // ne2k public functions }; class PCI_NE2000 : public PciDevice { // implement PCI func

[Qemu-devel] [PATCH 8/9] QMP: query-status: Introduce 'status' key

2011-09-15 Thread Luiz Capitulino
This new key reports the current VM status to clients. Please, check the documentation being added in this commit for more details. Signed-off-by: Luiz Capitulino --- monitor.c |3 +-- qmp-commands.hx | 19 ++- sysemu.h|1 + vl.c| 23

[Qemu-devel] [PATCH 2/9] Replace the VMSTOP macros with a proper state type

2011-09-15 Thread Luiz Capitulino
Today, when notifying a VM state change with vm_state_notify(), we pass a VMSTOP macro as the 'reason' argument. This is not ideal because the VMSTOP macros tell why qemu stopped and not exactly what the current VM state is. One example to demonstrate this problem is that vm_start() calls vm_state

Re: [Qemu-devel] [PATCH 1/2] build: Always have 'BUILD_DIR' variable pointing to the root of the build tree

2011-09-15 Thread Paolo Bonzini
On 09/15/2011 07:16 PM, Lluís Vilanova wrote: subdir-%: $(GENERATED_HEADERS) - $(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C $* V="$(V)" TARGET_DIR="$*/" all,) + $(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C $* V="$(V)" BUILD_DIR=$(BUILD_DIR) TARGET_DIR="$*/" all,) S

[Qemu-devel] [PATCH 1/9] Move vm_state_notify() prototype from cpus.h to sysemu.h

2011-09-15 Thread Luiz Capitulino
It's where all the state handling functions prototypes are located. Signed-off-by: Luiz Capitulino --- cpus.h |1 - sysemu.h |1 + 2 files changed, 1 insertions(+), 1 deletions(-) diff --git a/cpus.h b/cpus.h index f42b54e..5885885 100644 --- a/cpus.h +++ b/cpus.h @@ -15,7 +15,6 @@ vo

[Qemu-devel] [PULL 0/9]: QMP queue

2011-09-15 Thread Luiz Capitulino
Anthony, This is my latest pull of the RunState series with a build problem fixed and yet another rebase (solved automatically by git). The changes (since ef4f97cba2a354656b00eb8659bf61ab2321fa4e) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp Lu

[Qemu-devel] [Bug 818673] Re: virtio: trying to map MMIO memory

2011-09-15 Thread vrozenfe
Thank you, Rick. I will start checking virtio-serial driver tomorrow. Best, Vadim. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/818673 Title: virtio: trying to map MMIO memory Status in QEMU:

Re: [Qemu-devel] [PATCH RFC] main loop: fix some accesses made in sighandler context

2011-09-15 Thread Peter Maydell
On 15 September 2011 18:22, Laszlo Ersek wrote: > -int no_shutdown = 0; > +volatile int no_shutdown = 0; So why 'volatile' and not 'sig_atomic_t', then? thanks -- PMM

Re: [Qemu-devel] [PATCH 2/2] build: Move tracing objects into libuser on usermode emulation targets

2011-09-15 Thread Richard Henderson
On 09/15/2011 10:17 AM, Lluís Vilanova wrote: > This will apply libuser-specific compilation flags (like the ones added by > --enable-user-pie), but keep softmmu emulation targets "as-is". > > Signed-off-by: Lluís Vilanova > --- > Makefile.objs |7 --- > Makefile.target |2 +- > Ma

Re: [Qemu-devel] [PATCH 1/2] build: Always have 'BUILD_DIR' variable pointing to the root of the build tree

2011-09-15 Thread Richard Henderson
On 09/15/2011 10:16 AM, Lluís Vilanova wrote: > > --- > Makefile | 11 +++ > 1 files changed, 7 insertions(+), 4 deletions(-) This is going to get bounced back to you because of no Signed-off-by, but: Acked-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH RFC] main loop: fix some accesses made in sighandler context

2011-09-15 Thread Anthony Liguori
On 09/15/2011 12:22 PM, Laszlo Ersek wrote: Make variables volatile ("sig_atomic_t" should cover "int" and "pid_t"). Also replace calls to functions that are not required to be async-signal-safe [1]. (I haven't checked if any signal masks and/or previous suspension of the interrupted thread keep

Re: [Qemu-devel] [PULL] VirtFS update

2011-09-15 Thread Anthony Liguori
On 09/13/2011 08:27 AM, Aneesh Kumar K.V wrote: Hi Anthony, This series contain few fixes to VirtFS server. The patch set also add two new 9p operations. Please pull. The following changes since commit 07ff2c4475df77e38a31d50ee7f3932631806c15: Merge remote-tracking branch 'origin/master' i

Re: [Qemu-devel] [PULL] Memory core integer overflow fix

2011-09-15 Thread Anthony Liguori
On 09/14/2011 07:48 AM, Avi Kivity wrote: Please pull from git://github.com/avikivity/qemu.git memory/core to receive a core fix for an integer overflow problem hitting ppc: David Gibson (1): Fix subtle integer overflow bug in memory API Pulled. Thanks. Regards, Anthony Liguori memory

Re: [Qemu-devel] [PULL 00/35] Block patches

2011-09-15 Thread Anthony Liguori
On 09/12/2011 09:18 AM, Kevin Wolf wrote: The following changes since commit 44520db10b1b92f272348ab7028e7afc68ac3edf: Gdbstub: Fix back-trace on SPARC32 (2011-09-10 18:12:35 +) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Pulled. Thanks. Reg

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-15 Thread Anthony Liguori
On 09/15/2011 11:38 AM, Jan Kiszka wrote: On 2011-09-15 16:11, Anthony Liguori wrote: An example is a NIC with nvram that stores a mac address. In QOM, the guest could change the mac address, then a user could hot unplug the device, and then hot plug the device into a different PCI slot. The p

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-15 Thread Anthony Liguori
On 09/15/2011 11:59 AM, Gleb Natapov wrote: On Thu, Sep 15, 2011 at 11:33:00AM -0500, Anthony Liguori wrote: On 09/15/2011 10:38 AM, Gleb Natapov wrote: On Thu, Sep 15, 2011 at 10:28:52AM -0500, Anthony Liguori wrote: On 09/15/2011 09:25 AM, Gleb Natapov wrote: There is no canonical parent li

[Qemu-devel] [PATCH RFC] main loop: fix some accesses made in sighandler context

2011-09-15 Thread Laszlo Ersek
Make variables volatile ("sig_atomic_t" should cover "int" and "pid_t"). Also replace calls to functions that are not required to be async-signal-safe [1]. (I haven't checked if any signal masks and/or previous suspension of the interrupted thread keep the current calls safe.) termsig_handler()

Re: [Qemu-devel] [PATCH] build: Move tracing objects into libuser on usermode emulation targets

2011-09-15 Thread Lluís Vilanova
Please ignore this one; sorry. -- "And it's much the same thing with knowledge, for whenever you learn something new, the whole world becomes that much richer." -- The Princess of Pure Reason, as told by Norton Juster in The Phantom Tollbooth

[Qemu-devel] [PATCH 2/2] build: Move tracing objects into libuser on usermode emulation targets

2011-09-15 Thread Lluís Vilanova
This will apply libuser-specific compilation flags (like the ones added by --enable-user-pie), but keep softmmu emulation targets "as-is". Signed-off-by: Lluís Vilanova --- Makefile.objs |7 --- Makefile.target |2 +- Makefile.user |4 +++- configure |1 + 4 files c

[Qemu-devel] [PATCH 1/2] build: Always have 'BUILD_DIR' variable pointing to the root of the build tree

2011-09-15 Thread Lluís Vilanova
--- Makefile | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index 7e9382f..97b26c6 100644 --- a/Makefile +++ b/Makefile @@ -1,5 +1,8 @@ # Makefile for QEMU. +# Always point to the root of the build tree +BUILD_DIR=$(PWD) + GENERATED_HEAD

[Qemu-devel] [PATCH] build: Move tracing objects into libuser on usermode emulation targets

2011-09-15 Thread Lluís Vilanova
This will apply libuser-specific compilation flags (like the ones added by --enable-user-pie), but keep softmmu emulation targets "as-is". Signed-off-by: Lluís Vilanova --- Makefile.objs |7 --- Makefile.target |2 +- Makefile.user |4 +++- configure |1 + 4 files c

Re: [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI

2011-09-15 Thread Orit Wasserman
On Thu, 2011-09-15 at 14:58 +0200, Paolo Bonzini wrote: > On 09/15/2011 02:34 PM, Orit Wasserman wrote: > >> > Then you need an iSCSI*target* that understands qcow2, like qemu-nbd > >> > but for iSCSI... that's exactly the thing you were worried about > >> > implementing. > > > > Not really , t

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-15 Thread Gleb Natapov
On Thu, Sep 15, 2011 at 11:33:00AM -0500, Anthony Liguori wrote: > On 09/15/2011 10:38 AM, Gleb Natapov wrote: > >On Thu, Sep 15, 2011 at 10:28:52AM -0500, Anthony Liguori wrote: > >>On 09/15/2011 09:25 AM, Gleb Natapov wrote: > >> > >>There is no canonical parent link. A device may have multiple

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-15 Thread Anthony Liguori
On 09/15/2011 10:38 AM, Gleb Natapov wrote: On Thu, Sep 15, 2011 at 10:28:52AM -0500, Anthony Liguori wrote: On 09/15/2011 09:25 AM, Gleb Natapov wrote: There is no canonical parent link. A device may have multiple (more or less equivalent) parents. What should be treated as the "canonical" l

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-15 Thread Jan Kiszka
On 2011-09-15 16:11, Anthony Liguori wrote: > An example is a NIC with nvram that stores a mac address. In QOM, the guest > could change the mac address, then a user could hot unplug the device, and > then > hot plug the device into a different PCI slot. The path is now different but > the de

Re: [Qemu-devel] [Bug 818673] Re: virtio: trying to map MMIO memory

2011-09-15 Thread Rick Vernam
On Wednesday 14 September 2011 16:30:11 Rick Vernam wrote: > On Wednesday 14 September 2011 14:42:09 vrozenfe wrote: > > Thank you, Rick. > > > > Could you help me to narrow this problem down? > > Absolutely. > > > As I see, you have three virtio drivers installed on your system - block, > > net

Re: [Qemu-devel] [PATCH] usb: change VID/PID for usb-hub and usb-msd to prevent conflict

2011-09-15 Thread Gerd Hoffmann
On 09/15/11 05:25, Roy Tam wrote: Some USB drivers, for example USBASPI.SYS, will skip different type of device which has same VID/PID. The following patch helps preventing usb-msd being skipped by the driver. How and why did you pick those IDs? static const USBDesc desc_hub = { .id =

Re: [Qemu-devel] [PATCH] build: Move tracing objects into libuser on usermode emulation targets

2011-09-15 Thread Lluís Vilanova
Lluís Vilanova writes: > Richard Henderson writes: >> On 09/15/2011 08:28 AM, Lluís Vilanova wrote: >>> This will apply libuser-specific compilation flags (like the ones added by >>> --enable-user-pie), but keep softmmu emulation targets "as-is". >> This is missing some dependencies. >> make[1]:

Re: [Qemu-devel] [PATCH] build: Move tracing objects into libuser on usermode emulation targets

2011-09-15 Thread Richard Henderson
On 09/15/2011 08:58 AM, Lluís Vilanova wrote: > Is this for an out-of-tree compilation? I saw some errors regarding > missing *.mak files that were already there before applying my changes. Of course. I never build in-tree. r~

Re: [Qemu-devel] [PATCH] build: Move tracing objects into libuser on usermode emulation targets

2011-09-15 Thread Lluís Vilanova
Richard Henderson writes: > On 09/15/2011 08:28 AM, Lluís Vilanova wrote: >> This will apply libuser-specific compilation flags (like the ones added by >> --enable-user-pie), but keep softmmu emulation targets "as-is". > This is missing some dependencies. > make[1]: *** No rule to make target `c

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-15 Thread Paolo Bonzini
On 09/15/2011 05:31 PM, Anthony Liguori wrote: I think it's in the eye of a beholder. Hold a PCI NE2000 and E1000, they're clearly both PciDevices, but also they clearly both have PciConnectors. Write a driver for a PCI and ISA NE2000, and then they're clearly both NE2000, but also they clearly

Re: [Qemu-devel] [PATCH] build: Move tracing objects into libuser on usermode emulation targets

2011-09-15 Thread Richard Henderson
On 09/15/2011 08:28 AM, Lluís Vilanova wrote: > This will apply libuser-specific compilation flags (like the ones added by > --enable-user-pie), but keep softmmu emulation targets "as-is". This is missing some dependencies. make[1]: *** No rule to make target `config-host.mak', needed by `trace.

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-15 Thread Gleb Natapov
On Thu, Sep 15, 2011 at 10:28:52AM -0500, Anthony Liguori wrote: > On 09/15/2011 09:25 AM, Gleb Natapov wrote: > >On Thu, Sep 15, 2011 at 04:14:45PM +0200, Paolo Bonzini wrote: > >>On 09/15/2011 03:57 PM, Anthony Liguori wrote: > >>> > >>>void generate_tree(Device *node) > >>>{ > >>>if (IS_PCI_

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-15 Thread Anthony Liguori
On 09/15/2011 09:33 AM, Paolo Bonzini wrote: On 09/15/2011 04:18 PM, Anthony Liguori wrote: I think there are two real discussions happening here. One is how to model and one is what is the right representation of that modelling. I think Paolo is strongly advocating a non-OO model that uses the

[Qemu-devel] [PATCH] build: Move tracing objects into libuser on usermode emulation targets

2011-09-15 Thread Lluís Vilanova
This will apply libuser-specific compilation flags (like the ones added by --enable-user-pie), but keep softmmu emulation targets "as-is". Signed-off-by: Lluís Vilanova --- Makefile.objs |1 + Makefile.target |2 +- Makefile.user |4 +++- configure |1 + 4 files changed

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-15 Thread Anthony Liguori
On 09/15/2011 09:25 AM, Gleb Natapov wrote: On Thu, Sep 15, 2011 at 04:14:45PM +0200, Paolo Bonzini wrote: On 09/15/2011 03:57 PM, Anthony Liguori wrote: void generate_tree(Device *node) { if (IS_PCI_BUS(node)) { for (i = 0; i< 32; i++) { generate_tree(lookup_device(get_p

Re: [Qemu-devel] [Qemu-ppc] [PATCH 28/58] device tree: give dt more size

2011-09-15 Thread Alexander Graf
Am 15.09.2011 um 13:03 schrieb David Gibson : > On Thu, Sep 15, 2011 at 09:37:48AM +0200, Alexander Graf wrote: >> >> On 15.09.2011, at 05:19, David Gibson wrote: >> >>> On Wed, Sep 14, 2011 at 10:42:52AM +0200, Alexander Graf wrote: We currently load a device tree blob and then just take

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-15 Thread Peter Maydell
On 15 September 2011 15:33, Paolo Bonzini wrote: > I think it's in the eye of a beholder.  Hold a PCI NE2000 and E1000, they're > clearly both PciDevices, but also they clearly both have PciConnectors. > > Write a driver for a PCI and ISA NE2000, and then they're clearly both > NE2000, but also th

Re: [Qemu-devel] blobstore disk format (was Re: Design of the blobstore)

2011-09-15 Thread Stefan Berger
On 09/15/2011 08:28 AM, Michael S. Tsirkin wrote: So the below is a proposal for a directory scheme for storing (optionally multiple) nvram images, along with any metadata. Data is encoded using BER: http://en.wikipedia.org/wiki/Basic_Encoding_Rules Specifically, we mostly use the subsets. Would

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-15 Thread Paolo Bonzini
On 09/15/2011 04:18 PM, Anthony Liguori wrote: I think there are two real discussions happening here. One is how to model and one is what is the right representation of that modelling. I think Paolo is strongly advocating a non-OO model that uses the command pattern to establish most of the rel

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-15 Thread Gleb Natapov
On Thu, Sep 15, 2011 at 04:14:45PM +0200, Paolo Bonzini wrote: > On 09/15/2011 03:57 PM, Anthony Liguori wrote: > > > >void generate_tree(Device *node) > >{ > >if (IS_PCI_BUS(node)) { > > for (i = 0; i < 32; i++) { > > generate_tree(lookup_device(get_property(node, "slot[%d]", i)

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-15 Thread Gleb Natapov
On Thu, Sep 15, 2011 at 08:17:13AM -0500, Anthony Liguori wrote: > On 09/15/2011 01:31 AM, Gleb Natapov wrote: > >On Wed, Sep 14, 2011 at 01:04:00PM -0500, Anthony Liguori wrote: > >>All device relationships are identified as named properties. A QOM > >>path name > >>consists of a named device, fo

Re: [Qemu-devel] Design of the blobstore

2011-09-15 Thread Stefan Berger
On 09/15/2011 07:40 AM, Kevin Wolf wrote: Am 15.09.2011 13:17, schrieb Stefan Hajnoczi: On Wed, Sep 14, 2011 at 6:05 PM, Stefan Berger wrote: One property of the blobstore is that it has a certain required size for accommodating all blobs of device that want to store their blobs onto. The a

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-15 Thread Anthony Liguori
On 09/15/2011 08:54 AM, Peter Maydell wrote: On 15 September 2011 14:35, Paolo Bonzini wrote: It still holds, for two reasons. 1) The properties will be named differently for ISA and PCI versions, which is at the very least ugly; 2) if you want to save the property names for the ISA version, y

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-15 Thread Paolo Bonzini
On 09/15/2011 03:57 PM, Anthony Liguori wrote: void generate_tree(Device *node) { if (IS_PCI_BUS(node)) { for (i = 0; i < 32; i++) { generate_tree(lookup_device(get_property(node, "slot[%d]", i))); } } else if (IS_ISA_BUS(node)) { } else { /

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-15 Thread Anthony Liguori
On 09/15/2011 08:43 AM, Jan Kiszka wrote: On 2011-09-15 00:11, Anthony Liguori wrote: On 09/14/2011 04:15 PM, Jan Kiszka wrote: On 2011-09-14 21:42, Anthony Liguori wrote: Such names can get fairly long I'm afraid... A user should never even see these names. A user probably will always inte

Re: [Qemu-devel] Design of the blobstore

2011-09-15 Thread Stefan Berger
On 09/15/2011 09:27 AM, Daniel P. Berrange wrote: On Thu, Sep 15, 2011 at 09:13:25AM -0400, Stefan Berger wrote: On 09/15/2011 09:05 AM, Daniel P. Berrange wrote: On Wed, Sep 14, 2011 at 01:05:44PM -0400, Stefan Berger wrote: Hello! Over the last few days primarily Michael Tsirkin and I ha

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-15 Thread Anthony Liguori
On 09/15/2011 01:31 AM, Gleb Natapov wrote: On Wed, Sep 14, 2011 at 01:04:00PM -0500, Anthony Liguori wrote: All device relationships are identified as named properties. A QOM path name consists of a named device, followed by a series of properties which may or may not refer to other devices.

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-15 Thread Peter Maydell
On 15 September 2011 14:35, Paolo Bonzini wrote: > It still holds, for two reasons.  1) The properties will be named > differently for ISA and PCI versions, which is at the very least ugly; 2) if > you want to save the property names for the ISA version, you need to > duplicate the logic in NE2000

Re: [Qemu-devel] Question on kvm_clock working ...

2011-09-15 Thread al pat
Hi Phil, Thanks for an excellent explanation. Follow up question - " ...additional clock source named "kvmclock", which uses the host clock and the TSC: The host exports its current system time (plus some configurable offset) and a snapshot value of TSC register when doing so. Than the guest can

Re: [Qemu-devel] [Bug 824650] [NEW] Latest GIT assert error in arp_table.c

2011-09-15 Thread Jan Kiszka
On 2011-09-15 15:20, Roy Tam wrote: > 2011/9/15 Jan Kiszka : >> On 2011-09-15 14:05, Roy Tam wrote: >>> Here you go. >>> >>> sb16: warning: command 0xf,1 is not truly understood yet >>> sb16: warning: command 0xe,2 is not truly understood yet >>> [Switching to Thread 13840.0x3140] >>> >>> Breakpoin

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-15 Thread Jan Kiszka
On 2011-09-15 00:11, Anthony Liguori wrote: > On 09/14/2011 04:15 PM, Jan Kiszka wrote: >> On 2011-09-14 21:42, Anthony Liguori wrote: Such names can get fairly long I'm afraid... >>> >>> A user should never even see these names. A user probably will always >>> interact with devices via paths

Re: [Qemu-devel] [PATCH] hid: vmstat fix

2011-09-15 Thread Gerd Hoffmann
On 09/14/11 09:59, Paolo Bonzini wrote: On 09/14/2011 09:40 AM, TeLeMan wrote: >> >> The commit "usb/hid: add hid_pointer_activate, use it" used >> HIDMouseState.mouse_grabbed in hid_pointer_activate(), so >> mouse_grabbed should be added into vmstat. > > Does this fix a bug? qemu_activate_mous

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-15 Thread Paolo Bonzini
On 09/15/2011 03:26 PM, Anthony Liguori wrote: class PciConnector : public PciDevice { // provides interfaces to register closures which implement // PCI abstract functions }; or actually even class PciConnector : Plug { PciBus *bus; uint8_t config_space[4096]; ... } The properti

Re: [Qemu-devel] Design of the blobstore

2011-09-15 Thread Daniel P. Berrange
On Thu, Sep 15, 2011 at 09:13:25AM -0400, Stefan Berger wrote: > On 09/15/2011 09:05 AM, Daniel P. Berrange wrote: > >On Wed, Sep 14, 2011 at 01:05:44PM -0400, Stefan Berger wrote: > >>Hello! > >> > >> Over the last few days primarily Michael Tsirkin and I have > >>discussed the design of the 'bl

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-15 Thread Anthony Liguori
On 09/15/2011 01:47 AM, Paolo Bonzini wrote: On 09/14/2011 08:04 PM, Anthony Liguori wrote: The concept of busses are implemented as an interface that a device implements. I noticed that you haven't written in the document how to make devices reside on a particular bus (PCI, ISA, I2C, ...). T

Re: [Qemu-devel] [Bug 824650] [NEW] Latest GIT assert error in arp_table.c

2011-09-15 Thread Roy Tam
2011/9/15 Jan Kiszka : > On 2011-09-15 14:05, Roy Tam wrote: >> Here you go. >> >> sb16: warning: command 0xf,1 is not truly understood yet >> sb16: warning: command 0xe,2 is not truly understood yet >> [Switching to Thread 13840.0x3140] >> >> Breakpoint 1, arp_table_search (slirp=0x19f7380, ip_add

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-15 Thread Anthony Liguori
On 09/15/2011 01:31 AM, Gleb Natapov wrote: On Wed, Sep 14, 2011 at 01:04:00PM -0500, Anthony Liguori wrote: All device relationships are identified as named properties. A QOM path name consists of a named device, followed by a series of properties which may or may not refer to other devices.

Re: [Qemu-devel] Design of the blobstore

2011-09-15 Thread Stefan Berger
On 09/15/2011 09:05 AM, Daniel P. Berrange wrote: On Wed, Sep 14, 2011 at 01:05:44PM -0400, Stefan Berger wrote: Hello! Over the last few days primarily Michael Tsirkin and I have discussed the design of the 'blobstore' via IRC (#virtualization). The intention of the blobstore is to provide

Re: [Qemu-devel] [RFC] Plan for moving forward with QOM

2011-09-15 Thread Anthony Liguori
On 09/15/2011 05:49 AM, Stefan Hajnoczi wrote: On Thu, Sep 15, 2011 at 7:31 AM, Gleb Natapov wrote: On Wed, Sep 14, 2011 at 01:04:00PM -0500, Anthony Liguori wrote: For isa machines: /isa/ide@0170/drive@0/disk@0 /isa/fdc@03f1/floppy@1 /isa/fdc@03f1/floppy@0 /isa/ide@0170/drive@0/disk@1 Yes, i

Re: [Qemu-devel] [Bug 824650] [NEW] Latest GIT assert error in arp_table.c

2011-09-15 Thread Jan Kiszka
On 2011-09-15 14:05, Roy Tam wrote: > Here you go. > > sb16: warning: command 0xf,1 is not truly understood yet > sb16: warning: command 0xe,2 is not truly understood yet > [Switching to Thread 13840.0x3140] > > Breakpoint 1, arp_table_search (slirp=0x19f7380, ip_addr=4294967295, > out_ethadd

Re: [Qemu-devel] Design of the blobstore

2011-09-15 Thread Daniel P. Berrange
On Wed, Sep 14, 2011 at 01:05:44PM -0400, Stefan Berger wrote: > Hello! > > Over the last few days primarily Michael Tsirkin and I have > discussed the design of the 'blobstore' via IRC (#virtualization). > The intention of the blobstore is to provide storage to persist > blobs that devices crea

Re: [Qemu-devel] [PATCH 1/2] KVM: emulate lapic tsc deadline timer for guest

2011-09-15 Thread Marcelo Tosatti
On Thu, Sep 15, 2011 at 02:22:58PM +0800, Liu, Jinsong wrote: > Marcelo Tosatti wrote: > >> diff --git a/arch/x86/include/asm/apicdef.h > >> b/arch/x86/include/asm/apicdef.h > >> index 34595d5..3925d80 100644 > >> --- a/arch/x86/include/asm/apicdef.h > >> +++ b/arch/x86/include/asm/apicdef.h > >>

Re: [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI

2011-09-15 Thread Paolo Bonzini
On 09/15/2011 02:34 PM, Orit Wasserman wrote: > Then you need an iSCSI*target* that understands qcow2, like qemu-nbd > but for iSCSI... that's exactly the thing you were worried about > implementing. Not really , this is just part of the target configuration. For each file in the chain we c

  1   2   >