[Qemu-devel] [PATCH 1/1] Fix typo for qmp-commands.hx. Signed-off-by: Zhi Yong Wu

2011-07-26 Thread Zhi Yong Wu
--- qmp-commands.hx |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qmp-commands.hx b/qmp-commands.hx index 92c5c3a..d7352ae 100644 --- a/qmp-commands.hx +++ b/qmp-commands.hx @@ -42,7 +42,7 @@ and we're going to establish a deprecation policy for badly defined commands.

[Qemu-devel] [PATCH 0/1] qmp: fix typo for qmp-commands.hx

2011-07-26 Thread Zhi Yong Wu
In qmp-commands.hx, there exists a typo, and it will be fixed by this patch. Zhi Yong Wu (1): Fix typo for qmp-commands.hx. Signed-off-by: Zhi Yong Wu qmp-commands.hx |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- 1.7.2.3

Re: [Qemu-devel] [PATCH 6/6] scsi-disk: Check for supported commands

2011-07-26 Thread Markus Armbruster
Christoph Hellwig writes: > On Fri, Jul 22, 2011 at 04:51:17PM +0200, Hannes Reinecke wrote: >> Not every command is support for any device type. This patch adds >> a check for rejecting unsupported commands. >> >> Signed-off-by: Hannes Reinecke > > This seems to conflic with Markus' series. B

Re: [Qemu-devel] [PATCH 1/2] Makefile: distclean should clean all possible targets

2011-07-26 Thread Markus Armbruster
Alexandre Raymond writes: > Hi Markus, > >> Well, I'd expect distclean to remove exactly what *this* makefile can >> build, and leave everything else alone. > > I was expecting "distclean" to bring back the source directory to > however it was after checkout, removing anything that might have bee

Re: [Qemu-devel] [PATCH] virtio-serial-bus: replay guest_open on migration

2011-07-26 Thread Markus Armbruster
Alon Levy writes: > Signed-off-by: Alon Levy > --- > hw/virtio-serial-bus.c |8 +++- > 1 files changed, 7 insertions(+), 1 deletions(-) > > diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c > index c5eb931..7a652ff 100644 > --- a/hw/virtio-serial-bus.c > +++ b/hw/virtio-seria

[Qemu-devel] [Bug 816370] Re: compile error in QEMU 0.15.0-rc0

2011-07-26 Thread rowa
I've changed the file error.h. But I get the same error again. :-( diff error.h-original error.h 12,13c12,13 < #ifndef ERROR_H < #define ERROR_H --- > #ifndef ERROR_OBJ_H > #define ERROR_OBJ_H Thanks -- You received this bug notification because you are a member of qemu- devel-ml, which is subs

[Qemu-devel] [PATCH] Fix configure display for non-Linux OS's and the KVM / vhost-net features to show "no"

2011-07-26 Thread Brad
Fix configure display for non-Linux OS's and the KVM / vhost-net features to show "no" output instead of nothing at the end of the line. Signed-off-by: Brad Smith --- configure |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index dc9a1fe..ef8a4

Re: [Qemu-devel] 0.15.0 Testing volunteers

2011-07-26 Thread Zhi Yong Wu
HI, stefan, For networking and migration areas, is there any new feature to be tested? If yes, can i be their testing volunteer? If QMP has not a voluntter, i would like also to do some testings for it. What is the deadline for 0.15.rc0 testing? Regards, Zhiyong Wu On Tue, Jul 26, 2011 at 11

[Qemu-devel] [PATCH] [RFC] Add glib support to main loop

2011-07-26 Thread Anthony Liguori
This allows GSources to be used to register callback events in QEMU. This is useful as it allows us to take greater advantage of glib and also because it allows us to write code that is more easily testable outside of QEMU since we can make use of glib's main loop in unit tests. All new code shou

Re: [Qemu-devel] [RFC PATCH 0/4] Fix subsection ambiguity in the migration format

2011-07-26 Thread Anthony Liguori
On 07/26/2011 05:22 PM, Peter Maydell wrote: On 26 July 2011 22:46, Anthony Liguori wrote: [This is a bit random-sniping at minor points because I'm still thinking about the big-picture bits] So we never actually walk the VMState tables to do anything. The unconverted purely imperative routi

Re: [Qemu-devel] [RFC PATCH 0/4] Fix subsection ambiguity in the migration format

2011-07-26 Thread Peter Maydell
On 26 July 2011 22:46, Anthony Liguori wrote: [This is a bit random-sniping at minor points because I'm still thinking about the big-picture bits] > So we never actually walk the VMState tables to do anything.  The > unconverted purely imperative routines we just convert to use marshal to a > Vi

Re: [Qemu-devel] [PATCH 04/25] Add hard build dependency on glib

2011-07-26 Thread Yoder Stuart-B08248
> From: Anthony Liguori > > GLib is an extremely common library that has a portable thread implementation > along with tons of other goodies. > > GLib and GObject have a fantastic amount of infrastructure we can leverage in > QEMU including an object oriented programming infrastructure. > > Sho

Re: [Qemu-devel] [PATCH 04/25] Add hard build dependency on glib

2011-07-26 Thread Anthony Liguori
On 07/26/2011 04:51 PM, Yoder Stuart-B08248 wrote: I am having issues with this in a cross compilation environment. In Power embedded, almost all our development is using cross toolchains. Neither glib or pkg-config are in our cross build environment and I'm having issues getting them built a

Re: [Qemu-devel] [PATCH] lm32: softusb: claim to support full speed

2011-07-26 Thread Michael Walle
Hi Anthony, could you please apply this patch to the 0.15 (and master) branch. Am Donnerstag 21 Juli 2011, 20:52:24 schrieb Michael Walle: > The QEMU keyboard and mouse reports themselves as full speed devices, > though they are actually low speed devices. Until this is fixed, claim that > we a

Re: [Qemu-devel] [RFC PATCH 0/4] Fix subsection ambiguity in the migration format

2011-07-26 Thread Anthony Liguori
On 07/26/2011 03:13 PM, Juan Quintela wrote: Anthony Liguori wrote: On 07/26/2011 07:07 AM, Juan Quintela wrote: - Be able to describe that different features/versions. This is not the difficult part, it can be subsections, optional fields, whatever. What is the difficult part is _k

Re: [Qemu-devel] [PATCH 1/1] block/vpc.c: Detect too-large vpc file

2011-07-26 Thread Serge E. Hallyn
Quoting Kevin Wolf (kw...@redhat.com): > Am 26.07.2011 18:08, schrieb Serge E. Hallyn: > > Quoting Kevin Wolf (kw...@redhat.com): > >> Am 25.07.2011 20:34, schrieb Serge E. Hallyn: > >>> VHD files technically can be up to 2Tb, but virtual pc is limited > >>> to 127G. Currently qemu-img refused to

Re: [Qemu-devel] [RFC PATCH 0/4] Fix subsection ambiguity in the migration format

2011-07-26 Thread Juan Quintela
Anthony Liguori wrote: > On 07/26/2011 07:07 AM, Juan Quintela wrote: >> I will change this to: >> - We need to be able to "enable/disable" features of a device. >>A.K.A. make -M pc-0.14 work with devices with the same features >>than 0.14. Notice that this is _independent_ of migration.

[Qemu-devel] SAECO Royal Büromaschinen / Kaffee und Klimaanlagen sind auf eevad Discount

2011-07-26 Thread Estelle - eevad.de
SAECO Royal Macchine per ufficio / caffè e condizionatori d'aria sono scontati su eevad! In base alle informazioni e al diritto Libertà, avete il diritto di accedere, modificare e cancellare i dati che vi riguardano (art. 34 della informazione e delle libertà). Se non si desidera ricevere email

Re: [Qemu-devel] [PATCH v2 1/1] The codes V2 for QEMU disk I/O limits.

2011-07-26 Thread Marcelo Tosatti
On Tue, Jul 26, 2011 at 04:59:06PM +0800, Zhi Yong Wu wrote: > Welcome to give me your comments, thanks. > > Signed-off-by: Zhi Yong Wu > --- > Makefile.objs |2 +- > block.c | 288 > +++-- > block.h |1 - > block/

Re: [Qemu-devel] [RFC][PATCH 0/21] QEMU Object Model

2011-07-26 Thread Anthony Liguori
On 07/26/2011 01:26 PM, Paolo Bonzini wrote: On 07/26/2011 05:34 PM, Anthony Liguori wrote: And as such it can add data members. But when a device is on two buses, you cannot have both of them adding data members. I know MI is hard to get right, and in fact I'm not proposing to do MI---not even

Re: [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-07-26 Thread Corey Bryant
On 07/26/2011 01:10 PM, Alexander Graf wrote: On 26.07.2011, at 18:57, Corey Bryant wrote: > > Kevin, thanks for the input. > > On 07/26/2011 11:18 AM, Kevin Wolf wrote: >> Am 26.07.2011 14:51, schrieb Corey Bryant: >>> >sVirt provides SELinux MAC isolation for Qemu guest processes

Re: [Qemu-devel] [Bug 816370] Re: compile error in QEMU 0.15.0-rc0

2011-07-26 Thread Michael Roth
On 07/26/2011 12:02 PM, rowa wrote: I've tryed to compile this on qemu.git origin/master with the same error: git clone git://git.qemu.org/qemu.git qemu.git cd qemu.git ./configure --prefix=/usr --enable-spice --audio-card-list=ac97,es1370,sb16,adlib,gus,cs4231a&& make ... CCqapi/qapi-v

Re: [Qemu-devel] [PATCH] Makefile: add missing deps on $(GENERATED_HEADERS)

2011-07-26 Thread Stefan Berger
On 07/26/2011 12:39 PM, Michael Roth wrote: This fixes a build issue with make -j6+ due to qapi-generated files being built before $(GENERATED_HEADERS) have been created. Signed-off-by: Michael Roth Tested-by: Stefan Berger --- Makefile |4 +++- 1 files changed, 3 insertions(+), 1 del

Re: [Qemu-devel] [RFC][PATCH 0/21] QEMU Object Model

2011-07-26 Thread Paolo Bonzini
On 07/26/2011 05:34 PM, Anthony Liguori wrote: And as such it can add data members. But when a device is on two buses, you cannot have both of them adding data members. I know MI is hard to get right, and in fact I'm not proposing to do MI---not even interface inheritance. I don't want to have an

Re: [Qemu-devel] [PATCH v2 0/4] omap_gpio: convert to qdev

2011-07-26 Thread Peter Maydell
Ping? (added back the CCs that qemu-devel seems to have stripped out...) On 8 July 2011 17:56, Peter Maydell wrote: > These patches are changes from the meego omap3 tree which convert > the omap GPIO module device to use qdev. > > Changes v1->v2: >  * renamed omap_l4_base() to omap_l4_region_bas

[Qemu-devel] [Bug 814222] Re: kvm cannot use vhd files over 127GB

2011-07-26 Thread Brian Murray
** Tags added: patch -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/814222 Title: kvm cannot use vhd files over 127GB Status in QEMU: New Status in “qemu-kvm” package in Ubuntu: Triaged Bug de

[Qemu-devel] Invitation to connect on LinkedIn

2011-07-26 Thread Yonghong Yan via LinkedIn
LinkedIn Yonghong Yan requested to add you as a connection on LinkedIn: -- Jiajun, I'd like to add you to my professional network on LinkedIn. - Yonghong Accept invitation from Yonghong Yan http://www.linkedin.com/e/-kkb1ec-gql4vhj

[Qemu-devel] [Bug 816370] Re: compile error in QEMU 0.15.0-rc0

2011-07-26 Thread rowa
I've tryed to compile this on qemu.git origin/master with the same error: git clone git://git.qemu.org/qemu.git qemu.git cd qemu.git ./configure --prefix=/usr --enable-spice --audio-card-list=ac97,es1370,sb16,adlib,gus,cs4231a && make ... CCqapi/qapi-visit-core.o In file included from qapi/

Re: [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-07-26 Thread Alexander Graf
On 26.07.2011, at 18:57, Corey Bryant wrote: > > Kevin, thanks for the input. > > On 07/26/2011 11:18 AM, Kevin Wolf wrote: >> Am 26.07.2011 14:51, schrieb Corey Bryant: >>> > sVirt provides SELinux MAC isolation for Qemu guest processes and their >>> > corresponding resources (image files).

Re: [Qemu-devel] QEMU 0.15.0-rc0, stable-0.15, and QEMU 1.0

2011-07-26 Thread Brad
On 23/07/11 1:15 PM, Anthony Liguori wrote: Hi, I've forked off the stable branch and tagged qemu-0.15.0-rc0 in the master repository. Please begin explicitly marking patches meant for stable as [STABLE] and CC Justin. I'm not sure if this is an appropriate way of asking for commits to be merg

Re: [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-07-26 Thread Corey Bryant
Kevin, thanks for the input. On 07/26/2011 11:18 AM, Kevin Wolf wrote: Am 26.07.2011 14:51, schrieb Corey Bryant: > sVirt provides SELinux MAC isolation for Qemu guest processes and their > corresponding resources (image files). sVirt provides this support > by labeling guests and resources

[Qemu-devel] [PATCH] Makefile: add missing deps on $(GENERATED_HEADERS)

2011-07-26 Thread Michael Roth
This fixes a build issue with make -j6+ due to qapi-generated files being built before $(GENERATED_HEADERS) have been created. Signed-off-by: Michael Roth --- Makefile |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index daa3aa0..0a31633 100644 --

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Makefile: Fix parallel building after a clean tree

2011-07-26 Thread Michael Roth
On 07/26/2011 09:33 AM, Stefan Berger wrote: This patch fixes a compilation error when building qemu after 'make clean' by parallel building using 'make -j6' for example. A dependency seems to be missing. GEN qemu-options.def GEN trace.h GEN qapi-generated/qga-qapi-types.h GEN

[Qemu-devel] [PATCH 2/2] [SLIRP] Delayed IP packets

2011-07-26 Thread Fabien Chouteau
In the current implementation, if Slirp tries to send an IP packet to a client with an unknown hardware address, the packet is simply dropped and an ARP request is sent (if_encap in slirp/slirp.c). This patch adds a list of delayed IP packets to handle such cases. If the hardware address is unknow

[Qemu-devel] [PATCH 1/2] [SLIRP] Simple ARP table

2011-07-26 Thread Fabien Chouteau
This patch adds a simple ARP table in Slirp and also adds handling of gratuitous ARP requests. Signed-off-by: Fabien Chouteau --- Makefile.objs |2 +- slirp/arp_table.c | 61 +++ slirp/bootp.c | 15 ++- slirp/slirp.c | 68

Re: [Qemu-devel] [PATCH 1/1] block/vpc.c: Detect too-large vpc file

2011-07-26 Thread Kevin Wolf
Am 26.07.2011 18:08, schrieb Serge E. Hallyn: > Quoting Kevin Wolf (kw...@redhat.com): >> Am 25.07.2011 20:34, schrieb Serge E. Hallyn: >>> VHD files technically can be up to 2Tb, but virtual pc is limited >>> to 127G. Currently qemu-img refused to create vpc files > 127G, >>> but it is failing to

Re: [Qemu-devel] [PATCH 1/1] block/vpc.c: Detect too-large vpc file

2011-07-26 Thread Serge E. Hallyn
Quoting Kevin Wolf (kw...@redhat.com): > Am 25.07.2011 20:34, schrieb Serge E. Hallyn: > > VHD files technically can be up to 2Tb, but virtual pc is limited > > to 127G. Currently qemu-img refused to create vpc files > 127G, > > but it is failing to return error when converting from a non-vpc > >

Re: [Qemu-devel] [PATCH v2 04/23] memory: merge adjacent segments of a single memory region

2011-07-26 Thread Avi Kivity
On 07/26/2011 06:41 PM, Richard Henderson wrote: On 07/26/2011 04:36 AM, Paolo Bonzini wrote: > On 07/26/2011 01:26 PM, Avi Kivity wrote: >> +while (i< view->nr) { >> +j = i + 1; >> +while (j< view->nr >> +&& can_merge(&view->ranges[j-1],&view->ranges[j])) { >> +

Re: [Qemu-devel] [Bug 816370] [NEW] compile error in QEMU 0.15.0-rc0

2011-07-26 Thread Michael Roth
On 07/26/2011 06:28 AM, rowa wrote: Public bug reported: I've tryed to compile QEMU 0.15.0-rc0 on Ubuntu 10.10 „Maverick Meerkat“ but I get an error (For further details please see http://qemu- buch.de/d/Installation#Quellen_kompilieren ). ./configure --prefix=/usr --enable-spice --audio-card

[Qemu-devel] 0.15.0 Testing volunteers

2011-07-26 Thread Stefan Hajnoczi
Please test the target, host, subsystem, and/or feature that matters to you for QEMU 0.15.0. The following wiki page is aimed to keep track of what was tested and whether it passed: http://wiki.qemu.org/Planning/0.15/Testing Stefan

Re: [Qemu-devel] [PATCH v2 04/23] memory: merge adjacent segments of a single memory region

2011-07-26 Thread Richard Henderson
On 07/26/2011 04:36 AM, Paolo Bonzini wrote: > On 07/26/2011 01:26 PM, Avi Kivity wrote: >> +while (i < view->nr) { >> +j = i + 1; >> +while (j < view->nr >> + && can_merge(&view->ranges[j-1], &view->ranges[j])) { >> +view->ranges[i].addr.size += view->

Re: [Qemu-devel] [PATCH 2/3] Introduce a 'client_add' monitor command accepting an open FD

2011-07-26 Thread Fabien Chouteau
On 26/07/2011 17:29, Daniel P. Berrange wrote: > On Tue, Jul 26, 2011 at 05:20:16PM +0200, Fabien Chouteau wrote: >> On 23/06/2011 14:31, Daniel P. Berrange wrote: >>> Allow client connections for VNC and socket based character >>> devices to be passed in over the monitor using SCM_RIGHTS. >>> >> >

Re: [Qemu-devel] [RFC][PATCH 0/21] QEMU Object Model

2011-07-26 Thread Anthony Liguori
On 07/26/2011 09:35 AM, Paolo Bonzini wrote: On 07/26/2011 04:02 PM, Anthony Liguori wrote: Also because there is no hierarchy, composition in host devices can be done very easily. A decorator for char/block devices, such as a "tee" device, can treat the wrapped object(s) the same independent of

Re: [Qemu-devel] [PATCH 2/3] Introduce a 'client_add' monitor command accepting an open FD

2011-07-26 Thread Daniel P. Berrange
On Tue, Jul 26, 2011 at 05:20:16PM +0200, Fabien Chouteau wrote: > On 23/06/2011 14:31, Daniel P. Berrange wrote: > > Allow client connections for VNC and socket based character > > devices to be passed in over the monitor using SCM_RIGHTS. > > > > Hello Daniel, > > I'm a little bit late but it

Re: [Qemu-devel] [PATCH 2/3] Introduce a 'client_add' monitor command accepting an open FD

2011-07-26 Thread Fabien Chouteau
On 23/06/2011 14:31, Daniel P. Berrange wrote: > Allow client connections for VNC and socket based character > devices to be passed in over the monitor using SCM_RIGHTS. > Hello Daniel, I'm a little bit late but it seems that there's a build error with this patch when VNC is disabled. $./config

Re: [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-07-26 Thread Kevin Wolf
Am 26.07.2011 14:51, schrieb Corey Bryant: > sVirt provides SELinux MAC isolation for Qemu guest processes and their > corresponding resources (image files). sVirt provides this support > by labeling guests and resources with security labels that are stored > in file system extended attributes. Som

Re: [Qemu-devel] [PATCH 1/2] xen_mapcache: remove unused variable

2011-07-26 Thread Stefan Berger
On 07/11/2011 12:15 PM, Juan Quintela wrote: Signed-off-by: Juan Quintela Signed-off-by: Stefan Berger Been pointed to this patch after having posted the same. Stefan --- xen-mapcache.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/xen-mapcache.c b/xen-map

Re: [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-07-26 Thread Kevin Wolf
Am 26.07.2011 16:46, schrieb Corey Bryant: > > On 07/26/2011 10:05 AM, Kevin Wolf wrote: >> Am 26.07.2011 15:02, schrieb Christoph Hellwig: I have to say I really hate it. We've been working hard on getting rid of special cases in the qemu block layer, and this sprinkles them all

Re: [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-07-26 Thread Corey Bryant
On 07/26/2011 10:05 AM, Kevin Wolf wrote: Am 26.07.2011 15:02, schrieb Christoph Hellwig: > I have to say I really hate it. We've been working hard on getting rid > of special cases in the qemu block layer, and this sprinkles them all > over. I'd recommend to fix your security model instea

Re: [Qemu-devel] [PATCH] Fix a compilation error in xen-mapcache.c

2011-07-26 Thread Stefan Berger
On 07/26/2011 10:38 AM, Peter Maydell wrote: On 26 July 2011 15:33, Stefan Berger wrote: This patch fixes a compilation error in xen-mapcache.c . /home/stefanb/qemu/qemu-git/xen-mapcache.c: In function ‘xen_ram_addr_from_mapcache’: /home/stefanb/qemu/qemu-git/xen-mapcache.c:240:42: error: var

Re: [Qemu-devel] [PATCH] Fix a compilation error in xen-mapcache.c

2011-07-26 Thread Peter Maydell
On 26 July 2011 15:33, Stefan Berger wrote: > This patch fixes a compilation error in xen-mapcache.c . > > /home/stefanb/qemu/qemu-git/xen-mapcache.c: In function > ‘xen_ram_addr_from_mapcache’: > /home/stefanb/qemu/qemu-git/xen-mapcache.c:240:42: error: variable ‘pentry’ > set but not used [-We

[Qemu-devel] [PATCH] Makefile: Fix parallel building after a clean tree

2011-07-26 Thread Stefan Berger
This patch fixes a compilation error when building qemu after 'make clean' by parallel building using 'make -j6' for example. A dependency seems to be missing. GEN qemu-options.def GEN trace.h GEN qapi-generated/qga-qapi-types.h GEN qapi-generated/qga-qapi-visit.h GEN qapi-gen

Re: [Qemu-devel] [RFC][PATCH 0/21] QEMU Object Model

2011-07-26 Thread Paolo Bonzini
On 07/26/2011 04:02 PM, Anthony Liguori wrote: Also because there is no hierarchy, composition in host devices can be done very easily. A decorator for char/block devices, such as a "tee" device, can treat the wrapped object(s) the same independent of the actual class. A simple vtable works very

[Qemu-devel] [PATCH] Fix a compilation error in xen-mapcache.c

2011-07-26 Thread Stefan Berger
This patch fixes a compilation error in xen-mapcache.c . /home/stefanb/qemu/qemu-git/xen-mapcache.c: In function ‘xen_ram_addr_from_mapcache’: /home/stefanb/qemu/qemu-git/xen-mapcache.c:240:42: error: variable ‘pentry’ set but not used [-Werror=unused-but-set-variable] cc1: all warnings being tr

Re: [Qemu-devel] qemu crashes on Mac OS X

2011-07-26 Thread Alexandre Raymond
On Tue, Jul 26, 2011 at 9:08 AM, Alexandre Raymond wrote: > Indeed, I'd come to the exact same conclusion, yet I've witnessed it > both in the debugger and with trace messages... > > Alexandre Note that I don't think that this is a proper patch. I simply want to verify that it solves the issue enc

Re: [Qemu-devel] idea: non-ethernet paravirtual network device

2011-07-26 Thread Sassan Panahinejad
Ok, thanks guys. I don't think I'll proceed with this idea. Thanks Sassan On 26 July 2011 11:23, Hannes Reinecke wrote: > On 07/26/2011 08:04 AM, Stefan Hajnoczi wrote: > >> On Mon, Jul 25, 2011 at 4:53 PM, Sassan >> Panahinejad> >> wrote: >> >>> Here's a thought, could we improve network per

Re: [Qemu-devel] [PATCH 09/10] posix-aio-compat: Allow read after EOF

2011-07-26 Thread Kevin Wolf
Am 26.07.2011 15:55, schrieb Frediano Ziglio: > 2011/7/26 Kevin Wolf : >> In order to be able to transparently replace bdrv_read calls by bdrv_co_read, >> reading beyond EOF must produce zeros instead of short reads for AIO, too. >> >> Signed-off-by: Kevin Wolf >> --- >> posix-aio-compat.c | 19

Re: [Qemu-devel] [PATCH 6/6] scsi-disk: Check for supported commands

2011-07-26 Thread Hannes Reinecke
On 07/26/2011 03:46 PM, Kevin Wolf wrote: Am 22.07.2011 16:51, schrieb Hannes Reinecke: Not every command is support for any device type. This patch adds a check for rejecting unsupported commands. Signed-off-by: Hannes Reinecke We do emulate SEEK (6), but it's not in your scsi_cmd_table at a

Re: [Qemu-devel] [libvirt] [PATCH v3] Add support for fd: protocol

2011-07-26 Thread Kevin Wolf
Am 26.07.2011 16:00, schrieb Eric Blake: > On 07/26/2011 06:51 AM, Corey Bryant wrote: >> There are some additional features provided by certain image types >> where Qemu reopens the image file. All of these scenarios will be >> unsupported for the fd: protocol, at least for this patch: >> >>-

Re: [Qemu-devel] [PATCH 52/55] block: Move BlockDriverAIOCB & friends from block_int.h to block.h

2011-07-26 Thread Markus Armbruster
Christoph Hellwig writes: > On Wed, Jul 20, 2011 at 06:24:26PM +0200, Markus Armbruster wrote: >> Device models should be able to use them without an unclean include of >> block_int.h. > > I don't think so. In generall they aren't for use of device models at > all. It's just that the IDE trim s

Re: [Qemu-devel] [PATCH 49/55] block: Declare qemu_blockalign() in block.h, not block_int.h

2011-07-26 Thread Markus Armbruster
Christoph Hellwig writes: > On Wed, Jul 20, 2011 at 06:24:23PM +0200, Markus Armbruster wrote: >> Device models should be able to use it without an unclean include of >> block_int.h. > > Hmm. We already do proper read-modify-write cycles for actual data > transfers, so killing the buffer inside

Re: [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-07-26 Thread Kevin Wolf
Am 26.07.2011 15:02, schrieb Christoph Hellwig: > I have to say I really hate it. We've been working hard on getting rid > of special cases in the qemu block layer, and this sprinkles them all > over. I'd recommend to fix your security model instead. I think the problem here is more with the imp

Re: [Qemu-devel] [RFC][PATCH 0/21] QEMU Object Model

2011-07-26 Thread Anthony Liguori
On 07/26/2011 07:59 AM, Paolo Bonzini wrote: For host devices (Char/Block/Network) we have a relatively simple interface but we need a richer way to create and destroy the objects at runtime. We have it already for block and network, we don't for char, but it is done ad hoc for each hierarchy. We

Re: [Qemu-devel] [libvirt] [PATCH v3] Add support for fd: protocol

2011-07-26 Thread Eric Blake
On 07/26/2011 07:02 AM, Christoph Hellwig wrote: I have to say I really hate it. We've been working hard on getting rid of special cases in the qemu block layer, and this sprinkles them all over. I'd recommend to fix your security model instead. What is it that you hate - the particular qemu

Re: [Qemu-devel] [PATCH v5 01/18] Add hard build dependency on glib

2011-07-26 Thread Kenneth Salerno
From: Michael Roth Subject:[Qemu-devel] [PATCH v5 01/18] Add hard build dependency on glib Date: Tue, 5 Jul 2011 08:02:28 -0500 > From: Anthony Liguori > > GLib is an extremely common library that has a portable thread implementation > along with tons of other goodies. > > GLib and GO

Re: [Qemu-devel] [libvirt] [PATCH v3] Add support for fd: protocol

2011-07-26 Thread Eric Blake
On 07/26/2011 06:51 AM, Corey Bryant wrote: There are some additional features provided by certain image types where Qemu reopens the image file. All of these scenarios will be unsupported for the fd: protocol, at least for this patch: - The -snapshot command line option - The savevm monit

Re: [Qemu-devel] [PATCH 09/10] posix-aio-compat: Allow read after EOF

2011-07-26 Thread Frediano Ziglio
2011/7/26 Kevin Wolf : > In order to be able to transparently replace bdrv_read calls by bdrv_co_read, > reading beyond EOF must produce zeros instead of short reads for AIO, too. > > Signed-off-by: Kevin Wolf > --- >  posix-aio-compat.c |   19 +++ >  1 files changed, 19 insertions

Re: [Qemu-devel] [PATCH 1/2] Makefile: distclean should clean all possible targets

2011-07-26 Thread Alexandre Raymond
Hi Markus, > Well, I'd expect distclean to remove exactly what *this* makefile can > build, and leave everything else alone. I was expecting "distclean" to bring back the source directory to however it was after checkout, removing anything that might have been created by the build/configure proce

Re: [Qemu-devel] [PATCH 0/6][v2] Check for supported SCSI commands

2011-07-26 Thread Kevin Wolf
Am 22.07.2011 16:51, schrieb Hannes Reinecke: > Markus Armbruster pointed out that not every SCSI command is supported > for a given device type. Based on his patch and suggestiongs this series > cleans up the SCSI device type and adds a check for supported commands. > > Hannes Reinecke (6): > s

Re: [Qemu-devel] [PATCH 33/55] ide/atapi: Avoid physical/virtual tray state mismatch

2011-07-26 Thread Markus Armbruster
Christoph Hellwig writes: > On Wed, Jul 20, 2011 at 06:24:07PM +0200, Markus Armbruster wrote: >> When ide-cd is backed by a physical drive, we want the physical tray >> match the virtual one. To that end, we call bdrv_eject() on guest's >> load/eject, and bdrv_lock_medium() on guest's prevent/a

Re: [Qemu-devel] [PATCH 6/6] scsi-disk: Check for supported commands

2011-07-26 Thread Kevin Wolf
Am 22.07.2011 16:51, schrieb Hannes Reinecke: > Not every command is support for any device type. This patch adds > a check for rejecting unsupported commands. > > Signed-off-by: Hannes Reinecke We do emulate SEEK (6), but it's not in your scsi_cmd_table at all. > --- > hw/scsi-disk.c | 104

Re: [Qemu-devel] [PATCH 27/55] scsi-disk: Switch from BlockDriverState's locked to own tray_locked

2011-07-26 Thread Markus Armbruster
Christoph Hellwig writes: > On Wed, Jul 20, 2011 at 06:24:01PM +0200, Markus Armbruster wrote: >> >> Signed-off-by: Markus Armbruster > > > Looks good, although I would have merged it into the previous one. I'll consider squashing when I respin.

Re: [Qemu-devel] [PATCH 18/55] scsi-disk: Reject CD-specific SCSI commands to disks

2011-07-26 Thread Markus Armbruster
Christoph Hellwig writes: > On Wed, Jul 20, 2011 at 06:23:52PM +0200, Markus Armbruster wrote: >> Use a table to declare which drive kinds accept each command. >> >> Limit READ_CAPACITY, READ_TOC, GET_CONFIGURATION to SCSI_CD, as per >> SPC-4. > > READ CAPACITY is defined in SBC, and absolutely

Re: [Qemu-devel] [PATCH 17/55] ide/atapi: Switch from BlockDriverState's tray_open to own

2011-07-26 Thread Markus Armbruster
Christoph Hellwig writes: > On Wed, Jul 20, 2011 at 06:23:51PM +0200, Markus Armbruster wrote: >> >> Signed-off-by: Markus Armbruster > > Looks good, although I would have folded this patch into the previous > one. I'll consider squashing when I respin.

Re: [Qemu-devel] [PATCH 12/55] ide: Fix ATA command READ to set ATAPI signature for CD-ROM

2011-07-26 Thread Markus Armbruster
Christoph Hellwig writes: > On Wed, Jul 20, 2011 at 06:23:46PM +0200, Markus Armbruster wrote: >> Must set the ATAPI device signature, see ACS-2 7.36.6 Outputs for >> PACKET feature set devices. > > Odd but true, even if it's 7.38.2 in my local copy of the ACS spec. > > It defintively should be d

Re: [Qemu-devel] [PATCH 6/6] scsi-disk: Check for supported commands

2011-07-26 Thread Christoph Hellwig
On Fri, Jul 22, 2011 at 04:51:17PM +0200, Hannes Reinecke wrote: > Not every command is support for any device type. This patch adds > a check for rejecting unsupported commands. > > Signed-off-by: Hannes Reinecke This seems to conflic with Markus' series. But if we want to invest any major eff

[Qemu-devel] [PATCH v2 19/23] pc: move global memory map out of pc_init1() and into its callers

2011-07-26 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/pc_piix.c | 15 --- 1 files changed, 8 insertions(+), 7 deletions(-) diff --git a/hw/pc_piix.c b/hw/pc_piix.c index d83854c..f2d0476 100644 --- a/hw/pc_piix.c +++ b/hw/pc_piix.c @@ -68,7 +68,8 @@ static void ioapic_init(IsaIrqState *isa_irq_state)

[Qemu-devel] [PATCH 06/10] qcow: Use coroutines

2011-07-26 Thread Kevin Wolf
The old qcow format is another user of the AsyncContext infrastructure. Converting it to coroutines (and therefore CoMutexes) allows to remove AsyncContexts. Signed-off-by: Kevin Wolf --- block/qcow.c | 180 -- 1 files changed, 62 insertio

[Qemu-devel] [PATCH v2 13/23] memory: separate building the final memory map into two steps

2011-07-26 Thread Avi Kivity
Instead of adding and deleting regions in one pass, do a delete pass followed by an add pass. This fixes the following case: from: 0x-0x0fff ram (a1) 0x1000-0x1fff mmio (a2) 0x2000-0x2fff ram (a3) to: 0x-0x2fff ram (b1) The single pass algorithm removed a1, added b2, then rem

Re: [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-07-26 Thread Corey Bryant
On 07/26/2011 09:02 AM, Christoph Hellwig wrote: I have to say I really hate it. We've been working hard on getting rid of special cases in the qemu block layer, and this sprinkles them all over. I'd recommend to fix your security model instead. I understand your point on special casing. T

Re: [Qemu-devel] [PATCH 6/6] scsi-disk: Check for supported commands

2011-07-26 Thread Hannes Reinecke
On 07/26/2011 03:07 PM, Kevin Wolf wrote: Am 22.07.2011 16:51, schrieb Hannes Reinecke: Not every command is support for any device type. This patch adds a check for rejecting unsupported commands. Signed-off-by: Hannes Reinecke --- hw/scsi-disk.c | 104 ++

[Qemu-devel] [PATCH v2 03/23] memory: implement dirty tracking

2011-07-26 Thread Avi Kivity
Currently dirty tracking is implemented by passing through all calls to the underlying cpu_physical_memory_*() calls. Reviewed-by: Anthony Liguori Signed-off-by: Avi Kivity --- memory.c | 39 +++ memory.h |1 + 2 files changed, 32 insertions(+), 8 delet

[Qemu-devel] [PATCH 04/10] coroutines: Locks

2011-07-26 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- Makefile.objs |2 +- qemu-coroutine-int.h |1 + qemu-coroutine-lock.c | 124 + qemu-coroutine.h | 64 + trace-events |8 +++ 5 files changed, 198 insertions(

[Qemu-devel] [PATCH v2 23/23] usb-ohci: convert to MemoryRegion

2011-07-26 Thread Avi Kivity
Reviewed-by: Anthony Liguori Signed-off-by: Avi Kivity --- hw/usb-ohci.c | 42 +- 1 files changed, 17 insertions(+), 25 deletions(-) diff --git a/hw/usb-ohci.c b/hw/usb-ohci.c index 8491d59..337b250 100644 --- a/hw/usb-ohci.c +++ b/hw/usb-ohci.c @@ -62,

[Qemu-devel] [PATCH v2 00/23] Memory API, batch 1

2011-07-26 Thread Avi Kivity
This patchset contains the core of the memory API, with one device (usb-ohci) coverted for reference. The API is currently implemented on top of the old ram_addr_t/cpu_register_physical_memory() API, but the plan is to make it standalone later. The goals of the API are: - correctness: by modelli

Re: [Qemu-devel] qemu crashes on Mac OS X

2011-07-26 Thread Alexandre Raymond
Indeed, I'd come to the exact same conclusion, yet I've witnessed it both in the debugger and with trace messages... Alexandre On Tue, Jul 26, 2011 at 4:46 AM, Paolo Bonzini wrote: > On 07/26/2011 06:58 AM, Alexandre Raymond wrote: >> +#ifdef __APPLE__ >> +            if (sig == 0) continue; >>

[Qemu-devel] [PATCH 09/10] posix-aio-compat: Allow read after EOF

2011-07-26 Thread Kevin Wolf
In order to be able to transparently replace bdrv_read calls by bdrv_co_read, reading beyond EOF must produce zeros instead of short reads for AIO, too. Signed-off-by: Kevin Wolf --- posix-aio-compat.c | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/po

Re: [Qemu-devel] [PATCH 55/55] ide/atapi scsi-disk: Make monitor eject -f, then change work

2011-07-26 Thread Christoph Hellwig
On Wed, Jul 20, 2011 at 06:24:29PM +0200, Markus Armbruster wrote: > change fails while the tray is locked by the guest. eject -f forces > it open and removes any media. Unfortunately, the tray closes again > instantly. Since the lock remains as it is, there is no way to insert > another medium

Re: [Qemu-devel] [PATCH 54/55] block: New change_media_cb() parameter load

2011-07-26 Thread Christoph Hellwig
On Wed, Jul 20, 2011 at 06:24:28PM +0200, Markus Armbruster wrote: > To let device models distinguish between eject and load. Looks fine, Reviewed-by: Christoph Hellwig

Re: [Qemu-devel] [PATCH 53/55] nbd: Clean up use of block_int.h

2011-07-26 Thread Christoph Hellwig
Looks fine, Reviewed-by: Christoph Hellwig

Re: [Qemu-devel] [PATCH 52/55] block: Move BlockDriverAIOCB & friends from block_int.h to block.h

2011-07-26 Thread Christoph Hellwig
On Wed, Jul 20, 2011 at 06:24:26PM +0200, Markus Armbruster wrote: > Device models should be able to use them without an unclean include of > block_int.h. I don't think so. In generall they aren't for use of device models at all. It's just that the IDE trim support with it's ranges is rather "sp

Re: [Qemu-devel] [PATCH 51/55] block: Reset buffer alignment on detach

2011-07-26 Thread Christoph Hellwig
On Wed, Jul 20, 2011 at 06:24:25PM +0200, Markus Armbruster wrote: > BlockDriverState member buffer_alignment is initially 512. The device > model may set them, with bdrv_set_buffer_alignment(). If the device > model gets detached (hot unplug), the device's alignment is left > behind. Only okay

Re: [Qemu-devel] [PATCH 50/55] block: New bdrv_set_buffer_alignment()

2011-07-26 Thread Christoph Hellwig
On Wed, Jul 20, 2011 at 06:24:24PM +0200, Markus Armbruster wrote: > Device models should be able to set it without an unclean include of > block_int.h. Fine with me, Reviewed-by: Christoph Hellwig

Re: [Qemu-devel] [PATCH 49/55] block: Declare qemu_blockalign() in block.h, not block_int.h

2011-07-26 Thread Christoph Hellwig
On Wed, Jul 20, 2011 at 06:24:23PM +0200, Markus Armbruster wrote: > Device models should be able to use it without an unclean include of > block_int.h. Hmm. We already do proper read-modify-write cycles for actual data transfers, so killing the buffer inside SD sounds like the better idea. qemu

[Qemu-devel] [PATCH v2 09/23] memory: I/O address space support

2011-07-26 Thread Avi Kivity
Allow registering I/O ports via the same mechanism as mmio ranges. Reviewed-by: Anthony Liguori Signed-off-by: Avi Kivity --- exec-memory.h |3 ++ memory.c | 60 - memory.h |2 + 3 files changed, 64 insertions(+), 1 del

Re: [Qemu-devel] [PATCH 48/55] hw: Trim superfluous #include "block_int.h"

2011-07-26 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig

Re: [Qemu-devel] [PATCH 6/6] scsi-disk: Check for supported commands

2011-07-26 Thread Kevin Wolf
Am 22.07.2011 16:51, schrieb Hannes Reinecke: > Not every command is support for any device type. This patch adds > a check for rejecting unsupported commands. > > Signed-off-by: Hannes Reinecke > --- > hw/scsi-disk.c | 104 > +++- > 1 files

[Qemu-devel] [PATCH] virtio-serial-bus: replay guest_open on migration

2011-07-26 Thread Alon Levy
Signed-off-by: Alon Levy --- hw/virtio-serial-bus.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c index c5eb931..7a652ff 100644 --- a/hw/virtio-serial-bus.c +++ b/hw/virtio-serial-bus.c @@ -618,14 +618,20 @@ static

Re: [Qemu-devel] [PATCH 47/55] block: Move BlockConf & friends from block_int.h to block.h

2011-07-26 Thread Christoph Hellwig
On Wed, Jul 20, 2011 at 06:24:21PM +0200, Markus Armbruster wrote: > It's convenience stuff for block device models, so block.h isn't the > ideal home either, but better than block_int.h. > > Permits moving some #include "block_int.h" from device model .h into > .c. Fine with me (and I added this

[Qemu-devel] [PATCH v2 11/23] memory: add backward compatibility for old mmio registration

2011-07-26 Thread Avi Kivity
This eases the transition to the new API. Reviewed-by: Anthony Liguori Signed-off-by: Avi Kivity --- memory.c | 10 ++ memory.h | 10 ++ 2 files changed, 20 insertions(+), 0 deletions(-) diff --git a/memory.c b/memory.c index 5f2c9ef..7dd7cac 100644 --- a/memory.c +++ b/mem

  1   2   3   >