Hi all,
Are there any concerns with this patch?
I haven't heard much feedback, except:
* Jes Sorensen - March 28 - code style
* Aurelien Jarno - April 18 - Reviewed-by
Thanks,
-Jordan
On Fri, Jul 8, 2011 at 12:37, Jordan Justen wrote:
> If -pflash is specified and -bios is specified then pfla
On 07/15/2011 02:59 AM, Paolo Bonzini wrote:
On 07/14/2011 06:07 PM, Avi Kivity wrote:
Maybe we can do this via a magic subsection whose contents are the
hotplug event.
What about making the device list just another "thing" that has to be
migrated live, together with block and ram?
In an id
Am 15.07.2011 um 17:10 schrieb Paolo Bonzini:
Serial and parallel devices created with -device are not reported in
the PIIX4 configuration space, and are hence not picked up by the
DSDT.
This upsets Windows, which hides them altogether from the guest.
To avoid this, check at the end of machi
On 07/15/2011 12:24 PM, Stefan Weil wrote:
Wiki spammers are still very active on qemu.org (see
http://wiki.qemu.org/Special:RecentChanges).
The QEMU wiki needs more technical protection against spam
and also more administrators who can remove spam pages
(I can't, so I simply emptied the pages
On 07/15/2011 10:02 PM, Blue Swirl wrote:
On Fri, Jul 15, 2011 at 12:56 AM, Alexander Graf wrote:
Am 14.07.2011 um 21:34 schrieb Blue Swirl:
Don't compile virtio.c in hwlib, it depends on memory accesses
performed in CPU endianness.
Make loads and stores in CPU endianness unavailable to d
Am 15.07.2011 um 21:38 schrieb Stefan Weil:
Commit 953ffe0f935f40c0d6061d69e76e0339393b54f8
introduced FMT_pid which is wrong for w32 and w64 getpid():
those getpid() implementations always return an int value.
Where is __int64 FMT_pid used then if not for the returned pid?
Andreas
Signed-
Am 15.07.2011 um 21:38 schrieb Stefan Weil:
For mingw-w64, pid_t is _pid_t which is __int64,
so this platform needs its own definition of FMT_pid.
Signed-off-by: Stefan Weil
Ah, that's probably lld then and thus different from the existing
definitions.
Reviewed-by: Andreas Färber
Andre
On Fri, Jul 15, 2011 at 12:56 AM, Alexander Graf wrote:
>
>
>
>
> Am 14.07.2011 um 21:34 schrieb Blue Swirl :
>
>> Don't compile virtio.c in hwlib, it depends on memory accesses
>> performed in CPU endianness.
>>
>> Make loads and stores in CPU endianness unavailable to devices
>> and poison them
tcg_gen_exit_tb takes a parameter of type tcg_target_long,
so the type casts of pointer to long should be replaced by
type casts of pointer to tcg_target_long.
These changes are needed for build environments where
sizeof(long) != sizeof(void *), especially for w64.
See 4b4a72e55660abf7efe85aca787
Here are some small patches needed for the w32 and w64 platforms.
[PATCH 1/3] Fix conversions from pointer to tcg_target_long
[PATCH 2/3] w64: Add definition of FMT_pid
[PATCH 3/3] w32: Fix format string regression
Kind regards,
Stefan
Commit 953ffe0f935f40c0d6061d69e76e0339393b54f8
introduced FMT_pid which is wrong for w32 and w64 getpid():
those getpid() implementations always return an int value.
Signed-off-by: Stefan Weil
---
os-win32.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/os-win32.c b/
For mingw-w64, pid_t is _pid_t which is __int64,
so this platform needs its own definition of FMT_pid.
Signed-off-by: Stefan Weil
---
osdep.h |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/osdep.h b/osdep.h
index a817017..252d050 100644
--- a/osdep.h
+++ b/osdep.h
@@ -
LTTng-UST, the Linux Trace Toolkit Next Generation Userspace Tracer, is
port of the low-overhead tracing capabilities of the LTTng kernel tracer
to user-space. The library "libust" enables tracing of applications and
libraries.
Changelog:
* Add backward compability for tracepoint API (still plann
Ping ?
Hervé Poussineau a écrit :
This patchset qdev-ifies the ds1225y device, used in MIPS Jazz emulation.
Changes since v1:
- rebased
- split into multiple patches as per Markus advice
Hervé Poussineau (3):
ds1225y: Remove protection stuff, which doesn't belong to this device
ds1225y: us
On Fri, 15 Jul 2011 12:21:55 -0500
Michael Roth wrote:
> On 07/15/2011 11:23 AM, Luiz Capitulino wrote:
> > On Thu, 14 Jul 2011 15:00:34 -0500
> > Michael Roth wrote:
> >
> >> This adds the initial set of QMP/QAPI commands provided by the guest
> >> agent:
> >>
> >> guest-sync
> >> guest-ping
>
On Fri, Jul 15, 2011 at 18:05, Stefano Stabellini
wrote:
> Shouldn't we avoid registering any memory for the whole video ram area?
> I mean:
>
> 0xa - 0x10
No, because SeaBIOS load the Options ROM (VGA Bios, PXE) to the area
between 0xc and 0x10, and this go through QEMU.
The are
Am 04.07.2011 10:05, schrieb Stefan Hajnoczi:
On Mon, Jul 4, 2011 at 8:27 AM, Brad Hards wrote:
On Mon, 4 Jul 2011 03:15:06 PM Stefan Hajnoczi wrote:
Thanks. I have a regular wiki account so I checked the Recent Changes
page and undid the spam changes that I saw:
http://wiki.qemu.org/Special
On Fri, 15 Jul 2011, Anthony PERARD wrote:
> Hi all,
>
> Xen is not limited by the QEMU's virtual address space for the allocation of
> the guest RAM. So even with a QEMU 32bits, a Xen guest can have more than 4 GB
> of RAM.
>
> With this serie, we will be able to run a guest with more than 4GB.
On Fri, 15 Jul 2011, Anthony PERARD wrote:
> A Xen guest memory is allocated by libxc. But this memory is not
> allocated continuously, instead, it leaves the VGA IO memory space not
> allocated, same for the MMIO space (at HVM_BELOW_4G_MMIO_START of size
> HVM_BELOW_4G_MMIO_LENGTH).
>
> So to ref
The purpose of AsyncContexts was to protect qcow and qcow2 against reentrancy
during an emulated bdrv_read/write (which includes a qemu_aio_wait() call and
can run AIO callbacks of different requests if it weren't for AsyncContexts).
Now both qcow and qcow2 are protected by CoMutexes and AsyncCont
If we're already in a coroutine, there is no reason to use the synchronous
version of block layer functions when a coroutine one exists. This makes
bdrv_read/write/flush use bdrv_co_* when used inside a coroutine.
Signed-off-by: Kevin Wolf
---
block.c | 43 +
On 07/15/2011 11:23 AM, Luiz Capitulino wrote:
On Thu, 14 Jul 2011 15:00:34 -0500
Michael Roth wrote:
This adds the initial set of QMP/QAPI commands provided by the guest
agent:
guest-sync
guest-ping
guest-info
guest-shutdown
guest-file-open
guest-file-read
guest-file-write
guest-file-seek
gu
The old qcow format is another user of the AsyncContext infrastructure.
Converting it to coroutines (and therefore CoMutexes) allows to remove
AsyncContexts.
Signed-off-by: Kevin Wolf
---
block/qcow.c | 180 --
1 files changed, 62 insertio
Use the bdrv_co_readv/writev callbacks to implement bdrv_aio_readv/writev and
bdrv_read/write if a driver provides the coroutine version instead of the
synchronous or AIO version.
Signed-off-by: Kevin Wolf
---
block.c | 98 ++-
1 file
Signed-off-by: Kevin Wolf
---
block/qcow2-cluster.c | 26 +++---
block/qcow2.c | 240 ++---
block/qcow2.h |5 +-
3 files changed, 102 insertions(+), 169 deletions(-)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
inde
On Fri, Jul 15, 2011 at 6:18 PM, John Baboval
wrote:
> Is there something I can do to help take this patch the rest of the way?
>
> I'd hate to see it die because of a style issue and a compiler warning.
There's also suspicious missing 'break' statement. How about fixing
the issues and submitting
Based on Stefan's latest coroutine patches. This series makes qcow and qcow2
take advantage of the new coroutine infrastructure. Both formats used
synchronous operations for accessing their metadata and blocked the guest CPU
during that time. With coroutines, the I/O will happen asynchronously in t
Signed-off-by: Kevin Wolf
---
Makefile.objs |2 +-
qemu-coroutine-int.h |1 +
qemu-coroutine-lock.c | 124 +
qemu-coroutine.h | 62
trace-events |8 +++
5 files changed, 196 insertions(+
Now that AsyncContexts don't exist any more, we can use one global bottom half
for restarting coroutines instead of allocating a new one every time (before
removing AsyncContexts, the problem with having a global BH was that it had to
belong to a single AsyncContexts and wouldn't be executed in a d
Add new block driver callbacks bdrv_co_readv/writev, which work on a
QEMUIOVector like bdrv_aio_*, but don't need a callback. The function may only
be called inside a coroutine, so a block driver implementing this interface can
yield instead of blocking during I/O.
Signed-off-by: Kevin Wolf
---
On Thu, 14 Jul 2011 15:00:34 -0500
Michael Roth wrote:
> This adds the initial set of QMP/QAPI commands provided by the guest
> agent:
>
> guest-sync
> guest-ping
> guest-info
> guest-shutdown
> guest-file-open
> guest-file-read
> guest-file-write
> guest-file-seek
> guest-file-flush
> guest-fil
In order to be able to call bdrv_co_readv/writev for drivers that don't
implement the functions natively, add an emulation that uses the AIO functions
to implement them.
Signed-off-by: Kevin Wolf
---
block.c | 86 +++--
trace-events |
On Fri, 15 Jul 2011 09:15:18 +0800
Zhi Yong Wu wrote:
> On Fri, Jul 15, 2011 at 4:00 AM, Michael Roth
> wrote:
> > This is Set 3/3 of the QAPI+QGA patchsets.
> >
> > These patches apply on top of qapi-backport-set2-v6, and can also be
> > obtained from:
> > git://repo.or.cz/qemu/mdroth.git qap
Serial and parallel devices created with -device are not reported in
the PIIX4 configuration space, and are hence not picked up by the DSDT.
This upsets Windows, which hides them altogether from the guest.
To avoid this, check at the end of machine initialization whether the
corresponding I/O port
Is there something I can do to help take this patch the rest of the way?
I'd hate to see it die because of a style issue and a compiler warning.
-John
On 06/15/2011 02:19 PM, Blue Swirl wrote:
On Sat, Jun 11, 2011 at 1:29 AM, Michael Tokarev wrote:
I've given up on this one. Personally I do
Pass the BlockDeviceState to the nand_init() function rather
than having it look it up via drive_get() itself.
Signed-off-by: Peter Maydell
---
hw/axis_dev88.c |6 +-
hw/flash.h |2 +-
hw/nand.c |8 ++--
hw/spitz.c |4 +++-
hw/tc6393xb.c |5 -
5
Pass the BlockDriverState to the onenand init function so it doesn't
need to look up the drive itself.
Signed-off-by: Peter Maydell
---
hw/flash.h |3 ++-
hw/nseries.c | 10 ++
hw/onenand.c | 14 --
3 files changed, 16 insertions(+), 11 deletions(-)
diff --git a/hw
From: Juha Riihimäki
Support NAND devices which are wider than 8 bits.
Signed-off-by: Juha Riihimäki
[Riku Voipio: Fixes and restructuring patchset]
Signed-off-by: Riku Voipio
[Peter Maydell: More fixes and cleanups for upstream submission]
Signed-off-by: Peter Maydell
---
hw/flash.h |5
From: Juha Riihimäki
Qdevify the ONENAND device.
Signed-off-by: Juha Riihimäki
[Riku Voipio: Fixes and restructuring patchset]
Signed-off-by: Riku Voipio
[Peter Maydell: More fixes and cleanups for upstream submission]
Signed-off-by: Peter Maydell
---
hw/flash.h |8 +-
hw/onenand.c |
From: Juha Riihimäki
After receiving READ STATUS command all subsequent IO reads should return
the status register value until another command is issued.
Signed-off-by: Juha Riihimäki
[Riku Voipio: Fixes and restructuring patchset]
Signed-off-by: Riku Voipio
[Peter Maydell: More fixes and clea
Hi,
I have been updating the live snapshot wiki for qemu to try and cover
the commands we will want for async snapshot handling too.
http://wiki.qemu.org/Features/Snapshots
Cheers,
Jes
From: Juha Riihimäki
Add support for NAND devices of over 1Gb.
Signed-off-by: Juha Riihimäki
[Riku Voipio: Fixes and restructuring patchset]
Signed-off-by: Riku Voipio
[Peter Maydell: More fixes and cleanups for upstream submission]
Signed-off-by: Peter Maydell
---
hw/nand.c | 48
Writing to a NAND device cannot set bits, it can only clear them;
implement this rather than simply copying the data.
Signed-off-by: Peter Maydell
---
hw/nand.c | 17 +
1 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/hw/nand.c b/hw/nand.c
index e6c551d..d068eb6
From: Juha Riihimäki
Add support for unmapping a SysBus device's mmio region, via a new
function sysbus_mmio_unmap(). This simply reverses the effect of
sysbus_mmio_map().
Signed-off-by: Juha Riihimäki
Signed-off-by: Peter Maydell
---
hw/sysbus.c | 17 +
hw/sysbus.h |1 +
From: Juha Riihimäki
Ignore zero writes to the boot command space; Linux will issue
these in the powerdown/reset sequence.
Signed-off-by: Juha Riihimäki
[Riku Voipio: Fixes and restructuring patchset]
Signed-off-by: Riku Voipio
[Peter Maydell: More fixes and cleanups for upstream submission]
S
From: Juha Riihimäki
Qdevify the NAND device.
Signed-off-by: Juha Riihimäki
[Riku Voipio: Fixes and restructuring patchset]
Signed-off-by: Riku Voipio
[Peter Maydell: More fixes and cleanups for upstream submission]
Signed-off-by: Peter Maydell
---
hw/axis_dev88.c |2 +-
hw/flash.h
From: Juha Riihimäki
The program actions onenand_prog_main() and onenand_prog_spare()
can only set bits.
This implies a rewrite of onenand_erase() to not use the program
functions, since erase does need to set bits.
Signed-off-by: Juha Riihimäki
[Riku Voipio: Fixes and restructuring patchset]
From: Juha Riihimäki
Handle the manufacturer, device and version IDs separately rather than
smooshing them all together into a single uint32_t. Note that the ID
registers are actually 16 bit, even though typically the top bits are 0
and the Read Identification Data command only returns the bottom
On 07/15/2011 04:32 PM, Anthony PERARD wrote:
A Xen guest memory is allocated by libxc. But this memory is not
allocated continuously, instead, it leaves the VGA IO memory space not
allocated, same for the MMIO space (at HVM_BELOW_4G_MMIO_START of size
HVM_BELOW_4G_MMIO_LENGTH).
So to reflect th
This patchseries is more goodies from the Meego tree. Specifically, various
bug fixes to hw/nand and hw/onenand, plus conversion of both to sysbus.
[An advance note on the next thing due to come out of the pipe: qdeving
nand and onenand allows us to move to qdevification of omap_gpmc, which
takes
On 07/15/2011 04:32 PM, Anthony PERARD wrote:
As a Xen guest can have more than 2GB of RAM on a 32bit host, we move
the conditions after than we now if we run one Xen or not.
Signed-off-by: Anthony PERARD
---
vl.c | 14 --
1 files changed, 8 insertions(+), 6 deletions(-)
diff -
On 07/15/2011 04:32 PM, Anthony PERARD wrote:
Use the "host" CONFIG_ define instead of the "target" one.
Signed-off-by: Anthony PERARD
---
hw/xen.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/xen.h b/hw/xen.h
index e432705..43b95d6 100644
--- a/hw/xen.h
+++ b/
On 07/15/2011 04:32 PM, Anthony PERARD wrote:
As the variable pd and addr1 inside the function cpu_physical_memory_rw
are mean to handle a RAM address, they should be of the ram_addr_t type
instead of unsigned long.
Signed-off-by: Anthony PERARD
---
exec.c |4 ++--
1 files changed, 2 inse
A Xen guest memory is allocated by libxc. But this memory is not
allocated continuously, instead, it leaves the VGA IO memory space not
allocated, same for the MMIO space (at HVM_BELOW_4G_MMIO_START of size
HVM_BELOW_4G_MMIO_LENGTH).
So to reflect that, we do not register the physical memory for t
As a Xen guest can have more than 2GB of RAM on a 32bit host, we move
the conditions after than we now if we run one Xen or not.
Signed-off-by: Anthony PERARD
---
vl.c | 14 --
1 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/vl.c b/vl.c
index fcd7395..c2efedf 100644
In Xen case, memory can be bigger than the host memory. that mean a
32bits host (and QEMU) should be able to handle a RAM address of 64bits.
Signed-off-by: Anthony PERARD
---
cpu-common.h |8
exec.c |9 +
xen-all.c|2 +-
3 files changed, 14 insertions(+), 5
As the variable pd and addr1 inside the function cpu_physical_memory_rw
are mean to handle a RAM address, they should be of the ram_addr_t type
instead of unsigned long.
Signed-off-by: Anthony PERARD
---
exec.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/exec.c b/
Use the "host" CONFIG_ define instead of the "target" one.
Signed-off-by: Anthony PERARD
---
hw/xen.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/xen.h b/hw/xen.h
index e432705..43b95d6 100644
--- a/hw/xen.h
+++ b/hw/xen.h
@@ -24,7 +24,7 @@ extern int xen_allowed
Hi all,
Xen is not limited by the QEMU's virtual address space for the allocation of
the guest RAM. So even with a QEMU 32bits, a Xen guest can have more than 4 GB
of RAM.
With this serie, we will be able to run a guest with more than 4GB. The main
point is to change ram_addr_t from ulong to uin6
From: Gerd Hoffmann
Add qxl_guest_bug() function which is supposed to be called in case
sanity checks of guest requests fail. It raises an error IRQ and
logs a message in case guest debugging is enabled.
Make PANIC_ON() abort instead of exit. That macro should be used
for qemu bugs only, any g
From: Gerd Hoffmann
Factor out SimpleSpiceDisplay initialization into
qemu_spice_display_init_common() and call it from
both qxl.c (for vga mode) and spice-display.c
Signed-off-by: Gerd Hoffmann
---
hw/qxl.c |7 +--
ui/spice-display.c | 17 +++--
ui/spice-displa
Signed-off-by: Alon Levy
---
hw/qxl.c |9 +++--
hw/qxl.h |2 +-
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/hw/qxl.c b/hw/qxl.c
index 68ce409..d645c87 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -125,13 +125,18 @@ static void qxl_reset_memslots(PCIQXLDevice *d);
static
From: Gerd Hoffmann
Inform guest drivers about the new features I/O commands we have
now (async commands, S3 support) if building with newer spice, i.e.
if SPICE_INTERFACE_QXL_MINOR >= 1.
sneaked in some 81+ column line spliting.
Signed-off-by: Gerd Hoffmann
Signed-off-by: Alon Levy
---
hw/q
From: Gerd Hoffmann
Surface tracking needs proper locking since it is used from vcpu and spice
worker threads, add it. Also reset the surface counter when zapping all
surfaces.
Signed-off-by: Gerd Hoffmann
---
hw/qxl.c | 13 -
hw/qxl.h |2 ++
2 files changed, 14 insertions(+
Since the driver is still in operation even after moving to UNDEFINED, i.e.
by destroying primary in any way.
Signed-off-by: Alon Levy
---
hw/qxl.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/hw/qxl.c b/hw/qxl.c
index d645c87..b946942 100644
--- a/hw/qxl.c
+++ b/hw
Some of the QXL port i/o commands are waiting for the spice server to
complete certain actions. Add async versions for these commands, so we
don't block the vcpu while the spice server processses the command.
Instead the qxl device will raise an IRQ when done.
The async command processing relies
v5->v6:
really use array in io_port_to_string
undo merged "async io support" to revision change
remove QXL_REVISION_* defines usage
move qxl_send_event to async_cancel
fix async_cancel label per patchcheck
Alon Levy (5):
qxl: add io_port_to_string
qxl: make qxl_guest_bug take variable arg
Signed-off-by: Alon Levy
---
hw/qxl.c | 40 +++-
1 files changed, 39 insertions(+), 1 deletions(-)
diff --git a/hw/qxl.c b/hw/qxl.c
index e832d00..7d8b312 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -409,6 +409,43 @@ static const char *qxl_mode_to_string(int mod
Add two new IOs.
QXL_IO_FLUSH_SURFACES - equivalent to update area for all surfaces, used
to reduce vmexits from NumSurfaces to 1 on guest S3, S4 and resolution change
(windows
driver implementation is such that this is done on each of those occasions).
QXL_IO_FLUSH_RELEASE - used to ensure
From: Gerd Hoffmann
Move the wrapper functions which are used by qxl only to qxl.c.
Rename them from qemu_spice_* to qxl_spice_*. Also pass in a
qxl state pointer instead of a SimpleSpiceDisplay pointer.
Signed-off-by: Gerd Hoffmann
---
hw/qxl-render.c|4 +-
hw/qxl.c | 67
From: Gerd Hoffmann
Add wrapper functions for all spice worker calls.
Signed-off-by: Gerd Hoffmann
---
hw/qxl-render.c|4 +-
hw/qxl.c | 32 +-
ui/spice-display.c | 95 ---
ui/spice-display.h | 22 ++
Hi,
+qxl_destroy_primary(d, async);
+#if SPICE_INTERFACE_QXL_MINOR>= 1
+if (d->mode == QXL_MODE_UNDEFINED&& async == QXL_ASYNC) {
+dprint(d, 1, "QXL_IO_DESTROY_PRIMARY_ASYNC in %s, ignored\n",
+qxl_mode_to_string(d->mode));
+qxl_sen
Am 15.07.2011 12:34, schrieb Stefano Stabellini:
> On Fri, 1 Jul 2011, Stefano Stabellini wrote:
>> On Fri, 1 Jul 2011, Kevin Wolf wrote:
>>> Am 30.06.2011 16:16, schrieb Stefano Stabellini:
On Thu, 30 Jun 2011, Kevin Wolf wrote:
>> +static int pci_piix3_xen_ide_unplug(DeviceState *dev)
>>
From: Anthony PERARD
Remove the call to xenstore_record_dm_state from xen_main_loop_prepare
that is HVM specific.
Add a new vm_change_state_handler shared between xen_pv and xen_hvm
machines to record the VM state to xenstore.
Signed-off-by: Anthony PERARD
Signed-off-by: Stefano Stabellini
---
On Fri, 1 Jul 2011, Stefano Stabellini wrote:
> On Fri, 1 Jul 2011, Kevin Wolf wrote:
> > Am 30.06.2011 16:16, schrieb Stefano Stabellini:
> > > On Thu, 30 Jun 2011, Kevin Wolf wrote:
> > >>> +static int pci_piix3_xen_ide_unplug(DeviceState *dev)
> > >>> +{
> > >>> +PCIDevice *pci_dev;
> > >>>
I have just realized that I wrote the reply to this email long ago but I
have never sent it, it was sitting in my Draft mbox.
On Thu, 30 Jun 2011, Alexander Graf wrote:
> On 06/29/2011 01:16 PM, stefano.stabell...@eu.citrix.com wrote:
> > From: Anthony PERARD
> >
> > Remove the call to xenstore_re
On Thu, Jul 14, 2011 at 5:43 PM, Constantine Chernov
<810...@bugs.launchpad.net> wrote:
> Virual machine with MS windows 2003 installed on the virtual scsi disk
> (-drive
> file=/my/path/myimage.qcow2.img,boot=on,if=scsi,media=disk,bus=0,unit=1)
> unexpectedly crashes without core dump. When the
On Tue, Jun 28, 2011 at 06:53:08PM +0200, Lluís wrote:
> diff --git a/vl.c b/vl.c
> index b2f41fd..b766dc7 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2861,14 +2861,23 @@ int main(int argc, char **argv, char **envp)
> }
> xen_mode = XEN_ATTACH;
> break;
On Tue, Jun 28, 2011 at 06:53:01PM +0200, Lluís wrote:
> Signed-off-by: Lluís Vilanova
> ---
> .gitignore|2
> Makefile |1
> Makefile.objs |4 -
> scripts/tracetool |2
> simpletrace.c | 355
> -
>
On Tue, Jun 28, 2011 at 06:52:55PM +0200, Lluís wrote:
> This patch defines the "disable" trace event state to always use the "nop"
> backend.
>
> As a side-effect, all events are now enabled (without "disable") by default,
> as
> all backends (except "stderr") have programmatic support for dynam
On Tue, Jun 28, 2011 at 06:53:21PM +0200, Lluís wrote:
> Move the 'st_print_trace_events' and 'st_change_trace_event_state' into
> backend-agnostic 'trace_print_events' and 'trace_event_set_state'
> (respectively)
> in the "trace/control.c" file.
Renaming the functions makes sense but moving thei
On Tue, Jun 28, 2011 at 06:53:34PM +0200, Lluís wrote:
> diff --git a/docs/tracing.txt b/docs/tracing.txt
> index 017ff59..8f6e5c9 100644
> --- a/docs/tracing.txt
> +++ b/docs/tracing.txt
> @@ -129,6 +129,9 @@ This functionality is also provided through monitor
> commands:
> * trace-event NAME on
On Fri, Jul 15, 2011 at 10:23:39AM +0200, Gerd Hoffmann wrote:
> Hi,
>
> >+#if SPICE_INTERFACE_QXL_MINOR>= 1
> >+qemu_mutex_init(&qxl->async_lock);
> >+qxl->current_async = QXL_UNDEFINED_IO;
> >+#endif
>
> That surely belongs into another patch ...
yes.
>
> >+case QXL_REVISION_ST
On Fri, Jul 15, 2011 at 10:15:26AM +0200, Gerd Hoffmann wrote:
> >+#if SPICE_INTERFACE_QXL_MINOR>= 1
> >+case QXL_IO_FLUSH_RELEASE: {
> >+QXLReleaseRing *ring =&d->ram->release_ring;
> >+if (ring->prod - ring->cons + 1 == ring->num_items) {
> >+fprintf(stderr,
> >+
On Fri, Jul 15, 2011 at 10:20:08AM +0200, Gerd Hoffmann wrote:
> >+#if SPICE_INTERFACE_QXL_MINOR>= 1
> >+#define QXL_DEFAULT_REVISION QXL_REVISION_STABLE_V10
> >+#else
> >+#define QXL_DEFAULT_REVISION QXL_REVISION_STABLE_V06
> >+#endif
>
> Does that actually build with old spice-protocol? I don't
On Fri, Jul 15, 2011 at 10:12:14AM +0200, Gerd Hoffmann wrote:
> > case QXL_IO_DESTROY_PRIMARY:
> > if (val != 0) {
> >-qxl_guest_bug(d, "QXL_IO_DESTROY_PRIMARY: val != 0");
> >-break;
> >+qxl_guest_bug(d, "QXL_IO_DESTROY_PRIMARY (async=%d): val !=
On Fri, Jul 15, 2011 at 10:19:27AM +0200, Gerd Hoffmann wrote:
> On 07/14/11 21:13, Alon Levy wrote:
> >Some of the QXL port i/o commands are waiting for the spice server to
> >complete certain actions. Add async versions for these commands, so we
> >don't block the vcpu while the spice server pro
On Fri, Jul 15, 2011 at 09:59:21AM +0200, Gerd Hoffmann wrote:
> Hi,
>
> >+switch (io_port) {
> >+case QXL_IO_NOTIFY_CMD:
> >+return "QXL_IO_NOTIFY_CMD";
>
> Wasn't the plan to make this an array?
>
yes. Somehow I sent the wrong patch. No idea how I managed to do that.
> chee
Hi,
+#if SPICE_INTERFACE_QXL_MINOR>= 1
+qemu_mutex_init(&qxl->async_lock);
+qxl->current_async = QXL_UNDEFINED_IO;
+#endif
That surely belongs into another patch ...
+case QXL_REVISION_STABLE_V04: /* spice 0.4 -- qxl-1 */
+case QXL_REVISION_STABLE_V06: /* spice 0.6 -- qxl-2
On 07/14/11 21:13, Alon Levy wrote:
Some of the QXL port i/o commands are waiting for the spice server to
complete certain actions. Add async versions for these commands, so we
don't block the vcpu while the spice server processses the command.
Instead the qxl device will raise an IRQ when done.
+#if SPICE_INTERFACE_QXL_MINOR>= 1
+#define QXL_DEFAULT_REVISION QXL_REVISION_STABLE_V10
+#else
+#define QXL_DEFAULT_REVISION QXL_REVISION_STABLE_V06
+#endif
Does that actually build with old spice-protocol? I don't think so ...
cheers,
Gerd
+#if SPICE_INTERFACE_QXL_MINOR>= 1
+case QXL_IO_FLUSH_RELEASE: {
+QXLReleaseRing *ring =&d->ram->release_ring;
+if (ring->prod - ring->cons + 1 == ring->num_items) {
+fprintf(stderr,
+"ERROR: no flush, full release ring [p%d,%dc]\n",
+
case QXL_IO_DESTROY_PRIMARY:
if (val != 0) {
-qxl_guest_bug(d, "QXL_IO_DESTROY_PRIMARY: val != 0");
-break;
+qxl_guest_bug(d, "QXL_IO_DESTROY_PRIMARY (async=%d): val != 0",
+ async);
+goto cancel_async;
+
On 07/14/2011 06:07 PM, Avi Kivity wrote:
Maybe we can do this via a magic subsection whose contents are the
hotplug event.
What about making the device list just another "thing" that has to be
migrated live, together with block and ram?
Paolo
Hi,
+switch (io_port) {
+case QXL_IO_NOTIFY_CMD:
+return "QXL_IO_NOTIFY_CMD";
Wasn't the plan to make this an array?
cheers,
Gerd
95 matches
Mail list logo
