Hi,

+#if SPICE_INTERFACE_QXL_MINOR>= 1
+    qemu_mutex_init(&qxl->async_lock);
+    qxl->current_async = QXL_UNDEFINED_IO;
+#endif

That surely belongs into another patch ...

+    case QXL_REVISION_STABLE_V04: /* spice 0.4 -- qxl-1 */
+    case QXL_REVISION_STABLE_V06: /* spice 0.6 -- qxl-2 */

I think we should just not use these defines for now.

In a year or so when the new bits are in widespread use we can raise the minimum required spice-server+spice-protocol versions, cleanup the ifdef mess and also use QXL_REVISION_STABLE_V04.

cheers,
  Gerd


Reply via email to