Re: [Qemu-devel] [RFC v3 30/56] rtl8139: convert to memory API

2011-07-12 Thread Avi Kivity
On 07/13/2011 01:41 AM, Alex Williamson wrote: > static int rtl8139_post_load(void *opaque, int version_id) > { > @@ -3283,7 +3242,7 @@ static void rtl8139_pre_save(void *opaque) > rtl8139_set_next_tctr_time(s, current_time); > s->TCTR = muldiv64(current_time - s->TCTR_base, PCI_

Re: [Qemu-devel] [PATCHv3] async + suspend reworked

2011-07-12 Thread Gerd Hoffmann
On 07/12/11 15:55, Alon Levy wrote: v2->v3: builds correctly with older and newer spice, and runs with older and newer qxl driver. fixed update_area_async to not use QXLRect on stack qxl-render updated to work with update_area_async correctly reverted change to update_area api - update_a

Re: [Qemu-devel] Fwd: [PATCH] Introduce "info migrate-times" monitor command

2011-07-12 Thread Markus Armbruster
Michal Novotny writes: > This accidentally didn't go to the list although it's been sent there > (using git send-email)... Please resend cleanly, so that git-am commits with a reasonable commit message, not some crap like this: commit 1f5de40943d4ce9c18d7f9d8b0070a755d7babb5 Author: Michal Novo

[Qemu-devel] [PATCH 4/4] SPARC64: fp_disabled checks on stfa/stdfa/stqfa

2011-07-12 Thread Tsuneo Saito
stfa/stdfa/stqfa instructions should raise fp_disabled exceptions if %pstate.PEF==0 or %fprs.FEF==0. Signed-off-by: Tsuneo Saito --- target-sparc/translate.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/target-sparc/translate.c b/target-sparc/translate.c index 95

[Qemu-devel] [PATCH 3/4] SPARC64: Implement stfa/stdfa/stqfa instrcutions properly

2011-07-12 Thread Tsuneo Saito
This patch implements sparcv9 stfa/stdfa/stqfa instructions with non block-store ASIs. Signed-off-by: Tsuneo Saito --- target-sparc/op_helper.c | 15 +++ target-sparc/translate.c |2 -- 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/target-sparc/op_helper.c b/t

[Qemu-devel] [PATCH 1/4] SPARC64: Implement ldfa/lddfa/ldqfa instructions properly

2011-07-12 Thread Tsuneo Saito
This patch implements sparcv9 ldfa/lddfa/ldqfa instructions with non block-load ASIs. Signed-off-by: Tsuneo Saito --- target-sparc/op_helper.c | 16 +++- 1 files changed, 11 insertions(+), 5 deletions(-) diff --git a/target-sparc/op_helper.c b/target-sparc/op_helper.c index fd0cfb

[Qemu-devel] [PATCH 2/4] SPARC64: fp_disabled checks on ldfa/lddfa/ldqfa

2011-07-12 Thread Tsuneo Saito
ldfa/lddfa/ldqfa instructions should raise fp_disabled exceptions if %pstate.PEF==0 or %fprs.FEF==0. Signed-off-by: Tsuneo Saito --- target-sparc/translate.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/target-sparc/translate.c b/target-sparc/translate.c index f3

[Qemu-devel] [PATCH 0/4] SPARC64: Implement sparcv9 ldfa/stfa instructions

2011-07-12 Thread Tsuneo Saito
Hi, This patch series implements sparcv9 stfa/ldfa instructions with non block-transfer ASIs that implementations seem to be left unfinished. This patch also adds fp_disabled exception checks on stfa/ldfa as they are FP instructions. target-sparc/op_helper.c | 31 ++

Re: [Qemu-devel] PCI with Xilinx virtex-ml507 board

2011-07-12 Thread Lê Đức Tài
On Jul 11, 2011 15:31, "Edgar E. Iglesias" wrote: > Hi, > The emulated board and fpga config doesnt have pci. It does have a xilinx >ll-temac ethernet mac though. I have patches for that, its on my todo list to >post them. Right now im on the road with little access to my stuff. It'll >

[Qemu-devel] buildbot failure in qemu on qmp_i386_debian_5_0

2011-07-12 Thread qemu
The Buildbot has detected a new failure on builder qmp_i386_debian_5_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/qmp_i386_debian_5_0/builds/32 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki Build Reason:

Re: [Qemu-devel] Loading ELF binaries with very high base addresses

2011-07-12 Thread Prashant Vaibhav
That is what I am doing except that my binaries also don't have any data section and don't link against any libraries. The text section does start at 0x4000 but they get mapped at 0x1000 or similar location. I can also build binaries with low base addresses. When these basic ones are wo

[Qemu-devel] [PATCH v6 18/18] qapi: add QAPI code generation documentation

2011-07-12 Thread Michael Roth
Signed-off-by: Michael Roth --- docs/qapi-code-gen.txt | 316 1 files changed, 316 insertions(+), 0 deletions(-) create mode 100644 docs/qapi-code-gen.txt diff --git a/docs/qapi-code-gen.txt b/docs/qapi-code-gen.txt new file mode 100644 index 0

[Qemu-devel] [PATCH v6 17/18] qapi: add test-qmp-commands, tests for gen. marshalling/dispatch code

2011-07-12 Thread Michael Roth
Signed-off-by: Michael Roth --- Makefile|8 +++- test-qmp-commands.c | 113 +++ 2 files changed, 120 insertions(+), 1 deletions(-) create mode 100644 test-qmp-commands.c diff --git a/Makefile b/Makefile index a243c24..cbd2d77 100

[Qemu-devel] [PATCH v6 14/18] qapi: add qapi-commands.py code generator

2011-07-12 Thread Michael Roth
This is the code generator for qapi command marshaling/dispatch. Currently only generators for synchronous qapi/qmp functions are supported. This script generates the following files: $(prefix)qmp-marshal.c: command marshal/dispatch functions for each QMP command define

[Qemu-devel] [PATCH v6 11/18] qapi: add qapi.py helper libraries

2011-07-12 Thread Michael Roth
Signed-off-by: Michael Roth --- scripts/qapi.py | 203 +++ 1 files changed, 203 insertions(+), 0 deletions(-) create mode 100644 scripts/qapi.py diff --git a/scripts/qapi.py b/scripts/qapi.py new file mode 100644 index 000..56af232 --- /

[Qemu-devel] [PATCH v6 16/18] qapi: add test-visitor, tests for gen. visitor code

2011-07-12 Thread Michael Roth
Signed-off-by: Michael Roth --- Makefile | 18 +++- test-visitor.c | 306 2 files changed, 322 insertions(+), 2 deletions(-) create mode 100644 test-visitor.c diff --git a/Makefile b/Makefile index 42ae4e5..a243c24 100644 --- a/

[Qemu-devel] [PATCH v6 12/18] qapi: add qapi-types.py code generator

2011-07-12 Thread Michael Roth
This is the code generator for qapi types. It will generation the following files: $(prefix)qapi-types.h - C types corresponding to types defined in the schema you pass in $(prefix)qapi-types.c - Cleanup functions for the above C types The $(prefix) is used to as a n

[Qemu-devel] [PATCH v6 09/18] qapi: add QMP dispatch functions

2011-07-12 Thread Michael Roth
Given an object recieved via QMP, this code uses the dispatch table provided by qmp_registry.c to call the corresponding marshalling/dispatch function and format return values/errors for delivery to the QMP. Currently only synchronous QMP functions are supported, but this will also be used for asyn

[Qemu-devel] [PATCH v6 15/18] qapi: test schema used for unit tests

2011-07-12 Thread Michael Roth
This is how QMP commands/parameters/types would be defined. We use a subset of that functionality here to implement functions/types for unit testing. Signed-off-by: Michael Roth --- qapi-schema-test.json | 22 ++ 1 files changed, 22 insertions(+), 0 deletions(-) create mod

[Qemu-devel] [QAPI+QGA 2/3] QAPI code generation infrastructure v6

2011-07-12 Thread Michael Roth
This is Set 2/3 of the QAPI+QGA patchsets. These patches apply on top of master (set1 merged), and can also be obtained from: git://repo.or.cz/qemu/mdroth.git qapi-backport-set2-v6 (Set1+2 are a backport of some of the QAPI-related work from Anthony's glib tree. The main goal is to get the basic

[Qemu-devel] [PATCH v6 06/18] qapi: add QMP output visitor

2011-07-12 Thread Michael Roth
Type of Visiter class that serves as the inverse of the input visitor: it takes a series of native C types and uses their values to construct a corresponding QObject. The command marshaling/dispatcher functions will use this to convert the output of QMP functions into a QObject that can be sent ove

[Qemu-devel] [PATCH v6 13/18] qapi: add qapi-visit.py code generator

2011-07-12 Thread Michael Roth
This is the code generator for qapi visiter functions used to marshal/unmarshal/dealloc qapi types. It generates the following 2 files: $(prefix)qapi-visit.c: visiter function for a particular c type, used to automagically convert qobjects into the

[Qemu-devel] [PATCH v6 05/18] qapi: add QMP input visitor

2011-07-12 Thread Michael Roth
A type of Visiter class that is used to walk a qobject's structure and assign each entry to the corresponding native C type. Command marshaling function will use this to pull out QMP command parameters recieved over the wire and pass them as native arguments to the corresponding C functions. Signe

[Qemu-devel] [PATCH v6 10/18] qapi: add ordereddict.py helper library

2011-07-12 Thread Michael Roth
We need this to parse dictionaries with schema ordering intact so that C prototypes can be generated deterministically. Signed-off-by: Michael Roth --- scripts/ordereddict.py | 128 1 files changed, 128 insertions(+), 0 deletions(-) create mode

[Qemu-devel] [PATCH v6 08/18] qapi: add QMP command registration/lookup functions

2011-07-12 Thread Michael Roth
Registration/lookup functions for that provide a lookup table for dispatching QMP commands. Signed-off-by: Michael Roth --- Makefile.objs |1 + qapi/qmp-core.h | 40 qapi/qmp-registry.c | 40 3 fi

[Qemu-devel] [PATCH v6 04/18] qapi: add QAPI visitor core

2011-07-12 Thread Michael Roth
Base definitions/includes for Visiter interface used by generated visiter/marshalling code. Includes a GenericList type. Our lists require an embedded element. Since these types are generated, if you want to use them in a different type of data structure, there's no easy way to add another embedde

[Qemu-devel] [PATCH v6 02/18] qlist: add qlist_first()/qlist_next()

2011-07-12 Thread Michael Roth
Signed-off-by: Michael Roth --- qlist.h | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/qlist.h b/qlist.h index dbe7b92..d426bd4 100644 --- a/qlist.h +++ b/qlist.h @@ -16,6 +16,7 @@ #include "qobject.h" #include "qemu-queue.h" #include "qemu-common.h" +#inc

[Qemu-devel] [PATCH v6 07/18] qapi: add QAPI dealloc visitor

2011-07-12 Thread Michael Roth
Type of Visitor class that can be passed into a qapi-generated C type's visitor function to free() any heap-allocated data types. Signed-off-by: Michael Roth --- Makefile.objs |2 +- qapi/qapi-dealloc-visitor.c | 147 +++ qapi/qapi-deall

[Qemu-devel] [PATCH v6 03/18] qapi: add module init types for qapi

2011-07-12 Thread Michael Roth
Signed-off-by: Michael Roth --- module.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/module.h b/module.h index 9263f1c..ef66730 100644 --- a/module.h +++ b/module.h @@ -24,12 +24,14 @@ typedef enum { MODULE_INIT_BLOCK, MODULE_INIT_DEVICE, MODULE_INIT_

[Qemu-devel] [PATCH v6 01/18] Add hard build dependency on glib

2011-07-12 Thread Michael Roth
From: Anthony Liguori GLib is an extremely common library that has a portable thread implementation along with tons of other goodies. GLib and GObject have a fantastic amount of infrastructure we can leverage in QEMU including an object oriented programming infrastructure. Short term, it has a

Re: [Qemu-devel] [RFC v3 30/56] rtl8139: convert to memory API

2011-07-12 Thread Alex Williamson
On Tue, 2011-07-12 at 16:41 -0600, Alex Williamson wrote: > On Sun, 2011-07-10 at 21:14 +0300, Avi Kivity wrote: > > Signed-off-by: Avi Kivity > > --- > > hw/rtl8139.c | 172 > > +- > > 1 files changed, 51 insertions(+), 121 deletions(-) >

Re: [Qemu-devel] [RFC v3 30/56] rtl8139: convert to memory API

2011-07-12 Thread Alex Williamson
On Sun, 2011-07-10 at 21:14 +0300, Avi Kivity wrote: > Signed-off-by: Avi Kivity > --- > hw/rtl8139.c | 172 > +- > 1 files changed, 51 insertions(+), 121 deletions(-) > > diff --git a/hw/rtl8139.c b/hw/rtl8139.c > index 5214b8c..fa661fc

Re: [Qemu-devel] [PATCH] os-posix: set groups properly for -runas

2011-07-12 Thread Blue Swirl
Thanks, applied. On Sat, Jul 9, 2011 at 12:22 PM, Stefan Hajnoczi wrote: > Andrew Griffiths reports that -runas does not set supplementary group > IDs.  This means that gid 0 (root) is not dropped when switching to an > unprivileged user. > > Add an initgroups(3) call to use the -runas user's /et

Re: [Qemu-devel] [PATCH v2] esp: cancel current request only if some request is in flight

2011-07-12 Thread Blue Swirl
Thanks, applied. 2011/7/9 Hervé Poussineau : > This bug was introduced in 94d3f98a3f3caddd7875f9a11776daeb84962a7b: > scsi_cancel_io was checking if some request was pending before trying > to cancel it, while scsi_req_cancel always cancels the request. > > This may lead to a crash of Qemu due to

Re: [Qemu-devel] Loading ELF binaries with very high base addresses

2011-07-12 Thread Richard Henderson
On 07/12/2011 01:58 PM, Prashant Vaibhav wrote: > Yes, exactly what happened when loading a non-trivial binary. :-( > Oh well. If you've got an ia64 cross-compiler, you could still make progress on qemu by building your own binaries and linking them somewhere convenient in the low 64 TB. r~

Re: [Qemu-devel] [PATCH v2] Remove unneeded setjmp.h (fix compilation on Debian "lenny")

2011-07-12 Thread Blue Swirl
Thanks, applied. On Mon, Jul 4, 2011 at 9:52 PM, Stefan Weil wrote: > Some versions of png.h cannot be included after setjmp.h, > even when PNG_SKIP_SETJMP_CHECK was defined. > > setjmp.h was included from qemu-common.h and is not needed there. > Removing the include statement fixes compilation o

Re: [Qemu-devel] [PATCH 1/2] Introduce compiler.h header file

2011-07-12 Thread Luiz Capitulino
On Wed, 13 Jul 2011 00:43:42 +0400 (MSD) malc wrote: > On Tue, 12 Jul 2011, Luiz Capitulino wrote: > > > On Wed, 13 Jul 2011 00:31:56 +0400 (MSD) > > malc wrote: > > > > > On Tue, 12 Jul 2011, Luiz Capitulino wrote: > > > > > > > From: Luiz Capitulino > > > > > > > > This moves compiler rel

Re: [Qemu-devel] [PATCH] target-alpha, target-ppc: Remove unnecessary setjmp.h include

2011-07-12 Thread Blue Swirl
Thanks, applied. On Tue, Jul 5, 2011 at 12:02 AM, Peter Maydell wrote: > Remove the include of setjmp.h from the cpu.h of target-alpha > and target-ppc. This is unnecessary because cpu-defs.h already > includes this header; this change brings these two targets > into line with all the rest. > > S

Re: [Qemu-devel] [PATCH] exec-all.h: Make MAX_OP_PER_INSTR large enough for target-arm's uses

2011-07-12 Thread Blue Swirl
Thanks, applied. On Wed, Jul 6, 2011 at 2:15 PM, Peter Maydell wrote: > Ping? > > On 22 June 2011 15:16, Peter Maydell wrote: >> The target-arm frontend's worst-case TCG ops per instr is 194 (and in >> general many of the "load multiple registers" ARM instructions generate >> more than 100 TCG o

Re: [Qemu-devel] Loading ELF binaries with very high base addresses

2011-07-12 Thread Prashant Vaibhav
Yes, exactly what happened when loading a non-trivial binary. :-( Oh well. On Wed, Jul 13, 2011 at 12:04 AM, Richard Henderson wrote: > On 07/12/2011 09:43 AM, Alexander Graf wrote: > > For now, just force the mapping to somewhere mappable :) > > Unfortunately, I can tell you that there is no

Re: [Qemu-devel] [PATCH] exec.c: Fix calculation of code_gen_buffer_max_size

2011-07-12 Thread Blue Swirl
Thanks, applied. On Wed, Jul 6, 2011 at 2:07 PM, Peter Maydell wrote: > Ping? > > On 22 June 2011 11:58, Peter Maydell wrote: >> When calculating the point at which we should not try to put another >> TB into the code gen buffer, we have to allow not just for OPC_MAX_SIZE >> but OPC_BUF_SIZE. Th

Re: [Qemu-devel] [PATCH] tcg: Reload local variables after return from longjmp

2011-07-12 Thread Blue Swirl
Thanks, applied. On Sat, Jul 2, 2011 at 10:50 AM, Jan Kiszka wrote: > From: Jan Kiszka > > Recent compilers look deep into cpu_exec, find longjmp as a noreturn > function and decide to smash some stack variables as they won't be used > again. This may lead to env becoming invalid after return fr

Re: [Qemu-devel] [PATCH 1/2] Introduce compiler.h header file

2011-07-12 Thread malc
On Tue, 12 Jul 2011, Luiz Capitulino wrote: > On Wed, 13 Jul 2011 00:31:56 +0400 (MSD) > malc wrote: > > > On Tue, 12 Jul 2011, Luiz Capitulino wrote: > > > > > From: Luiz Capitulino > > > > > > This moves compiler related macros from qemu-common.h to compiler.h. > > > > > > The reason for t

[Qemu-devel] [PATCH 2/2] qemu-config: Document -drive options

2011-07-12 Thread Luiz Capitulino
From: Luiz Capitulino Signed-off-by: Luiz Capitulino --- qemu-config.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/qemu-config.c b/qemu-config.c index c63741c..93d20c6 100644 --- a/qemu-config.c +++ b/qemu-config.c @@ -23,6 +23,7 @@ static QemuOptsList qemu_dri

Re: [Qemu-devel] [PATCH 6/9] pl080: use specific endian ld/st_phys

2011-07-12 Thread Peter Maydell
On 5 July 2011 17:28, Alexander Graf wrote: > --- a/hw/pl080.c > +++ b/hw/pl080.c > @@ -199,10 +199,10 @@ again: >             if (size == 0) { >                 /* Transfer complete.  */ >                 if (ch->lli) { > -                    ch->src = ldl_phys(ch->lli); > -                    ch

Re: [Qemu-devel] [PATCH 1/2] Introduce compiler.h header file

2011-07-12 Thread Luiz Capitulino
On Wed, 13 Jul 2011 00:31:56 +0400 (MSD) malc wrote: > On Tue, 12 Jul 2011, Luiz Capitulino wrote: > > > From: Luiz Capitulino > > > > This moves compiler related macros from qemu-common.h to compiler.h. > > > > The reason for this change is that there are simple header files that > > depend

Re: [Qemu-devel] [PATCH 1/2] Introduce compiler.h header file

2011-07-12 Thread malc
On Tue, 12 Jul 2011, Luiz Capitulino wrote: > From: Luiz Capitulino > > This moves compiler related macros from qemu-common.h to compiler.h. > > The reason for this change is that there are simple header files that > depend only on the compiler macros, so including qemu-common.h is overkill. >

[Qemu-devel] [PATCH v2 0/2]: block: Document -drive options

2011-07-12 Thread Luiz Capitulino
Please, see individual patches for details. v2 o Correct man-page text o Document -drive options in qemu-config.c qemu-config.c |6 ++ qemu-options.hx |8 2 files changed, 14 insertions(+), 0 deletions(-)

[Qemu-devel] [PATCH 1/2] qemu-options.hx: Document missing -drive options

2011-07-12 Thread Luiz Capitulino
They are 'werror', 'rerror' and 'readonly'. Signed-off-by: Luiz Capitulino --- qemu-options.hx |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index e6d7adc..64114dd 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -160,6 +16

[Qemu-devel] [PATCH] linux-user/signal.c: Rename s390 target_ucontext fields to fix ia64

2011-07-12 Thread Peter Maydell
The ia64 sys/ucontext.h defines macros 'uc_link', 'uc_sigmask' and 'uc_stack'. Rename the s390 target_ucontext struct members to tuc_*, bringing them into line with the other targets and fixing a compile failure on ia64 hosts caused by this clash. Signed-off-by: Peter Maydell --- linux-user/sign

Re: [Qemu-devel] [PATCH v2 1/9] exec: add endian specific phys ld/st functions

2011-07-12 Thread Blue Swirl
Thanks, applied all. On Tue, Jul 12, 2011 at 10:52 AM, Alexander Graf wrote: > > Am 06.07.2011 um 09:09 schrieb Alexander Graf : > >> Device code some times needs to access physical memory and does that >> through the ld./st._phys functions. However, these are the exact same >> functions that the

[Qemu-devel] [PATCH 2/2] Error: Fix build when qemu-common.h is not included

2011-07-12 Thread Luiz Capitulino
From: Luiz Capitulino Commit e4ea5e2d0e0e4c5188ab45b66f3195062ae059dc added the use of the macro GCC_FMT_ATTR to error.h, however compiler.h is not included by error.h This will cause a build error when files including error.h don't include qemu-common.h (or compiler.h). Not an issue today becau

Re: [Qemu-devel] [PATCH] os-posix: set groups properly for -runas

2011-07-12 Thread Chris Wright
* Chris Wright (chr...@sous-sol.org) wrote: > * Stefan Hajnoczi (stefa...@linux.vnet.ibm.com) wrote: > > @@ -199,6 +200,11 @@ static void change_process_uid(void) > > fprintf(stderr, "Failed to setgid(%d)\n", user_pwd->pw_gid); > > exit(1); > > } > > +if (

Re: [Qemu-devel] Loading ELF binaries with very high base addresses

2011-07-12 Thread Prashant Vaibhav
Thanks Marc and Alex, Yes it was 0x4<<60, missed a zero. I didn't know about the virtual regions, I assumed it was flat 64-bit. For now I am going with Alex's suggestion and forcing the mmap to happen at a lower memory address, starting at mmap_min_addr. The guest_base is then large, causing a wr

Re: [Qemu-devel] Loading ELF binaries with very high base addresses

2011-07-12 Thread Peter Maydell
On 12 July 2011 17:43, Alexander Graf wrote: > I guess the long-term solution here really is to use the softmmu for > linux-user as well - unless we're running 32-on-64. Even for 32-on-64 we need to control the guest's address space properly (so we don't do things like gratuitously failing mmap);

[Qemu-devel] [PATCH v2 0/2]: Fix build issue with error.h

2011-07-12 Thread Luiz Capitulino
A .c file including error.h and not including qemu-common.h will break the build, because error.h uses a macro defined in qemu-common.h. The simple and obvious fix would be to change error.h to include qemu-common.h. But this is overkill, so this series does some splitting in qemu-common.h and cha

[Qemu-devel] [PATCH 1/2] Introduce compiler.h header file

2011-07-12 Thread Luiz Capitulino
From: Luiz Capitulino This moves compiler related macros from qemu-common.h to compiler.h. The reason for this change is that there are simple header files that depend only on the compiler macros, so including qemu-common.h is overkill. Besides, qemu-common.h is bloated and will benefit from so

Re: [Qemu-devel] [PATCH v5] Add support for Zipit Z2 machine

2011-07-12 Thread Peter Maydell
On 6 July 2011 14:52, Vasily Khoruzhick wrote: > Zipit Z2 is small PXA270 based handheld. > > Signed-off-by: Vasily Khoruzhick > --- > v2: codestyle fixes, added VMStateDescription for LCD device and AER915, >    traces clean up. > v3: no changes > v4: no changes > v5: use DPRINTF for debug-relat

Re: [Qemu-devel] Loading ELF binaries with very high base addresses

2011-07-12 Thread Richard Henderson
On 07/12/2011 09:43 AM, Alexander Graf wrote: > For now, just force the mapping to somewhere mappable :) Unfortunately, I can tell you that there is no such place. The text segment is mapped by default at 0x4000 and the data segment is by default mapped at 0x6000. If you

Re: [Qemu-devel] [PATCH v5 00/10] trace-state: make the behaviour of "disable" consistent across all backends

2011-07-12 Thread Stefan Hajnoczi
On Tue, Jun 28, 2011 at 5:52 PM, Lluís wrote: > This patch defines the "disable" trace event state to always use the "nop" > backend. Apologies for not reviewing sooner. I have begun and will send feedback tomorrow. Stefan

[Qemu-devel] [Bug 807893] Re: [PATCH] os-posix: set groups properly for -runas

2011-07-12 Thread Chris Wright
* Stefan Hajnoczi (stefa...@linux.vnet.ibm.com) wrote: > @@ -199,6 +200,11 @@ static void change_process_uid(void) > fprintf(stderr, "Failed to setgid(%d)\n", user_pwd->pw_gid); > exit(1); > } > +if (initgroups(user_pwd->pw_name, user_pwd->pw_gid) < 0) { >

Re: [Qemu-devel] [PATCH 1/8] Introduce the VMStatus type

2011-07-12 Thread Luiz Capitulino
On Tue, 12 Jul 2011 18:16:26 +0200 Kevin Wolf wrote: > Am 12.07.2011 18:03, schrieb Luiz Capitulino: > > On Tue, 12 Jul 2011 12:12:31 -0300 > > Luiz Capitulino wrote: > > > >> On Tue, 12 Jul 2011 16:51:03 +0200 > >> Kevin Wolf wrote: > >> > >>> Am 12.07.2011 16:25, schrieb Luiz Capitulino: > >

Re: [Qemu-devel] Loading ELF binaries with very high base addresses

2011-07-12 Thread Alexander Graf
Hi Prashant, Am 12.07.2011 um 17:29 schrieb Prashant Vaibhav : > Hello, > > I am working on target-ia64, but am stuck during ia64 ELF loading. > > Referring to function "probe_guest_base()" in linux-user/elfload.c around > line 1350, called from around line 1484 -- > > When the main binary i

[Qemu-devel] [Bug 807893] Re: qemu privilege escalation

2011-07-12 Thread Chris Wright
Requesting CVE. Tools like libvirt deprivilege themselves before launching qemu as an unprivileged user (no use of -runas), so aren't vulnerable. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/807893

Re: [Qemu-devel] live block copy/stream/snapshot discussion

2011-07-12 Thread Adam Litke
On 07/12/2011 10:45 AM, Stefan Hajnoczi wrote: > On Tue, Jul 12, 2011 at 9:06 AM, Kevin Wolf wrote: >> Am 11.07.2011 18:32, schrieb Marcelo Tosatti: >>> On Mon, Jul 11, 2011 at 03:47:15PM +0100, Stefan Hajnoczi wrote: Kevin, Marcelo, I'd like to reach agreement on the QMP/HMP APIs for

[Qemu-devel] [Bug 807893] Re: qemu privilege escalation

2011-07-12 Thread Chris Wright
This bug is being tracked as CVE-2011-2527 ** CVE added: http://www.cve.mitre.org/cgi- bin/cvename.cgi?name=2011-2527 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/807893 Title: qemu privilege esc

[Qemu-devel] [Bug 656285] Re: arm-semi mishandling SYS_HEAPINFO

2011-07-12 Thread Peter Maydell
The patches I mention in commit #4 (and also a fix by Cedric Vincent for some other brk related bugs) have now been committed to qemu master. ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscr

Re: [Qemu-devel] [PATCH 1/8] Introduce the VMStatus type

2011-07-12 Thread Kevin Wolf
Am 12.07.2011 18:03, schrieb Luiz Capitulino: > On Tue, 12 Jul 2011 12:12:31 -0300 > Luiz Capitulino wrote: > >> On Tue, 12 Jul 2011 16:51:03 +0200 >> Kevin Wolf wrote: >> >>> Am 12.07.2011 16:25, schrieb Luiz Capitulino: On Tue, 12 Jul 2011 09:28:05 +0200 Markus Armbruster wrote: >>>

Re: [Qemu-devel] Loading ELF binaries with very high base addresses

2011-07-12 Thread Marc Lörner
Hello Prashant, first of all your "0x4<<64" is wrong it's "0x4<<60". In Volume 2 of the IASDM page 2:46 you see that these three upper bits correspond to the 8 virtual regions (here: region 2). So maybe you can just disregard these bits and use the rest as new offset to an faked guest_base that fit

Re: [Qemu-devel] qdev for programmers writeup

2011-07-12 Thread Paolo Bonzini
On 07/11/2011 06:47 PM, Peter Maydell wrote: On 11 July 2011 16:29, Paolo Bonzini wrote: On 07/11/2011 04:44 PM, Peter Maydell wrote: (Also if you have one bus type per board then you're still very limited in what you can do with -device because you can't plug in some random other sysbus devic

Re: [Qemu-devel] [PATCH 1/8] Introduce the VMStatus type

2011-07-12 Thread Luiz Capitulino
On Tue, 12 Jul 2011 12:12:31 -0300 Luiz Capitulino wrote: > On Tue, 12 Jul 2011 16:51:03 +0200 > Kevin Wolf wrote: > > > Am 12.07.2011 16:25, schrieb Luiz Capitulino: > > > On Tue, 12 Jul 2011 09:28:05 +0200 > > > Markus Armbruster wrote: > > > > > >> Luiz Capitulino writes: > > >> > > >>> W

Re: [Qemu-devel] [PATCH v6 4/4] guest agent: add guest agent RPCs/commands

2011-07-12 Thread Michael Roth
On 07/12/2011 09:15 AM, Luiz Capitulino wrote: On Mon, 11 Jul 2011 18:11:21 -0500 Michael Roth wrote: On 07/11/2011 04:12 PM, Luiz Capitulino wrote: On Mon, 11 Jul 2011 15:11:26 -0500 Michael Roth wrote: On 07/08/2011 10:14 AM, Luiz Capitulino wrote: On Tue, 5 Jul 2011 08:21:40 -0500 Mi

Re: [Qemu-devel] migration: new sections and backward compatibility.

2011-07-12 Thread Gerd Hoffmann
Hi, Well, in case of usb hid devices breaking the guest isn't that a big issue for at least some guests because they manage to reset the device and continue nevertheless ... In a situation like this, I think our responsibility is to let the user know that there could be a problem, and provid

Re: [Qemu-devel] live block copy/stream/snapshot discussion

2011-07-12 Thread Stefan Hajnoczi
On Tue, Jul 12, 2011 at 9:06 AM, Kevin Wolf wrote: > Am 11.07.2011 18:32, schrieb Marcelo Tosatti: >> On Mon, Jul 11, 2011 at 03:47:15PM +0100, Stefan Hajnoczi wrote: >>> Kevin, Marcelo, >>> I'd like to reach agreement on the QMP/HMP APIs for live block copy >>> and image streaming.  Libvirt has a

[Qemu-devel] [Bug 807893] Re: qemu privilege escalation

2011-07-12 Thread Andrew Griffiths
or any other linux vendor that has an interest in qemu :) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/807893 Title: qemu privilege escalation Status in QEMU: Confirmed Bug description: If q

Re: [Qemu-devel] [PATCH v6 4/4] guest agent: add guest agent RPCs/commands

2011-07-12 Thread Luiz Capitulino
On Tue, 12 Jul 2011 10:44:14 -0500 Michael Roth wrote: > On 07/12/2011 09:15 AM, Luiz Capitulino wrote: > > On Mon, 11 Jul 2011 18:11:21 -0500 > > Michael Roth wrote: > > > >> On 07/11/2011 04:12 PM, Luiz Capitulino wrote: > >>> On Mon, 11 Jul 2011 15:11:26 -0500 > >>> Michael Roth wrote: > >>

[Qemu-devel] [Bug 807893] Re: qemu privilege escalation

2011-07-12 Thread Andrew Griffiths
Yep, that fix looks fine. RedHat should have a CVE number for this issue. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/807893 Title: qemu privilege escalation Status in QEMU: Confirmed Bug des

[Qemu-devel] Loading ELF binaries with very high base addresses

2011-07-12 Thread Prashant Vaibhav
Hello, I am working on target-ia64, but am stuck during ia64 ELF loading. Referring to function "probe_guest_base()" in linux-user/elfload.c around line 1350, called from around line 1484 -- When the main binary is being mmap'd, the host address and guest address should ideally be the same. If t

Re: [Qemu-devel] live block copy/stream/snapshot discussion

2011-07-12 Thread Kevin Wolf
Am 12.07.2011 17:45, schrieb Stefan Hajnoczi: Image streaming API === For leaf images with copy-on-read semantics, the stream commands allow the user to populate local blocks by manually streaming them from the backing image. Once all blocks have

Re: [Qemu-devel] [PATCH 3/8] block: Support to keep track of I/O status

2011-07-12 Thread Luiz Capitulino
On Tue, 12 Jul 2011 16:25:22 +0200 Kevin Wolf wrote: > Am 05.07.2011 20:17, schrieb Luiz Capitulino: > > This commit adds support to the BlockDriverState type to keep track > > of the last I/O status. That is, at every I/O operation we update > > a status field in the BlockDriverState instance. V

[Qemu-devel] [Bug 807893] Re: [PATCH] os-posix: set groups properly for -runas

2011-07-12 Thread Stefan Hajnoczi
On Sat, Jul 9, 2011 at 10:22 AM, Stefan Hajnoczi wrote: > Andrew Griffiths reports that -runas does not set supplementary group > IDs.  This means that gid 0 (root) is not dropped when switching to an > unprivileged user. > > Add an initgroups(3) call to use the -runas user's /etc/groups > members

Re: [Qemu-devel] [PULL] spice patch queue

2011-07-12 Thread Gerd Hoffmann
On 07/04/11 17:14, Gerd Hoffmann wrote: Hi, Here is the spice patch queue with a bunch of small fixes and improvements collected over time. No major changes. please pull, Gerd The following changes since commit 75ef849696830fc2ddeff8bb90eea5887ff50df6: esp: correctly fill bus id wit

Re: [Qemu-devel] [PATCH v6 4/4] guest agent: add guest agent RPCs/commands

2011-07-12 Thread Luiz Capitulino
On Mon, 11 Jul 2011 18:11:21 -0500 Michael Roth wrote: > On 07/11/2011 04:12 PM, Luiz Capitulino wrote: > > On Mon, 11 Jul 2011 15:11:26 -0500 > > Michael Roth wrote: > > > >> On 07/08/2011 10:14 AM, Luiz Capitulino wrote: > >>> On Tue, 5 Jul 2011 08:21:40 -0500 > >>> Michael Roth wrote: > >>

Re: [Qemu-devel] [PULL] usb patch queue

2011-07-12 Thread Gerd Hoffmann
On 07/08/11 11:50, Gerd Hoffmann wrote: Hi, Here is the current usb patch queue. Most noteworthy is the usb companion controller support added. There are also a bunch of bug fixes, some from Hans which he found while doing the companion controller work and some have been found in patch revi

Re: [Qemu-devel] [PATCH 1/8] Introduce the VMStatus type

2011-07-12 Thread Kevin Wolf
Am 12.07.2011 16:25, schrieb Luiz Capitulino: > On Tue, 12 Jul 2011 09:28:05 +0200 > Markus Armbruster wrote: > >> Luiz Capitulino writes: >> >>> We need to track the VM status so that QMP can report it to clients. >>> >>> This commit adds the VMStatus type and related functions. The >>> vm_stat

Re: [Qemu-devel] [PATCH v5 05/18] qapi: add QMP input visitor

2011-07-12 Thread Michael Roth
On 07/12/2011 08:53 AM, Luiz Capitulino wrote: On Tue, 12 Jul 2011 08:46:13 -0500 Michael Roth wrote: On 07/12/2011 08:16 AM, Luiz Capitulino wrote: On Mon, 11 Jul 2011 19:05:58 -0500 Michael Roth wrote: On 07/07/2011 09:32 AM, Luiz Capitulino wrote: On Tue, 5 Jul 2011 08:02:32 -0500 Mi

Re: [Qemu-devel] [PATCH 1/8] Introduce the VMStatus type

2011-07-12 Thread Luiz Capitulino
On Tue, 12 Jul 2011 09:28:05 +0200 Markus Armbruster wrote: > Luiz Capitulino writes: > > > We need to track the VM status so that QMP can report it to clients. > > > > This commit adds the VMStatus type and related functions. The > > vm_status_set() function is used to keep track of the curren

Re: [Qemu-devel] [PATCH 3/8] block: Support to keep track of I/O status

2011-07-12 Thread Luiz Capitulino
On Tue, 12 Jul 2011 11:12:04 +0200 Markus Armbruster wrote: > Kevin Wolf writes: > > > Am 12.07.2011 09:45, schrieb Markus Armbruster: > >> Luiz Capitulino writes: > >> > >>> This commit adds support to the BlockDriverState type to keep track > >>> of the last I/O status. That is, at every I/

[Qemu-devel] [PATCHv3] qxl: add QXL_IO_FLUSH_{SURFACES, RELEASE} for guest S3&S4 support

2011-07-12 Thread Alon Levy
Add two new IOs. QXL_IO_FLUSH_SURFACES - equivalent to update area for all surfaces, used to reduce vmexits from NumSurfaces to 1 on guest S3, S4 and resolution change (windows driver implementation is such that this is done on each of those occasions). QXL_IO_FLUSH_RELEASE - used to ensure

Re: [Qemu-devel] [PATCH 1/8] Introduce the VMStatus type

2011-07-12 Thread Luiz Capitulino
On Tue, 12 Jul 2011 16:51:03 +0200 Kevin Wolf wrote: > Am 12.07.2011 16:25, schrieb Luiz Capitulino: > > On Tue, 12 Jul 2011 09:28:05 +0200 > > Markus Armbruster wrote: > > > >> Luiz Capitulino writes: > >> > >>> We need to track the VM status so that QMP can report it to clients. > >>> > >>>

[Qemu-devel] Fwd: [PATCH] Introduce "info migrate-times" monitor command

2011-07-12 Thread Michal Novotny
This accidentally didn't go to the list although it's been sent there (using git send-email)... Michal Original Message Subject:[PATCH] Introduce "info migrate-times" monitor command Date: Tue, 12 Jul 2011 15:28:27 +0200 From: Michal Novotny To: qemu-devel@nongn

[Qemu-devel] [PATCHv3] qxl: qxl_send_events: ignore if stopped (instead of abort)

2011-07-12 Thread Alon Levy
This can happen if there is an interface_get_command issued when the server has been stopped. easy to trigger - do stop/cont a few times (three seem to be enough). The "solution" of ignoring the request is bad, but better then aborting and a real solution would probably be in spice to not call get

[Qemu-devel] qemu add cpu AMD Opteron 61XX

2011-07-12 Thread Alex Fedor
Hello! What add new cpu AMD Opteron 61xx in QEMU ? my cpu: processor   : 47 vendor_id   : AuthenticAMD cpu family  : 16 model   : 9 model name  : AMD Opteron(tm) Processor 6174 stepping    : 1 cpu MHz : 2200.294 cache size  : 512 KB physical id : 3 sib

[Qemu-devel] [PATCHv3] qxl: async io support using new spice api

2011-07-12 Thread Alon Levy
Some of the QXL port i/o commands are waiting for the spice server to complete certain actions. Add async versions for these commands, so we don't block the vcpu while the spice server processses the command. Instead the qxl device will raise an IRQ when done. The async command processing relies

Re: [Qemu-devel] [PATCH 7/8] QMP: query-status: Add 'io-status' key

2011-07-12 Thread Luiz Capitulino
On Tue, 12 Jul 2011 09:47:19 +0200 Markus Armbruster wrote: > Luiz Capitulino writes: > > > Contains the last I/O status for the given device. Currently this is > > only supported by ide, scsi and virtio block devices. > > > > Signed-off-by: Luiz Capitulino > > --- > > block.c | 15

[Qemu-devel] [PATCHv3] qxl: only disallow specific io's in vga mode

2011-07-12 Thread Alon Levy
Since the driver is still in operation even after moving to UNDEFINED, i.e. by destroying primary in any way. --- hw/qxl.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 0585f02..1d6acce 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1175,8 +1175,9 @

[Qemu-devel] [PATCHv3] qxl-render: split out qxl_render_update_dirty_rectangles

2011-07-12 Thread Alon Levy
will later be reused from surface_updated callback when compiling against a newer spice-server. --- hw/qxl-render.c | 37 ++--- 1 files changed, 22 insertions(+), 15 deletions(-) diff --git a/hw/qxl-render.c b/hw/qxl-render.c index e64b646..d70373d 100644 --- a/h

[Qemu-devel] [PATCHv3] spice/qxl: move worker wrappers

2011-07-12 Thread Alon Levy
From: Gerd Hoffmann Move the wrapper functions which are used by qxl only to qxl.c. Rename them from qemu_spice_* to qxl_spice_*. Also pass in a qxl state pointer instead of a SimpleSpiceDisplay pointer. Signed-off-by: Gerd Hoffmann --- hw/qxl-render.c|4 +- hw/qxl.c | 66

[Qemu-devel] [PATCHv3] qxl: use QXL_REVISION_*

2011-07-12 Thread Alon Levy
--- hw/qxl.c | 22 ++ 1 files changed, 10 insertions(+), 12 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index d3b1581..17b5b39 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1375,7 +1375,6 @@ static DisplayChangeListener display_listener = { static int qxl_init_common(PCIQXLDev

[Qemu-devel] [PATCHv3] qxl: error handling fixes and cleanups.

2011-07-12 Thread Alon Levy
From: Gerd Hoffmann Add qxl_guest_bug() function which is supposed to be called in case sanity checks of guest requests fail. It raises an error IRQ and logs a message in case guest debugging is enabled. Make PANIC_ON() abort instead of exit. That macro should be used for qemu bugs only, any g

  1   2   >