Re: [Qemu-devel] [PATCH 0/5] atapi: Implement 'media' subcommand for GESN

2011-04-10 Thread Amit Shah
On (Fri) 08 Apr 2011 [11:39:26], Markus Armbruster wrote: > Results of quick test run now, patch review to follow. > > Test uses a simple program to try ioctl CDROM_DRIVE_STATUS (attached). ... > Test in guest without your patches: > > [start with empty drive] > # ./drive-status >

Re: [Qemu-devel] [PATCH] pflash: Restore & fix lazy ROMD switching

2011-04-10 Thread Jan Kiszka
On 2011-04-10 21:33, Jordan Justen wrote: > On Sun, Apr 10, 2011 at 03:53, Jan Kiszka wrote: >> Commit 5145b3d1cc revealed a bug in the lazy ROMD switch-back logic, but >> resolved it by breaking that feature. This approach addresses the issue >> by switching back to ROMD after a certain amount of

[Qemu-devel] Re: To O_EXCL or not to O_EXCL open host_cdrom

2011-04-10 Thread Amit Shah
On (Fri) 08 Apr 2011 [12:33:27], Stefan Hajnoczi wrote: > Amit and I were discussing the pros and cons of using O_EXCL to open > host CD-ROM devices on IRC but this discussion could benefit from more > input. > > Linux block devices (like /dev/sr0 CD-ROMs) can be opened with O_EXCL > and only one

[Qemu-devel] Re: [PATCH] ppc: remove a write-only variable

2011-04-10 Thread David Gibson
On Sat, Apr 09, 2011 at 05:28:06PM +0200, Alexander Graf wrote: > > > > > Am 09.04.2011 um 16:56 schrieb Blue Swirl : > > > Remove a write-only variable, spotted by GCC 4.6.0: > > /src/qemu/hw/ppc.c: In function 'power7_set_irq': > > /src/qemu/hw/ppc.c:255:9: error: variable 'cur_level' set bu

Re: [Qemu-devel] tcg/tcg.c:1892: tcg fatal error

2011-04-10 Thread Igor Kovalenko
On Mon, Apr 11, 2011 at 12:00 AM, Artyom Tarasenko wrote: > On Sun, Apr 10, 2011 at 9:41 PM, Igor Kovalenko > wrote: >> On Sun, Apr 10, 2011 at 11:37 PM, Artyom Tarasenko >> wrote: >>> On Sun, Apr 10, 2011 at 8:52 PM, Igor Kovalenko >>> wrote: On Sun, Apr 10, 2011 at 10:35 PM, Artyom Tara

[Qemu-devel] Re: [PATCH] target-ppc: remove #ifdef FLOAT128

2011-04-10 Thread Aurelien Jarno
On Sun, Apr 10, 2011 at 09:08:55PM +0100, Peter Maydell wrote: > On 10 April 2011 20:23, Alexander Graf wrote: > > On 10.04.2011, at 21:12, Aurelien Jarno wrote: > >> Now that PPC defaults to softfloat which always provides float128 > >> support, there is no need to keep two version of the code, d

Re: [Qemu-devel] Re: [PATCH 4/5] softfloat: add float{32, 64, x80, 128}_unordered() functions

2011-04-10 Thread Aurelien Jarno
On Sun, Apr 10, 2011 at 08:59:04PM +0100, Peter Maydell wrote: > On 10 April 2011 20:13, Aurelien Jarno wrote: > > Add float{32,64,x80,128}_unordered() functions to softfloat, matching > > the softfloat-native ones. This allow target-i386/ops_sse.h to be > > compiled with softfloat. > > I guess y

Re: [Qemu-devel] [PATCH 08/15] s390x: virtio machine storage keys

2011-04-10 Thread Aurelien Jarno
On Mon, Apr 04, 2011 at 04:32:17PM +0200, Alexander Graf wrote: > For emulation (and migration) we need to know about the guest's storage keys. > These are separate from actual RAM contents, so we need to allocate them in > parallel to RAM. > > While touching the file, this patch also adjusts the

Re: [Qemu-devel] [PATCH 07/15] s390x: Adjust GDB stub

2011-04-10 Thread Aurelien Jarno
On Mon, Apr 04, 2011 at 04:32:16PM +0200, Alexander Graf wrote: > We have successfully lazilized cc computation, so we need to manually > trigger its calculation when gdb wants to fetch it. We also changed the > variable name, so writing it writes into a different field now. > > Signed-off-by: Ale

Re: [Qemu-devel] [PATCH 06/15] s390x: Dispatch interrupts to KVM or the real CPU

2011-04-10 Thread Aurelien Jarno
On Mon, Apr 04, 2011 at 04:32:15PM +0200, Alexander Graf wrote: > The KVM interrupt injection path is non-generic for now. So we need to push > knowledge of how to inject a device interrupt using KVM into the actual device > code. > > Signed-off-by: Alexander Graf > --- > hw/s390-virtio-bus.c |

Re: [Qemu-devel] [PATCH 05/15] s390x: Enable s390x-softmmu target

2011-04-10 Thread Aurelien Jarno
On Mon, Apr 04, 2011 at 04:32:14PM +0200, Alexander Graf wrote: > This patch adds some code paths for running s390x guest OSs without the > need for KVM. > > Signed-off-by: Alexander Graf > --- > cpu-exec.c |8 > target-s390x/exec.h | 20 > 2 files ch

Re: [Qemu-devel] [PATCH 15/15] tcg: use ext op for deposit

2011-04-10 Thread Aurelien Jarno
On Sun, Apr 10, 2011 at 10:17:26PM +0200, Alexander Graf wrote: > > On 10.04.2011, at 22:08, Aurelien Jarno wrote: > > > On Sun, Apr 10, 2011 at 09:25:33PM +0200, Alexander Graf wrote: > >> > >> On 10.04.2011, at 21:23, Aurelien Jarno wrote: > >> > >>> On Tue, Apr 05, 2011 at 09:55:09AM +0200,

Re: [Qemu-devel] [PATCH 01/15] s390x: fix virtio feature bitmap

2011-04-10 Thread Aurelien Jarno
On Sun, Apr 10, 2011 at 10:11:15PM +0200, Alexander Graf wrote: > > On 10.04.2011, at 22:06, Aurelien Jarno wrote: > > > On Sun, Apr 10, 2011 at 09:26:26PM +0200, Alexander Graf wrote: > >> > >> On 10.04.2011, at 21:25, Aurelien Jarno wrote: > >> > >>> On Mon, Apr 04, 2011 at 04:32:10PM +0200,

Re: [Qemu-devel] [PATCH 04/15] linux-user: define a couple of syscalls for non-uid16 targets

2011-04-10 Thread Aurelien Jarno
On Mon, Apr 04, 2011 at 04:32:13PM +0200, Alexander Graf wrote: > From: Ulrich Hecht > > Quite a number of syscalls are only defined on systems with USE_UID16 > defined; this patch defines them on other systems as well. > > Fixes a large number of uid/gid-related testcases on the s390x target >

[Qemu-devel] Re: [PATCH] target-ppc: remove #ifdef FLOAT128

2011-04-10 Thread Alexander Graf
On 10.04.2011, at 22:08, Peter Maydell wrote: > On 10 April 2011 20:23, Alexander Graf wrote: >> On 10.04.2011, at 21:12, Aurelien Jarno wrote: >>> Now that PPC defaults to softfloat which always provides float128 >>> support, there is no need to keep two version of the code, depending if >>> fl

[Qemu-devel] Re: [PATCH 3/5] target-i386: fix cpu-exec.o build with softfloat

2011-04-10 Thread Peter Maydell
On 10 April 2011 20:13, Aurelien Jarno wrote: > Fixing the definition of CPU86_LDoubleU allow building cpu-exec.o with > softfloat. > > Cc: Peter Maydell > Signed-off-by: Aurelien Jarno > --- >  target-i386/exec.h |    4 ++-- >  1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/t

Re: [Qemu-devel] [PATCH 03/15] s390x: s390x-linux-user support

2011-04-10 Thread Aurelien Jarno
On Mon, Apr 04, 2011 at 04:32:12PM +0200, Alexander Graf wrote: > From: Ulrich Hecht > > This patch adds support for running s390x binaries in the linux-user emulation > code. > > Signed-off-by: Ulrich Hecht > Signed-off-by: Alexander Graf > > --- > > v1 -> v2: > > - always set 64bit flag

Re: [Qemu-devel] [PATCH 15/15] tcg: use ext op for deposit

2011-04-10 Thread Alexander Graf
On 10.04.2011, at 22:08, Aurelien Jarno wrote: > On Sun, Apr 10, 2011 at 09:25:33PM +0200, Alexander Graf wrote: >> >> On 10.04.2011, at 21:23, Aurelien Jarno wrote: >> >>> On Tue, Apr 05, 2011 at 09:55:09AM +0200, Alexander Graf wrote: On 05.04.2011, at 06:54, Aurelien Jarno wrote:

Re: [Qemu-devel] [PATCH 01/15] s390x: fix virtio feature bitmap

2011-04-10 Thread Alexander Graf
On 10.04.2011, at 22:06, Aurelien Jarno wrote: > On Sun, Apr 10, 2011 at 09:26:26PM +0200, Alexander Graf wrote: >> >> On 10.04.2011, at 21:25, Aurelien Jarno wrote: >> >>> On Mon, Apr 04, 2011 at 04:32:10PM +0200, Alexander Graf wrote: The feature bitmap in the s390 virtio machine is litt

Re: [Qemu-devel] [PATCH 15/15] tcg: use ext op for deposit

2011-04-10 Thread Aurelien Jarno
On Sun, Apr 10, 2011 at 09:25:33PM +0200, Alexander Graf wrote: > > On 10.04.2011, at 21:23, Aurelien Jarno wrote: > > > On Tue, Apr 05, 2011 at 09:55:09AM +0200, Alexander Graf wrote: > >> > >> On 05.04.2011, at 06:54, Aurelien Jarno wrote: > >> > >>> On Mon, Apr 04, 2011 at 04:32:24PM +0200,

[Qemu-devel] Re: [PATCH] target-ppc: remove #ifdef FLOAT128

2011-04-10 Thread Peter Maydell
On 10 April 2011 20:23, Alexander Graf wrote: > On 10.04.2011, at 21:12, Aurelien Jarno wrote: >> Now that PPC defaults to softfloat which always provides float128 >> support, there is no need to keep two version of the code, depending if >> float128 support is available or not. Suggested by Peter

Re: [Qemu-devel] [PATCH 01/15] s390x: fix virtio feature bitmap

2011-04-10 Thread Aurelien Jarno
On Sun, Apr 10, 2011 at 09:26:26PM +0200, Alexander Graf wrote: > > On 10.04.2011, at 21:25, Aurelien Jarno wrote: > > > On Mon, Apr 04, 2011 at 04:32:10PM +0200, Alexander Graf wrote: > >> The feature bitmap in the s390 virtio machine is little endian. To > >> address for that, we need to bswap

Re: [Qemu-devel] tcg/tcg.c:1892: tcg fatal error

2011-04-10 Thread Artyom Tarasenko
On Sun, Apr 10, 2011 at 9:41 PM, Igor Kovalenko wrote: > On Sun, Apr 10, 2011 at 11:37 PM, Artyom Tarasenko > wrote: >> On Sun, Apr 10, 2011 at 8:52 PM, Igor Kovalenko >> wrote: >>> On Sun, Apr 10, 2011 at 10:35 PM, Artyom Tarasenko >>> wrote: On Sun, Apr 10, 2011 at 7:57 PM, Blue Swirl

[Qemu-devel] Re: [PATCH 4/5] softfloat: add float{32, 64, x80, 128}_unordered() functions

2011-04-10 Thread Peter Maydell
On 10 April 2011 20:13, Aurelien Jarno wrote: > Add float{32,64,x80,128}_unordered() functions to softfloat, matching > the softfloat-native ones. This allow target-i386/ops_sse.h to be > compiled with softfloat. I guess you could have made the x86 target use float*_compare() instead, but I agree

Re: [Qemu-devel] tcg/tcg.c:1892: tcg fatal error

2011-04-10 Thread Artyom Tarasenko
On Sun, Apr 10, 2011 at 8:52 PM, Igor Kovalenko wrote: > On Sun, Apr 10, 2011 at 10:35 PM, Artyom Tarasenko > wrote: >> On Sun, Apr 10, 2011 at 7:57 PM, Blue Swirl wrote: >>> On Sun, Apr 10, 2011 at 8:48 PM, Artyom Tarasenko >>> wrote: On Sun, Apr 10, 2011 at 4:44 PM, Blue Swirl wrote:

Re: [Qemu-devel] [PATCH] pflash: Restore & fix lazy ROMD switching

2011-04-10 Thread Jordan Justen
On Sun, Apr 10, 2011 at 03:53, Jan Kiszka wrote: > Commit 5145b3d1cc revealed a bug in the lazy ROMD switch-back logic, but > resolved it by breaking that feature. This approach addresses the issue > by switching back to ROMD after a certain amount of read accesses > without further unlock sequenc

Re: [Qemu-devel] [PATCH 15/15] tcg: use ext op for deposit

2011-04-10 Thread Alexander Graf
On 10.04.2011, at 21:23, Aurelien Jarno wrote: > On Tue, Apr 05, 2011 at 09:55:09AM +0200, Alexander Graf wrote: >> >> On 05.04.2011, at 06:54, Aurelien Jarno wrote: >> >>> On Mon, Apr 04, 2011 at 04:32:24PM +0200, Alexander Graf wrote: With the s390x target we use the deposit instruction

Re: [Qemu-devel] [PATCH 02/15] s390x: set alignment for long to 8

2011-04-10 Thread Aurelien Jarno
On Mon, Apr 04, 2011 at 04:32:11PM +0200, Alexander Graf wrote: > The alignment for longs on s390x is 8. That's the only place where it differs > from the default alignments found in configure already. The example alignment > program from Laurent printed the following on a real s390x: > > aligno

[Qemu-devel] Re: [PATCH] target-ppc: remove #ifdef FLOAT128

2011-04-10 Thread Alexander Graf
On 10.04.2011, at 21:12, Aurelien Jarno wrote: > Now that PPC defaults to softfloat which always provides float128 > support, there is no need to keep two version of the code, depending if > float128 support is available or not. Suggested by Peter Maydell. > > Cc: Alexander Graf > Cc: Peter May

Re: [Qemu-devel] [PATCH 01/15] s390x: fix virtio feature bitmap

2011-04-10 Thread Alexander Graf
On 10.04.2011, at 21:25, Aurelien Jarno wrote: > On Mon, Apr 04, 2011 at 04:32:10PM +0200, Alexander Graf wrote: >> The feature bitmap in the s390 virtio machine is little endian. To >> address for that, we need to bswap the values after reading them out. >> >> Signed-off-by: Alexander Graf >>

Re: [Qemu-devel] [PATCH 01/15] s390x: fix virtio feature bitmap

2011-04-10 Thread Aurelien Jarno
On Mon, Apr 04, 2011 at 04:32:10PM +0200, Alexander Graf wrote: > The feature bitmap in the s390 virtio machine is little endian. To > address for that, we need to bswap the values after reading them out. > > Signed-off-by: Alexander Graf > --- > hw/s390-virtio-bus.c |4 ++-- > 1 files chang

Re: [Qemu-devel] [PATCH 15/15] tcg: use ext op for deposit

2011-04-10 Thread Aurelien Jarno
On Tue, Apr 05, 2011 at 09:55:09AM +0200, Alexander Graf wrote: > > On 05.04.2011, at 06:54, Aurelien Jarno wrote: > > > On Mon, Apr 04, 2011 at 04:32:24PM +0200, Alexander Graf wrote: > >> With the s390x target we use the deposit instruction to store 32bit values > >> into 64bit registers withou

[Qemu-devel] [PATCH 5/5] target-i386: add floatx_{add, mul, sub} and use them

2011-04-10 Thread Aurelien Jarno
Add floatx_{add,mul,sub} defines, and use them instead of using direct C operations. Cc: Peter Maydell Signed-off-by: Aurelien Jarno --- target-i386/exec.h |6 ++ target-i386/op_helper.c | 18 -- 2 files changed, 14 insertions(+), 10 deletions(-) diff --git a/tar

[Qemu-devel] [PATCH 4/5] softfloat: add float{32, 64, x80, 128}_unordered() functions

2011-04-10 Thread Aurelien Jarno
Add float{32,64,x80,128}_unordered() functions to softfloat, matching the softfloat-native ones. This allow target-i386/ops_sse.h to be compiled with softfloat. Cc: Peter Maydell Signed-off-by: Aurelien Jarno --- fpu/softfloat.c | 88 +++ fp

[Qemu-devel] [PATCH 1/5] cpu-all.h: define CPU_LDoubleU

2011-04-10 Thread Aurelien Jarno
Add a CPU_LDoubleU type, matching the floatx80 definition and the long double type on x86 hosts. Based on a patch from Laurent Vivier . Cc: Laurent Vivier Cc: Peter Maydell Signed-by: Aurelien Jarno --- cpu-all.h | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git

[Qemu-devel] [PATCH 3/5] target-i386: fix cpu-exec.o build with softfloat

2011-04-10 Thread Aurelien Jarno
Fixing the definition of CPU86_LDoubleU allow building cpu-exec.o with softfloat. Cc: Peter Maydell Signed-off-by: Aurelien Jarno --- target-i386/exec.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target-i386/exec.h b/target-i386/exec.h index 6f9f709..d6922f3 100

[Qemu-devel] [PATCH] target-sh4: get rid of CPU_{Float,Double}U

2011-04-10 Thread Aurelien Jarno
SH4 is always using softfloat, so it's possible to have helpers directly taking float32 or float64 value. This allow to get rid of conversions through CPU_{Float,Double}U. Cc: Peter Maydell Cc: Nathan Froyd Signed-off-by: Aurelien Jarno --- target-sh4/helper.h| 48 ++-- target-sh

[Qemu-devel] [PATCH 2/5] target-i386: use CPU_LDoubleU instead of a private union

2011-04-10 Thread Aurelien Jarno
Use CPU_LDoubleU in cpu_dump_state() instead of redefining a union for doing the conversion. Based on a patch from Laurent Vivier . Cc: Laurent Vivier Cc: Peter Maydell Signed-off-by: Aurelien Jarno --- target-i386/helper.c | 12 +++- 1 files changed, 3 insertions(+), 9 deletions(-)

[Qemu-devel] [PATCH] softfloat: use GCC builtins to count the leading zeros

2011-04-10 Thread Aurelien Jarno
Softfloat has its own implementation to count the leading zeros. However a lot of architectures have either a dedicated instruction or an optimized to do that. When using GCC >= 3.4, this patch uses GCC builtins instead of the handcoded implementation. Note that I amware that QEMU_GNUC_PREREQ is d

[Qemu-devel] [PATCH] target-ppc: remove #ifdef FLOAT128

2011-04-10 Thread Aurelien Jarno
Now that PPC defaults to softfloat which always provides float128 support, there is no need to keep two version of the code, depending if float128 support is available or not. Suggested by Peter Maydell. Cc: Alexander Graf Cc: Peter Maydell Signed-off-by: Aurelien Jarno --- target-ppc/op_helpe

Re: [Qemu-devel] QEMU testing methodology & results

2011-04-10 Thread Roberto Paleari
On Fri, Apr 8, 2011 at 9:56 PM, Blue Swirl wrote: > Very interesting! Thank you! > KEmuFuzzer seems to be more general. The approach of the patch is a > bit intrusive. But there are similarities with it and GDB interface, > tracepoints and other instrumentation needs, so it may be possible to >

Re: [Qemu-devel] tcg/tcg.c:1892: tcg fatal error

2011-04-10 Thread Igor Kovalenko
On Sun, Apr 10, 2011 at 10:35 PM, Artyom Tarasenko wrote: > On Sun, Apr 10, 2011 at 7:57 PM, Blue Swirl wrote: >> On Sun, Apr 10, 2011 at 8:48 PM, Artyom Tarasenko >> wrote: >>> On Sun, Apr 10, 2011 at 4:44 PM, Blue Swirl wrote: On Sun, Apr 10, 2011 at 5:09 PM, Artyom Tarasenko wro

Re: [Qemu-devel] tcg/tcg.c:1892: tcg fatal error

2011-04-10 Thread Artyom Tarasenko
On Sun, Apr 10, 2011 at 7:57 PM, Blue Swirl wrote: > On Sun, Apr 10, 2011 at 8:48 PM, Artyom Tarasenko wrote: >> On Sun, Apr 10, 2011 at 4:44 PM, Blue Swirl wrote: >>> On Sun, Apr 10, 2011 at 5:09 PM, Artyom Tarasenko >>> wrote: On Sun, Apr 10, 2011 at 3:24 PM, Aurelien Jarno wrote

Re: [Qemu-devel] Re: [PATCH] hw/pflash_cfi02: Fix lazy reset of ROMD mode

2011-04-10 Thread Jordan Justen
On Sun, Apr 10, 2011 at 01:38, Jan Kiszka wrote: > Indeed, that block looks weird to its author today as well. But > inverting the logic completely defeats the purpose of lazy mode > switching (will likely file a patch to remove the block). Looking at the 2nd parameter to the call, and the pflash

[Qemu-devel] [PATCH 2/4] qemu-timer: Remove unneeded include statement (w32)

2011-04-10 Thread Stefan Weil
mmsystem.h is not needed in qemu-timer.h, so remove it. Signed-off-by: Stefan Weil --- qemu-timer.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/qemu-timer.h b/qemu-timer.h index 75d5675..a932b09 100644 --- a/qemu-timer.h +++ b/qemu-timer.h @@ -7,7 +7,6 @@ #ifdef _

[Qemu-devel] [PATCH 3/4] qemu-timer: Avoid type casts

2011-04-10 Thread Stefan Weil
The type casts are no longer needed after some small changes in struct qemu_alarm_timer. This also improves readability of the code. Signed-off-by: Stefan Weil --- qemu-timer.c | 42 ++ 1 files changed, 22 insertions(+), 20 deletions(-) diff --git a/qem

[Qemu-devel] [PATCH 4/4] qemu-timer: Fix timers for w32

2011-04-10 Thread Stefan Weil
Commit 68c23e5520e8286d79d96ab47c0ea722ceb75041 removed the multimedia timer, but this timer is needed for certain Linux kernels. Otherwise Linux boot stops with this error: MP-BIOS bug: 8254 timer not connected to IO-APIC So the multimedia timer is added again here. Cc: Paolo Bonzini Signe

[Qemu-devel] [PATCH 1/4] qemu-timer: Add and use new function qemu_timer_expired_ns

2011-04-10 Thread Stefan Weil
This simply moves code which is used three times into a new function thus improving readability. Signed-off-by: Stefan Weil --- qemu-timer.c | 17 ++--- 1 files changed, 10 insertions(+), 7 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index 50f1943..c3ad72a 100644 --- a/q

[Qemu-devel] qemu-timer: Clean code and re-add multimedia timers for windows

2011-04-10 Thread Stefan Weil
This patch series contains patches for qemu-timer. The first 3 patches try to improve readability of the code. Patch 1 was already sent to qemu-devel. The last patch fixes a problem reported by a user of my QEMU for Windows binaries: the multimedia timers are needed when users want to run current

Re: [Qemu-devel] tcg/tcg.c:1892: tcg fatal error

2011-04-10 Thread Blue Swirl
On Sun, Apr 10, 2011 at 8:48 PM, Artyom Tarasenko wrote: > On Sun, Apr 10, 2011 at 4:44 PM, Blue Swirl wrote: >> On Sun, Apr 10, 2011 at 5:09 PM, Artyom Tarasenko >> wrote: >>> On Sun, Apr 10, 2011 at 3:24 PM, Aurelien Jarno >>> wrote: On Sun, Apr 10, 2011 at 02:29:59PM +0200, Artyom Tar

Re: [Qemu-devel] tcg/tcg.c:1892: tcg fatal error

2011-04-10 Thread Artyom Tarasenko
On Sun, Apr 10, 2011 at 4:44 PM, Blue Swirl wrote: > On Sun, Apr 10, 2011 at 5:09 PM, Artyom Tarasenko wrote: >> On Sun, Apr 10, 2011 at 3:24 PM, Aurelien Jarno wrote: >>> On Sun, Apr 10, 2011 at 02:29:59PM +0200, Artyom Tarasenko wrote: Trying to boot some proprietary OS I get qemu-system-

Re: [Qemu-devel] tcg/tcg.c:1892: tcg fatal error

2011-04-10 Thread Artyom Tarasenko
On Sun, Apr 10, 2011 at 4:59 PM, Peter Maydell wrote: > On 10 April 2011 15:09, Artyom Tarasenko wrote: >> Does it mean the last block is processed correctly and the crash >> happens on the next instruction which doesn't make it to the log? > > ...maybe tcg_abort() should do a qemu_log_flush()...

[Qemu-devel] [PATCH] Replace cpu_physical_memory_rw were possible

2011-04-10 Thread Stefan Weil
Using cpu_physical_memory_read, cpu_physical_memory_write and ldub_phys improves readability and allows removing some type casts. lduw_phys and ldl_phys were not used because both require aligned addresses. Therefore it is not possible to simply replace existing calls by one of these functions. C

[Qemu-devel] [PATCH 1/3 v2] cpu-common: Modify cpu_physical_memory_read and cpu_physical_memory_write

2011-04-10 Thread Stefan Weil
A lot of calls don't operate on bytes but on words or on structured data. So instead of a pointer to uint8_t, a void pointer is the better choice. This allows removing many type casts. (Some very early implementations of memcpy used char pointers which were replaced by void pointers for the same

Re: [Qemu-devel] Re: software breakpoints disappearing/reappearing in KVM/qemu

2011-04-10 Thread Jan Kiszka
On 2011-04-10 16:41, Avi Kivity wrote: > On 04/10/2011 05:23 PM, Jan Kiszka wrote: >> On 2011-04-10 16:01, Avi Kivity wrote: >> > On 04/08/2011 11:52 PM, Jan Kiszka wrote: >> >> QEMU's gdbstub in KVM mode is simply not designed to account for >> guests >> >> swapping out code pages that contain

Re: [Qemu-devel] tcg/tcg.c:1892: tcg fatal error

2011-04-10 Thread Peter Maydell
On 10 April 2011 15:09, Artyom Tarasenko wrote: > Does it mean the last block is processed correctly and the crash > happens on the next instruction which doesn't make it to the log? ...maybe tcg_abort() should do a qemu_log_flush()...? -- PMM

Re: [Qemu-devel] tcg/tcg.c:1892: tcg fatal error

2011-04-10 Thread Blue Swirl
On Sun, Apr 10, 2011 at 5:09 PM, Artyom Tarasenko wrote: > On Sun, Apr 10, 2011 at 3:24 PM, Aurelien Jarno wrote: >> On Sun, Apr 10, 2011 at 02:29:59PM +0200, Artyom Tarasenko wrote: >>> Trying to boot some proprietary OS I get qemu-system-sparc64 crash with a >>> >>> tcg/tcg.c:1892: tcg fatal er

Re: [Qemu-devel] Re: software breakpoints disappearing/reappearing in KVM/qemu

2011-04-10 Thread Avi Kivity
On 04/10/2011 05:23 PM, Jan Kiszka wrote: On 2011-04-10 16:01, Avi Kivity wrote: > On 04/08/2011 11:52 PM, Jan Kiszka wrote: >> QEMU's gdbstub in KVM mode is simply not designed to account for guests >> swapping out code pages that contain breakpoints. Due to the fact that >> the Linux kernel

Re: [Qemu-devel] Re: software breakpoints disappearing/reappearing in KVM/qemu

2011-04-10 Thread Jan Kiszka
On 2011-04-10 16:01, Avi Kivity wrote: > On 04/08/2011 11:52 PM, Jan Kiszka wrote: >> QEMU's gdbstub in KVM mode is simply not designed to account for guests >> swapping out code pages that contain breakpoints. Due to the fact that >> the Linux kernel does not do these weird things to its own code,

Re: [Qemu-devel] tcg/tcg.c:1892: tcg fatal error

2011-04-10 Thread Artyom Tarasenko
On Sun, Apr 10, 2011 at 3:24 PM, Aurelien Jarno wrote: > On Sun, Apr 10, 2011 at 02:29:59PM +0200, Artyom Tarasenko wrote: >> Trying to boot some proprietary OS I get qemu-system-sparc64 crash with a >> >> tcg/tcg.c:1892: tcg fatal error >> >> error message. >> >> It looks like it can be a platfor

Re: [Qemu-devel] Re: software breakpoints disappearing/reappearing in KVM/qemu

2011-04-10 Thread Avi Kivity
On 04/08/2011 11:52 PM, Jan Kiszka wrote: QEMU's gdbstub in KVM mode is simply not designed to account for guests swapping out code pages that contain breakpoints. Due to the fact that the Linux kernel does not do these weird things to its own code, It actually happily patches its own code at c

Re: [Qemu-devel] tcg/tcg.c:1892: tcg fatal error

2011-04-10 Thread Aurelien Jarno
On Sun, Apr 10, 2011 at 02:29:59PM +0200, Artyom Tarasenko wrote: > Trying to boot some proprietary OS I get qemu-system-sparc64 crash with a > > tcg/tcg.c:1892: tcg fatal error > > error message. > > It looks like it can be a platform independent bug though, because > when a '-singlestep' optio

Re: [Qemu-devel] [PATCH 1/3] cpu-common: Modify cpu_physical_memory_read and cpu_physical_memory_write

2011-04-10 Thread Aurelien Jarno
On Sun, Apr 10, 2011 at 08:16:05AM +0200, Stefan Weil wrote: > Am 10.04.2011 00:37, schrieb Aurelien Jarno: > >On Sat, Mar 26, 2011 at 09:06:55PM +0100, Stefan Weil wrote: > >>A lot of calls don't operate on bytes but on words or on structured data. > >>So instead of a pointer to uint8_t, a void po

Re: [Qemu-devel] [PATCH 1/3] cpu-common: Modify cpu_physical_memory_read and cpu_physical_memory_write

2011-04-10 Thread Artyom Tarasenko
On Sat, Mar 26, 2011 at 9:06 PM, Stefan Weil wrote: > A lot of calls don't operate on bytes but on words or on structured data. > So instead of a pointer to uint8_t, a void pointer is the better choice. Wouldn't it make the endianness conversions more complex? uint8_t[] has a very obvious byte or

[Qemu-devel] Re: [PATCH] musicpal: Fix registration of MMIO-less sysbus devices

2011-04-10 Thread Aurelien Jarno
On Sun, Apr 10, 2011 at 09:35:42AM +0200, Jan Kiszka wrote: > The proper way to signal that a sysbus devices need no MMIO region is to > pass -1 to sysbus_create_simple. > > Signed-off-by: Jan Kiszka > --- > hw/musicpal.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) Thanks, a

[Qemu-devel] tcg/tcg.c:1892: tcg fatal error

2011-04-10 Thread Artyom Tarasenko
Trying to boot some proprietary OS I get qemu-system-sparc64 crash with a tcg/tcg.c:1892: tcg fatal error error message. It looks like it can be a platform independent bug though, because when a '-singlestep' option IS present, qemu doesn't crash and seems to translate the code properly. (gdb)

Re: [Qemu-devel] [PATCH 1/3] arm: basic support for ARMv4/ARMv4T emulation

2011-04-10 Thread Marek Vasut
On Monday 04 April 2011 15:38:44 Dmitry Eremin-Solenikov wrote: > Currently target-arm/ assumes at least ARMv5 core. Add support for > handling also ARMv4/ARMv4T. This changes the following instructions: > > BX(v4T and later) > > BKPT, BLX, CDP2, CLZ, LDC2, LDRD, MCRR, MCRR2, MRRC, MCRR, MRC2, MR

Re: [Qemu-devel] [PATCH 3/3] Basic implementation of Sharp Zaurus SL-5500 collie PDA

2011-04-10 Thread Aurelien Jarno
On Mon, Apr 04, 2011 at 05:38:46PM +0400, Dmitry Eremin-Solenikov wrote: > Add very basic implementation of collie PDA emulation. The system lacks > LoCoMo and graphics/sound emulation. Linux kernel boots up to mounting > rootfs (theoretically it can be provided in pflash images). > > Signed-off-b

Re: [Qemu-devel] [PATCH 4/4] qxl: allow QXL_IO_LOG also in vga

2011-04-10 Thread Alon Levy
On Sun, Apr 10, 2011 at 09:37:12PM +1000, Brad Hards wrote: > On Sun, 10 Apr 2011 08:26:06 pm Alon Levy wrote: > > -if (d->mode == QXL_MODE_NATIVE || d->mode == QXL_MODE_COMPAT) > > +if (d->mode == QXL_MODE_NATIVE || d->mode == QXL_MODE_COMPAT > > +|| (io_port == QXL_IO_

Re: [Qemu-devel] [PATCH 2/3] Implement basic part of SA-1110/SA-1100

2011-04-10 Thread Aurelien Jarno
On Mon, Apr 04, 2011 at 05:38:45PM +0400, Dmitry Eremin-Solenikov wrote: > Basic implementation of DEC/Intel SA-1100/SA-1110 chips emulation. > Implemented: > - IRQs > - GPIO > - PPC > - RTC > - UARTs (no IrDA/etc.) > - OST reused from pxa25x > > Everything else is TODO (esp. PM/idle/sleep!)

Re: [Qemu-devel] [PATCH 4/4] qxl: allow QXL_IO_LOG also in vga

2011-04-10 Thread Brad Hards
On Sun, 10 Apr 2011 08:26:06 pm Alon Levy wrote: > -if (d->mode == QXL_MODE_NATIVE || d->mode == QXL_MODE_COMPAT) > +if (d->mode == QXL_MODE_NATIVE || d->mode == QXL_MODE_COMPAT > +|| (io_port == QXL_IO_LOG)) I think this might look better with consistent use of brackets

Re: [Qemu-devel] [PATCH 1/3] arm: basic support for ARMv4/ARMv4T emulation

2011-04-10 Thread Aurelien Jarno
On Mon, Apr 04, 2011 at 05:38:44PM +0400, Dmitry Eremin-Solenikov wrote: > Currently target-arm/ assumes at least ARMv5 core. Add support for > handling also ARMv4/ARMv4T. This changes the following instructions: > > BX(v4T and later) > > BKPT, BLX, CDP2, CLZ, LDC2, LDRD, MCRR, MCRR2, MRRC, MCRR,

[Qemu-devel] [PATCH] pflash: Restore & fix lazy ROMD switching

2011-04-10 Thread Jan Kiszka
On 2011-04-10 10:38, Jan Kiszka wrote: > On 2011-04-03 22:16, Jordan Justen wrote: >> When checking pfl->rom_mode for when to lazily reenter ROMD mode, >> the value was check was the opposite of what it should have been. >> This prevent the part from returning to ROMD mode after a write >> was made

[Qemu-devel] [PATCH 3/4] qxl: add debug_cs and cmdlog_cs

2011-04-10 Thread Alon Levy
With this you can output the command log and/or the guest debug (driver) output to a chardev instead of stderr: -global qxl-vga.cmdlog_chardev=qxl_cmdlog_chardev -global qxl-vga.debug_chardev=qxl_debug_chardev useful for debugging. if no chardev is specified prints to stderr like the old code. --

[Qemu-devel] [PATCH 4/4] qxl: allow QXL_IO_LOG also in vga

2011-04-10 Thread Alon Levy
The driver may change us to vga mode and still issue a QXL_IO_LOG, which we can easily support. --- hw/qxl.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 86b98ee..4080325 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -943,7 +943,8 @@ static void io

[Qemu-devel] [PATCH 1/4] qxl: interface_get_command: fix reported mode

2011-04-10 Thread Alon Levy
report correct mode when in undefined mode. --- hw/qxl.c | 18 -- 1 files changed, 16 insertions(+), 2 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index fe4212b..63e295b 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -336,6 +336,21 @@ static void interface_get_init_info(QXLInstance *

[Qemu-devel] [PATCH 0/4] qxl: debug related fixes

2011-04-10 Thread Alon Levy
These patches contain three small fixes, and one patch requiring more review that adds support for using chardevs for specific debug information: one for guest debug prints, and another for qxl command ring logging. This allows easier parsing and logging of this data for debugging. Alon Levy (4):

[Qemu-devel] [PATCH 2/4] qxl: add mode to debugprint on destroy primary

2011-04-10 Thread Alon Levy
--- hw/qxl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 63e295b..ccd820c 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1009,7 +1009,7 @@ static void ioport_write(void *opaque, uint32_t addr, uint32_t val) break; case QXL_IO_DESTROY

Re: [Qemu-devel] Question about total_sectors in block/vpc.c

2011-04-10 Thread Lyu Mitnick
Hello Stefan, Is it your means: There is an assumption that a block device cannot be addressed below 512 byte sectors. A reasonable protection in block.c:bdrv_create() to check whether size is a multiple of BDRV_SECTOR_SIZE. Signed-off-by: Mitnick Lyu --- block.c | 10 ++ 1 files cha

Re: [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: add inject-nmi qmp command

2011-04-10 Thread Avi Kivity
On 04/08/2011 12:39 AM, Anthony Liguori wrote: On 04/07/2011 01:51 PM, Gleb Natapov wrote: NMI does not have to generate crash dump on every guest we support. Actually even for windows guest it does not generate one without tweaking registry. For all I know there is a guest that checks mail when

Re: [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: add inject-nmi qmp command

2011-04-10 Thread Avi Kivity
On 04/08/2011 12:41 AM, Anthony Liguori wrote: And it's a good thing to have, but exposing this as the only API to do something as simple as generating a guest crash dump is not the friendliest thing in the world to do to users. nmi is a fine name for something that corresponds to a real-lif

[Qemu-devel] Re: [PATCH] hw/pflash_cfi02: Fix lazy reset of ROMD mode

2011-04-10 Thread Jan Kiszka
On 2011-04-03 22:16, Jordan Justen wrote: > When checking pfl->rom_mode for when to lazily reenter ROMD mode, > the value was check was the opposite of what it should have been. > This prevent the part from returning to ROMD mode after a write > was made to the CFI rom region. > > Signed-off-by: J

[Qemu-devel] Re: Slow PXE boot in qemu.git (fast in qemu-kvm.git)

2011-04-10 Thread Avi Kivity
On 04/09/2011 03:50 AM, Anthony Liguori wrote: Maybe we're missing a coalesced io in qemu.git? e1000 coalesced mmio is in qemu.git (always the chance it's broken, of course). I don't think it would make a 5X difference in any case. -- error compiling committee.c: too many arguments to fun

[Qemu-devel] [PATCH] musicpal: Fix registration of MMIO-less sysbus devices

2011-04-10 Thread Jan Kiszka
The proper way to signal that a sysbus devices need no MMIO region is to pass -1 to sysbus_create_simple. Signed-off-by: Jan Kiszka --- hw/musicpal.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/musicpal.c b/hw/musicpal.c index d98aa8d..52b2931 100644 --- a/hw/m

[Qemu-devel] Re: [PATCH] configure: disable opengl per default

2011-04-10 Thread Jan Kiszka
On 2011-04-09 23:13, Michael Walle wrote: > There is a bug in nvidia's binary GPU driver, which causes a segmentation > fault if linked to libGL. > > Signed-off-by: Michael Walle > --- > configure |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/configure b/configur

[Qemu-devel] Re: [PATCHv2 3/3] unicore32: necessary modifications for other files to support unicore32

2011-04-10 Thread Blue Swirl
On Wed, Mar 30, 2011 at 11:29 AM, Guan Xuetao wrote: > > Signed-off-by: Guan Xuetao > --- >  configure                                |   11 +++- >  cpu-exec.c                               |   12 - >  default-configs/unicore32-linux-user.mak |    1 + >  elf.h