[Qemu-devel] 新年好,你的货到了

2011-02-09 Thread fanli
如果您看不到邮件内容,请点击这里>> 亲爱的,返利网 www.fanliwang.cn 最新入驻了一批商城,包括淘宝,京东,凡客等,一定有你需要的货品,通过返利网购买,有额外返利,还奖积分,帮你省钱,赶紧上去淘淘吧,点击进入>> 返利网可信吗?请看解放日报的一篇报道,为你揭秘返利网 背景 近来,随着网购市场的迅猛发展,购物返利网站如雨后春笋般在互联网上涌现出来。 随便在百度或者谷歌上搜索一下 “网购返利”,人们很容易就能找到一大批与此相关的网站。这些网站往往宣称,消费者在他们推荐的网购平台购物,不仅能在商家那里获得优惠,而且购物结束后,还能通过他们的网站按照一定比例拿到返还金

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-09 Thread Anthony Liguori
On 02/09/2011 09:15 PM, Blue Swirl wrote: On Wed, Feb 9, 2011 at 9:59 PM, Anthony Liguori wrote: On 02/09/2011 06:48 PM, Blue Swirl wrote: ISASerialState dev; isa_serial_init(&dev, 0, 0x274, 0x07, NULL, NULL); Do you mean that there should be a generic way of doing that,

[Qemu-devel] [PATCH] char: Prevent multiple devices opening same chardev

2011-02-09 Thread Amit Shah
Prevent: -chardev socket,path=/tmp/foo,server,nowait,id=c0 \ -device virtserialport,chardev=c0,id=vs0 \ -device virtserialport,chardev=c0,id=vs1 Reported-by: Mike Cao Signed-off-by: Amit Shah --- hw/qdev-properties.c |7 ++- qemu-char.h |1 + 2 files changed, 7 insertions(

Re: [Qemu-devel] Migration speed throttling, max_throttle in migration.c

2011-02-09 Thread Yoshiaki Tamura
2011/2/10 Thomas Treutner : > Am 09.02.2011 21:02, schrieb Anthony Liguori: >> >> The reason it's still this today is mainly historic. I've thought about >> making the default limit unlimited. I'm not sure if anyone has strong >> opinions. > > Personally, I'd appreciate that. TCP's congestion contr

[Qemu-devel] [PATCHv3 0/2] vhost: fix tap link down

2011-02-09 Thread Jason Wang
Michael S. Tsirkin writes: > qemu makes it possible to disable link at tap > which is not communicated to the guest but > causes all packets to be dropped. > > With vhost-net at the moment it just keeps going. > Fix by communicating to virtio net and have that > stop vhost-net. > > Signe

[Qemu-devel] Reminder about your invitation from Sam Liao

2011-02-09 Thread Sam Liao (LinkedIn Invitations)
LinkedIn This invitation is awaiting your response: From Sam Liao -- (c) 2011, LinkedIn Corporation

[Qemu-devel] [Bug 550863] Re: MicroBlaze QEMU skips jumps when using single steps in GDB

2011-02-09 Thread Edgar E. Iglesias
Hi, I've committed a patch (that I hope fixes this problem) into the qemu git repo. Cheers Look for the following commit: commit 6c5f738daec123020d32543fe90a6633a4f6643e Author: Edgar E. Iglesias Date: Thu Feb 10 00:46:09 2011 +0100 microblaze: Handle singlestepping over direct jmps

[Qemu-devel] [Bug 550863] Re: MicroBlaze QEMU skips jumps when using single steps in GDB

2011-02-09 Thread Edgar E. Iglesias
** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/550863 Title: MicroBlaze QEMU skips jumps when using single steps in GDB Status in QEMU: Fix

[Qemu-devel] Re: RFC: New API for PPC for vcpu mmu access

2011-02-09 Thread Scott Wood
On Thu, 3 Feb 2011 10:19:06 +0100 Alexander Graf wrote: > Yeah, that one's tricky. Usually the way the memory resolver in qemu works is > as follows: > > * kvm goes to qemu > * qemu fetches all mmu and register data from kvm > * qemu runs its mmu resolution function as if the target was emul

Re: [Qemu-devel] [PATCH v3] Fix ATA SMART and CHECK POWER MODE

2011-02-09 Thread Ryan Harper
* Brian Wheeler [2011-02-09 16:13]: > This patch fixes two things: > > 1) CHECK POWER MODE > > The error return value wasn't always zero, so it would show up as > offline. Error is now explicitly set to zero. > > 2) SMART > > The smart values that were returned were invalid and tools like s

[Qemu-devel] Re: RFC: New API for PPC for vcpu mmu access

2011-02-09 Thread Scott Wood
On Wed, 9 Feb 2011 18:21:40 +0100 Alexander Graf wrote: > > On 07.02.2011, at 21:15, Scott Wood wrote: > > > That's pretty much what the proposed API does -- except it uses a void > > pointer instead of uint64_t *. > > Oh? Did I miss something there? The proposal looked as if it only transfers

Re: [Qemu-devel] [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-09 Thread Stefan Weil
Am 09.02.2011 18:13, schrieb Blue Swirl: I think win32 situation is somewhat similar (but not nearly as bad as) to kqemu's. It was useful for some users, but there were no maintenance and when it got in the way, it was removed because nobody could fix it. But I'd prefer a solution where somebody

[Qemu-devel] [PATCH v3] Fix ATA SMART and CHECK POWER MODE

2011-02-09 Thread Brian Wheeler
This patch fixes two things: 1) CHECK POWER MODE The error return value wasn't always zero, so it would show up as offline. Error is now explicitly set to zero. 2) SMART The smart values that were returned were invalid and tools like skdump would not recognize that the smart data was act

Re: [Qemu-devel] Migration speed throttling, max_throttle in migration.c

2011-02-09 Thread Thomas Treutner
Am 09.02.2011 21:02, schrieb Anthony Liguori: The reason it's still this today is mainly historic. I've thought about making the default limit unlimited. I'm not sure if anyone has strong opinions. Personally, I'd appreciate that. TCP's congestion control when using 100MBit Ethernet seems to w

Re: [Qemu-devel] [RFC][PATCH v6 00/04] qtest: qemu unit testing framework

2011-02-09 Thread Michael Roth
On 02/09/2011 01:42 PM, Blue Swirl wrote: On Fri, Feb 4, 2011 at 3:49 PM, Michael Roth wrote: These patches apply to master (2-04-2011), and can also be obtained from: git://repo.or.cz/qemu/mdroth.git qtest_v1 OVERVIEW: QEMU currently lacks a standard means to do targeted unit testing of the

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-09 Thread Blue Swirl
On Wed, Feb 9, 2011 at 9:59 PM, Anthony Liguori wrote: > On 02/09/2011 06:48 PM, Blue Swirl wrote: >>> >>> ISASerialState dev; >>> >>> isa_serial_init(&dev, 0, 0x274, 0x07, NULL, NULL); >>> >> >> Do you mean that there should be a generic way of doing that, like >> sysbus_create_varargs() for qdev

Re: [Qemu-devel] Migration speed throttling, max_throttle in migration.c

2011-02-09 Thread Anthony Liguori
On 02/09/2011 07:13 PM, Thomas Treutner wrote: Hi, I was reading qemu's (qemu-kvm-0.13.0's, to be specific) live migration code to unterstand how the iterative dirty page transfer is implemented. During this I noticed that ram_save_live in arch_init.c is called quite often, more often than I

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-09 Thread Anthony Liguori
On 02/09/2011 06:48 PM, Blue Swirl wrote: ISASerialState dev; isa_serial_init(&dev, 0, 0x274, 0x07, NULL, NULL); Do you mean that there should be a generic way of doing that, like sysbus_create_varargs() for qdev, or just add inline functions which hide qdev property setup? I still think

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-09 Thread Anthony Liguori
On 02/09/2011 06:48 PM, Blue Swirl wrote: We can just do: ISASerialState dev; isa_serial_init(&dev, 0, 0x274, 0x07, NULL, NULL); Do you mean that there should be a generic way of doing that, like sysbus_create_varargs() for qdev, or just add inline functions which hide qdev property se

Re: [Qemu-devel] [PATCH] Fix ATA SMART and CHECK POWER MODE

2011-02-09 Thread Ryan Harper
* Brian Wheeler [2011-02-07 16:48]: > This patch fixes two things: > > 1) CHECK POWER MODE > > The error return value wasn't always zero, so it would show up as > offline. Error is now explicitly set to zero. > > 2) SMART > > The smart values that were returned were invalid and tools like skd

Re: [Qemu-devel] [RFC][PATCH v6 00/04] qtest: qemu unit testing framework

2011-02-09 Thread Blue Swirl
On Fri, Feb 4, 2011 at 3:49 PM, Michael Roth wrote: > These patches apply to master (2-04-2011), and can also be obtained from: > git://repo.or.cz/qemu/mdroth.git qtest_v1 > > OVERVIEW: > > QEMU currently lacks a standard means to do targeted unit testing of the > device model. Frameworks like kv

Re: [Qemu-devel] [PULL] linux-user changes

2011-02-09 Thread Aurelien Jarno
On Wed, Feb 09, 2011 at 10:59:40AM +0200, Riku Voipio wrote: > The following changes since commit c0c1dc992584b8ccbae0e8f8b09124b76662633b: > > cris, microblaze: use cpu_has_work (2011-02-08 20:37:39 +0100) > > are available in the git repository at: > git://gitorious.org/qemu-maemo/qemu.git

[Qemu-devel] QEMU network probes

2011-02-09 Thread Rayson Ho
Please review the probe addition in QEMU for the network module, note that I added probes for send & receive Ethernet frames for rtl8139 so far but not other network devices. Also for receive, the probe would only fire when a frame is successfully received, so any errors are ignored. =

Re: [Qemu-devel] [PATCH v2 1/6] softfloat: Add float16 type and float16 NaN handling functions

2011-02-09 Thread Peter Maydell
On 9 February 2011 18:40, Aurelien Jarno wrote: > You should also add it in the USE_SOFTFLOAT_STRUCT_TYPES case, so that > we can check the type correctness. Last time I tried, it was not > compiling in this mode Yeah, it doesn't compile, but it's not too hard to fix (at least for ARM targets). I

Re: [Qemu-devel] [PATCH v2 6/6] target-arm: Use standard FPSCR for Neon half-precision operations

2011-02-09 Thread Peter Maydell
On 9 February 2011 16:27, Peter Maydell wrote: > -uint32_t HELPER(vfp_fcvt_f32_to_f16)(float32 a, CPUState *env) > +static uint32_t do_fcvt_f32_to_f16(float32 a, CPUState *env, float_status *s) > +float32 HELPER(neon_fcvt_f32_to_f16)(uint32_t a, CPUState *env) > +float32 HELPER(vfp_fcvt_f32_to_

Re: [Qemu-devel] [PATCH] Make tb_alloc static.

2011-02-09 Thread Aurelien Jarno
On Tue, Feb 08, 2011 at 12:22:15PM +0100, Tristan Gingold wrote: > This function is only used within exec.c, so no need to make it public. > > Signed-off-by: Tristan Gingold > --- > exec-all.h |1 - > exec.c |4 +++- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a

Re: [Qemu-devel] [PATCH v3] Softfloat: Add support to softfloat to return floatxx_default_nan when, the corresponding target status flag is set.

2011-02-09 Thread Peter Maydell
On 9 February 2011 18:35, Aurelien Jarno wrote: > On Tue, Feb 08, 2011 at 08:06:57PM +, Peter Maydell wrote: >> On 8 February 2011 18:53, Peter Maydell wrote: >> Also, at the moment the commonNaNToFloatX(floatYToCommonNaN()) >> idiom doesn't do anything to avoid signaling NaNs showing up in >

Re: [Qemu-devel] [PATCH v2] target-arm: fix VSHLL Neon instruction.

2011-02-09 Thread Aurelien Jarno
On Wed, Feb 09, 2011 at 02:23:24PM +, Peter Maydell wrote: > On 9 February 2011 12:19, Christophe Lyon wrote: > > > > Fix bit mask used when widening the result of shift on narrow input. > > > > Signed-off-by: Christophe Lyon > > Confirmed with random instruction testing that this patch fixe

Re: [Qemu-devel] [PATCH v2] target-arm: implement vsli.64, vsri.64

2011-02-09 Thread Aurelien Jarno
On Wed, Feb 09, 2011 at 01:55:46PM +, Peter Maydell wrote: > On 8 February 2011 17:39, Christophe Lyon wrote: > > > > Signed-off-by: Christophe Lyon > > --- > > Submitted as a standalone patch as suggested by Peter, along with his > > corrections. > > Reviewed-by: Peter Maydell > Thanks,

Re: [Qemu-devel] [PATCH v2 3/6] softfloat: Fix single-to-half precision float conversions

2011-02-09 Thread Aurelien Jarno
On Wed, Feb 09, 2011 at 04:27:27PM +, Peter Maydell wrote: > Fix various bugs in the single-to-half-precision conversion code: > * input NaNs not correctly converted in IEEE mode >(fixed by defining and using a commonNaNToFloat16()) > * wrong values returned when converting NaN/Inf into n

Re: [Qemu-devel] [MIPS] Clear softfpu exception state for round, trunc, ceil and floor

2011-02-09 Thread Aurelien Jarno
On Tue, Feb 08, 2011 at 07:03:21PM -0800, Chris Dearman wrote: > MIPS FPU instructions should start with a clean softfpu status. This > is done for the arithmetic operations and cvt instructions, but not > for round, trunc, ceil and floor. > Good catch, I have applied the patch. -- Aurelien Jar

Re: [Qemu-devel] [PATCH v2 5/6] target-arm: Silence NaNs resulting from half-precision conversions

2011-02-09 Thread Aurelien Jarno
On Wed, Feb 09, 2011 at 04:27:29PM +, Peter Maydell wrote: > Silence the NaNs that may result from half-precision conversion, > as we do for the other conversions. > > Signed-off-by: Peter Maydell > --- > target-arm/helper.c | 12 ++-- > 1 files changed, 10 insertions(+), 2 deletio

Re: [Qemu-devel] [PATCH v2 2/6] softfloat: Honour default_nan_mode for float-to-float conversions

2011-02-09 Thread Aurelien Jarno
On Wed, Feb 09, 2011 at 04:27:26PM +, Peter Maydell wrote: > From: Christophe Lyon > > Honour the default_nan_mode flag when doing conversions between > different floating point formats, as well as when returning a NaN from > a two-operand floating point function. This corrects the behaviour

Re: [Qemu-devel] [PATCH v2 4/6] softfloat: Correctly handle NaNs in float16_to_float32()

2011-02-09 Thread Aurelien Jarno
On Wed, Feb 09, 2011 at 04:27:28PM +, Peter Maydell wrote: > Correctly handle NaNs in float16_to_float32(), by defining and > using a float16ToCommonNaN() function, as we do with the other formats. > > Signed-off-by: Peter Maydell > --- > fpu/softfloat-specialize.h | 17 + >

[Qemu-devel] [PATCH 2/2] pc: remove test on TARGET_PHYS_ADDR_BITS == 32

2011-02-09 Thread Aurelien Jarno
Both i386 and x86_64 targets are now using with target_phys_bits=64. Remove useless code. Signed-off-by: Aurelien Jarno --- hw/pc.c |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index 4dfdc0b..92e3843 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -968,1

Re: [Qemu-devel] [PATCH v2 1/6] softfloat: Add float16 type and float16 NaN handling functions

2011-02-09 Thread Aurelien Jarno
On Wed, Feb 09, 2011 at 04:27:25PM +, Peter Maydell wrote: > Add a float16 type to softfloat, rather than using bits16 directly. > Also add the missing functions float16_is_quiet_nan(), > float16_is_signaling_nan() and float16_maybe_silence_nan(), > which are needed for the float16 conversion r

[Qemu-devel] [PATCH 1/2] target-i386: set target_phys_bits to 64

2011-02-09 Thread Aurelien Jarno
qemu i386 used to support more than 4GB of RAM through PAE, but it has been disabled for an unknown reason. Reenable it. Note that simply running qemu x86_64 and emulating a 32-bit CPU is not a solution to this problem as it is about 15% slower (it needs to emulate 64 bit registers even if half of

Re: [Qemu-devel] [PATCH v3] Softfloat: Add support to softfloat to return floatxx_default_nan when, the corresponding target status flag is set.

2011-02-09 Thread Aurelien Jarno
Hi, On Tue, Feb 08, 2011 at 08:06:57PM +, Peter Maydell wrote: > On 8 February 2011 18:53, Peter Maydell wrote: > > On 8 February 2011 17:51, Christophe Lyon wrote: > >> - this means implementing float16ToCommonNaN, thus > >> float16_is_signaling_nan() > > > > ...like that, yes. > > I have

[Qemu-devel] [PATCH v2] Fix ATA SMART and CHECK POWER MODE

2011-02-09 Thread Brian Wheeler
This patch fixes two things: 1) CHECK POWER MODE The error return value wasn't always zero, so it would show up as offline. Error is now explicitly set to zero. 2) SMART The smart values that were returned were invalid and tools like skdump would not recognize that the smart data was actually

[Qemu-devel] Migration speed throttling, max_throttle in migration.c

2011-02-09 Thread Thomas Treutner
Hi, I was reading qemu's (qemu-kvm-0.13.0's, to be specific) live migration code to unterstand how the iterative dirty page transfer is implemented. During this I noticed that ram_save_live in arch_init.c is called quite often, more often than I expected (approx. 200 times for an idle 500MiB

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-09 Thread Blue Swirl
On Wed, Feb 9, 2011 at 4:44 PM, Anthony Liguori wrote: > On 02/09/2011 06:28 AM, Markus Armbruster wrote: >>> >>> Except that construction of a device requires initialization from an >>> array of variants (which is then type checked).  The way we store the >>> variants is lossy because we convert

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-09 Thread Aurelien Jarno
On Tue, Feb 08, 2011 at 04:08:28PM +0100, Aurelien Jarno wrote: > Aurelien Jarno a écrit : > > Paolo Bonzini a écrit : > >> On 02/08/2011 12:15 PM, Aurelien Jarno wrote: > >>> however > >>> it should not be done ignoring all the*current* drawbacks of the > >>> iothread mode. We know them (at least

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-09 Thread Blue Swirl
On Wed, Feb 9, 2011 at 12:43 PM, Anthony Liguori wrote: > On 02/08/2011 01:30 PM, Aurelien Jarno wrote: >> >> On Tue, Feb 08, 2011 at 06:13:53PM +0100, Markus Armbruster wrote: >> >>> >>> Chris Wright  writes: >>> >>> [...] >>> - qdev/vmstate both examples of partially completed work tha

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-02-09 Thread Blue Swirl
On Tue, Feb 8, 2011 at 5:09 PM, Aurelien Jarno wrote: > Anthony Liguori a écrit : >> On 02/08/2011 07:30 AM, Aurelien Jarno wrote: >>> So the strategy is let's break everything and wait for the maintainer to >>> fix that? This strategy doesn't work, we have seen for example that with >>> the SeaBI

[Qemu-devel] Re: RFC: New API for PPC for vcpu mmu access

2011-02-09 Thread Alexander Graf
On 07.02.2011, at 21:15, Scott Wood wrote: > On Mon, 7 Feb 2011 16:43:02 +0100 > Alexander Graf wrote: > >> On 04.02.2011, at 23:33, Scott Wood wrote: >> >>> On Thu, 3 Feb 2011 10:19:06 +0100 >>> Alexander Graf wrote: >>> Makes sense. So we basically need an ioctl that tells KVM the MMU

[Qemu-devel] Re: [PATCHv3 0/2] vhost: fix tap link down

2011-02-09 Thread Alex Williamson
On Wed, 2011-02-09 at 18:44 +0200, Michael S. Tsirkin wrote: > qemu makes it possible to disable link at tap > which is not communicated to the guest but > causes all packets to be dropped. > > With vhost-net at the moment it just keeps going. > Fix by communicating to virtio net and have that > s

Re: [Qemu-devel] Re: [PATCH 5/7] tcg-i386: Implement deposit operation.

2011-02-09 Thread Blue Swirl
On Wed, Feb 9, 2011 at 9:41 AM, Paolo Bonzini wrote: > On 02/08/2011 07:05 PM, Richard Henderson wrote: >> >> (Which is probably a mistake from a translator point of view -- there's >> no reason we can't emulate 16-bit operations with 32-bit operations given >> that the high bits are ignorable.) >

Re: [Qemu-devel] RE: /dev/mtd emulation

2011-02-09 Thread Artyom Tarasenko
On Wed, Feb 9, 2011 at 4:34 PM, Anton L. Vinokurov wrote: > Jan, Stefan, > > I've tried indeed but with no luck: > (qemu) info block > ide0-hd0: type=hd removable=0 file=vimage.dat ro=0 drv=raw encrypted=0 > mtd0: type=hd removable=0 file=firmware.bin ro=0 drv=raw encrypted=0 > floppy0: type=flopp

[Qemu-devel] Re: RFC: New API for PPC for vcpu mmu access

2011-02-09 Thread Alexander Graf
On 07.02.2011, at 20:56, Yoder Stuart-B08248 wrote: > > >> -Original Message- >> From: Wood Scott-B07421 >> Sent: Monday, February 07, 2011 12:52 PM >> To: Alexander Graf >> Cc: Yoder Stuart-B08248; Wood Scott-B07421; kvm-...@vger.kernel.org; >> k...@vger.kernel.org; qemu-devel@nongnu.o

[Qemu-devel] [PATCHv3 1/2] net: notify peer about link status change

2011-02-09 Thread Michael S. Tsirkin
qemu makes it possible to disable link at tap which is not communicated to the guest but causes all packets to be dropped. This works for virtio userspace, as qemu stops giving it packets, but not for virtio-net connected to vhost-net as that does not get notified about this change. Notify peer w

[Qemu-devel] [PATCHv3 0/2] vhost: fix tap link down

2011-02-09 Thread Michael S. Tsirkin
qemu makes it possible to disable link at tap which is not communicated to the guest but causes all packets to be dropped. With vhost-net at the moment it just keeps going. Fix by communicating to virtio net and have that stop vhost-net. Signed-off-by: Michael S. Tsirkin Reported-by: pradeep C

[Qemu-devel] [PATCH] qcow2: Fix order in L2 table COW

2011-02-09 Thread Kevin Wolf
When copying L2 tables (this happens only with internal snapshots), the order wasn't completely safe, so that after a crash you could end up with a L2 table that has too low refcount, possibly leading to corruption in the long run. This patch puts the operations in the right order: First allocate

[Qemu-devel] [PATCH v2 5/6] target-arm: Silence NaNs resulting from half-precision conversions

2011-02-09 Thread Peter Maydell
Silence the NaNs that may result from half-precision conversion, as we do for the other conversions. Signed-off-by: Peter Maydell --- target-arm/helper.c | 12 ++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/target-arm/helper.c b/target-arm/helper.c index d46defc..

[Qemu-devel] [PATCH v2 1/6] softfloat: Add float16 type and float16 NaN handling functions

2011-02-09 Thread Peter Maydell
Add a float16 type to softfloat, rather than using bits16 directly. Also add the missing functions float16_is_quiet_nan(), float16_is_signaling_nan() and float16_maybe_silence_nan(), which are needed for the float16 conversion routines. Signed-off-by: Peter Maydell --- fpu/softfloat-specialize.h

[Qemu-devel] [PATCH v2 3/6] softfloat: Fix single-to-half precision float conversions

2011-02-09 Thread Peter Maydell
Fix various bugs in the single-to-half-precision conversion code: * input NaNs not correctly converted in IEEE mode (fixed by defining and using a commonNaNToFloat16()) * wrong values returned when converting NaN/Inf into non-IEEE half precision value * wrong values returned for conversion

[Qemu-devel] [PATCHv3 2/2] vhost: disable on tap link down

2011-02-09 Thread Michael S. Tsirkin
qemu makes it possible to disable link at tap which is not communicated to the guest but causes all packets to be dropped. When vhost-net is enabled, vhost needs to be aware of both the virtio link_down and the peer link_down. we switch to userspace emulation when either is down. Signed-off-by: M

[Qemu-devel] [PATCH v2 6/6] target-arm: Use standard FPSCR for Neon half-precision operations

2011-02-09 Thread Peter Maydell
The Neon half-precision conversion operations (VCVT.F16.F32 and VCVT.F32.F16) use ARM standard floating-point arithmetic, unlike the VFP versions (VCVTB and VCVTT). Signed-off-by: Peter Maydell --- target-arm/helper.c| 26 ++ target-arm/helpers.h |2 ++ target

[Qemu-devel] [PATCH v2 4/6] softfloat: Correctly handle NaNs in float16_to_float32()

2011-02-09 Thread Peter Maydell
Correctly handle NaNs in float16_to_float32(), by defining and using a float16ToCommonNaN() function, as we do with the other formats. Signed-off-by: Peter Maydell --- fpu/softfloat-specialize.h | 17 + fpu/softfloat.c|4 +--- 2 files changed, 18 insertions(+),

[Qemu-devel] [PATCH v2 2/6] softfloat: Honour default_nan_mode for float-to-float conversions

2011-02-09 Thread Peter Maydell
From: Christophe Lyon Honour the default_nan_mode flag when doing conversions between different floating point formats, as well as when returning a NaN from a two-operand floating point function. This corrects the behaviour of float<->double conversions on both ARM and SH4. Signed-off-by: Christ

[Qemu-devel] [PATCH v2 0/6] target-arm: Fix floating point conversions

2011-02-09 Thread Peter Maydell
This patchset fixes two issues: * default_nan_mode not being honoured for float-to-float conversions * half precision conversions being broken in a number of ways as well as not handling default_nan_mode. With this patchset qemu passes random-instruction-selection tests for VCVT.F32.F16, VCVT

[Qemu-devel] [PATCH 1/2] target-arm: Fix VQMOVUN Neon instruction.

2011-02-09 Thread Peter Maydell
From: Juha Riihimäki VQMOVUN does a signed-to-unsigned saturating conversion. This is different from both the signed-to-signed and unsigned-to-unsigned conversions already implemented, so we need a new set of helper functions (neon_unarrow_sat*). Signed-off-by: Juha Riihimäki Reviewed-by: Peter

Re: [Qemu-devel] [PATCH v2] target-arm: implement vsli.64, vsri.64

2011-02-09 Thread Peter Maydell
On 8 February 2011 17:39, Christophe Lyon wrote: > > Signed-off-by: Christophe Lyon > --- > Submitted as a standalone patch as suggested by Peter, along with his > corrections. Reviewed-by: Peter Maydell -- PMM

Re: [Qemu-devel] [PATCH] target-arm: fix VQMOVUN Neon instruction.

2011-02-09 Thread Peter Maydell
On 9 February 2011 12:47, Christophe Lyon wrote: > > Create and use neon_unarrow_sat* helpers. > > Signed-off-by: Christophe Lyon This is OK code-wise, but since it has come from the meego tree it ought to have Juha's sign-off rather than yours. Also the commit message was another of the terse p

[Qemu-devel] [PATCH 0/2] target-arm: Fix VQMOV(U)N

2011-02-09 Thread Peter Maydell
This patchset fixes the VQMOV(U)N instructions (saturating narrowing conversions). Tested by random generation of instructions for VQMOVN, VQMOVUN, VMOVN. Patch 1/2 is the same as the one Christophe sent recently but I have corrected the authorship (this patch is from the meego tree). Juha Riihim

[Qemu-devel] [PATCH 2/2] target-arm: Fix 32 bit signed saturating narrow

2011-02-09 Thread Peter Maydell
The returned value when doing saturating signed 64->32 bit conversion of a negative number was incorrect due to a missing cast. Signed-off-by: Peter Maydell --- target-arm/neon_helper.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-arm/neon_helper.c b/target-ar

[Qemu-devel] RE: /dev/mtd emulation

2011-02-09 Thread Anton L. Vinokurov
Jan, Stefan, I've tried indeed but with no luck: (qemu) info block ide0-hd0: type=hd removable=0 file=vimage.dat ro=0 drv=raw encrypted=0 mtd0: type=hd removable=0 file=firmware.bin ro=0 drv=raw encrypted=0 floppy0: type=floppy removable=1 locked=0 [not inserted] sd0: type=floppy removable=1 locke

[Qemu-devel] [PATCH v2 04/15] Improve vm_stop reason declarations

2011-02-09 Thread Jan Kiszka
Define and use dedicated constants for vm_stop reasons, they actually have nothing to do with the EXCP_* defines used so far. At this chance, specify more detailed reasons so that VM state change handlers can evaluate them. Signed-off-by: Jan Kiszka --- Changes in v2: - VMSTOP_INTERRUPT -> VMST

[Qemu-devel] [PATCH v2 02/15] Refactor cpu_has_work/any_cpu_has_work in cpus.c

2011-02-09 Thread Jan Kiszka
Avoid duplicate use of the function name cpu_has_work, it's confusing, also their scope. Refactor cpu_has_work to cpu_thread_is_idle and do the same with any_cpu_has_work. Signed-off-by: Jan Kiszka --- Changes in v2: - renaming: cpu_thread_is_idle and all_cpu_threads_idle cpus.c | 43 ++

[Qemu-devel] Re: [PATCH 07/15] kvm: Separate TCG from KVM cpu execution

2011-02-09 Thread Jan Kiszka
On 2011-02-09 15:44, Marcelo Tosatti wrote: > On Wed, Feb 09, 2011 at 08:59:23AM +0100, Jan Kiszka wrote: >> On 2011-02-09 00:39, Marcelo Tosatti wrote: >>> On Mon, Feb 07, 2011 at 12:19:18PM +0100, Jan Kiszka wrote: Mixing up TCG bits with KVM already led to problems around eflags emulat

[Qemu-devel] Re: [PATCH 04/15] Improve vm_stop reason declarations

2011-02-09 Thread Jan Kiszka
On 2011-02-09 15:17, Marcelo Tosatti wrote: > On Wed, Feb 09, 2011 at 09:07:01AM +0100, Jan Kiszka wrote: >> On 2011-02-08 19:59, Marcelo Tosatti wrote: >>> On Mon, Feb 07, 2011 at 12:19:15PM +0100, Jan Kiszka wrote: index d6556c9..3397566 100644 --- a/gdbstub.c +++ b/gdbstub.c

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-09 Thread Anthony Liguori
On 02/09/2011 06:28 AM, Markus Armbruster wrote: Except that construction of a device requires initialization from an array of variants (which is then type checked). The way we store the variants is lossy because we convert back and forth to a string. Yes, there's overlap, but no, a qdev

[Qemu-devel] Re: [PATCH 02/15] Refactor cpu_has_work/any_cpu_has_work in cpus.c

2011-02-09 Thread Marcelo Tosatti
On Wed, Feb 09, 2011 at 09:07:50AM +0100, Jan Kiszka wrote: > > Do you really find it easier to read evaluations grouped with || ? I > > don't. > > I do, specifically as the old version was even more confusing in that > important detail "return 0" vs. "return 1". But even the new benefits > from t

[Qemu-devel] Re: [PATCH 07/15] kvm: Separate TCG from KVM cpu execution

2011-02-09 Thread Marcelo Tosatti
On Wed, Feb 09, 2011 at 08:59:23AM +0100, Jan Kiszka wrote: > On 2011-02-09 00:39, Marcelo Tosatti wrote: > > On Mon, Feb 07, 2011 at 12:19:18PM +0100, Jan Kiszka wrote: > >> Mixing up TCG bits with KVM already led to problems around eflags > >> emulation on x86. Moreover, quite some code that TCG

[Qemu-devel] Re: [PATCH 04/15] Improve vm_stop reason declarations

2011-02-09 Thread Marcelo Tosatti
On Wed, Feb 09, 2011 at 09:07:01AM +0100, Jan Kiszka wrote: > On 2011-02-08 19:59, Marcelo Tosatti wrote: > > On Mon, Feb 07, 2011 at 12:19:15PM +0100, Jan Kiszka wrote: > >> index d6556c9..3397566 100644 > >> --- a/gdbstub.c > >> +++ b/gdbstub.c > >> @@ -2194,14 +2194,14 @@ static void gdb_vm_stat

[Qemu-devel] Re: [PATCH master+0.14 0/2] blockdev memory leaks

2011-02-09 Thread Kevin Wolf
Am 09.02.2011 15:09, schrieb Justin M. Forbes: > On Wed, 2011-02-09 at 14:52 +0100, Kevin Wolf wrote: >> Hi Justin, >> >> Am 08.02.2011 15:12, schrieb Markus Armbruster: >>> Markus Armbruster (2): >>> blockdev: Plug memory leak in drive_uninit() >>> blockdev: Plug memory leak in drive_init() er

Re: [Qemu-devel] Re: [PATCH master+0.14 0/2] blockdev memory leaks

2011-02-09 Thread Anthony Liguori
On 02/09/2011 08:09 AM, Justin M. Forbes wrote: On Wed, 2011-02-09 at 14:52 +0100, Kevin Wolf wrote: Hi Justin, Am 08.02.2011 15:12, schrieb Markus Armbruster: Markus Armbruster (2): blockdev: Plug memory leak in drive_uninit() blockdev: Plug memory leak in drive_init() error p

Re: [Qemu-devel] [PATCH v2] target-arm: fix VSHLL Neon instruction.

2011-02-09 Thread Peter Maydell
On 9 February 2011 12:19, Christophe Lyon wrote: > > Fix bit mask used when widening the result of shift on narrow input. > > Signed-off-by: Christophe Lyon Confirmed with random instruction testing that this patch fixes VSHLL. Reviewed-by: Peter Maydell

[Qemu-devel] Re: [PATCH master+0.14 0/2] blockdev memory leaks

2011-02-09 Thread Justin M. Forbes
On Wed, 2011-02-09 at 14:52 +0100, Kevin Wolf wrote: > Hi Justin, > > Am 08.02.2011 15:12, schrieb Markus Armbruster: > > Markus Armbruster (2): > > blockdev: Plug memory leak in drive_uninit() > > blockdev: Plug memory leak in drive_init() error paths > > > > blockdev.c | 12 ++--

Re: [Qemu-devel] [PATCHv2] vhost: disable on tap link down

2011-02-09 Thread Michael S. Tsirkin
On Wed, Feb 09, 2011 at 09:52:22AM +0100, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > qemu makes it possible to disable link at tap > > which is not communicated to the guest but > > causes all packets to be dropped. > > > > Handle this with vhost simply by moving to the userspa

[Qemu-devel] [PATCH 6/6] target-arm: Use standard FPSCR for Neon half-precision operations

2011-02-09 Thread Peter Maydell
The Neon half-precision conversion operations (VCVT.F16.F32 and VCVT.F32.F16) use ARM standard floating-point arithmetic, unlike the VFP versions (VCVTB and VCVTT). Signed-off-by: Peter Maydell --- target-arm/helper.c| 26 ++ target-arm/helpers.h |2 ++ target

[Qemu-devel] Re: [PATCH master+0.14 0/2] blockdev memory leaks

2011-02-09 Thread Kevin Wolf
Hi Justin, Am 08.02.2011 15:12, schrieb Markus Armbruster: > Markus Armbruster (2): > blockdev: Plug memory leak in drive_uninit() > blockdev: Plug memory leak in drive_init() error paths > > blockdev.c | 12 ++-- > 1 files changed, 10 insertions(+), 2 deletions(-) How this series

[Qemu-devel] [PATCH 4/6] softfloat: Correctly handle NaNs in float16_to_float32()

2011-02-09 Thread Peter Maydell
Correctly handle NaNs in float16_to_float32(), by defining and using a float16ToCommonNaN() function, as we do with the other formats. Signed-off-by: Peter Maydell --- fpu/softfloat-specialize.h | 17 + fpu/softfloat.c|4 +--- 2 files changed, 18 insertions(+),

[Qemu-devel] [PATCH 0/6] target-arm: Fix floating point conversions

2011-02-09 Thread Peter Maydell
This patchset fixes two issues: * default_nan_mode not being honoured for float-to-float conversions * half precision conversions being broken in a number of ways as well as not handling default_nan_mode. With this patchset qemu passes random-instruction-selection tests for VCVT.F32.F16, VCVT

[Qemu-devel] [PATCH 1/6] softfloat: Add float16 type and float16 NaN handling functions

2011-02-09 Thread Peter Maydell
Add a float16 type to softfloat, rather than using bits16 directly. Also add the missing functions float16_is_quiet_nan(), float16_is_signaling_nan() and float16_maybe_silence_nan(), which are needed for the float16 conversion routines. Signed-off-by: Peter Maydell --- fpu/softfloat-specialize.h

[Qemu-devel] [PATCH 2/6] softfloat: Honour default_nan_mode for float-to-float conversions

2011-02-09 Thread Peter Maydell
Honour the default_nan_mode flag when doing conversions between different floating point formats, as well as when returning a NaN from a two-operand floating point function. This corrects the behaviour of float<->double conversions on both ARM and SH4. Signed-off-by: Christophe Lyon Signed-off-by

[Qemu-devel] [PATCH 3/6] softfloat: Fix single-to-half precision float conversions

2011-02-09 Thread Peter Maydell
Fix various bugs in the single-to-half-precision conversion code: * input NaNs not correctly converted in IEEE mode (fixed by defining and using a commonNaNToFloat16()) * wrong values returned when converting NaN/Inf into non-IEEE half precision value * wrong values returned for conversion

[Qemu-devel] [PATCH 5/6] target-arm: Silence NaNs resulting from half-precision conversions

2011-02-09 Thread Peter Maydell
Silence the NaNs that may result from half-precision conversion, as we do for the other conversions. Signed-off-by: Peter Maydell --- target-arm/helper.c | 12 ++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/target-arm/helper.c b/target-arm/helper.c index d46defc..

[Qemu-devel] [PATCH] target-arm: fix VQMOVUN Neon instruction.

2011-02-09 Thread Christophe Lyon
Create and use neon_unarrow_sat* helpers. Signed-off-by: Christophe Lyon --- target-arm/helpers.h |3 ++ target-arm/neon_helper.c | 63 ++ target-arm/translate.c | 28 3 files changed, 88 insertions(+), 6 deletions(-

Re: [Qemu-devel] [PATCH] qcow2: Fix error handling for reading compressed clusters

2011-02-09 Thread Markus Armbruster
Kevin Wolf writes: > When reading a compressed cluster failed, qcow2 falsely returned success. Reviewed-by: Markus Armbruster

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-09 Thread Markus Armbruster
Anthony Liguori writes: > On 02/09/2011 02:01 AM, Markus Armbruster wrote: >> Anthony Liguori writes: [...] >>> We need to unify the property model. We have QemuOpts, qdev >>> properties, and QObject which basically reinvents variant typing three >>> different ways. >>> >> Make it four: Q

[Qemu-devel] [PATCH v2] target-arm: fix VSHLL Neon instruction.

2011-02-09 Thread Christophe Lyon
Fix bit mask used when widening the result of shift on narrow input. Signed-off-by: Christophe Lyon --- target-arm/translate.c | 18 +++--- 1 files changed, 15 insertions(+), 3 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index b694eed..16c61f1 100644

Re: [Qemu-devel] [PATCH 1/8] target-arm: Fixes for several shift instructions: VRSHL, VRSHR, VRSHRN, VSHLL, VRSRA.

2011-02-09 Thread Christophe Lyon
On 07.02.2011 16:57, Peter Maydell wrote: > On 31 January 2011 18:06, wrote: >> For variants with rounding, fix cases where adding the rounding >> constant could overflow. >> >> For VSHLL, fix bit mask. > > These two things are completely distinct -- please put them > in separate patches. > OK

[Qemu-devel] Re: [PATCH master+0.14 0/2] blockdev memory leaks

2011-02-09 Thread Kevin Wolf
Am 08.02.2011 15:12, schrieb Markus Armbruster: > Markus Armbruster (2): > blockdev: Plug memory leak in drive_uninit() > blockdev: Plug memory leak in drive_init() error paths > > blockdev.c | 12 ++-- > 1 files changed, 10 insertions(+), 2 deletions(-) Thanks, applied all to the

[Qemu-devel] Re: [PATCH 3/4] qed: Report error for unsupported features

2011-02-09 Thread Kevin Wolf
Am 09.02.2011 12:21, schrieb Anthony Liguori: > On 02/09/2011 04:32 AM, Kevin Wolf wrote: >> @@ -311,7 +312,12 @@ static int bdrv_qed_open(BlockDriverState *bs, int >> flags) >> return -EINVAL; >> } >> if (s->header.features& ~QED_FEATURE_MASK) { >> -return -ENOTSUP;

[Qemu-devel] Re: [PATCH V6 1/4] nmi: convert cpu_index to cpu-index

2011-02-09 Thread Luiz Capitulino
On Wed, 09 Feb 2011 14:46:32 +0800 Lai Jiangshan wrote: > On 02/01/2011 09:29 PM, Luiz Capitulino wrote: > > On Thu, 27 Jan 2011 16:20:27 +0800 > > Lai Jiangshan wrote: > > > >> "cpu-index" which uses hyphen is better name. > >> > >> Signed-off-by: Lai Jiangshan > > > > It looks ok from a qu

[Qemu-devel] Re: [PATCH 3/4] qed: Report error for unsupported features

2011-02-09 Thread Anthony Liguori
On 02/09/2011 05:29 AM, Kevin Wolf wrote: Am 09.02.2011 12:21, schrieb Anthony Liguori: On 02/09/2011 04:32 AM, Kevin Wolf wrote: Instead of just returning -ENOTSUP, generate a more detailed error. Unfortunately we don't have a helpful text for features that we don't know yet, so jus

[Qemu-devel] Re: [PATCH 1/4] qerror: Add QERR_UNKNOWN_BLOCK_FORMAT_FEATURE

2011-02-09 Thread Anthony Liguori
On 02/09/2011 05:26 AM, Kevin Wolf wrote: Am 09.02.2011 12:08, schrieb Anthony Liguori: On 02/09/2011 04:31 AM, Kevin Wolf wrote: Signed-off-by: Kevin Wolf --- qerror.c |5 + qerror.h |3 +++ 2 files changed, 8 insertions(+), 0 deletions(-) diff --git a/qerror.c b/

[Qemu-devel] Re: [PATCH 3/4] qed: Report error for unsupported features

2011-02-09 Thread Kevin Wolf
Am 09.02.2011 12:21, schrieb Anthony Liguori: > On 02/09/2011 04:32 AM, Kevin Wolf wrote: >> Instead of just returning -ENOTSUP, generate a more detailed error. >> >> Unfortunately we don't have a helpful text for features that we don't know >> yet, >> so just print the feature mask. It might be u

Re: [Qemu-devel] [PATCH v4 2/3] qcow2: Use QcowCache

2011-02-09 Thread Avi Kivity
On 02/09/2011 01:19 PM, Avi Kivity wrote: On 01/20/2011 07:10 PM, Kevin Wolf wrote: Use the new functions of qcow2-cache.c for everything that works on refcount block and L2 tables. While autotesting qemu-kvm's stable-0.14 branch, this commit causes failures. The scenario is: - install O

[Qemu-devel] Re: [PATCH 1/4] qerror: Add QERR_UNKNOWN_BLOCK_FORMAT_FEATURE

2011-02-09 Thread Kevin Wolf
Am 09.02.2011 12:08, schrieb Anthony Liguori: > On 02/09/2011 04:31 AM, Kevin Wolf wrote: >> Signed-off-by: Kevin Wolf >> --- >> qerror.c |5 + >> qerror.h |3 +++ >> 2 files changed, 8 insertions(+), 0 deletions(-) >> >> diff --git a/qerror.c b/qerror.c >> index 9d0cdeb..62dcc1a 10

  1   2   >