[Qemu-devel] Re: [PATCH] slirp/tftp.c: fix mode field

2011-01-11 Thread Sergei Gavrikov
On Mon, 10 Jan 2011, Sergei Gavrikov wrote: > According to RFC 1350 http://www.ietf.org/rfc/rfc1350.txt [Page 5]: > > The mode field contains the string "netascii", "octet", or "mail" > (or any combination of upper and lower case, such as "NETASCII", > NetAscii", etc.) > > Unfortunate

[Qemu-devel] [PATCH] virtio-9p: Bugfix to send correct iounit

2011-01-11 Thread M. Mohan Kumar
LCREATE function packs address of iounit in the pdu, fix that to send actual iounit itself. Signed-off-by: M. Mohan Kumar Acked-by: Aneesh Kumar K.V --- hw/9pfs/virtio-9p.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c index

[Qemu-devel] Re: [PATCH 5/5] char: Equip the unix/tcp backend to handle nonblocking writes

2011-01-11 Thread Amit Shah
On (Tue) Jan 11 2011 [14:38:00], Paolo Bonzini wrote: > On 01/11/2011 12:10 PM, Amit Shah wrote: > >+char_set_fd_handlers(s->fd, tcp_chr_read_poll, tcp_chr_read, > >+ char_write_unblocked, chr, poll_out); > > Would the 4th parameter always be char_write_unblocked? If s

Re: [Qemu-devel] [PATCH 1/5] char: Add a QemuChrHandlers struct to initialise chardev handlers

2011-01-11 Thread Amit Shah
On (Tue) Jan 11 2011 [17:13:15], Blue Swirl wrote: > > +static QemuChrHandlers gdb_handlers = { > > +    .fd_can_read = gdb_chr_can_receive, > > +    .fd_read = gdb_chr_receive, > > +    .fd_event = gdb_chr_event, > > +}; > > These structures should be const. Hm, I had that but looks like it got

[Qemu-devel] Reminder about your invitation from Ozan Türkyılmaz

2011-01-11 Thread LinkedIn Invitations
LinkedIn This invitation is awaiting your response: From Ozan Türkyılmaz -- (c) 2010, LinkedIn Corporation

Re: [Qemu-devel] [PATCH 1/7] tcg: Define "deposit" as an optional operation.

2011-01-11 Thread Aurelien Jarno
On Mon, Jan 10, 2011 at 07:23:42PM -0800, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/README| 14 > tcg/tcg-op.h | 64 > + > tcg/tcg-opc.h |6 + > 3 files changed, 84 insertions(+),

Re: [Qemu-devel] [PATCH 0/7] Define "deposit" tcg operation, v2

2011-01-11 Thread Aurelien Jarno
On Mon, Jan 10, 2011 at 07:23:41PM -0800, Richard Henderson wrote: > Changes since v1: > * No attempt to pack pos+len into one operand. Updated backends > to match this change. > > * Example in the README is a bit more complex. > > * Define an official tcg_scratch_alloc routine, used b

Re: [Qemu-devel] [PATCH 4/4] target-arm: Restore IT bits when resuming after an exception

2011-01-11 Thread Aurelien Jarno
On Mon, Jan 10, 2011 at 11:11:52PM +, Peter Maydell wrote: > We were not correctly restoring the IT bits when resuming execution > after taking an unexpected exception in the middle of an IT block. > Fix this by tracking them along with PC changes and restoring in > gen_pc_load(). > > This fix

[Qemu-devel] Re: [PATCH] audio: split sample conversion and volumemixing

2011-01-11 Thread malc
On Tue, 11 Jan 2011, Michael Walle wrote: > > Hi Wolfgang, > > > The fixed point path for scaling in mixeng_volume() seems to be under by > > a factor of two, IMHO. The right shift should be by 31, not 32. (Because > > the volume, which I assume is a signed 32 bit integer, can be 0.5 at > > most

Re: [Qemu-devel] [PATCH v2 0/2] ARM: Fix VQSHL/VQSHLU immediate forms

2011-01-11 Thread Aurelien Jarno
On Sat, Jan 08, 2011 at 04:01:14PM +, Peter Maydell wrote: > This patchset fixes errors in the decoding and implementation of the > immediate forms of the VQSHL/VQSHLU ARM instructions. > Tested in the usual random-instruction-set way. This is the final part > of the maemo-qemu tree commit 03a2

Re: [Qemu-devel] [PATCH] linux-user: Add configure check for linux/fiemap.h and IOC_FS_FIEMAP

2011-01-11 Thread Aurelien Jarno
On Mon, Jan 10, 2011 at 01:11:24PM +, Peter Maydell wrote: > Add a configure check for the existence of linux/fiemap.h and the > IOC_FS_FIEMAP ioctl. This fixes a compilation failure on Linux > systems which don't have that header file. > > Signed-off-by: Peter Maydell > --- > configure

Re: [Qemu-devel] [PATCH 3/4] linux-user: ARM: clear the IT bits when invoking a signal handler

2011-01-11 Thread Aurelien Jarno
On Mon, Jan 10, 2011 at 11:11:51PM +, Peter Maydell wrote: > When invoking a signal handler for an ARM target, make sure the IT > bits in the CPSR are cleared. (This would otherwise cause incorrect > execution if the IT state was non-zero when an exception occured. > This bug has been masked pr

Re: [Qemu-devel] [PATCH 2/4] target-arm: Refactor translation of exception generating instructions

2011-01-11 Thread Aurelien Jarno
On Mon, Jan 10, 2011 at 11:11:50PM +, Peter Maydell wrote: > Create a new function which does the common sequence of gen_set_condexec, > gen_set_pc_im, gen_exception, set is_jmp to DISAS_JUMP. > > Signed-off-by: Peter Maydell > --- > target-arm/translate.c | 43 +++-

Re: [Qemu-devel] [PATCH 1/4] target-arm: Remove redundant setting of IT bits before Thumb SWI

2011-01-11 Thread Aurelien Jarno
On Mon, Jan 10, 2011 at 11:11:49PM +, Peter Maydell wrote: > Remove a redundant call to gen_set_condexec() in the translation of Thumb > mode SWI. (SWI and WFI generate "exceptions" which happen after the > execution of the instruction, ie when PC and IT bits have updated. > So the condexec bit

Re: [Qemu-devel] Tracking unfreed tcg temps

2011-01-11 Thread Aurelien Jarno
On Tue, Jan 11, 2011 at 06:09:06AM -0600, Peter Maydell wrote: > The ARM target-arm/translate.c file has some code in it which tries to > track the number of TCG temporaries allocated during translation of an > ARM instruction and complain if they are not freed by the end of that > instruction. So

[Qemu-devel] [PATCH] linux-user: correct core dump format

2011-01-11 Thread Laurent Vivier
This patch allows to really use the core dumped by qemu with guest architecture tools. - it adds a missing bswap_phdr() for the program headers of memory regions. "objdump -x" sample: BEFORE: 0x100 off0x0020 vaddr 0x0400 paddr 0x align 2**21 filesz 0x000

[Qemu-devel] [PULL] rtl8139, pci, ioeventfd

2011-01-11 Thread Michael S. Tsirkin
The following changes since commit 05bf441eb69a813d3893174d54faa6afa8c0d39b: cris: Remove unused orig_flags (2011-01-10 23:28:08 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/qemu.git for_anthony Alex Williamson (2): qdev: Track runtim

[Qemu-devel] Re: [PATCH v5] savevm: Fix no_migrate

2011-01-11 Thread Michael S. Tsirkin
On Tue, Jan 11, 2011 at 02:39:43PM -0700, Alex Williamson wrote: > The no_migrate save state flag is currently only checked in the > last phase of migration. This means that we potentially waste > a lot of time and bandwidth with the live state handlers before > we ever check the no_migrate flags.

[Qemu-devel] [PATCH 6/8] target-arm: Translate with condexec bits from TB flags, not CPUState

2011-01-11 Thread Peter Maydell
When translating, the condexec bits for the TB are in the TB flags; the CPUState condexec bits may be different. This patch fixes https://bugs.launchpad.net/bugs/604872 where we might segfault if we took an exception in the middle of a TB with an IT block, because when we came to retranslate in cp

[Qemu-devel] [PATCH 2/8] target-arm: Add symbolic constants for bitfields in TB flags

2011-01-11 Thread Peter Maydell
Add symbolic constants for the bitfields we use in the TB flags. Signed-off-by: Peter Maydell --- target-arm/cpu.h | 45 +++-- 1 files changed, 39 insertions(+), 6 deletions(-) diff --git a/target-arm/cpu.h b/target-arm/cpu.h index 340933e..3adb118 1006

[Qemu-devel] [PATCH 8/8] target-arm: Translate with user-state from TB flags, not CPUState

2011-01-11 Thread Peter Maydell
When translating, get the user/priv state from the TB flags, not the CPUState. Signed-off-by: Peter Maydell --- target-arm/translate.c |6 +- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index 4fe202d..aa3c60a 100644 --- a

[Qemu-devel] [PATCH 1/8] target-arm: Don't generate code specific to current CPU mode for SRS

2011-01-11 Thread Peter Maydell
When translating the SRS instruction, handle the "store registers to stack of current mode" case in the helper function rather than inline. This means the generated code does not make assumptions about the current CPU mode which might not be valid when the TB is executed later. Signed-off-by: Pete

[Qemu-devel] [PATCH 5/8] target-arm: Translate with Thumb state from TB flags, not CPUState

2011-01-11 Thread Peter Maydell
The Thumb/ARM state for the TB being translated should come from the TB flags, not the CPUState. Signed-off-by: Peter Maydell --- target-arm/translate.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index 624a443..bd

[Qemu-devel] [PATCH 4/8] target-arm: Translate with VFP len/stride from TB flags, not CPUState

2011-01-11 Thread Peter Maydell
When translating, the VFP vector length and stride for this TB are encoded in the TB flags; the CPUState copies may be different and must not be used. Signed-off-by: Peter Maydell --- target-arm/translate.c | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/target-

[Qemu-devel] [PATCH 7/8] target-arm: Set privileged bit in TB flags correctly for M profile

2011-01-11 Thread Peter Maydell
M profile ARM cores don't have a CPSR mode field. Set the bit in the TB flags that indicates non-user mode correctly for these cores. Signed-off-by: Peter Maydell --- target-arm/cpu.h |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/target-arm/cpu.h b/target-arm/cp

[Qemu-devel] [PATCH 3/8] target-arm: Translate with VFP-enabled from TB flags, not CPUState

2011-01-11 Thread Peter Maydell
When translating code, whether the VFP unit is enabled for this TB is stored in a bit in the TB flags. Use this rather than incorrectly reading the FPEXC from the CPUState passed to translation. Signed-off-by: Peter Maydell --- target-arm/translate.c | 14 +- 1 files changed, 5 ins

[Qemu-devel] [PATCH v2 0/8] target-arm: Translate based on TB flags, not CPUState

2011-01-11 Thread Peter Maydell
This patchset corrects a number of places in the ARM translation code which were generating code which was dependent on values in the CPUState structure which might change at runtime. This is a bad idea for two reasons. Firstly, we might try to reuse the generated code later when the assumptions ba

Re: [Qemu-devel] [PATCH 1/9] target-sh4: switch sh4 to softfloat

2011-01-11 Thread Edgar E. Iglesias
On Tue, Jan 11, 2011 at 03:35:33PM -0600, Peter Maydell wrote: > On 11 January 2011 15:22, Nathan Froyd wrote: > > On Tue, Jan 11, 2011 at 10:01:30PM +0100, Aurelien Jarno wrote: > >>  case "$target_arch2" in > >> -   > >> alpha|arm|armeb|m68k|microblaze|mips|mipsel|mipsn32|mipsn32el|mips64|mips64

[Qemu-devel] [PATCH 7/9] target-sh4: implement FPU exceptions

2011-01-11 Thread Aurelien Jarno
FPU exception support where not implemented on SH4. Implement them by clearing the softfloat exceptions flags before an FP instruction (the SH4 FPU also clear them before an instruction), and calling a function to update the FPSCR register after an FP instruction. This function update the correspon

Re: [Qemu-devel] [PATCH 1/9] target-sh4: switch sh4 to softfloat

2011-01-11 Thread Aurelien Jarno
On Tue, Jan 11, 2011 at 01:22:08PM -0800, Nathan Froyd wrote: > On Tue, Jan 11, 2011 at 10:01:30PM +0100, Aurelien Jarno wrote: > > case "$target_arch2" in > > - > > alpha|arm|armeb|m68k|microblaze|mips|mipsel|mipsn32|mipsn32el|mips64|mips64el|ppc|ppc64|ppc64abi32|ppcemb|s390x|sparc|sparc64|spar

Re: [Qemu-devel] [PATCH 1/9] target-sh4: switch sh4 to softfloat

2011-01-11 Thread Aurelien Jarno
On Tue, Jan 11, 2011 at 03:35:33PM -0600, Peter Maydell wrote: > On 11 January 2011 15:22, Nathan Froyd wrote: > > On Tue, Jan 11, 2011 at 10:01:30PM +0100, Aurelien Jarno wrote: > >>  case "$target_arch2" in > >> -   > >> alpha|arm|armeb|m68k|microblaze|mips|mipsel|mipsn32|mipsn32el|mips64|mips64

[Qemu-devel] [PATCH v5] savevm: Fix no_migrate

2011-01-11 Thread Alex Williamson
The no_migrate save state flag is currently only checked in the last phase of migration. This means that we potentially waste a lot of time and bandwidth with the live state handlers before we ever check the no_migrate flags. The error message printed when we catch a non-migratable device doesn't

Re: [Qemu-devel] [PATCH 1/9] target-sh4: switch sh4 to softfloat

2011-01-11 Thread Peter Maydell
On 11 January 2011 15:22, Nathan Froyd wrote: > On Tue, Jan 11, 2011 at 10:01:30PM +0100, Aurelien Jarno wrote: >>  case "$target_arch2" in >> -   >> alpha|arm|armeb|m68k|microblaze|mips|mipsel|mipsn32|mipsn32el|mips64|mips64el|ppc|ppc64|ppc64abi32|ppcemb|s390x|sparc|sparc64|sparc32plus) >> +   >>

[Qemu-devel] Re: [PATCH 3/9] softfloat: fix default-NaN mode

2011-01-11 Thread Peter Maydell
On 11 January 2011 15:01, Aurelien Jarno wrote: > When the default-NaN mode is enabled, it should return the default NaN > value, but it should anyway raise the invalid operation flag if one of > the operand is an sNaN. > > I have checked that this behavior matches the ARM and SH4 manuals, as > we

[Qemu-devel] [PATCH 9/9] target-sh4: add ftrv instruction

2011-01-11 Thread Aurelien Jarno
Add the ftrv XMTRX,FVn instruction, which computes the 4-row x 4-column matrix XMTRX by the 4-dimensional vector FVn. Signed-off-by: Aurelien Jarno --- target-sh4/helper.h|1 + target-sh4/op_helper.c | 26 ++ target-sh4/translate.c | 11 +++ 3 files ch

[Qemu-devel] [PATCH 5/9] target-sh4: define FPSCR constants

2011-01-11 Thread Aurelien Jarno
Define FPSCR constants for all field and use them instead of hardcoded values. Signed-off-by: Aurelien Jarno --- target-sh4/cpu.h | 35 +++ target-sh4/op_helper.c |7 --- target-sh4/translate.c |4 ++-- 3 files changed, 37 insertions(+), 9 dele

Re: [Qemu-devel] [PATCH 1/9] target-sh4: switch sh4 to softfloat

2011-01-11 Thread Nathan Froyd
On Tue, Jan 11, 2011 at 10:01:30PM +0100, Aurelien Jarno wrote: > case "$target_arch2" in > - > alpha|arm|armeb|m68k|microblaze|mips|mipsel|mipsn32|mipsn32el|mips64|mips64el|ppc|ppc64|ppc64abi32|ppcemb|s390x|sparc|sparc64|sparc32plus) > + > alpha|arm|armeb|m68k|microblaze|mips|mipsel|mipsn32|m

[Qemu-devel] [PATCH v3 2/3] MAINTAINERS: Change MIPS and SH4 maintainers

2011-01-11 Thread Aurelien Jarno
Since nobody else seems interested in maintaining MIPS and SH4 targets, and as I have done most of the recent code changes, let officialize that. Signed-off-by: Aurelien Jarno --- MAINTAINERS |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/MAINTAINERS b/MAINTAINER

[Qemu-devel] [PATCH 6/9] target-sh4: implement flush-to-zero

2011-01-11 Thread Aurelien Jarno
When the FPSCR.DN bit is set, the SH4 FPU treat denormalized numbers as zero. Enable the corresponding softfloat option when this bit is set. Signed-off-by: Aurelien Jarno --- target-sh4/op_helper.c |1 + target-sh4/translate.c |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff

[Qemu-devel] [PATCH v3 3/3] MAINTAINERS: add entries for TCG

2011-01-11 Thread Aurelien Jarno
The MAINTAINERS file was lacking entries concerning the TCG code, add them based on the git history. For the common TCG code, is probably better to keep qemu-de...@non-gnu.org as this code can break easily, so it's better to get it reviewed by a few persons. v1 -> v2: - Changed i386 as maintained

[Qemu-devel] [PATCH v3 1/3] MAINTAINERS: fix typos

2011-01-11 Thread Aurelien Jarno
Signed-off-by: Aurelien Jarno --- MAINTAINERS |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 59effc7..98af4ab 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -202,7 +202,7 @@ M: Edgar E. Iglesias S: Maintained F: hw/etraxfs.c -M86K M

[Qemu-devel] [PATCH 3/9] softfloat: fix default-NaN mode

2011-01-11 Thread Aurelien Jarno
When the default-NaN mode is enabled, it should return the default NaN value, but it should anyway raise the invalid operation flag if one of the operand is an sNaN. I have checked that this behavior matches the ARM and SH4 manuals, as well as real SH4 hardware. Cc: Peter Maydell Signed-off-by:

[Qemu-devel] [PATCH 2/9] softfloat: SH4 has the sNaN bit set

2011-01-11 Thread Aurelien Jarno
Signed-off-by: Aurelien Jarno --- fpu/softfloat-specialize.h | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/fpu/softfloat-specialize.h b/fpu/softfloat-specialize.h index f293f24..186b4da 100644 --- a/fpu/softfloat-specialize.h +++ b/fpu/softfloat-specialize.h @@

[Qemu-devel] target-sh4: improve FPU emulation

2011-01-11 Thread Aurelien Jarno
This patch series improve the FPU emulation by correctly implementing NaN values, IEEE754 exceptions and by adding two missing instructions.

[Qemu-devel] [PATCH 4/9] target-sh4: use default-NaN mode

2011-01-11 Thread Aurelien Jarno
SH4 FPU doesn't propagate NaN, and instead always regenerate new ones. Enable the default-NaN mode by default. Signed-off-by: Aurelien Jarno --- target-sh4/translate.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/target-sh4/translate.c b/target-sh4/translate.c index 1

[Qemu-devel] [PATCH 1/9] target-sh4: switch sh4 to softfloat

2011-01-11 Thread Aurelien Jarno
We need to be able to catch exceptions correctly. Signed-off-by: Aurelien Jarno --- configure |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure b/configure index 831a741..73485c5 100755 --- a/configure +++ b/configure @@ -3049,7 +3049,7 @@ if test ! -z "$gdb_xml

[Qemu-devel] [PATCH 8/9] target-sh4: add fipr instruction

2011-01-11 Thread Aurelien Jarno
Add the fipr FVm,FVn instruction, which computes the inner products of a 4-dimensional single precision floating-point vector. Signed-off-by: Aurelien Jarno --- target-sh4/helper.h|1 + target-sh4/op_helper.c | 20 target-sh4/translate.c | 12 3 file

Re: [Qemu-devel] [PATCH 1/3] Add scripts directory

2011-01-11 Thread Stefan Hajnoczi
On Tue, Jan 11, 2011 at 8:24 PM, Blue Swirl wrote: > On Tue, Jan 11, 2011 at 8:09 PM, Stefan Hajnoczi wrote: >> I'd like to test but this email is line wrapped and git-am won't apply it. > > Now attached, are these OK? Yes, thanks. Patch 1/3 configures and builds successfully. BTW the GMail we

[Qemu-devel] [Bug 570574] Re: GDBStub Bug: Can't stop at start_kernel when debugging linux kernel

2011-01-11 Thread Prudhvi
This problem also exists on qemu-kvm-0.13.0 and qemu-kvm-50 ( dev-builds ) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/570574 Title: GDBStub Bug: Can't stop at start_kernel when debugging linux k

Re: [Qemu-devel] [PATCH 1/3] Add scripts directory

2011-01-11 Thread Stefan Hajnoczi
On Tue, Jan 11, 2011 at 7:58 PM, Blue Swirl wrote: > diff --git a/Makefile b/Makefile > index 6d601ee..eca4c76 100644 > --- a/Makefile > +++ b/Makefile > @@ -47,7 +47,7 @@ config-all-devices.mak: $(SUBDIR_DEVICES_MAK) >  -include $(SUBDIR_DEVICES_MAK_DEP) > >  %/config-devices.mak: default-configs

[Qemu-devel] [PATCH 3/3] checkpatch: adjust to QEMUisms

2011-01-11 Thread Blue Swirl
Change checkpatch.pl for QEMU use: - Root directory detection - Forbid tabs - Indent at 4 spaces - Allow typedefs - Enforce brace use even for single statement blocks - Don't suggest nonexistent cleanup tools Mention the script in CODING_STYLE. Signed-off-by: Blue Swirl --- CODING_STYLE

[Qemu-devel] [PATCH 1/3] Add scripts directory

2011-01-11 Thread Blue Swirl
Move build and user scripts into scripts directory. Signed-off-by: Blue Swirl --- Makefile | 26 ++-- Makefile.target| 10 configure |2 +- gdbs

[Qemu-devel] Re: [PATCH 2/7] tcg-ppc: Implement deposit operation.

2011-01-11 Thread malc
On Tue, 11 Jan 2011, Richard Henderson wrote: > On 01/11/2011 04:40 AM, malc wrote: > >> +tcg_out32 (s, RLWIMI > >> + | RA(args[0]) > >> + | RS(args[2]) > >> + | SH(lsb_ofs) > >> + | MB(msb_ofs - le

[Qemu-devel] Re: RFC: QMP event notification for disk media eject

2011-01-11 Thread Luiz Capitulino
On Tue, 11 Jan 2011 14:28:23 +0100 Kevin Wolf wrote: > Am 11.01.2011 14:11, schrieb Luiz Capitulino: > > Hi there, > > > > I need feedback on a new QMP event. > > > > Problem > > === > > > > There's no way for a management tool to detect that a guest OS has ejected > > the > > media in a

spice vdagent protocol, was Re: [Qemu-devel] KVM call minutes for Jan 11

2011-01-11 Thread Alon Levy
On Tue, Jan 11, 2011 at 07:53:40AM -0800, Chris Wright wrote: > KVM Forum 2011 > - expand the scope? yes, continue up the stack > - how long? 2 days (maybe 2 1/2 - 3 space permitting) > - where? Vancouver with LinuxCon > > Spice guest agent: > - virt agent, matahari, spice agent...what is in spi

[Qemu-devel] Re: RFC: QMP event notification for disk media eject

2011-01-11 Thread Daniel P. Berrange
On Tue, Jan 11, 2011 at 03:45:49PM -0200, Luiz Capitulino wrote: > On Tue, 11 Jan 2011 14:28:23 +0100 > Kevin Wolf wrote: > > > Am 11.01.2011 14:11, schrieb Luiz Capitulino: > > > Hi there, > > > > > > I need feedback on a new QMP event. > > > > > > Problem > > > === > > > > > > There's no

Re: [Qemu-devel] RFC: QMP event notification for disk media eject

2011-01-11 Thread Luiz Capitulino
On Tue, 11 Jan 2011 15:13:40 +0100 Markus Armbruster wrote: > Luiz Capitulino writes: > > > Hi there, > > > > I need feedback on a new QMP event. > > > > Problem > > === > > > > There's no way for a management tool to detect that a guest OS has ejected > > the > > media in a CDROM or Flopp

Re: [Qemu-devel] Re: RFC: QMP event notification for disk media eject

2011-01-11 Thread Luiz Capitulino
On Tue, 11 Jan 2011 15:29:12 +0100 Markus Armbruster wrote: > Anthony Liguori writes: > > > On 01/11/2011 07:11 AM, Luiz Capitulino wrote: > >> Hi there, > >> > >> I need feedback on a new QMP event. > >> > >> Problem > >> === > >> > >> There's no way for a management tool to detect that a

Re: [Qemu-devel] Re: phys_page_find bug?

2011-01-11 Thread Bob Breuer
Artyom Tarasenko wrote: > On Mon, Jan 10, 2011 at 10:39 PM, Blue Swirl wrote: > >> On Mon, Jan 10, 2011 at 3:57 AM, Bob Breuer wrote: >> >>> Blue Swirl wrote: >>> On Mon, Nov 8, 2010 at 6:55 PM, Artyom Tarasenko wrote: > On Fri, May 7, 2010 at 6:2

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-11 Thread Jan Kiszka
Am 11.01.2011 09:53, Gerd Hoffmann wrote: > Hi, > >> Actually, there is already a channel to pass pointers to qdev devices: >> the pointer property hack. I'm not sure we should contribute to its user >> base or take the chance for a cleanup, but we are not alone with this >> requirement. Point b

Re: [Qemu-devel] [PATCH 6/6] spice: add chardev (v4)

2011-01-11 Thread Blue Swirl
On Tue, Jan 11, 2011 at 12:08 PM, Gerd Hoffmann wrote: > From: Alon Levy > > Adding a chardev backend for spice, where spice determines what > to do with it based on the name attribute given during chardev creation. > For usage by spice vdagent in conjunction with a properly named > virtio-serial

[Qemu-devel] Re: [PATCH 2/5] char: Introduce char_set/remove_fd_handlers()

2011-01-11 Thread Amit Shah
On (Tue) Jan 11 2011 [16:54:48], Gerd Hoffmann wrote: > On 01/11/11 16:38, Amit Shah wrote: > >On (Tue) Jan 11 2011 [15:39:46], Gerd Hoffmann wrote: > >>On 01/11/11 12:10, Amit Shah wrote: > >>>Introduce a char-specific wrapper to qemu_set_fd_handler functions. > >>>This wrapper is useful to add /

Re: [Qemu-devel] [PATCH 1/5] char: Add a QemuChrHandlers struct to initialise chardev handlers

2011-01-11 Thread Blue Swirl
On Tue, Jan 11, 2011 at 11:10 AM, Amit Shah wrote: > Instead of passing each handler in the qemu_add_handlers() function, > create a struct of handlers that can be passed to the function instead. > > Signed-off-by: Amit Shah > --- >  gdbstub.c            |    9 +++-- >  hw/debugcon.c        |

Re: [Qemu-devel] Re: [PATCH 26/35] kvm: Eliminate KVMState arguments

2011-01-11 Thread Avi Kivity
On 01/11/2011 06:26 PM, Anthony Liguori wrote: Visible, yes, but not in live migration, or in 'info i8254', or similar. We can live migrate between qcow2 and qed (using block migration), we should be able to do the same for the two i8254 implementations. I'm not happy about separate implem

Re: [Qemu-devel] Re: [PATCH 26/35] kvm: Eliminate KVMState arguments

2011-01-11 Thread Anthony Liguori
Visible, yes, but not in live migration, or in 'info i8254', or similar. We can live migrate between qcow2 and qed (using block migration), we should be able to do the same for the two i8254 implementations. I'm not happy about separate implementations, but that's a minor details. We can

[Qemu-devel] Re: [PATCH 2/7] tcg-ppc: Implement deposit operation.

2011-01-11 Thread Richard Henderson
On 01/11/2011 04:40 AM, malc wrote: >> +tcg_out32 (s, RLWIMI >> + | RA(args[0]) >> + | RS(args[2]) >> + | SH(lsb_ofs) >> + | MB(msb_ofs - len + 1) >> + | ME(msb_ofs)); >> +

[Qemu-devel] [patch 0/2] [pci branch] configure pci slot removability through ACPI (v2)

2011-01-11 Thread Marcelo Tosatti
Indicate PCI removability through ACPI _RMV method, so that Windows guests does not expose non-hotpluggable PCI devices as "hot removable". v2: - Mark slots with no present devices as hotpluggable.

[Qemu-devel] [patch 2/2] acpi_piix4: expose no_hotplug attribute via i/o port

2011-01-11 Thread Marcelo Tosatti
Expose no_hotplug attribute via I/O port, so ACPI BIOS can indicate removability status to guest OS. An updated seabios is required to make use of this feature (seabios.git commit ID 3c241edf3d7ef29c21). Signed-off-by: Marcelo Tosatti Tested-by: Gleb Natapov Index: qemu/hw/acpi_piix4.c ===

Re: [Qemu-devel] Re: [patch 2/2] acpi_piix4: expose no_hotplug attribute via i/o port

2011-01-11 Thread Marcelo Tosatti
On Mon, Jan 10, 2011 at 11:25:48PM +0200, Michael S. Tsirkin wrote: > On Mon, Jan 10, 2011 at 04:55:03PM -0200, Marcelo Tosatti wrote: > > Expose no_hotplug attribute via I/O port, so ACPI BIOS can indicate > > removability status to guest OS. > > > > An updated seabios is required to make use of

[Qemu-devel] [patch 1/2] document QEMU<->ACPIBIOS PCI hotplug interface

2011-01-11 Thread Marcelo Tosatti
Document how QEMU communicates with ACPI BIOS for PCI hotplug. Signed-off-by: Marcelo Tosatti Index: qemu/docs/specs/acpi_pci_hotplug.txt === --- /dev/null +++ qemu/docs/specs/acpi_pci_hotplug.txt @@ -0,0 +1,39 @@ +QEMU<->ACPI BIOS

Re: [Qemu-devel] [Bug 686613] Re: USB MSD are not marked as removable

2011-01-11 Thread Christoph Hellwig
On Tue, Jan 11, 2011 at 03:15:46PM -, Stefan Hajnoczi wrote: > A sampling of physical USB devices: > 1. Noname 2GB USB stick: RMB=1 > 2. Nexus One USB storage: RMB=1 > 3. LaCie USB harddisk: RMB=0 > > I suspect there's no setting that will satisfy everyone here. It makes > sense for a USB har

[Qemu-devel] [PATCH][RESEND] virtio-serial-bus: Bump up control vq descriptors to min. required

2011-01-11 Thread Amit Shah
The current default of 16 buffers for the control vq is too small for the default max_nr_ports of 32. We can get more entries in there, example when asking the guest to add max. allowed ports. Default to using the minimum required (next power of 2) of the max_nr_ports in use. Signed-off-by: Amit

[Qemu-devel] Re: [PATCH 2/5] char: Introduce char_set/remove_fd_handlers()

2011-01-11 Thread Amit Shah
On (Tue) Jan 11 2011 [15:39:46], Gerd Hoffmann wrote: > On 01/11/11 12:10, Amit Shah wrote: > >Introduce a char-specific wrapper to qemu_set_fd_handler functions. > >This wrapper is useful to add / remove a write handler easily. Write > >handlers are only used when the backend is blocked and canno

Re: [Qemu-devel] Re: [PATCH 26/35] kvm: Eliminate KVMState arguments

2011-01-11 Thread Avi Kivity
On 01/11/2011 05:55 PM, Anthony Liguori wrote: One thing I've been considering is essentially migration filters. It would be a set of rules that essentially were "hpet-kvm.* = hpet.*" which would allow migration from hpet to hpet-kvm given a translation of state. I think this sort of high

Re: [Qemu-devel] Re: [PATCH 26/35] kvm: Eliminate KVMState arguments

2011-01-11 Thread Anthony Liguori
On 01/11/2011 09:37 AM, Avi Kivity wrote: Why not? Whatever state the kernel keeps, we expose to userspace and allow sending it over the wire. What exactly is the scenario you're concerned about? Migration between userspace HPET and in-kernel HPET? Yes. To a lesser extent, a client doing '

[Qemu-devel] Re: [PATCH 2/5] char: Introduce char_set/remove_fd_handlers()

2011-01-11 Thread Gerd Hoffmann
On 01/11/11 16:38, Amit Shah wrote: On (Tue) Jan 11 2011 [15:39:46], Gerd Hoffmann wrote: On 01/11/11 12:10, Amit Shah wrote: Introduce a char-specific wrapper to qemu_set_fd_handler functions. This wrapper is useful to add / remove a write handler easily. Write handlers are only used when the

[Qemu-devel] KVM call minutes for Jan 11

2011-01-11 Thread Chris Wright
KVM Forum 2011 - expand the scope? yes, continue up the stack - how long? 2 days (maybe 2 1/2 - 3 space permitting) - where? Vancouver with LinuxCon Spice guest agent: - virt agent, matahari, spice agent...what is in spice agent? - spice char device - mouse, copy 'n paste, screen resolution ch

[Qemu-devel] [PATCH 1/2] xen: Add xc_domain_add_to_physmap to xen_interface.

2011-01-11 Thread anthony . perard
From: Anthony PERARD This function will be used to support sync dirty bitmap. This come with a check against every Xen release, and special implementation for Xen version that doesn't have this specific call. This function will not be usable with Xen 3.3 because the behavior is different. Sign

[Qemu-devel] [PATCH 2/2] xen: Introduce VGA sync dirty bitmap support

2011-01-11 Thread anthony . perard
From: Anthony PERARD This patch introduces phys memory client for Xen. Only sync dirty_bitmap and set_memory are actually implemented. migration_log will stay empty for the moment. Xen can only log one range for bit change, so only the range in the first call will be synced. Signed-off-by: Ant

[Qemu-devel] [PATCH 0/2] Xen VGA dirtybit support

2011-01-11 Thread anthony . perard
From: Anthony PERARD Hi, This two patchs provides the support for sync dirty bitmap. The sync dirty bitmap is not provide for Xen 3.3. This serie depends on the other serie "Xen device model support". Anthony PERARD (2): xen: Add xc_domain_add_to_physmap to xen_interface. xen: Introduce VG

Re: [Qemu-devel] Re: [PATCH 26/35] kvm: Eliminate KVMState arguments

2011-01-11 Thread Avi Kivity
On 01/11/2011 05:12 PM, Anthony Liguori wrote: No, it really doesn't :-) Cirrus VGA and std VGA share a lot of code. But that doesn't mean that we treat them as one device. Cirrus and VGA really are separate devices. They share code because on evolved from the other, and is backwards compat

[Qemu-devel] [Bug 686613] Re: USB MSD are not marked as removable

2011-01-11 Thread Stefan Hajnoczi
A sampling of physical USB devices: 1. Noname 2GB USB stick: RMB=1 2. Nexus One USB storage: RMB=1 3. LaCie USB harddisk: RMB=0 I suspect there's no setting that will satisfy everyone here. It makes sense for a USB harddisk to set RMB=0 because that allows you to put on more than one partition un

Re: [Qemu-devel] Re: [PATCH 26/35] kvm: Eliminate KVMState arguments

2011-01-11 Thread Alexander Graf
On 11.01.2011, at 16:12, Anthony Liguori wrote: > On 01/11/2011 08:56 AM, Avi Kivity wrote: >> On 01/11/2011 04:36 PM, Anthony Liguori wrote: They need to use the same device id then. And if they share code, that indicates that they need to be the same device even more. >>> >>> >>>

Re: [Qemu-devel] Re: [PATCH 26/35] kvm: Eliminate KVMState arguments

2011-01-11 Thread Anthony Liguori
On 01/11/2011 08:56 AM, Avi Kivity wrote: On 01/11/2011 04:36 PM, Anthony Liguori wrote: They need to use the same device id then. And if they share code, that indicates that they need to be the same device even more. No, it really doesn't :-) Cirrus VGA and std VGA share a lot of code. B

[Qemu-devel] Re: [PATCH] ioeventfd: error handling cleanup

2011-01-11 Thread Stefan Hajnoczi
On Tue, Jan 11, 2011 at 01:49:18PM +0200, Michael S. Tsirkin wrote: > - Don't return status from start/stop functions where it's ignored > - report errors to make debugging easier > - assert on unexpected failures > - don't disable notifiers on error so that we'll > retry when guest driver restar

Re: [Qemu-devel] Re: [PATCH 26/35] kvm: Eliminate KVMState arguments

2011-01-11 Thread Avi Kivity
On 01/11/2011 04:36 PM, Anthony Liguori wrote: They need to use the same device id then. And if they share code, that indicates that they need to be the same device even more. No, it really doesn't :-) Cirrus VGA and std VGA share a lot of code. But that doesn't mean that we treat them as

Re: [Qemu-devel] Re: [PATCH 26/35] kvm: Eliminate KVMState arguments

2011-01-11 Thread Avi Kivity
On 01/11/2011 04:28 PM, Anthony Liguori wrote: On 01/11/2011 08:18 AM, Avi Kivity wrote: On 01/11/2011 04:00 PM, Anthony Liguori wrote: On 01/11/2011 03:01 AM, Avi Kivity wrote: On 01/10/2011 10:23 PM, Anthony Liguori wrote: I don't see how ioapic, pit, or pic have a system scope. They are no

[Qemu-devel] [PATCH] audio: Fix support for multiple soft output voices.

2011-01-11 Thread digit
From: David 'Digit' Turner This patch fixes a minor bug that prevent audio emulation from working properly when several soft output voices are opened. The symptom was that as long as one active soft voice was empty, it prevented any output from any other voice. More precisely, audio_pcm_hw_find_

Re: [Qemu-devel] Re: KVM call agenda for Jan 11

2011-01-11 Thread Anthony Liguori
On 01/11/2011 07:41 AM, Juan Quintela wrote: Kevin Wolf wrote: Am 10.01.2011 14:32, schrieb Juan Quintela: Juan Quintela wrote: Juan Quintela wrote: Now sent it to the right kvm list. Sorry for the second sent. Please send any agenda items you are interested

[Qemu-devel] Re: [PATCH 3/5] char: Add framework for a 'write unblocked' callback

2011-01-11 Thread Gerd Hoffmann
Hi, @@ -60,6 +60,9 @@ struct CharDriverState { IOEventHandler *chr_event; IOCanReadHandler *chr_can_read; IOReadHandler *chr_read; +IOHandler *chr_write_unblocked; +void (*update_fd_handlers)(struct CharDriverState *chr, + bool poll_out);

[Qemu-devel] Re: [PATCH 2/5] char: Introduce char_set/remove_fd_handlers()

2011-01-11 Thread Gerd Hoffmann
On 01/11/11 12:10, Amit Shah wrote: Introduce a char-specific wrapper to qemu_set_fd_handler functions. This wrapper is useful to add / remove a write handler easily. Write handlers are only used when the backend is blocked and cannot receive any more input. I'd suggest to add flags to enable/

Re: [Qemu-devel] Re: [PATCH 26/35] kvm: Eliminate KVMState arguments

2011-01-11 Thread Anthony Liguori
On 01/11/2011 08:22 AM, Avi Kivity wrote: On 01/11/2011 04:09 PM, Anthony Liguori wrote: Disadvantages: 1) you lose migration / savevm between KVM and non-KVM VMs This doesn't work today and it's never worked. KVM exposes things that TCG cannot emulate (like pvclock). If you run kvm witho

Re: [Qemu-devel] Re: [PATCH 26/35] kvm: Eliminate KVMState arguments

2011-01-11 Thread Anthony Liguori
On 01/11/2011 08:18 AM, Avi Kivity wrote: On 01/11/2011 04:00 PM, Anthony Liguori wrote: On 01/11/2011 03:01 AM, Avi Kivity wrote: On 01/10/2011 10:23 PM, Anthony Liguori wrote: I don't see how ioapic, pit, or pic have a system scope. They are not bound to any CPU like the APIC which you may h

Re: [Qemu-devel] Re: RFC: QMP event notification for disk media eject

2011-01-11 Thread Markus Armbruster
Anthony Liguori writes: > On 01/11/2011 07:11 AM, Luiz Capitulino wrote: >> Hi there, >> >> I need feedback on a new QMP event. >> >> Problem >> === >> >> There's no way for a management tool to detect that a guest OS has ejected >> the >> media in a CDROM or Floppy disk drive (I'm discardin

Re: [Qemu-devel] Re: [PATCH 26/35] kvm: Eliminate KVMState arguments

2011-01-11 Thread Alexander Graf
On 11.01.2011, at 15:09, Anthony Liguori wrote: > On 01/11/2011 08:06 AM, Alexander Graf wrote: >> On 11.01.2011, at 15:00, Anthony Liguori wrote: >> >> >>> On 01/11/2011 03:01 AM, Avi Kivity wrote: >>> On 01/10/2011 10:23 PM, Anthony Liguori wrote: >>> I don't see h

Re: [Qemu-devel] Re: [PATCH 26/35] kvm: Eliminate KVMState arguments

2011-01-11 Thread Avi Kivity
On 01/11/2011 04:09 PM, Anthony Liguori wrote: Disadvantages: 1) you lose migration / savevm between KVM and non-KVM VMs This doesn't work today and it's never worked. KVM exposes things that TCG cannot emulate (like pvclock). If you run kvm without pvclock, or implement pvclock in qemu, i

Re: [Qemu-devel] Re: [PATCH 26/35] kvm: Eliminate KVMState arguments

2011-01-11 Thread Avi Kivity
On 01/11/2011 04:00 PM, Anthony Liguori wrote: On 01/11/2011 03:01 AM, Avi Kivity wrote: On 01/10/2011 10:23 PM, Anthony Liguori wrote: I don't see how ioapic, pit, or pic have a system scope. They are not bound to any CPU like the APIC which you may have in mind. And none of the above inter

[Qemu-devel] Re: [PATCH 1/5] char: Add a QemuChrHandlers struct to initialise chardev handlers

2011-01-11 Thread Gerd Hoffmann
On 01/11/11 12:10, Amit Shah wrote: Instead of passing each handler in the qemu_add_handlers() function, create a struct of handlers that can be passed to the function instead. Nice cleanup. Acked-by: Gerd Hoffmann cheers, Gerd

Re: [Qemu-devel] RFC: QMP event notification for disk media eject

2011-01-11 Thread Markus Armbruster
Luiz Capitulino writes: > Hi there, > > I need feedback on a new QMP event. > > Problem > === > > There's no way for a management tool to detect that a guest OS has ejected the > media in a CDROM or Floppy disk drive (I'm discarding polling, because it's > undesirable at best). > > The end re

Re: [Qemu-devel] Re: [PATCH 26/35] kvm: Eliminate KVMState arguments

2011-01-11 Thread Anthony Liguori
On 01/11/2011 08:06 AM, Alexander Graf wrote: On 11.01.2011, at 15:00, Anthony Liguori wrote: On 01/11/2011 03:01 AM, Avi Kivity wrote: On 01/10/2011 10:23 PM, Anthony Liguori wrote: I don't see how ioapic, pit, or pic have a system scope. They are not bound t

  1   2   >