On 10/25/2010 05:48 PM, Lluís wrote:
For instance, a CPUID leaf could be used in the 0x40001xxx range.
Right, I commented this in a previous mail as a much nicer way to do it,
but I was just too lazy to look up how CPUID works and instead ported
the implementation I already had in bochs :)
On Mon, 25 Oct 2010, Anthony Liguori wrote:
> On 10/25/2010 04:54 PM, malc wrote:
> > On Mon, 25 Oct 2010, Anthony Liguori wrote:
> >
> >
> > > On 10/22/2010 01:45 PM, Michael Roth wrote:
> > >
> > > > Common code for sending/recieving RPCs via http over virtproxy channel.
> > > > Event
Anthony Liguori writes:
> On 10/25/2010 08:37 AM, Lluís wrote:
>> I know extending the ISA is not nice at all, but I think that's much
>> more maintainable than a per-guest OS interface (supposing some will
>> need extra guest drivers).
> On x86, there are some architecturally nicer ways to do th
On 10/25/2010 04:54 PM, malc wrote:
On Mon, 25 Oct 2010, Anthony Liguori wrote:
On 10/22/2010 01:45 PM, Michael Roth wrote:
Common code for sending/recieving RPCs via http over virtproxy channel.
Eventually these will all be switched to asynchronous handlers to avoid
deadlocks betwee
On Mon, 25 Oct 2010, Anthony Liguori wrote:
> On 10/22/2010 01:45 PM, Michael Roth wrote:
> > Common code for sending/recieving RPCs via http over virtproxy channel.
> > Eventually these will all be switched to asynchronous handlers to avoid
> > deadlocks between qemu and the guest. For now we can
Blue Swirl writes:
> On Mon, Oct 25, 2010 at 11:13 AM, Lluís wrote:
>> Blue Swirl writes:
>>
>>> A lot of internal state needs to be made available to the
>>> instrumentation code, which is a problem if that is considered as an
>>> API.
>>
>> I don't get what you mean by that. In principle, onl
On 10/22/2010 01:46 PM, Michael Roth wrote:
Add RPC to view guest dmesg output.
Signed-off-by: Michael Roth
---
virtagent-daemon.c | 45 +
virtagent-daemon.h |1 +
2 files changed, 46 insertions(+), 0 deletions(-)
diff --git a/virtagent-daem
On 10/22/2010 01:45 PM, Michael Roth wrote:
Common code for sending/recieving RPCs via http over virtproxy channel.
Eventually these will all be switched to asynchronous handlers to avoid
deadlocks between qemu and the guest. For now we can usually get away with
just doing asynchronous reads for
On 10/25/2010 05:30 AM, Andrew Beekhof wrote:
On 10/22/2010 08:45 PM, Michael Roth wrote:
This set of patches is meant to be applied on top of the Virtproxy v1
patchset.
OVERVIEW:
There are a wide range of use cases motivating the need for a guest
agent of some sort to extend the functionali
On 10/25/2010 08:37 AM, Lluís wrote:
Paolo Bonzini writes:
On 10/25/2010 12:54 PM, Lluís wrote:
* Backdoor channels need to provide arguments.
* It's better to provide the same mechanism for both *-user and softmmu
(otherwise the application to simulate or the interposed librariy
sho
Blue Swirl writes:
> On Mon, Oct 25, 2010 at 10:54 AM, Lluís wrote:
>> Blue Swirl writes:
>>
>>> and there are guest visible side effects.
>>
>> I don't understand what you mean with guest-visible effects.
> The guest can examine itself and determine that it has been modified.
Well, yes, but b
This driver handles in-memory qemu-char driver operations, that's,
all writes to this driver are stored in an internal buffer. The
driver doesn't talk to the external world in any way.
Right now it's very simple: it supports only writes. But it can
be easily extended to support more operations.
T
This command allows QMP clients to execute HMP commands, please
check its documentation in the hmp-commands.hx file for usage
information.
Please, also note that not all HMP commands can be executed this
way, in special commands that:
o need to store monitor related data (eg. getfd)
o read data
This is my first try on implementing HMP passthrough via QMP. I've tried
to follow Anthony's advice on creating a buffered char device.
If this approach is good (and the implementation is not faulty), I believe
this is very near a mergeble state (although I haven't tested much yet).
Example:
->
* Juan Quintela (quint...@redhat.com) wrote:
> Please send in any agenda items you are interested in covering.
Guest agents
Please send in any agenda items you are interested in covering.
Cheers, Juan.
* Kevin Wolf [2010-10-22 11:12]:
> Am 22.10.2010 17:48, schrieb Luiz Capitulino:
> > On Thu, 21 Oct 2010 21:55:51 -0500
> > Ryan Harper wrote:
> >
> >> This patch series decouples the detachment of a block device from the
> >> removal
> >> of the backing pci-device. Removal of a hotplugged pci
Add a function to find a drive by id string.
Changes since v1:
-Coding Style fix
Signed-off-by: Ryan Harper
---
blockdev.c | 13 +
blockdev.h |1 +
2 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index ff7602b..5fc3b9b 100644
--- a/block
On Mon, Oct 25, 2010 at 10:00 AM, Avi Kivity wrote:
> On 10/24/2010 08:14 PM, Blue Swirl wrote:
>>
>> On Sun, Oct 24, 2010 at 3:34 PM, Avi Kivity wrote:
>> > The current ioport callbacks are not type-safe, in that they accept an
>> > "opaque"
>> > pointer as an argument whose type must match t
This patch series decouples the detachment of a block device from the removal
of the backing pci-device. Removal of a hotplugged pci device requires the
guest to respond before qemu tears down the block device. In some cases, the
guest may not respond leaving the guest with continued access to the
Signed-off-by: Ryan Harper
---
qmp-commands.hx | 26 ++
1 files changed, 26 insertions(+), 0 deletions(-)
diff --git a/qmp-commands.hx b/qmp-commands.hx
index 793cf1c..e8f3d4a 100644
--- a/qmp-commands.hx
+++ b/qmp-commands.hx
@@ -338,6 +338,32 @@ Example:
EQMP
On Mon, Oct 25, 2010 at 11:13 AM, Lluís wrote:
> Blue Swirl writes:
>
>> On Fri, Oct 22, 2010 at 6:32 PM, Lluís wrote:
>>> instrument: Handle config-time activation
>>> instrument: Add initial instrumentation example
>>> instrument: Dynamic per-CPU state of static instrumentation points
>>> i
Gleb Natapov writes:
> On Mon, Oct 25, 2010 at 05:06:51PM +0200, Markus Armbruster wrote:
>> Gleb Natapov writes:
>>
>> > Prevent two devices from claiming the same io port.
>>
>> Really?
>>
>> Your new check for double-claim is in the new isa_init_ioport(), which
>> is for ISADevice only. T
On Mon, Oct 25, 2010 at 08:01:13PM +0200, Markus Armbruster wrote:
> Gleb Natapov writes:
>
> > On Mon, Oct 25, 2010 at 05:06:51PM +0200, Markus Armbruster wrote:
> >> Gleb Natapov writes:
> >>
> >> > Prevent two devices from claiming the same io port.
> >>
> >> Really?
> >>
> >> Your new che
Gleb Natapov writes:
> On Mon, Oct 25, 2010 at 06:22:12PM +0200, Markus Armbruster wrote:
>> Gleb Natapov writes:
>>
>> > On Mon, Oct 25, 2010 at 04:29:35PM +0200, Markus Armbruster wrote:
>> >> Gleb Natapov writes:
>> >>
>> >> > Without this patch both buses on PIIX3_IDE device have the same
On Mon, Oct 25, 2010 at 07:53:41PM +0200, Markus Armbruster wrote:
> Gleb Natapov writes:
>
> > On Mon, Oct 25, 2010 at 05:10:15PM +0200, Markus Armbruster wrote:
> >> Gleb Natapov writes:
> >>
> >> > PCI bus already has one. For ISA bus this patch series uses device's
> >> > ioports to uniquel
Block hot unplug is racy since the guest is required to acknowlege the ACPI
unplug event; this may not happen synchronously with the device removal command
This series aims to close a gap where by mgmt applications that assume the
block resource has been removed without confirming that the guest h
On Mon, Oct 25, 2010 at 08:06:13PM +0200, Markus Armbruster wrote:
> Gleb Natapov writes:
>
> > On Mon, Oct 25, 2010 at 06:22:12PM +0200, Markus Armbruster wrote:
> >> Gleb Natapov writes:
> >>
> >> > On Mon, Oct 25, 2010 at 04:29:35PM +0200, Markus Armbruster wrote:
> >> >> Gleb Natapov write
Gleb Natapov writes:
> On Mon, Oct 25, 2010 at 05:10:15PM +0200, Markus Armbruster wrote:
>> Gleb Natapov writes:
>>
>> > PCI bus already has one. For ISA bus this patch series uses device's
>> > ioports to uniquely describe it. For isa-ide, for example, get_dev_path
>> > method returns:
>> > 0
On Mon, Oct 25, 2010 at 10:54 AM, Lluís wrote:
> Blue Swirl writes:
>
>> On Fri, Oct 22, 2010 at 6:32 PM, Lluís wrote:
>>> Lluís Vilanova (17):
>>> backdoor: Declare host-side backdoor helpers
>>> backdoor: [all] Include backdoor helper declarations
>>> backdoor: Declare guest-side interface m
On 10/25/2010 05:30 AM, Andrew Beekhof wrote:
On 10/22/2010 08:45 PM, Michael Roth wrote:
This set of patches is meant to be applied on top of the Virtproxy v1
patchset.
OVERVIEW:
There are a wide range of use cases motivating the need for a guest
agent of some sort to extend the functionality
On Mon, Oct 25, 2010 at 10:52:05AM -0200, Luiz Capitulino wrote:
> On Mon, 25 Oct 2010 13:39:59 +0800
> Jason Wang wrote:
>
> > When hanlding fd/vhostfd form command line through net_handle_fd_param(),
> > we need to check mon and return value of strtol() otherwise we could
> > get segmentation f
On Mon, Oct 25, 2010 at 05:06:51PM +0200, Markus Armbruster wrote:
> Gleb Natapov writes:
>
> > Prevent two devices from claiming the same io port.
>
> Really?
>
> Your new check for double-claim is in the new isa_init_ioport(), which
> is for ISADevice only. Thus, only qdevified ISA devices c
On Mon, Oct 25, 2010 at 05:10:15PM +0200, Markus Armbruster wrote:
> Gleb Natapov writes:
>
> > PCI bus already has one. For ISA bus this patch series uses device's
> > ioports to uniquely describe it. For isa-ide, for example, get_dev_path
> > method returns:
> > 01f0-01f7,03f6 for first IDE con
On Mon, Oct 25, 2010 at 06:22:12PM +0200, Markus Armbruster wrote:
> Gleb Natapov writes:
>
> > On Mon, Oct 25, 2010 at 04:29:35PM +0200, Markus Armbruster wrote:
> >> Gleb Natapov writes:
> >>
> >> > Without this patch both buses on PIIX3_IDE device have the same unit id.
> >>
> >> Are you su
On Mon, Oct 25, 2010 at 06:23:24PM +0200, Stefan Weil wrote:
> Am 25.10.2010 14:11, schrieb Markus Armbruster:
> >Stefan Weil writes:
> >
> >>Am 13.10.2010 09:13, schrieb Markus Armbruster:
> >>>Stefan Weil writes:
> >[...]
> Do you think there is urgent need for a
> gpxe-eepro100-80862449
On Mon, Oct 25, 2010 at 7:39 AM, Jes Sorensen wrote:
> On 10/23/10 16:42, Blue Swirl wrote:
>> On Mon, Oct 18, 2010 at 8:15 AM, wrote:
>>> From: Jes Sorensen
>>>
>>> Signed-off-by: Jes Sorensen
>>
>> Almost there:
>> CC m68k-linux-user/m68k-semi.o
>> /src/qemu/m68k-semi.c: In function 'do
On Tue, Oct 19, 2010 at 03:33:41PM +0200, Michael S. Tsirkin wrote:
> My main concern is with the fact that we add more state
> in notifiers that can easily get out of sync with users.
> If we absolutely need this state, let's try to at least
> document the state machine, and make the API
> for sta
Am 25.10.2010 14:11, schrieb Markus Armbruster:
Stefan Weil writes:
Am 13.10.2010 09:13, schrieb Markus Armbruster:
Stefan Weil writes:
[...]
Do you think there is urgent need for a gpxe-eepro100-80862449.rom
binary?
Well, "-device i82801" complains because it misses this binary. Do we
w
Gleb Natapov writes:
> On Mon, Oct 25, 2010 at 04:29:35PM +0200, Markus Armbruster wrote:
>> Gleb Natapov writes:
>>
>> > Without this patch both buses on PIIX3_IDE device have the same unit id.
>>
>> Are you sure that's wrong?
>>
> So how do I know which bus is it on PIIX3_IDE?
[...]
Let me
Acked-by: Anthony Liguori
Signed-off-by: Avi Kivity
---
hw/acpi_piix4.c | 30 ++
1 files changed, 18 insertions(+), 12 deletions(-)
diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c
index f74f34c..c01c2ee 100644
--- a/hw/acpi_piix4.c
+++ b/hw/acpi_piix4.c
@@ -52,6 +52
The current ioport callbacks are not type-safe, in that they accept an "opaque"
pointer as an argument whose type must match the argument to the registration
function; this is not checked by the compiler.
This patch adds an alternative that is type-safe. Instead of an opaque
argument, both regist
A recent qemu -> qemu-kvm merge broke cpu hotplug without the compiler
complaining because of the type-unsafeness of the ioport callbacks. This
patchset adds a type-safe variant of ioport callbacks and coverts a sample
ioport. Converting the other 300-odd registrations is left as an excercise
to
On Mon, Oct 25, 2010 at 04:29:35PM +0200, Markus Armbruster wrote:
> Gleb Natapov writes:
>
> > Without this patch both buses on PIIX3_IDE device have the same unit id.
>
> Are you sure that's wrong?
>
So how do I know which bus is it on PIIX3_IDE?
> As far as I can see, IDEBus member unit is
Avi Kivity writes:
> A recent qemu -> qemu-kvm merge broke cpu hotplug without the compiler
> complaining because of the type-unsafeness of the ioport callbacks. This
> patchset adds a type-safe variant of ioport callbacks and coverts a sample
> ioport. Converting the other 300-odd registration
Signed-off-by: Kevin Wolf
---
block/vpc.c | 21 +
1 files changed, 13 insertions(+), 8 deletions(-)
diff --git a/block/vpc.c b/block/vpc.c
index e50509e..416f489 100644
--- a/block/vpc.c
+++ b/block/vpc.c
@@ -439,6 +439,10 @@ static int vpc_write(BlockDriverState *bs, int64
This pulls the request completion for error cases from the caller to
scsi_disk_emulate_command. This should not change semantics, but allows to
reuse scsi_handle_write_error() for flushes in the next patch.
Signed-off-by: Kevin Wolf
---
hw/scsi-disk.c | 21 ++---
1 files change
Signed-off-by: Kevin Wolf
---
hw/scsi-disk.c | 17 -
1 files changed, 16 insertions(+), 1 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index 7418f0b..a1976ea 100644
--- a/hw/scsi-disk.c
+++ b/hw/scsi-disk.c
@@ -45,6 +45,7 @@ do { fprintf(stderr, "scsi-disk: " fmt ,
This implements the rerror option for SCSI disks.
Signed-off-by: Kevin Wolf
---
blockdev.c |2 +-
hw/scsi-disk.c | 91 ++--
2 files changed, 63 insertions(+), 30 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index ff7602b..160fa8
This changes bdrv_flush to return 0 on success and -errno in case of failure.
It's a requirement for implementing proper error handle in users of bdrv_flush.
Signed-off-by: Kevin Wolf
---
block.c | 21 +
block.h |2 +-
block/blkdebug.c |4 ++--
SCSI disks currently only support werror for write requests. This series adds
rerror for failed read requests and respects werror also for flushes.
Kevin Wolf (4):
scsi-disk: Implement rerror option
block: Allow bdrv_flush to return errors
scsi-disk: Complete failed requests in scsi_disk_emu
On Tue, Oct 19, 2010 at 03:33:41PM +0200, Michael S. Tsirkin wrote:
Apologies if you receive this twice, the original message either
disappeared or was delayed somehow.
> My main concern is with the fact that we add more state
> in notifiers that can easily get out of sync with users.
> If we abso
Gleb Natapov writes:
> PCI bus already has one. For ISA bus this patch series uses device's
> ioports to uniquely describe it. For isa-ide, for example, get_dev_path
> method returns:
> 01f0-01f7,03f6 for first IDE controller
> 0170-0177,0376 for second one
Any I/O port used by the device identi
Gleb Natapov writes:
> Prevent two devices from claiming the same io port.
Really?
Your new check for double-claim is in the new isa_init_ioport(), which
is for ISADevice only. Thus, only qdevified ISA devices can opt for
this protection, by calling isa_init_ioport(). It doesn't protect from
Gleb Natapov writes:
> Without this patch both buses on PIIX3_IDE device have the same unit id.
Are you sure that's wrong?
As far as I can see, IDEBus member unit is the currently active unit,
set by write to port 6 (in ide_ioport_write()) and cleared on reset (in
ide_bus_reset()).
> Signed-of
On 10/25/2010 08:52 AM, Paolo Bonzini wrote:
On 10/25/2010 03:46 PM, Anthony Liguori wrote:
Should we create a Documentation/ file with incomplete transitions
and the commit(s) that introduced them, for volunteers who wish to do
some dirty work or to learn Coccinelle?
If we have a TODO, we co
On 10/25/2010 03:46 PM, Anthony Liguori wrote:
Should we create a Documentation/ file with incomplete transitions
and the commit(s) that introduced them, for volunteers who wish to do
some dirty work or to learn Coccinelle?
If we have a TODO, we could add a janitor section there.
That's unne
On 10/24/2010 12:38 PM, Avi Kivity wrote:
On 10/24/2010 07:35 PM, Paolo Bonzini wrote:
On 10/24/2010 05:34 PM, Avi Kivity wrote:
A recent qemu -> qemu-kvm merge broke cpu hotplug without the compiler
complaining because of the type-unsafeness of the ioport callbacks.
This
patchset adds a ty
On 10/24/2010 10:34 AM, Avi Kivity wrote:
A recent qemu -> qemu-kvm merge broke cpu hotplug without the compiler
complaining because of the type-unsafeness of the ioport callbacks. This
patchset adds a type-safe variant of ioport callbacks and coverts a sample
ioport. Converting the other 300-
Paolo Bonzini writes:
> On 10/25/2010 12:54 PM, Lluís wrote:
>> * Backdoor channels need to provide arguments.
>> * It's better to provide the same mechanism for both *-user and softmmu
>> (otherwise the application to simulate or the interposed librariy
>> should be compiled differently on every
On 10/25/2010 02:54 PM, Juan Quintela wrote:
Avi Kivity wrote:
> +static void ioport_writeb_thunk(void *opaque, uint32_t addr, uint32_t data)
> +{
> +IOPort *ioport = opaque;
> +
> +return ioport->ops->writeb(ioport, addr, data);
> +}
> +
> +static void ioport_writew_thunk(void
Avi Kivity wrote:
> +static void ioport_writeb_thunk(void *opaque, uint32_t addr, uint32_t data)
> +{
> +IOPort *ioport = opaque;
> +
> +return ioport->ops->writeb(ioport, addr, data);
> +}
> +
> +static void ioport_writew_thunk(void *opaque, uint32_t addr, uint32_t data)
> +{
> +IOPo
On Mon, 25 Oct 2010 13:39:59 +0800
Jason Wang wrote:
> When hanlding fd/vhostfd form command line through net_handle_fd_param(),
> we need to check mon and return value of strtol() otherwise we could
> get segmentation fault or invalid fd when user type an illegal fd/vhostfd.
>
> This patch is b
On Fri, 22 Oct 2010 22:49:10 +0200
Stefan Weil wrote:
> Am 22.10.2010 19:33, schrieb Luiz Capitulino:
> > On Fri, 22 Oct 2010 19:15:07 +0200
> > Markus Armbruster wrote:
> >
> >
> >> Luiz Capitulino writes:
> >>
> >>
> >>> From: Jan Kiszka
> >>>
> >>> This avoids
> >>>
> >>> erro
On 10/25/2010 12:54 PM, Lluís wrote:
* Backdoor channels need to provide arguments.
* It's better to provide the same mechanism for both *-user and softmmu
(otherwise the application to simulate or the interposed librariy
should be compiled differently on every case).
You can add the sysc
The following changes since commit c57c846a80f9306aa2c6cf7efdef45ed42723fac:
qemu-timer: move commonly used timer code to qemu-timer-common (2010-10-23
15:24:07 +)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/mst/qemu.git for_anthony
Michael S. T
Stefan Weil writes:
> Am 13.10.2010 09:13, schrieb Markus Armbruster:
>> Stefan Weil writes:
[...]
>>> Do you think there is urgent need for a gpxe-eepro100-80862449.rom binary?
>>>
>> Well, "-device i82801" complains because it misses this binary. Do we
>> want to ship that way?
>>
>
Blue Swirl writes:
> On Fri, Oct 22, 2010 at 6:32 PM, Lluís wrote:
>> instrument: Handle config-time activation
>> instrument: Add initial instrumentation example
>> instrument: Dynamic per-CPU state of static instrumentation points
>> instrument: Code-generation macros
>> instrument: [all]
On Mon, Oct 25, 2010 at 08:46:38AM +0200, Michael S. Tsirkin wrote:
> > > --- a/hw/pcie.h
> > > +++ b/hw/pcie.h
> > > @@ -74,6 +74,11 @@ struct PCIExpressDevice {
> > > * also initialize it when loaded as
> > > * appropreately.
> >
Blue Swirl writes:
> On Fri, Oct 22, 2010 at 6:32 PM, Lluís wrote:
>> Lluís Vilanova (17):
>> backdoor: Declare host-side backdoor helpers
>> backdoor: [all] Include backdoor helper declarations
>> backdoor: Declare guest-side interface macros
>> backdoor: [i386] Decode backdoor instructions
On 10/23/2010 04:12 PM, Kevin O'Connor wrote:
On Thu, Oct 21, 2010 at 12:07:17PM +0200, Avi Kivity wrote:
> How do we manage the stable series wrt this issue?
>
> qemu-kvm-0.12.5 has a regression within the stable series that this
> patch fixes. qemu 0.12.5 does not, but only because it does
DMA into memory while VM is stopped makes it
hard to debug migration (consequitive saves
result in different files).
Sending while vm is stopped has an even worse
effect as it confuses the bridges so that they do
not know where to send packets.
Fixing this completely is a large effort,
this patch
On 10/22/2010 08:45 PM, Michael Roth wrote:
This set of patches is meant to be applied on top of the Virtproxy v1 patchset.
OVERVIEW:
There are a wide range of use cases motivating the need for a guest agent of
some sort to extend the functionality/usability/control offered by QEMU.
Some examp
On 10/24/2010 08:14 PM, Blue Swirl wrote:
On Sun, Oct 24, 2010 at 3:34 PM, Avi Kivity wrote:
> The current ioport callbacks are not type-safe, in that they accept an
"opaque"
> pointer as an argument whose type must match the argument to the registration
> function; this is not checked by t
On 10/23/2010 04:41 PM, Michael Roth wrote:
On 10/23/2010 06:31 AM, Andrew Beekhof wrote:
On 10/22/2010 08:45 PM, Michael Roth wrote:
the ability to deploy to guests which may not support virtio-serial,
which currently rules Matahari out.
Possibly there has been some miscommunication, Matah
On Fri, Oct 22, 2010 at 07:55:02AM -0500, Anthony Liguori wrote:
> On 10/22/2010 07:48 AM, Luiz Capitulino wrote:
> >On Thu, 21 Oct 2010 15:27:23 +0200
> >Alon Levy wrote:
> >
> >>On Thu, Oct 21, 2010 at 08:13:19AM -0500, Anthony Liguori wrote:
> >>>On 10/21/2010 08:03 AM, Gerd Hoffmann wrote:
> >
On Mon, Oct 25, 2010 at 04:04:26PM +0900, Isaku Yamahata wrote:
> On Mon, Oct 25, 2010 at 08:46:38AM +0200, Michael S. Tsirkin wrote:
> > On Mon, Oct 25, 2010 at 03:44:01PM +0900, Isaku Yamahata wrote:
> > > On Mon, Oct 25, 2010 at 07:49:41AM +0200, Michael S. Tsirkin wrote:
> > > > Simplify logic
Log must be started before backend is enabled,
to make sure no memory changes are untracked.
Signed-off-by: Michael S. Tsirkin
---
hw/vhost.c | 20 ++--
1 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/hw/vhost.c b/hw/vhost.c
index 8586f66..e0152e2 100644
--- a/
Am 22.10.2010 18:22, schrieb Sage Weil:
> On Fri, 22 Oct 2010, Kevin Wolf wrote:
>> [ Adding qemu-devel to CC again ]
>>
>> Am 21.10.2010 20:59, schrieb Sage Weil:
>>> On Thu, 21 Oct 2010, Christian Brunner wrote:
Hi,
is there a flush operation in librados? - I guess the only way to
On Mon, Oct 25, 2010 at 07:49:41AM +0200, Michael S. Tsirkin wrote:
> Simplify logic for hotplug notification, by tracking state of the
> logical interrupt condition. We then simply use this variable to make
> the interrupt decision, according to spec.
>
> API is made cleaner as we no longer forc
Some comments below.
On Mon, Oct 25, 2010 at 07:05:51AM +0200, Michael S. Tsirkin wrote:
> config cycle operations should be idempotent, so
> there's no need to complicate code with range checks.
>
> Signed-off-by: Michael S. Tsirkin
> ---
>
> Untested. Pls comment.
>
> hw/pcie.c | 96
> ++
config write handlers should be idempotent.
So no need for range checks.
Signed-off-by: Michael S. Tsirkin
---
hw/msi.c | 29 -
1 files changed, 0 insertions(+), 29 deletions(-)
diff --git a/hw/msi.c b/hw/msi.c
index a949d82..af8ea44 100644
--- a/hw/msi.c
+++ b/hw/
On Mon, Oct 25, 2010 at 07:49:41AM +0200, Michael S. Tsirkin wrote:
> Simplify logic for hotplug notification, by tracking state of the
> logical interrupt condition. We then simply use this variable to make
> the interrupt decision, according to spec.
>
> API is made cleaner as we no longer forc
On Mon, Oct 25, 2010 at 03:17:37PM +0900, Isaku Yamahata wrote:
> Some comments below.
>
> On Mon, Oct 25, 2010 at 07:05:51AM +0200, Michael S. Tsirkin wrote:
> > config cycle operations should be idempotent, so
> > there's no need to complicate code with range checks.
> >
> > Signed-off-by: Mich
On Mon, Oct 25, 2010 at 03:44:01PM +0900, Isaku Yamahata wrote:
> On Mon, Oct 25, 2010 at 07:49:41AM +0200, Michael S. Tsirkin wrote:
> > Simplify logic for hotplug notification, by tracking state of the
> > logical interrupt condition. We then simply use this variable to make
> > the interrupt de
On Mon, Oct 25, 2010 at 07:55:57AM +0200, Michael S. Tsirkin wrote:
> On Mon, Oct 25, 2010 at 02:53:16PM +0900, Isaku Yamahata wrote:
> > On Mon, Oct 25, 2010 at 06:15:37AM +0200, Michael S. Tsirkin wrote:
> > > On Mon, Oct 25, 2010 at 12:29:57PM +0900, Isaku Yamahata wrote:
> > > > On Fri, Oct 22,
On Mon, Oct 25, 2010 at 08:46:38AM +0200, Michael S. Tsirkin wrote:
> On Mon, Oct 25, 2010 at 03:44:01PM +0900, Isaku Yamahata wrote:
> > On Mon, Oct 25, 2010 at 07:49:41AM +0200, Michael S. Tsirkin wrote:
> > > Simplify logic for hotplug notification, by tracking state of the
> > > logical interru
Seems good.
For consistency, the range check in msix_write_config() should
be also removed.
On Mon, Oct 25, 2010 at 08:07:25AM +0200, Michael S. Tsirkin wrote:
> config write handlers should be idempotent.
> So no need for range checks.
>
> Signed-off-by: Michael S. Tsirkin
> ---
> hw/msi.c |
On 10/23/10 16:42, Blue Swirl wrote:
> On Mon, Oct 18, 2010 at 8:15 AM, wrote:
>> From: Jes Sorensen
>>
>> Signed-off-by: Jes Sorensen
>
> Almost there:
> CCm68k-linux-user/m68k-semi.o
> /src/qemu/m68k-semi.c: In function 'do_m68k_semihosting':
> /src/qemu/m68k-semi.c:328: error: 'qemu_t
Hmm, does this simply check that write is within the capability?
Then I think I misunderstood what this does.
Please replace hard-coded length logic with existing function call
that gets the lengths, the range check can stay then.
On Mon, Oct 25, 2010 at 04:07:13PM +0900, Isaku Yamahata wrote:
>
On Mon, Oct 25, 2010 at 04:02:36PM +0900, Isaku Yamahata wrote:
> On Mon, Oct 25, 2010 at 07:55:57AM +0200, Michael S. Tsirkin wrote:
> > On Mon, Oct 25, 2010 at 02:53:16PM +0900, Isaku Yamahata wrote:
> > > On Mon, Oct 25, 2010 at 06:15:37AM +0200, Michael S. Tsirkin wrote:
> > > > On Mon, Oct 25,
91 matches
Mail list logo
