On Mon, Oct 25, 2010 at 06:23:24PM +0200, Stefan Weil wrote: > Am 25.10.2010 14:11, schrieb Markus Armbruster: > >Stefan Weil <w...@mail.berlios.de> writes: > > > >>Am 13.10.2010 09:13, schrieb Markus Armbruster: > >>>Stefan Weil<w...@mail.berlios.de> writes: > >[...] > >>>>Do you think there is urgent need for a > >>>>gpxe-eepro100-80862449.rom binary? > >>>> > >>>Well, "-device i82801" complains because it misses this binary. Do we > >>>want to ship that way? > >>> > >> > >>I just sent two patches which create the rom data on load. > >>So -device i82801 no longer complains but gets the boot > >>information from dhcp (tested with i386-softmmu). > >> > >>Your build tree will be made smaller by at least 50 KB :-) > >> > >>Do you think these patches should be added to stable-0.13, too? > > > >If the gain for "-device i82801" is worth the risk, which depends on the > >patch. Have we reached consensus on how to fix it in master? > > > The latest patch version fixes rom data only for the default > roms, so the risk is minimized and full tests are possible. > > There is still no consensus whether we need a new qdev property > (which allows users to have their rom data fixed, too) or not. > > My patch does not prevent adding that new qdev property, > so I suggest applying my patch now and adding the property > later (if it is ever needed). > > Regards > Stefan
Fair enough, I guess. -- MST
