Re: [Qemu-devel] Re: [PATCH v6 07/12] pcie/hotplug: introduce pushing attention button command

2010-10-24 Thread Michael S. Tsirkin
On Mon, Oct 25, 2010 at 02:53:16PM +0900, Isaku Yamahata wrote: > On Mon, Oct 25, 2010 at 06:15:37AM +0200, Michael S. Tsirkin wrote: > > On Mon, Oct 25, 2010 at 12:29:57PM +0900, Isaku Yamahata wrote: > > > On Fri, Oct 22, 2010 at 04:38:49PM +0200, Michael S. Tsirkin wrote: > > > > On Fri, Oct 22,

[Qemu-devel] [PATCH RFC] pcie: clean up hot plug notification

2010-10-24 Thread Michael S. Tsirkin
Simplify logic for hotplug notification, by tracking state of the logical interrupt condition. We then simply use this variable to make the interrupt decision, according to spec. API is made cleaner as we no longer force users to pass in old slot control value. Untested. Signed-off-by: Michael

Re: [Qemu-devel] Re: [PATCH v6 07/12] pcie/hotplug: introduce pushing attention button command

2010-10-24 Thread Isaku Yamahata
On Mon, Oct 25, 2010 at 06:15:37AM +0200, Michael S. Tsirkin wrote: > On Mon, Oct 25, 2010 at 12:29:57PM +0900, Isaku Yamahata wrote: > > On Fri, Oct 22, 2010 at 04:38:49PM +0200, Michael S. Tsirkin wrote: > > > On Fri, Oct 22, 2010 at 01:35:47PM +0200, Markus Armbruster wrote: > > > > "Michael S.

[Qemu-devel] [V3 PATCH] net: properly handle illegal fd/vhostfd from command line

2010-10-24 Thread Jason Wang
When hanlding fd/vhostfd form command line through net_handle_fd_param(), we need to check mon and return value of strtol() otherwise we could get segmentation fault or invalid fd when user type an illegal fd/vhostfd. This patch is based on the suggestions from Luiz Capitulino . Signed-off-by: Ja

Re: [Qemu-devel] bdrv_flush for qemu block drivers nbd, rbd and sheepdog

2010-10-24 Thread MORITA Kazutaka
At Fri, 22 Oct 2010 10:47:44 +0200, Kevin Wolf wrote: > > Am 22.10.2010 07:43, schrieb MORITA Kazutaka: > > At Thu, 21 Oct 2010 16:07:28 +0200, > > Kevin Wolf wrote: > >> > >> Hi all, > >> > >> I'm currently looking into adding a return value to qemu's bdrv_flush > >> function and I noticed that y

[Qemu-devel] [PATCH rfc] pcie: get rid of range checks

2010-10-24 Thread Michael S. Tsirkin
config cycle operations should be idempotent, so there's no need to complicate code with range checks. Signed-off-by: Michael S. Tsirkin --- Untested. Pls comment. hw/pcie.c | 96 ++--- 1 files changed, 47 insertions(+), 49 deletions(-)

[Qemu-devel] Re: [RFC][PATCH 4/5] trace-event

2010-10-24 Thread Prerna Saxena
On 10/22/2010 08:57 PM, Stefan Hajnoczi wrote: On Thu, Oct 21, 2010 at 03:10:18PM +0530, Prerna Saxena wrote: trace-event : QMP interface to change state of a trace-event. (Analogous to hmp command : trace-event ) Signed-off-by: Prerna Saxena --- qmp-commands.hx | 32 +++

Re: [Qemu-devel] Re: [PATCH v6 07/12] pcie/hotplug: introduce pushing attention button command

2010-10-24 Thread Michael S. Tsirkin
On Fri, Oct 22, 2010 at 09:52:19AM -0500, Anthony Liguori wrote: > On 10/22/2010 09:38 AM, Michael S. Tsirkin wrote: > >On Fri, Oct 22, 2010 at 01:35:47PM +0200, Markus Armbruster wrote: > >>"Michael S. Tsirkin" writes: > >> > >>>On Wed, Oct 20, 2010 at 05:18:56PM +0900, Isaku Yamahata wrote: > >>

Re: [Qemu-devel] Re: [PATCH v6 07/12] pcie/hotplug: introduce pushing attention button command

2010-10-24 Thread Michael S. Tsirkin
On Mon, Oct 25, 2010 at 12:29:57PM +0900, Isaku Yamahata wrote: > On Fri, Oct 22, 2010 at 04:38:49PM +0200, Michael S. Tsirkin wrote: > > On Fri, Oct 22, 2010 at 01:35:47PM +0200, Markus Armbruster wrote: > > > "Michael S. Tsirkin" writes: > > > > > > > On Wed, Oct 20, 2010 at 05:18:56PM +0900, I

Re: [Qemu-devel] Re: [PATCH v6 07/12] pcie/hotplug: introduce pushing attention button command

2010-10-24 Thread Isaku Yamahata
On Fri, Oct 22, 2010 at 04:38:49PM +0200, Michael S. Tsirkin wrote: > On Fri, Oct 22, 2010 at 01:35:47PM +0200, Markus Armbruster wrote: > > "Michael S. Tsirkin" writes: > > > > > On Wed, Oct 20, 2010 at 05:18:56PM +0900, Isaku Yamahata wrote: > > >> glue pcie_push_attention_button command. > > >

[Qemu-devel] [Bug 645662] Re: Python 3.1.2 math errors with Qemu 0.12.5

2010-10-24 Thread Arno Wagner
And I unexpectedly had more time to dig. Findings: - asinh() is not in IEEE754, please ignore my comment about non-conformity, sorry. - The calculation for asinh() is pretty badly conditioned, i.e. it blows up errors in the basic calculations. - asinh() is implemented in glibc in as

Re: [Qemu-devel] kqemu with "full" -kernel-kqemu and windows XP guest

2010-10-24 Thread Mulyadi Santosa
On Sun, Oct 24, 2010 at 08:09, John Lumby wrote: >  FYI I have a developed a fairly small and (relative to > kqemu itself) simple workaround for this problem,  that allows you to get > some benefit from  -kernel-kqemu without resorting to other tricks such as > disabling ACPI in the guest device m

[Qemu-devel] OBS 2.1: Status of SuperH (sh4) support with QEMU

2010-10-24 Thread Martin Mohring
Hi, I would like to thank you all who had made QEMU better over the time and specifically who had contributed to QEMU 0.13 and User Mode improvements. One result you can see here: http://lizards.opensuse.org/2010/10/24/obs-2-1-status-of-superh-sh4-support-with-qemu/ So with QEMU user mode help

[Qemu-devel] [PATCH] Use appropriate functions for TLINK debug prints.

2010-10-24 Thread Harsh Prateek Bora
Running fsstress with debug enabled causes assertion failure because of inappropriate usage of debug print functions. With this patch, fsstress passes without assertion failure. Signed-off-by: Harsh Prateek Bora --- hw/virtio-9p-debug.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(

Re: [Qemu-devel] [PATCH 1/2] Type-safe ioport callbacks

2010-10-24 Thread Blue Swirl
On Sun, Oct 24, 2010 at 3:34 PM, Avi Kivity wrote: > The current ioport callbacks are not type-safe, in that they accept an > "opaque" > pointer as an argument whose type must match the argument to the registration > function; this is not checked by the compiler. > > This patch adds an alternativ

[Qemu-devel] Re: [PATCH 0/2] Type-safe ioport callbacks

2010-10-24 Thread Avi Kivity
On 10/24/2010 07:35 PM, Paolo Bonzini wrote: On 10/24/2010 05:34 PM, Avi Kivity wrote: A recent qemu -> qemu-kvm merge broke cpu hotplug without the compiler complaining because of the type-unsafeness of the ioport callbacks. This patchset adds a type-safe variant of ioport callbacks and cov

[Qemu-devel] Re: [PATCH 0/2] Type-safe ioport callbacks

2010-10-24 Thread Paolo Bonzini
On 10/24/2010 05:34 PM, Avi Kivity wrote: A recent qemu -> qemu-kvm merge broke cpu hotplug without the compiler complaining because of the type-unsafeness of the ioport callbacks. This patchset adds a type-safe variant of ioport callbacks and coverts a sample ioport. Converting the other 300-

[Qemu-devel] Re: [PATCH 1/2] Type-safe ioport callbacks

2010-10-24 Thread Avi Kivity
On 10/24/2010 05:34 PM, Avi Kivity wrote: Currently the old and new methods exist side by side; once the old way is gone, we can also save a bunch of memory since the new method requires one pointer per ioport instead of 6. Actually, 1:7, we replace 3 read callbacks, 3 write callbacks, and 1

[Qemu-devel] [PATCH] initialize unit id of IDE bus

2010-10-24 Thread Gleb Natapov
Without this patch both buses on PIIX3_IDE device have the same unit id. Signed-off-by: Gleb Natapov diff --git a/hw/ide/cmd646.c b/hw/ide/cmd646.c index ff80dd5..b2cbdbc 100644 --- a/hw/ide/cmd646.c +++ b/hw/ide/cmd646.c @@ -257,8 +257,8 @@ static int pci_cmd646_ide_initfn(PCIDevice *dev) p

[Qemu-devel] [PATCH 2/2] piix4 acpi: convert io BAR to type-safe ioport callbacks

2010-10-24 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/acpi_piix4.c | 30 ++ 1 files changed, 18 insertions(+), 12 deletions(-) diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c index f74f34c..5772667 100644 --- a/hw/acpi_piix4.c +++ b/hw/acpi_piix4.c @@ -52,6 +52,7 @@ struct pci_status {

[Qemu-devel] [PATCH 1/2] Type-safe ioport callbacks

2010-10-24 Thread Avi Kivity
The current ioport callbacks are not type-safe, in that they accept an "opaque" pointer as an argument whose type must match the argument to the registration function; this is not checked by the compiler. This patch adds an alternative that is type-safe. Instead of an opaque argument, both regist

[Qemu-devel] [PATCH 0/2] Type-safe ioport callbacks

2010-10-24 Thread Avi Kivity
A recent qemu -> qemu-kvm merge broke cpu hotplug without the compiler complaining because of the type-unsafeness of the ioport callbacks. This patchset adds a type-safe variant of ioport callbacks and coverts a sample ioport. Converting the other 300-odd registrations is left as an excercise to

[Qemu-devel] [PATCH 1/2] Keep track of ISA ports ISA device is using in qdev.

2010-10-24 Thread Gleb Natapov
Prevent two devices from claiming the same io port. Signed-off-by: Gleb Natapov --- hw/cs4231a.c |1 + hw/fdc.c |3 +++ hw/gus.c |4 hw/ide/isa.c |2 ++ hw/isa-bus.c | 31 +++ hw/isa.h |4 hw/m48t59.c

[Qemu-devel] [PATCH 2/2] Add get_dev_path callback to ISA bus in qdev.

2010-10-24 Thread Gleb Natapov
Use device ioports to create unique device path. Signed-off-by: Gleb Natapov --- hw/isa-bus.c | 39 +++ 1 files changed, 39 insertions(+), 0 deletions(-) diff --git a/hw/isa-bus.c b/hw/isa-bus.c index c509d56..ed0b665 100644 --- a/hw/isa-bus.c +++ b/hw/isa-

[Qemu-devel] [PATCH 0/2] Add get_dev_path callback to ISA bus.

2010-10-24 Thread Gleb Natapov
PCI bus already has one. For ISA bus this patch series uses device's ioports to uniquely describe it. For isa-ide, for example, get_dev_path method returns: 01f0-01f7,03f6 for first IDE controller 0170-0177,0376 for second one Gleb Natapov (2): Keep track of ISA ports ISA device is using in qdev

[Qemu-devel] [PATCH 3/4] add ccid-card-emulated device (v2)

2010-10-24 Thread Alon Levy
changes from v1: remove stale comments, use only c-style comments bugfix, forgot to set recv_len change reader name to 'Virtual Reader' Signed-off-by: Alon Levy --- Makefile.objs |2 +- configure | 20 ++ hw/ccid-card-emulated.c | 495 ++

[Qemu-devel] [PATCH 4/4] ccid: add docs

2010-10-24 Thread Alon Levy
--- docs/ccid.txt | 133 + 1 files changed, 133 insertions(+), 0 deletions(-) create mode 100644 docs/ccid.txt diff --git a/docs/ccid.txt b/docs/ccid.txt new file mode 100644 index 000..5eac611 --- /dev/null +++ b/docs/ccid.txt @@ -0,0

[Qemu-devel] [PATCH 1/4] usb-ccid: add CCID bus

2010-10-24 Thread Alon Levy
A CCID device is a smart card reader. It is a USB device, defined at [1]. This patch introduces the usb-ccid device that is a ccid bus. Next patches will introduce two card types to use it, a passthru card and an emulated card. [1] http://www.usb.org/developers/devclass_docs/DWG_Smart-Card_CCID_R

[Qemu-devel] [PATCH 2/4] ccid: add passthru card device

2010-10-24 Thread Alon Levy
For the client side utility vscclient, see libcac_card: libcac_card http://cgit.freedesktop.org/~alon/cac_card (temporary home) written by Robert Relyea Signed-off-by: Alon Levy --- Makefile.objs |2 +- hw/ccid-card-passthru.c | 278 ++

[Qemu-devel] [PATCH 0/4] usb-ccid (v4)

2010-10-24 Thread Alon Levy
This patchset adds three new devices, usb-ccid, ccid-card-passthru and ccid-card-emulated, providing a CCID bus, a simple passthru protocol implementing card requiring a client, and a standalone emulated card. v4 changes just the bus following Markus remarks, but I'm resending everything since

[Qemu-devel] [PATCHv3] Add support for async page fault to qemu

2010-10-24 Thread Gleb Natapov
Add save/restore of MSR for migration and cpuid bit. Signed-off-by: Gleb Natapov -- v1->v2 - use vmstate subsection to migrate new msr. v2->v3 - rebase onto uq/master - protect use of MSR_KVM_ASYNC_PF_EN with ifdef KVM_CAP_ASYNC_PF diff --git a/target-i386/cpu.h b/target-i386/cpu.h index