Re: [Qemu-devel] [PATCH 3/9] QMP: First half of the new argument checking code

Luiz Capitulino writes: > This commit introduces the first half of qmp_check_client_args(), > which is the new client argument checker. > > It's introduced on top of the existing code, so that there are > no regressions during the transition. > > It works this way: the command's args_type field (

Re: [Qemu-devel] [PATCH] virtio-blk: assign a default serial number if none provided

02.06.2010 05:48, Ryan Harper wrote: [] hw/virtio-blk.c |3 +++ +if (strlen(s->sn) == 0) { Just out of curiocity (not that it is wrong or inefficient): why strlen(s->sn) and not, say, !s->sn[0] ? /mjt

[Qemu-devel] [PATCH v2] x86: svm: Always clear event_inj on vmexit

Erik van der Kouwe wrote: > Hi, > >> We currently only clear SVM_EVTINJ_VALID after successful interrupt >> delivery. This apparently does not match real hardware which clears the >> whole event_inj field on every vmexit, including unsuccessful interrupt >> delivery. > > Thanks for the patch. It

[Qemu-devel] Re: [SeaBIOS] SMBIOS strings

On 06/01/10 22:26, Sebastian Herbszt wrote: > Jes Sorensen wrote: >> Handle 0x0401, DMI type 4, 32 bytes >> Processor Information >> - Socket Designation: CPU 1 >> + Socket Designation: CPU01 > > smbios.c got > snprintf((char*)start, 6, "CPU%2x", cpu_number); > > It should print "CPU

Re: [Qemu-devel] [PATCH 1/9] QDict: Introduce qdict_get_try_bool()

Luiz Capitulino writes: > Signed-off-by: Luiz Capitulino > --- > qdict.c | 18 ++ > qdict.h |1 + > 2 files changed, 19 insertions(+), 0 deletions(-) > > diff --git a/qdict.c b/qdict.c > index 175bc17..ca3c3b1 100644 > --- a/qdict.c > +++ b/qdict.c > @@ -287,6 +287,24 @@ i

Re: [Qemu-devel] [PATCH 2/8] sparc64: fix missing address masking

On Wed, Jun 2, 2010 at 12:44 AM, Richard Henderson wrote: > On 06/01/2010 01:12 PM, Igor V. Kovalenko wrote: >> +    if ((env->pstate & PS_AM) && is_translating_asi(asi)) { >> +        addr &= 0xULL; >> +    } > > I suggest that these be written instead as > >  if (is_translating_asi(asi))

[Qemu-devel] [PATCH] Extra scan codes for missing keys

The code comes from http://lists.gnu.org/archive/html/qemu-devel/2010-05/msg02788.html Without this patch it is not possible to send at least 10 special characters (\|'"`~:;[]{}) via the monitor sendkey command. Signed-off-by: Bernhard M. Wiedemann --- monitor.c |7 ++- 1 files changed,

Re: [Qemu-devel] [PATCH 0/4] Add virtio disk identification support

Ryan Harper wrote: > I've applied the qemu and kernel side of this patch series and tested > this out using the sample code below. I've also reworked this example > into a virtioblk_id tool to work with udev to generate /dev/disk/by-id > links; I'll be submitting a patch set to linux-hotplug with

[Qemu-devel] [PATCH] virtio-blk: assign a default serial number if none provided

This patch applies on-top of John's virtio-blk serial patches. Generate default serial numbers for virtio drives based on DriveInfo.unit which is incremented for each additional virtio-blk device. This provides a per-virtio-blk number to use in the default string: QM%05d that is used in hw/ide/c

Re: [Qemu-devel] [PATCH 0/4] Add virtio disk identification support

* john cooper [2010-03-25 00:45]: > This series adds the minimal support to qemu and virtio_blk > to support passing of a virtio_blk serial id string from qemu > through the guest driver and to the guest userland. > > This is derived in part from a patch set posted by Rusty some > time ago, but h

[Qemu-devel] [Bug 588127] Re: qemu fails to recognize host features SSE4.1, SSE4.2

Ok, building from source now: Passing SSE4.* to the guest does not work for me thru qemu-kvm-0.12.4, but it _does_ work at current head (git:aa22e82, 0.12.50). I can bisect further if anybody cares... -- qemu fails to recognize host features SSE4.1, SSE4.2 https://bugs.launchpad.net/bugs/588127

Re: [SeaBIOS] [Qemu-devel] Re: SMBIOS strings

On Tue, Jun 01, 2010 at 08:05:26AM +0200, Jes Sorensen wrote: > On 06/01/10 07:34, Markus Armbruster wrote: > > "Sebastian Herbszt" writes: > >> Gleb Natapov wrote: > >>> I don't care much as long as we will not have "CPU :". It looks like > >>> something > >>> that can change after BIOS upgrade,

[Qemu-devel] [PATCH] Fix multiboot compilation

Commit dd4239d6574ca41c94fc0d0f77ddc728510ffc57 broke multiboot. It replaced the instruction "rep insb (%dx), %es:(%edi)" by the binary output of "addr32 rep insb (%dx), %es:(%di)". Linuxboot calls the respective helper function in a code16 section. So the original instruction was automatically tr

[Qemu-devel] Re: [SeaBIOS] SMBIOS strings

On Tue, Jun 01, 2010 at 10:26:12PM +0200, Sebastian Herbszt wrote: > Jes Sorensen wrote: > >Handle 0x0401, DMI type 4, 32 bytes > >Processor Information > >- Socket Designation: CPU 1 > >+ Socket Designation: CPU01 > > smbios.c got > snprintf((char*)start, 6, "CPU%2x", cpu_number); >

[Qemu-devel] [PATCH] pc: push setting default cpu_model down a level

Not that CPU hotplug currently works, but if you make the mistake of trying it on a VM started without specifying a -cpu value, you hit a segfault from trying to strdup(NULL) in cpu_x86_find_by_name(). Signed-off-by: Alex Williamson --- hw/pc.c | 16 1 files changed, 8 insert

[Qemu-devel] [PATCH] monitor: allow device to be ejected if no disk is inserted

Resubmitting a patch that was submitted in December[1]. It was on the staging tree but somehow it got dropped. I have rebased it to current master branch on git. [1] http://article.gmane.org/gmane.comp.emulators.qemu/59813 This changes the monitor eject_device() function to not check

Re: [Qemu-devel] [PATCH 1/3] vnc: tight: don't forget last pixel in tight_encode_indexed_rect

On 06/01/2010 04:05 PM, Corentin Chary wrote: A simple patch would have been to just remove count -= 1, but this one also replace the while (count--) with a for(i = 0; i< count; i++) which I believe is more easy to understand. Signed-off-by: Corentin Chary Applied all. Thanks. Regards,

[Qemu-devel] [PATCH 3/3] vnc: add missing target for vnc-encodings-*.o

vnc-encodings-*.c dependencies where missing. Signed-off-by: Corentin Chary --- Makefile |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index cc5fc45..221fbd8 100644 --- a/Makefile +++ b/Makefile @@ -120,11 +120,11 @@ vnc-auth-vencrypt.o: vnc-au

[Qemu-devel] [PATCH 2/3] vnc: tight: don't forget the third color

While couting color, if the third color was only present one time it wasn't added to the palette. Signed-off-by: Corentin Chary --- vnc-encoding-tight.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/vnc-encoding-tight.c b/vnc-encoding-tight.c index c8effe6..efb57e7 100

[Qemu-devel] [PATCH 1/3] vnc: tight: don't forget last pixel in tight_encode_indexed_rect

A simple patch would have been to just remove count -= 1, but this one also replace the while (count--) with a for(i = 0; i < count; i++) which I believe is more easy to understand. Signed-off-by: Corentin Chary --- vnc-encoding-tight.c |9 - 1 files changed, 4 insertions(+), 5 delet

[Qemu-devel] [PATCH 0/3] Small tight fixes

Hi, Here is two small tight fix and another small patch related to vnc encodings. Thanks, Corentin Chary (3): vnc: tight: don't forget last pixel in tight_encode_indexed_rect vnc: tight: don't forget the third color vnc: add missing target for vnc-encodings-*.o Makefile |6

Re: [Qemu-devel] [PATCH 1/3] vnc: tight: don't forget last pixel in tight_encode_indexed_rect

On Thu, May 27, 2010 at 4:28 PM, Richard Henderson wrote: > On 05/26/2010 11:21 PM, Corentin Chary wrote: >> -        int rep = 0;                                                    \ >> +        int i = 0, rep = 0;                                             \ > > Dead initialization. > > > r~ >

[Qemu-devel] [PATCH 4/9] QMP: Second half of the new argument checking code

This commit introduces check_client_args_type(), which is called by qmp_check_client_args() and complements the previous commit. Now the new client's argument checker code is capable of doing type checking and detecting unknown arguments. It works this way: we iterate over the client's arguments

Re: [Qemu-devel] [PATCH 2/8] sparc64: fix missing address masking

On 06/01/2010 01:12 PM, Igor V. Kovalenko wrote: > +if ((env->pstate & PS_AM) && is_translating_asi(asi)) { > +addr &= 0xULL; > +} I suggest that these be written instead as if (is_translating_asi(asi)) { addr = address_mask(addr); } That should allow you to remov

[Qemu-devel] [PATCH 7/9] QError: Introduce QERR_QMP_BAD_INPUT_OBJECT_MEMBER

Signed-off-by: Luiz Capitulino --- qerror.c |4 qerror.h |3 +++ 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/qerror.c b/qerror.c index 44d0bf8..b26224e 100644 --- a/qerror.c +++ b/qerror.c @@ -177,6 +177,10 @@ static const QErrorStringTable qerror_table[] = {

[Qemu-devel] [PATCH 5/9] QMP: Drop old client argument checker

Previous two commits added qmp_check_client_args(), which fully replaces this code and is way better. It's important to note that the new checker doesn't support the '/' arg type. As we don't have any of those handlers converted to QMP, this is just dead code. Signed-off-by: Luiz Capitulino ---

[Qemu-devel] [PATCH 9/9] QMP: Drop old input object checking code

Previous commit added qmp_check_input_obj(), it does this checking for us. Signed-off-by: Luiz Capitulino --- monitor.c |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/monitor.c b/monitor.c index 654b193..f849456 100644 --- a/monitor.c +++ b/monitor.c @@ -4347,9 +43

[Qemu-devel] [PATCH 6/9] QMP: check_opts(): Minor cleanup

We couldn't do it before, otherwise we would break the intention of the previous checker, which was to ensure that opts_list wasn't a NULL before checking it. Debug code, pretty minor, still I decided to maintain its original behavior. Signed-off-by: Luiz Capitulino --- monitor.c |2 +- 1 f

[Qemu-devel] [PATCH 2/9] Monitor: handle optional '-' arg as a bool

Historically, user monitor arguments beginning with '-' (eg. '-f') were passed as integers down to handlers. I've maintained this behavior in the new monitor because we didn't have a boolean type at the very beginning of QMP. Today we have it and this behavior is causing trouble to the code that c

[Qemu-devel] [PATCH 8/9] QMP: Introduce qmp_check_input_obj()

This is similar to qmp_check_client_args(), but checks if the input object follows the specification (QMP/qmp-spec.txt section 2.3). As we're limited to three keys, the work here is quite simple: we iterate over the input object, each time checking if the given argument complies to the specificati

[Qemu-devel] [PATCH 3/9] QMP: First half of the new argument checking code

This commit introduces the first half of qmp_check_client_args(), which is the new client argument checker. It's introduced on top of the existing code, so that there are no regressions during the transition. It works this way: the command's args_type field (from qemu-monitor.hx) is transformed i

[Qemu-devel] [PATCH 0/9]: QMP: Replace client argument checker

Current QMP's client argument checker implementation is more complex than it should be and has a flaw: it ignores unknown arguments. This series solves both problems by introducing a new, simple and ultra-poweful argument checker. This wasn't trivial to get right due to the number of errors combin

[Qemu-devel] [PATCH 1/9] QDict: Introduce qdict_get_try_bool()

Signed-off-by: Luiz Capitulino --- qdict.c | 18 ++ qdict.h |1 + 2 files changed, 19 insertions(+), 0 deletions(-) diff --git a/qdict.c b/qdict.c index 175bc17..ca3c3b1 100644 --- a/qdict.c +++ b/qdict.c @@ -287,6 +287,24 @@ int64_t qdict_get_try_int(const QDict *qdict, co

[Qemu-devel] Re: [PATCH] x86: svm: Always clear event_inj on vmexit

Hi, > We currently only clear SVM_EVTINJ_VALID after successful interrupt > delivery. This apparently does not match real hardware which clears the > whole event_inj field on every vmexit, including unsuccessful interrupt > delivery. Thanks for the patch. It is a bit hard for me to test right no

[Qemu-devel] [PATCH] virtio-9p: Rearrange fileop structures

This patch rearranges the fileop structures by moving the structure definitions from virtio-9p.c to virtio-9p.h file. No functional changes. Signed-off-by: Venkateswararao Jujjuri --- hw/virtio-9p.c | 185 ++-- hw/virtio-9p.h | 92 ++

[Qemu-devel] Re: [SeaBIOS] SMBIOS strings

Jes Sorensen wrote: Handle 0x0401, DMI type 4, 32 bytes Processor Information - Socket Designation: CPU 1 + Socket Designation: CPU01 smbios.c got snprintf((char*)start, 6, "CPU%2x", cpu_number); It should print "CPU 1" instead of "CPU01" because the padding should be done with spa

[Qemu-devel] [PATCH] ahci: drop ATA_CMD constants

Drop ATA_CMD constants and use constants from ide/internal.h. Signed-off-by: Sebastian Herbszt diff --git a/hw/ahci.c b/hw/ahci.c index 9987459..b4eafdf 100644 --- a/hw/ahci.c +++ b/hw/ahci.c @@ -153,33 +153,6 @@ do { fprintf(stderr,"ahci: " fmt , ## __VA_ARGS__); } while (0) #define STATE_RES

[Qemu-devel] [PATCH] [virtio-9p] Flush the debug message out to the log file.

This patch fluesh the debug messages to the log file at the end of each debug message. Signed-off-by: Venkateswararao Jujjuri --- hw/virtio-9p-debug.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/virtio-9p-debug.c b/hw/virtio-9p-debug.c index 2fb2673..5bfa689 100

[Qemu-devel] [PATCH 7/8] sparc64: fix udiv and sdiv insns

From: Igor V. Kovalenko - truncate second operand to 32bit Signed-off-by: Igor V. Kovalenko --- target-sparc/op_helper.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target-sparc/op_helper.c b/target-sparc/op_helper.c index 83067ae..4c5155f 100644 --- a/target-sp

[Qemu-devel] [PATCH 5/8] sparc64: use symbolic name for MMU index

From: Igor V. Kovalenko Signed-off-by: Igor V. Kovalenko --- target-sparc/op_helper.c | 28 1 files changed, 16 insertions(+), 12 deletions(-) diff --git a/target-sparc/op_helper.c b/target-sparc/op_helper.c index f5e153d..b9af52b 100644 --- a/target-sparc/op_hel

[Qemu-devel] Re: [PATCH] sparc32 esp fix spurious interrupts in chip reset

2010/6/1 Blue Swirl : > On Tue, Jun 1, 2010 at 7:56 PM, Artyom Tarasenko > wrote: >> 2010/6/1 Blue Swirl : >>> On Sun, May 30, 2010 at 10:35 PM, Artyom Tarasenko >>> wrote: lower interrupt during chip reset. Otherwise the ESP_RSTAT register may get out of sync with the IRQ line status.

[Qemu-devel] [PATCH 6/8] sparc64: improve ldf and stf insns

From: Igor V. Kovalenko - implemented block load/store primary/secondary with user privilege Signed-off-by: Igor V. Kovalenko --- target-sparc/op_helper.c | 28 1 files changed, 28 insertions(+), 0 deletions(-) diff --git a/target-sparc/op_helper.c b/target-spar

[Qemu-devel] [PATCH 8/8] sparc64: fix umul and smul insns

From: Igor V. Kovalenko - truncate and sign or zero extend operands before multiplication - factor out common code to gen_op_multiply() with parameter to sign/zero extend - call gen_op_multiply from gen_op_umul and gen_op_smul Signed-off-by: Igor V. Kovalenko --- target-sparc/translate.c | 5

[Qemu-devel] [PATCH 3/8] sparc64: fix 32bit load sign extension

From: Igor V. Kovalenko - change return type of ldl_* to uint32_t to prevent unwanted sign extension visible in sparc64 load alternate address space methods - note this change makes ldl_* softmmu implementations match ldl_phys one Signed-off-by: Igor V. Kovalenko --- softmmu_header.h |2 +

[Qemu-devel] [PATCH 2/8] sparc64: fix missing address masking

From: Igor V. Kovalenko - address masking for ldqf and stqf insns - address masking for lddf and stdf insns - address masking for translating ASI (Ultrasparc IIi) Signed-off-by: Igor V. Kovalenko --- target-sparc/op_helper.c | 47 ++ target-sparc/t

[Qemu-devel] [PATCH 4/8] sparc64: fix ldxfsr insn

From: Igor V. Kovalenko - rearrange code to break from switch when appropriate - allow deprecated ldfsr insn Signed-off-by: Igor V. Kovalenko --- target-sparc/translate.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/target-sparc/translate.c b/target-sparc/trans

[Qemu-devel] [PATCH 0/8] sparc64 fixes

assorted changes, linux kernel can now work with 32bit init task --- Igor V. Kovalenko (8): sparc64: fix tag access register on mmu traps sparc64: fix missing address masking sparc64: fix 32bit load sign extension sparc64: fix ldxfsr insn sparc64: use symbolic name f

[Qemu-devel] [PATCH 1/8] sparc64: fix tag access register on mmu traps

From: Igor V. Kovalenko - set mmu tag access register on FAULT and PROT traps as well Signed-off-by: Igor V. Kovalenko --- target-sparc/helper.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/target-sparc/helper.c b/target-sparc/helper.c index 96a22f3..aa1fd63 100

[Qemu-devel] Re: [PATCH] sparc32 esp fix spurious interrupts in chip reset

On Tue, Jun 1, 2010 at 7:56 PM, Artyom Tarasenko wrote: > 2010/6/1 Blue Swirl : >> On Sun, May 30, 2010 at 10:35 PM, Artyom Tarasenko >> wrote: >>> lower interrupt during chip reset. Otherwise the ESP_RSTAT register >>> may get out of sync with the IRQ line status. This effect became >>> visible

[Qemu-devel] Re: [PATCH] sparc32 esp fix spurious interrupts in chip reset

2010/6/1 Blue Swirl : > On Sun, May 30, 2010 at 10:35 PM, Artyom Tarasenko > wrote: >> lower interrupt during chip reset. Otherwise the ESP_RSTAT register >> may get out of sync with the IRQ line status. This effect became >> visible after commit 65899fe3 > > Hard reset handlers should not touch q

Re: [Qemu-devel] [PATCH] Extra scan codes for missing keys

On 06/01/2010 02:29 PM, Bernhard M. Wiedemann wrote: The code comes from http://lists.gnu.org/archive/html/qemu-devel/2010-05/msg02788.html Without this patch it is not possible to send at least 10 special characters (\|'"`~:;[]{}) via the monitor sendkey command. Signed-off-by: Bernhard M. Wie

[Qemu-devel] [PATCH] Extra scan codes for missing keys

The code comes from http://lists.gnu.org/archive/html/qemu-devel/2010-05/msg02788.html Without this patch it is not possible to send at least 10 special characters (\|'"`~:;[]{}) via the monitor sendkey command. Signed-off-by: Bernhard M. Wiedemann --- monitor.c |6 ++ 1 files changed,

Re: [Qemu-devel] [PATCH 1/3] monitor: Reorder info documentation

On 05/31/2010 12:43 PM, Luiz Capitulino wrote: From: Jan Kiszka Push the doc fragments for the info command to the end of qemu-monitor.hx. This helps to establish a proper layout in the upcoming QMP documentation. Signed-off-by: Jan Kiszka Applied all. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] Re: [PATCH] qdev: Reject duplicate and anti-social device IDs

On 06/01/2010 01:35 PM, Markus Armbruster wrote: Luiz Capitulino writes: On Tue, 01 Jun 2010 16:44:24 +0200 Markus Armbruster wrote: Luiz Capitulino writes: On Mon, 31 May 2010 16:13:12 +0200 Markus Armbruster wrote: We need Device IDs to be unique and not

[Qemu-devel] [PATCH 01/14] blockdev: Belatedly remove MAX_DRIVES

Unused since commit 751c6a17. Signed-off-by: Markus Armbruster --- sysemu.h |1 - vl.c |2 -- 2 files changed, 0 insertions(+), 3 deletions(-) diff --git a/sysemu.h b/sysemu.h index 879446a..063319c 100644 --- a/sysemu.h +++ b/sysemu.h @@ -176,7 +176,6 @@ typedef struct DriveInfo {

[Qemu-devel] [PATCH 02/14] blockdev: Belatedly remove driveopts

Unused since commit 9dfd7c7a. Signed-off-by: Markus Armbruster --- sysemu.h |1 - vl.c |1 - 2 files changed, 0 insertions(+), 2 deletions(-) diff --git a/sysemu.h b/sysemu.h index 063319c..fd83b7d 100644 --- a/sysemu.h +++ b/sysemu.h @@ -178,7 +178,6 @@ typedef struct DriveInfo {

[Qemu-devel] [PATCH 03/14] usb: Remove unused usb_device_add() parameter is_hotplug

Unused since commit b3e461d3. Signed-off-by: Markus Armbruster --- vl.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/vl.c b/vl.c index 9283469..76a9b25 100644 --- a/vl.c +++ b/vl.c @@ -1315,7 +1315,7 @@ static void smp_parse(const char *optarg) /

[Qemu-devel] [PATCH 09/14] qdev: New qdev_prop_set_string()

Signed-off-by: Markus Armbruster --- hw/qdev-properties.c |5 + hw/qdev.h|1 + 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c index 9ffdba7..b6ee50f 100644 --- a/hw/qdev-properties.c +++ b/hw/qdev-properties.c @@

Re: [Qemu-devel] [PATCH 2/2] migration: Fix calculation of bytes_transferred

On 05/12/2010 08:12 AM, Pierre Riteau wrote: When a page with all identical bytes is transferred, it is counted as a full page (TARGET_PAGE_SIZE) although only one byte is actually sent. Fix this by changing ram_save_block() to return the number of bytes sent instead of a boolean value. This make

[Qemu-devel] [PATCH 00/14] Block-related fixes and cleanups

I'm working on cleanly separating block device host and guest parts. I'd like to route all this work through Kevin's block tree. This is just preliminaries. v2: Don't break IDE serial Markus Armbruster (14): blockdev: Belatedly remove MAX_DRIVES blockdev: Belatedly remove driveopts usb: Re

[Qemu-devel] [PATCH 05/14] ide: Remove redundant IDEState member conf

Commit 428c149b added IDEState member conf to let commit 0009baf1 find the BlockConf from there. It exists only for qdev drives, created via ide_drive_initfn(), not for drives created via ide_init2(). But for a qdev drive, we can just as well reach its IDEDevice, which contains the BlockConf. Do

[Qemu-devel] [PATCH 10/14] qdev: Don't leak string property value on hot unplug

parse_string() qemu_strdup()s the property value. It is never freed. It needs to be freed along with the device. Otherwise, the value of scsi-disk property "ver" gets leaked when hot-unplugging the disk, for instance. Call new PropertyInfo method free() from qdev_free(). Implement it for qdev_p

[Qemu-devel] [PATCH 14/14] scsi: Fix info qtree for scsi-disk.ver

Show the actual default value instead of when the property has not been set. Signed-off-by: Markus Armbruster --- hw/scsi-disk.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index e8c066a..a3559d1 100644 --- a/hw/scsi-disk.c +++

[Qemu-devel] [PATCH 13/14] scsi: Turn drive serial into a qdev property scsi-disk.serial

It needs to be a qdev property, because it belongs to the drive's guest part. Bonus: info qtree now shows the serial number. Signed-off-by: Markus Armbruster --- hw/scsi-disk.c | 17 + 1 files changed, 13 insertions(+), 4 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-dis

[Qemu-devel] [PATCH 12/14] ide: Fix info qtree for ide-drive.ver

Show the actual default value instead of when the property has not been set. Signed-off-by: Markus Armbruster --- hw/ide/qdev.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/ide/qdev.c b/hw/ide/qdev.c index 5e549d9..6231d77 100644 --- a/hw/ide/qdev.c +++ b/hw/ide

[Qemu-devel] [PATCH 11/14] ide: Turn drive serial into a qdev property ide-drive.serial

It needs to be a qdev property, because it belongs to the drive's guest part. Bonus: info qtree now shows the serial number. Signed-off-by: Markus Armbruster --- hw/ide/core.c | 11 ++- hw/ide/internal.h |4 +++- hw/ide/qdev.c | 16 +++- 3 files changed, 24 i

[Qemu-devel] [PATCH 06/14] ide: Split ide_init1() off ide_init2()

Signed-off-by: Markus Armbruster --- hw/ide/core.c | 32 +--- 1 files changed, 17 insertions(+), 15 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index c3334b1..443ff10 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -2633,27 +2633,29 @@ void ide_init_d

[Qemu-devel] [PATCH 08/14] ide: Split non-qdev code off ide_init2()

Signed-off-by: Markus Armbruster --- hw/ide/cmd646.c |4 ++-- hw/ide/core.c | 30 ++ hw/ide/internal.h |5 +++-- hw/ide/isa.c|2 +- hw/ide/macio.c |2 +- hw/ide/microdrive.c |3 ++- hw/ide/mmio.c |2 +- hw/ide/p

[Qemu-devel] [PATCH 07/14] ide: Change ide_init_drive() to require valid dinfo argument

IDEState members drive_serial_str and version are now left empty until an actual drive is connected. Before, they got a default value that was overwritten when a drive got connected. Doesn't matter, because they're used only while a drive is connected. Signed-off-by: Markus Armbruster --- hw/i

[Qemu-devel] Re: [PULLv2] pci fixes

On 05/31/2010 01:47 PM, Michael S. Tsirkin wrote: OK, I dropped the vhost change for now: I still think we should not bother about mingw for linux-only code, but at this point it's not important for me. The following changes since commit aa6f63fff62faf2fe9ffba5a789675d49293614d: mc146818rtc:

[Qemu-devel] [PATCH 04/14] ide: Remove useless IDEDeviceInfo members unit, drive

Signed-off-by: Markus Armbruster --- hw/ide/internal.h |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/hw/ide/internal.h b/hw/ide/internal.h index 2efc784..b4554ce 100644 --- a/hw/ide/internal.h +++ b/hw/ide/internal.h @@ -464,8 +464,6 @@ typedef int (*ide_qdev_initfn)(

Re: [Qemu-devel] [PATCH 1/5] vnc: factor out vnc_desktop_resize()

On 05/25/2010 11:25 AM, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann Applied all. Thanks. Regards, Anthony Liguori --- vnc.c | 24 1 files changed, 16 insertions(+), 8 deletions(-) diff --git a/vnc.c b/vnc.c index 11ae3e5..aaebe24 100644 --- a/vnc.c

Re: [Qemu-devel] Re: [PATCH] qdev: Reject duplicate and anti-social device IDs

Luiz Capitulino writes: > On Tue, 01 Jun 2010 16:44:24 +0200 > Markus Armbruster wrote: > >> Luiz Capitulino writes: >> >> > On Mon, 31 May 2010 16:13:12 +0200 >> > Markus Armbruster wrote: >> > >> >> We need Device IDs to be unique and not contain '/' so device tree >> >> nodes can always be

[Qemu-devel] Re: [PATCH 07/14] ide: Change ide_init_drive() to require valid dinfo argument

Kevin Wolf writes: > Am 28.05.2010 15:38, schrieb Markus Armbruster: >> IDEState members drive_serial_str and version are now left empty until >> an actual drive is connected. Before, they got a default value that >> was overwritten when a drive got connected. Doesn't matter, because >> they're

Re: [Qemu-devel] [PATCH] Add support for depth 15 to qemu_default_pixelformat()

On 05/21/2010 04:59 AM, Gerd Hoffmann wrote: Makes qemu_default_pixelformat(15) return pixelformat filled for 15 bit color depth (16 bpp, 5 bits for red,green,blue each, 1 bit unused). Signed-off-by: Gerd Hoffmann Applied. Thanks. Regards, Anthony Liguori --- console.c | 16 +++

Re: [Qemu-devel] [PATCH] resent: x86/cpuid: Add kvm32 CPU model

On 05/21/2010 02:50 AM, Andre Przywara wrote: Create a kvm32 CPU model that describes a least common denominator for KVM capable guest CPUs. Useful for migration purposes. Signed-off-by: Andre Przywara Applied. Thanks. Regards, Anthony Liguori --- target-i386/cpuid.c | 14 +

Re: [Qemu-devel] Re: [RFT][PATCH 07/15] qemu_irq: Add IRQ handlers with delivery feedback

On Tue, Jun 01, 2010 at 06:00:20PM +, Blue Swirl wrote: > >> > Looks like irr in apic is never cleared. Probably bug in userspace apic > >> > emulation. I'll look into it. Try to route interrupt via APIC (not > >> > ExtInt), > >> > or use qemu-kvm with in kernel irq chip. > >> > >> With APIC y

Re: [Qemu-devel] [PATCH] check for active_console before using it

On 05/20/2010 08:23 AM, Gerd Hoffmann wrote: Other vga_hw_* functions do the same. Fixes a segmentation fault. Trigger: boot with -nodefaults, then connect via vnc. Signed-off-by: Gerd Hoffmann Applied. Thanks. Regards, Anthony Liguori --- console.c |2 +- 1 files changed, 1 in

Re: [Qemu-devel] [PATCH] Add dependency of JSON unit tests on config-host.h

On 05/20/2010 02:18 AM, Jan Kiszka wrote: From: Jan Kiszka Signed-off-by: Jan Kiszka Applied. Thanks. Regards, Anthony Liguori --- Makefile |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/Makefile b/Makefile index 110698e..aa81d9b 100644 --- a/Makefile +++

Re: [Qemu-devel] [PATCH] virtio-serial-bus: fix ports_map allocation on init

On 05/19/2010 04:31 AM, Amit Shah wrote: From: Alon Levy Fix for too small allocation to ports_map Signed-off-by: Alon Levy Signed-off-by: Amit Shah Applied. Thanks. Regards, Anthony Liguori --- hw/virtio-serial-bus.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) d

Re: [Qemu-devel] [PATCH v3 01/12] Revert "vnc: set the right prefered encoding"

On 05/19/2010 02:24 AM, Corentin Chary wrote: This patch was wrong, because the loop was already reversed, so the first encoding was correctly set at the end of the loopp. This reverts commit 14eb8b6829ad9dee7035de729e083844a425f274. Signed-off-by: Corentin Chary Applied all. Thanks. Re

Re: [Qemu-devel] Re: [PATCH 2/3] QMP: Introduce commands documentation

Anthony Liguori wrote: > On 06/01/2010 12:39 PM, Jan Kiszka wrote: >> Oh, it's indeed a local issue. Likely our corporate mail server. Nice... >> Sorry for the noise! >> > > Jan, I believe you're okay with the current state of this series, yes? Yes, of course! > > I'd like to apply these AS

[Qemu-devel] [PATCH v2 0/2] basic machine opts framework

Hello, This is a resent (rebased) of an old patch set of mine, I sent some time ago. With that, we should have all the needed infrastructure to select the in-kernel irqchip for KVM. Glauber Costa (2): early set current_machine basic machine opts framework hw/boards.h | 10 +

Re: [Qemu-devel] Re: [PATCH 2/3] QMP: Introduce commands documentation

On 06/01/2010 12:39 PM, Jan Kiszka wrote: Oh, it's indeed a local issue. Likely our corporate mail server. Nice... Sorry for the noise! Jan, I believe you're okay with the current state of this series, yes? I'd like to apply these ASAP so we can start formal spec review. Regards, Anthon

[Qemu-devel] [PATCH v2 2/2] basic machine opts framework

This patch adds initial support for the -machine option, that allows command line specification of machine attributes (always relying on safe defaults). Besides its value per-se, it is the saner way we found to allow for enabling/disabling of kvm's in-kernel irqchip. A machine with in-kernel-irqch

[Qemu-devel] [PATCH v2 1/2] early set current_machine

this way, the machine_init function itself can know which machine is current in use, not only the late init code. Signed-off-by: Glauber Costa --- vl.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/vl.c b/vl.c index 96838f8..7a8b20b 100644 --- a/vl.c +++ b/vl.c @@ -

Re: [Qemu-devel] Re: [RFT][PATCH 07/15] qemu_irq: Add IRQ handlers with delivery feedback

On Mon, May 31, 2010 at 5:19 AM, Gleb Natapov wrote: > On Sun, May 30, 2010 at 08:21:30PM +, Blue Swirl wrote: >> On Sun, May 30, 2010 at 8:07 PM, Gleb Natapov wrote: >> > On Sun, May 30, 2010 at 07:37:59PM +, Blue Swirl wrote: >> >> On Sun, May 30, 2010 at 1:49 PM, Gleb Natapov wrote: >

[Qemu-devel] [PATCH] x86: svm: Always clear event_inj on vmexit

We currently only clear SVM_EVTINJ_VALID after successful interrupt delivery. This apparently does not match real hardware which clears the whole event_inj field on every vmexit, including unsuccessful interrupt delivery. Reported-by: Erik van der Kouwe Signed-off-by: Jan Kiszka --- (before it

[Qemu-devel] Re: [PATCH] sparc32 esp fix spurious interrupts in chip reset

On Sun, May 30, 2010 at 10:35 PM, Artyom Tarasenko wrote: > lower interrupt during chip reset. Otherwise the ESP_RSTAT register > may get out of sync with the IRQ line status. This effect became > visible after commit 65899fe3 Hard reset handlers should not touch qemu_irqs, because on cold start,

[Qemu-devel] Re: [PATCH 2/3] QMP: Introduce commands documentation

Luiz Capitulino wrote: > On Tue, 01 Jun 2010 18:10:26 +0200 > Jan Kiszka wrote: > >> Luiz Capitulino wrote: >>> From: Jan Kiszka >>> >>> One of the most important missing feature in QMP today is its >>> supported commands documentation. >>> >>> The plan is to make it part of self-description sup

Re: [Qemu-devel] [PATCH -V4 7/7] virtio-9p: Implemented security model for chown and chgrp.

On Wed, May 26, 2010 at 04:21:46PM -0700, Venkateswararao Jujjuri (JV) wrote: > Signed-off-by: Venkateswararao Jujjuri > --- > hw/file-op-9p.h |4 ++-- > hw/virtio-9p-local.c | 18 ++ > hw/virtio-9p.c | 15 --- > 3 files changed, 28 insertions(+), 9

Re: [Qemu-devel] [PATCH -V4 3/7] virtio-9p: modify create/open2 and mkdir for new security model.

On Wed, May 26, 2010 at 04:21:42PM -0700, Venkateswararao Jujjuri (JV) wrote: > Add required infrastructure and modify create/open2 and mkdir per the new > security model. > > Signed-off-by: Venkateswararao Jujjuri > --- > hw/file-op-9p.h | 23 +++- > hw/virtio-9p-local.c | 149 > ++

[Qemu-devel] Re: [PATCH 2/3] QMP: Introduce commands documentation

On Tue, 01 Jun 2010 18:10:26 +0200 Jan Kiszka wrote: > Luiz Capitulino wrote: > > From: Jan Kiszka > > > > One of the most important missing feature in QMP today is its > > supported commands documentation. > > > > The plan is to make it part of self-description support, however > > self-descr

Re: [Qemu-devel] [PATCH -V4 1/7] virtio-9p: Introduces an option to specify the security model.

On Wed, May 26, 2010 at 04:21:40PM -0700, Venkateswararao Jujjuri (JV) wrote: > The new option is: > > -fsdev fstype,id=myid,path=/share_path/,security_model=[mapped|passthrough] > -virtfs > fstype,path=/share_path/,security_model=[mapped|passthrough],mnt_tag=tag > > In the case of mapped securi

Re: [Qemu-devel] [PATCH -V4 2/7] virtio-9p: Rearrange fileop structures

On Wed, May 26, 2010 at 04:21:41PM -0700, Venkateswararao Jujjuri (JV) wrote: > Signed-off-by: Venkateswararao Jujjuri > --- > hw/virtio-9p.c | 185 > ++-- > hw/virtio-9p.h | 92 > 2 files changed, 138 insertions

Re: [Qemu-devel] [PATCH] block: Assume raw for drives without media

On Tue, 2010-06-01 at 18:50 +0200, Kevin Wolf wrote: > qemu -cdrom /dev/cdrom with an empty CD-ROM drive doesn't work any more > because > we try to guess the format and when this fails (because there is no medium) we > exit with an error message. > > This patch should restore the old behaviour b

Re: [Qemu-devel] Re: [PULL] pci, vhost fixes

On Tue, Jun 1, 2010 at 5:32 AM, Markus Armbruster wrote: > Blue Swirl writes: > >> On Mon, May 31, 2010 at 1:35 PM, Michael S. Tsirkin wrote: >>> On Mon, May 31, 2010 at 02:51:26PM +0200, Paolo Bonzini wrote: On 05/30/2010 08:19 PM, Blue Swirl wrote: > We have PRI*64 just for this purpo

[Qemu-devel] [PATCH] block: Assume raw for drives without media

qemu -cdrom /dev/cdrom with an empty CD-ROM drive doesn't work any more because we try to guess the format and when this fails (because there is no medium) we exit with an error message. This patch should restore the old behaviour by assuming raw format for such drives. Signed-off-by: Kevin Wolf

Re: [Qemu-devel] Re: [PATCH 2/4] migration-tcp: threaded tcp incoming migration.

2010/6/2 Anthony Liguori : > On 06/01/2010 11:23 AM, Yoshiaki Tamura wrote: >> >> 2010/6/2 Anthony Liguori: >> >>> >>> On 06/01/2010 10:40 AM, Yoshiaki Tamura wrote: >>> Create a thread to handle tcp incoming migration when CONFIG_IOTHREAD is enabled.  Spawned thread writes it's retu

Re: [Qemu-devel] Re: [PATCH 0/4] Threaded tcp incoming migration.

2010/6/2 Anthony Liguori : > On 06/01/2010 11:18 AM, Yoshiaki Tamura wrote: >> >> 2010/6/2 Anthony Liguori: >> >>> >>> On 06/01/2010 10:40 AM, Yoshiaki Tamura wrote: >>> Hi, This series add threaded tcp incoming migration.  Currently, tcp migration on incoming sid

  1   2   >