Re: [Qemu-devel] KVM call agenda for May 25

2010-05-24 Thread Gautham R Shenoy
On Mon, May 24, 2010 at 05:21:04PM -0700, Chris Wright wrote: > Please send in any agenda items you are interested in covering. > Sorry for the delayed response. If the community is interested, I would like to discuss the Generic Asynchronous task offloading framework patches posted to the commu

Re: [Qemu-devel] [RFT][PATCH 07/15] qemu_irq: Add IRQ handlers with delivery feedback

2010-05-24 Thread Jan Kiszka
Gleb Natapov wrote: > On Tue, May 25, 2010 at 08:31:06AM +0200, Jan Kiszka wrote: >> Gleb Natapov wrote: >>> On Mon, May 24, 2010 at 10:13:40PM +0200, Jan Kiszka wrote: From: Jan Kiszka This allows to communicate potential IRQ coalescing during delivery from the sink back to th

Re: [Qemu-devel] [RFT][PATCH 07/15] qemu_irq: Add IRQ handlers with delivery feedback

2010-05-24 Thread Gleb Natapov
On Tue, May 25, 2010 at 08:31:06AM +0200, Jan Kiszka wrote: > Gleb Natapov wrote: > > On Mon, May 24, 2010 at 10:13:40PM +0200, Jan Kiszka wrote: > >> From: Jan Kiszka > >> > >> This allows to communicate potential IRQ coalescing during delivery from > >> the sink back to the source. Targets that

Re: [Qemu-devel] [RFT][PATCH 07/15] qemu_irq: Add IRQ handlers with delivery feedback

2010-05-24 Thread Jan Kiszka
Gleb Natapov wrote: > On Mon, May 24, 2010 at 10:13:40PM +0200, Jan Kiszka wrote: >> From: Jan Kiszka >> >> This allows to communicate potential IRQ coalescing during delivery from >> the sink back to the source. Targets that support IRQ coalescing >> workarounds need to register handlers that ret

[Qemu-devel] Re: [PATCH] sdl: fix setenv for win32

2010-05-24 Thread Jan Kiszka
TeLeMan wrote: > setenv() is not implemented on MinGW, so we have to use putenv(). What a ... pity. > > Signed-off-by: TeLeMan > --- > sdl.c |4 > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/sdl.c b/sdl.c > index add1148..eb4a87f 100644 > --- a/sdl.c > +++ b/sdl

Re: [Qemu-devel] Re: [PATCH, RFC 1/4] mc146818: move hpet handling to pc.c

2010-05-24 Thread Gleb Natapov
On Tue, May 25, 2010 at 08:09:02AM +0200, Jan Kiszka wrote: > Gleb Natapov wrote: > > On Mon, May 24, 2010 at 10:20:31PM +0200, Jan Kiszka wrote: > >>> Maybe the coalescing should be pushed to APIC, or even generalized. > >> The latter has happened, hopefully in the right direction. > >> > > What d

Re: [Qemu-devel] Re: [PATCH, RFC 1/4] mc146818: move hpet handling to pc.c

2010-05-24 Thread Jan Kiszka
Gleb Natapov wrote: > On Mon, May 24, 2010 at 10:20:31PM +0200, Jan Kiszka wrote: >>> Maybe the coalescing should be pushed to APIC, or even generalized. >> The latter has happened, hopefully in the right direction. >> > What do you mean by that? The latter: I tried to generalize. Please look at p

Re: [Qemu-devel] [RFT][PATCH 07/15] qemu_irq: Add IRQ handlers with delivery feedback

2010-05-24 Thread Gleb Natapov
On Mon, May 24, 2010 at 10:13:40PM +0200, Jan Kiszka wrote: > From: Jan Kiszka > > This allows to communicate potential IRQ coalescing during delivery from > the sink back to the source. Targets that support IRQ coalescing > workarounds need to register handlers that return the appropriate > QEMU

Re: [Qemu-devel] Re: [PATCH, RFC 1/4] mc146818: move hpet handling to pc.c

2010-05-24 Thread Gleb Natapov
On Mon, May 24, 2010 at 07:58:28PM +, Blue Swirl wrote: > > having to deal with all those details via complex APIs. But the > > coalescing mess is still causing headaches to me, at least when trying > > to come up with something long-term ready. > > Maybe the coalescing should be pushed to API

Re: [Qemu-devel] Re: [PATCH, RFC 1/4] mc146818: move hpet handling to pc.c

2010-05-24 Thread Gleb Natapov
On Mon, May 24, 2010 at 10:20:31PM +0200, Jan Kiszka wrote: > > Maybe the coalescing should be pushed to APIC, or even generalized. > > The latter has happened, hopefully in the right direction. > What do you mean by that? -- Gleb.

[Qemu-devel] [PATCH] sdl: fix setenv for win32

2010-05-24 Thread TeLeMan
setenv() is not implemented on MinGW, so we have to use putenv(). Signed-off-by: TeLeMan --- sdl.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/sdl.c b/sdl.c index add1148..eb4a87f 100644 --- a/sdl.c +++ b/sdl.c @@ -850,7 +850,11 @@ void sdl_display_init(DisplaySta

[Qemu-devel] KVM call agenda for May 25

2010-05-24 Thread Chris Wright
Please send in any agenda items you are interested in covering. If we have a lack of agenda items I'll cancel the week's call. thanks, -chris

[Qemu-devel] B2B Newsletter - My LeasingShop

2010-05-24 Thread My Leasingshop
Sehr geehrte Damen und Herren, wieso kaufen, wenn man auch leasen kann? Wir möchten, dass sie ihre Träume verwirklichen und bieten ihnen deshalb praktische Möglichkeiten. EDV & Technik Leasing - mit uns ist alles möglich. Lernen Sie mit unserem Technik Leasing eine attraktive Alternative zum Ka

Re: [Qemu-devel] Re: [PATCH v2 12/15] monitor: Add basic device state visualization

2010-05-24 Thread Anthony Liguori
On 05/24/2010 05:12 PM, Jan Kiszka wrote: Anthony Liguori wrote: On 05/24/2010 03:35 PM, Jan Kiszka wrote: In contrast to save/loadvm, device_show does not provide a backward-compatible output. Not only field names can change (as a result of internal refactoring), Field names

Re: [Qemu-devel] Unable to install Windows XP and 2003 with libvirt

2010-05-24 Thread Bruce Rogers
>>> On 5/24/2010 at 05:43 AM, Laurent Léonard wrote: > The problem has already been reported on the list here : > http://lists.nongnu.org/archive/html/qemu-devel/2010-03/msg01725.html > > Any information on what can be done to solve that problem ? Is there any > available patch for KVM ? > >

Re: [Qemu-devel] [PATCH 1/5] trace: Add trace-events file for declaring trace events

2010-05-24 Thread Anthony Liguori
On 05/22/2010 04:08 PM, Stefan Hajnoczi wrote: This patch introduces the trace-events file where trace events can be declared like so: qemu_malloc(size_t size) "size %zu" qemu_free(void *ptr) "ptr %p" These trace event declarations are processed by a new tool called tracetool to generate code f

Re: [Qemu-devel] [RFT][PATCH 00/15] HPET cleanups, fixes, enhancements

2010-05-24 Thread Anthony Liguori
On 05/24/2010 03:13 PM, Jan Kiszka wrote: Not yet for merge (unless I happened to forgot adding bugs), just a Request For Testing (and for review, of course). This series grew beyond my initial plans and my current testing capabilities, Linux and Win7 are apparently still fine, but that's all I c

Re: [Qemu-devel] Re: [PATCH v2 12/15] monitor: Add basic device state visualization

2010-05-24 Thread Jan Kiszka
Anthony Liguori wrote: > On 05/24/2010 03:35 PM, Jan Kiszka wrote: >> In contrast to save/loadvm, device_show does not provide a >> backward-compatible output. Not only field names can change (as a result >> of internal refactoring), > > Field names could change, but that seems unlikely and unnece

Re: [Qemu-devel] [PATCH] resent: fix CPUID vendor override

2010-05-24 Thread Anthony Liguori
On 05/21/2010 12:58 AM, Andre Przywara wrote: the meaning of vendor_override is actually the opposite of how it is currently used :-( Fix it to allow KVM to export the non-native CPUID vendor if explicitly requested by the user. The semantic is now as intended: - With TCG, the guest always sees t

Re: [Qemu-devel] [PATCH] resent: x86/cpuid: propagate further CPUID leafs when -cpu host

2010-05-24 Thread Anthony Liguori
On 05/21/2010 02:50 AM, Andre Przywara wrote: -cpu host currently only propagates the CPU's family/model/stepping, the brand name and the feature bits. Add a whitelist of safe CPUID leafs to let the guest see the actual CPU's cache details and other things. Signed-off-by: Andre Przywara Th

Re: [Qemu-devel] [PATCH 1/5] trace: Add trace-events file for declaring trace events

2010-05-24 Thread Anthony Liguori
On 05/22/2010 04:08 PM, Stefan Hajnoczi wrote: This patch introduces the trace-events file where trace events can be declared like so: qemu_malloc(size_t size) "size %zu" qemu_free(void *ptr) "ptr %p" These trace event declarations are processed by a new tool called tracetool to generate code f

Re: [Qemu-devel] [PATCH] sdl: Do not disable screensaver by default

2010-05-24 Thread Anthony Liguori
On 05/24/2010 04:40 PM, Michael Tokarev wrote: 23.05.2010 12:29, Jan Kiszka wrote: From: Jan Kiszka Unless we are running in full-screen mode, QEMU's SDL window should not disable the host's screensaver. The user can still change this behaviour by setting the environment variable SDL_VIDEO_ALLO

Re: [Qemu-devel] Re: [PATCH v2 12/15] monitor: Add basic device state visualization

2010-05-24 Thread Anthony Liguori
On 05/24/2010 03:35 PM, Jan Kiszka wrote: In contrast to save/loadvm, device_show does not provide a backward-compatible output. Not only field names can change (as a result of internal refactoring), Field names could change, but that seems unlikely and unnecessary. fields may even disappea

Re: [Qemu-devel] [PATCH] sdl: Do not disable screensaver by default

2010-05-24 Thread Michael Tokarev
25.05.2010 01:40, Michael Tokarev wrote: 23.05.2010 12:29, Jan Kiszka wrote: From: Jan Kiszka Unless we are running in full-screen mode, QEMU's SDL window should not disable the host's screensaver. The user can still change this behaviour by setting the environment variable SDL_VIDEO_ALLOW_SCRE

Re: [Qemu-devel] [PATCH] sdl: Do not disable screensaver by default

2010-05-24 Thread Michael Tokarev
23.05.2010 12:29, Jan Kiszka wrote: From: Jan Kiszka Unless we are running in full-screen mode, QEMU's SDL window should not disable the host's screensaver. The user can still change this behaviour by setting the environment variable SDL_VIDEO_ALLOW_SCREENSAVER as desired. Signed-off-by: Jan Ki

Re: [Qemu-devel] [PATCH 1/2] virtio-9p: make virtio-9p available to all POSIX systems

2010-05-24 Thread Venkateswararao Jujjuri (JV)
Blue Swirl wrote: > Field d_off in struct dirent is Linux specific. > > Signed-off-by: Blue Swirl > --- > Makefile.objs |8 > Makefile.target |2 +- > hw/virtio-9p.c |2 +- > hw/virtio-pci.c |6 +++--- > hw/virtio.h |4 ++-- > qemu-config.c |4 ++-- > qe

[Qemu-devel] Re: [RFT][PATCH 01/15] hpet: Catch out-of-bounds timer access

2010-05-24 Thread Jan Kiszka
Juan Quintela wrote: > Jan Kiszka wrote: >> From: Jan Kiszka >> >> Also prevent out-of-bounds write access to the timers but don't spam the >> host console if it triggers. >> >> Signed-off-by: Jan Kiszka >> --- >> hw/hpet.c |6 +- >> 1 files changed, 5 insertions(+), 1 deletions(-) >> >

[Qemu-devel] [Bug 583462] Re: qemu disables screensaver

2010-05-24 Thread Anthony Liguori
This is now fixed by: commit 111f8ec99b67aeef152c71a5db12f0c0cb2422bd Author: Jan Kiszka Date: Sun May 23 10:29:34 2010 +0200 sdl: Do not disable screensaver by default Unless we are running in full-screen mode, QEMU's SDL window should not disable the host's screensaver. The

[Qemu-devel] Re: [RFT][PATCH 01/15] hpet: Catch out-of-bounds timer access

2010-05-24 Thread Juan Quintela
Jan Kiszka wrote: > Juan Quintela wrote: >> Jan Kiszka wrote: >>> From: Jan Kiszka >>> >>> Also prevent out-of-bounds write access to the timers but don't spam the >>> host console if it triggers. >>> >>> Signed-off-by: Jan Kiszka >>> --- >>> hw/hpet.c |6 +- >>> 1 files changed, 5 ins

[Qemu-devel] Re: [RFT][PATCH 02/15] hpet: Coding style cleanups and some refactorings

2010-05-24 Thread Juan Quintela
Jan Kiszka wrote: > From: Jan Kiszka > > This moves the private HPET structures into the C module, I almost did this one on my previous series, thanks. > simplifies > some helper functions and fixes most coding style issues (biggest chunk > was improper switch-case indention). No functional cha

Re: [Qemu-devel] Re: [PATCH v2 12/15] monitor: Add basic device state visualization

2010-05-24 Thread Jan Kiszka
Anthony Liguori wrote: > On 05/22/2010 01:55 PM, Avi Kivity wrote: >> On 05/22/2010 11:18 AM, Jan Kiszka wrote: >>> From: Jan Kiszka >>> >>> This introduces device_show, a monitor command that saves the vmstate of >>> a qdev device and visualizes it. QMP is also supported. Buffers are cut >>> after

[Qemu-devel] Compile qemu-i386 as library

2010-05-24 Thread John Vele
Greetings, I want to compile the i386 linux user part of qemu as a library (Shared or static) to use it with other applications. (Right now it produces a ./i386-linux-user/qemu-i386 executable). Anyone does know if this is possible? Which Makefile shall I edit? Thanx in advance

[Qemu-devel] Re: [RFT][PATCH 01/15] hpet: Catch out-of-bounds timer access

2010-05-24 Thread Juan Quintela
Jan Kiszka wrote: > From: Jan Kiszka > > Also prevent out-of-bounds write access to the timers but don't spam the > host console if it triggers. > > Signed-off-by: Jan Kiszka > --- > hw/hpet.c |6 +- > 1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/hw/hpet.c b/hw/hpet

[Qemu-devel] [RFT][PATCH 14/15] hpet: Add MSI support

2010-05-24 Thread Jan Kiszka
From: Jan Kiszka This implements the HPET capability of routing IRQs to the front-side bus, aka MSI support. This feature can be enabled via the qdev property "msi" and is off by default. Note that switching it on can cause guests (at least Linux) to use the HPET as timer instead of the LAPIC. K

Re: [Qemu-devel] Re: [PATCH v2 12/15] monitor: Add basic device state visualization

2010-05-24 Thread Anthony Liguori
On 05/22/2010 01:55 PM, Avi Kivity wrote: On 05/22/2010 11:18 AM, Jan Kiszka wrote: From: Jan Kiszka This introduces device_show, a monitor command that saves the vmstate of a qdev device and visualizes it. QMP is also supported. Buffers are cut after 16 byte by default, but the full content ca

Re: [Qemu-devel] [PATCH] Fix error handling in qemu_read_config_file

2010-05-24 Thread Anthony Liguori
On 05/17/2010 03:36 AM, Kevin Wolf wrote: We need to close the file even in error case. While at it, make the callers catch all kind of errors. ENOENT is allowed for default config files, they are optional. Reported-by: Luiz Capitulino Signed-off-by: Kevin Wolf Applied. Thanks. Regards,

Re: [Qemu-devel] [PATCH 1/3] cursor: add cursor functions.

2010-05-24 Thread Anthony Liguori
On 05/21/2010 04:54 AM, Gerd Hoffmann wrote: Add a new cursor type to console.h and a bunch of functions to deal with cursors the (new) cursor.c file. Signed-off-by: Gerd Hoffmann Applied all. Thanks. Regards, Anthony Liguori --- Makefile.objs |3 +- console.h |

Re: [Qemu-devel] [PATCH] Virtio-net: Replace the hardcode 6 with defined ETN_ALEN

2010-05-24 Thread Anthony Liguori
On 05/22/2010 09:49 PM, ak...@redhat.com wrote: From: Amos Kong hw/virtio-net.h: #define ETH_ALEN6 ETH_ALEN was defined by commit 7967406801aa897fae83caad3278ac85a342adaa Signed-off-by: Amos Kong Applied. Thanks. Regards, Anthony Liguori --- hw/virtio-net.h |4 ++-- 1

[Qemu-devel] [RFT][PATCH 12/15] vmstate: Add VMSTATE_STRUCT_VARRAY_UINT8

2010-05-24 Thread Jan Kiszka
From: Jan Kiszka Required for hpet. Signed-off-by: Jan Kiszka --- hw/hw.h | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/hw/hw.h b/hw/hw.h index fc2d184..36be0be 100644 --- a/hw/hw.h +++ b/hw/hw.h @@ -474,6 +474,16 @@ extern const VMStateInfo vmstate_info_un

Re: [Qemu-devel] [PATCH] sdl: Do not disable screensaver by default

2010-05-24 Thread Anthony Liguori
On 05/23/2010 03:29 AM, Jan Kiszka wrote: From: Jan Kiszka Unless we are running in full-screen mode, QEMU's SDL window should not disable the host's screensaver. The user can still change this behaviour by setting the environment variable SDL_VIDEO_ALLOW_SCREENSAVER as desired. Signed-off-by:

[Qemu-devel] Re: [PATCH, RFC 1/4] mc146818: move hpet handling to pc.c

2010-05-24 Thread Jan Kiszka
Blue Swirl wrote: > On Mon, May 24, 2010 at 3:30 PM, Jan Kiszka wrote: >> Blue Swirl wrote: >>> On Sun, May 23, 2010 at 3:40 PM, Jan Kiszka wrote: Blue Swirl wrote: > Move hpet_in_legacy_mode check from mc146818.c to pc.c. Remove > the optimization where the periodic timer is disable

[Qemu-devel] [RFT][PATCH 08/15] x86: Refactor RTC IRQ coalescing workaround

2010-05-24 Thread Jan Kiszka
From: Jan Kiszka Make use of the new feedback IRQ handlers and propagate coalesced deliveries via handler return code from the sink to the source. As a by-product, this also adds coalescing support to the PIC. Signed-off-by: Jan Kiszka --- hw/apic.c| 61 ++

Re: [Qemu-devel] [PATCH v2 1/3] add some tests for invalid JSON

2010-05-24 Thread Anthony Liguori
On 05/24/2010 02:39 AM, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini I think this series conflicts a bit with Luiz's series which I just pushed. Could you rebase against the latest? Regards, Anthony Liguori --- check-qjson.c | 98 +

Re: [Qemu-devel] Re: [PATCH v2 12/15] monitor: Add basic device state visualization

2010-05-24 Thread Anthony Liguori
On 05/24/2010 07:51 AM, Luiz Capitulino wrote: On Sun, 23 May 2010 09:57:43 +0200 Jan Kiszka wrote: Avi Kivity wrote: [...] +- "full": report full state (json-bool, optional) Is this needed for QMP? The client can always truncate it to any length.

[Qemu-devel] [RFT][PATCH 09/15] hpet/rtc: Rework RTC IRQ replacement by HPET

2010-05-24 Thread Jan Kiszka
From: Jan Kiszka Allow the intercept the RTC IRQ for the HPET legacy mode. Then push routing to IRQ8 completely into the HPET. This allows to turn hpet_in_legacy_mode() into a private function. Furthermore, this stops the RTC from clearing IRQ8 even if the HPET is in control. This patch comes wi

[Qemu-devel] Re: [PATCH 0/6] Make hpet a compile time option

2010-05-24 Thread Blue Swirl
On Mon, May 24, 2010 at 6:03 PM, Anthony Liguori wrote: > On 05/24/2010 12:54 PM, Juan Quintela wrote: >> >> Paul Brook  wrote: >> On 05/24/2010 11:32 AM, Paul Brook wrote: >> >> Notice that this patch was sent against hpet as one example, if we >> agree >> that this

[Qemu-devel] [RFT][PATCH 11/15] hpet: Add support for level-triggered interrupts

2010-05-24 Thread Jan Kiszka
From: Jan Kiszka By implementing this feature we can also remove a nasty way to kill qemu (by trying to enable level-triggered hpet interrupts). Signed-off-by: Jan Kiszka --- hw/hpet.c | 32 ++-- 1 files changed, 22 insertions(+), 10 deletions(-) diff --git a/hw/

[Qemu-devel] [RFT][PATCH 10/15] hpet: Drop static state

2010-05-24 Thread Jan Kiszka
From: Jan Kiszka Instead of keeping a static reference around, pass the state to hpet_enabled and hpet_get_ticks. All callers now have it at hand. Will once allow to instantiate the HPET more than a single time. Signed-off-by: Jan Kiszka --- hw/hpet.c | 38 +--

[Qemu-devel] [RFT][PATCH 02/15] hpet: Coding style cleanups and some refactorings

2010-05-24 Thread Jan Kiszka
From: Jan Kiszka This moves the private HPET structures into the C module, simplifies some helper functions and fixes most coding style issues (biggest chunk was improper switch-case indention). No functional changes. Signed-off-by: Jan Kiszka --- hw/hpet.c | 413

[Qemu-devel] [RFT][PATCH 13/15] hpet: Make number of timers configurable

2010-05-24 Thread Jan Kiszka
From: Jan Kiszka One HPET block supports up to 32 timers. Allow to instantiate more than the recommended and implemented minimum of 3. The number is configured via the qdev property "timers". It is also saved/restored so that it need not match between migration peers. Signed-off-by: Jan Kiszka

[Qemu-devel] [RFT][PATCH 07/15] qemu_irq: Add IRQ handlers with delivery feedback

2010-05-24 Thread Jan Kiszka
From: Jan Kiszka This allows to communicate potential IRQ coalescing during delivery from the sink back to the source. Targets that support IRQ coalescing workarounds need to register handlers that return the appropriate QEMU_IRQ_* code, and they have to propergate the code across all IRQ redirec

[Qemu-devel] [RFT][PATCH 15/15] monitor/QMP: Drop info hpet / query-hpet

2010-05-24 Thread Jan Kiszka
From: Jan Kiszka This command was of minimal use before, now it is useless as the hpet become a qdev device and is thus easily discoverable. We should definitely not set query-hpet in QMP's stone, and there is also no good reason to keep it for the interactive monitor. Signed-off-by: Jan Kiszka

[Qemu-devel] [RFT][PATCH 06/15] hpet: Start/stop timer when HPET_TN_ENABLE is modified

2010-05-24 Thread Jan Kiszka
From: Jan Kiszka We have to update the qemu timer when the per-timer enable bit is toggled, just like for HPET_CFG_ENABLE changes. Signed-off-by: Jan Kiszka --- hw/hpet.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/hw/hpet.c b/hw/hpet.c index 6974935..041dd84 1

Re: [Qemu-devel] [PATCH -V3 3/7] virtio-9p: modify create/open2 and mkdir for new security model.

2010-05-24 Thread Anthony Liguori
On 05/21/2010 04:26 PM, Venkateswararao Jujjuri (JV) wrote: Add required infrastructure and modify create/open2 and mkdir per the new security model. Signed-off-by: Venkateswararao Jujjuri --- hw/file-op-9p.h | 23 - hw/virtio-9p-local.c | 139 +

[Qemu-devel] [RFT][PATCH 03/15] hpet: Silence warning on write to running main counter

2010-05-24 Thread Jan Kiszka
From: Jan Kiszka Setting the main counter while the HPET is enabled may not be a good idea of the guest, but it is supported and should, thus, not spam the host console with warnings. Signed-off-by: Jan Kiszka --- hw/hpet.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --

[Qemu-devel] [RFT][PATCH 00/15] HPET cleanups, fixes, enhancements

2010-05-24 Thread Jan Kiszka
Not yet for merge (unless I happened to forgot adding bugs), just a Request For Testing (and for review, of course). This series grew beyond my initial plans and my current testing capabilities, Linux and Win7 are apparently still fine, but that's all I can say so far. To summarize contributions t

[Qemu-devel] [RFT][PATCH 05/15] hpet: Convert to qdev

2010-05-24 Thread Jan Kiszka
From: Jan Kiszka Register the HPET as a sysbus device and create it that way. As it can route its IRQs to any ISA IRQ, we need to connect it to all 24 of them. Once converted to qdev, we can move reset handler and vmstate registration into its hands as well. Signed-off-by: Jan Kiszka --- hw/hp

[Qemu-devel] Re: [PATCH 0/6] Make hpet a compile time option

2010-05-24 Thread Jan Kiszka
Juan Quintela wrote: >>> We already have to disable hpet for 5.4 (1 year ago). It was done with >>> a local hack because it was supposed that for next big release it would >>> have been fixed. >> But this remains a RHEL issue. Redhat decided to compile out features >> that are unsupported, others

[Qemu-devel] [RFT][PATCH 04/15] hpet: Move static timer field initialization

2010-05-24 Thread Jan Kiszka
From: Jan Kiszka Properly initialize HPETTimer::tn and HPETTimer::state once during hpet_init instead of (re-)writing them on every reset. Signed-off-by: Jan Kiszka --- hw/hpet.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/hpet.c b/hw/hpet.c index bcb160b..fd

[Qemu-devel] [RFT][PATCH 01/15] hpet: Catch out-of-bounds timer access

2010-05-24 Thread Jan Kiszka
From: Jan Kiszka Also prevent out-of-bounds write access to the timers but don't spam the host console if it triggers. Signed-off-by: Jan Kiszka --- hw/hpet.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/hw/hpet.c b/hw/hpet.c index 8729fb2..1980906 100644 --- a

Re: [Qemu-devel] [PATCH -V3 5/7] virtio-9p: Implemented security model for symlink and link.

2010-05-24 Thread Anthony Liguori
On 05/21/2010 04:26 PM, Venkateswararao Jujjuri (JV) wrote: Signed-off-by: Venkateswararao Jujjuri --- hw/file-op-9p.h |4 +- hw/virtio-9p-local.c | 87 +++-- hw/virtio-9p.c | 24 ++ 3 files changed, 88 insertions(+),

Re: [Qemu-devel] [PATCH -V3 1/7] virtio-9p: Introduces an option to specify the security model.

2010-05-24 Thread Anthony Liguori
On 05/21/2010 04:26 PM, Venkateswararao Jujjuri (JV) wrote: The new option is: -fsdev fstype,id=myid,path=/share_path/,security_model=[mapped|passthrough] -virtfs fstype,path=/share_path/,security_model=[mapped|passthrough],mnt_tag=tag In the case of mapped security model, files are created wit

Re: [Qemu-devel] Re: [RFC PATCH] AMD IOMMU emulation

2010-05-24 Thread Blue Swirl
On Mon, May 24, 2010 at 3:40 PM, Joerg Roedel wrote: > Hi Eduard, > > On Thu, May 20, 2010 at 04:50:07PM +0300, Eduard - Gabriel Munteanu wrote: >> +  --enable-amd-iommu-emul) amd_iommu="yes" >> +  ;; > > A compile-time option is a good idea. > >> +/* MMIO registers */ >> +#define MMIO_DEVICE_TABL

[Qemu-devel] Windows guest debugging on KVM/Qemu

2010-05-24 Thread Neo Jia
hi, I am using KVM/Qemu to debug my Windows guest according to KVM wiki page (http://www.linux-kvm.org/page/WindowsGuestDrivers/GuestDebugging). It works for me and also I can only use one Windows guest and bind its serial port to a TCP port and run "Virtual Serial Ports Emulator" on my Windows de

[Qemu-devel] Re: [PATCH, RFC 4/4] Compile mc146818 only once

2010-05-24 Thread Blue Swirl
On Mon, May 24, 2010 at 3:31 PM, Jan Kiszka wrote: > Blue Swirl wrote: >> 8 compilations less for the full build. >> >> Signed-off-by: Blue Swirl > > ... > >> diff --git a/default-configs/sparc64-softmmu.mak >> b/default-configs/sparc64-softmmu.mak >> index 1cc3f13..6ab0cf4 100644 >> --- a/defaul

[Qemu-devel] [Bug 585113] Re: e1000 irq problems after live migration with qemu-kvm 0.12.4

2010-05-24 Thread Peter Lieven
I did 2 additional tests 1) Stop VM, Live Migrate, Continue -> Triggers BUG 2) Stop VM, Continue -> Does NOT trigger BUG. My guess it seems that pending interrupts are incorrectly transferred with kernel irqchip. As said earlier userspace irqchip does not trigger the bug. -- e1000 irq problems

Re: [Qemu-devel] [PATCH, RFC 2/4] Convert PCI devices to use pci_register_memory()

2010-05-24 Thread Anthony Liguori
On 05/23/2010 03:34 PM, Blue Swirl wrote: Signed-off-by: Blue Swirl --- hw/cirrus_vga.c | 12 ++-- hw/e1000.c|2 +- hw/eepro100.c |2 +- hw/isa.h |1 + hw/isa_mmio.c | 18 -- hw/lsi53c895a.c |4 ++-- hw/macio.c

[Qemu-devel] Re: [PATCH, RFC 1/4] mc146818: move hpet handling to pc.c

2010-05-24 Thread Blue Swirl
On Mon, May 24, 2010 at 3:30 PM, Jan Kiszka wrote: > Blue Swirl wrote: >> On Sun, May 23, 2010 at 3:40 PM, Jan Kiszka wrote: >>> Blue Swirl wrote: Move hpet_in_legacy_mode check from mc146818.c to pc.c. Remove the optimization where the periodic timer is disabled if hpet is in lega

[Qemu-devel] [Bug 585113] [NEW] e1000 irq problems after live migration with qemu-kvm 0.12.4

2010-05-24 Thread Peter Lieven
Public bug reported: sorry for resubmitting. i accidently moved this bug to qemu-kvm at launchpad where it is stuck... After live migrating ubuntu 9.10 server (2.6.31-14-server) and suse linux 10.1 (2.6.16.13-4-smp) it happens sometimes that the guest runs into irq problems. i mention these 2 g

[Qemu-devel] [Bug 584510] Re: e1000 irq problems after live migration with qemu-kvm 0.12.4

2010-05-24 Thread Peter Lieven
I did 2 additional tests 1) Stop VM, Live Migrate, Continue -> Triggers BUG 2) Stop VM, Continue -> Does NOT trigger BUG. My guess it seems that pending interrupts are incorrectly transferred with kernel irqchip. As said earlier userspace irqchip does not trigger the bug. ** Project changed: qe

Re: [Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes

2010-05-24 Thread Luiz Capitulino
On Mon, 24 May 2010 14:29:58 -0500 Anthony Liguori wrote: > On 05/20/2010 02:22 PM, Luiz Capitulino wrote: > > On Thu, 20 May 2010 13:52:08 -0500 > > Anthony Liguori wrote: > > > > > >> On 05/20/2010 01:47 PM, Luiz Capitulino wrote: > >> > >>> On Thu, 20 May 2010 11:55:00 -0500 > >>> A

Re: [Qemu-devel] [RFC PATCH 1/1] ceph/rbd block driver for qemu-kvm

2010-05-24 Thread Anthony Liguori
On 05/24/2010 02:07 PM, Christian Brunner wrote: 2010/5/24 MORITA Kazutaka: However, I don't think nbd would be a good protocol. My preference would be for a plugin API, or for a new local protocol that uses splice() to avoid copies. Both would be okay for Sheepdog. I want to ta

Re: [Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes

2010-05-24 Thread Anthony Liguori
On 05/20/2010 02:22 PM, Luiz Capitulino wrote: On Thu, 20 May 2010 13:52:08 -0500 Anthony Liguori wrote: On 05/20/2010 01:47 PM, Luiz Capitulino wrote: On Thu, 20 May 2010 11:55:00 -0500 Anthony Liguori wrote: On 05/20/2010 11:27 AM, Luiz Capitulino wrote: O

Re: [Qemu-devel] [RFC PATCH 1/1] ceph/rbd block driver for qemu-kvm

2010-05-24 Thread Anthony Liguori
On 05/24/2010 06:03 AM, Avi Kivity wrote: On 05/24/2010 11:27 AM, Stefan Hajnoczi wrote: On Sun, May 23, 2010 at 1:01 PM, Avi Kivity wrote: On 05/21/2010 12:29 AM, Anthony Liguori wrote: I'd be more interested in enabling people to build these types of storage systems without touching qemu.

Re: [Qemu-devel] [RFC PATCH 1/1] ceph/rbd block driver for qemu-kvm

2010-05-24 Thread Anthony Liguori
On 05/24/2010 06:56 AM, Avi Kivity wrote: On 05/24/2010 02:42 PM, MORITA Kazutaka wrote: The server would be local and talk over a unix domain socket, perhaps anonymous. nbd has other issues though, such as requiring a copy and no support for metadata operations such as snapshot and file si

Re: [Qemu-devel] [RFC PATCH 1/1] ceph/rbd block driver for qemu-kvm

2010-05-24 Thread Christian Brunner
2010/5/24 MORITA Kazutaka : >> However, I don't think nbd would be a good protocol.  My preference >> would be for a plugin API, or for a new local protocol that uses >> splice() to avoid copies. >> > > Both would be okay for Sheepdog.  I want to take a suitable approach > for qemu. I think both

[Qemu-devel] Windows guest debugging on KVM/Qemu

2010-05-24 Thread Neo Jia
hi, I am using KVM/Qemu to debug my Windows guest according to KVM wiki page (http://www.linux-kvm.org/page/WindowsGuestDrivers/GuestDebugging). It works for me and also I can only use one Windows guest and bind its serial port to a TCP port and run "Virtual Serial Ports Emulator" on my Windows de

[Qemu-devel] Re: [PATCH 0/6] Make hpet a compile time option

2010-05-24 Thread Jan Kiszka
Juan Quintela wrote: > Paul Brook wrote: >>> On 05/24/2010 11:32 AM, Paul Brook wrote: > Notice that this patch was sent against hpet as one example, if we agree > that this "way" of disabling devices is ok, we could disable more > devices/have more flexibility. Notice that in general

[Qemu-devel] Re: [PATCH 0/6] Make hpet a compile time option

2010-05-24 Thread Jan Kiszka
Anthony Liguori wrote: > On 05/24/2010 12:54 PM, Juan Quintela wrote: >> Paul Brook wrote: >> On 05/24/2010 11:32 AM, Paul Brook wrote: >> Notice that this patch was sent against hpet as one example, if we >> agree >> that this "way" of disabling devices is ok, we c

[Qemu-devel] Re: [PATCH 0/6] Make hpet a compile time option

2010-05-24 Thread Juan Quintela
Jan Kiszka wrote: >> This happens to us all the time for lots of devices. And the big >> problem is that there is no sane way to disable them :( >> >> If we can agree in a mechanism to disable them (like this one) or >> something similar, we could remove it. >> >> Our biggest problem with ship

[Qemu-devel] Re: [PATCH 0/6] Make hpet a compile time option

2010-05-24 Thread Anthony Liguori
On 05/24/2010 12:54 PM, Juan Quintela wrote: Paul Brook wrote: On 05/24/2010 11:32 AM, Paul Brook wrote: Notice that this patch was sent against hpet as one example, if we agree that this "way" of disabling devices is ok, we could disable more devices/have more flexibility. Notice

[Qemu-devel] Re: [PATCH 0/6] Make hpet a compile time option

2010-05-24 Thread Juan Quintela
Paul Brook wrote: >> On 05/24/2010 11:32 AM, Paul Brook wrote: >> >> Notice that this patch was sent against hpet as one example, if we agree >> >> that this "way" of disabling devices is ok, we could disable more >> >> devices/have more flexibility. Notice that in general, we (RHEL/KVM) >> >> ar

Re: [Qemu-devel] Re: [PATCH 0/6] Make hpet a compile time option

2010-05-24 Thread Anthony Liguori
On 05/24/2010 12:11 PM, Paul Brook wrote: I think we're saying the same thing. We already have a mechanism for avoiding things at build time - specifically config-devices.mak. We don't have a nice UI for it, but it's there. At worst your distro specific patch is a 1-line change to default- confi

Re: [Qemu-devel] Re: [PATCH 0/6] Make hpet a compile time option

2010-05-24 Thread Paul Brook
> On 05/24/2010 11:32 AM, Paul Brook wrote: > >> Notice that this patch was sent against hpet as one example, if we agree > >> that this "way" of disabling devices is ok, we could disable more > >> devices/have more flexibility. Notice that in general, we (RHEL/KVM) > >> are interested in a small

Re: [Qemu-devel] Re: [PATCH 0/6] Make hpet a compile time option

2010-05-24 Thread Anthony Liguori
On 05/24/2010 11:32 AM, Paul Brook wrote: Notice that this patch was sent against hpet as one example, if we agree that this "way" of disabling devices is ok, we could disable more devices/have more flexibility. Notice that in general, we (RHEL/KVM) are interested in a small subset of qemu devic

[Qemu-devel] [PATCH 09/10] linux-user: honor low bit of entry PC for MIPS

2010-05-24 Thread Nathan Froyd
Signed-off-by: Nathan Froyd --- linux-user/main.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index 18b52c0..76d443b 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@ -3192,7 +3192,9 @@ int main(int argc, char **argv,

[Qemu-devel] [PATCH 3/3] Samples to add a tracepoint.

2010-05-24 Thread Prerna Saxena
Steps for adding a tracepoint : 1. In trace-entries.h, add a DECLARE_TRACE() in the said format. 2. In trace-entries.c: i) add a DEFINE_TRACE() for the tracepoint in the said format. ii) add an INIT_TRACE(name) for the tracepoint in the function init_tracepoints(void) 3. The call site sh

[Qemu-devel] [PATCH 07/10] target-mips: add microMIPS CPUs

2010-05-24 Thread Nathan Froyd
Signed-off-by: Nathan Froyd --- target-mips/translate_init.c | 61 ++ 1 files changed, 61 insertions(+), 0 deletions(-) diff --git a/target-mips/translate_init.c b/target-mips/translate_init.c index b79ed56..8e17f4b 100644 --- a/target-mips/translate_in

[Qemu-devel] Re: [PATCH 0/6] Make hpet a compile time option

2010-05-24 Thread Jan Kiszka
Juan Quintela wrote: > Jan Kiszka wrote: >> Juan Quintela wrote: > >> Unless this is deadly urgent, please hold it back until we sorted out >> some more fundamental issues with the HPET, specifically ported it to qdev. > > This series are independent of the qdev change (it almost don't change >

[Qemu-devel] Re: [PATCH 0/6] Make hpet a compile time option

2010-05-24 Thread Paul Brook
> Notice that this patch was sent against hpet as one example, if we agree > that this "way" of disabling devices is ok, we could disable more > devices/have more flexibility. Notice that in general, we (RHEL/KVM) > are interested in a small subset of qemu devices. IMO this patch is a backwards s

[Qemu-devel] [PATCH 08/10] target-mips: add microMIPS exception handler support

2010-05-24 Thread Nathan Froyd
Unlike MIPS16, microMIPS lets you choose the ISA mode for your exception handlers. Signed-off-by: Nathan Froyd --- target-mips/helper.c | 21 +++-- 1 files changed, 15 insertions(+), 6 deletions(-) diff --git a/target-mips/helper.c b/target-mips/helper.c index 8102f03..90c3b3a

[Qemu-devel] [PATCH 10/10] hw: honor low bit in mipssim machine

2010-05-24 Thread Nathan Froyd
Signed-off-by: Nathan Froyd --- hw/mips_mipssim.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/hw/mips_mipssim.c b/hw/mips_mipssim.c index a747de5..cd6c2be 100644 --- a/hw/mips_mipssim.c +++ b/hw/mips_mipssim.c @@ -106,7 +106,9 @@ static void main_cpu_reset(void *o

[Qemu-devel] [PATCH 00/10] target-mips: add microMIPS ASE support, v2

2010-05-24 Thread Nathan Froyd
This patch series adds support for the microMIPS ASE. microMIPS is a new ASE similar to MIPS16, but re-encodes the entire instruction set into 16-bit and 32-bit instructions--in contrast to MIPS16, which re-encodes only integer instructions. The mechanisms for going in and out of microMIPS mode a

[Qemu-devel] [PATCH 04/10] target-mips: refactor {c, abs}.cond.fmt insns

2010-05-24 Thread Nathan Froyd
Move all knowledge about coprocessor-checking and register numbering into the gen_cmp* helper functions. Signed-off-by: Nathan Froyd --- target-mips/translate.c | 174 -- 1 files changed, 91 insertions(+), 83 deletions(-) diff --git a/target-mips/tra

[Qemu-devel] [PATCH 05/10] target-mips: small changes to use new FMT_ enums

2010-05-24 Thread Nathan Froyd
Signed-off-by: Nathan Froyd --- target-mips/translate.c | 17 + 1 files changed, 9 insertions(+), 8 deletions(-) diff --git a/target-mips/translate.c b/target-mips/translate.c index 63844b8..cc445fb 100644 --- a/target-mips/translate.c +++ b/target-mips/translate.c @@ -359,7 +

[Qemu-devel] [PATCH 01/10] target-mips: break out [ls][wd]c1 and rdhwr insn generation

2010-05-24 Thread Nathan Froyd
Signed-off-by: Nathan Froyd --- target-mips/translate.c | 106 ++- 1 files changed, 59 insertions(+), 47 deletions(-) diff --git a/target-mips/translate.c b/target-mips/translate.c index c95ecb1..2075d09 100644 --- a/target-mips/translate.c +++ b/tar

[Qemu-devel] [PATCH 03/10] target-mips: add enum constants for various invocations of FOP

2010-05-24 Thread Nathan Froyd
Tweak gen_farith and its caller to use them. Signed-off-by: Nathan Froyd --- target-mips/translate.c | 266 --- 1 files changed, 180 insertions(+), 86 deletions(-) diff --git a/target-mips/translate.c b/target-mips/translate.c index 2075d09..2568e16

[Qemu-devel] [PATCH 02/10] target-mips: add microMIPS-specific bits to mips-defs.h

2010-05-24 Thread Nathan Froyd
There's a new ASE_MICROMIPS instruction flag, and some extra CP0_Config3 fields. The ISA and ISA_ON_EXC fields are specific to microMIPS. The DSP2P is for version 2 of the DSP ASE. Signed-off-by: Nathan Froyd --- target-mips/cpu.h |3 +++ target-mips/mips-defs.h |1 + 2 files cha

[Qemu-devel] [PATCH 2/3] Tracepoint, buffer & monitor framework

2010-05-24 Thread Prerna Saxena
Patch that implements tracepoint framework + trace buffer + monitor support. tracing can be enabled at compile time using --enable-trace switch, which compiles tracing support(all of these). Monitor commands introduced : 1. info trace : to see contents of trace buffer. 2. info tracepoints : to

[Qemu-devel] [PATCH 1/3]make tdb_hash available

2010-05-24 Thread Prerna Saxena
This function is used for hash table lookups by tracepoint framework. The patch adds trivial changes to reuse it. Regards, -- Prerna Saxena Linux Technology Centre, IBM Systems and Technology Lab, Bangalore, India Signed-off by : Prerna (pre...@linux.vnet.ibm.com) Index: qemu/qdict.c ==

  1   2   >