On 05/24/2010 11:32 AM, Paul Brook wrote:
Notice that this patch was sent against hpet as one example, if we agree
that this "way" of disabling devices is ok, we could disable more
devices/have more flexibility. Notice that in general, we (RHEL/KVM)
are interested in a small subset of qemu devices.
IMO this patch is a backwards step. The device models should be cleaned up so
that you don't need to make a compile time decision.
I disagree. I think the device model should be cleaned up so that no
CONFIG_HPET is required in code but I think it's still useful to be able
to exclude device models from the build. That should just be a matter
of not building the object though (that's the point of device_init()).
Regards,
Anthony LIguori
You'll notice that a
fair amount of effort has been put into making the device/system code less
tightly coupled and less machine specific. All inter-device interaction and
links should be explicit. Changing from "PC with HPET" and "PC without HPET"
should not require recompiling anything, and devices shouldn't need to know or
care which they're part of.
Paul
