Re: [Qemu-devel] [PATCH v2] Release usb devices on shutdown and usb_del command

2010-05-20 Thread Gerd Hoffmann
Hi, What about the existing callbacks? Could handle_destroy do? For hot-unplug it should do. --- a/vl.c +++ b/vl.c @@ -3914,6 +3914,7 @@ int main(int argc, char **argv, char **envp) main_loop(); quit_timers(); net_cleanup(); +usb_cleanup(); return 0; } Fig

Re: [Qemu-devel] [PATCH 3/3] Monitor: Drop QMP documentation from code

2010-05-20 Thread Markus Armbruster
Luiz Capitulino writes: > Previous commit added the QMP/qmp-commands.txt file, which is a > copy of this information. This is no longer true. > While it's good to keep it near code, maintaining two copies of > the same information is too hard and has little benefit as we > don't expect client w

Re: [Qemu-devel] [PATCH v2] Release usb devices on shutdown and usb_del command

2010-05-20 Thread Markus Armbruster
"David S. Ahern" writes: > On 05/19/2010 12:10 PM, Shahar Havivi wrote: >> When closig Vm or removing usb on guest via usb_del monitor command, >> qemu does not return the control to the host, the user have to >> unplug and plug the device in order to use it on the host. >> >> v2: >> added empty

Re: [Qemu-devel] [RFC PATCH 1/1] ceph/rbd block driver for qemu-kvm

2010-05-20 Thread MORITA Kazutaka
At Fri, 21 May 2010 06:28:42 +0100, Stefan Hajnoczi wrote: > > On Thu, May 20, 2010 at 11:16 PM, Christian Brunner wrote: > > 2010/5/20 Anthony Liguori : > >> Both sheepdog and ceph ultimately transmit I/O over a socket to a central > >> daemon, right?  So could we not standardize a protocol for

[Qemu-devel] [PATCH] resent: fix CPUID vendor override

2010-05-20 Thread Andre Przywara
the meaning of vendor_override is actually the opposite of how it is currently used :-( Fix it to allow KVM to export the non-native CPUID vendor if explicitly requested by the user. The semantic is now as intended: - With TCG, the guest always sees the configured vendor. - With KVM, the default is

Re: [Qemu-devel] [RFC PATCH 1/1] ceph/rbd block driver for qemu-kvm

2010-05-20 Thread MORITA Kazutaka
At Fri, 21 May 2010 00:16:46 +0200, Christian Brunner wrote: > > 2010/5/20 Anthony Liguori : > >> With new approaches like Sheepdog or Ceph, things are getting a lot > >> cheaper and you can scale your system without disrupting your service. > >> The concepts are quite similar to what Amazon is do

Re: [Qemu-devel] [RFC PATCH 1/1] ceph/rbd block driver for qemu-kvm

2010-05-20 Thread Stefan Hajnoczi
On Thu, May 20, 2010 at 11:16 PM, Christian Brunner wrote: > 2010/5/20 Anthony Liguori : >> Both sheepdog and ceph ultimately transmit I/O over a socket to a central >> daemon, right?  So could we not standardize a protocol for this that both >> sheepdog and ceph could implement? > > There is no c

[Qemu-devel] [Bug 540230] Re: Configuration option error for ARM in default-configs

2010-05-20 Thread cmchao
This problem has been fixed in 23f2166d at Feb 23 ** Changed in: qemu Status: New => Fix Committed -- Configuration option error for ARM in default-configs https://bugs.launchpad.net/bugs/540230 You received this bug notification because you are a member of qemu- devel-ml, which is sub

Re: [Qemu-devel] [RFC PATCH 1/1] ceph/rbd block driver for qemu-kvm

2010-05-20 Thread Yehuda Sadeh Weinraub
On Thu, May 20, 2010 at 1:31 PM, Blue Swirl wrote: > On Wed, May 19, 2010 at 7:22 PM, Christian Brunner wrote: >> The attached patch is a block driver for the distributed file system >> Ceph (http://ceph.newdream.net/). This driver uses librados (which >> is part of the Ceph server) for direct ac

Re: [Qemu-devel] Problems changing dvdrom iso during execution

2010-05-20 Thread David S. Ahern
On 05/20/2010 03:48 PM, Adnan Khaleel wrote: > Thanks for your response. > > > Does it work if the guest uses ide based CD's: > rmmod ide-scsi > modprobe ide-cd > > There isn't an ide-scsi but there is a scsi_mod and when I try to remove > that it gives > ERROR: Module scsi_mod is

Re: [Qemu-devel] [RFC PATCH 1/1] ceph/rbd block driver for qemu-kvm

2010-05-20 Thread Christian Brunner
2010/5/20 Anthony Liguori : >> With new approaches like Sheepdog or Ceph, things are getting a lot >> cheaper and you can scale your system without disrupting your service. >> The concepts are quite similar to what Amazon is doing in their EC2 >> environment, but they certainly won't publish it as

Re: [Qemu-devel] Problems changing dvdrom iso during execution

2010-05-20 Thread Adnan Khaleel
Thanks for your response. Does it work if the guest uses ide based CD's: rmmod ide-scsi modprobe ide-cd There isn't an ide-scsi but there is a scsi_mod and when I try to remove that it gives ERROR: Module scsi_mod is in use by sr_mod,sg,sd_mod,libata modprobe ide-cd seems to work.

Re: [Qemu-devel] [RFC] Bug Day - June 1st, 2010

2010-05-20 Thread Michael Tokarev
20.05.2010 11:15, Andre Przywara wrote: Michael Tokarev wrote: [] It'd be nice if we had more flexibility in defining custom machine types so you could just do qemu -M win98. This is wrong IMHO. win98 and winNT can run on various different machines, including all modern ones (yes I tried the

Re: [Qemu-devel] [RFC PATCH 1/1] ceph/rbd block driver for qemu-kvm

2010-05-20 Thread Anthony Liguori
On 05/20/2010 04:18 PM, Christian Brunner wrote: Thanks for your comments. I'll send an updated patch in a few days. Having a central storage system is quite essential in larger hosting environments, it enables you to move your guest systems from one node to another easily (live-migration or dyn

Re: [Qemu-devel] [RFC PATCH 1/1] ceph/rbd block driver for qemu-kvm

2010-05-20 Thread Christian Brunner
2010/5/20 Blue Swirl : > On Wed, May 19, 2010 at 7:22 PM, Christian Brunner wrote: >> The attached patch is a block driver for the distributed file system >> Ceph (http://ceph.newdream.net/). This driver uses librados (which >> is part of the Ceph server) for direct access to the Ceph object >> st

[Qemu-devel] [PATCH] fix curses update - v2

2010-05-20 Thread Bernhard Kauer
On Mon, May 03, 2010 at 01:06:46PM -0500, Anthony Liguori wrote: > On 04/22/2010 09:08 AM, Bernhard Kauer wrote: > >Hi, > > > >>I believe this issue has come up before with a similar patch but > >well i've submitted such a patch more than two years ago. Unfortunatelly > >it got never applied, so t

Re: [Qemu-devel] Problems changing dvdrom iso during execution

2010-05-20 Thread David S. Ahern
On 05/20/2010 02:29 PM, Adnan Khaleel wrote: > I cannot change DVD roms during execution using the monitor. I can only > mount a cdrom/dvdrom if I specify the iso file in the command line > x86_64-softmmu/qemu-system-x86_64 -hda ../../OSImages/sles11.qcow2 > -cdrom ../../ISOz/mydvd.iso -m 2048 >

[Qemu-devel] Re: [PATCH] pc: fix segfault introduced by 3d53f5c36ff6

2010-05-20 Thread Blue Swirl
Good catch. Thanks, applied. On Thu, May 20, 2010 at 6:14 AM, Eduard - Gabriel Munteanu wrote: > Commit 3d53f5c36ff6 introduced a segfault by erroneously making fw_cfg a > 'void **' and passing it around in different ways. > > Signed-off-by: Eduard - Gabriel Munteanu > --- >  hw/pc.c |    4 ++-

Re: [Qemu-devel] [RFC PATCH 1/1] ceph/rbd block driver for qemu-kvm

2010-05-20 Thread Blue Swirl
On Wed, May 19, 2010 at 7:22 PM, Christian Brunner wrote: > The attached patch is a block driver for the distributed file system > Ceph (http://ceph.newdream.net/). This driver uses librados (which > is part of the Ceph server) for direct access to the Ceph object > store and is running entirely i

[Qemu-devel] Problems changing dvdrom iso during execution

2010-05-20 Thread Adnan Khaleel
I cannot change DVD roms during execution using the monitor. I can only mount a cdrom/dvdrom if I specify the iso file in the command line x86_64-softmmu/qemu-system-x86_64 -hda ../../OSImages/sles11.qcow2 -cdrom ../../ISOz/mydvd.iso -m 2048 In the guest I can mount the iso image as you could n

[Qemu-devel] [[RfC PATCH]] linux fbdev display driver prototype.

2010-05-20 Thread Gerd Hoffmann
Display works with 32 bpp (both host + guest) only. Which surprisingly didn't cause much problems so far in my testing. Host runs with kms and inteldrmfb. Mouse support isn't available yet. I've cheated by passed through the hosts usb mouse for testing. Keyboard works. Guest screen has whatever

[Qemu-devel] Re: phys_page_find bug?

2010-05-20 Thread Artyom Tarasenko
2010/5/7 Artyom Tarasenko : > phys_page_find (exec.c) returns sometimes a page for addresses where > nothing is connected. > > One example, done with qemu-system-sparc -M SS-20 > > ok f130 2f spacec@ . > > // The address translates correctly, in cpu_physical_memory_rw > // addr== 0xff130 (w

[Qemu-devel] Re: [PATCH 3/3] target-sparc: Inline some generation of carry for ADDX/SUBX.

2010-05-20 Thread Blue Swirl
Thanks, applied. On Wed, May 12, 2010 at 6:04 PM, Richard Henderson wrote: > Computing carry is trivial for some inputs.  By avoiding an > external function call, we generate near-optimal code for > the common cases of add+addx (double-word arithmetic) and > cmp+addx (a setcc pattern). > > Signed

Re: [Qemu-devel] [PATCH 0/6]: QMP: Fix issues in parser/lexer

2010-05-20 Thread Avi Kivity
On 05/20/2010 12:43 AM, Anthony Liguori wrote: The JSON specification explicitly says: "A JSON parser transforms a JSON text into another representation. A JSON parser MUST accept all texts that conform to the JSON grammar. A JSON parser MAY accept non-JSON forms or extensions." IOW, we're

[Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes

2010-05-20 Thread Luiz Capitulino
On Thu, 20 May 2010 13:52:08 -0500 Anthony Liguori wrote: > On 05/20/2010 01:47 PM, Luiz Capitulino wrote: > > On Thu, 20 May 2010 11:55:00 -0500 > > Anthony Liguori wrote: > > > > > >> On 05/20/2010 11:27 AM, Luiz Capitulino wrote: > >> > >>> On Thu, 20 May 2010 10:50:41 -0500 > >>> A

Re: [Qemu-devel] [PATCH] QEMU: change default disk cache behavior

2010-05-20 Thread Anthony Liguori
On 05/20/2010 08:49 AM, Jes Sorensen wrote: On 05/20/10 15:40, Anthony Liguori wrote: On 05/20/2010 08:36 AM, Jes Sorensen wrote: And I strongly suspect that such a blanket change would be wrong but that a more targeted change like making cache=none default for physical devices would

Re: [Qemu-devel] Re: [PATCH] QEMU: Change default disk caching to nocache

2010-05-20 Thread Anthony Liguori
On 05/20/2010 10:24 AM, Paolo Bonzini wrote: On 05/20/2010 11:32 AM, jes.soren...@redhat.com wrote: +if (bdrv_flags & BDRV_O_NOCACHE) { +fprintf(stderr, "qemu: failed to open disk image %s as " +"nocache (O_DIRECT) retrying as write-back\n", file); +

Re: [Qemu-devel] [Bug 391879] Re: migrate exec ignores exit status

2010-05-20 Thread Anthony Liguori
On 05/20/2010 12:11 PM, Daniel P. Berrange wrote: On Thu, May 20, 2010 at 04:50:59PM -, Dave Walker wrote: This is a bug and has been reported upstream, it is unlikely to be fixed at the distribution level and therefore anyone interested in working on this bug should contribute a patch t

[Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes

2010-05-20 Thread Anthony Liguori
On 05/20/2010 01:47 PM, Luiz Capitulino wrote: On Thu, 20 May 2010 11:55:00 -0500 Anthony Liguori wrote: On 05/20/2010 11:27 AM, Luiz Capitulino wrote: On Thu, 20 May 2010 10:50:41 -0500 Anthony Liguori wrote: On 05/20/2010 10:16 AM, Paolo Bonzini wrote: On

Re: [Qemu-devel] [PATCH 04/22] tcg-i386: Tidy ext8s and ext16s operations.

2010-05-20 Thread Aurelien Jarno
On Tue, Apr 13, 2010 at 04:13:49PM -0700, Richard Henderson wrote: > Define OPC_MOVSBL and OPC_MOVSWL. Factor opcode emission to > separate functions. Don't restrict the input register to the > low 4 "q" registers; emit shifts instead if needed. > Given this patch is of the same type as the prev

Re: [Qemu-devel] [PATCH 03/22] tcg-i386: Tidy ext8u and ext16u operations.

2010-05-20 Thread Aurelien Jarno
On Thu, May 20, 2010 at 07:40:59AM -0700, Richard Henderson wrote: > On 05/20/2010 07:04 AM, Aurelien Jarno wrote: > >> Do you have tried to compare the generated code before and after your > >> patch? I expect a few cases where your patch has some drawbacks, so I > >> don't know if there is a net

[Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes

2010-05-20 Thread Luiz Capitulino
On Thu, 20 May 2010 11:55:00 -0500 Anthony Liguori wrote: > On 05/20/2010 11:27 AM, Luiz Capitulino wrote: > > On Thu, 20 May 2010 10:50:41 -0500 > > Anthony Liguori wrote: > > > > > >> On 05/20/2010 10:16 AM, Paolo Bonzini wrote: > >> > >>> On 05/20/2010 03:44 PM, Luiz Capitulino wrot

[Qemu-devel] [Bug 583462] Re: qemu disables screensaver

2010-05-20 Thread Jaap Versteegh
** Attachment added: "Code used to check idle time." http://launchpadlibrarian.net/48825708/idletime -- qemu disables screensaver https://bugs.launchpad.net/bugs/583462 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. Status in QEMU:

[Qemu-devel] [Bug 583462] [NEW] qemu disables screensaver

2010-05-20 Thread Jaap Versteegh
Public bug reported: lucid, with compiz and fglrx: Screensaver on host will not kick in when qemu is running (kvm or no kvm). It seems to be related to the fact that the idle time reported by libXss.so on the host is being reset every four seconds or so when qemu is running, eventhough there is n

[Qemu-devel] [Bug 241119] Re: usb_add of a Creative ZEN unrecognized in guest

2010-05-20 Thread Dave Walker
** Also affects: qemu Importance: Undecided Status: New -- usb_add of a Creative ZEN unrecognized in guest https://bugs.launchpad.net/bugs/241119 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. Status in QEMU: New Status in “q

[Qemu-devel] Re: [PATCH 0/6]: QMP: Fix issues in parser/lexer

2010-05-20 Thread Luiz Capitulino
On Thu, 20 May 2010 10:52:58 -0500 Anthony Liguori wrote: > On 05/20/2010 10:18 AM, Paolo Bonzini wrote: > > On 05/19/2010 11:43 PM, Anthony Liguori wrote: > >> > >>> 4. Lexer expects a 'terminal' char to process a token > >>> > >>> Which means clients must send a sort of end of line char, so

[Qemu-devel] Re: [PATCH 1/2] arm_timer: reload timer when enabled

2010-05-20 Thread Rabin Vincent
On Sun, May 02, 2010 at 03:20:51PM +0530, Rabin Vincent wrote: > Reload the timer when TimerControl is written, if the timer is to be > enabled. Otherwise, if an earlier write to TimerLoad was done while > periodic mode was not set, s->delta may incorrectly still have the value > of the maximum li

Re: [Qemu-devel] [Bug 391879] Re: migrate exec ignores exit status

2010-05-20 Thread Dustin Kirkland
On Thu, May 20, 2010 at 12:11 PM, Daniel P. Berrange wrote: > This bug appears to be filed against the Ubuntu qemu component, > rather than the upstream qemu component. Are we supposed to be > getting notifications for all Ubuntu distro qemu bugs too, rather > than just usptream bug reports ? Thi

Re: [Qemu-devel] [Bug 391879] Re: migrate exec ignores exit status

2010-05-20 Thread Daniel P. Berrange
On Thu, May 20, 2010 at 04:50:59PM -, Dave Walker wrote: > This is a bug and has been reported upstream, it is unlikely to be fixed > at the distribution level and therefore anyone interested in working on > this bug should contribute a patch to the upstream project. This will > then filter do

[Qemu-devel] [Bug 391879] Re: migrate exec ignores exit status

2010-05-20 Thread Dave Walker
This is a bug and has been reported upstream, it is unlikely to be fixed at the distribution level and therefore anyone interested in working on this bug should contribute a patch to the upstream project. This will then filter down to Ubuntu when it is merged mainline. Marking "Won't Fix" against

[Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes

2010-05-20 Thread Anthony Liguori
On 05/20/2010 11:27 AM, Luiz Capitulino wrote: On Thu, 20 May 2010 10:50:41 -0500 Anthony Liguori wrote: On 05/20/2010 10:16 AM, Paolo Bonzini wrote: On 05/20/2010 03:44 PM, Luiz Capitulino wrote: I think there's another issue in the handling of strings. The spec say

[Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes

2010-05-20 Thread Luiz Capitulino
On Thu, 20 May 2010 10:54:42 -0500 Anthony Liguori wrote: > On 05/20/2010 10:35 AM, Luiz Capitulino wrote: > >> I meant that we're just accepting some invalid JSON and that's not a big > >> deal. > >> > > It can become a big deal if clients rely on it and for some reason we > > decide we

Re: [Qemu-devel] [PATCH 04/10] target-mips: refactor {c, abs}.cond.fmt insns

2010-05-20 Thread Nathan Froyd
On Thu, May 20, 2010 at 08:34:16AM -0700, Richard Henderson wrote: > On 05/20/2010 07:52 AM, Nathan Froyd wrote: > > +/* Tests */ > > +#define OP_COND(name, cond) \ > > +#define OP_CONDI(name, cond) > > \ > > +

[Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes

2010-05-20 Thread Luiz Capitulino
On Thu, 20 May 2010 10:50:41 -0500 Anthony Liguori wrote: > On 05/20/2010 10:16 AM, Paolo Bonzini wrote: > > On 05/20/2010 03:44 PM, Luiz Capitulino wrote: > >> I think there's another issue in the handling of strings. > >> > >> The spec says that valid unescaped chars are in the following ra

[Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes

2010-05-20 Thread Anthony Liguori
On 05/20/2010 10:35 AM, Luiz Capitulino wrote: I meant that we're just accepting some invalid JSON and that's not a big deal. It can become a big deal if clients rely on it and for some reason we decide we should drop it. Ie. after QMP is declared stable such changes won't be allowed.

[Qemu-devel] Re: [PATCH 0/6]: QMP: Fix issues in parser/lexer

2010-05-20 Thread Anthony Liguori
On 05/20/2010 10:18 AM, Paolo Bonzini wrote: On 05/19/2010 11:43 PM, Anthony Liguori wrote: 4. Lexer expects a 'terminal' char to process a token Which means clients must send a sort of end of line char, so that we process their input. Maybe I'm missing something here, but I th

[Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes

2010-05-20 Thread Anthony Liguori
On 05/20/2010 10:16 AM, Paolo Bonzini wrote: On 05/20/2010 03:44 PM, Luiz Capitulino wrote: I think there's another issue in the handling of strings. The spec says that valid unescaped chars are in the following range: unescaped = %x20-21 / %x23-5B / %x5D-10 That's a spec bug IM

Re: [Qemu-devel] [PATCH RFC] virtio: put last seen used index into ring itself

2010-05-20 Thread Avi Kivity
On 05/20/2010 05:34 PM, Rusty Russell wrote: Have just one ring, no indexes. The producer places descriptors into the ring and updates the head, The consumer copies out descriptors to be processed and copies back in completed descriptors. Chaining is always linear. The descriptors contain a

Re: [Qemu-devel] [PATCH 04/10] target-mips: refactor {c, abs}.cond.fmt insns

2010-05-20 Thread Richard Henderson
On 05/20/2010 07:52 AM, Nathan Froyd wrote: > +/* Tests */ > +#define OP_COND(name, cond) \ > +static inline void glue(gen_op_, name) (TCGv ret, TCGv t0, TCGv t1) \ > +{ \ > +int l1 = gen_n

[Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes

2010-05-20 Thread Luiz Capitulino
On Thu, 20 May 2010 17:26:03 +0200 Paolo Bonzini wrote: > On 05/20/2010 05:25 PM, Luiz Capitulino wrote: > > On Thu, 20 May 2010 17:16:01 +0200 > > Paolo Bonzini wrote: > > > >> On 05/20/2010 03:44 PM, Luiz Capitulino wrote: > >>>I think there's another issue in the handling of strings. > >>

[Qemu-devel] Re: [PATCH 0/6]: QMP: Fix issues in parser/lexer

2010-05-20 Thread Luiz Capitulino
On Thu, 20 May 2010 17:18:23 +0200 Paolo Bonzini wrote: > On 05/19/2010 11:43 PM, Anthony Liguori wrote: > > > >> 4. Lexer expects a 'terminal' char to process a token > >> > >> Which means clients must send a sort of end of line char, so that we > >> process their input. > >> > >> Ma

[Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes

2010-05-20 Thread Luiz Capitulino
On Thu, 20 May 2010 17:16:01 +0200 Paolo Bonzini wrote: > On 05/20/2010 03:44 PM, Luiz Capitulino wrote: > > I think there's another issue in the handling of strings. > > > > The spec says that valid unescaped chars are in the following range: > > > > unescaped = %x20-21 / %x23-5B / %x5D

[Qemu-devel] Re: [PATCH 0/6]: QMP: Fix issues in parser/lexer

2010-05-20 Thread Paolo Bonzini
On 05/19/2010 11:43 PM, Anthony Liguori wrote: 4. Lexer expects a 'terminal' char to process a token Which means clients must send a sort of end of line char, so that we process their input. Maybe I'm missing something here, but I thought that the whole point of writing our ow

[Qemu-devel] Re: [PATCH] QEMU: Change default disk caching to nocache

2010-05-20 Thread Paolo Bonzini
On 05/20/2010 11:32 AM, jes.soren...@redhat.com wrote: +if (bdrv_flags & BDRV_O_NOCACHE) { +fprintf(stderr, "qemu: failed to open disk image %s as " +"nocache (O_DIRECT) retrying as write-back\n", file); +bdrv_flags &= BDRV_O_NOCACHE; Missing

[Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes

2010-05-20 Thread Paolo Bonzini
On 05/20/2010 05:25 PM, Luiz Capitulino wrote: On Thu, 20 May 2010 17:16:01 +0200 Paolo Bonzini wrote: On 05/20/2010 03:44 PM, Luiz Capitulino wrote: I think there's another issue in the handling of strings. The spec says that valid unescaped chars are in the following range: un

[Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes

2010-05-20 Thread Paolo Bonzini
On 05/20/2010 03:44 PM, Luiz Capitulino wrote: I think there's another issue in the handling of strings. The spec says that valid unescaped chars are in the following range: unescaped = %x20-21 / %x23-5B / %x5D-10 But we do: [IN_DQ_STRING] = { [1 ... 0xFF] = IN_DQ

[Qemu-devel] [PATCH 03/10] target-mips: add enum constants for various invocations of FOP

2010-05-20 Thread Nathan Froyd
Tweak gen_farith and its caller to use them. Signed-off-by: Nathan Froyd --- target-mips/translate.c | 266 --- 1 files changed, 180 insertions(+), 86 deletions(-) diff --git a/target-mips/translate.c b/target-mips/translate.c index 2075d09..2568e16

[Qemu-devel] [PATCH 08/10] target-mips: add microMIPS exception handler support

2010-05-20 Thread Nathan Froyd
Unlike MIPS16, microMIPS lets you choose the ISA mode for your exception handlers. Signed-off-by: Nathan Froyd --- target-mips/helper.c | 21 +++-- 1 files changed, 15 insertions(+), 6 deletions(-) diff --git a/target-mips/helper.c b/target-mips/helper.c index 8102f03..90c3b3a

[Qemu-devel] [PATCH 04/10] target-mips: refactor {c, abs}.cond.fmt insns

2010-05-20 Thread Nathan Froyd
Move all knowledge about coprocessor-checking and register numbering into the gen_cmp* helper functions. Signed-off-by: Nathan Froyd --- target-mips/translate.c | 232 ++- 1 files changed, 149 insertions(+), 83 deletions(-) diff --git a/target-mips/t

[Qemu-devel] [PATCH 09/10] linux-user: honor low bit of entry PC for MIPS

2010-05-20 Thread Nathan Froyd
Signed-off-by: Nathan Froyd --- linux-user/main.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index 18b52c0..76d443b 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@ -3192,7 +3192,9 @@ int main(int argc, char **argv,

[Qemu-devel] [PATCH 01/10] target-mips: break out [ls][wd]c1 and rdhwr insn generation

2010-05-20 Thread Nathan Froyd
Signed-off-by: Nathan Froyd --- target-mips/translate.c | 106 ++- 1 files changed, 59 insertions(+), 47 deletions(-) diff --git a/target-mips/translate.c b/target-mips/translate.c index c95ecb1..2075d09 100644 --- a/target-mips/translate.c +++ b/tar

[Qemu-devel] [PATCH 05/10] target-mips: small changes to use new FMT_ enums

2010-05-20 Thread Nathan Froyd
Signed-off-by: Nathan Froyd --- target-mips/translate.c | 17 + 1 files changed, 9 insertions(+), 8 deletions(-) diff --git a/target-mips/translate.c b/target-mips/translate.c index 8a7f3e9..c42d8dd 100644 --- a/target-mips/translate.c +++ b/target-mips/translate.c @@ -359,7 +

[Qemu-devel] [PATCH 07/10] target-mips: add microMIPS CPUs

2010-05-20 Thread Nathan Froyd
Signed-off-by: Nathan Froyd --- target-mips/translate_init.c | 61 ++ 1 files changed, 61 insertions(+), 0 deletions(-) diff --git a/target-mips/translate_init.c b/target-mips/translate_init.c index b79ed56..8e17f4b 100644 --- a/target-mips/translate_in

[Qemu-devel] [PATCH 00/10] target-mips: add microMIPS ASE support

2010-05-20 Thread Nathan Froyd
This patch series adds support for the microMIPS ASE. microMIPS is a new ASE similar to MIPS16, but re-encodes the entire instruction set into 16-bit and 32-bit instructions--in contrast to MIPS16, which re-encodes only integer instructions. The mechanisms for going in and out of microMIPS mode a

[Qemu-devel] [PATCH 10/10] hw: honor low bit in mipssim machine

2010-05-20 Thread Nathan Froyd
Signed-off-by: Nathan Froyd --- hw/mips_mipssim.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/hw/mips_mipssim.c b/hw/mips_mipssim.c index a747de5..cd6c2be 100644 --- a/hw/mips_mipssim.c +++ b/hw/mips_mipssim.c @@ -106,7 +106,9 @@ static void main_cpu_reset(void *o

[Qemu-devel] [PATCH 02/10] target-mips: add microMIPS-specific bits to mips-defs.h

2010-05-20 Thread Nathan Froyd
There's a new ASE_MICROMIPS instruction flag, and some extra CP0_Config3 fields. The ISA and ISA_ON_EXC fields are specific to microMIPS. The DSP2P is for version 2 of the DSP ASE. Signed-off-by: Nathan Froyd --- target-mips/cpu.h |3 +++ target-mips/mips-defs.h |1 + 2 files cha

[Qemu-devel] [PATCH 1/2] qcow2: Clear L2 table cache after write error

2010-05-20 Thread Kevin Wolf
If the L2 table was already updated in cache, but writing it to disk has failed, we must not continue using the changed version in the cache to stay consistent with what's on the disk. Signed-off-by: Kevin Wolf --- block/qcow2-cluster.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-)

[Qemu-devel] [PATCH 2/2] qcow2: Fix error handling in l2_allocate

2010-05-20 Thread Kevin Wolf
l2_allocate has some intermediate states in which the image is inconsistent. Change the order to write to the L1 table only after the new L2 table has successfully been initialized. Also reset the L2 cache in failure case, it's very likely wrong. Signed-off-by: Kevin Wolf --- block/qcow2-cluste

Re: [Qemu-devel] [PATCH 03/22] tcg-i386: Tidy ext8u and ext16u operations.

2010-05-20 Thread Richard Henderson
On 05/20/2010 07:04 AM, Aurelien Jarno wrote: >> Do you have tried to compare the generated code before and after your >> patch? I expect a few cases where your patch has some drawbacks, so I >> don't know if there is a net gain on the size of the translated code. >> > > I have done a quick test o

Re: [Qemu-devel] [PATCH RFC] virtio: put last seen used index into ring itself

2010-05-20 Thread Rusty Russell
On Thu, 20 May 2010 04:30:56 pm Avi Kivity wrote: > On 05/20/2010 08:01 AM, Rusty Russell wrote: > > > >> A device with out of order > >> completion (like virtio-blk) will quickly randomize the unused > >> descriptor indexes, so every descriptor fetch will require a bounce. > >> > >> In contrast, i

Re: [Qemu-devel] [PATCH] QEMU: change default disk cache behavior

2010-05-20 Thread Stefan Hajnoczi
On Thu, May 20, 2010 at 2:49 PM, Jes Sorensen wrote: > On 05/20/10 15:40, Anthony Liguori wrote: >> On 05/20/2010 08:36 AM, Jes Sorensen wrote: And I strongly suspect that such a blanket change would be wrong but that a more targeted change like making cache=none default for physical >>>

Re: [Qemu-devel] [PATCH 03/22] tcg-i386: Tidy ext8u and ext16u operations.

2010-05-20 Thread Aurelien Jarno
On Thu, May 20, 2010 at 03:39:08PM +0200, Aurelien Jarno wrote: > On Wed, May 19, 2010 at 11:31:27AM -0700, Richard Henderson wrote: > > On 05/18/2010 11:47 PM, Aurelien Jarno wrote: > > > The reg allocator is able to issue move if needed, so the only > > > improvement this patch is for doing a ext

[Qemu-devel] [RFC PATCH] AMD IOMMU emulation

2010-05-20 Thread Eduard - Gabriel Munteanu
This is preliminary work for AMD IOMMU emulation support. Signed-off-by: Eduard - Gabriel Munteanu --- Makefile.target |2 + configure |9 + hw/amd_iommu.c | 442 +++ hw/pc.c |2 + hw/pc.h |3 + hw/pci_id

Re: [Qemu-devel] [PATCH] QEMU: change default disk cache behavior

2010-05-20 Thread Jes Sorensen
On 05/20/10 15:40, Anthony Liguori wrote: > On 05/20/2010 08:36 AM, Jes Sorensen wrote: >>> And I strongly suspect that such a blanket change would be wrong but >>> that a more targeted change like making cache=none default for physical >>> devices would satisfy mostly everyone. >>> >> Is the

Re: [Qemu-devel] [PATCH 2/6] json-lexer: Handle missing escapes

2010-05-20 Thread Luiz Capitulino
On Wed, 19 May 2010 16:44:47 -0500 Anthony Liguori wrote: > On 05/19/2010 04:15 PM, Luiz Capitulino wrote: > > The JSON escape sequence "\/" and "\\" are valid and should be > > handled. > > > > Signed-off-by: Luiz Capitulino > > > > Good catch. I think there's another issue in the handlin

Re: [Qemu-devel] [PATCH] QEMU: change default disk cache behavior

2010-05-20 Thread Anthony Liguori
On 05/20/2010 08:36 AM, Jes Sorensen wrote: On 05/20/10 14:30, Anthony Liguori wrote: On 05/20/2010 04:32 AM, jes.soren...@redhat.com wrote: Therefore, here is a patch that does two things: - default to "nocache" - in case of failure with nocache, retry with "write-back"

Re: [Qemu-devel] [PATCH] QEMU: change default disk cache behavior

2010-05-20 Thread Jes Sorensen
On 05/20/10 14:30, Anthony Liguori wrote: > On 05/20/2010 04:32 AM, jes.soren...@redhat.com wrote: >> Therefore, here is a patch that does two things: >> - default to "nocache" >> - in case of failure with nocache, retry with "write-back" >> > > This sort of change requires performance dat

Re: [Qemu-devel] [PATCH 03/22] tcg-i386: Tidy ext8u and ext16u operations.

2010-05-20 Thread Aurelien Jarno
On Wed, May 19, 2010 at 11:31:27AM -0700, Richard Henderson wrote: > On 05/18/2010 11:47 PM, Aurelien Jarno wrote: > > The reg allocator is able to issue move if needed, so the only > > improvement this patch is for doing a ext8u on both "q" registers. > > > > OTOH the reg allocator knows this sit

Re: [Qemu-devel] [PATCH 0/6]: QMP: Fix issues in parser/lexer

2010-05-20 Thread Luiz Capitulino
On Wed, 19 May 2010 16:43:08 -0500 Anthony Liguori wrote: > On 05/19/2010 04:15 PM, Luiz Capitulino wrote: > > Hi Anthony, > > > > While investigating a QMP bug reported by a user, I've found a few issues > > in our parser/lexer. > > > > The patches in this series fix the problems I was abl

[Qemu-devel] [PATCH] check for active_console before using it

2010-05-20 Thread Gerd Hoffmann
Other vga_hw_* functions do the same. Fixes a segmentation fault. Trigger: boot with -nodefaults, then connect via vnc. Signed-off-by: Gerd Hoffmann --- console.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/console.c b/console.c index 7070b1b..4c42b28 100644 --- a/

Re: [Qemu-devel] [PATCH 0/2] Fix scsi-generic breakage in upstream qemu-kvm.git

2010-05-20 Thread Kevin Wolf
Am 17.05.2010 18:45, schrieb Nicholas A. Bellinger: > From: Nicholas Bellinger > > Greetings, > > Attached are the updated patches following hch's comments to fix scsi-generic > device breakage with find_image_format() and refresh_total_sectors(). > > These are being resent as the last attachme

Re: [Qemu-devel] Re: [PATCH 1/3] cursor: add cursor functions.

2010-05-20 Thread Anthony Liguori
On 05/20/2010 07:49 AM, Gerd Hoffmann wrote: Hi, Well. You can't have both. We can have a efficiently packed format (i.e. two bitmaps). Or we can do it in a way which doesn't need parsing, but that wouldn't be the most compact format ... You're right, so packing or introducing a small conve

Re: [Qemu-devel] [RFC] Bug Day - June 1st, 2010

2010-05-20 Thread Andre Przywara
Michael Tokarev wrote: 20.05.2010 02:30, Anthony Liguori wrote: On 05/19/2010 05:29 PM, Andre Przywara wrote: Michael Tokarev wrote: ... Also, thanks to Andre Przywara, whole winNT thing works but it requires -cpu qemu64,level=1 (or level=2 or =3), -- _not_ with default CPU. This [] It'd be

[Qemu-devel] [PATCH 7/8] vvfat: Fix compilation with DEBUG defined

2010-05-20 Thread Kevin Wolf
From: Riccardo Magliocchetti gcc does not like passing a NULL where an int value is expected: block/vvfat.c: In function ‘checkpoint’: block/vvfat.c:2868: error: passing argument 2 of ‘remove_mapping’ makes integer from pointer without a cast Signed-off-by: Riccardo Magliocchetti Signed-off-

[Qemu-devel] [PATCH 8/8] vvfat: More build fixes with DEBUG

2010-05-20 Thread Kevin Wolf
Casting a pointer to an int doesn't work on 64 bit platforms. Use the %p printf conversion specifier instead. Signed-off-by: Kevin Wolf --- block/vvfat.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/block/vvfat.c b/block/vvfat.c index 13c31fa..6d61c2e 100644 --

[Qemu-devel] [PATCH 6/8] block: Add SG_IO device check in refresh_total_sectors()

2010-05-20 Thread Kevin Wolf
From: Nicholas Bellinger This patch adds a special case check for scsi-generic devices in refresh_total_sectors() to skip the subsequent BlockDriver->bdrv_getlength() that will be returning -ESPIPE from block/raw-posic.c:raw_getlength() for BlockDriverState->sg=1 devices. Signed-off-by: Nicholas

[Qemu-devel] [PATCH 1/8] block: fix aio_flush segfaults for read-only protocols (e.g. curl)

2010-05-20 Thread Kevin Wolf
From: Avi Kivity Not all block format drivers expose an io_flush method (reasonable for read-only protocols), so calling io_flush there will immediately segfault. Fix by checking for the method's existence before calling it. Signed-off-by: Avi Kivity Signed-off-by: Kevin Wolf --- aio.c |

[Qemu-devel] [PATCH 2/8] virtio-blk: Avoid zeroing every request structure

2010-05-20 Thread Kevin Wolf
From: Stefan Hajnoczi The VirtIOBlockRequest structure is about 40 KB in size. This patch avoids zeroing every request by only initializing fields that are read. The other fields are either written to or may not be used at all. Oprofile shows about 10% of CPU samples in memset called by virtio_

[Qemu-devel] [PATCH 5/8] block: Make find_image_format() return 'raw' BlockDriver for SG_IO devices

2010-05-20 Thread Kevin Wolf
From: Nicholas Bellinger This patch adds a special BlockDriverState->sg check in block.c:find_image_format() after bdrv_file_open() -> block/raw-posix.c:hdev_open() has been called to determine if we are dealing with a Linux host scsi-generic device. The patch then returns the BlockDriver * fr

[Qemu-devel] [PATCH 4/8] block: fix sector comparism in multiwrite_req_compare

2010-05-20 Thread Kevin Wolf
From: Christoph Hellwig The difference between the start sectors of two requests can be larger than the size of the "int" type, which can lead to a not correctly sorted multiwrite array and thus spurious I/O errors and filesystem corruption due to incorrect request merges. So instead of doing th

[Qemu-devel] [PATCH 3/8] virtio-blk: fix barrier support

2010-05-20 Thread Kevin Wolf
From: Christoph Hellwig Before issuing the barrier to the block driver we need to flush our oustanding queue of write requests, as the flush is supposed to be issued after them. Signed-off-by: Christoph Hellwig Signed-off-by: Kevin Wolf --- hw/virtio-blk.c | 15 +-- 1 files chan

[Qemu-devel] [PULL 0/8] Block patches

2010-05-20 Thread Kevin Wolf
Hi Anthony, this bunch of patches contains some fixes that I think qualify for stable, especially the first two. Please cherry-pick them into stable-0.12 when you have pulled: 468f932 block: fix sector comparism in multiwrite_req_compare 49eb7b7 virtio-blk: fix barrier support 5fdf2a6 block: fix

[Qemu-devel] Re: vgabios plans ( Re: [PATCH 1/5] Makefile cleanup)

2010-05-20 Thread Anthony Liguori
On 05/20/2010 07:57 AM, Gerd Hoffmann wrote: On 05/07/10 12:09, Gerd Hoffmann wrote: Use a single rule for building bios binaries. Use target specific variables to set compile flags. This makes it more obvious what the differences between the versions are. It also makes it easier to add new bi

[Qemu-devel] vgabios plans ( Re: [PATCH 1/5] Makefile cleanup)

2010-05-20 Thread Gerd Hoffmann
On 05/07/10 12:09, Gerd Hoffmann wrote: Use a single rule for building bios binaries. Use target specific variables to set compile flags. This makes it more obvious what the differences between the versions are. It also makes it easier to add new bios binaries with slightly different settings.

Re: [Qemu-devel] Re: [PATCH 1/3] cursor: add cursor functions.

2010-05-20 Thread Gerd Hoffmann
Hi, Well. You can't have both. We can have a efficiently packed format (i.e. two bitmaps). Or we can do it in a way which doesn't need parsing, but that wouldn't be the most compact format ... You're right, so packing or introducing a small conversion function is not critical. I'd still prefe

[Qemu-devel] [PATCH 1/2] Fix TEXI section mark imbalance in qemu-img-cmd.hx

2010-05-20 Thread Jan Kiszka
From: Jan Kiszka Signed-off-by: Jan Kiszka --- qemu-img-cmds.hx |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu-img-cmds.hx b/qemu-img-cmds.hx index c079019..c4cf3e7 100644 --- a/qemu-img-cmds.hx +++ b/qemu-img-cmds.hx @@ -7,7 +7,7 @@ HXCOMM HXCOMM can be used for

Re: [Qemu-devel] [PATCH] QEMU: change default disk cache behavior

2010-05-20 Thread Anthony Liguori
On 05/20/2010 04:32 AM, jes.soren...@redhat.com wrote: From: Jes Sorensen We seem to get into the discussion of what is the correct default setting disk images in QEMU. The libvirt team is reluctant to change specified for newly created images without the default setting matching it, and everybo

[Qemu-devel] [Bug 583296] Re: I/O errors with qemu-nbd/qcow2

2010-05-20 Thread David Weber
I forgot: this is on Ubuntu 10.04, Qemu 0.12.3. -- I/O errors with qemu-nbd/qcow2 https://bugs.launchpad.net/bugs/583296 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. Status in QEMU: New Bug description: I tried to open a qcow2 file

[Qemu-devel] [Bug 583296] [NEW] I/O errors with qemu-nbd/qcow2

2010-05-20 Thread David Weber
Public bug reported: I tried to open a qcow2 file with qemu-nbd and backup the files in it. After some coping I get lot of I/O errors in dmesg and the system hangs. One time I got even a kernel panic (Of course on a productive Server ;-) ) How to reproduce: 1. Connect nbd to a qcow2 file, a virtu

[Qemu-devel] [Bug 583296] Re: I/O errors with qemu-nbd/qcow2

2010-05-20 Thread David Weber
** Attachment added: "dmesg" http://launchpadlibrarian.net/48810728/kern.log -- I/O errors with qemu-nbd/qcow2 https://bugs.launchpad.net/bugs/583296 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. Status in QEMU: New Bug descripti

  1   2   >