Re: [Qemu-devel] [PATCH 2/2] block: Convert bdrv_first to QTAILQ

On Fri, Apr 9, 2010 at 7:17 PM, Stefan Hajnoczi wrote: > I see three options: > 1. Leave the search. > 2. Modify qemu-queue.h to add a QTAILQ_ON_LIST(elm) macro. > 3. Break the QTAILQ abstraction and test tge_prev directly. I see a nicer option: check device_name[0]. Patch v2 sent. Stefan

[Qemu-devel] [PATCH v2] block: Convert bdrv_first to QTAILQ

Signed-off-by: Stefan Hajnoczi --- block.c | 41 +++-- block_int.h |3 ++- 2 files changed, 21 insertions(+), 23 deletions(-) diff --git a/block.c b/block.c index 61da183..5d087de 100644 --- a/block.c +++ b/block.c @@ -55,7 +55,8 @@ static int bdrv_r

Re:Re: [Qemu-devel] why VNC server running on `::1:5901' ?

Thanks Aurelien,I 'll have a try. 在2010-04-09 23:07:20，"Aurelien Jarno" 写道： >On Fri, Apr 09, 2010 at 09:44:51PM +0800, Hayfeng Lee wrote: >> hi,folks. >> I'm a newbie for qemu.AND now I use the qemu to emulate windows xp ,But >> ,when I type the commandline "qemu -hda hda.img -boot d" >> Error

[Qemu-devel] [PATCH v2 14/18] tcg/arm: bswap arguments in qemu_ld/st if needed

On big endian targets, data arguments of qemu_ld/st ops have to be byte swapped. Two temporary registers are needed for qemu_st to do the bswap. r0 and r1 are used in system mode, do the same in user mode, which implies reworking the constraints. Signed-off-by: Aurelien Jarno --- tcg/arm/tcg-tar

[Qemu-devel] [PATCH v2 15/18] tcg/arm: remove useless register tests in qemu_ld/st

addr_reg, data_reg and data_reg2 can't be register r0 or r1 du to the constraints. Don't check if they equals these registers. Signed-off-by: Aurelien Jarno --- tcg/arm/tcg-target.c | 30 ++ 1 files changed, 10 insertions(+), 20 deletions(-) diff --git a/tcg/arm/tc

[Qemu-devel] [PATCH v2 13/18] tcg/arm: use ext* ops in qemu_ld

Signed-off-by: Aurelien Jarno --- tcg/arm/tcg-target.c | 30 -- 1 files changed, 12 insertions(+), 18 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c index 2b560f6..b6f5803 100644 --- a/tcg/arm/tcg-target.c +++ b/tcg/arm/tcg-target.c @@ -499,6

[Qemu-devel] [PATCH v2 17/18] tcg/arm: optimize register allocation order

The beginning of the register allocation order list on the TCG arm target matches the list of clobbered registers. This means that when an helper is called, there is almost always clobbered registers that have to be spilled. Signed-off-by: Aurelien Jarno --- tcg/arm/tcg-target.c | 10 +

[Qemu-devel] [PATCH v2 18/18] tcg/arm: don't try to load constants using pc

There is statistically almost 0 chances to use this code, so remove it. Signed-off-by: Aurelien Jarno --- tcg/arm/tcg-target.c |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c index 1e2028f..33c780b 100644 --- a/tcg/arm/tc

[Qemu-devel] [PATCH v2 16/18] tcg/arm: fix argument alignment in qemu_st64

64-bit arguments should be aligned on an even register as specified by the "Procedure Call Standard for the ARM Architecture". Signed-off-by: Aurelien Jarno --- tcg/arm/tcg-target.c | 19 ++- 1 files changed, 10 insertions(+), 9 deletions(-) diff --git a/tcg/arm/tcg-target.c b

[Qemu-devel] [PATCH v2 12/18] tcg/arm: remove conditional argument for qemu_ld/st

While it make sense to pass a conditional argument to tcg_out_*() functions as the ARM architecture allows that, it doesn't make sense for qemu_ld/st functions. These functions use comparison instructions and conditional execution already, so it is not possible to use a second level of conditional

[Qemu-devel] [PATCH v2 11/18] tcg/arm: add bswap ops

Add an bswap16 and bswap32 ops, either using the rev and rev16 instructions on ARMv6+ or shifts and logical operations on previous ARM versions. In both cases the result use less instructions than the pure TCG version. These ops are also needed by the qemu_ld/st functions. v1 -> v2: - simplify th

[Qemu-devel] [PATCH v2 10/18] tcg/arm: add ext16u op

Add an ext16u op, either using the uxth instruction on ARMv6+ or two shifts on previous ARM versions. In both cases the result use the same number or less instructions than the pure TCG version. Also move all sign extension code to separate functions, so that they can be reused in other parts of t

[Qemu-devel] [PATCH v2 06/18] tcg/arm: add variables to define the allowed instructions set

Use a set of variables to define the allowed ARM instructions, depending on the __ARM_ARCH_*__ GCC defines. v1 -> v2: - switch from #defines to variables - reorder and factorize definitions - add more architectures Signed-off-by: Aurelien Jarno --- tcg/arm/tcg-target.c | 123 ++

[Qemu-devel] [PATCH v2 09/18] tcg/arm: add rotation ops

Signed-off-by: Aurelien Jarno --- tcg/arm/tcg-target.c | 19 +++ tcg/arm/tcg-target.h |2 +- 2 files changed, 20 insertions(+), 1 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c index 7758601..b9a6abd 100644 --- a/tcg/arm/tcg-target.c +++ b/tcg/arm/tcg

[Qemu-devel] [PATCH v2 08/18] tcg/arm: use the blx instruction when possible

Signed-off-by: Aurelien Jarno --- tcg/arm/tcg-target.c | 16 1 files changed, 12 insertions(+), 4 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c index 8c55325..7758601 100644 --- a/tcg/arm/tcg-target.c +++ b/tcg/arm/tcg-target.c @@ -357,6 +357,11 @@ stat

[Qemu-devel] [PATCH v2 03/18] tcg/arm: remove store signed functions

Store signed functions doesn't make sense, and are not used. Remove them. Signed-off-by: Aurelien Jarno --- tcg/arm/tcg-target.c | 72 +++--- 1 files changed, 10 insertions(+), 62 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c

[Qemu-devel] [PATCH v2 07/18] tcg/arm: sxtb and sxth are available starting with ARMv6

Signed-off-by: Aurelien Jarno --- tcg/arm/tcg-target.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c index 2d834d6..8c55325 100644 --- a/tcg/arm/tcg-target.c +++ b/tcg/arm/tcg-target.c @@ -1478,7 +1478,7 @@ static inline vo

[Qemu-devel] [PATCH v2 02/18] tcg/arm: explicitely list clobbered/reserved regs

Instead of writing very compact code, declare all registers that are clobbered or reserved one by one. This makes the code easier to read. Also declare all the 16 registers to TCG, and mark pc as reserved. Signed-off-by: Aurelien Jarno --- tcg/arm/tcg-target.c | 13 + tcg/arm/tcg-

[Qemu-devel] [PATCH v2 04/18] tcg/arm: replace integer values by registers enum

The TCG ARM backends uses integer values to refer to both immediate values and register number. This makes the code difficult to read. The patch below replaces all (if I haven't miss any ;-) integer values representing register number by TCG_REG_* enum values. Signed-off-by: Aurelien Jarno ---

[Qemu-devel] [PATCH v2 01/18] tcg/arm: remove SAVE_LR code

There is no need to save the LR register (r14) before a call to a subroutine. According to the "Procedure Call Standard for the ARM Architecture", it is the job of the callee to save this register. Moreover, this register is already saved in the prologue/epilogue. This patch removes the disabled S

[Qemu-devel] [PATCH v2 05/18] tcg/arm: align 64-bit arguments in function calls

As specified by the "Procedure Call Standard for the ARM Architecture". Signed-off-by: Aurelien Jarno --- tcg/arm/tcg-target.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/tcg/arm/tcg-target.h b/tcg/arm/tcg-target.h index a0027b5..334edfa 100644 --- a/tcg/arm/tcg-targ

[Qemu-devel] [PATCH v2 0/18] tcg/arm: cleanup and improvements

This patch series clean-up and improves the tcg/arm code. The first patches are just a clean-up and should not change the resulting binaries, while the other ones use new ARM instructions, and fix 64-bit and/or big-endian targets. With this patch series I am able to successfully: - boot debian-i

Re: [Qemu-devel] [PATCH 07/13] target-alpha: Use non-inverted arguments to gen_{f}cmov.

On Tue, Mar 16, 2010 at 02:44:44PM -0700, Richard Henderson wrote: > The inverted conditions as argument to the function looks wrong > at a glance inside translate_one. Since we have an easy function > to produce the inversion now, use it. Thanks, applied. > Signed-off-by: Richard Henderson > -

Re: [Qemu-devel] [PATCH] raw-posix: don't assign bs->read_only

On Wed, Apr 07, 2010 at 01:58:06PM +0200, Christoph Hellwig wrote: > bdrv_open already takes care of this for us. Thanks, applied. > Signed-off-by: Christoph Hellwig > > Index: qemu/block/raw-posix.c > === > --- qemu.orig/block/raw

Re: [Qemu-devel] [PATCH 02/13] target-alpha: Implement cpys{, n, e} inline.

On Fri, Mar 12, 2010 at 11:22:45AM -0800, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target-alpha/helper.h|4 -- > target-alpha/op_helper.c | 18 -- > target-alpha/translate.c | 78 +++-- > 3 files changed, 74 in

Re: [Qemu-devel] [PATCH 0/6] qcow2: More error path fixes

On Tue, Apr 06, 2010 at 03:30:08PM +0200, Kevin Wolf wrote: > This is part three of the qcow2 error path fixes. More to come... > > May depend on any patches sent earlier that are in my queue (I think it does > depend at least on the blkdebug series to apply cleanly) All those patches looks fine

Re: [Qemu-devel] [PATCH 13/13] target-alpha: Implement RPCC.

On Wed, Apr 07, 2010 at 03:42:54PM -0700, Richard Henderson wrote: > A minimal implementation that more or less corresponds to the > user-level version used by target-i386. More hoops will want > to be jumped through when alpha gets system-level emulation. This patch looks ok, but it mixed host a

Re: [Qemu-devel] [PATCH 06/13] target-alpha: Use setcond for int comparisons.

On Tue, Mar 16, 2010 at 01:04:34PM -0700, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target-alpha/translate.c | 43 ++- > 1 files changed, 22 insertions(+), 21 deletions(-) Thanks, applied. > diff --git a/target-alpha/translate.

Re: [Qemu-devel] [PATCH 01/13] target-alpha: Add flags markups to helpers.h.

On Fri, Mar 12, 2010 at 10:31:49AM -0800, Richard Henderson wrote: > Almost all alpha helpers are at least TCG_CALL_CONST > and a fair few are also TCG_CALL_PURE. Thanks, applied. > Signed-off-by: Richard Henderson > --- > target-alpha/helper.h | 184 ---

Re: [Qemu-devel] [PATCH 10/13] target-alpha: Enable NPTL.

On Wed, Mar 24, 2010 at 05:13:07PM -0700, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > configure|1 + > linux-user/syscall.c |2 +- > target-alpha/cpu.h | 28 +--- > 3 files changed, 19 insertions(+), 12 deletions(-) > > diff

Re: [Qemu-devel] [PATCH 0/3] fix network booting when using "-device" instead of "-net nic"

On Tue, Apr 06, 2010 at 07:22:05PM -0300, Eduardo Habkost wrote: > This series fixes the following issue: > > $ qemu-system-x86_64 -device > rtl8139,vlan=0,id=net0,mac=52:54:00:82:41:fd,bus=pci.0,addr=0x4 -net > user,vlan=0,name=hostnet0 -vnc 0.0.0.0:0 -boot n > Cannot boot from non-existent

Re: [Qemu-devel] [PATCH 03/13] target-alpha: Implement rs/rc properly.

On Mon, Mar 15, 2010 at 07:49:42AM -0700, Richard Henderson wrote: > This is a per-cpu flag; there's no need for a spinlock of any kind. > > We were also failing to manipulate the flag with $31 as a target reg > and failing to clear the flag on execution of a return-from-interrupt > instruction. >

Re: [Qemu-devel] [PATCH 6/6] [S390] Add firmware code

On Sat, Apr 10, 2010 at 01:29:55AM +0200, Alexander Graf wrote: > > On 09.04.2010, at 22:17, Aurelien Jarno wrote: > > > On Thu, Apr 01, 2010 at 06:42:41PM +0200, Alexander Graf wrote: > >> This patch adds a firmware blob to the S390 target. The blob is a simple > >> implementation of a virtio cl

[Qemu-devel] Re: [PATCH] pci: fix pci_find_bus().

Oh I sent out the wrong one. This is the correct one. Sorry for noise. >From 370c23c837070f78ca5715f032eacbf6747d42fb Mon Sep 17 00:00:00 2001 Message-Id: <370c23c837070f78ca5715f032eacbf6747d42fb.1270856742.git.yamah...@valinux.co.jp> In-Reply-To: References: From: Isaku Yamahata Date: Fri, 9

Re: [Qemu-devel] [PATCH 6/6] [S390] Add firmware code

On 09.04.2010, at 22:17, Aurelien Jarno wrote: > On Thu, Apr 01, 2010 at 06:42:41PM +0200, Alexander Graf wrote: >> This patch adds a firmware blob to the S390 target. The blob is a simple >> implementation of a virtio client that tries to read the second stage >> bootloader from sectors describe

[Qemu-devel] [PATCH] Remove un-needed code

The set_geometry_hint call below is not needed - it's just setting what was just read. Signed-Off-By: Bruce Rogers rq = NULL; s->sector_mask = (s->conf->logical_block_size / 512) - 1; bdrv_guess_geometry(s->bs, &cylinders, &heads, &secs); -bdrv_set_geometry_hint(s->bs, cylinders, he

Re: [Qemu-devel] [PATCH 0/2] block: Multiwrite error path fixes

On Tue, Apr 06, 2010 at 06:24:05PM +0200, Kevin Wolf wrote: > Kevin Wolf (2): > block: Fix error code in multiwrite for immediate failures > block: Fix multiwrite memory leak in error case > Thanks, both applied. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurel...@aurel3

Re: [Qemu-devel] [PATCH] qemu: address todo comment in exec.c

On Tue, Apr 06, 2010 at 02:18:19PM +0300, Michael S. Tsirkin wrote: > exec.c has a comment 'XXX: optimize' for lduw_phys/stw_phys, > so let's do it, along the lines of stl_phys. > > The reason to address 16 bit accesses specifically is that virtio relies > on these accesses to be done atomically,

Re: [Qemu-devel] [GSoC 2010] Pass-through filesystem support.

On Sat, Apr 10, 2010 at 12:22 AM, Javier Guerra Giraldez wrote: > On Fri, Apr 9, 2010 at 5:17 PM, Mohammed Gamal wrote: >> That's all good and well. The question now is which direction would >> the community prefer to go. Would everyone be just happy with >> virtio-9p passthrough? Would it suppor

Re: [Qemu-devel] [PATCH 0/4] Remove duplicate CPU logging

On Mon, Apr 05, 2010 at 04:03:06PM -0700, Richard Henderson wrote: > Generic code handles -d cpu in cpu_exec, amidst the horde of ifdefs. > These duplicates simply double the amount of output produced with no > extra information emitted. This is only true if cpu-exec.c is compiled with CONFIG_DEBU

Re: [Qemu-devel] [GSoC 2010] Pass-through filesystem support.

On Fri, Apr 9, 2010 at 5:17 PM, Mohammed Gamal wrote: > That's all good and well. The question now is which direction would > the community prefer to go. Would everyone be just happy with > virtio-9p passthrough? Would it support multiple OSs (Windows comes to > mind here)? Or would we eventually

Re: [Qemu-devel] [GSoC 2010] Pass-through filesystem support.

On Fri, Apr 9, 2010 at 11:22 PM, Jamie Lokier wrote: > Mohammed Gamal wrote: >> 2- With respect to CIFS. I wonder how the shares are supposed to be >> exposed to the guest. Should the Samba server be modified to be able >> to use unix domain sockets instead of TCP ports and then QEMU >> communicat

Re: [Qemu-devel] [PATCH] block: Fix multiwrite error handling

On Thu, Apr 01, 2010 at 10:48:44PM +0200, Kevin Wolf wrote: > When two requests of the same multiwrite batch fail, the callback of all > requests in that batch were called twice. This could have any kind of nasty > effects, in my case it lead to use after free and eventually a segfault. > > Signed

Re: [Qemu-devel] [PATCH] target-mips: Fix format specifiers for fpu_fprintf

On Thu, Apr 01, 2010 at 11:05:14PM +0200, Stefan Weil wrote: > In the previous patch which introduced fprintf_function to > allow parameter checking by gcc some compiler warnings > remained unfixed. > > These warnings are fixed here. Thanks applied. > Signed-off-by: Stefan Weil > --- > target-

Re: [Qemu-devel] [PATCHv2] Avoid page_set_flags() assert in qemu-user host page protection code

On Wed, Mar 31, 2010 at 11:00:36PM +0200, Juergen Lock wrote: > V2 that uses endaddr = end-of-guest-address-space if !h2g_valid(endaddr) > after I found out that indeed works; and also disables the FreeBSD 6.x > /compat/linux/proc/self/maps fallback because it can return partial lines > if (at leas

[Qemu-devel] Re: [PATCH] tcp/mips: Change TCG_AREG0 (fp -> s0)

On Fri, Apr 09, 2010 at 05:28:40PM +0200, Stefan Weil wrote: > Register fp (frame pointer) is a bad choice for compilations > without optimisation, because the compiler makes heavy use > of this register (so the resulting code crashes). > > Register s0 had been used for TCG_AREG1 in earlier releas

Re: [Qemu-devel] [PATCH 4/6] Always notify consumers of char devices if they're open

On Thu, Apr 01, 2010 at 06:42:39PM +0200, Alexander Graf wrote: > When using virtio-console on s390, the input doesn't work. > > The root of the problem is rather simple. What happens is the following: > > 1) create character device for stdio > 2) char device is done creating, sends OPENED even

Re: [Qemu-devel] [PATCH] Documentation: Update chapter on installation

On Sun, Mar 28, 2010 at 11:50:19AM +0200, Stefan Weil wrote: > * Replace broken links by link to QEMU wiki. > > * Separate sections for Linux / Windows / Mac OS X > are no longer needed: the wiki link will provide > additional links, so we don't need them here. > > * Add hint for (Open) Solar

Re: [Qemu-devel] [STABLE][PULL 00/10] Patches for 0.12.4

On Fri, Apr 09, 2010 at 11:46:18AM +0200, Kevin Wolf wrote: > Hi Aurelien, > > I went through the patches that were committed recently, either written by me > or concerning block stuff (most of them are both). I came up with this list of > patches that should go into 0.12.4. The first half of them

Re: [Qemu-devel] [PATCH] Remove magic numbers for VNC message IDs from code

On Wed, Mar 31, 2010 at 06:20:43PM +0100, Daniel P. Berrange wrote: > The code processing incoming & sending outgoing messages from/to > clients used embedded magic numbers for all message IDs. This > made the code a little hard to follow. Add constants in the vnc.h > header file for all message ID

Re: [Qemu-devel] why VNC server running on `::1:5901' ?

On Fri, Apr 09, 2010 at 09:44:51PM +0800, Hayfeng Lee wrote: > hi,folks. > I'm a newbie for qemu.AND now I use the qemu to emulate windows xp ,But > ,when I type the commandline "qemu -hda hda.img -boot d" > Error happens. > The scene is : > > omy...@ubuntu:~$ sudo qemu -hda hda.img -boot d > VN

Re: [Qemu-devel] [PATCH] Fix cross compilation

On Sun, Mar 28, 2010 at 11:44:05AM +0200, Stefan Weil wrote: > This patch enhances the algorithm which finds the correct settings for SDL. > For cross compilations (when cross_prefix is set), it looks for sdl-config > with cross prefix. Here is the complete search order: > > ${cross_prefix}sdl_con

Re: [Qemu-devel] [PATCH] lsi: fix segfault in lsi_command_complete

On Mon, Mar 29, 2010 at 03:42:57PM +0200, Gerd Hoffmann wrote: > > Signed-off-by: Gerd Hoffmann Thanks, applied. > --- > hw/lsi53c895a.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/hw/lsi53c895a.c b/hw/lsi53c895a.c > index a332401..525f3ca 100644 > --- a/hw/

Re: [Qemu-devel] [PATCH 5/6] [S390] Implement virtio reset

On Thu, Apr 01, 2010 at 06:42:40PM +0200, Alexander Graf wrote: > The guest may issue a RESET command for virtio. So far we didn't bother > to implement it, but with my new bootloader we actually need it for Linux > to get back to a safe state. Thanks, applied. > Signed-off-by: Alexander Graf >

Re: [Qemu-devel] [PATCH 6/6] [S390] Add firmware code

On Thu, Apr 01, 2010 at 06:42:41PM +0200, Alexander Graf wrote: > This patch adds a firmware blob to the S390 target. The blob is a simple > implementation of a virtio client that tries to read the second stage > bootloader from sectors described as of offset 0x20 in the MBR. > > In combination wi

Re: [Qemu-devel] General information about the QEMU project

On Tue, Apr 06, 2010 at 01:14:17PM +0200, lok...@gmail.com wrote: > Hi > > I am searching for some informations about QEMU. > > 1. > Currently it's possible to compile and run QEMU under Windows. Is there a > fixed support for Windows platforms (as Host)? Or is it possible that newer > releases o

Re: [Qemu-devel] [PATCH v3 0/5] Move stuff out of vl.c

On Thu, Apr 01, 2010 at 07:57:07PM +0200, Paolo Bonzini wrote: > v2->v3 > - re-rebased > - salvage some cleanups made while trying to compile balloon.c once, > but do not do it because it breaks (I have patches to do it also for > vl.o, but they are ugly!) Thanks, all applied. > Paolo Bonzini (5)

Re: [libvirt] [Qemu-devel] Re: Libvirt debug API

On 04/09/2010 03:06 PM, Jamie Lokier wrote: > Daniel P. Berrange wrote: >> I think this alteration of existing args is fr too complex & fragile, >> and way overkill. > > Would it not be simpler, for the target audience, for the config to > contain a one-line shell script to transform particula

Re: [Qemu-devel] [GSoC 2010] Pass-through filesystem support.

Mohammed Gamal wrote: > 2- With respect to CIFS. I wonder how the shares are supposed to be > exposed to the guest. Should the Samba server be modified to be able > to use unix domain sockets instead of TCP ports and then QEMU > communicating on these sockets. With that approach, how should the > g

[Qemu-devel] [PATCH] arm: Fix compiler warning (fprintf format string)

When argument checking is enabled, gcc throws this error: error: format not a string literal and no format arguments The patch rewrites the statement to satisfy the compiler. Signed-off-by: Stefan Weil --- arm-dis.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git

[Qemu-devel] Re: [libvirt] Libvirt debug API

On 04/09/2010 07:41 AM, Chris Lalancette wrote: > Caveats: > 3) Application developers will be strongly discouraged from using > this API because of the above 2 issues. To help in this, the > API's will be in a separate library that developers will explicitly > have to link to, and it will have a

Re: [Qemu-devel] Re: [libvirt] Libvirt debug API

Daniel P. Berrange wrote: > I think this alteration of existing args is fr too complex & fragile, > and way overkill. Would it not be simpler, for the target audience, for the config to contain a one-line shell script to transform particular matched arguments in any way that's wanted? > If th

[Qemu-devel] [PATCH] sparc: Fix compiler warning (fprintf format string)

When argument checking is enabled, gcc throws this error: error: format not a string literal and no format arguments The patch rewrites the statement to satisfy the compiler. Signed-off-by: Stefan Weil --- sparc-dis.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/sp

[Qemu-devel] [PATCH] microblaze: Fix two format specifiers in disassembler

inst is unsigned long, so use %04lx instead of %04x. Signed-off-by: Stefan Weil --- microblaze-dis.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/microblaze-dis.c b/microblaze-dis.c index b26572f..9235fd8 100644 --- a/microblaze-dis.c +++ b/microblaze-dis.c @@ -826

[Qemu-devel] [PATCH] sh4: Fix compiler warning (fprintf format string)

When argument checking is enabled, gcc throws this error: error: format not a string literal and no format arguments The patch rewrites the statement to satisfy the compiler. Signed-off-by: Stefan Weil --- sh4-dis.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sh

[Qemu-devel] [PATCH] m68k: Fix compiler warning (fprintf format string)

When argument checking is enabled, gcc throws this error: error: format not a string literal and no format arguments The patch rewrites the statement to satisfy the compiler. It also removes a type cast which is not needed. Signed-off-by: Stefan Weil --- m68k-dis.c |6 +++--- 1 files chang

Re: [Qemu-devel] [6531] toplevel: remove error handling from qemu_malloc() callers ( Avi Kivity)

Anthony Liguori schrieb: > Revision: 6531 > http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6531 > Author: aliguori > Date: 2009-02-05 22:06:18 + (Thu, 05 Feb 2009) > > Log Message: > --- > toplevel: remove error handling from qemu_malloc() callers (Avi Kivity) > > Signed-off-

[Qemu-devel] Re: [libvirt] Libvirt debug API

On 04/09/2010 10:27 AM, Daniel P. Berrange wrote: > The concept of command line & monitor is something that is QEMU specific > and thus is not suitable for the primary XML schema. IMHO, this needs to be > done as a separate schema, linked in via an XML namespace. For example > > http://libvirt.o

Re: [Qemu-devel] [PATCH 2/2] block: Convert bdrv_first to QTAILQ

On Fri, Apr 9, 2010 at 5:47 PM, Kevin Wolf wrote: >> @@ -545,13 +542,15 @@ void bdrv_close(BlockDriverState *bs) >> >>  void bdrv_delete(BlockDriverState *bs) >>  { >> -    BlockDriverState **pbs; >> +    BlockDriverState *bs1; >> >> -    pbs = &bdrv_first; >> -    while (*pbs != bs && *pbs != NUL

Re: [Qemu-devel] race condition when exec'ing "qemu -incoming" followed by monitor "cont"

On Fri, Apr 09, 2010 at 12:03:54PM -0400, Laine Stump wrote: > (Please forgive (and correct!) any inaccuracies in my description of > qemu's workings - I've only recently started looking at it directly, > rather than through the lens of libvirt) > > libvirt implements a "domain restore" operatio

Re: [Qemu-devel] Weird thing happen when the VM is stop! (0.12.3)

On Sat, Apr 10, 2010 at 01:12:27AM +0900, Jun Koi wrote: > On Fri, Apr 9, 2010 at 10:20 PM, Luiz Capitulino > wrote: > > On Fri, 9 Apr 2010 18:32:21 +0900 > > Jun Koi wrote: > > > >> Hi, > >> > >> I found something very funny happening with 0.12.3: it seems the VM is > >> still running even I al

[Qemu-devel] Re: [PATCH 18/22] net: slirp: replace qemu_format_nic_info_str by qemu_format_nic_info_dict

On Thu, 8 Apr 2010 17:16:35 -0300 Miguel Di Ciurcio Filho wrote: > Signed-off-by: Miguel Di Ciurcio Filho > --- > net/slirp.c |7 +-- > 1 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/net/slirp.c b/net/slirp.c > index b41c60a..4036b92 100644 > --- a/net/slirp.c > +++

[Qemu-devel] Re: [PATCH 05/22] net: eepro100: replace qemu_format_nic_info_str by qemu_format_nic_info_dict

On Thu, 8 Apr 2010 17:16:22 -0300 Miguel Di Ciurcio Filho wrote: > Signed-off-by: Miguel Di Ciurcio Filho > --- > hw/eepro100.c |7 +-- > 1 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/hw/eepro100.c b/hw/eepro100.c > index 7db6fb5..329fe15 100644 > --- a/hw/eepro100

[Qemu-devel] Re: [PATCH 0/22] Convert do_info_network() to QObject/QMP

On Thu, 8 Apr 2010 17:16:17 -0300 Miguel Di Ciurcio Filho wrote: > The VLANClientState structure has the member info_str, a simple string that > is filled with information about NIC devices and used on monitor calls. > > There is no coherent formatting of this string by all the NIC devices, >

[Qemu-devel] Re: [PATCH 02/22] net: replace qemu_nic_format_info_str and VLANClientState->info_str by QDicts

On Thu, 8 Apr 2010 17:16:19 -0300 Miguel Di Ciurcio Filho wrote: > There is no standard format when formatting info_str, so it is difficult > to extract information and transmit it over QMP. > > This patch changes info_str from a simple string to a QDict. > > Patches that convert the devices t

[Qemu-devel] Re: [PATCH 22/22] monitor/net: Convert do_info_network() to QObject/QMP

On Thu, 8 Apr 2010 17:16:39 -0300 Miguel Di Ciurcio Filho wrote: > Each device is represented by a QDict. The returned QObject is a QList > of all devices. > > This commit slightly changes the monitor output when 'info network' is used. > > Signed-off-by: Miguel Di Ciurcio Filho > --- > moni

[Qemu-devel] Re: [PATCH 20/22] net: tap: replace qemu_format_nic_info_str by info_dict

On Thu, 8 Apr 2010 17:16:37 -0300 Miguel Di Ciurcio Filho wrote: > Signed-off-by: Miguel Di Ciurcio Filho > --- > net/tap-win32.c |9 ++--- > net/tap.c | 18 +- > 2 files changed, 19 insertions(+), 8 deletions(-) > > diff --git a/net/tap-win32.c b/net/tap-win32

[Qemu-devel] Re: [PATCH 19/22] net: socket: replace qemu_format_nic_info_str by qemu_format_nic_info_dict

On Thu, 8 Apr 2010 17:16:36 -0300 Miguel Di Ciurcio Filho wrote: > Signed-off-by: Miguel Di Ciurcio Filho > --- > net/socket.c | 47 ++- > 1 files changed, 34 insertions(+), 13 deletions(-) > > diff --git a/net/socket.c b/net/socket.c > index 1c4e

[Qemu-devel] Re: [PATCH 01/22] QObject API: add qdict_to_qstring() function

On Thu, 8 Apr 2010 17:16:18 -0300 Miguel Di Ciurcio Filho wrote: > This is a helper function that converts a QDict to a QString, using the > format: > > key1=value1 SPACE key2=value2 SPACE key3=value3 > > Handy for debugging and other things. > > Signed-off-by: Miguel Di Ciurcio Filho > ---

Re: [Qemu-devel] [GSoC 2010] Pass-through filesystem support.

On Fri, Apr 9, 2010 at 7:11 PM, jvrao wrote: > Luiz Capitulino wrote: >> On Thu, 8 Apr 2010 18:01:01 +0200 >> Mohammed Gamal wrote: >> >>> Hi, >>> Now that Cam is almost done with his ivshmem patches, I was thinking >>> of another idea for GSoC which is improving the pass-though >>> filesystems.

Re: [Qemu-devel] [PATCH 1/2] block: Do not export bdrv_first

Am 09.04.2010 16:22, schrieb Stefan Hajnoczi: > The bdrv_first linked list of BlockDriverStates is currently extern so > that block migration can iterate the list. However, since there is > already a bdrv_iterate() function there is no need to expose bdrv_first. > > Signed-off-by: Stefan Hajnoczi

Re: [Qemu-devel] [GSoC 2010] Pass-through filesystem support.

Luiz Capitulino wrote: > On Thu, 8 Apr 2010 18:01:01 +0200 > Mohammed Gamal wrote: > >> Hi, >> Now that Cam is almost done with his ivshmem patches, I was thinking >> of another idea for GSoC which is improving the pass-though >> filesystems. >> I've got some questions on that: >> >> 1- What does

Re: [Qemu-devel] [PATCH 11/18] tcg/arm: add bswap ops

On Fri, Apr 09, 2010 at 12:32:04AM +0100, Paul Brook wrote: > > +static inline void tcg_out_bswap32(TCGContext *s, int cond, int rd, int rn) > > +#else > > +/* This code only uses one temporary register. There is probably > > + a faster way to do that with more temporary registers. */ >

Re: [Qemu-devel] race condition when exec'ing "qemu -incoming" followed by monitor "cont"

On 04/09/2010 12:03 PM, Laine Stump wrote: (Please forgive (and correct!) any inaccuracies in my description of qemu's workings - I've only recently started looking at it directly, rather than through the lens of libvirt) libvirt implements a "domain restore" operation by: 0) start with a pre

Re: [Qemu-devel] [PATCH 2/2] block: Convert bdrv_first to QTAILQ

Am 09.04.2010 16:22, schrieb Stefan Hajnoczi: > Signed-off-by: Stefan Hajnoczi > --- > block.c | 44 +++- > block_int.h |3 ++- > 2 files changed, 25 insertions(+), 22 deletions(-) > > diff --git a/block.c b/block.c > index 61da183..86d2504 10064

Re: [Qemu-devel] [RFC PATCH 0/7] QEMU patches to generate FDT from qdevs

On Fri, Apr 9, 2010 at 9:57 AM, Paul Brook wrote: >> On Fri, Apr 9, 2010 at 6:07 AM, Paul Brook wrote: >> >> Hi everyone, >> >> >> >> This is an experimental set of patches for populating the flattened >> >> device tree (fdt) data from the actual set of qdevs in the platform. >> >> I'm not expect

[Qemu-devel] Re: race condition when exec'ing "qemu -incoming" followed by monitor "cont"

On 04/09/2010 06:03 PM, Laine Stump wrote: Can someone provide any insight on why it is possible to start the CPUs in the domain before the incoming migration is complete, and what we can do (other than blindly sleeping) to prevent this? I would say it's a bug in QEMU, and it has to be fixed t

[Qemu-devel] Re: [PATCH] microblaze: fix build on Ubuntu Hardy

On 04/09/2010 05:31 PM, Thomas Monjalon wrote: Paolo Bonzini wrote: On 04/09/2010 12:22 AM, Thomas Monjalon wrote: Using GCC-4.2.4-1ubuntu4, there were 3 warnings. The last two are correct, but what was the first error? If it was a shadowed declaration as it seems to be, the solution is to s

[Qemu-devel] [PATCH] microblaze: fix build on Ubuntu Hardy

From: Thomas Monjalon Using GCC-4.2.4-1ubuntu4, there were 3 warnings: microblaze-dis.c:829: warning: format '%04x' expects type 'unsigned int', but argument 4 has type 'long unsigned int' microblaze-dis.c:962: warning: format '%04x' expects type 'unsigned int', but argument 4 h

Re: [Qemu-devel] Weird thing happen when the VM is stop! (0.12.3)

On Fri, Apr 9, 2010 at 10:20 PM, Luiz Capitulino wrote: > On Fri, 9 Apr 2010 18:32:21 +0900 > Jun Koi wrote: > >> Hi, >> >> I found something very funny happening with 0.12.3: it seems the VM is >> still running even I already stopped it. >> >> Here is how I verified that: Boot any OS (I checked

[Qemu-devel] race condition when exec'ing "qemu -incoming" followed by monitor "cont"

(Please forgive (and correct!) any inaccuracies in my description of qemu's workings - I've only recently started looking at it directly, rather than through the lens of libvirt) libvirt implements a "domain restore" operation by: 0) start with a previously saved domain image in a file 1) ope

Re: [Qemu-devel] [RFC PATCH 0/7] QEMU patches to generate FDT from qdevs

> On Fri, Apr 9, 2010 at 6:07 AM, Paul Brook wrote: > >> Hi everyone, > >> > >> This is an experimental set of patches for populating the flattened > >> device tree (fdt) data from the actual set of qdevs in the platform. > >> I'm not expecting this to get merged anytime soon, but I wanted to get

[Qemu-devel] [PATCH 2/2] block: Convert bdrv_first to QTAILQ

Signed-off-by: Stefan Hajnoczi --- block.c | 44 +++- block_int.h |3 ++- 2 files changed, 25 insertions(+), 22 deletions(-) diff --git a/block.c b/block.c index 61da183..86d2504 100644 --- a/block.c +++ b/block.c @@ -55,7 +55,8 @@ static int bdr

[Qemu-devel] [PATCH 1/2] block: Do not export bdrv_first

The bdrv_first linked list of BlockDriverStates is currently extern so that block migration can iterate the list. However, since there is already a bdrv_iterate() function there is no need to expose bdrv_first. Signed-off-by: Stefan Hajnoczi --- block-migration.c | 63

[Qemu-devel] [PATCH 0/2] block: Cleanups

Small cleanups to block.c and friends. These patches apply to qemu.git and kevin's block branch.

[Qemu-devel] Hi...Is there any way to virtualize HP-UX OS in a Host having x86 and Windows OS?

Hi, Is there any way to virtualize HP-UX OS in a Host having x86 and Windows OS? I will be glad to hear about that. Thanks. Best Regards, === Adhir Dutta Engineer (Process Control) PMC-Pulp Mill-2. DoubleA ( www.DoubleApa

[Qemu-devel] Re: [PATCH] microblaze: fix build on Ubuntu Hardy

Paolo Bonzini wrote: > On 04/09/2010 12:22 AM, Thomas Monjalon wrote: > > Using GCC-4.2.4-1ubuntu4, there were 3 warnings. > > The last two are correct, but what was the first error? If it was a > shadowed declaration as it seems to be, the solution is to > s/fprintf/fprintf_func/ throughout print

[Qemu-devel] [PATCH] tcp/mips: Change TCG_AREG0 (fp -> s0)

Register fp (frame pointer) is a bad choice for compilations without optimisation, because the compiler makes heavy use of this register (so the resulting code crashes). Register s0 had been used for TCG_AREG1 in earlier releases, but was no longer used and is now free for TCG_AREG0. The resultin

Re: [Qemu-devel] [RFC PATCH 1/7] devicetree: Add 8k instead of double dtb size when reserving extra memory

On Fri, Apr 9, 2010 at 6:00 AM, Paul Brook wrote: >> If a small 'seed' dtb file is loaded into qemu and then heavily modified >> (say for runtime population of all the device nodes), then 2x the dtb >> size turns out not to be very much. >> >> This patch changes the device tree loading code to add

Re: [Qemu-devel] [RFC PATCH 0/7] QEMU patches to generate FDT from qdevs

On Fri, Apr 9, 2010 at 6:07 AM, Paul Brook wrote: >> Hi everyone, >> >> This is an experimental set of patches for populating the flattened >> device tree (fdt) data from the actual set of qdevs in the platform. >> I'm not expecting this to get merged anytime soon, but I wanted to get >> it out th

  1   2   >