Re: [Qemu-devel] [PATCH] Added 'access' option to -drive flag

2010-01-05 Thread Naphtali Sprei
Jamie Lokier wrote: > Anthony Liguori wrote: >> On 12/24/2009 03:09 AM, Markus Armbruster wrote: >>> Naphtali Sprei writes: >>> Added 'access' option to -drive flag The new option is: access=[rw|ro|auto] rw: open the drive's file with Read and Write permission, don't continue

Re: [Qemu-devel] [PATCH V11 01/27] acpi: split out pc smbus routines from acpi.c into pc_smbus.c

2010-01-05 Thread Aurelien Jarno
Isaku Yamahata a écrit : > On Tue, Jan 05, 2010 at 11:11:00PM +0100, Aurelien Jarno wrote: >> On Tue, Jan 05, 2010 at 03:27:24PM +0900, Isaku Yamahata wrote: >>> Split out pc smbus routines from acpi.c into pc_smbus.c and >>> use it. >> Given the code is not specific to PC, but is also used on MIPS

[Qemu-devel] [PATCH resend] vmware_vga: Check cursor dimensions passed from guest to avoid buffer overflow

2010-01-05 Thread Roland Dreier
Check that the cursor dimensions passed from the guest for the DEFINE_CURSOR command don't overflow the available space in the cursor.image[] or cursor.mask[] arrays before copying data from the guest into those arrays. Signed-off-by: Roland Dreier --- Hi Anthony, as far as I can tell this seems

Re: [Qemu-devel] [PATCH 2/2] tcg-x86_64: Avoid unnecessary REX.B prefixes.

2010-01-05 Thread Richard Henderson
On 01/05/2010 04:31 PM, Richard Henderson wrote: A while ago Laurent pointed out that the setcc opcode emitted by the setcond patch had unnecessary REX prefixes. The existing P_REXB internal opcode flag unconditionally emits the REX prefix. Technically it's not needed if the register in questio

Re: [Qemu-devel] cpuid problem in upstream qemu with kvm

2010-01-05 Thread Avi Kivity
On 01/06/2010 02:10 AM, Anthony Liguori wrote: On 12/23/2009 04:32 AM, Avi Kivity wrote: On 12/22/2009 06:12 PM, Anthony Liguori wrote: I think the only two Fully Correct approachs are to support a very specific CPU (e.g. Xeon-X5270) or provide the ability to individually tweak cpu flags.

[Qemu-devel] [PATCH V12 07/27] pc, i440fx: Make smm enable/disable function i440fx independent.

2010-01-05 Thread Isaku Yamahata
make cpu_smm_update() generic to be independent on i440fx by registering a callback. Signed-off-by: Isaku Yamahata Acked-by: Gerd Hoffmann --- hw/pc.c | 18 +++--- hw/pc.h |8 +++- hw/piix_pci.c |5 - 3 files changed, 26 insertions(+), 5 deletions(-) d

[Qemu-devel] [PATCH V12 04/27] acpi: split acpi.c into the common part and the piix4 part.

2010-01-05 Thread Isaku Yamahata
Split acpi.c into the common part and the piix4 specific part. The common part will be used later. Signed-off-by: Isaku Yamahata Acked-by: Gerd Hoffmann --- Makefile.target |4 +- hw/acpi.c | 557 --- hw/{acpi.c => acpi_

[Qemu-devel] [PATCH V12 03/27] acpi: add acpi constants from linux header files and use them.

2010-01-05 Thread Isaku Yamahata
add acpi constants from linux header files and replace the old constants with them. The acpi constants will be used by other file. Signed-off-by: Isaku Yamahata Acked-by: Gerd Hoffmann --- hw/acpi.c | 56 +++ hw/acpi.h | 78 +++

[Qemu-devel] [PATCH V12 02/27] acpi: split out apm register emulation from acpi.c

2010-01-05 Thread Isaku Yamahata
Split out apm register emulation for acpi.c into apm.c. The apm emulation will be used later. Signed-off-by: Isaku Yamahata Acked-by: Gerd Hoffmann Cc: Aurelien Jarno --- changes v11 -> v12 - drop pc prefix as this is used by not only pc, but also mips. including filenames and symbol names -

[Qemu-devel] [PATCH V12 15/27] pc: split out vga initialization from pc_init1() into pc_vga_init().

2010-01-05 Thread Isaku Yamahata
Split out vga initialization which is independent of piix from pc_init1() as pc_vga_init(). Later it will be used. Signed-off-by: Isaku Yamahata Acked-by: Gerd Hoffmann --- hw/pc.c | 41 +++-- 1 files changed, 23 insertions(+), 18 deletions(-) diff --git a

[Qemu-devel] [PATCH V12 17/27] pc: split out pci device init from pc_init1() into pc_pci_device_init()

2010-01-05 Thread Isaku Yamahata
Split out pci device initialization from pc_init1() into pc_pci_device_init(). and removed unnecessary braces. Signed-off-by: Isaku Yamahata Acked-by: Gerd Hoffmann --- hw/pc.c | 35 +++ 1 files changed, 19 insertions(+), 16 deletions(-) diff --git a/hw/pc.c b

Re: [Qemu-devel] Planning for 0.13

2010-01-05 Thread Roy Tam
2010/1/5 Anthony Liguori : > Hi, > > I hope everyone had a happy new year! Now that we've finished the 0.12 > release and most of us have had a nice break, I think it's time to start > planning for the next release. > > 0.12 felt a bit rushed to me. I'd like to take a bit more time with 0.13 > an

[Qemu-devel] [PATCH V12 06/27] pc: initialize ioapic before use.

2010-01-05 Thread Isaku Yamahata
The changeset of 2c8d9340203c7f19265fd4cb2341f568217a3af6 prevents isa_irq_handler() from NULL refering of IsaIrqState::ioapic. However it would be better to initialize the member before reference. Signed-off-by: Isaku Yamahata Acked-by: Gerd Hoffmann --- hw/pc.c |6 +++--- 1 files changed,

[Qemu-devel] [PATCH V12 13/27] pc: split out cpu initialization from pc_init1() into pc_cpus_init().

2010-01-05 Thread Isaku Yamahata
split out cpu initialization which is piix independent from pc_init1() into pc_cpus_init(). Later it will be used. Signed-off-by: Isaku Yamahata Acked-by: Gerd Hoffmann --- hw/pc.c | 32 +++- 1 files changed, 19 insertions(+), 13 deletions(-) diff --git a/hw/pc.c

[Qemu-devel] [PATCH V12 19/27] pc: move rtc declarations from pc.h into a dedicated header file.

2010-01-05 Thread Isaku Yamahata
Move rtc_xxx declarations from pc.h into mc146818rtc.h. Signed-off-by: Isaku Yamahata Acked-by: Gerd Hoffmann --- hw/mc146818rtc.h | 10 ++ hw/pc.h | 10 ++ 2 files changed, 12 insertions(+), 8 deletions(-) create mode 100644 hw/mc146818rtc.h diff --git a/hw/mc146

[Qemu-devel] [PATCH V12 20/27] rtc: make rtc_xxx accept/return ISADevice instead of RTCState.

2010-01-05 Thread Isaku Yamahata
To match rtc_xxx with qdev, make rtc_xxx accept and return ISADevice instead of RTCState. Signed-off-by: Isaku Yamahata Acked-by: Gerd Hoffmann --- hw/mc146818rtc.c | 26 +++--- hw/mc146818rtc.h |8 hw/mips_jazz.c |1 + hw/mips_malta.c |3 ++- hw/mi

[Qemu-devel] [PATCH V12 21/27] acpi_piix4: qdevfy.

2010-01-05 Thread Isaku Yamahata
qdevfy acpi_piix4. Signed-off-by: Isaku Yamahata Acked-by: Gerd Hoffmann --- changes v10 -> v11: - pass DeviceState of piix4-pm to pc_smbus_init(). Now info qtree shows smbus. --- hw/acpi_piix4.c | 56 ++ 1 files changed, 43 insertions(+)

[Qemu-devel] [PATCH V12 18/27] pc: split out piix specific part from pc.c into pc_piix.c

2010-01-05 Thread Isaku Yamahata
Finally, we can safely split out the piix specific part from pc.c into pc_piix.c. Signed-off-by: Isaku Yamahata Acked-by: Gerd Hoffmann --- Makefile.target |2 +- hw/pc.c | 264 +- hw/pc.h | 33 +++ hw/pc_piix.c|

[Qemu-devel] [PATCH V12 14/27] pc: split out memory allocation from pc_init1() into pc_memory_init()

2010-01-05 Thread Isaku Yamahata
Split out memory allocation and rom/bios loading which doesn't depend on piix from pc_init1() into pc_memory_init(). Later it will be used. Signed-off-by: Isaku Yamahata Acked-by: Gerd Hoffmann --- hw/pc.c | 74 +++--- 1 files changed, 4

[Qemu-devel] [PATCH V12 16/27] pc: split out basic device init from pc_init1() into pc_basic_device_init()

2010-01-05 Thread Isaku Yamahata
Split out basic device, i.e. legacy devices like floppy, initialization from pc_init1() into pc_basic_device_init(). Later it will be used. Signed-off-by: Isaku Yamahata Acked-by: Gerd Hoffmann --- hw/pc.c | 87 +++--- 1 files changed, 4

[Qemu-devel] [PATCH V12 22/27] pci hotplug: add argument to pci hot plug callback.

2010-01-05 Thread Isaku Yamahata
Add argument, DeviceState*, to pci hot plug callback. The argument will be used later to remove global variable. Signed-off-by: Isaku Yamahata Acked-by: Gerd Hoffmann --- changes v10 -> v11: - change callback argument from void* to DeviceState*. --- hw/acpi_piix4.c |6 +++--- hw/pci.c

[Qemu-devel] [PATCH V12 08/27] pc: make an unnecessary global variable, pit, local.

2010-01-05 Thread Isaku Yamahata
remove unnecessary global static variables, pit. Make it local. Signed-off-by: Isaku Yamahata Acked-by: Gerd Hoffmann --- hw/pc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index cdd9de6..0dee9d7 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -66,7 +66,6

[Qemu-devel] [PATCH V12 27/27] mc146818rtc: remove #ifdef DEBUG_CMOS.

2010-01-05 Thread Isaku Yamahata
remove #ifdef DEBUG_CMOS by using macro. Signed-off-by: Isaku Yamahata Acked-by: Gerd Hoffmann --- hw/mc146818rtc.c | 18 ++ 1 files changed, 10 insertions(+), 8 deletions(-) diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c index 1eb991c..0e1dc07 100644 --- a/hw/mc146818rtc.c

[Qemu-devel] [PATCH V12 12/27] pc: make pc_init1() not refer ferr_irq directly.

2010-01-05 Thread Isaku Yamahata
By introducing a registering function, make pc_init1() not refer to ferr_irq directly in order to make ferr_irq piix independent. Later pc_init1() will be split out into another file keeping ferr_irq static. Signed-off-by: Isaku Yamahata Acked-by: Gerd Hoffmann --- hw/pc.c |8 +++- hw/p

[Qemu-devel] [PATCH V12 05/27] acpi_piix4: remove unused variable in get_pmsts().

2010-01-05 Thread Isaku Yamahata
remove unused variable in get_pmsts(). Signed-off-by: Isaku Yamahata Acked-by: Gerd Hoffmann --- hw/acpi_piix4.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c index c44ab5d..30401a1 100644 --- a/hw/acpi_piix4.c +++ b/hw/acpi_piix4.c

[Qemu-devel] [PATCH V12 01/27] acpi: split out piix4 smbus routines from acpi.c into pm_smbus.c

2010-01-05 Thread Isaku Yamahata
Split out piix4 smbus routines from acpi.c into pm_smbus.c and use it. The split out smbus emulation will be used later. Signed-off-by: Isaku Yamahata Acked-by: Gerd Hoffmann Cc: Aurelien Jarno --- changes v11 -> v12 - switch the prefix, pc to pm since this is used by not only pc, but also m

[Qemu-devel] [PATCH V12 25/27] acpi_piix4: remove #ifdef DEBUG.

2010-01-05 Thread Isaku Yamahata
removed #ifdef DEBUG by using macro. Signed-off-by: Isaku Yamahata Acked-by: Gerd Hoffmann --- hw/acpi_piix4.c | 54 ++ 1 files changed, 18 insertions(+), 36 deletions(-) diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c index e448143..bc32c3b

[Qemu-devel] [PATCH V12 09/27] pc: remove a global variable, floppy_controller.

2010-01-05 Thread Isaku Yamahata
Remove a global variable, floppy_controller. Since it is unnecessarily global, make it local and pass it as a function argument. Signed-off-by: Isaku Yamahata Acked-by: Gerd Hoffmann --- hw/pc.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/pc.c b/hw/pc.c in

[Qemu-devel] [PATCH V12 11/27] pc: introduce a function to allocate cpu irq.

2010-01-05 Thread Isaku Yamahata
Introduce a function, pc_allocate_cpu_irq(), to allocate cpu irq in order to make pic_irq_request() piix independent. Later piix code will be split out to another file keeping pic_irq_request() static. Signed-off-by: Isaku Yamahata Acked-by: Gerd Hoffmann --- hw/pc.c |7 ++- 1 files cha

[Qemu-devel] [PATCH V12 10/27] pc: remove global variable rtc_state by using qemu_irq.

2010-01-05 Thread Isaku Yamahata
Remove the reference to the global variable, rtc_state, by passing function argument to cmos_init_hd(), cmos_init(). And following d9c3231019a0fbacbe15dcb26a0e3708b726af77 which uses qemu_irq for powerdown to eliminate nasty #ifdef (TARGET_xxx), this patch removes #ifdef(TARGET_I386) and global var

[Qemu-devel] [PATCH V12 23/27] pci hotadd, acpi_piix4: remove global variables.

2010-01-05 Thread Isaku Yamahata
remove global variables, gpe and pci0_status by moving them into PIIX4PMState. Signed-off-by: Isaku Yamahata Acked-by: Gerd Hoffmann --- Changes v10 -> v11: - change callback argument of hotplug from void* to DeviceState*. --- hw/acpi_piix4.c | 72 +---

[Qemu-devel] [PATCH V12 00/27] split out piix specific part from pc emulator and some clean ups

2010-01-05 Thread Isaku Yamahata
As Aurelien pointed out that piix smbus and apm aren't pc specific because MIPS also uses it. So I renamed them. both file names and symbol names. s/pc_smbus/pm_smbus/g, s/pc_apm/apm/g and so on. At first I tried s/pc_smbus/smbus/g, however smbus is already used. So I chose pm_smbus. patch series

[Qemu-devel] [PATCH V12 24/27] pm_smbus: remove #ifdef DEBUG.

2010-01-05 Thread Isaku Yamahata
remove #ifdef DEBUG by using macro. Signed-off-by: Isaku Yamahata Acked-by: Gerd Hoffmann --- hw/pm_smbus.c | 21 - 1 files changed, 12 insertions(+), 9 deletions(-) diff --git a/hw/pm_smbus.c b/hw/pm_smbus.c index 6ef6b9e..9929d72 100644 --- a/hw/pm_smbus.c +++ b/hw/pm_s

[Qemu-devel] [PATCH V12 26/27] apm: remove #ifdef DEBUG.

2010-01-05 Thread Isaku Yamahata
remove #ifdef DEBUG by using macro. Signed-off-by: Isaku Yamahata Acked-by: Gerd Hoffmann --- hw/apm.c | 14 -- 1 files changed, 8 insertions(+), 6 deletions(-) diff --git a/hw/apm.c b/hw/apm.c index d20db3d..3cbde43 100644 --- a/hw/apm.c +++ b/hw/apm.c @@ -23,6 +23,12 @@ //#d

[Qemu-devel] Re: Can anybody simply explains how the device model gets run?

2010-01-05 Thread 刘鹏程
let me be more specific, for pci nic rtl8139, some callback functions are registered during initialization, such as rtl8139_receive, rtl8139_can_receive. When and how do these functions get called? My qemu vertion is qemu-0.10.6. Can anyone generally explain the process? It will be very appreciated

Re: [Qemu-devel] [PATCH V11 01/27] acpi: split out pc smbus routines from acpi.c into pc_smbus.c

2010-01-05 Thread Isaku Yamahata
On Tue, Jan 05, 2010 at 11:11:00PM +0100, Aurelien Jarno wrote: > On Tue, Jan 05, 2010 at 03:27:24PM +0900, Isaku Yamahata wrote: > > Split out pc smbus routines from acpi.c into pc_smbus.c and > > use it. > > Given the code is not specific to PC, but is also used on MIPS, I am not > sure pc_smbus

Re: [Qemu-devel] Re: [PATCH 11/19] use a bottom half to run timers

2010-01-05 Thread Jamie Lokier
Anthony Liguori wrote: > Thread and signal safety are slightly different. They are very different: Virtually all libc calls are thread safe, unless they use unsafe static data APIs. On the other hand, the number of libc calls that are signal safe is very limited. For example, calling printf() i

[Qemu-devel] [PATCH 2/2] tcg-x86_64: Avoid unnecessary REX.B prefixes.

2010-01-05 Thread Richard Henderson
A while ago Laurent pointed out that the setcc opcode emitted by the setcond patch had unnecessary REX prefixes. The existing P_REXB internal opcode flag unconditionally emits the REX prefix. Technically it's not needed if the register in question is %al, %bl, %cl, %dl. Eliding the prefix requir

[Qemu-devel] [PATCH 1/2] tcg-x86_64: Special-case all 32-bit AND operands.

2010-01-05 Thread Richard Henderson
This avoids an unnecessary REX.W prefix when dealing with AND operands that fit into a 32-bit quantity. The most common change actually seen is movz[wb]q -> movz[wb]l. Similarly, avoid REXW in ext{8,16}u_i64 tcg opcodes. Signed-off-by: Richard Henderson --- tcg/x86_64/tcg-target.c | 26 +

Re: [Qemu-devel] Re: Planning for 0.13

2010-01-05 Thread Anthony Liguori
On 01/05/2010 03:33 PM, Michael S. Tsirkin wrote: On Tue, Jan 05, 2010 at 06:43:11AM -0600, Anthony Liguori wrote: Hi, I hope everyone had a happy new year! Now that we've finished the 0.12 release and most of us have had a nice break, I think it's time to start planning for the next relea

Re: [Qemu-devel] [PATCH] Added 'access' option to -drive flag

2010-01-05 Thread Jamie Lokier
Anthony Liguori wrote: > On 12/24/2009 03:09 AM, Markus Armbruster wrote: > >Naphtali Sprei writes: > > > >>Added 'access' option to -drive flag > >> > >>The new option is: access=[rw|ro|auto] > >>rw: open the drive's file with Read and Write permission, don't continue > >>if failed > >>ro: open

Re: [Qemu-devel] cpuid problem in upstream qemu with kvm

2010-01-05 Thread Anthony Liguori
On 12/23/2009 04:32 AM, Avi Kivity wrote: On 12/22/2009 06:12 PM, Anthony Liguori wrote: I think the only two Fully Correct approachs are to support a very specific CPU (e.g. Xeon-X5270) or provide the ability to individually tweak cpu flags. Yes. By a curious coincidence these are what th

[Qemu-devel] [PATCH 9/9] sparc64: reimplement tick timers

2010-01-05 Thread Igor Kovalenko
sparc64 timer has tick counter which can be set and read, and tick compare value used as deadline to fire timer interrupt. The timer is not used as periodic timer, instead deadline is set each time new timer interrupt is needed. This change implements sparc64 timers without periodic timers. It is

[Qemu-devel] [PATCH 8/9] sparc64: interrupt trap handling

2010-01-05 Thread Igor V. Kovalenko
From: Igor V. Kovalenko cpu_check_irqs - handle SOFTINT register TICK and STICK timer bits - only check interrupt levels greater than PIL value - handle preemption by higher level traps cpu_exec - handle CPU_INTERRUPT_HARD only if interrupts are enabled - PIL 15 is not special level on sparcv9

[Qemu-devel] [PATCH 7/9] sparc64: move cpu_interrupts_enabled to cpu.h

2010-01-05 Thread Igor V. Kovalenko
From: Igor V. Kovalenko - to be used by cpu_check_irqs Signed-off-by: Igor V. Kovalenko --- target-sparc/cpu.h | 13 + target-sparc/exec.h | 13 - 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/target-sparc/cpu.h b/target-sparc/cpu.h index 0dba241

[Qemu-devel] [PATCH 6/9] sparc64: clear exception_index with -1 value

2010-01-05 Thread Igor V. Kovalenko
From: Igor V. Kovalenko Signed-off-by: Igor V. Kovalenko --- target-sparc/op_helper.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-sparc/op_helper.c b/target-sparc/op_helper.c index b1978cb..94f1c7a 100644 --- a/target-sparc/op_helper.c +++ b/target-sparc/op_

[Qemu-devel] [PATCH 5/9] sparc64: add macros to deal with softint and timer interrupt

2010-01-05 Thread Igor V. Kovalenko
From: Igor V. Kovalenko Signed-off-by: Igor V. Kovalenko --- target-sparc/cpu.h |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/target-sparc/cpu.h b/target-sparc/cpu.h index 1fe4d0f..0dba241 100644 --- a/target-sparc/cpu.h +++ b/target-sparc/cpu.h @@ -394,6 +394,8

[Qemu-devel] [PATCH 4/9] sparc64: check for pending irq when pil, pstate or softint is changed

2010-01-05 Thread Igor V. Kovalenko
From: Igor V. Kovalenko Signed-off-by: Igor V. Kovalenko --- target-sparc/op_helper.c | 39 --- 1 files changed, 36 insertions(+), 3 deletions(-) diff --git a/target-sparc/op_helper.c b/target-sparc/op_helper.c index a7da0e4..b1978cb 100644 --- a/target-sp

[Qemu-devel] [PATCH 3/9] sparc64: use helper_wrpil to check pending irq on write

2010-01-05 Thread Igor V. Kovalenko
From: Igor V. Kovalenko Signed-off-by: Igor V. Kovalenko --- target-sparc/helper.h|1 + target-sparc/op_helper.c | 14 ++ target-sparc/translate.c |5 + 3 files changed, 16 insertions(+), 4 deletions(-) diff --git a/target-sparc/helper.h b/target-sparc/helper.h in

[Qemu-devel] [PATCH 2/9] sparc64: add PSR and PIL to cpu state dump

2010-01-05 Thread Igor V. Kovalenko
From: Igor V. Kovalenko Signed-off-by: Igor V. Kovalenko --- target-sparc/helper.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/target-sparc/helper.c b/target-sparc/helper.c index a06923a..0f0e583 100644 --- a/target-sparc/helper.c +++ b/target-sparc/helper.c @@ -145

[Qemu-devel] [PATCH 1/9] sparc64: trace pstate and global register set changes

2010-01-05 Thread Igor V. Kovalenko
From: Igor V. Kovalenko Signed-off-by: Igor V. Kovalenko --- target-sparc/op_helper.c | 20 1 files changed, 20 insertions(+), 0 deletions(-) diff --git a/target-sparc/op_helper.c b/target-sparc/op_helper.c index dab2c25..26092e5 100644 --- a/target-sparc/op_helper.c +++

[Qemu-devel] [PATCH 0/9] sparc64: tick timers

2010-01-05 Thread Igor V. Kovalenko
The following series deals with tick timers for sparc64. It is not complete solution yet, comments are welcome. First two changes are really debug helpers, so are not strictly required. Central part is addressing how traps are taken, which includes taking trap when PSTATE.IE is changed, PIL mask

Re: [Qemu-devel] Re: PCI: Fix bus address conversion

2010-01-05 Thread Andreas Färber
Am 04.01.2010 um 19:33 schrieb Michael S. Tsirkin: On Sun, Dec 27, 2009 at 05:01:38PM -0600, Anthony Liguori wrote: Likewise, if you see a patch go in that you think would have benefited from being on the list, point it out. People are reasonable and if you have a good suggestion, they'll

Re: [Qemu-devel] Planning for 0.13

2010-01-05 Thread Aurelien Jarno
On Tue, Jan 05, 2010 at 06:43:11AM -0600, Anthony Liguori wrote: > Hi, > > I hope everyone had a happy new year! Now that we've finished the 0.12 > release and most of us have had a nice break, I think it's time to start > planning for the next release. > > 0.12 felt a bit rushed to me. I'd l

[Qemu-devel] Re: [PATCH 1/6] PCI config space access overhaul

2010-01-05 Thread Michael S. Tsirkin
On Mon, Jan 04, 2010 at 08:32:50AM +0100, Alexander Graf wrote: > +typedef void (*pci_config_reg_fn)(PCIHostState *s, uint32_t config_reg, > + PCIConfigAddress *conf); > + pci_decode_config_addr_fn would be a better name. > struct PCIHostState { > SysBusDevi

Re: [Qemu-devel] [PATCH V11 01/27] acpi: split out pc smbus routines from acpi.c into pc_smbus.c

2010-01-05 Thread Aurelien Jarno
On Tue, Jan 05, 2010 at 03:27:24PM +0900, Isaku Yamahata wrote: > Split out pc smbus routines from acpi.c into pc_smbus.c and > use it. Given the code is not specific to PC, but is also used on MIPS, I am not sure pc_smbus is the best name. > The split out smbus emulation will be used later. > >

[Qemu-devel] Re: Planning for 0.13

2010-01-05 Thread Michael S. Tsirkin
On Tue, Jan 05, 2010 at 06:43:11AM -0600, Anthony Liguori wrote: > Hi, > > I hope everyone had a happy new year! Now that we've finished the 0.12 > release and most of us have had a nice break, I think it's time to start > planning for the next release. > > 0.12 felt a bit rushed to me. I'd l

Re: [Qemu-devel] eepro100.c patches

2010-01-05 Thread Stefan Weil
Anthony Liguori schrieb: > Stefan Weil wrote: >> Anthony Liguori schrieb: >> >>> Stefan Weil wrote: >>> Hi, these patches are still missing in QEMU master (and would also be good for 0.12.x because many people wait for the multicast fix needed for junos, see "jun

[Qemu-devel] Re: [PATCH] Makefile: Update unmodified config-devices.mak automatically

2010-01-05 Thread Stefan Weil
Michael S. Tsirkin schrieb: > On Thu, Dec 24, 2009 at 04:03:17PM +0100, Juan Quintela wrote: >> "Michael S. Tsirkin" wrote: >>> On Thu, Dec 24, 2009 at 02:31:58PM +0100, Stefan Weil wrote: Michael S. Tsirkin schrieb: > On Sun, Dec 20, 2009 at 03:39:03PM +0100, Stefan Weil wrote: > >>>

Re: [Qemu-devel] Planning for 0.13

2010-01-05 Thread Stefan Weil
Anthony Liguori schrieb: > Hi, > > I hope everyone had a happy new year! Now that we've finished the > 0.12 release and most of us have had a nice break, I think it's time > to start planning for the next release. > > 0.12 felt a bit rushed to me. I'd like to take a bit more time with > 0.13 and

[Qemu-devel] [PATCH] [virtio] Add virtio block device sanboot support

2010-01-05 Thread Stefan Hajnoczi
This patch adds virtio block device support alongside the existing iSCSI, ATA-over-Ethernet, and ramdisk block devices. The virtio block device provides storage in virtualized environments. Using this patch, a gPXE option ROM can boot a QEMU/KVM virtual machine directly from a virtio block device

[Qemu-devel] [PATCH 5/5] PCI: do_pci_info(): PCI bridge devices support

2010-01-05 Thread Luiz Capitulino
This commit completes the do_pci_info() conversion to QObject by adding support to PCI bridge devices. This is done by recursively adding devices in the "pci_bridge" key. This code is being added separately because I could not test it properly. According to Michael Tsirkin, it depends on ultraspa

[Qemu-devel] [PATCH 4/5] PCI: do_pci_info(): PCI bridge support

2010-01-05 Thread Luiz Capitulino
This commit adds the "pci_bridge" key to the PCI device QDict, it also adds support for printing it in the user protocol. This code is being added separately because I could not test it properly. According to Michael Tsirkin, it depends on ultrasparc and it would take time to do the proper setup.

[Qemu-devel] [PATCH 3/5] PCI: Convert pci_info() to QObject

2010-01-05 Thread Luiz Capitulino
The returned QObject is a QList of all buses. Each bus is represented by a QDict, which has a key with a QList of all PCI devices attached to it. Each device is represented by a QDict. IMPORTANT: support for printing PCI bridge information and its devices is NOT part of this commit, it's going to

[Qemu-devel] [PATCH 2/5] QDict: Introduce qdict_get_qdict()

2010-01-05 Thread Luiz Capitulino
A helper to retrieve a QDict from a QDict. Signed-off-by: Luiz Capitulino --- qdict.c | 13 + qdict.h |1 + 2 files changed, 14 insertions(+), 0 deletions(-) diff --git a/qdict.c b/qdict.c index ba8eef0..c6a5a42 100644 --- a/qdict.c +++ b/qdict.c @@ -216,6 +216,19 @@ QList *qd

[Qemu-devel] [PATCH 1/5] QList: Introduce QLIST_FOREACH_ENTRY()

2010-01-05 Thread Luiz Capitulino
Iterate over QList entries, it's needed to call qlist_entry_obj() to retrieve the stored QObject. I'm not sure if it's ok to have this, because it's not as easy as qlist_iter() and the QListEntry data type is now exposed to the users, which means we have one more struct to be maintained when we ha

[Qemu-devel] [PATCH v0 0/5]: Convert pci_info() to QObject

2010-01-05 Thread Luiz Capitulino
Hi, This series begins complex handler conversion to QObject by converting pci_info(), which is called when "info pci" is executed in the Monitor. Please help reviewing, as this was the more complex conversion I did so far and I only ran basic tests. Two points worth noting: 1. I'm still us

Re: [Qemu-devel] Re: [PATCH 1/6] Make config space accessor host bus trapable

2010-01-05 Thread Michael S. Tsirkin
On Tue, Jan 05, 2010 at 07:10:58AM +1100, Benjamin Herrenschmidt wrote: > On Mon, 2010-01-04 at 13:07 +0200, Michael S. Tsirkin wrote: > > BTW, I think we really should think about the right way to address the > > swap/noswap issue without using a preprocessor. Maybe make pci host > > bridge explic

Re: [Qemu-devel] Re: [PATCH v2] virtio-blk physical block size

2010-01-05 Thread Jamie Lokier
Avi Kivity wrote: > Physical block size is the what the logical block size would have been > is software didn't suck. In theory they should be the same, but since > compatibility reaons clamp the logical block size to 512, they have to > differ. A disk may have a physical block size of 4096 an

Re: [Qemu-devel] Re: [PATCH v2] virtio-blk physical block size

2010-01-05 Thread Jamie Lokier
Avi Kivity wrote: > On 01/05/2010 02:56 PM, Rusty Russell wrote: > > > >>Those should be the same for any sane interface. They are for classical > >>disk devices with larger block sizes (MO, s390 dasd) and also for the > >>now appearing 4k sector scsi disks. But in the ide world people are > >>co

Re: [Qemu-devel] Re: [PATCH 1/6] Make config space accessor host bus trapable

2010-01-05 Thread Benjamin Herrenschmidt
On Tue, 2010-01-05 at 00:25 +0200, Michael S. Tsirkin wrote: > On Tue, Jan 05, 2010 at 08:53:52AM +1100, Benjamin Herrenschmidt wrote: > > > > > Yes, but I think how you program your host to pci bridge is platform > > > specific, > > > the standard (mostly) applies to what happens below the bridg

Re: [Qemu-devel] Re: [PATCH 1/6] Make config space accessor host bus trapable

2010-01-05 Thread Benjamin Herrenschmidt
> Yes, but I think how you program your host to pci bridge is platform specific, > the standard (mostly) applies to what happens below the bridge. There's > no real standard for how PCI host bridge is connected to processor > AFAIK, it's by luck we can share code there at all. Well, yes and no .

Re: [Qemu-devel] Re: [PATCH 1/6] Make config space accessor host bus trapable

2010-01-05 Thread Benjamin Herrenschmidt
On Tue, 2010-01-05 at 00:08 +0100, Alexander Graf wrote: > > IIRC qemu's mmio functions just pass the register value the guest had > at that moment to the mmio function. That means that qemu HW emulation needs, for each device, to add a layer of byteswap depending on whether the CPU is LE or BE w

Re: [Qemu-devel] Re: [PATCH 1/6] Make config space accessor host bus trapable

2010-01-05 Thread Benjamin Herrenschmidt
On Mon, 2010-01-04 at 23:12 +0200, Michael S. Tsirkin wrote: > Well, the main issue if I understand correcttly is that basically the > same hardware bridge can be connected to host in different ways. Yes, we > can say "if it's connected differently it's a different device" but this > is slightly ug

Re: [Qemu-devel] [PATCH 2/8] virtio-console: qdev conversion, new virtio-serial-bus

2010-01-05 Thread Anthony Liguori
On 12/23/2009 11:25 PM, Amit Shah wrote: On (Wed) Dec 23 2009 [17:12:22], Anthony Liguori wrote: +struct VirtIOSerial { +VirtIODevice vdev; + +VirtQueue *c_ivq, *c_ovq; +/* Arrays of ivqs and ovqs: one per port */ +VirtQueue **ivqs, **ovqs; + +VirtIOSerialBus *bus; + +

Re: [Qemu-devel] [PATCH] Added 'access' option to -drive flag

2010-01-05 Thread Anthony Liguori
On 12/24/2009 03:09 AM, Markus Armbruster wrote: Naphtali Sprei writes: Added 'access' option to -drive flag The new option is: access=[rw|ro|auto] rw: open the drive's file with Read and Write permission, don't continue if failed ro: open the file only with Read permission auto: open the fi

[Qemu-devel] Re: PCI: Fix bus address conversion (was Re: commit rules for common git tree)

2010-01-05 Thread Blue Swirl
On Mon, Jan 4, 2010 at 7:10 PM, Michael S. Tsirkin wrote: > On Mon, Jan 04, 2010 at 07:04:38PM +, Blue Swirl wrote: >> On Mon, Jan 4, 2010 at 6:33 PM, Michael S. Tsirkin wrote: >> >> On Sun, Dec 27, 2009 at 05:01:38PM -0600, Anthony Liguori wrote: >> >> > Likewise, if you see a patch go in th

[Qemu-devel] [PATCH 6/6] target-alpha: Implement IEEE FP qualifiers.

2010-01-05 Thread Richard Henderson
IEEE FP instructions are split up so that the rounding mode coming from the instruction and exceptions (both masking and delivery) are handled external to the base FP operation. FP exceptions are properly raised for non-finite inputs to instructions that do not indicate software completion. A shor

[Qemu-devel] [PATCH 2/6] target-alpha: Split up FPCR value into separate fields.

2010-01-05 Thread Richard Henderson
The fpcr_exc_status, fpcr_exc_mask, and fpcr_dyn_round fields are stored in format for convenience during regular execution. Revert the addition of float_exception_mask to float_status, added in ba0e276db4b51bd2255a5d5ff8902c70d32ade40. Signed-off-by: Richard Henderson --- fpu/softfloat.h

Re: [Qemu-devel] Re: [PATCH 1/6] Make config space accessor host bus trapable

2010-01-05 Thread Alexander Graf
On 04.01.2010, at 23:59, Michael S. Tsirkin wrote: > On Tue, Jan 05, 2010 at 09:51:48AM +1100, Benjamin Herrenschmidt wrote: >> On Tue, 2010-01-05 at 00:25 +0200, Michael S. Tsirkin wrote: >>> On Tue, Jan 05, 2010 at 08:53:52AM +1100, Benjamin Herrenschmidt wrote: > Yes, but I think how

Re: [Qemu-devel] Re: [PATCH 1/6] Make config space accessor host bus trapable

2010-01-05 Thread Michael S. Tsirkin
On Tue, Jan 05, 2010 at 08:25:30AM +1100, Benjamin Herrenschmidt wrote: > On Mon, 2010-01-04 at 23:12 +0200, Michael S. Tsirkin wrote: > > Well, the main issue if I understand correcttly is that basically the > > same hardware bridge can be connected to host in different ways. Yes, we > > can say "

Re: [Qemu-devel] Re: [PATCH 1/6] Make config space accessor host bus trapable

2010-01-05 Thread Benjamin Herrenschmidt
> So, it appears that this is not the case for many platforms: bridge > itself does a byteswap to make devices behind it work according to spec, > but this does not apply to programming bridge itself. > > This seems common on BE platforms, this is why qemu has > ifdef TARGET_WORDS_BIGENDIAN there

Re: [Qemu-devel] Re: [PATCH 1/6] Make config space accessor host bus trapable

2010-01-05 Thread Michael S. Tsirkin
On Tue, Jan 05, 2010 at 08:53:52AM +1100, Benjamin Herrenschmidt wrote: > > > Yes, but I think how you program your host to pci bridge is platform > > specific, > > the standard (mostly) applies to what happens below the bridge. There's > > no real standard for how PCI host bridge is connected t

[Qemu-devel] Re: [PATCH V10 22/27] pci hotplug: add argument to pci hot plug callback.

2010-01-05 Thread Isaku Yamahata
On Mon, Jan 04, 2010 at 03:56:50PM +0100, Gerd Hoffmann wrote: > On 12/24/09 09:09, Isaku Yamahata wrote: >> The argument will be used later to remove global variable. > >> -static int piix4_device_hotplug(PCIDevice *dev, int state); >> +static int piix4_device_hotplug(void *opaque, PCIDevice *dev,

[Qemu-devel] [PATCHv2 2/3] kvm: move kvm_set_phys_mem around

2010-01-05 Thread Michael S. Tsirkin
move kvm_set_phys_mem so that it will be later available earlier in the file. needed for next patch using memory notifiers. Signed-off-by: Michael S. Tsirkin --- kvm-all.c | 276 ++-- 1 files changed, 138 insertions(+), 138 deletions(-) d

[Qemu-devel] [PATCHv2 0/3] qemu: memory notifiers

2010-01-05 Thread Michael S. Tsirkin
This patch against qemu upstream adds notifiers hook which lets backends get notified on memory changes, and converts kvm to use it. It survived light testing. Avi, could you please take a look at this patch? Thanks! --- cpu-common.h | 19 + exec.c | 62 +++

[Qemu-devel] [PATCHv2 1/3] qemu: memory notifiers

2010-01-05 Thread Michael S. Tsirkin
This adds notifiers for phys memory changes: a set of callbacks that vhost can register and update kernel accordingly. Down the road, kvm code can be switched to use these as well, instead of calling kvm code directly from exec.c as is done now. Signed-off-by: Michael S. Tsirkin --- cpu-common.

[Qemu-devel] [PATCHv2 3/3] kvm: move kvm to use memory notifiers

2010-01-05 Thread Michael S. Tsirkin
remove direct kvm calls from exec.c, make kvm use memory notifiers framework instead. Signed-off-by: Michael S. Tsirkin --- exec.c| 17 + kvm-all.c | 40 ++-- kvm.h |8 3 files changed, 35 insertions(+), 30 deletions(-)

Re: [Qemu-devel] [PATCH 1/4] socket: Rationalise function declarations

2010-01-05 Thread Anthony Liguori
On 12/27/2009 04:29 PM, Ian Molton wrote: Ian Molton wrote: Can I get the status of this patchset please ? I really dislike the idea of automatically reconnecting a socket. Mainly because I'm not sure that you can have sane universal semantics for what to do while it's disconnected. I woul

[Qemu-devel] Re: PCI: Fix bus address conversion (was Re: commit rules for common git tree)

2010-01-05 Thread Michael S. Tsirkin
On Mon, Jan 04, 2010 at 07:49:10PM +, Blue Swirl wrote: > On Mon, Jan 4, 2010 at 7:10 PM, Michael S. Tsirkin wrote: > > On Mon, Jan 04, 2010 at 07:04:38PM +, Blue Swirl wrote: > >> On Mon, Jan 4, 2010 at 6:33 PM, Michael S. Tsirkin wrote: > >> >> On Sun, Dec 27, 2009 at 05:01:38PM -0600,

[Qemu-devel] Re: [PATCH 11/19] use a bottom half to run timers

2010-01-05 Thread Paolo Bonzini
On 01/04/2010 09:24 PM, Anthony Liguori wrote: I'm not a huge fan of this for a couple reasons. The first is that it introduces a subtle semantic change. Previously, timers always ran before bottom halves whereas after this change, timers may run after some bottoms halves but before others.

[Qemu-devel] Re: [PATCH 11/19] use a bottom half to run timers

2010-01-05 Thread Michael S. Tsirkin
On Mon, Jan 04, 2010 at 02:24:53PM -0600, Anthony Liguori wrote: > On 12/21/2009 02:09 AM, Paolo Bonzini wrote: >> Make the timer subsystem register its own bottom half instead of >> placing the bottom half code in the heart of the main loop. To >> test if an alarm timer is pending, just check if

Re: [Qemu-devel] Re: [PATCH 1/6] Make config space accessor host bus trapable

2010-01-05 Thread Benjamin Herrenschmidt
On Mon, 2010-01-04 at 13:07 +0200, Michael S. Tsirkin wrote: > BTW, I think we really should think about the right way to address the > swap/noswap issue without using a preprocessor. Maybe make pci host > bridge explicitly specify whether to swap bytes? How about adding a > field in PCIHostState

Re: [Qemu-devel] [PATCH v2] Drop --whole-archive and static libraries

2010-01-05 Thread Blue Swirl
On Sun, Jan 3, 2010 at 12:31 PM, Blue Swirl wrote: > 2009/12/31 Andreas Färber : >> From: Andreas Färber >> >> Juan has contributed a cool Makefile infrastructure that enables us to drop >> static libraries completely: >> >> Move shared obj-y definitions to Makefile.objs, prefixed {common-,hw-,us

Re: [Qemu-devel] Re: [PATCH 1/6] Make config space accessor host bus trapable

2010-01-05 Thread Michael S. Tsirkin
On Tue, Jan 05, 2010 at 09:51:48AM +1100, Benjamin Herrenschmidt wrote: > On Tue, 2010-01-05 at 00:25 +0200, Michael S. Tsirkin wrote: > > On Tue, Jan 05, 2010 at 08:53:52AM +1100, Benjamin Herrenschmidt wrote: > > > > > > > Yes, but I think how you program your host to pci bridge is platform > >

Re: [Qemu-devel] Re: [PATCH 1/6] Make config space accessor host bus trapable

2010-01-05 Thread Michael S. Tsirkin
On Tue, Jan 05, 2010 at 12:08:19AM +0100, Alexander Graf wrote: > > On 04.01.2010, at 23:59, Michael S. Tsirkin wrote: > > > On Tue, Jan 05, 2010 at 09:51:48AM +1100, Benjamin Herrenschmidt wrote: > >> On Tue, 2010-01-05 at 00:25 +0200, Michael S. Tsirkin wrote: > >>> On Tue, Jan 05, 2010 at 08:5

[Qemu-devel] Re: [PATCH 11/19] use a bottom half to run timers

2010-01-05 Thread Anthony Liguori
On 01/04/2010 02:01 PM, Michael S. Tsirkin wrote: On Mon, Jan 04, 2010 at 02:24:53PM -0600, Anthony Liguori wrote: On 12/21/2009 02:09 AM, Paolo Bonzini wrote: Make the timer subsystem register its own bottom half instead of placing the bottom half code in the heart of the main loop.

[Qemu-devel] [PATCH] alpha-linux-user: Implement signals.

2010-01-05 Thread Richard Henderson
Move userland PALcode handling into linux-user main loop so that we can send signals from there. This also makes alpha_palcode.c system-level only, so don't build it for userland. Add defines for GENTRAP PALcall mapping to signals. Signed-off-by: Richard Henderson --- Makefile.target

[Qemu-devel] [PATCH 3/6] target-alpha: Reduce internal processor registers for user-mode.

2010-01-05 Thread Richard Henderson
The existing set of IPRs is totally irrelevant to user-mode emulation. Indeed, they most are irrelevant to implementing kernel-mode emulation, and would only be relevant to PAL-mode emulation, which I suspect that no one will ever attempt. Reducing the set of processor registers reduces the size o

[Qemu-devel] Re: [PATCH 11/19] use a bottom half to run timers

2010-01-05 Thread Anthony Liguori
On 01/04/2010 02:01 PM, Paolo Bonzini wrote: On 01/04/2010 09:24 PM, Anthony Liguori wrote: I'm not a huge fan of this for a couple reasons. The first is that it introduces a subtle semantic change. Previously, timers always ran before bottom halves whereas after this change, timers may run a

  1   2   >