Re: [Qemu-devel] Re: POST failure (loop) with isapc and seabios

On Mon, Nov 23, 2009 at 10:30:56PM +0100, Sebastian Herbszt wrote: > Gleb Natapov wrote: > >On Mon, Nov 23, 2009 at 08:19:54PM +0100, Sebastian Herbszt wrote: > >>Gleb Natapov wrote: > >>>On Sun, Nov 22, 2009 at 09:01:45PM +0100, Sebastian Herbszt wrote: > Gleb Natapov wrote: > >On Sun, Nov

[Qemu-devel] [PATCH 10/11] gdbstub: add MIPS16 support

The only thing to do here is to expose ISAMode to GDB and to set ISAMode properly when we change the PC. Signed-off-by: Nathan Froyd --- gdbstub.c | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 055093f..58a701b 100644 --- a/gdbstub.c

[Qemu-devel] [PATCH 05/11] target-mips: make gen_compute_branch 16/32-bit-aware

Signed-off-by: Nathan Froyd --- target-mips/translate.c | 15 --- 1 files changed, 8 insertions(+), 7 deletions(-) diff --git a/target-mips/translate.c b/target-mips/translate.c index c03d1bf..1157e97 100644 --- a/target-mips/translate.c +++ b/target-mips/translate.c @@ -2406,6 +2

Re: [Qemu-devel] [PATCH 0/6] Fix -kernel with SeaBIOS v2

On Mon, Nov 23, 2009 at 10:28:44PM +0100, Alexander Graf wrote: > >Is this on an x86_64 box or i386? I can boot the same kernel with > >upstream qemu on another box with an x86_64 kernel and qemu. > > I only test things on x86_64. so you're saying it breaks on an i586 > host? Yes, both guest a

Re: [Qemu-devel] Re: POST failure (loop) with isapc and seabios

Gleb Natapov wrote: On Mon, Nov 23, 2009 at 08:19:54PM +0100, Sebastian Herbszt wrote: Gleb Natapov wrote: >On Sun, Nov 22, 2009 at 09:01:45PM +0100, Sebastian Herbszt wrote: >>Gleb Natapov wrote: >>>On Sun, Nov 22, 2009 at 04:31:24PM +0100, Sebastian Herbszt wrote: Bad things could hap

Re: [Qemu-devel] [PATCH 0/6] Fix -kernel with SeaBIOS v2

Am 23.11.2009 um 21:21 schrieb Christoph Hellwig : On Fri, Nov 20, 2009 at 12:34:29PM +0100, Alexander Graf wrote: ag...@busu:~/work/qemu-late-int19/qemu> ./x86_64-softmmu/qemu-system- x86_64 -nographic -kernel ../bzImage -append console=ttyS0 -L pc- bios - enable-kvm [0.00] Linux ve

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

On Mon, Nov 23, 2009 at 01:49:09PM -0600, Anthony Liguori wrote: > Eduardo Habkost wrote: >> On Mon, Nov 23, 2009 at 12:28:16PM -0600, Anthony Liguori wrote: >>> After mulling over it a bit, here's what I'd suggest: >>> >>> 1) Integrate VMstate with qdev >>> 2) Introduce a bitmap bla

[Qemu-devel] [PATCH 08/11] target-mips: add enums for MIPS16 opcodes

Signed-off-by: Nathan Froyd --- target-mips/translate.c | 112 +++ 1 files changed, 112 insertions(+), 0 deletions(-) diff --git a/target-mips/translate.c b/target-mips/translate.c index e7aee33..611774b 100644 --- a/target-mips/translate.c +++ b/tar

[Qemu-devel] [PATCH 11/11] target-mips: add copyright notice for mips16 work

Signed-off-by: Nathan Froyd --- target-mips/translate.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/target-mips/translate.c b/target-mips/translate.c index 49d2264..ef5e726 100644 --- a/target-mips/translate.c +++ b/target-mips/translate.c @@ -4,6 +4,7 @@ * Copyri

[Qemu-devel] [PATCH 06/11] target-mips: add gen_base_offset_addr

This is a common pattern in existing code. We'll also use it to implement the mips16 SAVE/RESTORE instructions. Signed-off-by: Nathan Froyd --- target-mips/translate.c | 40 1 files changed, 16 insertions(+), 24 deletions(-) diff --git a/target-mips/t

[Qemu-devel] [PATCH 02/11] target-mips: add new HFLAGs for JALX and 16/32-bit delay slots

We create separate masks for the "basic" branch hflags and the "extended" branch hflags and define MIPS_HFLAG_BMASK as the logical or of those two. This is done to avoid churning the codebase in lots of different places. Signed-off-by: Nathan Froyd --- target-mips/cpu.h |8 +++- 1 files

[Qemu-devel] [PATCH 01/11] target-mips: add ISAMode bits for mips16 execution

Signed-off-by: Nathan Froyd --- target-mips/cpu.h |1 + target-mips/translate.c |2 ++ 2 files changed, 3 insertions(+), 0 deletions(-) diff --git a/target-mips/cpu.h b/target-mips/cpu.h index 82f9a38..e8febe6 100644 --- a/target-mips/cpu.h +++ b/target-mips/cpu.h @@ -167,6 +167,7

[Qemu-devel] [PATCH 07/11] target-mips: split out delay slot handling

Move delay slot handling to common code whose invocation can be controlled from gen_intermediate_code_internal. Signed-off-by: Nathan Froyd --- target-mips/translate.c | 134 +++--- 1 files changed, 79 insertions(+), 55 deletions(-) diff --git a/target-m

[Qemu-devel] [PATCH 03/11] target-mips: change interrupt bits to be mips16-aware

Signed-off-by: Nathan Froyd --- target-mips/helper.c| 47 ++- target-mips/op_helper.c | 10 +++--- 2 files changed, 33 insertions(+), 24 deletions(-) diff --git a/target-mips/helper.c b/target-mips/helper.c index 4a37277..e54a31a 100644 --

[Qemu-devel] [PATCH 09/11] target-mips: add mips16 instruction decoding

There's no good way to add this incrementally, so we do it all at once. The only changes to shared code are in handle_delay_slot. We need to flip ISAMode when doing a jump-and-exchange. We also need to set ISAMode the low bit of the target address for jump-to-register. Signed-off-by: Nathan Froy

[Qemu-devel] [PATCH 04/11] target-mips: move ROTR and ROTRV inside gen_shift_{imm, }

It's easier to implement mips16 shift instructions if we're not examining the opcode inside gen_shift_{imm,}. So move ROTR and ROTRV and do the special-case handling of SRL and SRLV inside decode_opc. Likewise for their 64-bit counterparts. Signed-off-by: Nathan Froyd --- target-mips/translate.

[Qemu-devel] [PATCH 00/11] target-mips: add mips16 support

This patchset adds MIPS16 support to the MIPS backend. MIPS16 is a compact encoding of a subset of the MIPS integer instructions, similar to ARM's Thumb mode. The processor enters MIPS16 mode by executing a special jump instruction; execution continus at the jump target in MIPS16 mode until the p

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

Excerpts from Anthony Liguori's message of Mon Nov 23 14:44:04 -0200 2009: > > I don't want to transparently migrate from 5.4.1 to 5.4.0 and have my > guest's time start drifting. I specifically want that to fail. If you migrate from 5.4.0 to 5.4.0 or from 5.4.0 to 5.4.1, the guest will also st

Re: [Qemu-devel] [PATCH 0/6] Fix -kernel with SeaBIOS v2

On Fri, Nov 20, 2009 at 12:34:29PM +0100, Alexander Graf wrote: > ag...@busu:~/work/qemu-late-int19/qemu> ./x86_64-softmmu/qemu-system- > x86_64 -nographic -kernel ../bzImage -append console=ttyS0 -L pc-bios - > enable-kvm > [0.00] Linux version 2.6.32-rc7 (h...@brick) (gcc version 4.3.4

Re: [Qemu-devel] [PATCH] debugcon: support for debugging consoles (e.g. Bochs port 0xe9)

On 11/23/2009 02:52 AM, Gerd Hoffmann wrote: > > All not needed. Simply registering as qdev device is enougth. You can > then add a debug port like this, without adding new cmd line options: > >-chardev vc,id=debug -device isa-debugcon,chardev=debug > > Adding a second one on a non-defaul

[Qemu-devel] [PATCH 17/17] VNC: Convert do_info_vnc() to QObject

Return a QDict with server information. Connected clients are returned as a QList of QDicts. The new functions (vnc_qdict_remote_addr(), vnc_qdict_local_addr() and put_addr_qdict()) are used to insert 'host' and 'service' information in the returned QDict. This patch is big, but I don't see how t

[Qemu-devel] [PATCH 16/17] PCI: Convert pci_device_hot_add() to QObject

Return a QDict with information about the just added device. This commit should not change user output. Please, note that this patch does not do error handling conversion. In error conditions the handler still calls monitor_printf(). Signed-off-by: Luiz Capitulino --- hw/pci-hotplug.c | 40 +

[Qemu-devel] [PATCH 14/17] block: Convert bdrv_info_stats() to QObject

Each device statistic information is stored in a QDict and the returned QObject is a QList of all devices. This commit should not change user output. Signed-off-by: Luiz Capitulino --- block.c | 82 block.h |3 +- monitor.c

[Qemu-devel] [PATCH 15/17] char: Convert qemu_chr_info() to QObject

Each device is represented by a QDict. The returned QObject is a QList of all devices. This commit should not change user output. Signed-off-by: Luiz Capitulino --- monitor.c |3 ++- qemu-char.c | 43 +-- qemu-char.h |4 +++- 3 files changed,

[Qemu-devel] [PATCH 13/17] block: Convert bdrv_info() to QObject

Each block device information is stored in a QDict and the returned QObject is a QList of all devices. This commit should not change user output. Signed-off-by: Luiz Capitulino --- Makefile |6 +- block.c | 123 +++-- block.h |

[Qemu-devel] [PATCH 12/17] migration: Convert do_info_migrate() to QObject

Return a QDict, which may contain another QDict if the migration process is active. IMPORTANT: as a QInt stores a int64_t integer, RAM values are going to be stored as int64_t and not as uint64_t as they are today. If this is a problem QInt will have to be changed. This commit should not change u

[Qemu-devel] [PATCH 11/17] monitor: Convert do_info_mice() to QObject

Each mouse is represented by a QDict, the returned QObject is a QList of all mice. This commit should not change user output. Signed-off-by: Luiz Capitulino --- console.h |3 +- monitor.c |3 +- vl.c | 62 ++-- 3 files chang

[Qemu-devel] [PATCH 10/17] monitor: Convert do_info_uuid() to QObject

The returned QObject is a QString, snprintf() is used because the UUID_FMT is too complex for qobject_from_jsonf(). Signed-off-by: Luiz Capitulino --- monitor.c | 15 --- 1 files changed, 12 insertions(+), 3 deletions(-) diff --git a/monitor.c b/monitor.c index ab21db4..eb46926 10

[Qemu-devel] [PATCH 09/17] monitor: Convert do_info_hpet() to QObject

Return a QString with HPET information. Signed-off-by: Luiz Capitulino --- monitor.c | 24 +--- 1 files changed, 21 insertions(+), 3 deletions(-) diff --git a/monitor.c b/monitor.c index 1540254..ab21db4 100644 --- a/monitor.c +++ b/monitor.c @@ -361,10 +361,27 @@ static v

[Qemu-devel] [PATCH 08/17] monitor: Convert do_info_name() to QObject

Return a QString with the current VM name. Signed-off-by: Luiz Capitulino --- monitor.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/monitor.c b/monitor.c index c2e82c8..1540254 100644 --- a/monitor.c +++ b/monitor.c @@ -349,10 +349,15 @@ static void do_inf

[Qemu-devel] [PATCH 07/17] monitor: Convert do_info_kvm() to QObject

Return a QString with kvm status information. Signed-off-by: Luiz Capitulino --- monitor.c | 31 +-- 1 files changed, 25 insertions(+), 6 deletions(-) diff --git a/monitor.c b/monitor.c index c9104c3..c2e82c8 100644 --- a/monitor.c +++ b/monitor.c @@ -1551,17 +1551

[Qemu-devel] [PATCH 06/17] monitor: Convert do_info_status() to QObject

Return a QString with status information. Signed-off-by: Luiz Capitulino --- monitor.c | 33 +++-- 1 files changed, 27 insertions(+), 6 deletions(-) diff --git a/monitor.c b/monitor.c index e3368c8..c9104c3 100644 --- a/monitor.c +++ b/monitor.c @@ -1678,16 +1678,3

[Qemu-devel] [PATCH 05/17] monitor: Fix do_info_balloon() output

New monitor commands should always return values in bytes. Signed-off-by: Luiz Capitulino --- monitor.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/monitor.c b/monitor.c index 3286ba2..e3368c8 100644 --- a/monitor.c +++ b/monitor.c @@ -1702,12 +1702,18 @@

[Qemu-devel] [PATCH 04/17] QDict: Introduce qdict_get_qlist()

A helper function to get a QList from a QDict. Signed-off-by: Luiz Capitulino --- Makefile |2 +- qdict.c | 13 + qdict.h |2 ++ 3 files changed, 16 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index 8b4c4e6..89fbdc6 100644 --- a/Makefile +++ b/Makefile

[Qemu-devel] [PATCH 03/17] QDict: Introduce qdict_get_qbool()

This is a helper function that does type checking before retrieving a QBool from the dictionary. Signed-off-by: Luiz Capitulino --- Makefile |2 +- qdict.c | 15 +++ qdict.h |1 + 3 files changed, 17 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index 35

[Qemu-devel] [PATCH v1 00/17]: info handlers conversions to QObject

Hi, This series covers almost half of the info handlers conversions to the QObject style, the other half is a bit more complicated as some handlers can be defined by different machine types. changelog - v0 -> v1 - Minor fixes (indentation, casts, etc) - Improved some documentation and

[Qemu-devel] [PATCH 02/17] Makefile: move QObject objs to their own entry

Other subsystems will need to link against them. Signed-off-by: Luiz Capitulino --- Makefile |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 7843690..35238f5 100644 --- a/Makefile +++ b/Makefile @@ -82,6 +82,11 @@ ALL_SUBDIRS=$(TARGET_DIR

[Qemu-devel] [PATCH 01/17] Introduce qemu-objects.h header file

An easy way to include all QEMU objects. Signed-off-by: Luiz Capitulino --- qemu-objects.h | 24 1 files changed, 24 insertions(+), 0 deletions(-) create mode 100644 qemu-objects.h diff --git a/qemu-objects.h b/qemu-objects.h new file mode 100644 index 000..e1d1e

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

Eduardo Habkost wrote: On Mon, Nov 23, 2009 at 12:28:16PM -0600, Anthony Liguori wrote: Eduardo Habkost wrote: That may be good enough for upstream Qemu, but IMO for RHEL it is not a realistic policy. If the definition of "guest visible state" is buggy on the current implementation, we

Re: [Qemu-devel] Re: POST failure (loop) with isapc and seabios

On Mon, Nov 23, 2009 at 08:19:54PM +0100, Sebastian Herbszt wrote: > Gleb Natapov wrote: > >On Sun, Nov 22, 2009 at 09:01:45PM +0100, Sebastian Herbszt wrote: > >>Gleb Natapov wrote: > >>>On Sun, Nov 22, 2009 at 04:31:24PM +0100, Sebastian Herbszt wrote: > > Bad things could happen if some

[Qemu-devel] Re: [PATCH][SEABIOS] Make SMBIOS table pass MS SVVP test

On Mon, Nov 23, 2009 at 07:48:20PM +0100, Sebastian Herbszt wrote: > What about using the vendor provided by CPUID, so it displays the correct > value on coreboot and others, and > change qemu cpus to a different vendor string like padded QEMU or something. > Currently qemu64 uses AMD, > kvm64 an

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

On Mon, Nov 23, 2009 at 12:28:16PM -0600, Anthony Liguori wrote: > Eduardo Habkost wrote: >> That may be good enough for upstream Qemu, but IMO for RHEL it is not a >> realistic policy. If the definition of "guest visible state" is buggy on >> the current implementation, we can't drop entirely the

Re: [Qemu-devel] Re: POST failure (loop) with isapc and seabios

Gleb Natapov wrote: On Sun, Nov 22, 2009 at 09:01:45PM +0100, Sebastian Herbszt wrote: Gleb Natapov wrote: >On Sun, Nov 22, 2009 at 04:31:24PM +0100, Sebastian Herbszt wrote: >> >>Bad things could happen if someone modifies the BIOS because it's unprotected >>(e.g. VM crash). >> >BIOS is reloade

Re: [Qemu-devel] Re: POST failure (loop) with isapc and seabios

On Mon, Nov 23, 2009 at 08:12:32PM +0100, Sebastian Herbszt wrote: > Gleb Natapov wrote: > >On Mon, Nov 23, 2009 at 06:57:47PM +0100, Sebastian Herbszt wrote: > >>Gleb Natapov wrote: > >>>On Sun, Nov 22, 2009 at 10:38:42AM -0500, Kevin O'Connor wrote: > On Sun, Nov 22, 2009 at 05:10:53PM +0200,

Re: [Qemu-devel] Re: POST failure (loop) with isapc and seabios

Gleb Natapov wrote: On Mon, Nov 23, 2009 at 06:57:47PM +0100, Sebastian Herbszt wrote: Gleb Natapov wrote: >On Sun, Nov 22, 2009 at 10:38:42AM -0500, Kevin O'Connor wrote: >>On Sun, Nov 22, 2009 at 05:10:53PM +0200, Gleb Natapov wrote: >>> On Sun, Nov 22, 2009 at 04:07:56PM +0100, Sebastian Herb

Re: [Qemu-devel] [PATCH] Makefile: Add missing rule for config-devices.mak

On Sunday 22 November 2009, Stefan Weil wrote: > All files config-devices.mak are copies from files in > directory default-configs. See commit a992fe3, specifically "make defconfig". Paul

[Qemu-devel] Re: [PATCH][SEABIOS] Make SMBIOS table pass MS SVVP test

Gleb Natapov wrote: On Mon, Nov 23, 2009 at 07:15:55PM +0100, Sebastian Herbszt wrote: Gleb Natapov wrote: >On Sun, Nov 22, 2009 at 09:41:26PM +0100, Sebastian Herbszt wrote: >>Gleb Natapov wrote: >>>On Sun, Nov 22, 2009 at 06:39:16PM +0100, Sebastian Herbszt wrote: Gleb Natapov wrote: >

Re: [Qemu-devel] Re: virtio: Report new guest memory statistics pertinent to memory ballooning (V4)

Avi Kivity wrote: The new monitor will support async command completion but even then I don't think we should allow a guest to stop command execution indefinitely (it would tie up resources at the client). Well, I think we're going to end up pushing this to 0.13 as we're quickly approaching t

[Qemu-devel] Re: [PATCH 0/3 v5] Live migration without shared storage

Avi Kivity wrote: > On 11/03/2009 11:40 AM, Liran Schour wrote: >> - Liran >> >> Avi Kivity wrote on 02/11/2009 20:47:34: >> >>> On 11/02/2009 03:40 PM, lir...@il.ibm.com wrote: >>> This series adds support for live migration without shared storage, >> means >> co

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

Juan Quintela wrote: The problem here isn't migration, it's what you've decided to backport into your stable branch. No. the problem is that I made a mistake in the past. And didn't add a field to the state that I should. It just happens to work without that field in several use cases.

Re: [Qemu-devel] seabios: missing DMI type 4 entry if -cpu parameter is used

Gleb Natapov wrote: On Sun, Nov 22, 2009 at 06:05:02PM +0100, Sebastian Herbszt wrote: v0.11.0-rc0-1677: use -cpu pentium and check SMBIOS tables. DMI type 4 entry is missing. Works with Bochs bios. See two problems here. First one in seabios (patch attached). And the second one in QEMU. Why p

[Qemu-devel] Re: [PATCH][SEABIOS] Make SMBIOS table pass MS SVVP test

On Mon, Nov 23, 2009 at 07:15:55PM +0100, Sebastian Herbszt wrote: > Gleb Natapov wrote: > >On Sun, Nov 22, 2009 at 09:41:26PM +0100, Sebastian Herbszt wrote: > >>Gleb Natapov wrote: > >>>On Sun, Nov 22, 2009 at 06:39:16PM +0100, Sebastian Herbszt wrote: > Gleb Natapov wrote: > >On Sun, Nov

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

Eduardo Habkost wrote: That may be good enough for upstream Qemu, but IMO for RHEL it is not a realistic policy. If the definition of "guest visible state" is buggy on the current implementation, we can't drop entirely the possibility of fixing it on our stable branch. After mulling over it

[Qemu-devel] Re: [PATCH][SEABIOS] Make SMBIOS table pass MS SVVP test

Gleb Natapov wrote: On Sun, Nov 22, 2009 at 09:41:26PM +0100, Sebastian Herbszt wrote: Gleb Natapov wrote: >On Sun, Nov 22, 2009 at 06:39:16PM +0100, Sebastian Herbszt wrote: >>Gleb Natapov wrote: >>>On Sun, Nov 22, 2009 at 05:51:41PM +0100, Sebastian Herbszt wrote: Gleb Natapov wrote: >

Re: [Qemu-devel] Re: POST failure (loop) with isapc and seabios

On Mon, Nov 23, 2009 at 06:57:47PM +0100, Sebastian Herbszt wrote: > Gleb Natapov wrote: > >On Sun, Nov 22, 2009 at 10:38:42AM -0500, Kevin O'Connor wrote: > >>On Sun, Nov 22, 2009 at 05:10:53PM +0200, Gleb Natapov wrote: > >>> On Sun, Nov 22, 2009 at 04:07:56PM +0100, Sebastian Herbszt wrote: > >>

Re: [Qemu-devel] Re: [PATCH][SEABIOS] Make SMBIOS table pass MS SVVP test

Gleb Natapov wrote: On Mon, Nov 23, 2009 at 12:57:14AM +0100, Carl-Daniel Hailfinger wrote: On 22.11.2009 18:39, Sebastian Herbszt wrote: > Gleb Natapov wrote: >> On Sun, Nov 22, 2009 at 05:51:41PM +0100, Sebastian Herbszt wrote: >>> Is the requirement for "Targeted Content Delivery" specified >

Re: [Qemu-devel] Re: POST failure (loop) with isapc and seabios

Gleb Natapov wrote: On Sun, Nov 22, 2009 at 10:38:42AM -0500, Kevin O'Connor wrote: On Sun, Nov 22, 2009 at 05:10:53PM +0200, Gleb Natapov wrote: > On Sun, Nov 22, 2009 at 04:07:56PM +0100, Sebastian Herbszt wrote: > > Gleb Natapov wrote: > > >May be make qemu to map it writable if isapc is spec

[Qemu-devel] Re: [PATCHv2][SEABIOS] Make SMBIOS table pass MS SVVP test

On 11/23/2009 01:03 PM, Gleb Natapov wrote: p->bios_characteristics[0] = 0x08; /* BIOS characteristics not supported */ FWIW, I agree with not changing this. From reading the spec, it seems like the characteristics extensions are totally separate from the basic characteristics, and set

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

Excerpts from Anthony Liguori's message of Mon Nov 23 14:16:39 -0200 2009: > Eduardo Habkost wrote: > > Excerpts from Anthony Liguori's message of Mon Nov 23 12:49:23 -0200 2009: > >>> > >> In our own stable branch, we do not introduce any savevm changes. I > >> would recommend the same p

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

Juan Quintela wrote: you can weasel the way you want (I can also do it). Customer had: 5.4 <-> 5.4 migration working (suboptimally) Now appears 5.4.1 that works best with migration. But he want to do the migration in two steps: migrate from qemu 5.4 -> 5.4.1, and be able to migrate back if he

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

Gleb Natapov wrote: I am OK with management being responsible to sort things out. Juan said that destination can't abort migration in the middle, so I pointed out easy solution that will work in 99.999% cases. I think there's something elegant about doing migration in a unidirectional strea

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

Eduardo Habkost wrote: Excerpts from Anthony Liguori's message of Mon Nov 23 12:49:23 -0200 2009: Juan Quintela wrote: But if you know substitute qemu-0.11 and qemu-0.12 for RHEL5.4 and RHEL5.4.1, you will see that the code bases are going to be really, really similar. And if any savev

Re: [Qemu-devel] [PATCH 00/10]: QError v4

Luiz Capitulino writes: > On Sat, 21 Nov 2009 11:02:41 +0100 > Markus Armbruster wrote: > >> Now, what should a client do when it discovers the monitor command it >> needs to use has grown a new error? Refuse to use the command for fear >> of having to present a sub-par error message to the use

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

On Mon, Nov 23, 2009 at 10:09:15AM -0600, Anthony Liguori wrote: > Gleb Natapov wrote: > >On Mon, Nov 23, 2009 at 09:32:48AM -0600, Anthony Liguori wrote: > >>Gleb Natapov wrote: > >>>On Mon, Nov 23, 2009 at 09:05:58AM -0600, Anthony Liguori wrote: > Gleb Natapov wrote: > >Then I don't see

Re: [Qemu-devel] [PATCH 1/9] chardev: add greeting

On 11/23/09 16:20, Anthony Liguori wrote: Gerd Hoffmann wrote: On 11/23/09 14:26, Paul Brook wrote: I thinking more that this should be done by the character backend itself. For example, the "graphical" consoles should probably be putting this as part of the window title Doesn't work with vnc

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

Gleb Natapov wrote: According to Anthony this is not a bug. Management has all the means to resolve this situation properly. The bug would be if dst and src both run or both exit. Yup. And they do. If you do the same migration with libvirt, it will fail gracefully with a -1 in the post_lo

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

Gleb Natapov wrote: On Mon, Nov 23, 2009 at 09:32:48AM -0600, Anthony Liguori wrote: Gleb Natapov wrote: On Mon, Nov 23, 2009 at 09:05:58AM -0600, Anthony Liguori wrote: Gleb Natapov wrote: Then I don't see why Juan claims what he claims. Live migration is

Re: [Qemu-devel] [PATCH 00/10]: QError v4

Anthony Liguori writes: > Markus Armbruster wrote: >> I'm thinking and talking primarily about the protocol, and that probably >> makes me too terse on implementation. >> >> I didn't mean to suggest that for adding the data part we should add new >> arguments providing the data. That would be du

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

On Mon, Nov 23, 2009 at 05:01:58PM +0100, Juan Quintela wrote: > Anthony Liguori wrote: > > Gleb Natapov wrote: > > My problem implementing optional features/sections/... is not the > > savevm/VMState bits. At the end, implementing that is easy. What is > > more dificult is once that

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

On Mon, Nov 23, 2009 at 09:32:48AM -0600, Anthony Liguori wrote: > Gleb Natapov wrote: > >On Mon, Nov 23, 2009 at 09:05:58AM -0600, Anthony Liguori wrote: > >>Gleb Natapov wrote: > >>>Then I don't see why Juan claims what he claims. > >>Live migration is unidirectional. As long as qemu can send ou

Re: [Qemu-devel] [PATCH 12/17] char: Convert qemu_chr_info() to QObject

Luiz Capitulino writes: > On Fri, 20 Nov 2009 15:10:20 +0100 > Markus Armbruster wrote: > >> Luiz Capitulino writes: >> >> > Each device is represented by a QDict. The returned QObject is a QList >> > of all devices. >> > >> > This commit should not change user output. >> > >> > Signed-off-by:

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

On Mon, Nov 23, 2009 at 09:00:05AM -0600, Anthony Liguori wrote: > > I think the problem is that you shouldn't be changing the guest visible > state in a stable update of qemu. If you change the guest visible state > in a stable update, then you won't be able to support live migration > bet

Re: [Qemu-devel] [PATCH 11/17] block: Convert bdrv_info() to QObject

Luiz Capitulino writes: > On Fri, 20 Nov 2009 15:06:26 +0100 > Markus Armbruster wrote: > >> Luiz Capitulino writes: [...] >> > diff --git a/block.c b/block.c >> > index 6fdabff..fc4e2f2 100644 >> > --- a/block.c >> > +++ b/block.c [...] >> > -monitor_printf(mon, " removable=%d", bs->re

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

Gleb Natapov wrote: On Mon, Nov 23, 2009 at 09:05:58AM -0600, Anthony Liguori wrote: Gleb Natapov wrote: Then I don't see why Juan claims what he claims. Live migration is unidirectional. As long as qemu can send out all of the data without the stream closing, it will "succeed"

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

On 11/23/2009 04:22 PM, Gleb Natapov wrote: As far as I remember the two general's problem talks about unreliable channel, not unreliable nodes. Why not having destination send ACK/NACK to the source when it knows that migration succeeded/failed. If source gets NACK it continues, if it gets ACK i

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

Excerpts from Anthony Liguori's message of Mon Nov 23 12:49:23 -0200 2009: > Juan Quintela wrote: > > But if you know substitute qemu-0.11 and qemu-0.12 for RHEL5.4 and > > RHEL5.4.1, you will see that the code bases are going to be really, > > really similar. And if any savevm format is changed,

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

On Mon, Nov 23, 2009 at 09:05:58AM -0600, Anthony Liguori wrote: > Gleb Natapov wrote: > >Then I don't see why Juan claims what he claims. > > Live migration is unidirectional. As long as qemu can send out all > of the data without the stream closing, it will "succeed" on the > source. While thi

Re: [Qemu-devel] [PATCH 1/9] chardev: add greeting

Gerd Hoffmann wrote: On 11/23/09 14:26, Paul Brook wrote: I thinking more that this should be done by the character backend itself. For example, the "graphical" consoles should probably be putting this as part of the window title Doesn't work with vnc. A vc is what renders the for VNC so

Re: [Qemu-devel] [PATCH 1/9] chardev: add greeting

On Mon, Nov 23, 2009 at 04:10:48PM +0100, Gerd Hoffmann wrote: > On 11/23/09 14:26, Paul Brook wrote: > >I thinking more that this should be done by the character backend itself. > >For > >example, the "graphical" consoles should probably be putting this as part > >of > >the window title > > Do

Re: [Qemu-devel] [PATCH 1/9] chardev: add greeting

On Monday 23 November 2009, Gerd Hoffmann wrote: > On 11/23/09 14:26, Paul Brook wrote: > > I thinking more that this should be done by the character backend itself. > > For example, the "graphical" consoles should probably be putting this as > > part of the window title > > Doesn't work with vnc

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

Eduardo Habkost wrote: The pvclock MSRs are an example: if the guest is not using pvclock, not restoring the MSRs won't make any difference. Strictly speaking, not migrating them is wrong, but the user may argue that they know it won't impact their guest OS, and that they want to take the risk.

Re: [Qemu-devel] [PATCH 1/9] chardev: add greeting

On 11/23/09 14:26, Paul Brook wrote: I thinking more that this should be done by the character backend itself. For example, the "graphical" consoles should probably be putting this as part of the window title Doesn't work with vnc. cheers, Gerd

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

Gleb Natapov wrote: Then I don't see why Juan claims what he claims. Live migration is unidirectional. As long as qemu can send out all of the data without the stream closing, it will "succeed" on the source. While this may sound like a bug, it's an impossible problem to solve as it's d

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

On Mon, Nov 23, 2009 at 03:21:24PM +0100, Paolo Bonzini wrote: > On 11/23/2009 02:51 PM, Eduardo Habkost wrote: >> Right, but I wouldn't be surprised if a user complains that "I know that >> my guest don't use that VM feature, so I want to be able to migrate to >> an older version anyway". > > That

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

Paolo Bonzini wrote: On 11/23/2009 02:51 PM, Eduardo Habkost wrote: Right, but I wouldn't be surprised if a user complains that "I know that my guest don't use that VM feature, so I want to be able to migrate to an older version anyway". That's a bit more tricky. What if the older version doe

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

On Mon, Nov 23, 2009 at 08:51:17AM -0600, Anthony Liguori wrote: > Gleb Natapov wrote: > My problem implementing optional features/sections/... is not the > savevm/VMState bits. At the end, implementing that is easy. What is > more dificult is once that a device have 5 features, what

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

Eduardo Habkost wrote: Migration needs to be conservative. There should be only two possible outcomes: 1) a successful live migration or 2) graceful failure with the source VM still running correctly. Silently ignoring things that could affect the guests behavior means that it's possible that aft

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

Gleb Natapov wrote: My problem implementing optional features/sections/... is not the savevm/VMState bits. At the end, implementing that is easy. What is more dificult is once that a device have 5 features, what are the valid combinations. i.e. if you have pci and msix features, msix requires

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

Juan Quintela wrote: Anthony Liguori wrote: Juan Quintela wrote: I'm not at all convinced that you can downgrade the version of a device without exposing a functional change to a guest. In fact, I'm pretty certain that it's provably impossible. Please give a counter example of w

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

On Mon, Nov 23, 2009 at 03:09:35PM +0100, Juan Quintela wrote: > Gleb Natapov wrote: > > On Mon, Nov 23, 2009 at 01:25:32PM +0100, Juan Quintela wrote: > >> Gleb Natapov wrote: > >> > On Sun, Nov 22, 2009 at 08:17:46PM -0600, Anthony Liguori wrote: > > > Yes, I proposed to send device state in m

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

On 11/23/2009 02:51 PM, Eduardo Habkost wrote: Right, but I wouldn't be surprised if a user complains that "I know that my guest don't use that VM feature, so I want to be able to migrate to an older version anyway". That's a bit more tricky. What if the older version doesn't support sound (j

[Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

Anthony Liguori wrote: > Juan Quintela wrote: >> Dor Laor wrote: >>> >> >> My idea here is that we need to have further use of machine >> descriptions, once that is done, we need something like a new property >> for qdev (version?). Once there, each device could do: >> - if version != last_

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

Excerpts from Anthony Liguori's message of Mon Nov 23 00:17:46 -0200 2009: > Paolo Bonzini wrote: > > > >> I don't see how this fixes anything. If you used feature bits, how do > >> you migrate from a version that has a feature bit that an older version > >> doesn't know about? Do you just ignore i

Re: [Qemu-devel] [PATCH 00/10]: QError v4

Am 23.11.2009 um 14:34 schrieb Luiz Capitulino : On Mon, 23 Nov 2009 07:11:53 -0600 Anthony Liguori wrote: Luiz Capitulino wrote: On Sun, 22 Nov 2009 10:08:16 -0600 Anthony Liguori wrote: I'm certainly willing to consider alternative ways to do qmp_error () but taking a free form string

Re: [Qemu-devel] Re: Live migration protocol, device features, ABIs and other beasts

Paolo Bonzini wrote: On 11/23/2009 03:17 AM, Anthony Liguori wrote: You mean, each device would have multiple sections? We already use chunks for each device state. If they want to, yes. We only migrate things that are guest visible. Everything else is left to the user to configure. We wo

Re: [Qemu-devel] [PATCH 00/10]: QError v4

On Mon, 23 Nov 2009 07:11:53 -0600 Anthony Liguori wrote: > Luiz Capitulino wrote: > > On Sun, 22 Nov 2009 10:08:16 -0600 > > Anthony Liguori wrote: > > > > > >> I'm certainly willing to consider alternative ways to do qmp_error() but > >> taking a free form string is not an option in my min

[Qemu-devel] Re: [PATCH 13/17] PCI: Convert pci_device_hot_add() to QObject

On Mon, 23 Nov 2009 11:44:57 +0200 "Michael S. Tsirkin" wrote: > On Tue, Nov 17, 2009 at 06:32:20PM -0200, Luiz Capitulino wrote: > > Return a QDict with information about the just added device. > > > > This commit should not change user output. > > > > Please, note that this patch does not do

Re: [Qemu-devel] [PATCH 1/9] chardev: add greeting

On Monday 23 November 2009, Gerd Hoffmann wrote: > On 11/20/09 18:41, Paul Brook wrote: > > On Tuesday 17 November 2009, Gerd Hoffmann wrote: > >> Add a greeting string to CharDriverState which is printed after > >> initialization. Used to have the qemu vc consoles labeled. This > >> way we can a

Re: [Qemu-devel] [PATCH 12/17] char: Convert qemu_chr_info() to QObject

On Fri, 20 Nov 2009 15:10:20 +0100 Markus Armbruster wrote: > Luiz Capitulino writes: > > > Each device is represented by a QDict. The returned QObject is a QList > > of all devices. > > > > This commit should not change user output. > > > > Signed-off-by: Luiz Capitulino > > --- > > monitor.

Re: [Qemu-devel] [PATCH 11/17] block: Convert bdrv_info() to QObject

On Fri, 20 Nov 2009 15:06:26 +0100 Markus Armbruster wrote: > Luiz Capitulino writes: > > > Each block device information is stored in a QDict and the > > returned QObject is a QList of all devices. > > > > This commit should not change user output. > > > > Signed-off-by: Luiz Capitulino > > -

  1   2   >