On Mon, Nov 23, 2009 at 12:28:16PM -0600, Anthony Liguori wrote: > Eduardo Habkost wrote: >> That may be good enough for upstream Qemu, but IMO for RHEL it is not a >> realistic policy. If the definition of "guest visible state" is buggy on >> the current implementation, we can't drop entirely the possibility of >> fixing it on our stable branch. >> > > After mulling over it a bit, here's what I'd suggest: > > 1) Integrate VMstate with qdev > 2) Introduce a bitmap blacklist for unsupported VMstate versions > 3) Expose that bitmap as a qdev property for each device. > 4) By default, upstream qemu will always set the bitmap to be 100% correct. > > This provides a mechanism for informed users and downstreams to reduce > correctness in favor of migration compatibility on a case-by-case basis.
Is this for backward migration? (I suppose so, as forward migration is already handled by the usual version_id checks on the *_load() functions). If so, even with this bitmap, how would the migration source process know which version it should use when generating the savevm data? (considering that the migration stream is unidirectional, today) We have been considering using a "set-savevm-version" monitor command that would be used by management if backward migration is forced by the user. BTW, we still have the "machine type" suggestion, that would still keep guest-visible state correctness and allow backward migration when it is 100% correct and safe. With such mechanism, VMs created with the x.y.1 machine type could be safely migrated from x.y.2 to x.y.1. (Althought the bitmap suggestion could have some use even on this case, if the user really wants to force migration of a x.y.2 machine to x.y.1). > > This takes qemu out of the business of creating these sort of policies > but allows RHEL to make decisions about what default policy it uses. It > also lets well informed users of RHEL to override those policy decisions > when they deem it to be appropriate. > > This would make me happy both from an upstream qemu perspective but also > as a consumer of RHEL. What about the suggestion of using multiple sections per device, every time a new feature is added, instead of just increasing the version numbers linearly? It allows us to keep the savevm version info consistent on the multiple downstream trees. Suppose we have the following scenario: 1) Device Foo has features A, B, C on "foo" section, sets version to 1 2) Downstream tree (e.g. RHEL) is branched off upstream 3) Device Foo adds support to feature D, version change to 2 5) Device Foo adds support to feature E, version changed to 3 6) Feature E is backported to a downstream tree. Now it supports features A,B,C,E, and its versioning scheme will be incompatible with upstream. What I suggest is something like: 1) Device Foo has features A,B,C, on "foo" section (or maybe on "foo.a", "foo.b", and "foo.c" sections, depending if they make sense individually) 2) Device Foo adds support to feature D, adds "foo.d" section 3) Device Foo adds support to feature E, adds "foo.e" section Each section will still have its version number as usual (for cases where a feature is changed in a incompatible way), but the point is that independent features get stored on different sections. -- Eduardo
