Aurelien Jarno wrote:
That's the problem. We have seen that people already take advantage of
the ambiguities, as I would have never have imagined someone writing the
code in the rationale of this patch to avoid putting braces.
I appreciate the desire to be precise, but we aren't writing a co
On Mon, Oct 26, 2009 at 10:11:07AM +0100, Laurent Desnogues wrote:
> On Mon, Oct 26, 2009 at 8:46 AM, wrote:
> >
> > On Oct 25, 2009, at 16:01, ext Laurent Desnogues wrote:
> >
> >> I don't really like the idea of having tcg_qemu_ld/st not factored
> >> in some place, as it makes memory access tr
Serial frames always start with a start bit.
This bit was missing in frame size calculation.
Signed-off-by: Stefan Weil
---
hw/serial.c |8 +---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/hw/serial.c b/hw/serial.c
index eb14f11..7552fee 100644
--- a/hw/serial.c
+++ b/
On Mon, Oct 26, 2009 at 10:20:34PM +0200, Blue Swirl wrote:
> On Mon, Oct 26, 2009 at 10:03 PM, Aurelien Jarno wrote:
> > On Mon, Oct 26, 2009 at 06:02:52PM +0200, Blue Swirl wrote:
> >> On Mon, Oct 26, 2009 at 8:26 AM, Aurelien Jarno
> >> wrote:
> >> > Rationale: The following code is difficult
Amit Shah wrote:
> On (Mon) Oct 26 2009 [08:40:12], Jan Kiszka wrote:
>> Amit Shah wrote:
>>> On (Sat) Oct 24 2009 [12:36:54], Jan Kiszka wrote:
Amit Shah wrote:
> The OPENED event gets sent also when qemu resets its state initially.
> The consumers of the event aren't interested in re
On Mon, Oct 26, 2009 at 10:03 PM, Aurelien Jarno wrote:
> On Mon, Oct 26, 2009 at 06:02:52PM +0200, Blue Swirl wrote:
>> On Mon, Oct 26, 2009 at 8:26 AM, Aurelien Jarno wrote:
>> > Rationale: The following code is difficult to read, but allowed by the
>> > current coding style.
>>
>> Fully agree.
On Mon, Oct 26, 2009 at 06:02:52PM +0200, Blue Swirl wrote:
> On Mon, Oct 26, 2009 at 8:26 AM, Aurelien Jarno wrote:
> > Rationale: The following code is difficult to read, but allowed by the
> > current coding style.
>
> Fully agree.
>
> > +Every control flow statement is followed by a new inde
On Sat, Oct 24, 2009 at 11:23:43AM +0800, TeLeMan wrote:
> On Sat, Oct 24, 2009 at 02:58, Stefan Weil wrote:
> > Is patch 4 (call handling) needed, or is it an optimization?
> > If it is needed, the tcg disassembler has to be extended as well.
>
> In fact tci has no stack and robber registers and
On Mon, Oct 26, 2009 at 04:43:11PM -0200, Marcelo Tosatti wrote:
> > On Thu, Oct 22, 2009 at 06:57:27PM -0200, Marcelo Tosatti wrote:
> > > On Thu, Oct 22, 2009 at 02:00:15PM +0200, Michael S. Tsirkin wrote:
> > > > Hi!
> > > > I'm sometimes getting segfaults when I kill qemu.
> > > > This time I c
> On Thu, Oct 22, 2009 at 06:57:27PM -0200, Marcelo Tosatti wrote:
> > On Thu, Oct 22, 2009 at 02:00:15PM +0200, Michael S. Tsirkin wrote:
> > > Hi!
> > > I'm sometimes getting segfaults when I kill qemu.
> > > This time I caught it when qemu was under gdb:
> > >
> > >
> > > Program received sign
Since there is an ioctl that tells us which msrs are available,
use it. This saves us from the need of functions like has_star(),
lm_capable(), etc.
Signed-off-by: Glauber Costa
CC: Marcelo Tosatti
CC: Avi Kivity
---
target-i386/kvm.c | 200 ++--
Avi Kivity wrote:
On 10/14/2009 04:30 PM, Glauber Costa wrote:
Hello people,
As I promised, I am sending a very brief PoC wrt split devices and
in-kernel irqchip.
In this mail, I am including only the ioapic version for apreciation.
I also have i8259,
and apic will take me a little bit more.
On Sun, Oct 25, 2009 at 12:26:51PM +0200, Avi Kivity wrote:
> On 10/14/2009 04:30 PM, Glauber Costa wrote:
>> Hello people,
>>
>> As I promised, I am sending a very brief PoC wrt split devices and in-kernel
>> irqchip.
>> In this mail, I am including only the ioapic version for apreciation. I also
Avi Kivity wrote:
On 10/26/2009 05:49 PM, Anthony Liguori wrote:
A user starts a VM at a physical box. Everythings fine but he wants
to return to his workstation so he closes the window. He goes back
to his workstation and connects to a VNC server (on a different X
server). He wants to now
On 10/26/2009 05:49 PM, Anthony Liguori wrote:
Many applications minimize to the system tray without needing two
processes.
Minimizing or hiding the window are different use cases. Now, I'm not
100% convinced this use-case is absolutely required but historically,
it's always come up in disc
On Mon, Oct 26, 2009 at 8:26 AM, Aurelien Jarno wrote:
> Rationale: The following code is difficult to read, but allowed by the
> current coding style.
Fully agree.
> +Every control flow statement is followed by a new indented and braced
> +block; even if the block contains just one statement.
On Mon, 26 Oct 2009, Stefan Weil wrote:
> malc schrieb:
> >
> >
> > On Sun, 11 Oct 2009, Stefan Weil wrote:
> >> Stuart Brady schrieb:
> >>> On Mon, Sep 28, 2009 at 06:50:21PM +0200, Stefan Weil wrote:
> Please send patches / enhancements based on my latest
> version from git://repo.or.c
Avi Kivity wrote:
On 10/26/2009 05:04 PM, Anthony Liguori wrote:
Maybe slightly less than 100%. I meant a native GUI in the same
process as qemu, but talking to QObjects through a scripting language.
The trouble here is that if you want to support being able to close
the gui and open it aga
malc schrieb:
>
>
> On Sun, 11 Oct 2009, Stefan Weil wrote:
>> Stuart Brady schrieb:
>>> On Mon, Sep 28, 2009 at 06:50:21PM +0200, Stefan Weil wrote:
Please send patches / enhancements based on my latest
version from git://repo.or.cz/qemu/ar7.git.
>>> Just bug reports for now, unfortunate
Images with disk size 0 may be used for
VM snapshots, but not to save normal block data.
It is possible to create such images using
qemu-img, but opening them later fails.
So even "qemu-img info image.qcow2" is not
possible for an image created with
"qemu-img create -f qcow2 image.qcow2 0".
This
Hi list,
there's been a lot of discussion about abstraction of hardware devices
and machine description.
Last Saturday I've been running into some developers from the
University of Erlangen (FAU) who work on an x86 emulator, used to
simulate machine failures (memory bit flips, hard drive
* Allow any speed value which is defined for Linux
(and possibly other systems).
* Compare int values instead of double values.
Signed-off-by: Stefan Weil
---
qemu-char.c | 87 +-
1 files changed, 61 insertions(+), 26 deletions(-)
diff
On 10/26/2009 05:04 PM, Anthony Liguori wrote:
Maybe slightly less than 100%. I meant a native GUI in the same
process as qemu, but talking to QObjects through a scripting language.
The trouble here is that if you want to support being able to close
the gui and open it again without killing
Avi Kivity wrote:
I'd much rather see a real GUI client, perhaps implemented by
scripting QObjects or QMP.
I'm with you 100% here. I'd rather see our focus put into a proper
gui based on QMP than to tack on features to SDL.
Maybe slightly less than 100%. I meant a native GUI in the sam
Changes:
* We don't create/delete devices, we attach/detach them instead.
* The separate autofilter list is gone, we simply walk the list
of devices directly instead.
* Autofiltering is done unconditionally now. Non-auto device scan
code got dropped.
* Autofiltering turns off the timer
Hook up usb_msd_init.
Also rework handling of encrypted block devices,
move the code out vl.c.
Signed-off-by: Gerd Hoffmann
---
hw/usb-msd.c | 33 +
hw/usb.h |4
vl.c | 25 -
3 files changed, 25 insertions(+), 37 d
Signed-off-by: Gerd Hoffmann
---
hw/usb-bus.c |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/hw/usb-bus.c b/hw/usb-bus.c
index 87dcc7f..99d185e 100644
--- a/hw/usb-bus.c
+++ b/hw/usb-bus.c
@@ -226,9 +226,10 @@ static void usb_bus_dev_print(Monitor *mon, DeviceStat
Signed-off-by: Gerd Hoffmann
---
hw/baum.c |6
hw/baum.h |3 --
hw/usb-serial.c | 85 ++-
hw/usb.h|3 --
vl.c|6
5 files changed, 65 insertions(+), 38 deletions(-)
diff --git a/hw/bau
This patchs adds infrastructure to handle -usbdevice via qdev callbacks.
USBDeviceInfo gets a name field (for the -usbdevice driver name) and a
callback for -usbdevice parameter parsing.
The new usbdevice_create() function walks the qdev driver list and looks
for a usb driver with a matching name.
Signed-off-by: Gerd Hoffmann
---
hw/usb-hid.c |3 +++
hw/usb-wacom.c |1 +
vl.c | 29 -
3 files changed, 4 insertions(+), 29 deletions(-)
diff --git a/hw/usb-hid.c b/hw/usb-hid.c
index d1cc45e..f4a2a48 100644
--- a/hw/usb-hid.c
+++ b/hw/usb-hid.
Hi,
This patch series changes the way the -usbdevice switch (and the usb_add
monitor command) is handled. Instead of hard-coding stuff in vl.c it
is integrated with qdev by adding new fields to USBDeviceInfo. First
patch adds the infrastructure. Follwing patches switch over the usb
drivers to
Add a auto_attach field to USBDevice, which is enabled by default.
USB drivers can clear this field in case they do *not* want the device
being attached (i.e. plugged into a usb port) automatically after
successfull init().
Use cases (see next patches):
* attaching encrypted mass storage devices.
This is a slightly revised patch for adding readonly flag to the -drive command.
Even though this patch is "stand-alone", it assumes a previous related patch
(in Anthony staging tree), that passes
the readonly attribute of the drive to the guest OS, applied first.
This enables sharing same image
Fixes a couple of issues with msix table access:
- With misbehaving guests, misaligned 4 byte access could overflow
msix table and cause qemu to segfault. Since PCI spec requires
host to only issue dword-aligned accesses, as a fix,
it's enough to mask the address low bits.
- Tables use pci fo
On 10/26/2009 03:45 PM, Anthony Liguori wrote:
Avi Kivity wrote:
On 10/23/2009 03:59 PM, Anthony Liguori wrote:
Your answer may be, this is for a developer and they'll be aware of
all the short comings/gotchas but this ends up being a rather
user-hostile interface. People are never as aware o
Avi Kivity wrote:
On 10/23/2009 03:59 PM, Anthony Liguori wrote:
Your answer may be, this is for a developer and they'll be aware of
all the short comings/gotchas but this ends up being a rather
user-hostile interface. People are never as aware of short
comings/gotchas as we'd like them to be
On 10/26/2009 03:40 PM, Krumme, Chris wrote:
Well, it is. vlan=x really means "the ethernet segment named x". If
you connect all your guest nics to one vlan, you are
connecting them all
to one ethernet segment, so any packet transmitted on one will be
reflected on others.
Whether this is a u
> -Original Message-
> From:
> qemu-devel-bounces+chris.krumme=windriver@nongnu.org
> [mailto:qemu-devel-bounces+chris.krumme=windriver@nongnu.o
rg] On Behalf Of Avi Kivity
> Sent: Sunday, October 25, 2009 9:23 AM
> To: Mark McLoughlin
> Cc: Michael Tokarev; qemu-devel@nongnu.org;
According to SCSI-2 specification,
http://ldkelley.com/SCSI2/SCSI2/SCSI2/SCSI2-08.html#8.2.5 ,
"if the allocation length of the command descriptor block (CDB) is too
small to transfer
all of the parameters, the additional length shall not be adjusted to
reflect the truncation."
The 36 mandatory byt
Scott Tsai writes:
> I recently found that this chageset:
> http://git.savannah.gnu.org/cgit/qemu.git/commit/?id=e19eb22486f258a421108ac22b8380a4e2f16b97
> "net: make use of async packet sending API in tap client"
> causes NFS root Linux guest setups using TAP networking to fail with
> error mess
wmb must be at least a compiler barrier, even without SMP.
Further, we likely need some rmb()/mb() as well:
I have not audited the code but lguest has mb(),
add a comment for now.
Signed-off-by: Michael S. Tsirkin
---
hw/virtio.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
di
On Sun, Oct 25, 2009 at 06:49:44PM +0100, Jan-Simon Möller wrote:
> We encontered problems with the low default value for the stacksize in
> usermode (ok, whats "low").
> For environments like scratchbox, its hard to use "-s" as qemu is called by
> binfmt mechanism.
> The attached patch makes th
This patch migrates virtio-console to the qdev infrastructure and
creates a new virtio-serial bus on which multiple ports are exposed as
devices. The bulk of the code now resides in a new file with
virtio-console.c being just a simple qdev device.
This interface enables spawning of multiple virtio
The context parameter in paio_submit isn't used anyway, so there is no reason
why block drivers should need to remember it. This also avoids passing a Linux
AIO context to paio_submit (which doesn't do any harm as long as the parameter
is unused, but it is highly confusing).
Signed-off-by: Kevin W
This patch adds generic serial ports over the virtio serial bus.
These ports have a few more options that are not relevant for
virtio console ports: the ability to cache buffers that are
received for a port while it's disconnected, setting of limits
to the bytes that are cached so as to prevent OOM
Hello,
This iteration of the series fixes a style bug pointed out by Gerd and
a typo noticed by Rich.
In addition to that, it also introduces a few debug prints in the
'info qtree' output that shows some per-port data that could be
helpful for debugging.
I've been testing all the features that a
Hi,
A collection of rom loader bits, check individual patches for details.
One more change for rom_add_{vga,option}. We are simply using a
variable now to enable rom loading, so different TARGET_I386 machine
types can have different behavior here. pc98 support needs this.
cheers,
Gerd
The rom_add_vga() and rom_add_option() macros are transformed into
functions. They look at the new rom_enable_driver_roms variable
and only do something if it is set to non-zero, making vga+option rom
loading runtime option. pc_init() sets rom_enable_driver_roms to 1.
With this in place we can m
Am Sonntag 25 Oktober 2009 22:09:10 schrieb Juan Quintela:
> If we are changing the code in configure anyways, why don't add the
> default there?
>
> Something like this (I tested that it compiled, but didn't tested
> usermode). I am assuming that you only want it for linux-user.
I like this ver
On Mon, Oct 26, 2009 at 12:02 PM, wrote:
> From: Juha Riihimäki
>
> tmp4 and tmp5 temporary variables are allocated using tcg_const_i32
> but incorrectly released using dead_tmp which will cause resource
> leak tracking to report false leaks.
>
> Signed-off-by: Juha Riihimäki
Acked-by: Lauren
This patch adds a 'index' property to the isa-parallel and isa-serial
devices. This can be used to create devices with the default isa irqs
and ioports by simply specifying the index, i.e.
-device isa-serial,index=1
instead of
-device isa-serial,iobase=0x2f8,irq=3
for ttyS1 aka com2. Li
Signed-off-by: Gerd Hoffmann
---
hw/cirrus_vga.c |6 +-
hw/pc.c | 12
hw/vga-isa.c|3 +++
hw/vga-pci.c|4
hw/vga_int.h|2 ++
5 files changed, 14 insertions(+), 13 deletions(-)
diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c
index 9dfe76
The pc bios shows up in 'info roms' now.
Note that the BIOS is mapped to two places: The complete rom at the top
of the memory, and the first 128k at 0xe. Only the first place is
listed in 'info roms'.
Signed-off-by: Gerd Hoffmann
---
hw/pc.c |4 ++--
1 files changed, 2 insertions(+),
Signed-off-by: Gerd Hoffmann
---
hw/loader.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/loader.c b/hw/loader.c
index 7aa1a67..6baafa8 100644
--- a/hw/loader.c
+++ b/hw/loader.c
@@ -559,7 +559,7 @@ int rom_add_file(const char *file,
rom->name = qemu_strdup(f
From: Juha Riihimäki
tmp4 and tmp5 temporary variables are allocated using tcg_const_i32
but incorrectly released using dead_tmp which will cause resource
leak tracking to report false leaks.
Signed-off-by: Juha Riihimäki
---
target-arm/translate.c |4 ++--
1 files changed, 2 insertions(+)
On Oct 26, 2009, at 12:46, ext Laurent Desnogues wrote:
>> @@ -5511,8 +5539,9 @@ static int disas_neon_data_insn(CPUState *
>> env, DisasContext *s, uint32_t insn)
>>tcg_gen_movi_i32(tmp, 0);
>>}
>>tmp2 = neon_load_reg(rm, 0);
>> -
On Thu, Oct 22, 2009 at 1:17 PM, wrote:
> From: Juha Riihimäki
>
> Revised patch for getting rid of tcg temporary variable leaks in
> target-arm/translate.c. This version also includes the leak patch for
> gen_set_cpsr macro, now converted as a static inline function, which I
> sent earlier as a
On Mon, Oct 26, 2009 at 10:46 AM, wrote:
> From: Juha Riihimäki
>
> All other bits except for the EN in the VFP FPEXC register are defined
> as subarchitecture specific and real functionality for any of the
> other bits has not been implemented in QEMU. However, current code
> allows modifying a
From: Juha Riihimäki
All other bits except for the EN in the VFP FPEXC register are defined
as subarchitecture specific and real functionality for any of the
other bits has not been implemented in QEMU. However, current code
allows modifying all bits in the VFP FPEXC register leading to
problems
On (Mon) Oct 26 2009 [08:40:12], Jan Kiszka wrote:
> Amit Shah wrote:
> > On (Sat) Oct 24 2009 [12:36:54], Jan Kiszka wrote:
> >> Amit Shah wrote:
> >>> The OPENED event gets sent also when qemu resets its state initially.
> >>> The consumers of the event aren't interested in receiving this event
>
Looks fine to me. A similar solution could do for default mac address.
One little thing I missed on first reading: making an index property
hexadecimal is weird. I'd really expect decimal there.
Indeed. Wasn't intentional, cut+paste bug. Will fix.
cheers,
Gerd
On Mon, Oct 26, 2009 at 8:46 AM, wrote:
>
> On Oct 25, 2009, at 16:01, ext Laurent Desnogues wrote:
>
>> I don't really like the idea of having tcg_qemu_ld/st not factored
>> in some place, as it makes memory access tracing extensions
>> more intrusive.
>>
>> This brings us back to the problem ha
On Mon, Oct 26, 2009 at 8:32 AM, wrote:
[...]
>>
>> Shouldn't writes to FPEXC from gdb be protected in the same
>> way? Except for that I agree with your patch.
>
> Please correct me if I'm wrong but it seems to me that the code in
> gdbstub.c never writes anything to the VFP registers, at least
Markus Armbruster writes:
> Gerd Hoffmann writes:
>
>> This patch adds a 'index' property to the isa-parallel and isa-serial
>> devices. This can be used to create devices with the default isa irqs
>> and ioports by simply specifying the index, i.e.
>>
>>-device isa-serial,index=1
>>
>> ins
Am 25.10.2009 08:19, schrieb Christoph Hellwig:
> On Thu, Oct 22, 2009 at 11:05:55AM +0200, Kevin Wolf wrote:
>> Yes, it might look like overkill to introduce a abstraction for exactly
>> two backends. I felt the same way. But then, the current implementation
>> just feels totally wrong. It absolut
On Oct 25, 2009, at 16:01, ext Laurent Desnogues wrote:
> I don't really like the idea of having tcg_qemu_ld/st not factored
> in some place, as it makes memory access tracing extensions
> more intrusive.
>
> This brings us back to the problem having function freeing tmps.
> In that case, you cou
Amit Shah wrote:
> On (Sat) Oct 24 2009 [12:36:54], Jan Kiszka wrote:
>> Amit Shah wrote:
>>> The OPENED event gets sent also when qemu resets its state initially.
>>> The consumers of the event aren't interested in receiving this event
>>> on reset.
>> The monitor was. Now its initial prompt on ac
On Oct 25, 2009, at 14:23, ext Laurent Desnogues wrote:
> On Sat, Oct 24, 2009 at 1:19 PM, wrote:
>> From: Juha Riihimäki
>>
>> All other bits except for the EN in the VFP FPEXC register are
>> defined
>> as subarchitecture specific and real functionality for any of the
>> other bits has not
Hi,
I have compiled qemu 0.11.0 for x86 64 bit. I run Fedora Core 10 64 bit as
my guest OS.
Sometimes, when I shutdown the guest OS gracefully (using halt command), I
see a kernel crash with a stack trace on guest OS window at *
native_machine_shutdown()*. The RIP points to *native_smp_send_stop()*
From: Juha Riihimäki
Current code is broken at least on recent compilers, comparison
between signed and unsigned types yield incorrect code and render
the neon shift helper functions defunct. This is the third revision
of this patch, casting all comparisons with the sizeof operator to
signed ssiz
70 matches
Mail list logo
