Re: [Qemu-devel] bug report : kqemu and self-writing code

2006-05-01 Thread Kevin F. Quinn
Looks like SELinux to me. Even - you should raise it with whoever writes your policy. On Mon, 01 May 2006 23:29:54 +0200 Fabrice Bellard <[EMAIL PROTECTED]> wrote: > Are you sure that the bug is really in kqemu ? It is possible that > your guest kernel implements a security system which prevents

Re: [Qemu-devel] [PATCH] Separate alias_addr (10.0.2.2) from our_addr in slirp

2006-05-01 Thread Ed Swierk
On 5/1/06, Ben Taylor <[EMAIL PROTECTED]> wrote: Am I seeing a problem in line 98 of slirp/misc.c? Yes--thanks for finding that. An amended patch is attached. --Ed diff -BurN qemu.orig/slirp/ip_icmp.c qemu/slirp/ip_icmp.c --- qemu.orig/slirp/ip_icmp.c 2004-04-22 00:10:47.0 + +++ q

Re: [Qemu-devel] [PATCH] Fix scrambling of >32KB packets in slirp

2006-05-01 Thread Ed Swierk
On 5/1/06, Fabrice Bellard <[EMAIL PROTECTED]> wrote: Why not changing the definition itself to uint16_t and verifying each occurence of ip_off and ip_len ? Indeed, why not. This is the solution adopted by Apple's OpenDarwin (another BSD derivative). The attached patch changes the signed defini

Re: [Qemu-devel] [PATCH] Separate alias_addr (10.0.2.2) from our_addr in slirp

2006-05-01 Thread Ben Taylor
Ed Swierk <[EMAIL PROTECTED]> wrote: > On 5/1/06, Fabrice Bellard <[EMAIL PROTECTED]> wrote: > I am not sure this patch is sufficient: sometimes our_addr is used to > open socket on the host side and 10.0.2.2 has a meanning only on the VM > side. Indeed, our_addr seems to be used for two di

[Qemu-devel] [PATCH] Separate alias_addr (10.0.2.2) from our_addr in slirp

2006-05-01 Thread Ed Swierk
On 5/1/06, Fabrice Bellard <[EMAIL PROTECTED]> wrote: I am not sure this patch is sufficient: sometimes our_addr is used to open socket on the host side and 10.0.2.2 has a meanning only on the VM side. Indeed, our_addr seems to be used for two distinct purposes: - application protocol emulatio

Re: [Qemu-devel] bug report : kqemu and self-writing code

2006-05-01 Thread Even Rouault
You're absolutely right. SELinux was enabled on the host. I disabled it and now the self modying code runs with kqemu enabled. So, I guess the current behaviour of qemu (without kqemu) is not really wanted. Le Lundi 1 Mai 2006 23:29, Fabrice Bellard a écrit : > Are you sure that the bug is reall

[Qemu-devel] qemu vnc.c

2006-05-01 Thread Fabrice Bellard
CVSROOT:/sources/qemu Module name:qemu Branch: Changes by: Fabrice Bellard <[EMAIL PROTECTED]> 06/05/01 21:44:22 Modified files: . : vnc.c Log message: uppercase fix (Anthony Liguori) CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/qemu

Re: [Qemu-devel] [PATCH] Fix overflow conditions for MIPS add/subtract

2006-05-01 Thread Fabrice Bellard
The current code seems correct to me too (it is the same as the x86 "reference"). Fabrice. Stefan Weil wrote: Dirk Behme schrieb: > > Fix overflow conditions for MIPS add/subtract as proposed by > Daniel Jacobowitz. > > http://lists.gnu.org/archive/html/qemu-devel/2006-04/msg00538.html

Re: [Qemu-devel] bug report : kqemu and self-writing code

2006-05-01 Thread Fabrice Bellard
Are you sure that the bug is really in kqemu ? It is possible that your guest kernel implements a security system which prevents self modifying code using segment limits which QEMU does not check (but kqemu checks them !). Regards, Fabrice. Even Rouault wrote: Guest OS : Linux 2.6.15-1.2054

Re: [Qemu-devel] PATCH: solaris-sparc-slirp fix

2006-05-01 Thread Leonardo E. Reiter
Thanks for the explanation Fabrice... I guess I am not sure how to swap the host pixel format without taking a performance penalty. So for now I just offer the patch I made in case anyone else finds it useful for their own needs. Maybe I'll revisit this in the future when I have more time and co

[Qemu-devel] Feature request: -hda image file locks, and warnings for readonly

2006-05-01 Thread Troy Benjegerdes
I managed to make the mistake of starting up two instances of qemu using the same '-hda' win2k guest. Needless to say this rendered the image unbootable. What I'd like is for qemu to do some sort of optional (but default behavior) file lock on the disk image, and spit out a warning and refuse to s

[Qemu-devel] bug report : kqemu and self-writing code

2006-05-01 Thread Even Rouault
Guest OS : Linux 2.6.15-1.2054_FC5 i686 (Fedora Core 5 i386) Host OS: Linux 2.6.12-10-amd64-k8 #1 x86_64 (Ubuntu 5.10 amd64) QEMU Version : today CVS compiled with kqemu support KQEMU : 1.3.0pre6 Binary used : qemu-system-x86-64 (so kqemu user-mode is used) I'm running the simple C code attached.

[Qemu-devel] Patch submission policy? (was Re: [PATCH] SAMBA multi-share support

2006-05-01 Thread Stealth Dave
d to be the squeaky wheel. I've attached an updated patch the cleanly applies to current CVS. Please feel free to attach whatever license is necessary for distribution with QEMU. I welcome any feedback, and await an oil can or the junkyard. :) Regards, - Dave smb-multishare-20060501.

Re: [Qemu-devel] [PATCH] Fix overflow conditions for MIPS add/subtract

2006-05-01 Thread Daniel Jacobowitz
On Mon, May 01, 2006 at 08:42:08PM +0200, Stefan Weil wrote: > >- if (((tmp ^ T1 ^ (-1)) & (T0 ^ T1)) >> 31) { > >+ if (~(T0 ^ T1) & (T0 ^ tmp) & 0x8000) { > Hello Dirk, > > which additions / subtractions are handled incorrectly by the current code? > Here is the result of a test which shows

Re: [Qemu-devel] [PATCH] Fix scrambling of >32KB packets in slirp

2006-05-01 Thread Fabrice Bellard
Yes, I would prefer that you resubmit a patch using unsigned types. Fabrice. Kenneth Duda wrote: Well that is a good question. When I made this patch, I wanted to respect the comment in the code that the author felt that using a signed data type was safer in some cases. However, I will admit

Re: [Qemu-devel] [PATCH] Fix overflow conditions for MIPS add/subtract

2006-05-01 Thread Fabrice Bellard
OK. I hope this is correct now :-) Just a note : there is already a lot of code in QEMU to compute correctly the overflow and carry flags (for example in the i386 target)... don't spend your time on reinventing them ! Fabrice. Dirk Behme wrote: Fix overflow conditions for MIPS add/subtract

Re: [Qemu-devel] PATCH: solaris-sparc-slirp fix

2006-05-01 Thread Fabrice Bellard
Hi, I did not accept your patch for two reasons: 1) You changed the guest vga frame buffer format and I don't think this is what you wanted (it can be useful to emulate VGA on big endian guests though - the current implementation for ppc guests is a hack). What is needed is to swap the host p

Re: [Qemu-devel] [PATCH] Fix overflow conditions for MIPS add/subtract

2006-05-01 Thread Stefan Weil
Dirk Behme schrieb: > > Fix overflow conditions for MIPS add/subtract as proposed by > Daniel Jacobowitz. > > http://lists.gnu.org/archive/html/qemu-devel/2006-04/msg00538.html > > Regards > > Dirk > > > >--- target-mips/op.c

Re: [Qemu-devel] PATCH: solaris-sparc-slirp fix

2006-05-01 Thread Leonardo E. Reiter
Sorry, I should add that the automatic detection is only done for SDL. It should be easy enough to add to the VNC side of things, but I didn't get around to it yet. You can use the -bgr command-line option to qemu in the VNC case to set it manually. - Leo Reiter Leonardo E. Reiter wrote: > Ben

Re: [Qemu-devel] PATCH: solaris-sparc-slirp fix

2006-05-01 Thread Leonardo E. Reiter
Ben, You can use the patch I posted here recently to get QEMU to fix the BGR problem internally. It doesn't have to be done at the VNC level - and in fact, this way, you can use it on the Solaris native X server (or even SunRays) in 24-bit color mode. I am attaching a new version of the patch, c

Re: [Qemu-devel] [PATCH] Fix memory leaks in ELF loader

2006-05-01 Thread Fabrice Bellard
Why adding several labels ? qemu_free(NULL) is perfectly valid. I would just add the missing "qemu_free(phdr)" ... Fabrice. Dirk Behme wrote: Fix memory leaks in ELF loader. Regards Dirk --- elf_ops.h_orig 2006

[Qemu-devel] PATCH: solaris-sparc-slirp fix

2006-05-01 Thread Ben Taylor
The following patch, along with the previous solaris patch posted, booted DamnSmallLinux (x86) on a Sun Ultra10 Workstation running Solaris 9, using the -vnc display. Other than the colors being GBR instead of RGB (and I hear a fix for that in the vnc code is in development) it works. Ben--- q

[Qemu-devel] [PATCH] Fix overflow conditions for MIPS add/subtract

2006-05-01 Thread Dirk Behme
Fix overflow conditions for MIPS add/subtract as proposed by Daniel Jacobowitz. http://lists.gnu.org/archive/html/qemu-devel/2006-04/msg00538.html Regards Dirk --- target-mips/op.c_orig 2006-04-30 09:40:46.0 +0200 +++ target-mips/op.c2006-04-30 09:41:52.0 +0200 @@ -2

[Qemu-devel] [PATCH] Fix memory leaks in ELF loader

2006-05-01 Thread Dirk Behme
Fix memory leaks in ELF loader. Regards Dirk --- elf_ops.h_orig 2006-05-01 09:01:47.0 +0200 +++ elf_ops.h 2006-05-01 09:09:34.0 +0200 @@ -148,7 +148,7 @@ int glue(load_elf, SZ)(int fd, int64_t v uint8_t *data = NULL; if (read(fd, &ehdr, sizeof(ehdr)) != sizeo

Re: [Qemu-devel] PATCH: Solaris 9/sparc host patches

2006-05-01 Thread Ben Taylor
The attachment included this time... Ben Taylor <[EMAIL PROTECTED]> wrote: > > Here is a patch for qemu-CVS to allow qemu to be compiled under Solaris > 9/Sparc. > > the fixes are the following: > > vl.c: add a rtc for sparc (previously "Unsupported CPU") > Makefile/Makefile.target: co

Re: [Qemu-devel] [PATCH] Fix scrambling of >32KB packets in slirp

2006-05-01 Thread Kenneth Duda
Well that is a good question. When I made this patch, I wanted to respect the comment in the code that the author felt that using a signed data type was safer in some cases. However, I will admit that I do not understand this reasoning, and I agree that switching to an unsigned data type would b

[Qemu-devel] PATCH: Solaris 9/sparc host patches

2006-05-01 Thread Ben Taylor
Here is a patch for qemu-CVS to allow qemu to be compiled under Solaris 9/Sparc. the fixes are the following: vl.c: add a rtc for sparc (previously "Unsupported CPU") Makefile/Makefile.target: compile flags to enable proper compilation fpu/softfloat-native.c: extension of the _BSD functions and

[Qemu-devel] Re: [PATCH] Work around VNC clients that do not transmit shifts for uppercase characters

2006-05-01 Thread Anthony Liguori
Fabrice Bellard wrote: Does it mean that the caps lock keysym is not transmitted by RealVNC ? Otherwise converting the upper case to case lower case would suffice. You're right. New patch attached. Regards, Anthony Liguori Fabrice. Anthony Liguori wrote: The spec isn't really clear about

[Qemu-devel] [PATCH]USB tablet auto grab and ungrab

2006-05-01 Thread Scipio
With this patch, automatic grab keyboard and mouse when the mouse enters the window, and ungrab when the mouse reachs the window edge. I created this beacuse I want to close a window with ALT+F4 inside qemu, but I closed qemu window, because qemu is not grabbed. Scipio diff -u qemu.orig/sdl.c q

[Qemu-devel] qemu ./configure fpu/softfloat-native.h

2006-05-01 Thread Fabrice Bellard
CVSROOT:/sources/qemu Module name:qemu Branch: Changes by: Fabrice Bellard <[EMAIL PROTECTED]> 06/05/01 13:58:07 Modified files: . : configure fpu: softfloat-native.h Log message: Solaris port (Ben Taylor) CVSWeb URL

Re: [Qemu-devel] [PATCH] Improve -net user (slirp) performance by 4x

2006-05-01 Thread Fabrice Bellard
Fabrice Bellard wrote: Ed Swierk wrote: 3. qemu sleeps soundly while packets back up in slirp's buffers. slirp socket fds should be added to the main qemu select() loop to avoid unnecessary delays. I agree, but your patch does not suppress the slirp select(). I tried to do it with the follo

[Qemu-devel] qemu vl.c

2006-05-01 Thread Fabrice Bellard
CVSROOT:/sources/qemu Module name:qemu Branch: Changes by: Fabrice Bellard <[EMAIL PROTECTED]> 06/05/01 13:33:02 Modified files: . : vl.c Log message: use a single select for slirp and qemu sockets CVSWeb URLs: http://cvs.savannah.gnu.or

[Qemu-devel] qemu vl.c

2006-05-01 Thread Fabrice Bellard
CVSROOT:/sources/qemu Module name:qemu Branch: Changes by: Fabrice Bellard <[EMAIL PROTECTED]> 06/05/01 13:28:36 Modified files: . : vl.c Log message: workaround: force /dev/rtc usage on Linux CVSWeb URLs: http://cvs.savannah.gnu.org/vie

[Qemu-devel] qemu vl.c

2006-05-01 Thread Fabrice Bellard
CVSROOT:/sources/qemu Module name:qemu Branch: Changes by: Fabrice Bellard <[EMAIL PROTECTED]> 06/05/01 13:23:04 Modified files: . : vl.c Log message: better win32 timers - use win32 event to wake up cpu in idle mode (kazu) CVSWeb URLs:

[Qemu-devel] solaris configure and fpu/softfloat-native.h

2006-05-01 Thread Ben Taylor
This is a minimal patch to configure and fpu/softfloat-native.h to get qemu to compile and run on Solaris 10. Compile support for Solaris 9 and Sparc will be updated in a different patch. Bendiff -ruN qemu/configure qemu-solaris/configure --- qemu/configure 2006-04-29 19:05:22.0 -0400 +++

[Qemu-devel] qemu vl.c

2006-05-01 Thread Fabrice Bellard
CVSROOT:/sources/qemu Module name:qemu Branch: Changes by: Fabrice Bellard <[EMAIL PROTECTED]> 06/05/01 12:43:29 Modified files: . : vl.c Log message: fix for hosts resuming from software suspend (initial patch by John Coiner) CVSWeb UR

[Qemu-devel] qemu/hw pc.c

2006-05-01 Thread Fabrice Bellard
CVSROOT:/sources/qemu Module name:qemu Branch: Changes by: Fabrice Bellard <[EMAIL PROTECTED]> 06/05/01 12:31:24 Modified files: hw : pc.c Log message: increase max kernel size with initrd CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/

Re: [Qemu-devel] [PATCH] Allow -kernel without -hda

2006-05-01 Thread Fabrice Bellard
I agree that the feature is useful, but your patch is incomplete: without bs_table[0], the boot sector cannot be created and the Linux kernel cannot be launched. Maybe you have a specific Ethernet BIOS to enable that ? Someone submitted a new block driver which simulated "/dev/zero" and it may

Re: [Qemu-devel] [PATCH] Improve -net user (slirp) performance by 4x

2006-05-01 Thread Fabrice Bellard
Ed Swierk wrote: 3. qemu sleeps soundly while packets back up in slirp's buffers. slirp socket fds should be added to the main qemu select() loop to avoid unnecessary delays. I agree, but your patch does not suppress the slirp select(). I tried to do it with the following patch but slirp beco

[Qemu-devel] qemu/slirp tcp_input.c

2006-05-01 Thread Fabrice Bellard
CVSROOT:/sources/qemu Module name:qemu Branch: Changes by: Fabrice Bellard <[EMAIL PROTECTED]> 06/05/01 11:18:01 Modified files: slirp : tcp_input.c Log message: do not delay TCP acks (Ed Swierk) CVSWeb URLs: http://cvs.savannah.gnu.org/view

[Qemu-devel] qemu/slirp tcp.h

2006-05-01 Thread Fabrice Bellard
CVSROOT:/sources/qemu Module name:qemu Branch: Changes by: Fabrice Bellard <[EMAIL PROTECTED]> 06/05/01 11:17:27 Modified files: slirp : tcp.h Log message: set TCP_MSS to 1460 (Ed Swierk) CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/qemu

Re: [Qemu-devel] [PATCH] Fix scrambling of >32KB packets in slirp

2006-05-01 Thread Fabrice Bellard
Ed Swierk wrote: In several places in qemu's slirp code, signed and unsigned ints are used interchangeably when dealing with IP packet lengths and offsets. This causes IP packets greater than 32K in length to be scrambled in various interesting ways that are extremely difficult to troubleshoot.

[Qemu-devel] qemu/slirp ip_input.c

2006-05-01 Thread Fabrice Bellard
CVSROOT:/sources/qemu Module name:qemu Branch: Changes by: Fabrice Bellard <[EMAIL PROTECTED]> 06/05/01 11:02:11 Modified files: slirp : ip_input.c Log message: fixed IP packet rassembly logic (Ed Swierk) CVSWeb URLs: http://cvs.savannah.gnu

[Qemu-devel] qemu/slirp mbuf.c

2006-05-01 Thread Fabrice Bellard
CVSROOT:/sources/qemu Module name:qemu Branch: Changes by: Fabrice Bellard <[EMAIL PROTECTED]> 06/05/01 10:59:02 Modified files: slirp : mbuf.c Log message: fixed realloc logic (Ed Swierk) CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/qem

Re: [Qemu-devel] [PATCH] Always use 10.0.2.2 as host addr for -net user (slirp)

2006-05-01 Thread Fabrice Bellard
I am not sure this patch is sufficient: sometimes our_addr is used to open socket on the host side and 10.0.2.2 has a meanning only on the VM side. Fabrice. Ed Swierk wrote: A couple of serious problems remain in the slirp redirection code after the patch Paul applied on 23 April. * If the I

[Qemu-devel] Re: [PATCH] Work around VNC clients that do not transmit shifts for uppercase characters

2006-05-01 Thread Fabrice Bellard
Does it mean that the caps lock keysym is not transmitted by RealVNC ? Otherwise converting the upper case to case lower case would suffice. Fabrice. Anthony Liguori wrote: The spec isn't really clear about what a client should do. This patch is needed for RealVNC clients (at least). Regard

[Qemu-devel] qemu vnc.c

2006-05-01 Thread Fabrice Bellard
CVSROOT:/sources/qemu Module name:qemu Branch: Changes by: Fabrice Bellard <[EMAIL PROTECTED]> 06/05/01 10:38:19 Modified files: . : vnc.c Log message: copyright CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/qemu/qemu/vnc.c.diff?tr1=1

Re: [Qemu-devel] [PATCH] VNC display support for QEMU

2006-05-01 Thread Johannes Schindelin
Hi, On Mon, 1 May 2006, Brad Campbell wrote: > I need to look at the protocol and see if there is a way to instruct the > client to change its size on the fly also.. at the moment booting win2k > I have three different client sizes and need to close/reopen the client > for each change. rfbEnc

[Qemu-devel] -cc checking wrong

2006-05-01 Thread Pavel Janík
[EMAIL PROTECTED]:/tmp/QEMU/qemu-cvs> ./configure --cc="ccache gcc" Compiler ccache gcc could not be found [EMAIL PROTECTED]:/tmp/QEMU/qemu-cvs> Would be nice to accept environment setting of CC as well. -- Pavel Janík panic("Aarggh: attempting to free lock with active wait queue - shoot Andy"