LS thread in nbd/server.c,
> it is more generic if all qio channels that wrap other channels
> inherit the follow status, in the same way that they inherit feature
> bits.
>
> CC: Stefan Hajnoczi
> CC: Daniel P. Berrangé
> CC: qemu-sta...@nongnu.org
> Fixes: https://issues.r
On Fri, May 17, 2024 at 10:08:08PM -0500, Eric Blake wrote:
> Adding a bit of self-review (in case you want to amend this before
> pushing, instead of waiting for me to get back online),
>
> On Fri, May 17, 2024 at 09:50:15PM GMT, Eric Blake wrote:
> > Prevent regressions when using NBD with TLS i
On Thu, May 23, 2024 at 04:55:18PM +0200, Stefano Garzarella wrote:
> These defines are also useful for vhost-user-blk when it is compiled
> in some POSIX systems that do not define them, so let's move them to
> “qemu/osdep.h”.
>
> Suggested-by: Philippe Mathieu-Daudé
> Signed-off-by: Stefano Gar
while ss -ltn | grep -sqE ":$port\b"; do
> +((port++))
> +if [ $port -eq 65000 ]; then port=5; fi
> +done
> +echo picked unused port
> +}
In retrospect I'd probably have suggested putting this into
common.qemu as its conceptually independant of
e, but
> I'm not familiar with this code or a crypto expert.
Yes, its a case of this is undesirable, but we do it everywhere
already, so this isn't making it any worse.
For both patches
Acked-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com
On Mon, Jun 24, 2024 at 06:08:26PM +0200, Kevin Wolf wrote:
> Am 24.06.2024 um 17:23 hat Stefan Hajnoczi geschrieben:
> > On Wed, Jun 19, 2024 at 08:43:25PM +0300, Nir Soffer wrote:
> > > Tested using:
> >
> > Hi Nir,
> > This looks like a good candidate for the qemu-iotests test suite. Adding
> >
On Sat, Jul 06, 2024 at 06:29:23PM +0900, Akihiko Odaki wrote:
> rom_bar is tristate but was defined as uint32_t so convert it into
> OnOffAuto to clarify that. For compatibility, a uint32 value set via
> QOM will be converted into OnOffAuto.
>
> Signed-off-by: Akihiko Odaki
> ---
> docs/igd-ass
On Tue, Jul 16, 2024 at 04:27:31PM +0900, Akihiko Odaki wrote:
> qemu_get_runtime_dir() returns a dynamically allocated directory path
> that is appropriate for storing runtime files. It corresponds to "run"
> directory in Unix.
>
> With a tree-wide search, it was found that there are several case
On Tue, Jul 16, 2024 at 11:06:57AM +0300, Michael Tokarev wrote:
> 16.07.2024 10:27, Akihiko Odaki wrote:
> > qemu_get_runtime_dir() returns a dynamically allocated directory path
> > that is appropriate for storing runtime files. It corresponds to "run"
> > directory in Unix.
>
> Since runtime di
On Tue, Jul 16, 2024 at 07:52:00PM +0900, Akihiko Odaki wrote:
> On 2024/07/16 18:53, Daniel P. Berrangé wrote:
> > On Tue, Jul 16, 2024 at 04:27:31PM +0900, Akihiko Odaki wrote:
> > > qemu_get_runtime_dir() returns a dynamically allocated directory path
> > > that
nit/test-crypto-block.c | 14 +++---
> 7 files changed, 22 insertions(+), 24 deletions(-)
Acked-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|
pher-nettle.c.inc| 8 +++
> crypto/rsakey-builtin.c.inc | 4 ++--
> crypto/rsakey-nettle.c.inc | 4 ++--
> 9 files changed, 32 insertions(+), 33 deletions(-)
Acked-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://ber
+++
> tests/unit/test-crypto-hmac.c | 16 -
> tests/unit/test-crypto-ivgen.c | 8 ++---
> tests/unit/test-crypto-pbkdf.c | 44 -
> ui/vnc.c | 2 +-
> util/hbitmap.c
| 18 +++---
> crypto/cipher-gcrypt.c.inc| 56
> crypto/cipher-gnutls.c.inc| 38 +--
> crypto/cipher-nettle.c.inc| 58 -
> 26 files changed, 277 insertions(+), 278 deletions(-)
Acked-by: Daniel P. Berrangé
W
.h | 2 +-
> include/crypto/ivgen.h | 14 +++---
> crypto/block-luks.c| 16
> crypto/block-qcow.c| 2 +-
> crypto/ivgen.c | 10 +-
> tests/unit/test-crypto-block.c | 14 +++---
>
/test-crypto-akcipher.c | 10 +-
> crypto/akcipher-gcrypt.c.inc | 4 ++--
> crypto/akcipher-nettle.c.inc| 4 ++--
> 9 files changed, 19 insertions(+), 20 deletions(-)
Acked-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com
nc| 18 +-
> crypto/akcipher-nettle.c.inc| 18 +-
> 7 files changed, 41 insertions(+), 42 deletions(-)
Acked-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dber
> crypto/cipher-afalg.c | 12 ++--
> crypto/hash-afalg.c | 14 +++---
> 5 files changed, 25 insertions(+), 25 deletions(-)
Acked-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|:
yptodev-builtin.c| 8
> backends/cryptodev-lkcf.c | 2 +-
> backends/cryptodev-vhost-user.c | 6 +++---
> backends/cryptodev.c| 6 +++---
> hw/virtio/virtio-crypto.c | 10 +++++-
> 6 files changed, 16 insertions(+), 17 deletions(-)
Re
yptodev.c | 6 +++---
> hw/virtio/virtio-crypto.c| 14 +++---
> 6 files changed, 18 insertions(+), 19 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|:
nclude/hw/qdev-properties-system.h | 2 +-
> include/hw/s390x/cpu-topology.h | 2 +-
> target/s390x/cpu.h | 2 +-
> hw/core/qdev-properties-system.c| 6 +++---
> hw/s390x/cpu-topology.c | 6 +++---
> 9 files changed, 23 insertions(+), 26
| 1 +
> qapi/migration.json | 1 +
> qapi/ui.json | 2 ++
> scripts/qapi/common.py | 42 ++++++----------
> scripts/qapi/schema.py | 2 +-
> tests/qapi-schema/alternate-array.out| 1 -
On Tue, Jul 30, 2024 at 02:26:49PM +0200, Markus Armbruster wrote:
> Daniel P. Berrangé writes:
>
> > On Tue, Jul 30, 2024 at 10:10:25AM +0200, Markus Armbruster wrote:
> >> QAPI's 'prefix' feature can make the connection between enumeration
> >> ty
> client's socket never got added to the list closed in
> nbd_export_close_all), despite that patch intentionally tearing down
> the QIONetListener to prevent new clients.
>
> Reported-by: Alexander Ivanov
> Fixes: CVE-2024-7409
> Signed-off-by: Eric Blake
> ---
>
On Mon, Aug 05, 2024 at 09:21:36PM -0500, Eric Blake wrote:
> Since an NBD server may be long-living, serving clients that
> repeatedly connect and disconnect, it can be more efficient to clean
> up after each client disconnects, rather than storing a list of
> resources to clean up when the server
+-
> qemu-nbd.c | 3 ++-
> 2 files changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrang
typedef struct NBDOption {
> @@ -403,9 +409,12 @@ AioContext *nbd_export_aio_context(NBDExport *exp);
> NBDExport *nbd_export_find(const char *name);
>
> void nbd_client_new(QIOChannelSocket *sioc,
> +uint32_t handshake_limit,
s/handshake_limit/handshake_max_secs/
to m
surface. On the other hand, by itself, it makes it more obvious that
> with a finite limit, we have the problem of an unauthenticated client
> holding 100 fds opened as a way to block out a legitimate client from
> being able to connect; thus, later patches will further add timeouts
>
get to start progressing once earlier ones are
> forcefully dropped for taking too long, rather than hanging.
>
> Suggested-by: Daniel P. Berrangé
> Signed-off-by: Eric Blake
> ---
> nbd/server.c | 31 ++-
> nbd/trace-events | 1 +
> 2 file
to the list closed in
> nbd_export_close_all), despite that patch intentionally tearing down
> the QIONetListener to prevent new clients.
>
> Reported-by: Alexander Ivanov
> Fixes: CVE-2024-7409
> Signed-off-by: Eric Blake
> ---
> blockdev-nbd.c | 35 ++
h"
> > #include "nbd-internal.h"
> > #include "qemu/cutils.h"
> > +#include "qemu/unicode.h"
> >
> > /* Definitions for opaque data types */
> >
> > @@ -230,7 +231,9 @@ static int nbd_handle_reply_err(QIOChannel *ioc,
&
> 3 files changed, 88 insertions(+), 46 deletions(-)
I was going to ask for a unit test, but "escaped_string" in
test-qjson.c looks like it will be covering this sufficiently
well already, that we don't need to test it in isolation.
Reviewed-by: Daniel P. Berrangé
Wi
On Mon, Aug 12, 2024 at 05:38:41PM +0200, Thomas Huth wrote:
> On 24/07/2024 11.47, Daniel P. Berrangé wrote:
> > The current TLS session I/O APIs just return a synthetic errno
> > value on error, which has been translated from a gnutls error
> > value. This looses a lar
Error reporting from gnutls was improved by:
commit 57941c9c86357a6a642f9ee3279d881df4043b6d
Author: Daniel P. Berrangé
Date: Fri Mar 15 14:07:58 2024 +
crypto: push error reporting into TLS session I/O APIs
This has the effect of changing the output from one of the NBD
tests
On Wed, Aug 28, 2024 at 10:32:15AM +0200, Thomas Huth wrote:
> On 27/08/2024 09.05, Markus Armbruster wrote:
> > Daniel P. Berrangé writes:
> >
> > > On Mon, Aug 12, 2024 at 05:38:41PM +0200, Thomas Huth wrote:
> > > > On 24/07/2024 11.47, Daniel P. Berra
; Fixes: 500e2434207d ('raw-format: Split raw_read_options()')
> Signed-off-by: Kevin Wolf
> ---
> block/raw-format.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-
On Wed, Sep 04, 2024 at 01:18:18PM +0200, Markus Armbruster wrote:
> camel_to_upper() converts its argument from camel case to upper case
> with '_' between words. Used for generated enumeration constant
> prefixes.
>
> Signed-off-by: Markus Armbruster
> Reviewed-by: Daniel P. Berrang??
The
On Thu, Sep 05, 2024 at 07:59:13AM +0200, Markus Armbruster wrote:
> Daniel P. Berrangé writes:
>
> > On Wed, Sep 04, 2024 at 01:18:18PM +0200, Markus Armbruster wrote:
> >> camel_to_upper() converts its argument from camel case to upper case
> >> with '_&
* Fix iotests expected output from gnutls errors
--------
Daniel P. Berrangé (6):
iotests: fix expected output from gnutls
crypto: check gnutls & gcrypt support the requested pbkdf hash
tests/unit: always build the pbkdf crypto unit
-bot2/
[2]
https://lore.kernel.org/lkml/20221226031010.4079885-1-maxing@bytedance.com/t/#m1c7f2fdc0ea742776a70fd1aa2a2e414c437f534
Resolves: #2398
Signed-off-by: Tiago Pasqualini
Signed-off-by: Daniel P. Berrangé
---
crypto/pbkdf.c | 53 +++---
1
Error reporting from gnutls was improved by:
commit 57941c9c86357a6a642f9ee3279d881df4043b6d
Author: Daniel P. Berrangé
Date: Fri Mar 15 14:07:58 2024 +
crypto: push error reporting into TLS session I/O APIs
This has the effect of changing the output from one of the NBD
tests
P. Berrangé
---
crypto/pbkdf-gcrypt.c | 2 +-
crypto/pbkdf-gnutls.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/crypto/pbkdf-gcrypt.c b/crypto/pbkdf-gcrypt.c
index a8d8e64f4d..bc0719c831 100644
--- a/crypto/pbkdf-gcrypt.c
+++ b/crypto/pbkdf-gcrypt.c
@@ -33,7 +33,7
Not all paths in qcrypto_cipher_ctx_new() were correctly distinguishing
between valid user input for cipher mode (which should report a user
facing error), vs program logic errors (which should assert).
Reported-by: Peter Maydell
Signed-off-by: Daniel P. Berrangé
---
crypto/cipher-nettle.c.inc
Fixes: Coverity CID 1546884
Reviewed-by: Peter Maydell
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Daniel P. Berrangé
---
crypto/cipher-nettle.c.inc | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/crypto/cipher-nettle.c.inc b/crypto/cipher-nettle.c.inc
index
Add CONFIG_DARWIN to the pbkdf test build condition, since we have a way
to measure CPU time on this platform since commit bf98afc75efedf1.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Daniel P. Berrangé
---
tests/unit/test-crypto-pbkdf.c | 2 +-
1 file changed, 1 insertion(+), 1
test registration.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Daniel P. Berrangé
---
tests/unit/meson.build | 4 +---
tests/unit/test-crypto-pbkdf.c | 13 -
2 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/tests/unit/meson.build b/tests/unit/meson.build
From: Dorjoy Chowdhury
QEMU requires minimum glib version 2.66.0 as per the root meson.build
file and per glib documentation[1] G_CHECKSUM_SHA384 is available since
2.51.
[1] https://docs.gtk.org/glib/enum.ChecksumType.html
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Dorjoy Chowdhury
From: Dorjoy Chowdhury
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Dorjoy Chowdhury
Signed-off-by: Daniel P. Berrangé
---
crypto/hash.c | 14 +++---
include/crypto/hash.h | 8
2 files changed, 15 insertions(+), 7 deletions(-)
diff --git a/crypto/hash.c b/crypto
-by: Daniel P. Berrangé
---
crypto/meson.build | 4 ++
crypto/x509-utils.c | 76 +
include/crypto/x509-utils.h | 22 +++
3 files changed, 102 insertions(+)
create mode 100644 crypto/x509-utils.c
create mode 100644 include/crypto/x509
On Mon, Jun 27, 2022 at 02:39:57PM +0200, Niklas Cassel via wrote:
> The serial prop on the controller is actually describing the nvme
> subsystem serial, which has to be identical for all controllers within
> the same nvme subsystem.
Given this description...
>
> -device nvme-subsys,id=nvm
On Sat, Jul 02, 2022 at 12:33:23PM +0100, Alberto Faria wrote:
> This series introduces a static analyzer for QEMU. It consists of a
> single static-analyzer.py script that relies on libclang's Python
> bindings, and provides a common framework on which arbitrary static
> analysis checks can be dev
On Mon, Jul 04, 2022 at 08:30:08PM +0100, Alberto Faria wrote:
> On Mon, Jul 4, 2022 at 5:28 PM Daniel P. Berrangé wrote:
> > Have you done any measurement see how much of the overhead is from
> > the checks you implemented, vs how much is inherantly forced on us
> > by libcl
On Tue, Jul 05, 2022 at 12:28:55PM +0100, Alberto Faria wrote:
> On Tue, Jul 5, 2022 at 8:16 AM Daniel P. Berrangé wrote:
> > for i in `git ls-tree --name-only -r HEAD:`
> > do
> > clang-tidy $i 1>/dev/null 2>&1
> > done
>
> Al
On Sat, Jul 02, 2022 at 12:33:23PM +0100, Alberto Faria wrote:
> This series introduces a static analyzer for QEMU. It consists of a
> single static-analyzer.py script that relies on libclang's Python
> bindings, and provides a common framework on which arbitrary static
> analysis checks can be dev
On Wed, Jul 06, 2022 at 10:54:51AM +0100, Alberto Faria wrote:
> On Tue, Jul 5, 2022 at 5:12 PM Daniel P. Berrangé wrote:
> > On Tue, Jul 05, 2022 at 12:28:55PM +0100, Alberto Faria wrote:
> > > On Tue, Jul 5, 2022 at 8:16 AM Daniel P. Berrangé
> > > wrote:
> &g
> tests/vm/centos.aarch64 | 174 ++--
> 1 file changed, 24 insertions(+), 150 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop
en run as a TCG test.
>
> Signed-off-by: John Snow
> ---
> tests/vm/ubuntu.aarch64 | 8 ++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/
n Snow
> ---
> tests/vm/basevm.py | 5 +++++
> 1 file changed, 5 insertions(+)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop1
gt; qga/commands-posix.c | 7 ++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.b
d-by: Thomas Huth
> ---
> tests/vm/centos | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-
e changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|
--
> 2 files changed, 1 insertion(+), 42 deletions(-)
> delete mode 100755 tests/vm/ubuntu.i386
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-p
4 +++---
> 1 file changed, 7 insertions(+), 7 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://
K=1;
I don't mind either way though, and feel this is quite poiintless
anyway, since mingw is trivial to test in containers
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org
On Thu, Jul 07, 2022 at 11:48:35AM -0400, John Snow wrote:
> On Thu, Jul 7, 2022 at 4:33 AM Daniel P. Berrangé wrote:
> >
> > On Thu, Jul 07, 2022 at 12:03:07AM -0400, John Snow wrote:
> > > The fedora container has since been split apart, so there's no suitable
&
On Wed, Jun 15, 2022 at 04:51:17PM +0100, Stefan Hajnoczi wrote:
> From: Jagannathan Raman
>
> add the libvfio-user library as a submodule. build it as a meson
> subproject.
>
> libvfio-user is distributed with BSD 3-Clause license and
> json-c with MIT (Expat) license
>
> Signed-off-by: Elena
+++-
> 1 file changed, 9 insertions(+), 9 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://
ttps://bugzilla.redhat.com/show_bug.cgi?id=2092322
> Signed-off-by: Hanna Reitz
> ---
> storage-daemon/qemu-storage-daemon.c | 11 ++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com
>
> Signed-off-by: Hanna Reitz
> ---
> softmmu/vl.c | 30 ++
> 1 file changed, 26 insertions(+), 4 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org
On Tue, Jul 12, 2022 at 03:27:09PM +, Jag Raman wrote:
>
>
> On Jul 12, 2022, at 4:39 AM, Daniel P. Berrangé
> mailto:berra...@redhat.com>> wrote:
>
> On Wed, Jun 15, 2022 at 04:51:17PM +0100, Stefan Hajnoczi wrote:
> From: Jagannathan Raman mailto:jag.ra..
Hi Jay / Stefan,
We've got a non-determinsitic hang in QEMU CI since this series
merged, which we tracked down to a libvfio-user test that is
flakey:
https://gitlab.com/qemu-project/qemu/-/issues/1114
John Levon has proposed a PR to libvfio-user to turn off the
test, but we'll need one of you
updated.
That sounds good, thank you. We should be fine to get the
submodule reefreshed even in soft freeze, given that it is
fixing a test failure bug.
Oh and I just noticed I messed up your name in my message
below. I'm very sorry about that.
With regards,
Daniel
> On Jul 21, 2022, a
On Wed, Aug 03, 2022 at 11:46:26AM +0100, Dr. David Alan Gilbert wrote:
> * Alberto Faria (afa...@redhat.com) wrote:
> > Make non-void static functions whose return values are ignored by
> > all callers return void instead.
> >
> > These functions were found by static-analyzer.py.
> >
> > Not all
On Wed, Aug 03, 2022 at 12:15:20PM +0100, Richard W.M. Jones wrote:
> On Wed, Aug 03, 2022 at 12:07:19PM +0100, Alberto Faria wrote:
> > On Wed, Aug 3, 2022 at 11:46 AM Dr. David Alan Gilbert
> > wrote:
> > >
> > > * Alberto Faria (afa...@redhat.com) wrote:
> > > > Make non-void static functions w
On Thu, Jul 28, 2022 at 10:46:35AM +0100, Peter Maydell wrote:
> On Wed, 27 Jul 2022 at 20:03, Kevin Wolf wrote:
> >
> > Am 18.07.2022 um 11:49 hat Markus Armbruster geschrieben:
> > > An OTP device isn't really a parallel flash, and neither are eFuses.
> > > More fast-and-lose use of IF_PFLASH ma
On Thu, Aug 04, 2022 at 04:56:15PM +0200, Markus Armbruster wrote:
> Daniel P. Berrangé writes:
>
> > On Thu, Jul 28, 2022 at 10:46:35AM +0100, Peter Maydell wrote:
> >> On Wed, 27 Jul 2022 at 20:03, Kevin Wolf wrote:
> >> >
> >> > Am 18.07.20
On Thu, Aug 04, 2022 at 05:30:40PM +0200, Markus Armbruster wrote:
> Daniel P. Berrangé writes:
>
> > On Thu, Aug 04, 2022 at 04:56:15PM +0200, Markus Armbruster wrote:
> >> Daniel P. Berrangé writes:
> >>
> >> > On Thu, Jul 28, 2022 at 10:46:35AM +010
On Thu, Aug 11, 2022 at 02:50:01PM +0400, Marc-André Lureau wrote:
> Hi
>
> On Thu, Aug 11, 2022 at 2:22 PM Peter Maydell
> wrote:
>
> > On Thu, 11 Aug 2022 at 11:09, Marc-André Lureau
> > wrote:
> > > On Thu, Aug 11, 2022 at 1:05 PM Markus Armbruster
> > wrote:
> > >> Your moves tear closely
Cc: Daniel P. Berrange
> Cc: Thomas Huth
> ---
> qemu-options.hx | 13 +
> 1 file changed, 13 insertions(+)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt
On Wed, Aug 31, 2022 at 04:54:41PM +0400, Marc-André Lureau wrote:
> Hi Bin
>
> On Wed, Aug 24, 2022 at 1:42 PM Bin Meng wrote:
>
> > From: Bin Meng
> >
> > At present get_tmp_filename() has platform specific implementations
> > to get the directory to use for temporary files. Switch over to us
On Fri, Sep 02, 2022 at 06:51:26PM +0200, Juan Quintela wrote:
> With this change "make check" works when configured with --disable-keyring.
>
> Signed-off-by: Juan Quintela
> ---
> tests/unit/meson.build | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/unit/mes
> and use g_file_open_tmp() for a consistent implementation.
>
> Signed-off-by: Bin Meng
> ---
>
> include/block/block_int-common.h | 2 +-
> block.c | 42 ++--
> block/vvfat.c | 8 +++---
> 3 files changed,
On Sun, Sep 25, 2022 at 12:32:00AM +0800, Bin Meng wrote:
> From: Bin Meng
>
> At present there are two callers of get_tmp_filename() and they are
> inconsistent.
>
> One does:
>
> /* TODO: extra byte is a hack to ensure MAX_PATH space on Windows. */
> char *tmp_filename = g_malloc0(PAT
tify
> && aio_node_check(ctx, node->is_external)) {
> + assert(count < MAXIMUM_WAIT_OBJECTS);
> events[count++] = event_notifier_get_handle(node->e);
> }
> }
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https:/
The qcow2 block driver expects to see a valid sector size even when it
has opened the crypto layer with QCRYPTO_BLOCK_OPEN_NO_IO.
Signed-off-by: Daniel P. Berrangé
---
crypto/block-qcow.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/crypto/block-qcow.c b/crypto/block-qcow.c
index
On Mon, Oct 15, 2018 at 06:38:14PM +0200, Max Reitz wrote:
> On 11.10.18 12:58, Alberto Garcia wrote:
> > This doesn't have any practical effect at the moment because the
> > values of BDRV_SECTOR_SIZE, QCRYPTO_BLOCK_LUKS_SECTOR_SIZE and
> > QCRYPTO_BLOCK_QCOW_SECTOR_SIZE are all the same (512 byte
Paolo, I think this is a patch for your misc patches queue.
On Wed, Mar 21, 2018 at 03:31:24PM +, Daniel P. Berrangé wrote:
> The sheepdog mailing list is setup to stop and queue messages from
> non-subscribers, pending moderator approval. Unfortunately it seems
> that the moderation
On Mon, Nov 12, 2018 at 03:45:45PM +0100, Alberto Garcia wrote:
> ping
Sorry, I should have said I queued this patch when adding my previous R-b.
> On Fri 05 Oct 2018 04:52:02 PM CEST, Alberto Garcia wrote:
> > The values specified in the documentation don't match the actual
> > defaults set in q
On Mon, Nov 12, 2018 at 09:59:56AM -0500, Cleber Rosa wrote:
>
> On 11/12/18 5:49 AM, Kevin Wolf wrote:
> > Am 09.11.2018 um 23:12 hat Cleber Rosa geschrieben:
> >> The initial goal of this RFC is to get feedback on tests not specific
> >> to the QEMU main binary, but specific to other components
On Tue, Nov 13, 2018 at 10:39:57AM +0100, Markus Armbruster wrote:
> Drive-by comment...
>
> Cleber Rosa writes:
>
> [...]
> > My impression is that the "infrastructure for block tests" is not that
> > different from the infrastructure needed by other tests, specially other
> > QEMU tests.
> [..
On Mon, Nov 05, 2018 at 04:41:09PM -0600, Eric Blake wrote:
> On 10/9/18 8:23 AM, Daniel P. Berrangé wrote:
> > From: "Daniel P. Berrange"
> >
> > Currently any client which can complete the TLS handshake is able to use
> > the NBD server. The server admin
On Mon, Nov 05, 2018 at 04:41:09PM -0600, Eric Blake wrote:
> On 10/9/18 8:23 AM, Daniel P. Berrangé wrote:
> > From: "Daniel P. Berrange"
> >
> > Currently any client which can complete the TLS handshake is able to use
> > the NBD server. The server admin
n 'qemu-iotests/check -luks' on it to
validate it then ...
Reviewed-by: Daniel P. Berrangé
> ---
> block/crypto.c | 80 +++---
> 1 file changed, 30 insertions(+), 50 deletions(-)
>
> diff --git a/block/crypto.c b/blo
This does two minor fixes to the NBD code and adds significant coverage
of the NBD TLS support to detect future problems.
The first two patches should be for 3.1.
The tests can wait till 4.0 if desired.
Daniel P. Berrangé (6):
nbd: fix whitespace in server error message
nbd: stop waiting
with server NBD_REP_ERR errors
Signed-off-by: Daniel P. Berrangé
---
nbd/server.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/nbd/server.c b/nbd/server.c
index 4e8f5ae51b..12e8139f95 100644
--- a/nbd/server.c
+++ b/nbd/server.c
@@ -1135,7 +1135,7 @@ static int
If the qemu-nbd UNIX socket has not shown up, the tests will sleep a bit
and then check again repeatedly for upto 30 seconds. This is pointless
if the qemu-nbd process has quit due to an error, so check whether the
pid is still alive before waiting and retrying.
Signed-off-by: Daniel P. Berrangé
Signed-off-by: Vladimir Sementsov-Ogievskiy
Message-Id: <20170526110913.89098-1-vsement...@virtuozzo.com>
Signed-off-by: Paolo Bonzini
Signed-off-by: Daniel P. Berrangé
---
block/nbd-client.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/nbd-client.c b/block/nbd-clie
The helpers for starting/stopping qemu-nbd in 058 will be useful in
other test cases, so move them into a common.nbd file.
Signed-off-by: Daniel P. Berrangé
---
tests/qemu-iotests/058| 47 +
tests/qemu-iotests/common.nbd | 56
Add helpers to common.tls for creating TLS certificates for a CA,
server and client.
Signed-off-by: Daniel P. Berrangé
---
tests/qemu-iotests/common.tls | 139 ++
1 file changed, 139 insertions(+)
create mode 100644 tests/qemu-iotests/common.tls
diff --git a
1 - 100 of 1814 matches
Mail list logo
