On Mon, Nov 12, 2018 at 03:45:45PM +0100, Alberto Garcia wrote: > ping Sorry, I should have said I queued this patch when adding my previous R-b.
> On Fri 05 Oct 2018 04:52:02 PM CEST, Alberto Garcia wrote: > > The values specified in the documentation don't match the actual > > defaults set in qcrypto_block_luks_create(). > > > > Signed-off-by: Alberto Garcia <be...@igalia.com> > > --- > > qapi/crypto.json | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/qapi/crypto.json b/qapi/crypto.json > > index a51b434412..b2a4cff683 100644 > > --- a/qapi/crypto.json > > +++ b/qapi/crypto.json > > @@ -181,11 +181,11 @@ > > # The options that apply to LUKS encryption format initialization > > # > > # @cipher-alg: the cipher algorithm for data encryption > > -# Currently defaults to 'aes'. > > +# Currently defaults to 'aes-256'. > > # @cipher-mode: the cipher mode for data encryption > > -# Currently defaults to 'cbc' > > +# Currently defaults to 'xts' > > # @ivgen-alg: the initialization vector generator > > -# Currently defaults to 'essiv' > > +# Currently defaults to 'plain64' > > # @ivgen-hash-alg: the initialization vector generator hash > > # Currently defaults to 'sha256' > > # @hash-alg: the master key hash algorithm > > -- > > 2.11.0 Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
