[PATCH 1/2] scsi-disk: Advertise FUA support by default

2025-03-04 Thread Alberto Faria
FUA emulation code is already is place. Signed-off-by: Alberto Faria --- hw/scsi/scsi-disk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index e7f738b484..8cf50845ab 100644 --- a/hw/scsi/scsi-disk.c +++ b/hw/scsi/scsi-disk.c @@ -3

[PATCH 2/2] scsi-disk: Add native FUA support

2025-03-04 Thread Alberto Faria
Avoid emulating FUA when the driver supports it natively. This should provide better performance than a full flush after the write. Signed-off-by: Alberto Faria --- hw/scsi/scsi-disk.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/hw/scsi/scsi-disk.c b/hw

Re: [PATCH v2] iotest: Unbreak 302 with python 3.13

2025-03-04 Thread Eric Blake
On Mon, Mar 03, 2025 at 04:41:56PM +0800, Stefan Hajnoczi wrote: > On Fri, Feb 28, 2025 at 09:57:08PM +0200, Nir Soffer wrote: > > This test depends on TarFile.addfile() to add tar member header without > > writing the member data, which we write ourself using qemu-nbd. Python > > 3.13 changed the

Re: [PATCH] iotests: Stop NBD server in test 162 before starting the next one

2025-03-04 Thread Eric Blake
On Thu, Feb 27, 2025 at 01:14:12PM -0600, Eric Blake wrote: > On Tue, Feb 25, 2025 at 08:06:50AM +0100, Thomas Huth wrote: > > Test 162 recently started failing for me for no obvious reasons (I > > did not spot any suspicious commits in this area), but looking in > > the 162.out.bad log file, there

Re: [PULL 0/4] ufs queue

2025-03-04 Thread Philippe Mathieu-Daudé
Hi Stefan, On 17/2/25 10:27, Jeuk Kim wrote: From: Jeuk Kim The following changes since commit db7aa99ef894e88fc5eedf02ca2579b8c344b2ec: Merge tag 'hw-misc-20250216' of https://github.com/philmd/qemu into staging (2025-02-16 20:48:06 -0500) are available in the Git repository at: htt

Re: [PATCH 1/2] scsi-disk: Advertise FUA support by default

2025-03-04 Thread Daniel P . Berrangé
On Tue, Mar 04, 2025 at 03:52:31PM +, Alberto Faria wrote: > FUA emulation code is already is place. > > Signed-off-by: Alberto Faria > --- > hw/scsi/scsi-disk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c > index e7f738

Re: [PATCH] nbd: Defer trace init until after daemonization

2025-03-04 Thread Thomas Huth
On 27/02/2025 23.06, Eric Blake wrote: At least the simple trace backend works by spawning a helper thread, and setting up an atexit() handler that coordinates completion with the helper thread. But since atexit registrations survive fork() but helper threads do not, this means that qemu-nbd con

[PATCH v2] blockdev-backup: Add error handling option for copy-before-write jobs

2025-03-04 Thread Raman Dzehtsiar
This patch extends the blockdev-backup QMP command to allow users to specify how to behave when IO errors occur during copy-before-write operations. Previously, the behavior was fixed and could not be controlled by the user. The new 'on-cbw-error' option can be set to one of two values: - 'break-g

Re: [PATCH] blockdev-backup: Add error handling option for copy-before-write jobs

2025-03-04 Thread Raman Dzehtsiar
Hi, Eric. > > backup->on_target_error, > > +backup->has_on_cbw_error ? > > backup->on_cbw_error : ON_CBW_ERROR_BREAK_GUEST_WRITE, > > Is there a way to avoid this long line, perhaps by using assignment > into a temporary variable prior to t

[PATCH 0/2] scsi-disk: Add FUA write support

2025-03-04 Thread Alberto Faria
Add support for Force Unit Access (FUA) writes. The first patch makes scsi-disk devices advertise FUA support by default; FUA requests will be emulated through a regular write followed by a flush. The second patch lets us avoid FUA emulation when the underlying block driver supports it natively. A

Re: [PATCH 0/2] hw/ufs: Add temperature event support and test cases

2025-03-04 Thread Philippe Mathieu-Daudé
On 25/2/25 07:40, Keoseong Park wrote: Keoseong Park (2): hw/ufs: Add temperature event notification support tests/qtest/ufs-test: Add test code for the temperature feature Series queued, thanks!

Re: [PATCH v17 11/11] hw/vmapple/vmapple: Add vmapple machine type

2025-03-04 Thread Philippe Mathieu-Daudé
On 3/3/25 23:11, Philippe Mathieu-Daudé wrote: On 3/3/25 21:36, Phil Dennis-Jordan wrote: On Mon, 3 Mar 2025 at 19:20, Philippe Mathieu-Daudé > wrote:     On 12/1/25 22:00, Phil Dennis-Jordan wrote: > From: Alexander Graf mailto:g...@amazon.com>> >   M

Re: [PATCH v2 04/11] rust/qemu-api: Add wrappers to run futures in QEMU

2025-03-04 Thread Stefan Hajnoczi
On Tue, Feb 18, 2025 at 07:20:12PM +0100, Kevin Wolf wrote: > This adds helper functions that allow running Rust futures to completion > using QEMU's event loops. This commit is a cliff-hanger. I'm intrigued to find out how timer, fd, etc event loop integration will work :). > > Signed-off-by: K

Re: [PATCH v2 09/11] rust/block: Add read support for block drivers

2025-03-04 Thread Stefan Hajnoczi
On Tue, Feb 18, 2025 at 07:20:17PM +0100, Kevin Wolf wrote: > This adds a map() function to the BlockDriver trait and makes use of it > to implement reading from an image. > > Signed-off-by: Kevin Wolf > --- > rust/block/src/driver.rs | 95 > 1 file chang

Re: [PATCH v2 08/11] rust/block: Add driver module

2025-03-04 Thread Stefan Hajnoczi
On Tue, Feb 18, 2025 at 07:20:16PM +0100, Kevin Wolf wrote: > This adds a barebones module for a block driver interface. Because there > is no native QAPI support for Rust yet, opening images takes a few > unsafe functions to call into C visitor functions. This should be > cleaned up later. > > Si