Hi, Eric. > > backup->on_target_error, > > + backup->has_on_cbw_error ? > > backup->on_cbw_error : ON_CBW_ERROR_BREAK_GUEST_WRITE, > > Is there a way to avoid this long line, perhaps by using assignment > into a temporary variable prior to the function call?
Good point. I’ve refactored it to improve readability. > > +# @on-cbw-error: optional policy defining behavior on I/O errors in > > +# copy-before-write jobs; defaults to break-guest-write. (Since 9.3) > > The next release is 10.0, not 9.3. You're right. I've corrected the release number. Apologies for the mistake. I'm still getting familiar with the process. Thanks for your review! Both issues have been addressed in v2 of this patch. -- Best regards, Raman Dzehtsiar
