On Wed, Jan 15, 2025 at 01:46:29PM +0900, Akihiko Odaki wrote:
> On 2025/01/15 2:02, Peter Xu wrote:
> > On Tue, Jan 14, 2025 at 05:43:09PM +0900, Akihiko Odaki wrote:
> > > memory_region_finalize() is not a function to tell the owner is leaving,
> > > but
> > > the memory region itself is being d
On Wed, 15 Jan 2025 at 14:05, Michael Tokarev wrote:
> 13.01.2025 00:00, Phil Dennis-Jordan wrote:
> > This patch set introduces a new ARM and macOS HVF specific machine type
> > called "vmapple". There are also some patches for fixing XHCI spec
> > compliance issues and adding a workaround to a
13.01.2025 00:00, Phil Dennis-Jordan wrote:
This patch set introduces a new ARM and macOS HVF specific machine type
called "vmapple". There are also some patches for fixing XHCI spec
compliance issues and adding a workaround to a quirk in the macOS guest's
XHCI driver.
The vmapple machine type a
11.01.2025 21:36, Bernhard Beschow wrote:
In U-Boot, the fsl_esdhc[_imx] driver waits for both "transmit completed" and
"DMA" bits in esdhc_send_cmd_common() by means of DATA_COMPLETE constant. QEMU
currently misses to set the DMA bit which causes the driver to loop forever. Fix
that by setting t
The versioned 'pc' and 'q35' machines up to 2.12 been marked
as deprecated two releases ago, and are older than 6 years,
so according to our support policy we can remove them.
This series only includes the 2.4 and 2.5 machines removal,
as it is a big enough number of LoC removed. Rest will
follow.
The PCMachineClass::broken_reserved_end field was only used
by the pc-q35-2.4 and pc-i440fx-2.4 machines, which got removed.
Remove it and simplify pc_memory_init().
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/i386/pc.h | 1 -
hw/i386/pc.c | 13 +
2 files changed, 5
The pc_compat_2_4[] array was only used by the pc-q35-2.4
and pc-i440fx-2.4 machines, which got removed. Remove it.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/i386/pc.h | 3 ---
hw/i386/pc.c | 19 ---
2 files changed, 22 deletions(-)
diff --git a/include/hw/i3
We removed the implementations in commit 46a2bd52571
("hw/i386/pc: Remove deprecated pc-i440fx-2.3 machine")
but forgot to remove the declarations. Do it now.
Fixes: 46a2bd52571 ("hw/i386/pc: Remove deprecated pc-i440fx-2.3 machine")
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/i386/pc.h
The MachineClass::legacy_fw_cfg_order boolean was only used
by the pc-q35-2.5 and pc-i440fx-2.5 machines, which got
removed. Remove it along with:
- FW_CFG_ORDER_OVERRIDE_* definitions
- fw_cfg_set_order_override()
- fw_cfg_reset_order_override()
- fw_cfg_order[]
- rom_set_order_override()
- rom_r
E1000_FLAG_MAC was only used by the hw_compat_2_4[] array,
via the 'extra_mac_registers=off' property. We removed all
machines using that array, lets remove all the code around
E1000_FLAG_MAC.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/net/e1000.c | 63 +
The "fallback" property was only used by the hw_compat_2_5[] array,
as 'fallback=144'. We removed all machines using that array, lets
remove ISA floppy drive 'fallback' property, manually setting the
default value in isabus_fdc_realize().
Signed-off-by: Philippe Mathieu-Daudé
---
hw/block/fdc-is
VIRTIO_PCI_FLAG_DISABLE_PCIE was only used by the
hw_compat_2_4[] array, via the 'x-disable-pcie=false'
property. We removed all machines using that array,
lets remove all the code around VIRTIO_PCI_FLAG_DISABLE_PCIE.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/virtio/virtio-pci.h | 4 -
VMXNET3_COMPAT_FLAG_OLD_MSI_OFFSETS was only used by the
hw_compat_2_5[] array, via the 'x-old-msi-offsets=on' property.
We removed all machines using that array, lets remove all the
code around VMXNET3_COMPAT_FLAG_OLD_MSI_OFFSETS.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/net/vmxnet3.c | 20
The hw_compat_2_4[] array was only used by the pc-q35-2.4 and
pc-i440fx-2.4 machines, which got removed. Remove it.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/boards.h | 3 ---
hw/core/machine.c | 9 -
2 files changed, 12 deletions(-)
diff --git a/include/hw/boards.h b/inclu
The hw_compat_2_5[] array was only used by the pc-q35-2.5 and
pc-i440fx-2.5 machines, which got removed. Remove it.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/boards.h | 3 ---
hw/core/machine.c | 9 -
2 files changed, 12 deletions(-)
diff --git a/include/hw/boards.h b/inclu
VIRTIO_PCI_FLAG_MIGRATE_EXTRA was only used by the
hw_compat_2_4[] array, via the 'migrate-extra=true'
property. We removed all machines using that array,
lets remove all the code around VIRTIO_PCI_FLAG_MIGRATE_EXTRA.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/virtio/virtio-pci.h | 4
PVSCSI_COMPAT_DISABLE_PCIE_BIT was only used by the
hw_compat_2_5[] array, via the 'x-disable-pcie=on' property.
We removed all machines using that array, lets remove all the
code around PVSCSI_COMPAT_DISABLE_PCIE_BIT.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/scsi/vmw_pvscsi.c | 44 -
These machines has been supported for a period of more than 6 years.
According to our versioned machine support policy (see commit
ce80c4fa6ff "docs: document special exception for machine type
deprecation & removal") they can now be removed.
Signed-off-by: Philippe Mathieu-Daudé
---
docs/about/
VMXNET3_COMPAT_FLAG_DISABLE_PCIE was only used by the
hw_compat_2_5[] array, via the 'x-disable-pcie=on' property.
We removed all machines using that array, lets remove all the
code around VMXNET3_COMPAT_FLAG_DISABLE_PCIE.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/net/vmxnet3.c | 11 +
Simplify merging vmxnet3_realize() within vmxnet3_instance_init(),
removing the need for device_class_set_parent_realize().
Signed-off-by: Philippe Mathieu-Daudé
---
hw/net/vmxnet3.c | 15 +--
1 file changed, 1 insertion(+), 14 deletions(-)
diff --git a/hw/net/vmxnet3.c b/hw/net/vmx
Simplify replacing pvscsi_realize() by pvscsi_instance_init(),
removing the need for device_class_set_parent_realize().
Signed-off-by: Philippe Mathieu-Daudé
---
hw/scsi/vmw_pvscsi.c | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/hw/scsi/vmw_pvscsi.c b/hw/scsi
PVSCSI_COMPAT_OLD_PCI_CONFIGURATION was only used by the
hw_compat_2_5[] array, via the 'x-old-pci-configuration=on'
property. We removed all machines using that array, lets remove
all the code around PVSCSI_COMPAT_OLD_PCI_CONFIGURATION.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/scsi/vmw_pvsc
Simplify x86_cpu_realizefn() by passing an Error**
argument to x86_cpu_filter_features().
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/cpu.c | 26 +-
1 file changed, 9 insertions(+), 17 deletions(-)
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 422276
The X86CPU::check_cpuid boolean was only set in the
pc_compat_2_4[] array, via the 'check=off' property.
We removed all machines using that array, lets remove
that CPU property and simplify x86_cpu_realizefn().
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/cpu.h | 1 -
target/i386/cpu.c
These machines has been supported for a period of more than 6 years.
According to our versioned machine support policy (see commit
ce80c4fa6ff "docs: document special exception for machine type
deprecation & removal") they can now be removed.
Remove the now unused empty pc_compat_2_5[] array.
Sig
The X86MachineClass::save_tsc_khz boolean was only used
by the pc-q35-2.5 and pc-i440fx-2.5 machines, which got
removed. Remove it and simplify tsc_khz_needed().
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/i386/x86.h | 5 -
hw/i386/x86.c | 1 -
target/i386/machine.c | 5 ++--
Adds the NVMe Admin Security Send/Receive command support with support
for DMTFs SPDM. The transport binding for SPDM is defined in the
DMTF DSP0286.
Signed-off-by: Wilfred Mallawa
---
hw/nvme/ctrl.c | 203 ++-
hw/nvme/nvme.h | 5 ++
include/
This patch extends the existing support we have for NVMe with only DoE
to also add support to SPDM over the NVMe Security Send/Recv commands.
With the new definition of the `spdm-trans` argument, users can specify
`spdm_trans=nvme` or `spdm_trans=doe`. This allows us to select the SPDM
transport r
This header contains the transport encoding for an SPDM message that
uses the SPDM over Storage transport as defined by the DMTF DSP0286.
Signed-off-by: Wilfred Mallawa
---
include/system/spdm-socket.h | 12
1 file changed, 12 insertions(+)
diff --git a/include/system/spdm-socket.h
This series adds support for SPDM to be used over the storage transport, as
defined by the DMTF DSP0286 [1] for NVMe. That is, using the admin
NVMe Security Send/Receive commands, support transport for SPDM as per
DSP0286 [1]. The binding specification (DSP0286) is still currently a draft
specifica
On Wed, 2025-01-15 at 12:28 +1000, Alistair Francis wrote:
> On Wed, Jan 8, 2025 at 12:04 AM Wilfred Mallawa via
> wrote:
> >
> > This is to support uni-directional transports such as SPDM
> > over Storage. As specified by the DMTF DSP0286.
> >
> > Signed-off-by: Wilfred Mallawa
> > ---
> > ba
On Fri, 2025-01-10 at 11:03 +0100, Klaus Jensen wrote:
> On Jan 7 15:29, Wilfred Mallawa via wrote:
> > Adds the NVMe Admin Security Send/Receive command support with
> > support
> > for DMTFs SPDM. The transport binding for SPDM is defined in the
> > DMTF DSP0286.
> >
> > Signed-off-by: Wilfred
On 2025/01/16 1:14, Peter Xu wrote:
On Thu, Jan 16, 2025 at 12:52:56AM +0900, Akihiko Odaki wrote:
Functionally, the ordering of container/subregion finalization matters if
some device tries to a container during finalization. In such a case,
|
^ so
On 2025/01/16 0:01, Nicholas Piggin wrote:
The e1000e and igb tests don't clear the msix pending bit after waiting
for it, as it is masked so the irq doesn't get sent. This means all
subsequent waits for the interrupt does not wait or verify the interrupt
was generated, affecting the multiple_tra
On Fri, Jan 10, 2025 at 10:03:26AM +, David Woodhouse wrote:
> From: David Woodhouse
>
> Signed-off-by: David Woodhouse
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
On Fri, Jan 10, 2025 at 10:03:25AM +, David Woodhouse wrote:
> From: David Woodhouse
>
> Now that xs_node_read() can construct a node path, no need to open-code it.
>
> Signed-off-by: David Woodhouse
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
On Fri, Jan 10, 2025 at 10:35:31AM +0100, Roger Pau Monne wrote:
> diff --git a/hw/char/xen_console.c b/hw/char/xen_console.c
> index ef0c2912efa1..989e75fef88f 100644
> --- a/hw/char/xen_console.c
> +++ b/hw/char/xen_console.c
> @@ -550,7 +550,8 @@ static void xen_console_device_create(XenBackendI
On Fri, Jan 10, 2025 at 10:03:24AM +, David Woodhouse wrote:
> From: David Woodhouse
>
> Now that xs_node_read() can construct a node path, no need to open-code it.
>
> Signed-off-by: David Woodhouse
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
On 2025/01/15 22:43, Peter Xu wrote:
On Wed, Jan 15, 2025 at 01:46:29PM +0900, Akihiko Odaki wrote:
On 2025/01/15 2:02, Peter Xu wrote:
On Tue, Jan 14, 2025 at 05:43:09PM +0900, Akihiko Odaki wrote:
memory_region_finalize() is not a function to tell the owner is leaving, but
the memory region
From: Roger Pau Monne
The 'm' parameter used to request auto-allocation of the destination variable
is not supported on FreeBSD, and as such leads to failures to parse.
What's more, the current usage of '%ms' with xs_node_scanf() is pointless, as
it just leads to a double allocation of the same
From: David Woodhouse
When attempting to read the 'output' node, interpret any error *other*
than ENOENT as a fatal error. For ENOENT, fall back to serial_hd() to
find a character device, or create a null device.
Do not attempt to prepend to errp when serial_hd() fails; the error
isn't relevant
Add a new xs_node_read() helper function which constructs the node path
using a printf format string, and use it where appropriate.
In particular, use it to eliminate the use of the %ms format specifier
for scanf(), which doesn't exist in FreeBSD.
v3:
• Further cleanups using xs_node_read().
From: David Woodhouse
This returns the full contents of the node, having created the node path
from the printf-style format string provided in its arguments.
This will save various callers from having to do so for themselves (and
from using xs_node_scanf() with the non-portable %ms format string
On Wed, Jan 15, 2025 at 04:27:19PM +, David Woodhouse wrote:
> From: David Woodhouse
>
> This returns the full contents of the node, having created the node path
> from the printf-style format string provided in its arguments.
>
> This will save various callers from having to do so for thems
From: David Woodhouse
Signed-off-by: David Woodhouse
Reviewed-by: Anthony PERARD
Acked-by: Roger Pau Monné
---
hw/xen/xen_pvdev.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/hw/xen/xen_pvdev.c b/hw/xen/xen_pvdev.c
index c5ad71e8dc..c9143ba259 100644
--- a/hw/xen/
From: David Woodhouse
Now that xs_node_read() can construct a node path, no need to open-code it.
Signed-off-by: David Woodhouse
Reviewed-by: Anthony PERARD
Acked-by: Roger Pau Monné
---
hw/net/xen_nic.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/hw/net
From: David Woodhouse
Now that xs_node_read() can construct a node path, no need to open-code it.
Signed-off-by: David Woodhouse
Reviewed-by: Anthony PERARD
Acked-by: Roger Pau Monné
---
hw/char/xen_console.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --gi
From: David Woodhouse
Reduce some duplication.
Signed-off-by: David Woodhouse
Reviewed-by: Anthony PERARD
Acked-by: Roger Pau Monné
---
hw/xen/trace-events | 1 -
hw/xen/xen-bus-helper.c | 15 ++-
2 files changed, 6 insertions(+), 10 deletions(-)
diff --git a/hw/xen/trace-e
On Wed, Jan 15, 2025 at 04:27:20PM +, David Woodhouse wrote:
> From: Roger Pau Monne
>
> The 'm' parameter used to request auto-allocation of the destination variable
> is not supported on FreeBSD, and as such leads to failures to parse.
>
> What's more, the current usage of '%ms' with xs_no
On 15/01/2025 4:27 pm, David Woodhouse wrote:
> diff --git a/hw/xen/xen-bus.c b/hw/xen/xen-bus.c
> index adfc4efad0..85b92cded4 100644
> --- a/hw/xen/xen-bus.c
> +++ b/hw/xen/xen-bus.c
> @@ -650,6 +650,16 @@ int xen_device_frontend_scanf(XenDevice *xendev, const
> char *key,
> return rc;
> }
On Wed, Jan 15, 2025 at 04:27:25PM +, David Woodhouse wrote:
> diff --git a/hw/char/xen_console.c b/hw/char/xen_console.c
> index e61902461b..9e7f6da343 100644
> --- a/hw/char/xen_console.c
> +++ b/hw/char/xen_console.c
> @@ -581,19 +581,27 @@ static void
> xen_console_device_create(XenBackend
On Fri, Jan 10, 2025 at 10:03:23AM +, David Woodhouse wrote:
> From: David Woodhouse
>
> Reduce some duplication.
>
> Signed-off-by: David Woodhouse
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
On Wed, 2025-01-15 at 15:34 +0100, Roger Pau Monné wrote:
> On Fri, Jan 10, 2025 at 10:02:53AM +, David Woodhouse wrote:
> > On Fri, 2025-01-10 at 10:35 +0100, Roger Pau Monne wrote:
> > > Hello,
> > >
> > > First patch from David introduces a new helper to fetch xenstore nodes,
> > > while se
On Fri, Jan 10, 2025 at 10:02:53AM +, David Woodhouse wrote:
> On Fri, 2025-01-10 at 10:35 +0100, Roger Pau Monne wrote:
> > Hello,
> >
> > First patch from David introduces a new helper to fetch xenstore nodes,
> > while second patch removes the usage of scanf related functions with the
> > "
On Sun, Jan 12, 2025 at 10:00:45PM +0100, Phil Dennis-Jordan wrote:
> This patch set introduces a new ARM and macOS HVF specific machine type
> called "vmapple". There are also some patches for fixing XHCI spec
> compliance issues and adding a workaround to a quirk in the macOS guest's
> XHCI drive
On Wed, Jan 15, 2025 at 04:33:45PM +0100, Phil Dennis-Jordan wrote:
>
>
> On Wed, 15 Jan 2025 at 16:08, Michael S. Tsirkin wrote:
>
> On Sun, Jan 12, 2025 at 10:00:45PM +0100, Phil Dennis-Jordan wrote:
> > This patch set introduces a new ARM and macOS HVF specific machine type
> > c
On Wed, Jan 15, 2025 at 11:54:56PM +0900, Akihiko Odaki wrote:
> On 2025/01/15 22:43, Peter Xu wrote:
> > On Wed, Jan 15, 2025 at 01:46:29PM +0900, Akihiko Odaki wrote:
> > > On 2025/01/15 2:02, Peter Xu wrote:
> > > > On Tue, Jan 14, 2025 at 05:43:09PM +0900, Akihiko Odaki wrote:
> > > > > memory_
On Thu, Jan 16, 2025 at 12:52:56AM +0900, Akihiko Odaki wrote:
> Functionally, the ordering of container/subregion finalization matters if
> some device tries to a container during finalization. In such a case,
|
^ something is missing here, feel free to
On 11/1/25 19:37, Bernhard Beschow wrote:
Signed-off-by: Bernhard Beschow
---
hw/sd/sd.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
See question on v1:
https://lore.kernel.org/qemu-devel/e202623e-eac7-4ed3-87fb-002491ddf...@linaro.org/
Add assertions to ensure a BAR is not mapped twice, and only
previously mapped BARs are unmapped. This can help catch some
bugs.
Cc: Michael S. Tsirkin
Cc: Marcel Apfelbaum
Reviewed-by: Fabiano Rosas
Signed-off-by: Nicholas Piggin
---
tests/qtest/libqos/ahci.h | 1 +
tests/qtest/libqos
The e1000e and igb tests do not clear the ICR/EICR cause bits (or
set auto-clear) on seeing queue interrupts, which inhibits the
triggering of a new interrupt.
Fix this by clearing the cause bits, and verify that the expected
cause bit was set.
Cc: Michael S. Tsirkin
Cc: Marcel Apfelbaum
Cc: Dm
This series fixes some iomap balance issues and enables msix
sharing bar0, which will be required for some future XHCI
test cases.
It also removes the invalid write to msix PBA memory by
qtest, and fixes that properly by unmasking and taking
delivery of the msix interrupt in e1000e and igb tests,
The PCI Local Bus Specification says the result of writes to MSI-X
PBA memory is undefined. QEMU implements them as no-ops, so remove
the pointless write from qpci_msix_pending().
Cc: Michael S. Tsirkin
Cc: Marcel Apfelbaum
Cc: Dmitry Fleytman
Cc: Akihiko Odaki
Cc: Sriram Yagnaraman
Signed-of
The e1000e and igb tests don't clear the msix pending bit after waiting
for it, as it is masked so the irq doesn't get sent. This means all
subsequent waits for the interrupt does not wait or verify the interrupt
was generated, affecting the multiple_transfers tests.
To fix this, have device setup
Devices where the MSI-X addresses are shared with other MMIO on BAR0
can not use msi_enable because it unmaps and remaps BAR0, which
interferes with device MMIO mappings. xhci-nec is one such device we
would like to test msix with.
Use the BAR iomap tracking structure introduced in the previous ch
On Wed, 15 Jan 2025 at 16:08, Michael S. Tsirkin wrote:
> On Sun, Jan 12, 2025 at 10:00:45PM +0100, Phil Dennis-Jordan wrote:
> > This patch set introduces a new ARM and macOS HVF specific machine type
> > called "vmapple". There are also some patches for fixing XHCI spec
> > compliance issues an
On 2025/01/16 0:40, Peter Xu wrote:
On Wed, Jan 15, 2025 at 11:54:56PM +0900, Akihiko Odaki wrote:
On 2025/01/15 22:43, Peter Xu wrote:
On Wed, Jan 15, 2025 at 01:46:29PM +0900, Akihiko Odaki wrote:
On 2025/01/15 2:02, Peter Xu wrote:
On Tue, Jan 14, 2025 at 05:43:09PM +0900, Akihiko Odaki wr
On Wed, 2025-01-15 at 15:36 +0100, Anthony PERARD wrote:
> On Fri, Jan 10, 2025 at 10:35:31AM +0100, Roger Pau Monne wrote:
> > diff --git a/hw/char/xen_console.c b/hw/char/xen_console.c
> > index ef0c2912efa1..989e75fef88f 100644
> > --- a/hw/char/xen_console.c
> > +++ b/hw/char/xen_console.c
> >
The interrupt enable registers are not reset to 0 but some bits are
enabled on reset. At least some U-Boot versions seem to expect this
and not initialise these registers before expecting interrupts. The
numbers in this patch match what QorIQ P1022 has on reset and fix
U-Boot for this SoC and shoul
On 2025/01/13 6:00, Phil Dennis-Jordan wrote:
From: Alexander Graf
Apple has its own virtio-blk PCI device ID where it deviates from the
official virtio-pci spec slightly: It puts a new "apple type"
field at a static offset in config space and introduces a new barrier
command.
This patch first
On Wed, 2025-01-15 at 17:49 +0100, Anthony PERARD wrote:
>
> With those fixed: Reviewed-by: Anthony PERARD
Thanks. I've pushed those changes and am watching the pipeline at
https://gitlab.com/dwmw2/qemu/-/pipelines/1626804720
I'll probably send a pull request tomorrow. The patch now looks like
71 matches
Mail list logo
