[issue15437] Merge Doc/ACKS.txt names into Misc/ACKS

2012-08-06 Thread Chris Jerdonek
Chris Jerdonek added the comment: For completeness, I am attaching the modified version of the script that was used to generate the latest output. -- Added file: http://bugs.python.org/file26712/merge-acks-2.py ___ Python tracker <h

[issue15543] central documentation for 'universal newlines'

2012-08-06 Thread Chris Jerdonek
Chris Jerdonek added the comment: Updating patch to current tip. -- Added file: http://bugs.python.org/file26714/issue-15543-2.patch ___ Python tracker <http://bugs.python.org/issue15

[issue15569] Dev Guide format-only roles

2012-08-06 Thread Chris Jerdonek
New submission from Chris Jerdonek: After the section describing roles that create cross-references to C-language constructs, the Dev Guide says this, "The following roles don’t do anything special except formatting the text in a different style." http://hg.python.org/dev

[issue15571] Python version of TextIOWrapper ignores "write_through" arg

2012-08-07 Thread Chris Jerdonek
Chris Jerdonek added the comment: The fact that the Python implementation doesn't look at write_through doesn't necessarily mean that it's not respected. It could always write through. Indeed, it looks like this is the case and was discussed at one point: http://bugs.python

[issue15571] Python version of TextIOWrapper ignores "write_through" arg

2012-08-07 Thread Chris Jerdonek
Chris Jerdonek added the comment: Attaching patch. -- keywords: +patch Added file: http://bugs.python.org/file26716/issue-15571-1.patch ___ Python tracker <http://bugs.python.org/issue15

[issue15580] fix True/False/None reST markup

2012-08-07 Thread Chris Jerdonek
New submission from Chris Jerdonek: The Dev Guide says not to markup True, False, and None in the documentation in a way that generates a link (e.g. ":const:`True`") because "they’re fundamental to the language and should be known to any programmer": http://docs

[issue15580] fix True/False/None reST markup

2012-08-07 Thread Chris Jerdonek
Chris Jerdonek added the comment: Here is a command to find the file names of all occurrences: find Doc -type f -name *.rst | xargs grep -ERl ":const:\`(True|False|None)\`" The occurrences are in the following directories: Doc/c-api/ Doc/library/ Doc/reference/ Doc/whatsnew/ An

[issue15510] textwrap.wrap('') returns empty list

2012-08-07 Thread Chris Jerdonek
Chris Jerdonek added the comment: Thanks for weighing in, Greg! At least for me, this edge case was important because it determines how the canonical advice or recipe for handling multiple paragraphs behaves when the input string has line breaks in between paragraphs. That advice, of course

[issue15580] fix True/False/None reST markup

2012-08-07 Thread Chris Jerdonek
Changes by Chris Jerdonek : -- stage: -> patch review versions: +Python 2.7, Python 3.2, Python 3.3 ___ Python tracker <http://bugs.python.org/issu

[issue15561] update subprocess docs to reference io.TextIOWrapper

2012-08-07 Thread Chris Jerdonek
Chris Jerdonek added the comment: io module experts: Can one of you review this minor change to the subprocess documentation to make it reference the newly added io.TextIOWrapper documentation changes? For background purposes, digging back, it looks like the original change to subprocess was

[issue15580] fix True/False/None reST markup

2012-08-07 Thread Chris Jerdonek
Chris Jerdonek added the comment: Yes, I can see the trade off. However, is there a sense in which the situation for documentation could be different from the situation for code? With code, style and refactoring changes cause churn without directly benefiting the end user (because code is

[issue15592] subprocess.communicate() breaks on no input with universal newlines true

2012-08-08 Thread Chris Jerdonek
New submission from Chris Jerdonek: Popen.communicate() raises an exception if passed no input when stdin=PIPE and universal_newlines=True. With universal_newlines=False, no exception is raised. For example, the following yields-- args = [sys.executable, '-c', 'pass']

[issue15592] subprocess.communicate() breaks on no input with universal newlines true

2012-08-08 Thread Chris Jerdonek
Chris Jerdonek added the comment: See issue 12623 for another issue related to communicate() and universal newline support. -- nosy: +pitrou ___ Python tracker <http://bugs.python.org/issue15

[issue15595] subprocess.Popen(universal_newlines=True) does not work for certain locales

2012-08-08 Thread Chris Jerdonek
New submission from Chris Jerdonek: subprocess.Popen() with universal_newlines=True does not convert line breaks correctly when the preferred encoding is UTF-16. For example, the following code-- code = r"import sys; sys.stdout.buffer.write('a\r\nb'.encode('utf-16')

[issue15595] subprocess.Popen(universal_newlines=True) does not work for certain locales

2012-08-08 Thread Chris Jerdonek
Chris Jerdonek added the comment: Attaching patch for review. -- stage: needs patch -> patch review Added file: http://bugs.python.org/file26729/issue-15595-1.patch ___ Python tracker <http://bugs.python.org/issu

[issue15595] subprocess.Popen(universal_newlines=True) does not work for certain locales

2012-08-08 Thread Chris Jerdonek
Chris Jerdonek added the comment: Victor, I have not personally experienced this issue. I just noticed that the order of operations is wrong or not portable in the _translate_newlines() method when I was looking at the code for another reason

[issue15595] subprocess.Popen(universal_newlines=True) does not work for certain locales

2012-08-08 Thread Chris Jerdonek
Chris Jerdonek added the comment: > How do you set the locale encoding to UTF-16? Do you mean UTF-16, UTF-16-LE > or UTF-16-BE? I confirmed that the issue occurs for all of these. For testing purposes, you can do-- locale.getpreferredencoding = lambda do_setlocale: &

[issue15595] subprocess.Popen(universal_newlines=True) does not work for certain locales

2012-08-08 Thread Chris Jerdonek
Chris Jerdonek added the comment: Thanks for your comments. > FYI it's not directly Popen() which uses the locale encoding, but > TextIOWrapper. Yes, I will note that to be more clear. Would you like me to add tests for UTF-16-LE, etc. (via a helper test method), or will U

[issue15595] subprocess.Popen(universal_newlines=True) does not work for certain locales

2012-08-08 Thread Chris Jerdonek
Chris Jerdonek added the comment: Updating patch with Victor's comments. -- Added file: http://bugs.python.org/file26733/issue-15595-2.patch ___ Python tracker <http://bugs.python.org/is

[issue15595] subprocess.Popen(universal_newlines=True) does not work for certain locales

2012-08-08 Thread Chris Jerdonek
Chris Jerdonek added the comment: It looks like this also affects 3.2, but I will need to modify the test slightly because in 3.2, TextIOWrapper calls locale.getpreferredencoding() without any arguments. -- versions: +Python 3.2 ___ Python tracker

[issue15595] subprocess.Popen(universal_newlines=True) does not work for certain locales

2012-08-08 Thread Chris Jerdonek
Chris Jerdonek added the comment: Here is a patch also suitable for applying to Python 3.2. -- Added file: http://bugs.python.org/file26734/issue-15595-3.patch ___ Python tracker <http://bugs.python.org/issue15

[issue15457] consistent treatment of generator terminology

2012-08-09 Thread Chris Jerdonek
Chris Jerdonek added the comment: Note to reviewers: changing to "needs patch" because I want to make changes to the latest patch before this is reviewed (e.g. to the index directives). I should be able to do this by the end of the weekend. -- stage: ->

[issue15355] generator docs should mention already-executing exception

2012-08-09 Thread Chris Jerdonek
Chris Jerdonek added the comment: Nick, would you be able to take a look at this minor documentation patch re: generators? Would you prefer this blanket statement, or an explicit (possibly repeated) statement inside the documentation of each method? -- versions: +Python 2.7, Python

[issue15600] expose the finder details used by the FileFinder path hook

2012-08-09 Thread Chris Jerdonek
Chris Jerdonek added the comment: It seems like a test and documentation for this would be beneficial (for the usual reasons, etc). -- nosy: +cjerdonek ___ Python tracker <http://bugs.python.org/issue15

[issue11643] Use |version| instead of X.Y in the doc

2012-08-09 Thread Chris Jerdonek
Changes by Chris Jerdonek : -- nosy: +cjerdonek ___ Python tracker <http://bugs.python.org/issue11643> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue15561] update subprocess docs to reference io.TextIOWrapper

2012-08-09 Thread Chris Jerdonek
Chris Jerdonek added the comment: In the process of working on issue 15595, I noticed that the documentation change will need to be slightly different for Python 3.2 than for 3.3. In 3.2, it is locale.getpreferredencoding() (which defaults to do_setlocale=True) instead of

[issue15605] Explain sphinx documentation building in devguide

2012-08-09 Thread Chris Jerdonek
Chris Jerdonek added the comment: +If you are building the developer's guide, or for some other reason can not use +the `tools/sphinx-build.py` file, you can also run the following command from +the directory containing `conf.py` :: + + sphinx-build -b . build/ Note that the

[issue15555] Default newlines of io.TextIOWrapper

2012-08-09 Thread Chris Jerdonek
Chris Jerdonek added the comment: What is the change to the documentation being suggested here? The code does reference os.linesep, so it seems like the documentation is correct, or am I missing something? self._writetranslate = newline != '' self._writenl =

[issue15561] update subprocess docs to reference io.TextIOWrapper

2012-08-09 Thread Chris Jerdonek
Changes by Chris Jerdonek : Added file: http://bugs.python.org/file26747/issue-15561-2-branch-32.patch ___ Python tracker <http://bugs.python.org/issue15561> ___ ___ Pytho

[issue15561] update subprocess docs to reference io.TextIOWrapper

2012-08-09 Thread Chris Jerdonek
Chris Jerdonek added the comment: I have uploaded updated patches for both 3.2 and the default branch. Thanks, Andrew. -- Added file: http://bugs.python.org/file26748/issue-15561-2-branch-default.patch ___ Python tracker <http://bugs.python.

[issue15611] devguide: add "core mentors" area to Experts Index

2012-08-09 Thread Chris Jerdonek
New submission from Chris Jerdonek: On the core-mentorship list, Nick Coghlan suggested adding an "area" to the Experts Index for core developers who are on the core-mentorship list (or at least those who wish to be listed). This issue is to do that. This can be done by adding a

[issue15611] devguide: add "core mentors" area to Experts Index

2012-08-09 Thread Chris Jerdonek
Chris Jerdonek added the comment: > I think you should better define the goal of this new section. I see your point and may not have fully understood the intent. I'll defer to Nick on this since the initial suggestion was his. I'm not personally wedded to any particular reso

[issue15444] Incorrectly written contributor's names

2012-08-09 Thread Chris Jerdonek
Chris Jerdonek added the comment: > While working on issue 15437, it occurred to me that storing the names in a > structured form might come in handy. In a separate discussion, Ezio pointed out a case where we are already scraping data about members from doc files: http://hg.pyth

[issue15527] Double parens in functions references

2012-08-10 Thread Chris Jerdonek
Chris Jerdonek added the comment: - a distinct non-*NULL* pointer if possible, as if :c:func:`PyMem_Malloc(1)` had + a distinct non-*NULL* pointer if possible, as if ``PyMem_Malloc(1)`` had > From my perspective sphinx doesn't allow notations like > :c:func:`PyMem_Malloc(1)`

[issue15622] struct module 'c' specifier does not follow PEP-3118

2012-08-11 Thread Chris Jerdonek
Chris Jerdonek added the comment: > Status was still open. Was that a tracker bug? -- nosy: +cjerdonek ___ Python tracker <http://bugs.python.org/issu

[issue15557] Tests for webbrowser module

2012-08-11 Thread Chris Jerdonek
Chris Jerdonek added the comment: It seems like these tests can be made more DRY. For example, the line `args = popen.cmd_line` appears in every test. You could make an assert_args() helper method to address this. There also seems to be a lot of overlap between tests for each browser. A

[issue15561] update subprocess docs to reference io.TextIOWrapper

2012-08-11 Thread Chris Jerdonek
Chris Jerdonek added the comment: > Can you reflect this fact in your patches? Sure. (Though for stdin '\n' is converted to os.linesep and no more.) Would you mind if I also updated the following part of the subprocess documentation to reference the part we are updating

[issue15624] clarify io.TextIOWrapper newline documentation

2012-08-11 Thread Chris Jerdonek
New submission from Chris Jerdonek: The documentation of io.TextIOWrapper's newline argument is somewhat confusing and perhaps reversed from what was intended. (For example, the subprocess module uses the reverse terminology.) Either way, it can be improved somewhat. Currently, it

[issue15624] clarify io.TextIOWrapper newline documentation

2012-08-11 Thread Chris Jerdonek
Chris Jerdonek added the comment: Andrew, I'm adding you because this is the documentation that the subprocess module will point to after issue 15561. -- nosy: +asvetlov ___ Python tracker <http://bugs.python.org/is

[issue15611] devguide: add "core mentors" area to Experts Index

2012-08-11 Thread Chris Jerdonek
Chris Jerdonek added the comment: Here is an initial patch based on the core developers who responded on core-mentorship. In response to Ezio's comment (after thinking further), I think the goal would be to provide a list of people that new contributors should feel welcome to add to the

[issue15626] unittest.main negates -bb option and programmatic warning configuration

2012-08-11 Thread Chris Jerdonek
Changes by Chris Jerdonek : -- nosy: +cjerdonek ___ Python tracker <http://bugs.python.org/issue15626> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue10848] Move test.regrtest from getopt to argparse

2012-08-12 Thread Chris Jerdonek
Chris Jerdonek added the comment: I just discovered that issue 15302, which has a patch awaiting review from a month ago as well as some discussion, is a duplicate of this issue. Would it be possible to leave that issue open (retitling either or both issues if necessary to avoid overlap

[issue15629] Run doctests in Doc/*.rst as part of regrtest

2012-08-12 Thread Chris Jerdonek
New submission from Chris Jerdonek: This issue is to start running (at least some of) the doctests in the Doc/ folder's *.rst files as part of regrtest. We will need a whitelist mechanism to tell regrtest which files to process since currently many doctests are not runnable (e.g. some ki

[issue15629] Run doctests in Doc/*.rst as part of regrtest

2012-08-12 Thread Chris Jerdonek
Chris Jerdonek added the comment: One option for whitelisting files would be to subclass doctest.DocTestParser and pass an instance as the parser argument to doctest.DocFileSuite: http://docs.python.org/dev/library/doctest.html#doctest.DocFileSuite The custom parser could look for the per

[issue15629] Run doctests in Doc/*.rst as part of regrtest

2012-08-12 Thread Chris Jerdonek
Chris Jerdonek added the comment: > Might it be simpler to run doctest over the rst file from the relevant > unittest? (Perhaps with help from test.support.) If I understand correctly, do you mean for example that Lib/test/test_textwrap.py could be responsible for loading the docte

[issue15629] Run doctests in Doc/*.rst as part of regrtest

2012-08-12 Thread Chris Jerdonek
Chris Jerdonek added the comment: > I'm not sure running these tests as part of regrtest is a good idea. Can you provide reasons? -- ___ Python tracker <http://bugs.python.org

[issue15557] Tests for webbrowser module

2012-08-12 Thread Chris Jerdonek
Chris Jerdonek added the comment: It still seems like things could be made more DRY. Also, the pattern of having assert_unix_browser() execute various function blocks depending on whether various arguments are not None doesn't seem as clean or scalable as it should be (e.g. if the numb

[issue15630] Missing "continue" example for "for" loop tutorial

2012-08-12 Thread Chris Jerdonek
Chris Jerdonek added the comment: > Please remove the "... " prompt from the example so that the code is > cut-and-pasteable by people who want to experiment with the example. That is the usual format for docstring examples. See, for example-- http://docs.python.org/dev/libr

[issue15557] Tests for webbrowser module

2012-08-12 Thread Chris Jerdonek
Chris Jerdonek added the comment: Thanks, Anton. It is looking a lot better now. I still have comments, but because my comments have not been on the substance of the patch and because I am not a core developer, I will defer to others at this point

[issue15624] clarify newline documentation for open and io.TextIOWrapper.

2012-08-13 Thread Chris Jerdonek
Chris Jerdonek added the comment: Thanks a lot, Andrew. -- ___ Python tracker <http://bugs.python.org/issue15624> ___ ___ Python-bugs-list mailing list Unsub

[issue15561] update subprocess docs to reference io.TextIOWrapper

2012-08-13 Thread Chris Jerdonek
Chris Jerdonek added the comment: Yes, that too. :) I am working on it. -- ___ Python tracker <http://bugs.python.org/issue15561> ___ ___ Python-bugs-list mailin

[issue15555] Default newlines of io.TextIOWrapper

2012-08-13 Thread Chris Jerdonek
Chris Jerdonek added the comment: I think it can be useful for testing reasons (e.g. testing that os.linesep is respected by certain code). -- ___ Python tracker <http://bugs.python.org/issue15

[issue15638] incorrect version info for TextIOWrapper write_through docs

2012-08-13 Thread Chris Jerdonek
New submission from Chris Jerdonek: The io.TextIOWrapper documentation says that the write_through argument was added in version 3.3: "Changed in version 3.3: The write_through argument has been added." http://docs.python.org/dev/library/io.html#io.TextIOWrapper However, it s

[issue15561] update subprocess docs to reference io.TextIOWrapper

2012-08-13 Thread Chris Jerdonek
Chris Jerdonek added the comment: For 3.2 to mention write_through, issue 15638 should probably be fixed first. I can create a patch for that first. -- dependencies: +incorrect version info for TextIOWrapper write_through docs ___ Python tracker

[issue15595] subprocess.Popen(universal_newlines=True) does not work for certain locales

2012-08-13 Thread Chris Jerdonek
Changes by Chris Jerdonek : -- nosy: +asvetlov ___ Python tracker <http://bugs.python.org/issue15595> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue15638] incorrect version info for TextIOWrapper write_through docs

2012-08-13 Thread Chris Jerdonek
Chris Jerdonek added the comment: The C version seems to have it in 3.2 as well: http://hg.python.org/cpython/file/5b629e9fde61/Modules/_io/textio.c#l818 Is it possible you were thinking of issue 15571 (not "used" in Python version but still

[issue15561] update subprocess docs to reference io.TextIOWrapper

2012-08-13 Thread Chris Jerdonek
Chris Jerdonek added the comment: > As I can see in subprocess.py TextIOWrapper is applied to stdin also in > non-buffered (write_through=True) mode. In 3.2, I will not mention the write_through argument based on Antoine's response to

[issue15638] incorrect version info for TextIOWrapper write_through docs

2012-08-13 Thread Chris Jerdonek
Chris Jerdonek added the comment: Ah, thank you. I see. -- ___ Python tracker <http://bugs.python.org/issue15638> ___ ___ Python-bugs-list mailing list Unsub

[issue15592] subprocess.communicate() breaks on no input with universal newlines true

2012-08-13 Thread Chris Jerdonek
Chris Jerdonek added the comment: > From my perspective input should be encoded (converted to bytes) if it is str > regardless of universal_newlines value. I don't know the reason, but the limitation is documented: "The optional input argument should be data to be sent to t

[issue15561] update subprocess docs to reference io.TextIOWrapper

2012-08-13 Thread Chris Jerdonek
Chris Jerdonek added the comment: Andrew, here is the new patch for 3.2. 3.3 will come shortly after. -- Added file: http://bugs.python.org/file26783/issue-15561-3-branch-32.patch ___ Python tracker <http://bugs.python.org/issue15

[issue15561] update subprocess docs to reference io.TextIOWrapper

2012-08-13 Thread Chris Jerdonek
Chris Jerdonek added the comment: Here is the patch for the default/3.3 branch, which for convenience is a diff for the branch *after the 3.2 patch has been forward-ported to 3.3*. I did not think it was necessary to mention write_through specifically since it seems more like an

[issue15592] subprocess.communicate() breaks on no input with universal newlines true

2012-08-13 Thread Chris Jerdonek
Chris Jerdonek added the comment: This issue may be the bug referenced here: # BUG: can't give a non-empty stdin because it breaks both the # select- and poll-based communicate() implementations. (stdout, stderr) = p.communicate() http://hg.python.org/cpython/file/843e0da7e91f/Lib

[issue15561] update subprocess docs to reference io.TextIOWrapper

2012-08-13 Thread Chris Jerdonek
Chris Jerdonek added the comment: > Fixed. BTW I prefer to use «stream» as alias to file object Thanks a lot, Andrew. Yes, I agree and actually contemplated doing that myself. -- ___ Python tracker <http://bugs.python.org/issu

[issue15497] correct characters in TextWrapper.replace_whitespace docs

2012-08-13 Thread Chris Jerdonek
Changes by Chris Jerdonek : -- nosy: +asvetlov versions: +Python 3.2 ___ Python tracker <http://bugs.python.org/issue15497> ___ ___ Python-bugs-list mailin

[issue15437] Merge Doc/ACKS.txt names into Misc/ACKS

2012-08-13 Thread Chris Jerdonek
Changes by Chris Jerdonek : -- nosy: +asvetlov ___ Python tracker <http://bugs.python.org/issue15437> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue15592] subprocess.communicate() breaks on no input with universal newlines true

2012-08-13 Thread Chris Jerdonek
Chris Jerdonek added the comment: Attaching a failing test case. Also, to confirm, this issue does not seem to affect 3.2. -- keywords: +patch Added file: http://bugs.python.org/file26787/failing-test-case-1.patch ___ Python tracker <h

[issue15592] subprocess.communicate() breaks on no input with universal newlines true

2012-08-13 Thread Chris Jerdonek
Changes by Chris Jerdonek : -- stage: test needed -> needs patch ___ Python tracker <http://bugs.python.org/issue15592> ___ ___ Python-bugs-list mailing list Un

[issue14649] doctest.DocTestSuite error misleading when module has no docstrings

2012-08-13 Thread Chris Jerdonek
Changes by Chris Jerdonek : -- nosy: +asvetlov ___ Python tracker <http://bugs.python.org/issue14649> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue15592] subprocess.communicate() breaks on no input with universal newlines true

2012-08-13 Thread Chris Jerdonek
Chris Jerdonek added the comment: Attaching patch. -- stage: needs patch -> patch review Added file: http://bugs.python.org/file26788/issue-15592-1.patch ___ Python tracker <http://bugs.python.org/issu

[issue15269] Document dircmp.left and dircmp.right

2012-08-13 Thread Chris Jerdonek
Changes by Chris Jerdonek : -- nosy: +asvetlov ___ Python tracker <http://bugs.python.org/issue15269> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue15322] sysconfig.get_config_var('srcdir') returns unexpected value

2012-08-13 Thread Chris Jerdonek
Chris Jerdonek added the comment: It seems to be fixed now. Thanks. -- status: pending -> open ___ Python tracker <http://bugs.python.org/issue15322> ___ _

[issue15543] central documentation for 'universal newlines'

2012-08-13 Thread Chris Jerdonek
Chris Jerdonek added the comment: Updating patch to latest again. -- nosy: +asvetlov Added file: http://bugs.python.org/file26792/issue-15543-3.patch ___ Python tracker <http://bugs.python.org/issue15

[issue12623] "universal newlines" subprocess support broken with select- and poll-based communicate()

2012-08-13 Thread Chris Jerdonek
Changes by Chris Jerdonek : -- nosy: +cjerdonek ___ Python tracker <http://bugs.python.org/issue12623> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue15543] central documentation for 'universal newlines'

2012-08-13 Thread Chris Jerdonek
Chris Jerdonek added the comment: Sure, you're welcome. And sounds good, I'll change it. The singular was the prevailing form, but you're right that there is no reason we can't change it. -- ___ Python tracker <http://bug

[issue15543] central documentation for 'universal newlines'

2012-08-13 Thread Chris Jerdonek
Chris Jerdonek added the comment: Is it worth standardizing on "universal newlines mode" in the code as well (docstrings, etc)? There are about ten occurrences of "universal newline mode" that would need to be changed. -- ___ P

[issue15543] central documentation for 'universal newlines'

2012-08-13 Thread Chris Jerdonek
Chris Jerdonek added the comment: Here is a new patch with David's suggested change (just for doc files though). -- Added file: http://bugs.python.org/file26796/issue-15543-4.patch ___ Python tracker <http://bugs.python.org/is

[issue15269] Document dircmp.left and dircmp.right

2012-08-14 Thread Chris Jerdonek
Chris Jerdonek added the comment: Thanks a lot, Senthil. I appreciate it. -- ___ Python tracker <http://bugs.python.org/issue15269> ___ ___ Python-bugs-list m

[issue15543] central documentation for 'universal newlines'

2012-08-14 Thread Chris Jerdonek
Chris Jerdonek added the comment: Updating patch to tip again. -- Added file: http://bugs.python.org/file26799/issue-15543-5.patch ___ Python tracker <http://bugs.python.org/issue15

[issue6135] subprocess seems to use local encoding and give no choice

2012-08-14 Thread Chris Jerdonek
Chris Jerdonek added the comment: > > only one Popen instance (for the iconv call), but different encodings > > for stdin and stdout. > Isn't that the exception rather than the rule? I think it actually makes > sense, in at least 99.83% of cases ;-), to have a common enc

[issue15648] stderr "refs" output does not respect PYTHONIOENCODING

2012-08-14 Thread Chris Jerdonek
New submission from Chris Jerdonek: The --help documentation for the python executable says-- PYTHONIOENCODING: Encoding[:errors] used for stdin/stdout/stderr. However, PYTHONIOENCODING doesn't seem to be respected for the python executable's "refs" output to stderr

[issue15592] subprocess.communicate() breaks on no input with universal newlines true

2012-08-14 Thread Chris Jerdonek
Chris Jerdonek added the comment: Thanks, Andrew! -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python.or

[issue15649] subprocess.Popen.communicate: accept str for input parameter if universal_newlines is False

2012-08-14 Thread Chris Jerdonek
Chris Jerdonek added the comment: > What to do if stdin doesn't have `encoding` attribute? Convert to bytes using > filesystemencoding? If choosing an encoding, it probably makes sense to default to the same as for when universal_newlines=True, namely locale.getpreferredenc

[issue6135] subprocess seems to use local encoding and give no choice

2012-08-14 Thread Chris Jerdonek
Chris Jerdonek added the comment: To my previous comment, issue 15648 shows the case where I was able to change the encoding for stdout in the child process but not stderr (which would require supporting two encodings in Popen to handle

[issue14649] doctest.DocTestSuite error misleading when module has no docstrings

2012-08-14 Thread Chris Jerdonek
Chris Jerdonek added the comment: > Every doctest is docstring from tested module, but not every docstring is a > valid doctest. Actually, I'm not sure even this is correct. doctest will form a unittest *TestSuite* from a module if it has docstrings, but it will not necessaril

[issue14649] doctest.DocTestSuite error misleading when module has no docstrings

2012-08-14 Thread Chris Jerdonek
Chris Jerdonek added the comment: > I suspect the intent was to raise an error if there were no *tests*, not if > there were no docstrings. That, or the implementor thought that if no docstrings were found, then that might indicate something went wrong with the parsing. For back

[issue15269] Document dircmp.left and dircmp.right

2012-08-14 Thread Chris Jerdonek
Chris Jerdonek added the comment: Senthil, here is a recent e-mail and response in which I asked about documentation changes and adding tests during feature freeze: http://mail.python.org/pipermail/python-dev/2012-July/121138.html Also, here is a recent example of a documentation

[issue14649] doctest.DocTestSuite error misleading when module has no docstrings

2012-08-14 Thread Chris Jerdonek
Chris Jerdonek added the comment: The problem seems to be restricted only to DocTestSuite. testmod and DocTestFinder both seem to work fine. DocTestSuite calls DocTestFinder but not the other way around: nothing calls DocTestSuite. If in certain versions we do not treat raising the

[issue15543] central documentation for 'universal newlines'

2012-08-14 Thread Chris Jerdonek
Chris Jerdonek added the comment: Sure, I'd be happy to do both 2.7 and 3.2. I can upload the patch for the default branch as a delta to apply after the 3.2 change has been forward-ported from 3.2 to default. Thanks for taking an interest in this! -- versions: +Python 2.7, P

[issue15629] Run doctests in Doc/*.rst as part of regrtest

2012-08-15 Thread Chris Jerdonek
Chris Jerdonek added the comment: I would like the chance to try implementing this without depending on Sphinx and "make doctest". I don't think it would take much work, and it would let us leverage and hook into regrtest's existing options (like test selection by name).

[issue15543] central documentation for 'universal newlines'

2012-08-15 Thread Chris Jerdonek
Chris Jerdonek added the comment: Here is the patch for 2.7. -- Added file: http://bugs.python.org/file26822/issue-15543-6-py27.patch ___ Python tracker <http://bugs.python.org/issue15

[issue15543] central documentation for 'universal newlines'

2012-08-15 Thread Chris Jerdonek
Changes by Chris Jerdonek : Added file: http://bugs.python.org/file26826/issue-15543-6-py32.patch ___ Python tracker <http://bugs.python.org/issue15543> ___ ___ Python-bug

[issue15543] central documentation for 'universal newlines'

2012-08-15 Thread Chris Jerdonek
Chris Jerdonek added the comment: And here are the 3.2 patch and the 3.3 "delta" after forward-porting. Note that to forward-port the 3.2 patch to the default 3.3 branch, you can simply drop the changes to the file Doc/library/bz2.rst. I think that is the only conflict. --

[issue15543] central documentation for 'universal newlines'

2012-08-15 Thread Chris Jerdonek
Chris Jerdonek added the comment: Thanks, David! Also, can/did you check that reflows like these still link to the glossary correctly? + :func:`input` function to allow opening files in binary or :term:`universal + newlines` mode. Another new parameter, *openhook*, lets you use a function

[issue12623] "universal newlines" subprocess support broken with select- and poll-based communicate()

2012-08-15 Thread Chris Jerdonek
Chris Jerdonek added the comment: Andrew, I'm not sure if this is the issue, but it seems like the only tests in which input is passed to communicate() with universal newlines is when stdin is the only PIPE, i.e.: def test_universal_newlines_communicate_stdin(self): # univ

[issue12623] "universal newlines" subprocess support broken with select- and poll-based communicate()

2012-08-15 Thread Chris Jerdonek
Chris Jerdonek added the comment: > Pushing to communicate input with "\r" (see attached patch) produces the > error. Is this a supported use case? In universal newlines, stdin line endings are supposed to be "\n". From the subprocess documentation: "For std

[issue12623] "universal newlines" subprocess support broken with select- and poll-based communicate()

2012-08-15 Thread Chris Jerdonek
Chris Jerdonek added the comment: > Looking the code this test will fail on Windows. I cannot check it just now > but looks like this is the problem. Would it be possible to do something like the following to check this on a non-Windows machine (since the Python implementation of io re

[issue15693] expose glossary link on hover

2012-08-16 Thread Chris Jerdonek
New submission from Chris Jerdonek: It would be nice if hovering over the right side of the header to a glossary entry would expose a link in the same way that it does for function definitions, etc. http://docs.python.org/dev/glossary.html#glossary Otherwise, there doesn't seem to

[issue15694] link to "file object" glossary entry in open() and io docs

2012-08-16 Thread Chris Jerdonek
New submission from Chris Jerdonek: It would be nice if the first sentence of the documentation for the open() built-in function: "Open file and return a corresponding stream. If the file cannot be opened, an OSError is raised." http://docs.python.org/dev/library/functions.html#op

[issue15694] link to "file object" glossary entry in open() and io docs

2012-08-16 Thread Chris Jerdonek
Changes by Chris Jerdonek : -- keywords: +easy ___ Python tracker <http://bugs.python.org/issue15694> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue15693] expose glossary link on hover

2012-08-16 Thread Chris Jerdonek
Chris Jerdonek added the comment: Do we pin the version of Sphinx that we use to generate the documentation? If Sphinx fixes the issue, would we need to make a corresponding change here to reflect the fix? -- ___ Python tracker <h

<    8   9   10   11   12   13   14   15   16   17   >