Chris Jerdonek added the comment:

It seems like these tests can be made more DRY.  For example, the line `args = 
popen.cmd_line` appears in every test.  You could make an assert_args() helper 
method to address this.  There also seems to be a lot of overlap between tests 
for each browser.  A DRY approach would let one see more easily how the tests 
differ across browsers.

Do you also need to include the test boilerplate at the bottom?  See, for 
example--

http://hg.python.org/cpython/file/867de88b69f0/Lib/test/test_textwrap.py#l732

----------
nosy: +cjerdonek

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue15557>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to