[issue43625] CSV has_headers heuristic could be improved

2021-06-29 Thread Skip Montanaro
Skip Montanaro added the comment: Here's a NEWS entry. -- Added file: https://bugs.python.org/file50132/2021-06-29-07-27-08.bpo-43625.ZlAxhp.rst ___ Python tracker <https://bugs.python.org/is

[issue43941] Unit test failure in test_gdb only with -O0

2021-07-07 Thread Skip Montanaro
Skip Montanaro added the comment: I routinely build with -O0 and have been getting test_gdb failures building the 3.10 branch. I tried adding -g3 to my configure flags: nice ./configure OPT="-O0 -g3 -Wall" --with-pydebug --with-trace-refs but test_gdb still fails. Output attached.

[issue43941] Unit test failure in test_gdb only with -O0

2021-07-07 Thread Skip Montanaro
Skip Montanaro added the comment: Unfortunately, I'm currently not able to build Python 3.8, 3.9 or 3.10 and get a non-failing test_gdb. I'll mess around a bit more, but I'm skeptical I'll find something simple. (I wonder if something changed in GDB which is

[issue23041] csv needs more quoting rules

2021-09-10 Thread Skip Montanaro
Skip Montanaro added the comment: Update version - too late for anything older than 3.11. -- versions: -Python 3.10, Python 3.6, Python 3.7, Python 3.8, Python 3.9 ___ Python tracker <https://bugs.python.org/issue23

[issue45638] Does ccbench still require 2.6 compatibility?

2021-10-27 Thread Skip Montanaro
New submission from Skip Montanaro : At the top of Tools/ccbench/ccbench.py is this comment dating from 2010 (probably in the initial version): # This file should be kept compatible with both Python 2.6 and Python >= 3.0. Is there still a need for 2.6 compatibility in what is essentiall

[issue45669] An 'ascii_alphanumerics' variable is missing in the 'strings' lib

2021-10-30 Thread Skip Montanaro
Skip Montanaro added the comment: I'll be the wet blanket here and say -1. This doesn't seem at all necessary. 81 occurrences in ~3.5k PyPI packages? That's a hardly overwhelming endorsement. To top it off, since this can't be backported to 3.10 and earlier, it creates

[issue45638] Does ccbench still require 2.6 compatibility?

2021-11-02 Thread Skip Montanaro
Skip Montanaro added the comment: CCbench was mentioned recently in the discussion about Sam Gross's nogil branch: https://mail.python.org/archives/list/python-...@python.org/message/WRT7F2RHHCQ3N2TYEDC6JSIJ4T2ZM6F7/ I'm not convinced that deleting it is a no-brainer. Maybe if

[issue45714] test_multiprocessing_spawn hangs sometimes

2021-11-04 Thread Skip Montanaro
New submission from Skip Montanaro : I find that test_multiprocessing_spawn frequently hangs. Hitting Ctl-C then rerunning "make test" generally works. Still, this behavior makes it problematic to run testing unattended. I don't think I have an unusual environment (XUbuntu 2

[issue45714] test_multiprocessing_spawn hangs sometimes

2021-11-04 Thread Skip Montanaro
Skip Montanaro added the comment: Took me a while to notice the -i flag to regrtest.py. I think that solves my particular problem, so I will close this. Is there a place to see how 'make test' is run on the buildbots? -- stage: -> resolved status: o

[issue45745] ./python -m test --help output for refleaks seems wrong

2021-11-07 Thread Skip Montanaro
New submission from Skip Montanaro : Just preparing to make a refleaks test run, so I ran: ./python -m test --help The output related to refleaks seemed suspicious: ... Special runs: -l, --findleaks deprecated alias to --fail-env-changed ... --fail-env-changedif a test file

[issue45745] ./python -m test --help output for refleaks seems wrong

2021-11-08 Thread Skip Montanaro
Skip Montanaro added the comment: Thanks, I get that. My issue is with the apparent mismatch between the English meaning of "find leaks" and "fail env changed." It seems to me that the help message(s) for one or both of those options is probably incorrect and

[issue23041] csv needs more quoting rules

2021-11-08 Thread Skip Montanaro
Change by Skip Montanaro : -- pull_requests: +27722 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/29469 ___ Python tracker <https://bugs.python.org/issu

[issue23041] csv needs more quoting rules

2021-11-08 Thread Skip Montanaro
Skip Montanaro added the comment: Note to @samwyse and @krypten: I updated the patches and created a pull request on GitHub, but I have no way of knowing if at least krypten has signed a CLA for Python. Since you're the author of the original patches, we need to verify that you

[issue23041] csv needs more quoting rules

2021-11-09 Thread Skip Montanaro
Skip Montanaro added the comment: Further question... All the discussion has been on the writer side of the csv module. Is there any reason that using QUOTE_STRINGS or QUOTE_NOTNULL should have an effect when reading? For example, should this line on input "",,1,'a'

[issue36051] Drop the GIL during large bytes.join operations?

2020-01-30 Thread Skip Montanaro
Skip Montanaro added the comment: I think to avoid compiler warnings about 'save' perhaps being used uninitialized, it should be initialized to NULL when declared on line 21 of Objects/stringlib/join.h. -- nosy: +skip.montanaro status: closed -> open Adde

[issue39583] Remove superfluous "extern C" bits from Include/cpython/*.h

2020-02-08 Thread Skip Montanaro
New submission from Skip Montanaro : I noticed that the files in Include/cpython also have extern C declarations, despite the fact that the only files which #include them do as well. Seems like a small bit of cleanup. PR incoming... -- components: C API messages: 361628 nosy

[issue39583] Remove superfluous "extern C" bits from Include/cpython/*.h

2020-02-08 Thread Skip Montanaro
Change by Skip Montanaro : -- keywords: +patch pull_requests: +17787 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18413 ___ Python tracker <https://bugs.python.org/issu

[issue39583] Remove superfluous "extern C" bits from Include/cpython/*.h

2020-02-08 Thread Skip Montanaro
Change by Skip Montanaro : -- nosy: +ncoghlan, vstinner ___ Python tracker <https://bugs.python.org/issue39583> ___ ___ Python-bugs-list mailing list Unsub

[issue40315] Incorrect stacksize in code object

2020-04-17 Thread Skip Montanaro
New submission from Skip Montanaro : Consider this trivial function: >>> def f(): ...   while True: ...     pass ... and its disassembly: >>> dis.dis(f)   3     >>    0 JUMP_ABSOLUTE               0               2 LOAD_CONST                  0 (None)               4 R

[issue40315] Incorrect stacksize in code object

2020-04-18 Thread Skip Montanaro
Skip Montanaro added the comment: Thanks, Serhiy. -- resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue40762] Writing bytes using CSV module results in b prefixed strings

2020-05-27 Thread Skip Montanaro
Skip Montanaro added the comment: This likely worked in the past because bytes == str in Python 2.x. This is just a corner case people porting from 2 to 3 need to address in their code. Papering over it so people using Pandas don't have to do the right thing is no reason to make ch

[issue40762] Writing bytes using CSV module results in b prefixed strings

2020-05-27 Thread Skip Montanaro
Skip Montanaro added the comment: I would also that tweaking Python to make this work with no change in Pandas would be a case of the tail wagging the dog. A big tail, but a tail nonetheless. -- ___ Python tracker <https://bugs.python.

[issue27580] CSV Null Byte Error

2020-05-30 Thread Skip Montanaro
Skip Montanaro added the comment: I'm sorry, but why is this issue coming up again after nearly four years? Especially without a patch? (I apologize. I've gotten a bit more grumpy as I've aged.) Let me summarize a bit of history. Back in the early 2000s, Dave Cole at

[issue27580] CSV Null Byte Error

2020-05-30 Thread Skip Montanaro
Skip Montanaro added the comment: Looks like my comment removed Remi from the nosy list. Restoring that... -- nosy: +remi.lapeyre ___ Python tracker <https://bugs.python.org/issue27

[issue41474] Missing dependency on Include/cpython/frameobject.h

2020-08-04 Thread Skip Montanaro
New submission from Skip Montanaro : When Include/cpython/frameobject.h was created, there was no dependency added to Makefile.pre.in. -- components: Build messages: 374809 nosy: skip.montanaro priority: normal severity: normal status: open title: Missing dependency on Include/cpython

[issue41474] Missing dependency on Include/cpython/frameobject.h

2020-08-04 Thread Skip Montanaro
Change by Skip Montanaro : -- keywords: +patch pull_requests: +20877 stage: -> patch review pull_request: https://github.com/python/cpython/pull/21732 ___ Python tracker <https://bugs.python.org/issu

[issue41474] Missing dependency on Include/cpython/frameobject.h

2020-08-04 Thread Skip Montanaro
Skip Montanaro added the comment: Created a pull request. Hopefully I didn't muff the protocol too badly. -- stage: patch review -> ___ Python tracker <https://bugs.python.org

[issue41474] Missing dependency on Include/cpython/frameobject.h

2020-08-04 Thread Skip Montanaro
Skip Montanaro added the comment: > Your PR has 124 commits, that looks strange. Funny, it told me just one file had changed (Makefile.pre.in). I was attempting to make a PR against that one change from my fork of master to the main repo. Let me take another crack at

[issue41474] Missing dependency on Include/cpython/frameobject.h

2020-08-04 Thread Skip Montanaro
Skip Montanaro added the comment: I see what @vstinner is talking about. If you look at those commit messages, they all look to be of the form "Merge remote-tracking branch 'upstream/master'". That is, they are me syncing python/cpython/master to python/smontanaro/maste

[issue41474] Missing dependency on Include/cpython/frameobject.h

2020-08-04 Thread Skip Montanaro
Skip Montanaro added the comment: > they all look to be of the form "Merge remote-tracking branch > 'upstream/master'". Aside from one where I erroneously committed a change to the wrong branch, then backed it out immediately. --

[issue41474] Missing dependency on Include/cpython/frameobject.h

2020-08-04 Thread Skip Montanaro
Skip Montanaro added the comment: > > I don't know how to get rid of all those commit messages. > > I suggest you to create a local branch per change, rather than using "master". > > I consider that "origin" is g...@github.com:python/cpython.git

[issue41561] test_ssl fails in Ubuntu 20.04: test_min_max_version_mismatch

2020-09-07 Thread Skip Montanaro
Skip Montanaro added the comment: Has any progress been made on the Ubuntu 20.04 test_ssl failures? Is there any consensus about it being a Python or Ubuntu problem? -- nosy: +skip.montanaro ___ Python tracker <https://bugs.python.org/issue41

[issue41561] test_ssl fails in Ubuntu 20.04: test_min_max_version_mismatch

2020-09-07 Thread Skip Montanaro
Skip Montanaro added the comment: This skips the breaking tests (but doesn't actually fix anything). -- keywords: +patch versions: +Python 3.10 -Python 3.8 Added file: https://bugs.python.org/file49450/test_ssl_ubuntu.diff ___ Python tr

[issue41561] test_ssl fails in Ubuntu 20.04: test_min_max_version_mismatch

2020-09-10 Thread Skip Montanaro
Skip Montanaro added the comment: @Vladyslav.Bondar I can't tell where you are suggesting MinProtocol should be set. I don't see that particular string in any .c, .h or .py file in the Python source. -- ___ Python track

[issue41561] test_ssl fails in Ubuntu 20.04: test_min_max_version_mismatch

2020-09-18 Thread Skip Montanaro
Skip Montanaro added the comment: > > I confirm that Tal Einat's workaround also works. > Should workarounds be required to successfully run the test suite? I routinely unset PYTHONSTARTUP, but that's because I can and sometimes do weird things to support interactive use. I

[issue41561] test_ssl fails in Ubuntu 20.04: test_min_max_version_mismatch

2020-09-18 Thread Skip Montanaro
Skip Montanaro added the comment: > Could you please modify the test case to check for TLS 1.0 and run it Ubuntu? > > @requires_minimum_version > @requires_tls_version('TLSv1_2') > @requires_tls_version('TLSv1') > def test_min_

[issue41826] test_peg_generator compilation warnings

2020-09-21 Thread Skip Montanaro
New submission from Skip Montanaro : I don't see anything like this while building Python proper, but when test_peg_generator is run, it spews a few compiler warnings. Platform is Ubuntu 20.04. Seems low-ish priority, but I saw no mention of it in a quick bpo search, so thought I would

[issue41826] test_peg_generator compilation warnings

2020-09-23 Thread Skip Montanaro
Skip Montanaro added the comment: > This is because the types of the grammars in Lib/test/test_peg_generator/test_c_parser.py needs to be updated to use the new sequences I'm sorry, that doesn't mean much to me. Is it simply a matter of applying suitable casts to the various para

[issue41826] test_peg_generator compilation warnings

2020-09-25 Thread Skip Montanaro
Skip Montanaro added the comment: Possible patch. All this does is add some C casts. @pablogsal suggested there was more to be done, but my glance at the reference he gave suggested that's already been done. My apologies if I misinterpreted his reference. -- keywords: +patch

[issue41826] test_peg_generator compilation warnings

2020-09-25 Thread Skip Montanaro
Change by Skip Montanaro : -- pull_requests: +21450 stage: -> patch review pull_request: https://github.com/python/cpython/pull/22412 ___ Python tracker <https://bugs.python.org/issu

[issue41826] test_peg_generator compilation warnings

2020-09-25 Thread Skip Montanaro
Skip Montanaro added the comment: I created a PR from my patch, but it includes all the merges to my smontanaro/cpython master branch from python/cpython. I thought I was following the instructions properly (https://devguide.python.org/gitbootcamp/#creating-a-pull-request), but I guess I&#

[issue42325] UnicodeDecodeError executing ./setup.py during build

2020-11-11 Thread Skip Montanaro
New submission from Skip Montanaro : I recently replaced Ubuntu 20.04 with Manjaro 20.2. In the process my Python builds broke in the sharedmods target of the Makefile. The tail end of the traceback is:   File "/home/skip/src/python/cpython/./setup.py", line 246, in grep_headers_

[issue37709] CSVReader ignores dialect.lineterminator

2019-07-29 Thread Skip Montanaro
Skip Montanaro added the comment: I imagine this is a corner case which will continue to cause problems. At the time the csv module was originally written, I believe the authors' intent was to read and write CSV files which were compatible with Excel. In Python 3, you have to open

[issue37709] CSVReader ignores dialect.lineterminator

2019-07-30 Thread Skip Montanaro
Skip Montanaro added the comment: Looking at your sample file, it seems stranger than you first indicated. Your line terminator actually appears to be '\x07\r\n', not just '\x07'. Opening your file in text mode will leave you with '\x07' as the last character

[issue37709] CSVReader ignores dialect.lineterminator

2019-07-30 Thread Skip Montanaro
Change by Skip Montanaro : Added file: https://bugs.python.org/file48522/lfmapper.py ___ Python tracker <https://bugs.python.org/issue37709> ___ ___ Python-bugs-list m

[issue29955] logging decimal point should come from locale

2017-03-31 Thread Skip Montanaro
New submission from Skip Montanaro: The logging module hard codes the decimal point for timestamps to be ",". It should use locale.localeconv()["decimal_point"] instead. -- components: Library (Lib) messages: 290927 nosy: skip.montanaro priority: normal severity:

[issue29955] logging decimal point should come from locale

2017-03-31 Thread Skip Montanaro
Skip Montanaro added the comment: It's Vinay's code, so what he wants should carry the most weight. I did this as much as an exercise in figuring out the whole pull request/bug report process as anything. -- ___ Python trac

[issue29955] logging decimal point should come from locale

2017-03-31 Thread Skip Montanaro
Skip Montanaro added the comment: One example demonstrating that the datetime module at least prefers a decimal point: >>> import dateutil.parser >>> t = '1993-04-21 08:03:00,123' >>> dateutil.parser.parse(t) datetime.datetime(1993, 4, 21, 8, 3, 0

[issue29955] logging decimal point should come from locale

2017-04-06 Thread Skip Montanaro
Skip Montanaro added the comment: Vinay> I would like to close this issue now... Go for it. As I indicated in a previous comment, the exercise was as much to try and come to grips with the process as to actually make the change. There certainly appear to be good reasons to leave well eno

[issue30129] functools.partialmethod should look more like what it's impersonating.

2017-04-21 Thread Skip Montanaro
New submission from Skip Montanaro: I needed to create a partial method in Python 2.7, so I grabbed functools.partialmethod from a Python 3.5.2 install. For various reasons, one of the reasons I wanted this was to suck in some methods from a delegated class so they appeared in dir() and help

[issue30129] functools.partialmethod should look more like what it's impersonating.

2017-04-21 Thread Skip Montanaro
Skip Montanaro added the comment: Yeah, sorry about that. I work in an environment where I can't "eject" any code from my work computer. I've come up with a simple Python3 example, but it will have to wait until I can recreate it from scratch

[issue30129] functools.partialmethod should look more like what it's impersonating.

2017-04-21 Thread Skip Montanaro
Changes by Skip Montanaro : Added file: http://bugs.python.org/file46823/partial3.py ___ Python tracker <http://bugs.python.org/issue30129> ___ ___ Python-bugs-list mailin

[issue30129] functools.partialmethod should look more like what it's impersonating.

2017-04-21 Thread Skip Montanaro
Changes by Skip Montanaro : -- keywords: +patch Added file: http://bugs.python.org/file46824/ft.diff ___ Python tracker <http://bugs.python.org/issue30

[issue30129] functools.partialmethod should look more like what it's impersonating.

2017-04-21 Thread Skip Montanaro
Skip Montanaro added the comment: Again, my apologies for the crappy initial bug report. Hopefully this comment and the two files I just attached demonstrate what I am getting at. I just uploaded a stupid little example, partial3.py. Stupid, but still, it demonstrates part of how I think

[issue17267] datetime.time support for '+' and '-'

2019-04-12 Thread Skip Montanaro
Change by Skip Montanaro : -- nosy: -skip.montanaro ___ Python tracker <https://bugs.python.org/issue17267> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue27497] csv module: Add return value to DictWriter.writeheader

2019-05-07 Thread Skip Montanaro
Skip Montanaro added the comment: I think this is ready to go. I added a comment to PR12306. As I am no longer a committer, I'm not sure what the next step is. -- ___ Python tracker <https://bugs.python.org/is

[issue32594] File object 'name' attribute inconsistent type and not obviously documented

2018-01-18 Thread Skip Montanaro
New submission from Skip Montanaro : I stumbled on what I think is an inconsistency in the "name" attribute of file objects. When a file is opened with an existing file descriptor, the "name" attribute is of type int (this from a 3.6.4 session, but it also exists in 2

[issue32594] File object 'name' attribute inconsistent type and not obviously documented

2018-01-18 Thread Skip Montanaro
Skip Montanaro added the comment: Apologies for the incomplete report. In 2.7 this anomaly exists in the io.open() function. You are correct, builtin open() in 2.x doesn't support opening by file descriptor. -- ___ Python tracker &

[issue32594] File object 'name' attribute inconsistent type and not obviously documented

2018-01-18 Thread Skip Montanaro
Skip Montanaro added the comment: I'm not terribly concerned with the end result, only that we wind up with a more consistent system. As I see it, there are two main problems: 1. The type of the name attribute varies 2. The name attribute appears to be undocumented, at least not i

[issue1818] Add named tuple reader to CSV module

2018-01-29 Thread Skip Montanaro
Skip Montanaro added the comment: FWIW, I relinquished my check-in privileges quite awhile ago. This should almost certainly no longer be assigned to me. S -- ___ Python tracker <https://bugs.python.org/issue1

[issue29673] Some gdb macros are broken in 3.6

2018-03-18 Thread Skip Montanaro
Change by Skip Montanaro : -- nosy: -skip.montanaro ___ Python tracker <https://bugs.python.org/issue29673> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue15257] Misc/.gdbinit:pystack is too brittle

2018-04-05 Thread Skip Montanaro
Skip Montanaro added the comment: I would prefer if these macros remain standalone (and thus fragile). Despite Python support in gdb, not everyone (more than five years after the bug report) don't use a gdb which was built --with-python. There is better support for gdb integration else

[issue15817] Misc/gdbinit: Expose command documentation to gdb help

2018-04-05 Thread Skip Montanaro
Change by Skip Montanaro : -- pull_requests: +6094 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue15817> ___ ___ Python-bugs-list mai

[issue15817] Misc/gdbinit: Expose command documentation to gdb help

2018-04-05 Thread Skip Montanaro
Skip Montanaro added the comment: This looks good to me. I added a pull request with a couple minor tweaks. Unfortunately, I can't tell how to add a "skip news" label. This doesn't seem "big" enough to warrant it. --

[issue15817] Misc/gdbinit: Expose command documentation to gdb help

2018-04-05 Thread Skip Montanaro
Change by Skip Montanaro : -- versions: +Python 3.7 -Python 3.4 ___ Python tracker <https://bugs.python.org/issue15817> ___ ___ Python-bugs-list mailing list Unsub

[issue27805] io.open('/dev/stdout', 'a') raises OSError with errno=ESPIPE

2018-04-05 Thread Skip Montanaro
Skip Montanaro added the comment: I was bitten by this porting a system from Python 2.7 to 3.6. "/dev/stderr" is a very nice default for logfiles. Users will frequently override the default, so you really want to open the logfile in append mode. Having to jump through hoops to avoi

[issue33099] test_poplib hangs with the changes done in PR

2018-04-09 Thread Skip Montanaro
Skip Montanaro added the comment: Just in case this would be useful to others, git bisect led me to this commit as the source of the problem: 61d478c71c5341cdc54e6bfb4ace4252852fd972 is the first bad commit commit 61d478c71c5341cdc54e6bfb4ace4252852fd972 Author: Christian Heimes Date: Sat

[issue33099] test_poplib hangs with the changes done in PR

2018-04-09 Thread Skip Montanaro
Skip Montanaro added the comment: @christian.heimes I figured you probably didn't need it, but I did that work before I discovered this ticket. And as a nice bonus, I got to learn git bisect. :-) -- ___ Python tracker <https://bugs.py

[issue33556] leftover thread crumb in threading.ident docstring

2018-05-17 Thread Skip Montanaro
New submission from Skip Montanaro : There is a leftover reference to "thread.get_ident" in the docstring for threading.ident. I believe it needs a leading underscore. Hopefully a PR isn't required for this. I'm not equipped to generate one at the moment, and this seems l

[issue33556] leftover thread crumb in threading.ident docstring

2018-05-17 Thread Skip Montanaro
Change by Skip Montanaro : -- keywords: +patch pull_requests: +6622 stage: needs patch -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue34132] Obscure netrc parser "bug"

2018-07-16 Thread Skip Montanaro
New submission from Skip Montanaro : Not sure I can really call this a bug, however there is a behavioral change between 2.7 and at least 3.6 and 3.7 (probably earlier versions of the 3.x series as well). There is no spec for .netrc files that I can find, certainly nothing which mentions

[issue34132] Obscure netrc parser "bug"

2018-07-16 Thread Skip Montanaro
Change by Skip Montanaro : Added file: https://bugs.python.org/file47697/netrc-blank-comment ___ Python tracker <https://bugs.python.org/issue34132> ___ ___ Python-bug

[issue30825] csv.Sniffer does not detect lineterminator

2018-11-08 Thread Skip Montanaro
Skip Montanaro added the comment: A couple comments. 1. Terry Reedy wrote: > The csv expert listed in https://devguide.python.org/experts/ is marked as > inactive That would be me. I am indeed inactive w.r.t. fixing broken stuff, and don't want to feel obligated to jump in wit

[issue18085] Verifying refcounts.dat

2013-05-28 Thread Skip Montanaro
Skip Montanaro added the comment: As far as I can tell that file is still manually maintained. I see it mentioned in Doc/conf.py, but nowhere else. It shouldn't be hard to deal with manually, as the C API doesn't change that often. A verifier shouldn't be terribly difficu

[issue18085] Verifying refcounts.dat

2013-05-28 Thread Skip Montanaro
Skip Montanaro added the comment: > Fred L. Drake, Jr. added the comment: > > Were I adding that today, I'd use a more verbose (but more standard) > format, like configparser or JSON. If any further use is going to be > made of it, that should be considered. Colon-d

[issue18085] Verifying refcounts.dat

2013-05-29 Thread Skip Montanaro
Skip Montanaro added the comment: > And is it necessary to list all functions there? Probably not. However, BITD, I was figuring this stuff out as I was going along by examining the source code and writing down what I found. No regard for common or special cases.

[issue14732] PEP 3121 Refactoring applied to _csv module

2012-05-08 Thread Skip Montanaro
Changes by Skip Montanaro : -- nosy: -skip.montanaro ___ Python tracker <http://bugs.python.org/issue14732> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue14732] PEP 3121 Refactoring applied to _csv module

2012-05-08 Thread Skip Montanaro
Skip Montanaro added the comment: > Changes by Éric Araujo : > > > -- > nosy: +skip.montanaro Thanks, but I'm out of the Python development business, except as it pertains to my day job... Skip -- nosy: +skip.montanaro __

[issue14732] PEP 3121 Refactoring applied to _csv module

2012-05-11 Thread Skip Montanaro
Skip Montanaro added the comment: > Skip: I used the nosy field autocomplete which is based on the experts file > in the devguide; I can mark you "retired" in that file so that your name does > not show up in autocomplete (but humans will still know that you might be &

[issue15421] Calendar.itermonthdates OverflowError

2012-09-20 Thread Skip Montanaro
Skip Montanaro added the comment: LGTM -- nosy: +skip.montanaro ___ Python tracker <http://bugs.python.org/issue15421> ___ ___ Python-bugs-list mailing list Unsub

[issue15631] Python 3.3/3.4 installation issue on OpenSUSE lib/lib64 folders

2012-10-05 Thread Skip Montanaro
Skip Montanaro added the comment: I applied the OpenSUSE patch to the current cpython tip (3.4a0), rebuilt, then reinstalled. I verified that sys.path contains directories which contain "lib64". I can import the time module now, which failed before applying the patch. The pa

[issue15631] Python 3.3/3.4 installation issue on OpenSUSE lib/lib64 folders

2012-10-06 Thread Skip Montanaro
Skip Montanaro added the comment: > the proposed patch has still some issues: > > - it breaks the installation on 64bit platforms on Debian and Ubuntu. >Please test the patch on one of these platforms too. > > - it hardcodes more platform information in the sys modules, w

[issue15631] Python 3.3/3.4 installation issue on OpenSUSE lib/lib64 folders

2012-10-07 Thread Skip Montanaro
Skip Montanaro added the comment: Before this goes any farther, let me make this clear - I *did not* develop this patch. It was developed by the OpenSUSE folks. I had trouble installing Python from source on the OpenSUSE system under my desk at work. I asked about the problem on python-l

[issue20962] Rather modest chunk size in gzip.GzipFile

2014-03-17 Thread Skip Montanaro
New submission from Skip Montanaro: I've had the opportunity to use the seek() method of the gzip.GzipFile class for the first time in the past few days. Wondering why it seemed my processing times were so slow, I took a look at the code for seek() and read(). It seems like the chunk siz

[issue20962] Rather modest chunk size in gzip.GzipFile

2014-04-20 Thread Skip Montanaro
Skip Montanaro added the comment: Here's a straightforward patch. I didn't want to change the public API of the module, so just defined the chunk size with a leading underscore. Gzip tests continue to pass. -- keywords: +patch stage: needs patch -> patch review Add

[issue20962] Rather modest chunk size in gzip.GzipFile

2014-04-28 Thread Skip Montanaro
Skip Montanaro added the comment: On Mon, Apr 28, 2014 at 1:59 PM, Antoine Pitrou wrote: > Well, I think that compressed files in general would benefit from a > larger buffer size than plain binary I/O, but that's just a hunch. I agree. When writing my patch, my (perhaps speciou

[issue20962] Rather modest chunk size in gzip.GzipFile

2014-04-28 Thread Skip Montanaro
Skip Montanaro added the comment: On Mon, Apr 28, 2014 at 3:08 PM, Charles-François Natali wrote: > In short, I think the overall buffering should be rewritten :-) Perhaps so, but I think we should open a separate ticket for that instead of instituting some feature creep here (no matter

[issue21480] A build now requires...

2014-05-12 Thread Skip Montanaro
New submission from Skip Montanaro: It's been awhile since I pulled from Mercurial and built, but I tried today. I almost immediately ran into an error. The configure step worked fine, but make, not so much: % make python ./Tools/scripts/generate_opcode_h.py ./Lib/opcode.py ./Include/opc

[issue21480] A build now requires...

2014-05-12 Thread Skip Montanaro
Skip Montanaro added the comment: > Does "make touch" work for you as well? Hadn't tried, and wasn't aware of its existence. I searched Makefile for things like AST_H. Perhaps: * Note "make touch" where the "A build now requires..." comment exists. T

[issue21483] Skip os.utime() test on NFS?

2014-05-12 Thread Skip Montanaro
New submission from Skip Montanaro: I got a strange error during "make test" in a fresh build (hg clone ; ./configure ; make ; make test) Traceback (most recent call last): File "Lib/test/test_import.py", line 293, in test_timestamp_overflow os.utime(source, (2 **

[issue21469] False positive hazards in robotparser

2014-05-12 Thread Skip Montanaro
Skip Montanaro added the comment: Can this change be (easily) tested? If so, a test case akin to your original example would be nice. -- nosy: +skip.montanaro ___ Python tracker <http://bugs.python.org/issue21

[issue21483] Skip os.utime() test on NFS?

2014-05-13 Thread Skip Montanaro
Skip Montanaro added the comment: > Or we could simply catch the EINVAL failure and then skip the test. > I suppose the filesystem doesn't support timestamps > 2**32 ? Just in that one test? If I passed -1 that would probably also generate EINVAL (haven't tested). I'l

[issue5289] ctypes.util.find_library does not work under Solaris

2013-01-26 Thread Skip Montanaro
Skip Montanaro added the comment: Is there still time to get this bug fixed in 2.7.3? I patched my 2.7 ctypes/util.py with the latest version (offset a few lines, but no other problems) and verified that it seems to fix the issue. When running util.py as a main program I see this before

[issue19019] Investigate using Apple clang for building OS X installers

2013-09-18 Thread Skip Montanaro
Skip Montanaro added the comment: If you find it difficult to find people with 10.6 systems to build a Python dmg for that platform, give me a shout. I'm not planning on replacing my system anytime soon. I have 10.6.8 installed, and what I believe to be the last Xcode version to suppo

[issue19019] Investigate using Apple clang for building OS X installers

2013-09-18 Thread Skip Montanaro
Skip Montanaro added the comment: I guess snakebite (http://www.snakebite.net/) never materialized? -- ___ Python tracker <http://bugs.python.org/issue19

[issue19475] Inconsistency between datetime's str()/isoformat() and its strptime() method

2013-11-01 Thread Skip Montanaro
New submission from Skip Montanaro: I have a CSV file. Here are a few rows: "2013-10-30 14:26:46.000528","1.36097023829" "2013-10-30 14:26:46.999755","1.36097023829" "2013-10-30 14:26:47.999308","1.36097023829" "2013-10-30 14:2

[issue19475] Inconsistency between datetime's str()/isoformat() and its strptime() method

2013-11-01 Thread Skip Montanaro
Skip Montanaro added the comment: I don't accept your conclusion. I understand that making %S consume microseconds or ".%f" be "optional" would be a load. What's the problem with forcing __str__ and isoformat to emit microseconds in all cases though? That woul

[issue19475] Inconsistency between datetime's str()/isoformat() and its strptime() method

2013-11-01 Thread Skip Montanaro
Skip Montanaro added the comment: Okay, so no to __str__. What about isoformat? -- ___ Python tracker <http://bugs.python.org/issue19475> ___ ___ Python-bug

[issue19475] Inconsistency between datetime's str()/isoformat() and its strptime() method

2013-11-01 Thread Skip Montanaro
Skip Montanaro added the comment: The ultimate culprit here is actually the csv module. :-) It calls str() on every element it's about to write. In my applications which write to CSV files I can special case datetime objects. I will stop swimming ups

[issue19475] Add microsecond flag to datetime isoformat()

2013-11-06 Thread Skip Montanaro
Skip Montanaro added the comment: > I am afraid that the rounding issues may kill this proposal. Can we start > with something simple? For example, we can start with show=None keyword > argument and allow a single value 'microseconds' (or 'us'). This will solv

<    1   2   3   4   5   6   7   8   9   >