Changes by Sean Reifschneider:
--
assignee: ronaldoussoren -> nobody
nosy: +nobody
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1178>
__
___
P
Sean Reifschneider added the comment:
Committed in trunk revision 58199
Committed in 25-maint revision 58200
Committed in py3k revision 58201
--
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.o
Changes by Sean Reifschneider:
--
assignee: -> ronaldoussoren
keywords: +patch
nosy: +ronaldoussoren
priority: -> low
type: behavior -> rfe
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.py
Sean Reifschneider added the comment:
Patch is inline above.
RFC2822 says lines MUST be less than 998 bytes long, so this should be fine.
What does this do when a line longer than 4096 bytes is found? Does it
report an error to the SMTP client? That's my only concern.
--
ass
Sean Reifschneider added the comment:
It's unclear if this only causes a crash or if it can inject data.
Referenced mailing list post points out where one error is.
--
nosy: +jafo
priority: -> high
__
Tracker <[EMAIL PROTECTED]>
<http:
Sean Reifschneider added the comment:
In looking at the current documentation:
http://docs.python.org/dev/library/string.html#string.split
I don't see the wording the original poster mentions. The current
documentation of the separator is clear and reasonable. I'm going to
call t
Sean Reifschneider added the comment:
Ported code change to urllib, passes tests, committed as revision 58206
--
resolution: -> accepted
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Sean Reifschneider added the comment:
Georg: This has been assigned to you, do you have any thoughts on this?
If you don't, please assign back to me.
--
keywords: +py3k
nosy: +jafo
_
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.or
Sean Reifschneider added the comment:
Facundo, can you do a NEWS update on this?
--
assignee: -> facundobatista
keywords: +patch
status: closed -> open
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Sean Reifschneider added the comment:
Thanks for correcting my mis-click on the "patch" item, gbot.
As far as the order goes, is this something that needs to be discussed
on c.l.p, or should we assign it to someone else who might have an
opi
Changes by Sean Reifschneider:
--
priority: -> normal
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1180>
__
___
Python-bugs-list mailing list
Uns
Sean Reifschneider added the comment:
Guido: That code came from the full-disclosure list posting, I think
cartman was just passing it on.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Changes by Sean Reifschneider:
--
keywords: +patch
priority: -> normal
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1181>
__
___
Python-bugs-li
Changes by Sean Reifschneider:
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1178>
__
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mai
Changes by Sean Reifschneider:
--
priority: -> high
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1179>
__
___
Python-bugs-list mailing list
Uns
Changes by Sean Reifschneider:
--
priority: high -> normal
resolution: -> remind
status: open -> pending
_
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Changes by Sean Reifschneider:
--
priority: high -> low
title: function breakpoints in pdb -> pdb find_function does not find Class
methods.
type: -> rfe
_
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Changes by Sean Reifschneider:
--
severity: normal -> minor
_
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1643369>
_
___
Python-bugs-li
Sean Reifschneider added the comment:
Raymond: Is this still a problem, or should we close it because the
reported issue is resolved and 2.4 is no longer maintained?
--
assignee: -> rhettinger
nosy: +jafo
priority: high -> low
resolution: -> accepted
type: -&
Changes by Sean Reifschneider:
--
keywords: +patch
priority: -> normal
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1183>
__
___
Python-bugs-li
Changes by Sean Reifschneider:
--
keywords: +patch, py3k
priority: -> normal
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1184>
__
___
Python-bu
Changes by Sean Reifschneider:
--
keywords: +patch, py3k
priority: -> normal
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1185>
__
___
Python-bu
Changes by Sean Reifschneider:
--
title: must run "make" before "make install" -> UnicodeError in compileall if
"make install" is run before "make".
_
Tracker <[EMAIL PR
Changes by Sean Reifschneider:
--
keywords: +patch
_
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1704287>
_
___
Python-bugs-list mailing list
Sean Reifschneider added the comment:
I can verify that this happens in trunk (2.6) on CentOS 5, 32-bit.
Patch review looks good, and solves the problem. I've committed it to
trunk as revision 58225.
--
nosy: +jafo
resolution: -> accepted
status: open -> closed
type:
Changes by Sean Reifschneider:
--
keywords: +patch
superseder: -> Add os.link() and os.symlink() support for Windows
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org
Sean Reifschneider added the comment:
swarren: According to the wikipedi article on junction points:
They can only be used on folders, not files.
They are being replaced by symbolic links.
The latter I take to mean junction points are being phased out, but I
couldn't find any inform
Sean Reifschneider added the comment:
If the file links are on the same volume, it's probably using hard
links. Symbolic links can cross file-systems, of course. So it sounds
like the Junction Points aren't going to work to replace symlinks, and
they'l
Sean Reifschneider added the comment:
Bringing attachment inline here:
The Python manual for module 'bsddb'says it requires a Berkeley DB
library 3.3 - 4.4. But the build tools do not check this. If that's
the requirement, they should.
In
Changes by Sean Reifschneider:
--
assignee: -> astrand
nosy: +astrand
priority: -> normal
versions: +Python 2.6 -Python 2.4
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Changes by Sean Reifschneider:
--
components: +Library (Lib) -None
priority: -> normal
type: -> behavior
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Changes by Sean Reifschneider:
--
priority: -> normal
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1197>
__
___
Python-bugs-list mailing list
Uns
Changes by Sean Reifschneider:
--
priority: -> normal
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1196>
__
___
Python-bugs-list mailing list
Uns
Changes by Sean Reifschneider:
--
priority: -> normal
severity: major -> normal
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1193>
__
___
Python
Sean Reifschneider added the comment:
This issue came up on #python IRC, and that combined with the number of times
this has been duplicated makes me think that maybe the mention of the
SortedCollection recipe should be a little more prominent.
Perhaps either moved up by the method list, or
New submission from Sean Reifschneider :
Over the years I've written the same code over and over to create a random salt
string of 2 characters. Worse, the Modular Crypt Format is difficult to find
documentation on, so creating stronger hashed passwords is difficult to get
right.
To
Sean Reifschneider added the comment:
Oops, thanks. It's in there now, though for some reason I can't get this patch
to apply to trunk, but I'll have to look at that later this afternoon. I
wanted to get this new version up in the interim since it definitely does
include t
Changes by Sean Reifschneider :
Removed file: http://bugs.python.org/file20422/python-underscore_crypt.patch
___
Python tracker
<http://bugs.python.org/issue10
Sean Reifschneider added the comment:
I've made a new .patch file using "diff -c" rather than "svn diff". This is
the same code, but applies without manual intervention.
--
Added file: http://bugs.python.org/file20428/python
Changes by Sean Reifschneider :
Removed file: http://bugs.python.org/file20427/python-underscore_crypt-2.patch
___
Python tracker
<http://bugs.python.org/issue10
Sean Reifschneider added the comment:
Thanks for the review. Attached is a new version of the patch.
1) Done.
2) Good point, I didn't think of that. I've changed it into a class that
stores the methods list, and made the module "methods" point to that method on
an in
Changes by Sean Reifschneider :
Removed file: http://bugs.python.org/file20428/python-underscore_crypt-3.patch
___
Python tracker
<http://bugs.python.org/issue10
Sean Reifschneider added the comment:
Sure thing, here's an "svn diff". I had switched to the diff because I
couldn't get it to patch into a fresh trunk, but the format looked fine; not
sure why it couldn't find the files. Anyway, here's a new version
Sean Reifschneider added the comment:
Not sure if that was meant to be a suggestion for why my local patching wasn't
working from the "svn diff" output, but obviously -5 was messed up. Here's a
new version that I can apply to my fresh trunk and passes "make test&quo
Sean Reifschneider added the comment:
Thanks for the pointer about "patch -p0". I *HAD* tried that, but it didn't
seem to work either. I'll double check that though... "svn diff" is what I'd
prefer, because then I can "svn commit" it when
Sean Reifschneider added the comment:
Affirmative on the "svn mv" for the C module.
The duplicated code, thanks for pointing that out. Someone else mentioned it,
but I didn't understand what they were saying and they didn't reply to my
request for clarification. Fi
Changes by Sean Reifschneider :
Removed file: http://bugs.python.org/file20433/python-underscore_crypt-4.patch
___
Python tracker
<http://bugs.python.org/issue10
Changes by Sean Reifschneider :
Removed file: http://bugs.python.org/file20442/python-underscore_crypt-5.patch
___
Python tracker
<http://bugs.python.org/issue10
Changes by Sean Reifschneider :
Removed file: http://bugs.python.org/file20443/python-underscore_crypt-6.patch
___
Python tracker
<http://bugs.python.org/issue10
Sean Reifschneider added the comment:
At this point I'm going to consider this good to go, and will commit it after
the 3.2 final release. Thanks for the review everyone. Of course, I'm open to
further suggestions until then, just not expecting any...
--
assignee: ->
Changes by Sean Reifschneider :
--
nosy: -jafo
___
Python tracker
<http://bugs.python.org/issue8591>
___
___
Python-bugs-list mailing list
Unsubscribe:
Sean Reifschneider added the comment:
Thanks. I had just read that a day or so ago, reviewing it for Brett's work.
--
___
Python tracker
<http://bugs.python.org/is
Sean Reifschneider added the comment:
Committed in r88500.
--
stage: commit review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Sean Reifschneider added the comment:
The final word on this seems to be this:
- Wait until when we aren't in a beta release. (DONE)
- Quoting:
Well, For Py3K at least we might need to consider going through the C
API and fixing it so that these incorrect assumptions
Sean Reifschneider added the comment:
Andrew: There have been changes committed within the last week to #7712, which
Florent suggested might be related. Can you please re-test this to see if it
still exists, and if it does, bug me and I'll try to get some more movement on
Sean Reifschneider added the comment:
I've posted to python-dev asking for a reviewer for this, the thread is at
http://mail.python.org/pipermail/python-dev/2010-March/098597.html
--
nosy: +jafo
___
Python tracker
<http://bugs.python.org/i
Sean Reifschneider added the comment:
Since this needs review, and Christian is the author of that PEP, I'm assigning
it to him. If not appropriate, any suggestions on where to get visibility to
get reviewers?
--
assignee: ronaldoussoren -> christian.heimes
nosy: +christia
Changes by Sean Reifschneider :
--
priority: -> normal
___
Python tracker
<http://bugs.python.org/issue7072>
___
___
Python-bugs-list mailing list
Unsubscri
Sean Reifschneider added the comment:
Tarek: This patch seems reasonable to me, is this something that can be applied?
--
nosy: +jafo
priority: -> normal
___
Python tracker
<http://bugs.python.org/iss
Sean Reifschneider added the comment:
Sorry for the delay in getting to this patch.
I've reviewed this patch and it seems fine to me. The only thing I see
outstanding is the recommendation made by Alexandre about changing the C module
to also implement this.
Aaron: You may want to
Sean Reifschneider added the comment:
Ugh, I forgot to check the output of my test run before submitting the last
reply. With the patch applied, "make test" fails with:
test_pickle
Fatal Python error: Cannot recover from stack overflow.
Fatal Python error: Cannot recover from stac
Sean Reifschneider added the comment:
pickle_batch_list_exact_py3k.diff applies cleanly on current py3k trunk and
passes tests. cpickle_list.patch applies cleanly against 2.x trunk and passes
"make test".
I don't see any objections brought up about this set of patches, so we
Sean Reifschneider added the comment:
>From a cursory glance, I don't see any problems with this patch. Though I
>admit that I don't know the traceback code nearly as well as you, Amaury. The
>tests pass on py3k trunk on my Linux box.
If you want other review, perhap
Changes by Sean Reifschneider :
--
priority: -> normal
___
Python tracker
<http://bugs.python.org/issue6543>
___
___
Python-bugs-list mailing list
Unsubscri
New submission from Sean Reifschneider :
As discussed in this thread:
http://mail.python.org/pipermail/python-dev/2010-March/098500.html
The syslog module is using the C argv[0] as the program name, not the python
sys.argv[0]. So, in most cases this means that unless you explicitly set a
Changes by Sean Reifschneider :
Added file: http://bugs.python.org/file16982/syslog-kwargs.patch
___
Python tracker
<http://bugs.python.org/issue8451>
___
___
Python-bug
Changes by Sean Reifschneider :
--
nosy: +eric.smith
___
Python tracker
<http://bugs.python.org/issue8451>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Sean Reifschneider :
Added file: http://bugs.python.org/file16983/syslog-kwargs2.patch
___
Python tracker
<http://bugs.python.org/issue8451>
___
___
Python-bug
Sean Reifschneider added the comment:
Antoine: I believe I have everything you mentioned addressed with the new
patch. That was an awesome review, thank you so much.
The only things I didn't do were parts of the last two items you bring up:
If PyTuple_New(0) fails, bail ou
Sean Reifschneider added the comment:
Ok, so I left the argument style in the docs as it was.
*** NOTE ***: Sean: Change this for the 3 trunk commit.
Setting the "python" string is outside of the argv function because we want to
use "python" on any of the many places wher
Sean Reifschneider added the comment:
Committed as 80396. Included a change to let openlog(3) pick the ident instead
of using the static string "python".
--
resolution: -> accepted
status: open -> closed
___
Pytho
Sean Reifschneider added the comment:
Ported to python3 and committed as 80401.
--
___
Python tracker
<http://bugs.python.org/issue8451>
___
___
Python-bug
Sean Reifschneider added the comment:
Collin: Antoine has asked for some feedback, can you answer that question?
--
assignee: -> collinwinter
nosy: +jafo
priority: -> normal
___
Python tracker
<http://bugs.python.org/
Sean Reifschneider added the comment:
I believe I have the first function implemented. See the attached patch for
that code and feel free to review.
--
keywords: +patch
nosy: -haypo
Added file: http://bugs.python.org/file17089/logexception.diff
Sean Reifschneider added the comment:
I have completed the exception handling code as prototyped in msg101687.
Please review.
--
assignee: -> jafo
keywords: +needs review
stage: needs patch -> patch review
Added file: http://bugs.python.org/file17159/logexception2
Sean Reifschneider added the comment:
Jack Diederich commented:
I don't have my tracker login on this computer so I'll post here.
I'd +1 on making the module python with just the core functionality
imported from C (it releases the GIL when doing IO). Then you
could replace
Sean Reifschneider added the comment:
Thanks for the review Jack.
I was very tempted to split it into C and Python components, but I decided
against it because it's so close to the 2.7 release. I think it would be
best to defer that for the Python 3 release, because of potential pack
Sean Reifschneider added the comment:
Changed to use import_module.
--
Added file: http://bugs.python.org/file17177/logexception4.patch
___
Python tracker
<http://bugs.python.org/issue8
Sean Reifschneider added the comment:
Switched to using assertTrue/assertFalse.
--
Added file: http://bugs.python.org/file17179/logexception5.patch
___
Python tracker
<http://bugs.python.org/issue8
Sean Reifschneider added the comment:
This won't go into 2.7.0. I will do a patch for 3.x, and wait for 2.7.0 to see
if it can go into 2.7.1.
--
___
Python tracker
<http://bugs.python.org/i
Sean Reifschneider added the comment:
This won't go into 2.7.0. I will do a patch for 3.x, and wait for 2.7.0 to see
if it can go into 2.7.1.
--
___
Python tracker
<http://bugs.python.org/i
Changes by Sean Reifschneider :
--
___
Python tracker
<http://bugs.python.org/issue8214>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.pyth
Sean Reifschneider added the comment:
The thread at:
http://bugzilla.gnome.org/show_bug.cgi?id=481569
requests "attention" so I'm formally rejecting it. :-)
My reading of the python-dev thread on this is that the current patch
does not reasonably fix the problem. However, I
Sean Reifschneider added the comment:
It seems like the problem here is that chown is defined to take -1 for
the arguments, where the underlying platform may define chown taking
unsigned uid/gid.
I think in the short term we will need to apply a patch like one of the
ones included here, but in
Changes by Sean Reifschneider:
_
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1747858>
_
___
Python-bugs-list mailing list
Unsubscribe:
http://mai
Sean Reifschneider added the comment:
I've reviewed the chown system call under Linux and I think the included
patch will resolve the problem. With that patch on a Fedora 8 64-bit
system I'm getting:
>>> os.stat('/tmp/foo')
posix.stat_result(st_mode=33188,
Sean Reifschneider <[EMAIL PROTECTED]> added the comment:
Patch is inline.
A few notes for submitter:
This also needs to include a documentation patch before it can be accepted.
Please format the docstring for a line length of 78 characters or less.
Ideally, please submit a "dif
New submission from Sean Reifschneider <[EMAIL PROTECTED]>:
No body included in original message.
--
assignee: -> loewis
nosy: +jafo, loewis
priority: -> normal
__
Tracker <[EMAIL PROTECTED]>
<http://bugs
Changes by Sean Reifschneider <[EMAIL PROTECTED]>:
--
assignee: -> niemeyer
nosy: +niemeyer
priority: -> normal
__
Tracker <[EMAIL PROTECTED]>
<http://bugs
Changes by Sean Reifschneider <[EMAIL PROTECTED]>:
--
type: behavior -> feature request
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1230>
__
___
Sean Reifschneider <[EMAIL PROTECTED]> added the comment:
We've discussed this at the PyCon sprints, and here's the concensus:
os.popen inherits the parents stderr, and on Windows there is not an
existing valid stderr by default. So the parent should, to be
compatible
Sean Reifschneider <[EMAIL PROTECTED]> added the comment:
Marc-Andre: Is this good to be committed, or does it need to be reviewed
further?
--
assignee: -> lemburg
nosy: +jafo
priority: -> normal
__
Tracker <[EMAIL PROTECTED]>
<h
Sean Reifschneider <[EMAIL PROTECTED]> added the comment:
It sounds like the Unicode FAQ has an authoritative statement on this,
is this a "wontfix", or does this need more discussion? Perhaps on
python-dev or at the sprints this week?
--
assignee: -> doerwalter
n
Sean Reifschneider <[EMAIL PROTECTED]> added the comment:
Can someone comment on this, or bring it up on python-dev if it needs
more discussion?
--
assignee: -> doerwalter
nosy: +doerwalter, jafo
priority: -> low
__
Tracker <[EMAIL PR
Sean Reifschneider <[EMAIL PROTECTED]> added the comment:
There's a new version, can we get it reviewed and tested under Windows?
--
assignee: -> loewis
keywords: +patch
nosy: +jafo
priority: -> normal
title: [patch] socketmodule cleanups: allow the use of k
Sean Reifschneider <[EMAIL PROTECTED]> added the comment:
I think this proposed change needs some research into what the standards
say about ioctl's return code, and if the change to a long return code
is done then test it on Linux to see if it breaks things or if it works
Sean Reifschneider <[EMAIL PROTECTED]> added the comment:
I have run this under the current py3k SVN version on an 64-bit Linux
(Fedora 8), and it runs fine, FYI. ISTR that I had a patch which fixed
something that sounds very much like this, but I can't find that other
issue.
Sean Reifschneider <[EMAIL PROTECTED]> added the comment:
The existing tests include a test explicitly for the existing behavior,
including the statement: "An example may not generate output before it
raises an exception". In order to be able to accept this change, there
is goi
Changes by Sean Reifschneider <[EMAIL PROTECTED]>:
--
priority: -> normal
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1516>
__
___
Python-b
Sean Reifschneider <[EMAIL PROTECTED]> added the comment:
Fix is inline.
--
keywords: +patch
nosy: +jafo
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
101 - 200 of 316 matches
Mail list logo
