R. David Murray added the comment:
I like the idea of pointing out that shlex can be used to determine exactly
what to pass to subprocess, but I agree that the proposed patch is too wordy
(and still too much in a negative voice).
Here is an alternate simpler patch.
Note that while I have
R. David Murray added the comment:
Hmm. Somehow the patch got lost. Let's try again.
--
Added file: http://bugs.python.org/file16099/subprocess-doc.patch
___
Python tracker
<http://bugs.python.org/i
Changes by R. David Murray :
Removed file: http://bugs.python.org/file16099/subprocess-doc.patch
___
Python tracker
<http://bugs.python.org/issue6760>
___
___
Python-bug
R. David Murray added the comment:
Woops, spotted a word I left out. Fixed.
--
Added file: http://bugs.python.org/file16100/subprocess-doc.patch
___
Python tracker
<http://bugs.python.org/issue6
Changes by R. David Murray :
Removed file: http://bugs.python.org/file16100/subprocess-doc.patch
___
Python tracker
<http://bugs.python.org/issue6760>
___
___
Python-bug
R. David Murray added the comment:
By the way, I've been wanting the Popen docs improved for a long time but never
got around to it, so thanks for pushing for this.
--
___
Python tracker
<http://bugs.python.org/i
R. David Murray added the comment:
My placement of the note was carefully considered. It is discussing the
shell=False case and IMO belongs after that paragraph. I understand now your
concern about the note I omitted...and again I think this is a bug in the Popen
API. If shell=False, I
R. David Murray added the comment:
I'm happy to delete the two sentences about quoting.
As for -c, you are so right that it is cryptic. In the new version of the
patch I've changed the sentence to be as precise as possible, but I'm not at
all convinced that it is less conf
R. David Murray added the comment:
The change to echo is an excellent improvement. You forgot to change 'python'
to 'echo' in the following paragraph, though. You are also correct about
/bin/sh vs sh, my bad. And I was even looking at the source cod
New submission from R. David Murray :
Currently Popen accepts either a string or a list regardless of the value of
'shell'. In the shell=False case, a string is interpreted as the command name,
no matter what it actually is. In the shell=True case, a list is interpreted
as args[0]
R. David Murray added the comment:
The documentation also says, "if the object defines both a __getstate__ and a
__setstate__ method, the state object does not need to be a dictionary and the
methods can do what they want." In issue 7848 (which I will close as a
duplicate of
R. David Murray added the comment:
At the very least the documentation should be updated to warn that cooperating
__getstate__ and __setstate__ methods must make sure the state object can never
take on a False value.
--
___
Python tracker
<h
Changes by R. David Murray :
--
priority: -> normal
resolution: -> duplicate
stage: -> committed/rejected
superseder: -> deepcopy erroneously doesn't call __setstate__ if __getstate__
returns empty dict
___
Pyth
R. David Murray added the comment:
Merged as part of r77961 (2.6), r77962 (py3k), and r77963 (3.1). Print fixed
for py3.
--
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Changes by R. David Murray :
--
nosy: +vinay.sajip
priority: -> normal
stage: -> needs patch
type: -> behavior
versions: +Python 2.7, Python 3.1, Python 3.2
___
Python tracker
<http://bugs.python.o
R. David Murray added the comment:
Thanks for catching that. Fixed r77987 r77988.
--
___
Python tracker
<http://bugs.python.org/issue6760>
___
___
Python-bug
R. David Murray added the comment:
Thanks. Committed in r78014, r78015, r78016, and r78017.
--
nosy: +r.david.murray
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bug
New submission from R. David Murray :
A while back, after along discussion about variables and their meaning in
Python on the python-list, I wrote up the attached FAQ entry to summarize what
I got out of that enlightening discussion. I'm proposing that this be added to
the FAQs. If
R. David Murray added the comment:
Well, the discussion was *long* and more than a bit contentious. This is my
own personal summary. Here is a message I found somewhere in the middle of the
thread:
http://mail.python.org/pipermail/python-list/2009-January/1187126.html
Do you have a
R. David Murray added the comment:
Well, the thrust of the second part is to make it clear that there *are* no
differences between mutable and immutable objects as far as the assignment
semantics are concerned. All objects in Python are treated the same. What is
different is what is on the
R. David Murray added the comment:
Michael: I didn't read the whole thread, but it has definite echos of the
thread in which I was involved. While I agree that in pure computer-science
terms it may be imprecise to say that python is 'call by value where values are
pointers to ob
Changes by R. David Murray :
--
nosy: +vinay.sajip
priority: -> normal
stage: -> patch review
type: behavior -> feature request
versions: -Python 2.5
___
Python tracker
<http://bugs.python.o
R. David Murray added the comment:
That would be test_support.import_module, which at your recommendation I
changed to use importlib.import_module at the last pycon sprint :)
I'm not clear on why option 3 would interfere with __import__ getting tested?
--
nosy: +r.david.m
R. David Murray added the comment:
I meant test.support for py3k, of course.
--
___
Python tracker
<http://bugs.python.org/issue7875>
___
___
Python-bugs-list m
R. David Murray added the comment:
Committed in r78137 to trunk, r78138 py26, r78139 py3k, and r78140 py31.
--
components: +Library (Lib) -Interpreter Core
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -&g
R. David Murray added the comment:
Thanks for the patch. I applied the doc patch and a slightly simplified
version of the test in r78141 (we tend to just let errors bubble up rather than
code explicit Fails, since as often as not if you provide a specific message it
turns out to be wrong
R. David Murray added the comment:
Fix modified to catch the case where the shutdown has also deleted module
dictionary, at MAL's suggestion, in r78142.
--
___
Python tracker
<http://bugs.python.org/i
New submission from R. David Murray :
While working on another shelve issue I noticed that the keyencoding keyword
argument was added to shelf, but that the value is hardcoded to 'utf-8' in the
__init__ body. DbfilenameShelf does not have a keyencoding option, nor does
open, but
R. David Murray added the comment:
I agree that caching for speed is something that should be implemented in
another layer. It certainly is orthogonal to the writeback issue. The best
caching strategy is going to depend on the application, so I don't think
caching for speed belon
R. David Murray added the comment:
Read this:
http://docs.python.org/tutorial/floatingpoint.html?highlight=rounding
And then perhaps take a look at the Decimal package.
--
nosy: +r.david.murray
priority: -> low
resolution: -> invalid
stage: -> committed/rejected
sta
New submission from R. David Murray :
Cmd currently has undocumented support for using the docstrings of 'do_'
methods as the documentation for those methods. This is a very convenient
facility, except that it leads to documentation being printed with a lot of
leading whitespace.
New submission from R. David Murray :
+1
--
nosy: +r.david.murray
priority: -> normal
type: -> feature request
___
Python tracker
<http://bugs.python.org/
R. David Murray added the comment:
My feeling from watching bug reports is that Solaris is no less well supported
than other non-linux, non-windows platforms. When you look at the number of
open Solaris bug reports, also consider the number of open bug reports over
all. We just don't
R. David Murray added the comment:
I think Mark is correct. RFC 3986 says:
When authority is present, the path must either be empty or begin with a slash
("/") character. When authority is not present, the path cannot begin with two
slash characters ("//").
I think it
R. David Murray added the comment:
If by "fail" you mean "doesn't execute the command in the way I expected", then
I believe you will be enlightened by reading the recent updates to the Popen
documentation (see issue 6760).
--
nosy: +r.david.murray
priori
R. David Murray added the comment:
You can't even use call or check_call without referencing the Popen constructor
documentation, so I'm not sure what you are advocating, Anatoly. We certainly
don't want to repeat the Popen documentation in full for each convenience
func
R. David Murray added the comment:
I think you should reread the Popen docs carefully :)
That example should be:
call([sys.executable, 'diff.py', 'oldfile', 'newfile'])
And there are examples of that call format in the Popen docs, as well as the
explanation of
R. David Murray added the comment:
I agree with Andrew, but I think the optparse documentation should make it
clear that this is what happens with a default value for an 'append' action.
It is *implied* by the fact that append says it appends to a list, and default
says the va
R. David Murray added the comment:
In the example you give it seems to me that the message for the new style class
is more accurate and useful than the message for the old style class. Looking
at your mercurial example, it looks like the problem is the same (len returning
a long), and again
R. David Murray added the comment:
Interestingly, this (len returning something larger than ssize_t) has not been
fixed in python3.
On the other hand, I still think the new-style message is better. Yes, it is
an implementation detail of CPython, but that is exactly the error being
reported
R. David Murray added the comment:
Also note that RawIOBase is not intended to be a concrete class, it is intended
to be subclassed (thus the 'Base' in the name).
--
nosy: +r.david.murray
priority: -> normal
___
Python t
R. David Murray added the comment:
The outcome of that discussion is that what this implies is that there is
insufficient test coverage of mhlib, such that no one noticed that mhlib was
generating deprecation messages.
mhlib is itself effectively deprecated, since it no longer exists in py3k
R. David Murray added the comment:
Hmm. Apparently the actual bug is that mhlib itself does not produce a
deprecated message. The test was explicitly changed to mark the module as one
that is deprecated.
--
title: mhlib uses deprecated module -> mhlib does not emit deprecat
R. David Murray added the comment:
That's because the attribute values don't exist in the instance until you make
an assignment to them. Before that the exist only as class attributes.
--
nosy: +r.david.murray
priority: -> normal
resolution: -> invalid
stage: ->
R. David Murray added the comment:
It's a bug, and the bug is fixed (indirectly) in py3k trunk via improvements to
the 'compile' function. That fix can't be backported because it is a behavior
change, so fixing this in 3.1 would require fixing pdb to deal with universal
R. David Murray added the comment:
It's a bug, and the bug is fixed (indirectly) in py3k trunk via improvements to
the 'compile' function. That fix can't be backported because it is a behavior
change.
On the other hand, it appears as though the fix is to change the
R. David Murray added the comment:
But a goal is for the standard library to work with Python implementations
other than CPython, and the reference counting behavior described won't happen
in non-reference counting implementations. So I don't think that requiring
emulation of re
R. David Murray added the comment:
The problem only arises with HeaderParser. The full parser turns the body into
a list containing a Message object, because that's how the email package models
the message structure. HeaderParser treats the body as a single string. All
that is fine
R. David Murray added the comment:
But the docs (which presumably describe the API) say that the socket is
unusable after the call to close, which argues that the paramiko sockets are
following the documented API. Do the docs need to be corrected
R. David Murray added the comment:
Hmm. You are right. Not sure if that was user error or browser error. Let's
try again.
--
keywords: +patch
Added file: http://bugs.python.org/file16266/email_message_rfc822.patch
___
Python tracker
R. David Murray added the comment:
Applied to trunk in r78274, 2.6 in r78275, py3k in r78276, and 3.1 in r78277.
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bug
R. David Murray added the comment:
Could you please provide a complete example that demonstrates the problem? A
naive example using shelve with a dbhash database seems to work fine.
--
nosy: +r.david.murray
priority: -> normal
stage: -> test needed
type: -> behavior
R. David Murray added the comment:
The bug seems to have been introduced by an incomplete or incorrect translation
to the newer idiom (DictMixin to MutableMapping). Since bsddb is gone in py3,
I'm inclined to fix it by just going back to using DictMixin. There are no
tests fo
R. David Murray added the comment:
So do I. I'm saying that paramiko appears to be following the socket API as
documented in the python docs (ie: that closing the socket means it is no
longer usable).
--
___
Python tracker
R. David Murray added the comment:
So HTTConnection is closing the thing returned by makefile and that is closing
the socket, except that the socket library makes sure it doesn't actually close
the socket until the dupped file handle is also closed? I guess I need to look
at this
R. David Murray added the comment:
Here's a patch. test_bsddb3 still passes with this patch applied on trunk.
--
assignee: -> r.david.murray
keywords: +patch
stage: test needed -> patch review
Added file: http://bugs.python.org/file16284/dbshelve_dict
R. David Murray added the comment:
OK, then I think I understand Jeremy's point now: the paramiko socket is
apparently not implementing makefile in a way that matches the documented API.
--
___
Python tracker
<http://bugs.python.org/i
R. David Murray added the comment:
Woops, I accidentally deleted one of the patch files. Adding back.
--
nosy: +r.david.murray
Added file: http://bugs.python.org/file16291/tarfileWithSupportv2.patch
___
Python tracker
<http://bugs.python.
R. David Murray added the comment:
I like (2). If someone tries to use the repr to recreate the object, it will
fail with a message that mentions _Environ. So no information is lost, I
think, by using (2).
--
nosy: +r.david.murray
___
Python
R. David Murray added the comment:
FYI there's been a proposal to create a time.py module anyway in order to add
some pure python functions not worth writing in c.
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/i
R. David Murray added the comment:
Attribute error confirmed on linux on trunk and py3k.
--
priority: -> normal
stage: -> test needed
___
Python tracker
<http://bugs.python.org/
R. David Murray added the comment:
I would expect the second and would view the first as a bug.
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/issue4
R. David Murray added the comment:
By 'convert', I believe you mean 'create a python implementation of'. That is,
there's no reason to drop any c code, just to create parallel python versions
when possible.
Also note that one of the alternate implementations (I
Changes by R. David Murray :
--
resolution: remind -> fixed
___
Python tracker
<http://bugs.python.org/issue216285>
___
___
Python-bugs-list mailing list
Un
R. David Murray added the comment:
The last comment set this issue to 'remind' in case someone wanted to fix it in
the future...it's pretty much fixed now. format_string was added in 2.5, and
in 2.6 format only accepts a string containing just a format code.
--
nosy:
R. David Murray added the comment:
Applied a slightly cleaned up (with help from Brian and Matias Torchinsky at
the sprint) version of Brian's patch in r78351. Leaving open until merged to
py3k.
--
assignee: -> r.david.murray
nosy: +r.david.murray
resolution: -> fixed
s
R. David Murray added the comment:
I believe the ability to log warning messages was added recently, but that it
does not give you an control over what warnings are *generated*, just what
happens to them (that is, allowing you to log them).
On the other hand, what is the motivation for
Changes by R. David Murray :
--
priority: -> normal
___
Python tracker
<http://bugs.python.org/issue7900>
___
___
Python-bugs-list mailing list
Unsubscri
R. David Murray added the comment:
I see. I agree with Nick, a public API function in Warnings is better than
something specific to optparse or argparse. If the op (or anyone else) wants
to propose a patch to create such an API (with docs and tests), that would be
welcome. The docs for
R. David Murray added the comment:
How does this make it easier to review the built documentation? Most web
browsers are happy to read off disk, and that seems easier than firing up a
server.
(I would actually have a use case for this, since the machine I build the docs
on isn'
R. David Murray added the comment:
Ah, windows. And if it was there, I'd probably use it. Let's see what Georg
things.
--
nosy: +georg.brandl
___
Python tracker
<http://bugs.python.
R. David Murray added the comment:
Georg: could we also add a targets in the Docs Makefile and make.bat to fire up
the script?
--
resolution: -> accepted
versions: +Python 3.2
___
Python tracker
<http://bugs.python.org/iss
Changes by R. David Murray :
--
priority: -> high
___
Python tracker
<http://bugs.python.org/issue8007>
___
___
Python-bugs-list mailing list
Unsubscri
R. David Murray added the comment:
Looking at the interface I assumed that any openid provider was supported. Did
you try an alternate one and it didn't work? I'm using an id hosted on my own
server (albeit delegating to myopenid).
This bug actually belongs in the metatracker,
R. David Murray added the comment:
Committed to py3k in r78400. Had to add the make_request_and_skipIf decorator
to test_xmplrc as well.
--
priority: -> normal
status: open -> closed
versions: +Python 3.2
___
Python tracker
R. David Murray added the comment:
Well, 'we' and 'they' are pretty much the same team. If you want to enhance
the openid support that Martin added to the tracker, you can submit a patch
against the code in the repository.
--
R. David Murray added the comment:
Benjamin pointed out that the primary copy of lib2to3 is not trunk, so I backed
out the change to that package.
--
___
Python tracker
<http://bugs.python.org/issue6
R. David Murray added the comment:
Committed to trunk in r78412 and 2.6 in r78413.
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.o
R. David Murray added the comment:
PEP 389 has been accepted.
--
components: +Library (Lib) -Extension Modules
priority: -> normal
resolution: -> accepted
stage: -> committed/rejected
status: open -> closed
___
Python tr
R. David Murray added the comment:
Having looked at this code for another reason, I suspect that the stop_serving
change was an attempt to handle a possible hang in the test, and that the py2
code simply doesn't try to handle that possible hang. Note that you can
simulate the hang by h
Changes by R. David Murray :
--
nosy: +benjamin.peterson
___
Python tracker
<http://bugs.python.org/issue8029>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
Because the shell argument provides important functionality. Or are you
suggesting that passing a list implies shell=False and passing a string implies
shell=True? That is a possibility, but I think it would not be a good idea,
because people will
R. David Murray added the comment:
Hmm. I liked Eric's idea, and it would be easier to get in, but 'call' is
actually an argument against it. It would mean that in addition to PopenExec
and PopenShell we'd need call_exec and call_shell, and check_call_exec a
R. David Murray added the comment:
Applied skip patch to trunk in r78558, and 2.6 in 78560.
--
status: open -> languishing
___
Python tracker
<http://bugs.python.org/iss
R. David Murray added the comment:
See also issue 1284316, which is still open, and should probably remain open
even though there's no consensus to make a change (yet?).
--
nosy: +ezio.melotti, flox, r.david.murray
priority: -> normal
superseder: -> Win32: Security p
R. David Murray added the comment:
Note that Ezio and Flox have been improving the test suite and code to handle
paths-with-spaces better. Perhaps we will eventually get to the point where it
is possible to fix this, although Tim's point about python being a
CLI/scripting tool remains
R. David Murray added the comment:
I believe this would be blocked by the moratorium. Correct me if I'm wrong.
--
assignee: twouters -> pedronis
keywords: +after moratorium
nosy: +pedronis, r.david.murray
stage: -> patch review
versions:
R. David Murray added the comment:
fix inadvertent reassignment.
--
assignee: pedronis -> twouters
nosy: -pedronis
___
Python tracker
<http://bugs.python.org/iss
R. David Murray added the comment:
I haven't reviewed the whole patch, but I would suggest that instead of making
a test_support.skip_if_no (or any other name), you use use
@unittest.skipUnless(threading) (note that lack of quotes around
threading...you seem to already be getting it de
R. David Murray added the comment:
I'm not an ElementTree user, but that spelling (etree.tostring(encode=str), or
even etree.tostring(encode=unicode)) strikes me as horrible. You don't encode
to unicode, you *decode* to unicode. Thus the current Python3 interface works
the way
R. David Murray added the comment:
Ah, I misunderstood, and did not see that the newline in question was inside
the base64 string. Thank you for pointing out my mistake.
Would either of you like to propose a patch, including a test case?
(I've removed 2.5 because it is in security-fix
Changes by R. David Murray :
--
versions: -Python 3.0
___
Python tracker
<http://bugs.python.org/issue7143>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
My understanding is that backward compatibility, while nice to retain, was not
considered a stopper for cleaning up interfaces in py3. Exactly how considered
this change was, I have no idea, but as I said it does make sense to me. As
for 2.x, what's
R. David Murray added the comment:
Fred, I think your report of observed breakage is sufficient to warrant rolling
back the change, especially since this isn't an actual bug fix. That is, no
code that was failing to work before would be enabled to work by this fix.
(Rather, it ai
R. David Murray added the comment:
Using python 2.6.4, your first example gives me an error:
UnicodeEncodeError: 'ascii' codec can't encode characters in position 11-18:
ordinal not in range(128)
while your second example works, as you indicated.
So, at the moment I can no
R. David Murray added the comment:
Duplicate of issue 7082. However, I fixed the documentation in r78656.
--
nosy: +r.david.murray
priority: -> normal
resolution: -> duplicate
stage: -> committed/rejected
status: open -> closed
superseder: -> Patch for
R. David Murray added the comment:
Thanks for working on this.
For the most part your patch looks fine. Two comments: (1) it concerns me that
by co-opting the existing test, we are no longer testing that decoding does not
introduce a spurious newline :). (2) I think we should add a comment
R. David Murray added the comment:
Not likely to make 2.7, either, unless someone comes forward with a patch real
quick.
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/issue8
R. David Murray added the comment:
We don't fully support setting defaultencoding to anything other than ASCII.
The test suite doesn't fully pass, for example, if defaultencoding is set to
'utf-8' in site.py.
But that aside, the documentation for MIMEText says: "No
R. David Murray added the comment:
Does this mean you think you've fixed whatever was causing metatracker bug 320?
(http://psf.upfronthosting.co.za/roundup/meta/issue320).
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.py
1901 - 2000 of 10554 matches
Mail list logo
