Petr Viktorin added the comment:
All linked PRs are merged, so I'm closing this. Feel free to reopen if there's
more!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<h
New submission from Petr Viktorin :
Hello,
In Fedora, we've long used a Bash script to compile modules to bytecode, as the
compileall module was historically unsuitable.
Recently, Lumír re-wrote our enhancements to compileall, and published the
result as compileall2 on PyPI. We'd l
Change by Petr Viktorin :
--
pull_requests: +15599
pull_request: https://github.com/python/cpython/pull/15966
___
Python tracker
<https://bugs.python.org/issue37
Petr Viktorin added the comment:
I like PR 14890 better. I like the separation of representation for error
messages (where it's clearer that this is a callable) and for __str__.
Also, changing the __str__ of functions would need much wider discussion than
on issues/PRs.
I left
Change by Petr Viktorin :
--
pull_requests: +15629
pull_request: https://github.com/python/cpython/pull/16004
___
Python tracker
<https://bugs.python.org/issue37
Petr Viktorin added the comment:
My bad, I didn't publish the comments. They should be there now.
--
___
Python tracker
<https://bugs.python.org/is
Petr Viktorin added the comment:
New changeset 5e9caeec76119a0d61c25f1466c27b7dbd5115bd by Petr Viktorin in
branch 'master':
bpo-37879: Fix warnings in _testcapimodule (GH-16004)
https://github.com/python/cpython/commit/5e9caeec76119a0d61c25f1466c27b
Petr Viktorin added the comment:
New changeset 3562ae25402aad36583bc27d4d82c67554323d5e by Petr Viktorin in
branch '3.8':
[3.8] bpo-37879: Suppress subtype_dealloc decref when base type is a C heap
type (GH-15323, GH-16004) (GH-15966)
https://github.com/python/cpyt
Change by Petr Viktorin :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Petr Viktorin added the comment:
Fixed here and in https://bugs.python.org/issue37499 (
https://github.com/python/cpython/pull/15776 )
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracke
Change by Petr Viktorin :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Petr Viktorin added the comment:
This is fixed in Python 3.5+.
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Petr Viktorin added the comment:
PEP 573 proposes an alternative to PyState_FindModule.
--
nosy: +petr.viktorin
___
Python tracker
<https://bugs.python.org/issue18
New submission from Petr Viktorin :
I've seen extension modules calling PyState_AddModule on init, despite Python
doing this automatically.
It should be clarified that PyState_AddModule is for people who are writing
alternative ways of creating/registering module ob
Change by Petr Viktorin :
--
keywords: +patch
pull_requests: +15720
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/16101
___
Python tracker
<https://bugs.python.org/issu
Petr Viktorin added the comment:
PEP 573 already proposes adding a pointer to the *module* to heap types (well,
those that opt in).
We should rather add a pointer from *modules* to the interpreter state.
--
___
Python tracker
<ht
Petr Viktorin added the comment:
Thanks for the feature!
This still needs documentation, however.
--
resolution: fixed ->
status: closed -> open
___
Python tracker
<https://bugs.python.org/i
Change by Petr Viktorin :
--
pull_requests: +15934
stage: resolved -> patch review
pull_request: https://github.com/python/cpython/pull/16354
___
Python tracker
<https://bugs.python.org/issu
Petr Viktorin added the comment:
New changeset 468f8a6ee0d83e36795bbab6f20037b0e380f493 by Petr Viktorin in
branch 'master':
bpo-38140: Document offsets in PyMemberDef (GH-16354)
https://github.com/python/cpython/commit/468f8a6ee0d83e36795bbab6f20037
Petr Viktorin added the comment:
How are you building Python? Could you share your configure/make commands?
--
nosy: +petr.viktorin
___
Python tracker
<https://bugs.python.org/issue38
Petr Viktorin added the comment:
This line in _tesctcapimodule.c:
{"__dictoffset__", T_PYSSIZET, -sizeof(void*), READONLY},
gives a legitimate-sounding warning on a Windows buildbot:
d:\buildarea\3.x.ware-win81-release.nondebug\build\modules\_testcapimodule.c(6409)
Petr Viktorin added the comment:
New changeset 8e7bb991de7c88583bc6663d8bbc541054ca8dc4 by Petr Viktorin (Lumír
'Frenzy' Balhar) in branch 'master':
bpo-38112: Compileall improvements (GH-16012)
https://github.com/python/cpython/commit/8e7bb991de7c88583bc6
Change by Petr Viktorin :
--
pull_requests: +15994
pull_request: https://github.com/python/cpython/pull/16414
___
Python tracker
<https://bugs.python.org/issue38
Petr Viktorin added the comment:
Thanks!
The buildbot complained in the pull request a while ago; I commented there that
I'm looking into it.
I'd appreciate a review for the fix; I don't have a good way to test it other
than offer it t
Petr Viktorin added the comment:
New changeset 4267c989e7fc6cd528e8a1d04a07fac5cca85ec7 by Petr Viktorin in
branch 'master':
bpo-38112: compileall: Skip long path path on Windows if the path can't be
created (GH-16414)
https://github.com/python
Change by Petr Viktorin :
--
pull_requests: +15999
pull_request: https://github.com/python/cpython/pull/16419
___
Python tracker
<https://bugs.python.org/issue38
Petr Viktorin added the comment:
> only if PEP 573 makes it *compulsory* for heap types to contain a pointer to
> their module
And that's impossible without either breaking API (or some hackery).
PyType_FromSpec doesn't get the information, and it can be easily outside
modul
Petr Viktorin added the comment:
Indeed, it can be closed.
Thanks Serhiy for the better error message!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Petr Viktorin added the comment:
Thanks to Stéphane and Eddie for fixing the refleak!
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<https://bugs.python.org/i
Petr Viktorin added the comment:
Thank you all!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Petr Viktorin added the comment:
Oh! Sorry, I thought I saw green bots, and haven't looked since.
I should have time for this tomorrow.
If that's too late, remove/skip test_compile_dir_maxlevels on Windows. (The
feature was untested before, and the 3.9 enhancement added test cove
Change by Petr Viktorin :
--
keywords: +patch
pull_requests: +16340
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/16778
___
Python tracker
<https://bugs.python.org/issu
Petr Viktorin added the comment:
If someone has access to Windows and can reproduce this (you need a more
special setup than "just Windows"), and you want to spend some time debugging,
please do. I'm shooting in the dark.
My proposed patch limits the maximum path depth to 20
Petr Viktorin added the comment:
New changeset eb1dda2b56f67f09352c303588c28880c471ae87 by Petr Viktorin (Victor
Stinner) in branch 'master':
bpo-38470: Fix test_compileall.test_compile_dir_maxlevels() (GH-16789)
https://github.com/python/cpyt
Change by Petr Viktorin :
--
nosy: +petr.viktorin
___
Python tracker
<https://bugs.python.org/issue38007>
___
___
Python-bugs-list mailing list
Unsubscribe:
Petr Viktorin added the comment:
New changeset 9bc94eca0c69a551f928692364a99e9b67c4a45b by Petr Viktorin in
branch 'master':
bpo-38159: Clarify documentation of PyState_AddModule (GH-16101)
https://github.com/python/cpython/commit/9bc94eca0c69a551f928692364a99e
Petr Viktorin added the comment:
The module still uses tp_new directly, so it's not limited to only stable ABI,
but that's for another issue.
Thanks for the contribution!
--
nosy: +petr.viktorin
resolution: -> fixed
stage: patch review -> resolved
status
Change by Petr Viktorin :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Petr Viktorin added the comment:
With this change, CPython no longer uses PyEval_GetFuncName/PyEval_GetFuncDesc
internally.
Shall we deprecate/discourage them?
Shall we expose PyObject_FunctionStr publicly?
--
___
Python tracker
<ht
Petr Viktorin added the comment:
Generally, „true“ and „false“ refer to „truthiness“, while the actual ``True``
and ``False`` literals should be capitalized. And in monospace font if possible.
I think this is a good convention, but it's quite subtle, and I don't think
it
Petr Viktorin added the comment:
There seems to be much confusion here. Maybe on my side?
PEP 489 is *very much* part of the limited API.
--
nosy: +petr.viktorin
___
Python tracker
<https://bugs.python.org/issue43
Change by Petr Viktorin :
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue43543>
___
___
Petr Viktorin added the comment:
This reverted commit 5940c535b06805960d008bcafec7260dae74d9b9
--
nosy: +petr.viktorin
___
Python tracker
<https://bugs.python.org/issue33
Petr Viktorin added the comment:
If you do this, please check the performance impact. Py_INCREF/Py_DECREF are
very common.
--
___
Python tracker
<https://bugs.python.org/issue43
Petr Viktorin added the comment:
Not sure what platforms libabigail works on, but the set of stable ABI symbols
is platform-specific. Currently it's affected by the MS_WINDOWS and HAVE_FORK
defines.
--
___
Python tracker
<https://bugs.py
New submission from Petr Viktorin :
This issue tracks implementation of PEP 652.
CPython's Limited C-API and Stable ABI, introduced in PEP 384, will be
formalized in a single definitive file, tested, and documented.
--
messages: 390638
nosy: petr.viktorin
priority: normal
sev
Change by Petr Viktorin :
--
keywords: +patch
pull_requests: +24047
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/25312
___
Python tracker
<https://bugs.python.org/issu
Change by Petr Viktorin :
--
pull_requests: +24050
pull_request: https://github.com/python/cpython/pull/25315
___
Python tracker
<https://bugs.python.org/issue43
Change by Petr Viktorin :
--
resolution: -> duplicate
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue43831>
___
___
Petr Viktorin added the comment:
New changeset 92eebf6dd20c541ca5883d010a575fb6ea4a245c by Petr Viktorin in
branch 'master':
bpo-43795: Sort PC/python3dll.c (GH-25312)
https://github.com/python/cpython/commit/92eebf6dd20c541ca5883d010a575f
Petr Viktorin added the comment:
New changeset 341e8a939aca6e9f59ffb0e6daee5888933694ed by Lumír 'Frenzy' Balhar
in branch 'master':
bpo-41282: (PEP 632) Load install schemes from sysconfig (GH-24549)
https://github.com/python/cpython/commit/341e8a939aca6e9f59ff
New submission from Petr Viktorin :
The inclusion of PyOS_ReadlineFunctionPointer in python3dll.c (*) was a
mistake. According to PEP 384:
> functions expecting FILE* are not part of the ABI, to avoid depending on a
> specific version of the Microsoft C runtime DLL on Windows.
The sit
Change by Petr Viktorin :
--
keywords: +patch
pull_requests: +24172
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/25442
___
Python tracker
<https://bugs.python.org/issu
Petr Viktorin added the comment:
Opened as a separate issue: bpo-43868, Remove PyOS_ReadlineFunctionPointer from
the stable ABI list
--
___
Python tracker
<https://bugs.python.org/issue43
Petr Viktorin added the comment:
I unsure about the following symbols.
Victor, do you think they should be part of the stable ABI?
- PyThreadState_DeleteCurrent
- Py_GetArgcArgv
- PyInterpreterState_GetID
--
nosy: +vstinner
___
Python tracker
Petr Viktorin added the comment:
Thanks! I'll send PRs later.
--
___
Python tracker
<https://bugs.python.org/issue43795>
___
___
Python-bugs-list m
Petr Viktorin added the comment:
Thanks for linking to the issues/documentation!
I see that Py_GetArgcArgv it was exported in python3.def (i.e. stable ABI) in
bpo-40910, which got backported to 3.9.
And the removal of PyThreadState_DeleteCurrent was reverted: bpo-38266
While we would like
Change by Petr Viktorin :
--
pull_requests: +24207
pull_request: https://github.com/python/cpython/pull/25482
___
Python tracker
<https://bugs.python.org/issue43
Petr Viktorin added the comment:
> Should we mention PEP 652 in Include/README.rst, now that the PEP is accepted?
No, we should link to the documentation (when it's written). The PEP is a
design document; it'll become outdated.
--
_
Change by Petr Viktorin :
--
pull_requests: +24208
pull_request: https://github.com/python/cpython/pull/25483
___
Python tracker
<https://bugs.python.org/issue43
Petr Viktorin added the comment:
I wonder if it would be worth it to add a new option to include hidden files
(except . and ..)
For the record, setuptools' fork of glob does this unconditionally:
https://github.com/pypa/setuptools/blob/main/setuptools/glob.py
--
nosy: +petr.vik
Petr Viktorin added the comment:
New changeset 90d02e5e63e2cb8f66a2c0dd2ea8d7d4f45f4ebf by Lumír 'Frenzy' Balhar
in branch 'master':
bpo-41282: (PEP 632) Deprecate distutils.sysconfig (partial implementation of
the PEP) (GH-23142)
https://github.com/p
Petr Viktorin added the comment:
New changeset e7cc64e297001cc79b9afab80f71d9e6d1267cb7 by Petr Viktorin in
branch 'master':
bpo-43795: PEP-652: Simplify headers for easier static analysis (GH-25483)
https://github.com/python/cpython/commit/e7cc64e297001cc79b9afab80f71d9
Petr Viktorin added the comment:
New changeset 9d6a2d0ee7e55402656e1dec46400591b62db331 by Petr Viktorin in
branch 'master':
bpo-43795: PEP-652: Clean up the stable ABI/limited API (GH-25482)
https://github.com/python/cpython/commit/9d6a2d0ee7e55402656e1dec464005
Petr Viktorin added the comment:
New changeset 91b69b77cf5f78de6d35dea23098df34b6fd9e53 by Petr Viktorin in
branch 'master':
bpo-43868: Remove PyOS_ReadlineFunctionPointer from the stable ABI list
(GH-25442)
https://github.com/python/cpython/commit/91b69b77cf5f78de6d35dea23098df
Petr Viktorin added the comment:
Please don't lose the big picture here.
Previously, the reported line number was *somewhere close* to the currently
executing code. That's typically all I need from a traceback: the fix for a bug
often needs to go a few lines above/below where it&
Change by Petr Viktorin :
--
pull_requests: +24357
pull_request: https://github.com/python/cpython/pull/25668
___
Python tracker
<https://bugs.python.org/issue43
Petr Viktorin added the comment:
I hope the PR fixes that. I plan to merge tomorrow if there ar no objections to
it.
On April 28, 2021 5:15:19 PM GMT+02:00, STINNER Victor
wrote:
>
>STINNER Victor added the comment:
>
>Right now, running "make regen-limited-abi" adds
Petr Viktorin added the comment:
New changeset f6ee4dad589c0953283dacb577a2d808fda7aae9 by Petr Viktorin in
branch 'master':
bpo-43795: Generate python3dll.c and doc data from manifest (PEP 652) (GH-25315)
https://github.com/python/cpython/commit/f6ee4dad589c0953283dacb577a2d8
Change by Petr Viktorin :
--
nosy: +petr.viktorin
nosy_count: 5.0 -> 6.0
pull_requests: +24411
pull_request: https://github.com/python/cpython/pull/25720
___
Python tracker
<https://bugs.python.org/issu
Petr Viktorin added the comment:
New changeset 14fc2bdfab857718429029e53ceffca456178827 by Petr Viktorin in
branch 'master':
bpo-28254: Add PyGC_ functions to the stable ABI manifest (GH-25720)
https://github.com/python/cpython/commit/14fc2bdfab857718429029e53ceffc
Petr Viktorin added the comment:
Sorry for not getting to this sooner, but 5 days is really tight for such a
change.
With -S/-I, It would be great if sys.path only included packages installed as
part of the OS, and not those installed by `sudo pip`. (Or `pip --user`, but
that's co
Change by Petr Viktorin :
--
nosy: +petr.viktorin
nosy_count: 5.0 -> 6.0
pull_requests: +24568
pull_request: https://github.com/python/cpython/pull/25896
___
Python tracker
<https://bugs.python.org/issu
Petr Viktorin added the comment:
Changing PyType_FromSpec* to accept NULL has an issue: extensions built and
tested with 3.9.5 would not work with the earlier 3.9s.
I'll send a PR to fix just PyStructSequence_NewType.
--
___
Python tr
Change by Petr Viktorin :
--
pull_requests: +24588
pull_request: https://github.com/python/cpython/pull/25920
___
Python tracker
<https://bugs.python.org/issue43
Petr Viktorin added the comment:
The symbols exported by python3.dll are now generated from Misc/stable_abi.txt
as per PEP 652.
See the devguide for more details: https://devguide.python.org/c-api/
This is slightly more work than generating the list fully automatically, but
the extra work
Petr Viktorin added the comment:
PEP 0497 is rejected; the active one is PEP 387, which says "backwards
incompatibility" means preexisting code ceases to comparatively function after
a change.
So, this does look like a backwards-incompatible change.
Unfortunately, not all of th
Petr Viktorin added the comment:
PyCode_NewWithPosOnlyArgs is not part of the stable ABI. It is OK to break its
ABI in a minor version (i.e. 3.11).
The PyAPI_FUNC makes it part of the public *API*. It needs to be source-
compatible; the number of arguments can't change. Could yo u add
Petr Viktorin added the comment:
Then, according to PEP 387, "The steering council may grant exceptions to this
policy."
I think API breaks like this do need coordination at the project level.
--
___
Python tracker
<https://bu
Petr Viktorin added the comment:
Thanks for the note!
This is due to `csv`. Adding a script in Tools/scripts that imports csv will
also make the refleak check fail.
I'll investigate further.
--
___
Python tracker
<https://bugs.py
New submission from Petr Viktorin :
After `_csv.register_dialect` is called, the csv module is alive even after
it's removed from sys.modules. It should be garbage-collected.
(It's not that big a deal: unloading _csv isn't something users should do. But
it might be hiding
Petr Viktorin added the comment:
I opened https://bugs.python.org/issue44116 for the leak when trying to unload
_csv.
Looks like investigating that will take a while, so I'll send a small PR to
unblock the buildbots.
--
___
Python tracker
&
Petr Viktorin added the comment:
Hm, a similar thing apparently happens with urllib.request.
--
___
Python tracker
<https://bugs.python.org/issue44116>
___
___
Change by Petr Viktorin :
--
keywords: +patch
pull_requests: +24709
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26068
___
Python tracker
<https://bugs.python.org/issu
Petr Viktorin added the comment:
*facepalm* Yes, that's it.
If you have the time now, could you send he PR?
--
___
Python tracker
<https://bugs.python.org/is
Change by Petr Viktorin :
--
nosy: +petr.viktorin
nosy_count: 5.0 -> 6.0
pull_requests: +24712
pull_request: https://github.com/python/cpython/pull/26072
___
Python tracker
<https://bugs.python.org/issu
Petr Viktorin added the comment:
The urllib.request one was caused by _hashlib, see GH-26072.
--
stage: patch review ->
___
Python tracker
<https://bugs.python.org/issu
Petr Viktorin added the comment:
Changes to _csv.Error should not be necessary, there everything is handled by
the superclass.
--
stage: patch review ->
___
Python tracker
<https://bugs.python.org/issu
Change by Petr Viktorin :
--
pull_requests: +24742
pull_request: https://github.com/python/cpython/pull/26101
___
Python tracker
<https://bugs.python.org/issue43
Petr Viktorin added the comment:
METH_VARARGS and METH_KEYWORDS are part of the stable ABI.
--
___
Python tracker
<https://bugs.python.org/issue4>
___
___
Petr Viktorin added the comment:
The tests are now skipped on Windows. It might be better to use a feature
check: hasattr(ctypes.pythonapi, 'Py_FrozenMain')
IMO, Py_FrozenMain is quite specific: it's OK if it's exported, but also OK if
it's missing. (Unless you
Petr Viktorin added the comment:
Is this function actually usable in Windows? ISTM that you need to define three
more functions, PyWinFreeze_ExeInit, PyWinFreeze_ExeTerm and
PyInitFrozenExtensions.
Was adding this undocumented function to the Windows stable ABI deliberate? I
see no
Change by Petr Viktorin :
--
pull_requests: +24858
pull_request: https://github.com/python/cpython/pull/26241
___
Python tracker
<https://bugs.python.org/issue44
Change by Petr Viktorin :
--
pull_requests: +24857
pull_request: https://github.com/python/cpython/pull/26241
___
Python tracker
<https://bugs.python.org/issue42
Change by Petr Viktorin :
--
pull_requests: +24856
pull_request: https://github.com/python/cpython/pull/26241
___
Python tracker
<https://bugs.python.org/issue43
Petr Viktorin added the comment:
First off, note that you can use PyModule_AddType rather than
PyModule_AddObject to avoid repeating the name.
Adding this *correctly* will be somewhat involved: slots take function
pointers, not data pointers which are incompatible according to standard C
Petr Viktorin added the comment:
When building Python, we need two distinct "include" directories:
- source .h files
- install target for .h files
Note that this doesn't matter except when building Python from source.
Historically:
- source .h files were in the sysconf
Change by Petr Viktorin :
--
pull_requests: +24921
pull_request: https://github.com/python/cpython/pull/26329
___
Python tracker
<https://bugs.python.org/issue41
Petr Viktorin added the comment:
Thank you for doing the hard part, Ned!
--
___
Python tracker
<https://bugs.python.org/issue41282>
___
___
Python-bugs-list m
Petr Viktorin added the comment:
How will these filenames be generated? Won't build tools like setuptools need
to be changed as well?
--
___
Python tracker
<https://bugs.python.org/is
101 - 200 of 950 matches
Mail list logo