[issue1020] pydoc doesn't work on pyexpat

2007-08-25 Thread Neal Norwitz
New submission from Neal Norwitz: help(pyexpat) causes an exception: Traceback (most recent call last): File "", line 1, in File "/home/neal/python/dev/py3k/Lib/site.py", line 350, in __call__ return pydoc.help(*args, **kwds) File "/home/neal/python/dev/py3k

[issue1022] use bytes for code objects

2007-08-25 Thread Neal Norwitz
New submission from Neal Norwitz: This patch has a hack to read in marshaled code objects. Bytes can't be marshaled currently (they are stored as strings). So when reading a marshaled code object, the hack converts them to bytes. All tests except test_modulefinder pass. The issue is

[issue1025] tracebacks from list comps (probably other comps) don't show full stack

2007-08-25 Thread Neal Norwitz
New submission from Neal Norwitz: A traceback that occurs within a list comprehension (and probably all comprehensions) only shows the stack from the comprehension, not the entire scope: Traceback (most recent call last): File "Lib/test/test_multibytecodec_support.py", l

[issue1031] py3k: compilation with VC2005

2007-08-26 Thread Neal Norwitz
Neal Norwitz added the comment: Thanks for the patch. I tried to apply this patch, but almost everything failed. Could you make sure to do a svn update and then generate the patch? The only part of the patch that applied cleanly was to rmpyc.py. That was checked in as: Committed revision

[issue1030] py3k: Adapt _winreg.c to the new buffer API

2007-08-26 Thread Neal Norwitz
New submission from Neal Norwitz: Thanks! I can't test this, but I applied the change. It makes sense to me. Committed revision 57528. -- assignee: -> nnorwitz nosy: +nnorwitz resolution: -> accepted status: open -> closed __ T

[issue1031] py3k: compilation with VC2005

2007-08-26 Thread Neal Norwitz
Neal Norwitz added the comment: Hmmm, the patch was out of date (I had already removed cPickle). However, I don't think that was the reason for everything failing. I manually applied the changes to the files and python version. Things should be pretty good now. I didn't add the

[issue1031] py3k: compilation with VC2005

2007-08-26 Thread Neal Norwitz
Neal Norwitz added the comment: I thought it might be line endings so I tried changing them, but that didn't help. I couldn't apply the new version of the patch either. I'm not sure if the problem is on your side or mine. :-( I missed some files from the original checki

[issue1028] Tkinter binding involving Control-spacebar raises unicode error

2007-08-26 Thread Neal Norwitz
Neal Norwitz added the comment: I can confirm the problem and that your patch fixes the problem. Go ahead and check it in. Thanks! -- assignee: nnorwitz -> kbk nosy: +nnorwitz resolution: -> accepted __ Tracker <[EMAIL PROTECTE

[issue1031] py3k: compilation with VC2005

2007-08-26 Thread Neal Norwitz
Neal Norwitz added the comment: Awesome! I'm going to close this patch. Let me know if you have any more problems. Feel free to send messages to python-3000. I would like py3k to build on Windows for the alpha which will be coming out in about a week hopefully. -- ass

[issue1266] segfault in curses when calling redrawwin() before refresh()

2007-10-11 Thread Neal Norwitz
Neal Norwitz added the comment: What platform are you on? I can reproduce this with 2.5.1+ and trunk on Ubuntu. I can reproduce with a trivial C program that does the same thing. This could be a bug in the curses implementation. Or it could be misuse of the API. I don't know enou

[issue1233] bsddb.dbshelve.DbShelf.append doesn't work

2007-10-11 Thread Neal Norwitz
Neal Norwitz added the comment: Gregory, could you take a look at this? -- assignee: -> gregory.p.smith components: +Extension Modules -Library (Lib) nosy: +gregory.p.smith, nnorwitz __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.o

[issue1216] Python2.5.1 fails to compile under VC.NET2002 ( 7.0 )

2007-10-11 Thread Neal Norwitz
Neal Norwitz added the comment: Martin, it looks like you made some changes in rev 46064. Can you suggest anything? -- assignee: -> loewis components: +Extension Modules nosy: +loewis, nnorwitz __ Tracker <[EMAIL PROTECTED]> <http://bug

[issue1631171] implement warnings module in C

2007-10-17 Thread Neal Norwitz
Neal Norwitz added the comment: I think this is good enough for now. The approach will probably stand even if the details change. Go for it! _ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/iss

[issue1631171] implement warnings module in C

2007-10-17 Thread Neal Norwitz
Changes by Neal Norwitz: -- assignee: nnorwitz -> brett.cannon _ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1631171> _ ___ Python-bugs-li

[issue1307] smtpd.SMTPServer throws exception on MAIL command with no arg

2007-10-22 Thread Neal Norwitz
Neal Norwitz added the comment: It would be great to get this into 2.5.2. -- assignee: nnorwitz -> gvanrossum __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.o

[issue1307] smtpd.SMTPServer throws exception on MAIL command with no arg

2007-10-22 Thread Neal Norwitz
Neal Norwitz added the comment: Thanks for the patch. Committed revision 58599. (2.5) -- status: open -> closed __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.o

[issue1313] Typo in Python Library Reference documentation: logging module

2007-10-22 Thread Neal Norwitz
Neal Norwitz added the comment: Thanks for the report. Committed revision 58600. (2.5) Committed revision 58601. 3.0 will be fixed when we merge. -- assignee: -> nnorwitz nosy: +nnorwitz resolution: -> fixed status: open -> closed __ Tracke

[issue1307] smtpd.SMTPServer throws exception on MAIL command with no arg

2007-10-23 Thread Neal Norwitz
Neal Norwitz added the comment: Committed revision 58625. (2.5) -- status: open -> closed __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1307> __

[issue1329] Different 3.0a1 exit behavior

2007-10-25 Thread Neal Norwitz
Neal Norwitz added the comment: Thanks for testing 3.0. Do you have any idea why they are no longer called? I don't recall any changes related to this area. Can you try to debug further? -- nosy: +nnorwitz __ Tracker <[EMAIL PROTECTED

[issue1329] Different 3.0a1 exit behavior

2007-10-26 Thread Neal Norwitz
Neal Norwitz added the comment: Maybe that's because site and io get cleaned up and then there is some fatal error that can't be printed? __ Tracker <[EMAIL PROTECTED]> <http://bugs.p

[issue1329] Different 3.0a1 exit behavior

2007-10-26 Thread Neal Norwitz
Neal Norwitz added the comment: I suggest you configure --with-pydebug. That will disable optimization, enable debugging symbols and will make it easier to develop. Note that a debug version runs much slower due to asserts() and other internal changes. Otherwise, it should work the same. On

[issue1329] Different 3.0a1 exit behavior

2007-10-26 Thread Neal Norwitz
Neal Norwitz added the comment: When I run with the attached patch, I see the message: *** dtor called in python ... Is that the behavior you expect? Added file: http://bugs.python.org/file8626/stdout-close.patch __ Tracker <[EMAIL PROTECTED]>

[issue1631171] implement warnings module in C

2007-10-30 Thread Neal Norwitz
Neal Norwitz added the comment: I think Brett summarized the issues well. I can't think of anything else that seems to need doing. _ Tracker <[EMAIL PROTECTED]> <http://bugs.python.or

[issue1358] Compile error on OS X 10.5

2007-10-30 Thread Neal Norwitz
Neal Norwitz added the comment: I don't have access to a 10.5 machine. My guess is that the difference is between configure not setting _XOPEN_SOURCE and/or _XOPEN_SOURCE_EXTENDED and it being set in pyconfig.h. At least those are both defined on 10.4. This page talks about needi

[issue1574217] isinstance swallows exceptions

2007-10-30 Thread Neal Norwitz
Neal Norwitz added the comment: Yeah, this seems like a bug and the patch seems correct. The patch also needs a test and add a space between if (. _ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/iss

[issue1490190] add os.chflags() and os.lchflags() where available

2007-10-30 Thread Neal Norwitz
Neal Norwitz added the comment: Martin's patch from 2007-03-21 fixed the problem with test_posix. It now passes all the tests (test_posix and rest of test suite). The tests/interpreter do not exit prematurely. I think it is good to apply this patch. -- assignee: nnorwitz ->

[issue1346] Error using >>> from OpenGL.GLUT import *

2007-10-30 Thread Neal Norwitz
Neal Norwitz added the comment: As gagenellina said, this problem appears to be with OpenGL, not python. OpenGL is not maintained here. You'll have to open a bug report with them. -- nosy: +nnorwitz resolution: -> rejected status: open -

[issue1705170] contextmanager eats StopIteration

2007-11-06 Thread Neal Norwitz
Neal Norwitz added the comment: Nick, can you backport this and add a NEWS entry? Thanks. -- nosy: +nnorwitz _ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/iss

[issue10399] AST Optimization: inlining of function calls

2010-11-20 Thread Neal Norwitz
Neal Norwitz added the comment: There is some precedent for allowing minor differences in -O mode. http://mail.python.org/pipermail/python-dev/2008-February/077193.html I think we should push this to see how practical we can make it. Dave, this is great work, I'm really interested to se

[issue1574217] isinstance swallows exceptions

2008-05-19 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: > I'd like to clarify the approach to fixing these types of problems. > ... > However, I like constricting it to AttributeError only as that would > make it much less confusing. This might be something to bring up on &

[issue2620] Multiple buffer overflows in unicode processing

2008-07-27 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: Committed revision 65261 for 2.5 Committed revision 65262 for 2.4. -- status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.py

[issue3627] apple security patches need to be forward ported to py3k

2008-08-20 Thread Neal Norwitz
New submission from Neal Norwitz <[EMAIL PROTECTED]>: The trunk revision was 65335. -- components: Interpreter Core messages: 71608 nosy: nnorwitz priority: release blocker severity: normal status: open title: apple security patches need to be forward ported to py3k versions: Pyth

[issue3656] unicode encoding has lots of leaks of bytes

2008-08-23 Thread Neal Norwitz
New submission from Neal Norwitz <[EMAIL PROTECTED]>: Some of these leaks reported by valgrind are likely duplicates. I don't know how many individual cases of these leaks there are. 11,119 bytes in 14 blocks are possibly lost in loss record 86 of 119 realloc (vg_replace_m

[issue3656] unicode encoding has lots of leaks of bytes

2008-08-23 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: There are also tons of reference leaks when running regrtest.py with -R. Even code as simple as this leaks: >>> eval('1') 1 [40731 refs] >>> eval('1') 1 [40732 refs] >>> eval('1

[issue3651] eval() leaks 1 reference every time

2008-08-23 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: This is a partial (or complete) duplicate of 3656. -- nosy: +nnorwitz ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue3656] unicode encoding has lots of leaks of bytes

2008-08-23 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: This is a partial (or complete) duplicate of 3651. ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue3657] pickle can pickle the wrong function

2008-08-24 Thread Neal Norwitz
New submission from Neal Norwitz <[EMAIL PROTECTED]>: test_pickletools fails sporadically on at least two platforms I've seen. http://www.python.org/dev/buildbot/all/x86%20gentoo%20trunk/builds/4120/step-test/0 http://www.python.org/dev/buildbot/all/ppc%20Debian%20unstable%20trunk/

[issue3627] apple security patches need to be forward ported to py3k

2008-08-24 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: Committed revision 66009. -- assignee: -> nnorwitz resolution: -> fixed status: open -> closed type: -> security ___ Python tracker <[EMAIL PROTECTED]> <http:

[issue3651] eval() leaks 1 reference every time

2008-08-24 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: Even with the patch, there are still tons of leaks. I don't know if it's due to the same problem or not. So far there is: test_unittest leaked [124, 124] references, sum=248 test_array leaked [110, 110] references, sum=

[issue2744] Fix test_cProfile

2008-08-24 Thread Neal Norwitz
Changes by Neal Norwitz <[EMAIL PROTECTED]>: -- priority: critical -> release blocker ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.py

[issue3660] reference leaks in 3.0

2008-08-24 Thread Neal Norwitz
New submission from Neal Norwitz <[EMAIL PROTECTED]>: Even after adding the current patch in http://bugs.python.org/issue3651 there are many reference leaks. This bug can be a placeholder for all the reference leaks returned from: ./python ./Lib/test/regrtest.py -R 3:2 -uall,-bsddb

[issue3610] Fix gdbinit for Python 3.0

2008-08-24 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: I fixed some problems in r66016. This patch seems like it has other things which might be useful, so I'll keep it open until it's handled. -- nosy: +nnorwitz ___ Python tracker &

[issue3651] eval() leaks 1 reference every time

2008-08-24 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: Another PyBuffer_Release(&pin); looks necessary at @@ -805,6 +807,7 @@. ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.p

[issue3304] invalid call to PyMem_Free() in fileio_init()

2008-08-24 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: In 3.0 the free is necessary, though see http://bugs.python.org/issue3662 . -- nosy: +nnorwitz status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.py

[issue3662] _fileio._FileIO segfaults

2008-08-24 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: Daniel, thanks for running the fuzzer! It would be great if you could keep running it and find any more problems before releasing 2.6 and 3.0. I agree with Benjamin and Amaury. PyArg_ParseTupleAndKeywords() shouldn't update the po

[issue1375] hotshot IndexError when loading stats

2008-08-24 Thread Neal Norwitz
Changes by Neal Norwitz <[EMAIL PROTECTED]>: -- type: crash -> behavior ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1375> ___ ___

[issue2456] Make sysmodule.c compatible with Bazaar

2008-08-24 Thread Neal Norwitz
Changes by Neal Norwitz <[EMAIL PROTECTED]>: -- type: crash -> feature request ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue2456> ___ _

[issue1210] imaplib does not run under Python 3

2008-08-24 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: Is this still a problem? -- nosy: +nnorwitz type: crash -> behavior ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.py

[issue1658] "RuntimeError: dictionary changed size during iteration" in Tkinter

2008-08-24 Thread Neal Norwitz
Changes by Neal Norwitz <[EMAIL PROTECTED]>: -- type: crash -> behavior ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1658> ___ ___

[issue1840] Tools/i18n/msgfmt.py fixes for Python 3.0

2008-08-24 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: Is this still a problem? -- nosy: +nnorwitz type: crash -> behavior ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.py

[issue2747] Documentation of new gobject types fails

2008-08-24 Thread Neal Norwitz
Changes by Neal Norwitz <[EMAIL PROTECTED]>: -- type: crash -> behavior ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue2747> ___ ___

[issue2562] Cannot use non-ascii letters in disutils if setuptools is used.

2008-08-24 Thread Neal Norwitz
Changes by Neal Norwitz <[EMAIL PROTECTED]>: -- type: crash -> behavior ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue2562> ___ ___

[issue1838] Ctypes C-level infinite recursion

2008-08-24 Thread Neal Norwitz
Changes by Neal Norwitz <[EMAIL PROTECTED]>: -- assignee: -> theller components: +ctypes -Extension Modules nosy: +theller ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.py

[issue3657] pickle can pickle the wrong function

2008-08-24 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: The valgrind errors below are possibly related. Conditional jump or move depends on uninitialised value(s) PyUnicodeUCS2_EncodeUTF8 (unicodeobject.c:2216) _PyUnicode_AsString (unicodeobject.c:1417) save (_pickle.c:930) Pickle

[issue3651] eval() leaks 1 reference every time

2008-08-24 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: With the latest patch (and the one addition PyBuffer_Release() I noted above), valgrind is happy wrt memory leaks. The only problem valgrind found is a read of uninitialized memory. See http://bugs.python.org/issue3657 . I don'

[issue3651] eval() leaks 1 reference every time

2008-08-24 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: Also there should be a Misc/NEWS entry added. Also check the doc to see it needs updating wrt ownership. -- type: -> resource usage ___ Python tracker <[EMAIL PROTECTED]> <http

[issue3657] pickle can pickle the wrong function

2008-08-24 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: Indeed. The problem was an incorrect conversion of str -> unicode, instead of converting to bytes. On getting the buffer from unicode, it tried to read data which was uninitialized. Hmmm, this fix is for 3.0 only, but the p

[issue3673] bsddb module leaks memory

2008-08-24 Thread Neal Norwitz
New submission from Neal Norwitz <[EMAIL PROTECTED]>: The attached patch against 2.6 fixes the memory leaks reported against the bsddb module. There are still (probably) reference leaks. Jesus, it would be great if you can look at this before the release. -- assignee: jcea comp

[issue3657] pickle can pickle the wrong function

2008-08-24 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: It seems that if the tests are run in this order: ./python -E -tt ./Lib/test/regrtest.py -u all test_xmlrpc test_ctypes test_json test_bsddb3 test_pickletools The error will trigger consistently. That is in 2.6 with a debug build on

[issue1210] imaplib does not run under Python 3

2008-08-26 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: This may not be a real release blocker, but I want to raise the priority. It is a regression and we should try to fix it, especially if it's easy. -- priority: normal -> release blocker

[issue3660] reference leaks in 3.0

2008-09-04 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: The only one that is probably an issue based on Antoine's info is: test_unicode leaked [1, 1] references, sum=2 I've seen test_urllib2_localnet leak 3 before. I don't know that it's a real leak. I'm pretty sur

[issue4970] test_os causes delayed failure on x86 gentoo buildbot: Unknown signal 32

2010-04-13 Thread Neal Norwitz
Neal Norwitz added the comment: Thanks for taking care of this guys. Sorry, I got swamped with mail and had to archive 3,000+ messages. It looks like it's in good hands. Let me know if there's anything you need. I may not have access to the box anymore, however, I can always co

[issue1617] Rare exception in test_urllib2net

2007-12-13 Thread Neal Norwitz
Neal Norwitz added the comment: This may happen every time on the MIPS buildbot. Here is a recent run. http://www.python.org/dev/buildbot/all/MIPS%20Debian%20trunk/builds/190/step-test/0 My guess is that there is some exception happening in C code and that propagates back up to the error we

[issue1303614] Bypassing __dict__ readonlyness

2008-01-23 Thread Neal Norwitz
Changes by Neal Norwitz: -- nosy: +nnorwitz _ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1303614> _ ___ Python-bugs-list mailing list Unsubs

[issue1303614] Bypassing __dict__ readonlyness

2008-01-23 Thread Neal Norwitz
Neal Norwitz added the comment: I looked at Guido's latest deldict.diff patch--the one to Objects/object.c only. It seems good. I can't convince myself either way about the change to Objects/typeobject.c. I can't think of a way to cause a problem. It seems safer to use Py_CLE

[issue1617] Rare exception in test_urllib2net

2008-01-23 Thread Neal Norwitz
Neal Norwitz added the comment: This started happening consistently on my box and I was able to reproduce it. Revision 60233 should fix this problem. I forwarded the checkin to Greg. Hopefully he can comment if there is a problem. (Also cc'd him on this bug report that I'm n

[issue1621] Do not assume signed integer overflow behavior

2008-01-25 Thread Neal Norwitz
Changes by Neal Norwitz: -- nosy: +nnorwitz __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1621> __ ___ Python-bugs-list mailing list Unsubs

[issue1621] Do not assume signed integer overflow behavior

2008-01-27 Thread Neal Norwitz
Neal Norwitz added the comment: I'm just starting to look at the patch. The first one changes i to unsigned in Modules/_csv.c. Hopefully most of them are like this. The code is fine as it is. There is no reliance on overflow AFAICT. It's just that the breaking condition from the l

[issue1621] Do not assume signed integer overflow behavior

2008-01-27 Thread Neal Norwitz
Neal Norwitz added the comment: I just added -Wstrict-overflow to the code in sysmodule.c (sys_getframe) and tried with gcc 4.2.1. It doesn't warn. I wonder if 4.3 is more picky or warns when it shouldn't? Unless if I changed the code so it doesn't work: typedef struct {int

[issue1621] Do not assume signed integer overflow behavior

2008-01-27 Thread Neal Norwitz
Neal Norwitz added the comment: On Jan 27, 2008 6:45 PM, Ismail Donmez <[EMAIL PROTECTED]> wrote: > > Can you try with -Wstrict-overflow=3 , but yes I am using gcc 4.3 trunk. I just tried with =1, =2, =3, and no =. All the same result: no warning. Ismail, thanks for going thro

[issue1953] Compact int and float freelists

2008-02-03 Thread Neal Norwitz
Neal Norwitz added the comment: I think sys is appropriate for clearing the cache. Lib/test/regrtest.py still has a reference to gc rather than sys. Why do the CompactFreeList APIs return an int that is always 0? Seems like they should return a real value or be void. I'm not sure wh

[issue1750076] Python 2.5+ skips while statements in debuggers

2008-02-03 Thread Neal Norwitz
Neal Norwitz added the comment: I was hoping you could get rid of my entire hack. I didn't (still don't) completely understand the intention of the code, so can't really offer any more advice. IMO, the patch is an improvement so you should check it in. -- ass

[issue2147] int operations no longer overflow

2008-02-19 Thread Neal Norwitz
New submission from Neal Norwitz: Georg, I hope you don't mind me assigning this to you. Feel free to unassign. A colleague pointed me to section 5.7 in the old ref doc: http://docs.python.org/ref/shifting.html It says that shifting operations lose data on overflow. This info is out

[issue2181] optimize out local variables at end of function

2008-02-24 Thread Neal Norwitz
New submission from Neal Norwitz: This patch optimizes code like: x = any_expression return x to: return any_expression Currently it only optimizes out the local variable if there is a return because it can't determine if this is the last use of the variable or not. This shou

[issue2181] optimize out local variables at end of function

2008-02-24 Thread Neal Norwitz
Neal Norwitz added the comment: I forgot to mention that if another loop was added to PyCode_Optimize that kept track of the # of times each local variable was LOAD_FAST/STORE_FAST/DELETE_FAST and that the count was 2, we could perform a similar optimization without requiring the return. Bonus

[issue2183] optimize list comprehensions

2008-02-24 Thread Neal Norwitz
New submission from Neal Norwitz: Optimize list comprehensions by using the list on the stack, rather than storing in a (local/global) variable. This reduces the size of the stack by one pointer, reduces the bytecode size by 8, and reduces the iterations in the eval loop by 2 + # of iterations

[issue2181] optimize out local variables at end of function

2008-02-24 Thread Neal Norwitz
Neal Norwitz added the comment: I forgot to mention that if another loop was added to PyCode_Optimize that kept track of the # of times each local variable was LOAD_FAST/STORE_FAST/DELETE_FAST and that the count was 2, we could perform a similar optimization without requiring the return. Bonus

[issue1394] simple patch, improving unreachable bytecode removing

2008-02-24 Thread Neal Norwitz
Neal Norwitz added the comment: It would be great to see test cases with this change. That would help answer Alexander's question too. -- nosy: +nnorwitz __ Tracker <[EMAIL PROTECTED]> <http://bugs.python

[issue2185] code objects should conserve memory

2008-02-24 Thread Neal Norwitz
New submission from Neal Norwitz: Various bits are often duplicated in code objects. For example, sometimes names and varnames are equal. In this case, we don't need two objects since they are both const. This patch implements a trivial fix for this case. However, there are more cases

[issue2181] optimize out local variables at end of function

2008-02-24 Thread Neal Norwitz
Neal Norwitz added the comment: Guido says to do it only with -O. http://mail.python.org/pipermail/python-dev/2008-February/077193.html __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/

[issue1691070] Speed up PyArg_ParseTupleAndKeywords() and improve error msg

2008-02-24 Thread Neal Norwitz
Neal Norwitz added the comment: Christian, Could you clean this patch up? Specifically: * Put everything into one patch * Eliminate unnecessary changes (changing variable name or whitespace) * Conform to the style in the file * Verify all the tests run with regrtest.py -u all when built

[issue1518] Fast globals/builtins access (patch)

2008-02-24 Thread Neal Norwitz
Neal Norwitz added the comment: I've gone over this at a high-level and looked for various outstanding issues. Below are my comments. I didn't delve into this in detail. There are a lot of questions too. I think this is very interesting and hope that we can get it working, 100% r

[issue2168] gdbm needs to be iterable

2008-02-25 Thread Neal Norwitz
Neal Norwitz added the comment: Thomas, thanks for fixing this. I didn't see any specific problems with the patch, but I'm wondering why the code doesn't just call has_key in both cases? -- nosy: +nnorwitz __ Tracker <[EMAIL

[issue1691070] Speed up PyArg_ParseTupleAndKeywords() and improve error msg

2008-02-25 Thread Neal Norwitz
Neal Norwitz added the comment: I looked over the new patch Christian uploaded and I think I understand what's going on. I didn't do a through comparison, but if all the tests pass, I think that's good enough. Good work! Here are the issues I would like to see fixed before chec

[issue1691070] Speed up PyArg_ParseTupleAndKeywords() and improve error msg

2008-02-25 Thread Neal Norwitz
Changes by Neal Norwitz: -- assignee: nnorwitz -> tiran _ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1691070> _ ___ Python-bugs-li

[issue1394] simple patch, improving unreachable bytecode removing

2008-02-25 Thread Neal Norwitz
Neal Norwitz added the comment: Can you add more tests? It seems that almost all the examples given in this thread are good examples. Also something like: while 1: if cond: return 1 return 2 return 3 There are a bunch more cases that could be added for where the code should be

[issue1691070] Speed up PyArg_ParseTupleAndKeywords() and improve error msg

2008-02-26 Thread Neal Norwitz
Neal Norwitz added the comment: On Tue, Feb 26, 2008 at 12:51 AM, Christian Heimes <[EMAIL PROTECTED]> wrote: > > > * Verify that it's faster by compiling python in a release build > > It's roughly the same speed. :/ The variation between timeit runs is >

[issue2181] optimize out local variables at end of function

2008-02-27 Thread Neal Norwitz
Neal Norwitz added the comment: > I suppose you are aware that performing this optimization in general > would break a lot of existing code that uses inspect.getstack() or > sys._getframe() to peek at the caller's local variables. I know this Yes, with this optimization the

[issue2262] Helping the compiler avoid memory references in PyEval_EvalFrameEx

2008-03-09 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: I bet with just a little more work, you could get rid of t and stream. t is only used for a single set of opcodes (STORE_SLICE+n). stream is only used for the PRINT opcodes. The code in print could be moved to a function which might

[issue2262] Helping the compiler avoid memory references in PyEval_EvalFrameEx

2008-03-09 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: Can't next_instr and stack_pointer move inside the for loop too? __ Tracker <[EMAIL PROTECTED]> <http://bugs.

[issue2291] Catching all exceptions with 'object'

2008-03-15 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: See PEP 352. Currently this is slated for python 2.8. Perhaps the schedule should be sped up a bit in light the current release schedule. Brett, any comments? We should add all the warnings from PEP 352 with the -3 flag

[issue2185] code objects should conserve memory

2008-03-15 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: Marshal is the wrong place for this sort of thing (the code object is where it should be done). I botched the analysis. The case is common, but only for the empty tuple which I forgot to ignore. (None,) was a common case when I measu

[issue2321] return more memory from unicode objects to system

2008-03-17 Thread Neal Norwitz
New submission from Neal Norwitz <[EMAIL PROTECTED]>: This patch returns more memory to the system when doing: >>> x = [unicode(i) for i in xrange(100)] >>> del x If the above code is done, the memory before and after is quite different. After this patch, the

[issue2321] return more memory from unicode objects to system

2008-03-17 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: On Mon, Mar 17, 2008 at 11:55 AM, Alec Thomas <[EMAIL PROTECTED]> wrote: > > Alec Thomas <[EMAIL PROTECTED]> added the comment: > > Hi Neal, > > This seems to be a more general problem than just unicode.

[issue2375] PYTHON3PATH environment variable to supersede PYTHONPATH for multi-Python environments

2008-03-17 Thread Neal Norwitz
Changes by Neal Norwitz <[EMAIL PROTECTED]>: -- assignee: -> nnorwitz nosy: +nnorwitz priority: -> urgent __ Tracker <[EMAIL PROTECTED]> <http://bugs

[issue2321] return more memory from unicode objects to system

2008-03-17 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: After discussing this with MvL, I'll check this patch into trunk and 2.5. Alec, if you find other issues, please create a new patch. Committed revision 61458. Committed revision 61485. (2.5) __ Trac

[issue2321] return more memory from unicode objects to system

2008-03-17 Thread Neal Norwitz
Changes by Neal Norwitz <[EMAIL PROTECTED]>: -- assignee: -> nnorwitz resolution: -> accepted status: open -> closed __ Tracker <[EMAIL PROTECTED]> <http://b

[issue2321] return more memory from unicode objects to system

2008-03-17 Thread Neal Norwitz
Changes by Neal Norwitz <[EMAIL PROTECTED]>: __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue2321> __ ___ Python-bugs-list mailing list Unsubscribe: http

[issue2332] Renaming of attributes on functions need to be backported.

2008-03-17 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: Committed revision 61492. -- resolution: -> fixed status: open -> closed __ Tracker <[EMAIL PROTECTED]> <http://bugs

[issue2400] from .foo import * should work

2008-03-18 Thread Neal Norwitz
New submission from Neal Norwitz <[EMAIL PROTECTED]>: Explicit relative imports using from .foo import * should work. http://mail.python.org/pipermail/python-3000/2008-March/012564.html -- components: Interpreter Core messages: 63942 nosy: nnorwitz priority: critical severity:

  1   2   >