Guilherme Polo <[EMAIL PROTECTED]> added the comment:
This is indeed a problem with Tkinter only, but I didn't check what is
causing it yet.
For the suggestion about fixing the search method regarding the pattern:
the fix is almost fine, but we need to disallow None a
Changes by Guilherme Polo <[EMAIL PROTECTED]>:
--
priority: -> release blocker
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue4342>
___
_
Guilherme Polo added the comment:
On Wed, Dec 10, 2008 at 6:44 AM, Martin v. Löwis wrote:
>
> Martin v. Löwis added the comment:
>
> What problem is solved by ScrolledText.diff that isn't already solved by
> scrolledtext_masterstr.diff?
None. The later is a cleanu
Guilherme Polo added the comment:
On Wed, Dec 10, 2008 at 6:15 AM, Martin v. Löwis wrote:
>
> Martin v. Löwis added the comment:
>
> I'm skeptical about backporting r59654. Doing so might break existing
> applications.
>
I don't see in what way it would brea
Guilherme Polo added the comment:
On Wed, Dec 10, 2008 at 6:21 AM, Martin v. Löwis wrote:
>
> Martin v. Löwis added the comment:
>
> Can you remind me what problem was fixed with r59653? I can't find the
> Tk tracker anymore on which this apparently was reported.
>
I
Guilherme Polo added the comment:
On Fri, Dec 12, 2008 at 9:06 PM, Martin v. Löwis wrote:
>
> Martin v. Löwis added the comment:
>
>> I don't see in what way it would break existing applications. The
>> indices returned by that command in Tcl should all be represent
Guilherme Polo added the comment:
Something like the proposed patch is still needed. But allow me to point
out my views towards your current patch:
* Changes in Misc.after, Misc._bind: good
* Changes in Misc.unbind can be simplified a bit:
cbs = self._bind_names(self._bind(('bind'
Guilherme Polo added the comment:
Sample attached for demonstrating the leak by missing a call to
Tkapp_CallDeallocArgs.
--
nosy: +gpolo
Added file: http://bugs.python.org/file12373/test_tkleak1.py
___
Python tracker
<http://bugs.python.
Guilherme Polo added the comment:
Fix: My previous comment was about changes in Misc.deletecommand not
Misc.destroy (this is what you get for guessing the methods changed in
the diff, without applying it).
To Quentin: I wouldn't bother mentioning it since this new TkinterError
exception s
Guilherme Polo added the comment:
Rethinking about the changes done in Misc._configure I found out that
you don't need any of those there.
Isn't it the case of only improving the changes regarding callable
overwriting in Misc._options ? So if the value is a callable and the
opti
Guilherme Polo added the comment:
The changes in Misc.destroy do not look right, why are you deleting
commands created by bind_all (for example) from the root window when a
simple widget is destroyed ?
It would make more sense to not apply these changes in Misc.destroy,
instead
Guilherme Polo added the comment:
I've fixed the leaks in Variable doing this:
http://code.google.com/p/plumage/source/detail?r=93
I don't use an extra _tclCommands for Variable, instead in __del__ I use
the information returned by Variable.trace_vinfo to remove associated
Guilherme Polo added the comment:
On Wed, Dec 17, 2008 at 3:51 PM, Guilherme Polo wrote:
>
> Guilherme Polo added the comment:
>
> Rethinking about the changes done in Misc._configure I found out that
> you don't need any of those there.
> Isn't it the case o
Guilherme Polo added the comment:
You don't need to cast PyObject_HashNotImplemented to hashfunc
--
nosy: +gpolo
___
Python tracker
<http://bugs.python.org/i
Guilherme Polo added the comment:
On Fri, Dec 19, 2008 at 2:02 PM, Hagen Fürstenau wrote:
>
> Hagen Fürstenau added the comment:
>
> Why does every other place seem to do the cast? Historical reasons?
>
No, if you look at the functions being casted you will notice them do
not
Guilherme Polo added the comment:
On Fri, Dec 19, 2008 at 2:14 PM, Hagen Fürstenau wrote:
>
> Hagen Fürstenau added the comment:
>
> I'm talking about places like these:
>
> [hag...@chage py3k]$ grep -R "(hashfunc)PyObject_HashNotImplemented"
> Objects/*.
Guilherme Polo added the comment:
It isn't being careful when calling PyErr_SetFromErrno inside the
Py_UniversalNewlineFread function since this function is being called
all over fileobject after releasing the GIL.. so, isn't this just a
matter of adding pairs of PyGILSt
Guilherme Polo added the comment:
On Sun, Dec 21, 2008 at 9:52 PM, Martin v. Löwis wrote:
>
> Martin v. Löwis added the comment:
>
>> It isn't being careful when calling PyErr_SetFromErrno inside the
>> Py_UniversalNewlineFread function since this function i
Guilherme Polo added the comment:
I hope you are not too bored for me commenting on this again.
So, I have re-though about this issue today and decided to solve it
differently (and will include a patch here this time, don't worry about
mentions to external repo this time).
To solve the pr
Changes by Guilherme Polo :
Removed file: http://bugs.python.org/file12427/keep_tclcommands_correct.diff
___
Python tracker
<http://bugs.python.org/issue1524639>
___
___
Changes by Guilherme Polo :
Added file: http://bugs.python.org/file12430/keep_tclcommands_correct.diff
___
Python tracker
<http://bugs.python.org/issue1524639>
___
___
Guilherme Polo added the comment:
On Mon, Dec 29, 2008 at 2:02 PM, Martin v. Löwis wrote:
>
> Martin v. Löwis added the comment:
>
> Notice that the example function doesn't actually work; it gives
>
> _tkinter.TclError: wrong # args: should be ".148002724.14
Changes by Guilherme Polo :
___
Python tracker
<http://bugs.python.org/issue3833>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/o
Guilherme Polo added the comment:
Jimmy Retzlaff (msg73003):
I'm seeing the same symptoms that are described in issue 1543 with the
2.6b3 MSIs. Namely, when you run one of the MSIs (either 32-bit or
64-bit) then the other will refuse to install. This is on XP Pro x64 SP2.
python-3.0b3.ms
Guilherme Polo added the comment:
Uhm ? The builtin cmp wasn't removed.
--
nosy: +gpolo
___
Python tracker
<http://bugs.python.org/issue4760>
___
___
Pytho
Guilherme Polo added the comment:
I was about to mark this as invalid when I found out I had patched
tkinter/filedialog.py myself. Nevertheless, this is a duplicate of issue4406
--
nosy: +gpolo
resolution: -> duplicate
status: open ->
Guilherme Polo added the comment:
I'm moving this to release blocker since it went unnoticed in the 3.0
release.
--
priority: -> release blocker
___
Python tracker
<http://bugs.python.or
New submission from Guilherme Polo :
Right now PythonCmd is using the Tcl interpreter stored in self->interp,
but this is unsafe and since it is a Tcl_CmdProc it already receives the
Tcl interpreter as a parameter. Using the interpreter in self->interp is
unsafe because Python might deal
Guilherme Polo added the comment:
On Wed, Dec 31, 2008 at 2:24 PM, Antoine Pitrou wrote:
>
> Antoine Pitrou added the comment:
>
> "tkinter.mainloop" seems used in a bunch of places according to Google
> Code. Am I missing something?
>
Yes, those are not
Guilherme Polo added the comment:
On Wed, Dec 31, 2008 at 2:27 PM, Guilherme Polo wrote:
>
> Guilherme Polo added the comment:
>
> On Wed, Dec 31, 2008 at 2:24 PM, Antoine Pitrou
> wrote:
>>
>> Antoine Pitrou added the comment:
>>
>> "tkint
Guilherme Polo added the comment:
Eh.. old.
Anyway, I have made a patch against trunk now and it should work with
any nested level of cloned menus according to how tk names cloned menus.
--
nosy: +gpolo
versions: +Python 2.6, Python 2.7, Python 3.0, Python 3.1 -Python 2.3
Added file
Guilherme Polo added the comment:
This is not going to happen.
You should be protecting it yourself since this is a special case.
--
nosy: +gpolo
resolution: -> wont fix
status: open -> closed
___
Python tracker
<http://bugs.python.org/is
Guilherme Polo added the comment:
Closing as only r59654 was backported to release25-maint, so Tk 8.5 is
not fully supported by the standard Tkinter present in python 2.5.x
--
resolution: -> wont fix
status: open -> closed
___
Python tracker
Changes by Guilherme Polo :
--
title: IDLE doesn't work with Tk 8.5 -> IDLE doesn't work with Tk 8.5 under
python 2.5 and older
___
Python tracker
<http://bugs.pyth
Guilherme Polo added the comment:
Can you retry making some small example that demonstrates the problem ?
--
nosy: +gpolo
___
Python tracker
<http://bugs.python.org/issue2
Guilherme Polo added the comment:
Dropped for inclusion in python 2.5, but should still be considered for
trunk and py3k.
--
resolution: -> accepted
versions: +Python 2.7, Python 3.0, Python 3.1 -Python 2.5
___
Python tracker
&l
Guilherme Polo added the comment:
Your example doesn't disprove the "merely syntactic sugar" found in the
documentation about the decorator syntax.
The results you are getting are based on when the decorator is applied.
--
nosy: +gpolo
resolution: -> invalid
stat
Guilherme Polo added the comment:
I see some issues related to scrolling under macosx were fixed in tk
8.4.13, but I can't test them since I don't have a mac.
If scrolling doesn't work with the example below then I can just say the
problem is indeed with tk, but you could t
Guilherme Polo added the comment:
I'm closing this as won't fix but let me tell what you can do to solve
the problem yourself (this may be added somewhere else then, like in the
tkinter wiki).
First, check the keysym you get when pressing Shift-BackSpace:
import Tkinter
def show
Guilherme Polo added the comment:
Just for future reference it is now on
http://tkinter.unpy.net/wiki/Linux_Shift-Backspace
___
Python tracker
<http://bugs.python.org/issue1482
Guilherme Polo added the comment:
I would actually prefer to move xview and yview method to classes like
it was done in xview_yview.patch (I've done this on a personal branch
some time ago too, but named them as XScroll, YScroll), we can see they
are used in several places in Tkinter, Ti
Guilherme Polo added the comment:
Fixed the issue now.
_tkinter.call needs to use the TCL_EVAL_GLOBAL flag since all the
variables in Tkinter are global variables.
Matthias: your issue about the pattern should be placed in a different
issue.
--
keywords: +patch
versions: +Python 2.6
Guilherme Polo added the comment:
Victor, you seem to be confusing "code that supports it" with "functions
that use it". There are some conditional code inside Tkapp_MainLoop that
depends on self being available, that is what Martin meant by code that
supports it, and sinc
Guilherme Polo added the comment:
> Martin v. Löwis added the comment:
>
>> Now, I'm much more in favour to remove it from moduleMethods than from
>> adjusting it to work in py3k.
>
> Would you apply the same reasoning to the other Tkapp methods available
> on
Guilherme Polo added the comment:
> Martin v. Löwis added the comment:
>
>> But I don't see a RPC being used there, I just see some polling.
>
> Consider Tkapp_Call (e.g.). If this is invoked in the Tk interpreter
> thread, then there is a direct call to Tcl_EvalObj
Changes by Guilherme Polo :
--
resolution: -> duplicate
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue4823>
___
___
Python-bugs-
Guilherme Polo added the comment:
Here is a patch, two actually. The next one deprecates the functions in
trunk
Added file: http://bugs.python.org/file12574/issue3638.diff
___
Python tracker
<http://bugs.python.org/issue3
Changes by Guilherme Polo :
Added file: http://bugs.python.org/file12575/deprecated_funcs.diff
___
Python tracker
<http://bugs.python.org/issue3638>
___
___
Python-bug
Guilherme Polo added the comment:
> These look fine. I think further changes are necessary:
> tkinter/__init__.py tries to load createfilehandler/deletefilehandler;
> this becomes redundant.
Indeed, I forgot to look into the Python code.
I also see as redundant the checks for
Guilherme Polo added the comment:
> I get an empty string with the text below, but I was expecting some
s/text/test
___
Python tracker
<http://bugs.python.org/iss
Guilherme Polo added the comment:
Thanks Martin,
trunk: r68231 (blocked on py3k)
py3k: r68237
release30-maint: r68239
--
resolution: -> fixed
status: open -> closed
title: tkinter.mainloop() is meaningless and crash: remove it -> Remove module
level functions in _tkinter th
Guilherme Polo added the comment:
Uh, I forgot about the code removal in __init__ in the first commits.
r68242, r68244 now
___
Python tracker
<http://bugs.python.org/issue3
Guilherme Polo added the comment:
> Do you still need a review for this, Guilherme? If you just need a quick
> code check I can see if I can make the time for this, but my tkinter
> knowledge is lacking so it won't be very in-depth. Hopefully this is all
> isolated enough t
Guilherme Polo added the comment:
> As for the testing question, I am not sure I understand what you are
> asking. Are you asking if the tests can stay integrated with tkinter's
> existing tests?
>
There are no tests for tkinter, except for some few ones for _tkinter
basic fun
Changes by Guilherme Polo :
--
versions: +Python 2.6, Python 2.7, Python 3.1
___
Python tracker
<http://bugs.python.org/issue4676>
___
___
Python-bugs-list mailin
Guilherme Polo added the comment:
It would be nice if the OP could confirm that the bug described by
Daniel is the same one as he gets. I can reproduce it on linux on all
the versions I marked, but didn't have time to fix it yet.
To the OP: If you are running Windows, try starting IDLE o
Guilherme Polo added the comment:
Patch against trunk attached.
It fixes only the first problem reported, and I can't reproduce the
second one.
--
keywords: +patch
Added file: http://bugs.python.org/file12601/issue_4676.diff
___
Python tr
Guilherme Polo added the comment:
Can you add some example ?
Is the bug new to python 2.6 ?
--
nosy: +gpolo
___
Python tracker
<http://bugs.python.org/issue4
Changes by Guilherme Polo :
--
resolution: -> duplicate
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue4840>
___
___
Python-bugs-
Changes by Guilherme Polo :
--
keywords: +patch
Added file: http://bugs.python.org/file12603/issue4844.diff
___
Python tracker
<http://bugs.python.org/issue4
Guilherme Polo added the comment:
I can't reproduce this on python 2.4.4 (or any newer version) using
windows vista, so this is either specific to the tk included in python
2.4.2 or tk and your specific os version.
If you still have this problem, report it at
http://sourceforge.net/pro
Guilherme Polo added the comment:
The bug mentioned by the OP doesn't occur with the newer installers,
closing.
--
nosy: +gpolo
resolution: -> out of date
status: open -> closed
___
Python tracker
<http://bugs.python.o
Guilherme Polo added the comment:
The problem with the backspace key was fixed in python 2.6 when using
the windows installer at least.
I didn't check yet if it is specific to tcl/tk or if it involves
tkinter.
___
Python tracker
<http://bugs.py
Guilherme Polo added the comment:
I don't know what I was thinking when I said that, the check you are
doing in the patch is fine. And just to answer your next question: it
would raise ValueError.
Also, it would be good to add the other missing search switches.
--
nosy: +
Guilherme Polo added the comment:
Wave_read.initfp also needs fixing on counting the frame number, correct
me if its wrong.
Patch added.
--
keywords: +patch
nosy: +gpolo
Added file: http://bugs.python.org/file12688/issue_4913.diff
___
Python
Guilherme Polo added the comment:
Oops, _framesize already takes sampwidth into account. So there is a
problem somewhere else, since reading the wave file is returning the
number of frames multiplied by the sampwidth.
___
Python tracker
<h
Changes by Guilherme Polo :
Removed file: http://bugs.python.org/file12688/issue_4913.diff
___
Python tracker
<http://bugs.python.org/issue4913>
___
___
Python-bugs-list m
Guilherme Polo added the comment:
Given the name of the function related to the problem: "writeframesraw",
it seems to be more correct to remove the sampwidth multiplication from
the other case (not add it in the other one), since you must already
pass the data multiplied by it.
Does
Guilherme Polo added the comment:
Ah, yes :) But in the other case (the one where it is currently
multiplied) the multiplication happens because data is formatted to
either bytes, shorts or longs, so without the multiplication data length
would end up being divided by 1, 2 or 4.
So, besides
Guilherme Polo added the comment:
Documentation, tests and patch against trunk are needed to get this into
Python, but to me the request is fine.
--
title: wave.py writes 16 bit sample files of half the correct duration ->
wave.py: add writesamples() and readsamples()
versi
Changes by Guilherme Polo :
--
type: -> feature request
versions: +Python 2.7, Python 3.1
___
Python tracker
<http://bugs.python.org/issue1483545>
___
___
Py
Changes by Guilherme Polo :
--
versions: -Python 2.6, Python 3.0
___
Python tracker
<http://bugs.python.org/issue4913>
___
___
Python-bugs-list mailing list
Unsub
Guilherme Polo added the comment:
I could do it, but I'm in disagreement with big part of your patch.
Can you add some kind of test you used for it ? Raw data, sample file,
or something like this.
___
Python tracker
<http://bugs.python.org/i
Guilherme Polo added the comment:
Aren't 8 bit samples stored as unsigned bytes ? If yes, they don't range
between -128 and 127 (first disagreement). So this line: wav = [ s - 128
for s in wav ] and the respective one (that adds +128 in writesamples)
should go.
Why is this check: &q
Guilherme Polo added the comment:
1) wave.py doesn't do assumptions about what the user wants, so I don't
think it is the place to put the DC (0 hz) assumption.
3) writesamples would raise an exception in the case of the current
number of channels set being wrong.
4) Well, lets fi
Guilherme Polo added the comment:
I was going to reply about your "code layout" answer but forgot. Well,
each one has their preferences so I'm not going to question yours.
The only problem is that there is no maintainer for wave.py, so, the
more you follow the rules for Pyt
Guilherme Polo added the comment:
Not going to happen, python 2.5.4 is already out there.
--
resolution: -> wont fix
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Guilherme Polo added the comment:
> "DC (0 hz) assumption"?
> wave.py makes the assumption that what the user wants is whatever
> happens to be in the file, however arbitrary. (That 8 bit samples are
> unsigned bytes is probably an artifact of early ADC logic. Typically yo
Guilherme Polo added the comment:
Why didn't you use assertRaises in place of that try/except for a test ?
I was somewhat following this issue and just saw it being commited, but
the change was being discussed. Aren't you supposed to commit these kind
of changes only after e
New submission from Guilherme Polo :
I would like to add a 'gui' resource in regrtest, this would be nice for
the ttk module that I'm planning to do add very soon (after I solve
another issue about tests).
--
components: Tests
files: regrtest_gui_resource.diff
keywords:
Guilherme Polo added the comment:
Mark,
I'm not a very huge user of tkinter, but I can tell you it would be
tricky to try getting a PyTclObject. It needs to be exposed if you want
to test it without relying on Tcl, but, to me they are just a
"temporary" object that serves
Guilherme Polo added the comment:
Added in python-trunk now: r69050
I will be merging it into py3k now, and my bad for taking so long to do
this.
___
Python tracker
<http://bugs.python.org/issue2
Guilherme Polo added the comment:
r69051 in py3k
Now only samples are missing, I will be doing these later today I think.
And there is an issue regarding regrtest (gui resource), see issue5083.
___
Python tracker
<http://bugs.python.org/issue2
Guilherme Polo added the comment:
Uhm, maybe this 'gui' resource is too special to live in use_resources ?
Maybe a new option in regrtest would be better ?
___
Python tracker
<http://bugs.python.
Guilherme Polo added the comment:
> Do the tests require human interaction? If so, it should definitely be
> another option.
>
No interaction is needed for the current ones.
> Otherwise, I'm don't know if we'll be wreaking havok with the buildbots
> by inclu
Guilherme Polo added the comment:
samples: r69053 and r69055
Closing the issue now, thanks.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Guilherme Polo added the comment:
> Well, if the libraries for Ttk are not included then the tests should
> get skipped when the import fails.
>
Ah yes, good you said that because I wasn't doing it.
> A key reason to leaving something out of 'all' is if it takes a
Guilherme Polo added the comment:
Added in r69063
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue5083>
___
__
Guilherme Polo added the comment:
> Weeble added the comment:
>
> In summary, Tk 8.5 changed the name of the "anchor" mark to be unique to
> each Text widget. The code to make the home key toggle between column 0
> and the start of the text tries to make use of the
Guilherme Polo added the comment:
> Weeble added the comment:
>
> Well, the status quo depends on an unsupported field - "anchor".
Better not repeat the mistake then ?
> As far
> as I can tell, the only other option that allows any customisation of
> cursor beha
Guilherme Polo added the comment:
> Weeble added the comment:
>
> I *think* the primary reason for overriding the home key behaviour was
> not for the interactive shell, but to make it easier to edit code. Most
> programmer's editors that do automatic indentation also let yo
Guilherme Polo added the comment:
> It's
> also the only quick way in IDLE to be sure that the text widget is
> scrolled all the way to the left, since there's no horizontal scrollbar.
> (Any idea why that is? I assumed it's to discourage long lines, but I
&
Guilherme Polo added the comment:
As an side-side-note, I find much more important to add some kind of
test discovery since it is being duplicated in several packages in Lib/
and will continue being duplicated.
--
nosy: +gpolo
___
Python tracker
New submission from Guilherme Polo :
For some reason the recently added test_ttk_guionly is causing Tcl to
abort on Mac. I would prefer to disable the test for now, except if some
mac owner has the time to fix it.
I would like to know the tcl version being used on the noller-osx86
buildslave
Guilherme Polo added the comment:
> For some reason the recently added test_ttk_guionly is causing Tcl to
> abort on Mac. I would prefer to disable the test for now, except if some
> mac owner has the time to fix it.
Just saw it didn't cause an abort with the buildslave heller
New submission from Guilherme Polo :
Recently I've added this test named test_ttk_guionly, and I noticed some
buildslaves went red, like amd64 gentoo trunk and x86 FreeBSD trunk (I
though there were others for the reason I'm going to say next, but
didn't found on a quick look).
Guilherme Polo added the comment:
This is not really related to IDLE, it is how the Text widget behaves
under Linux, you will notice the same with tcl/tk 8.5.
Nevertheless, I would prefer to have the same results under Windows and
Linux.
--
nosy: +gpolo
Guilherme Polo added the comment:
Thanks for verifying, closing as invalid.
--
nosy: +gpolo
resolution: -> invalid
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Guilherme Polo added the comment:
It seems to be good now after a recent modification in how tests are
performed, closing. Sorry for the fuss.
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/iss
Guilherme Polo added the comment:
Do we still want to say _tkinter.c supports tcl/tk from version 8.2 and
newer ? If yes, then we should add a no-op Tcl_ConditionFinalize when
using tcl older than 8.3, because that was when this function got added.
Besides that, the patch looks fine to me too
301 - 400 of 659 matches
Mail list logo