Eli Bendersky added the comment:
I'd like to take a shot at this, if Antoine doesn't mind. I'll prepare a patch
for bytesio.c
Question: what set of benchmarks would it be good to run to make sure this
doesn't degrade the performance of BytesIO in various cases?
Changes by Eli Bendersky :
--
assignee: eli.bendersky ->
___
Python tracker
<http://bugs.python.org/issue15381>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Eli Bendersky :
--
nosy: -eli.bendersky
___
Python tracker
<http://bugs.python.org/issue1470548>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eli Bendersky added the comment:
Even if this is a problem at all, it's certainly not something that must be
fixed by 3.3
--
versions: +Python 3.4 -Python 3.3
___
Python tracker
<http://bugs.python.org/i
Eli Bendersky added the comment:
Yes, code samples would help clarifying the rationale for this request
--
nosy: +eli.bendersky
versions: +Python 3.4 -Python 3.3
___
Python tracker
<http://bugs.python.org/issue15
New submission from Eli Bendersky :
The default ignore list of filecmp.dircmp is ['RCS', 'CVS', 'tags'].
This predates even Subversion! I suggest to freshen up this module to also
ignore the dirs for SVN, Mercurial, Git and Bazaar.
[this is a new f
Eli Bendersky added the comment:
The patch looks reasonable to me. Martin/Éric - any objections to committing?
--
nosy: +eli.bendersky
___
Python tracker
<http://bugs.python.org/issue15
Changes by Eli Bendersky :
--
nosy: -eli.bendersky
___
Python tracker
<http://bugs.python.org/issue15321>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eli Bendersky added the comment:
Sorry about the commit message. Ignore it, I got the issue number wrong :)
--
nosy: +eli.bendersky
___
Python tracker
<http://bugs.python.org/issue15
Eli Bendersky added the comment:
Committed in f315cfa22630
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Eli Bendersky added the comment:
Makes sense. I agree that publicly exposing the left/right attributes makes
sense. But let's do it properly:
1. Add an example to the documentation
2. Add some tests to Lib/test/test_filecmp.py that verify these attributes
behave as expected
In additi
Eli Bendersky added the comment:
I think it can go into 3.3 but only if it gets reviewed by another core dev
(we're in release candidate stage now). Senthil - can you review the patch
together with me?
As for customizing the stream, yes, go ahead and open a new issue for it, and
a
Eli Bendersky added the comment:
Éric - what is missing?
--
___
Python tracker
<http://bugs.python.org/issue15231>
___
___
Python-bugs-list mailing list
Unsub
Eli Bendersky added the comment:
Feel free to change it, I don't mind. I think the intention is clear anyway.
--
___
Python tracker
<http://bugs.python.org/is
Eli Bendersky added the comment:
I've committed a rephrase [the Misc/NEWS entry is IMHO unnecessary for tiny
documentation clarifications].
Since there's no distutils2/packaging in 3.3 at the moment, I think we're done.
Éric - would you like to keep this issue alive to rememb
Eli Bendersky added the comment:
Yes, if the new phrasing looks OK I will backport to 3.2 & 2.7
--
___
Python tracker
<http://bugs.python.org/issue15231>
___
Eli Bendersky added the comment:
I'm looking at the docs. Started with the HOWTO (Doc/howto/ipaddress.rst)
This example:
>>> net4 = ipaddress.ip_network('192.0.2.0/24')
>>> for x in net4.iterhosts():
print(x)
Seems to be wrong:
...
Traceback (most rec
Eli Bendersky added the comment:
P.S. I intend to prepare patch(es) eventually, but I will document the problems
I find here, in case anyone is interested to discuss.
--
___
Python tracker
<http://bugs.python.org/issue14
Eli Bendersky added the comment:
Ah, probably hosts() replaced iterhosts()
--
___
Python tracker
<http://bugs.python.org/issue14814>
___
___
Python-bugs-list m
Eli Bendersky added the comment:
Attaching a patch for the howto
--
Added file: http://bugs.python.org/file26612/ipaddr_howto.1.patch
___
Python tracker
<http://bugs.python.org/issue14
Eli Bendersky added the comment:
FWIW I would prefer this HOWTO to be part of the document itself. Splitting a
document to two parts and keeping them separated is problematic exactly for the
same reasons as external documentation in general - it can be forgotten when
things get updated
Eli Bendersky added the comment:
The docs don't mention that addresses can also be packed in bytes
--
___
Python tracker
<http://bugs.python.org/is
Eli Bendersky added the comment:
I disagree about the HOWTO vs. doc thing, but I don't see it as a major issue
so I won't dwell on it.
I'm now in the process of throwing together a patch for the reference doc -
also bundling the address objects together, the network object
Eli Bendersky added the comment:
Alright, attaching an attempt at improving the reference docs. This only
handles the address objects for now:
1. Grouping address objects together, network objects together, interface
objects together
2. Explain that everything IPv4Address exposes is also
Eli Bendersky added the comment:
Thanks Nick. I've addressed your review comments and will be pushing the doc
update.
--
___
Python tracker
<http://bugs.python.org/is
Eli Bendersky added the comment:
By the way, Nick, was not this module intended to be introduced as provisional
in 3.3? At least PEP 411 lists it as one of the candidates.
--
___
Python tracker
<http://bugs.python.org/issue14
Eli Bendersky added the comment:
Attaching part 1 of the patch for documenting the network objects. Contains
general introduction, detailed documentation of constructors and all attributes.
Left to document: methods, operations (like iterating, "in", comparison
operators)
--
Eli Bendersky added the comment:
Attaching an updated patch that completes the documentation of network objects
(attributes, methods and operations). Additionally, inserted the "provisional
package" note and a "new in 3.3" notice.
--
Added file: http://bugs.
Eli Bendersky added the comment:
Backported in 014b36383a54 and 29bdbcadf299
--
___
Python tracker
<http://bugs.python.org/issue15231>
___
___
Python-bugs-list m
Eli Bendersky added the comment:
Nick, your commit incorporates my latest patch (ipaddr_refdoc_network.2.patch),
right?
--
___
Python tracker
<http://bugs.python.org/issue14
Changes by Eli Bendersky :
--
nosy: +eli.bendersky
___
Python tracker
<http://bugs.python.org/issue15572>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eli Bendersky added the comment:
Please note that the documentation of ET has been significantly improved in
3.3, with added examples, etc. You can start by backporting whatever is
relevant to earlier versions (2.7/3.2) - do not add new documentation contents
to 2.7/3.2 before the changes
Changes by Eli Bendersky :
--
versions: +Python 2.7, Python 3.3, Python 3.4
___
Python tracker
<http://bugs.python.org/issue15586>
___
___
Python-bugs-list mailin
Eli Bendersky added the comment:
I provided some comments on your patch in the code-review tool. Thanks for the
contribution, Daniel. It's fine to first apply these changes to 3.3 and then
backport to 2.7 (I don't think 3.2 is necessary because most users use the
online d
Changes by Eli Bendersky :
--
versions: +Python 2.7
___
Python tracker
<http://bugs.python.org/issue15586>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eli Bendersky added the comment:
Sarbjit, if you look at the docs of 3.3, I think most of what you're asking for
is there (especially once you count Daniel's commit). What else is missing in
your opinion?
--
___
Python trac
Eli Bendersky added the comment:
My job is done here. Éric - assigning to you for distutils2, once it becomes
relevant.
--
assignee: docs@python -> eric.araujo
___
Python tracker
<http://bugs.python.org/issu
Changes by Eli Bendersky :
--
nosy: -eli.bendersky
___
Python tracker
<http://bugs.python.org/issue15231>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eli Bendersky added the comment:
Sarbjit: first of all, look at the up-to-date documentation for 3.3 (it's
available online at http://docs.python.org/dev/
Then, on a checkout of the 3.3 code (default branch) you can apply Daniel's
patch (it's in the "Files" section i
Eli Bendersky added the comment:
Here's a patch adding documentation to the *Interface classes.
I must say I'm not very psyched about the with_* methods. Their outputs are
inconsistent, unlike in *Network, where all return strings.
--
Changes by Eli Bendersky :
Added file: http://bugs.python.org/file26736/ipaddr_refdoc_interface.1.patch
___
Python tracker
<http://bugs.python.org/issue14814>
___
___
Eli Bendersky added the comment:
pmoody - you mean IPv?Interface, right? The network classes consistently return
strings in with_* methods
--
___
Python tracker
<http://bugs.python.org/issue14
Eli Bendersky added the comment:
Attaching a new patch that fixes the with_* methods to be more consistent, and
the relevant tests too. The doc is now consistent as well.
For some reason IPv6Interface.with_netmask also returned the prefixlen
representation. The test justified it by quoting
Eli Bendersky added the comment:
I agree with Georg. As far as I understand the word "arbitrary" - it describes
the situation exactly.
--
nosy: +eli.bendersky
___
Python tracker
<http://bugs.python.o
Eli Bendersky added the comment:
I committed your patch to default (3.3) with some minor fixes. Please go over
them as you will need to apply them to the 2.7 patch. I've reviewed the 2.7
patch as well - it's an initial review. Did you execute all the code sampl
Eli Bendersky added the comment:
Daniel, this looks good except that the section numbering is different from 3.3
where the object/function reference sections were nested under "Reference".
Could you fix your patch to align the 2.7 doc to this structure?
P.S. Éric's comment
Changes by Eli Bendersky :
--
nosy: +eli.bendersky
___
Python tracker
<http://bugs.python.org/issue15656>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eli Bendersky added the comment:
Fixed, thanks for the report.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Eli Bendersky added the comment:
I think implementing this is very important, and +1 to Georg's suggestion,
because no one is suddenly going to convert KLOCs of code samples to be
testable (many code samples are partial, and will need to be completed in one
way or another to be act
Eli Bendersky added the comment:
I'm just waiting for a review. If Nick has no time for that, perhaps I can
commit anyway since this is just adding documentation.
--
___
Python tracker
<http://bugs.python.org/is
Eli Bendersky added the comment:
Thanks for the patch, David.
Alas, due to personal reasons I will not be able to work on core Python in the
next 2-3 months. I may throw in a review here and there, but that's not a
promise ;-)
--
___
P
Eli Bendersky added the comment:
I'm currently somewhat "offline" for a while (cross-continental move), but I'll
do my best to try to recreate my setup to test this problem and the proposed
solution.
--
___
Python tracker
<
Eli Bendersky added the comment:
Thank you, Antoine, for looking into this. I wish I could participate in a
meaningful way, but alas it will be days or weeks before I can recreate a
suitable setup to get back hacking on Python.
--
___
Python
Eli Bendersky added the comment:
Antoine, Thanks!
You said :
> the coding style there is quite old
It would be great if you could elaborate, however briefly, if there's anything
else besides your fixes that is old and should be modernized. I will admit to
writing some of that c
Eli Bendersky added the comment:
Ah, OK. I was actually putting off refactorings in that code to after
refactoring the test suite. The latter is in progress, it was paused by my
vacation but I do plan to resume it eventually. Once the test suite is
sufficiently humane (esp. moves off doctest
Eli Bendersky added the comment:
Will look into it, thanks for the report.
--
___
Python tracker
<http://bugs.python.org/issue16076>
___
___
Python-bugs-list m
Eli Bendersky added the comment:
Thanks for the report, Patrick. Yes, documenting this limitation would make
sense. Have you tested to see how it behaves?
Anyhow, a patch would be welcome ;-)
--
stage: -> needs patch
___
Python tracker
&l
Eli Bendersky added the comment:
Thanks for the report. I'll take a look.
Patches always welcome :)
--
stage: -> patch review
title: xml.etree.ElementTree.tostringlist does conform to it's documentation ->
xml.etree.ElementTree.tostringlist does not conform to i
Eli Bendersky added the comment:
Thanks, Chris. I'll take a look
--
___
Python tracker
<http://bugs.python.org/issue15888>
___
___
Python-bugs-list m
Eli Bendersky added the comment:
Pushed to 3.3 and 3.4
Thanks for the report and patch
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Eli Bendersky added the comment:
Changes pushed. Thanks for the report and patches.
Mike - a note for the future: when you create an updated patch, create it anew
vs. a clean repo. Don't "compound" patches.
--
resolution: -> fixed
stage: needs patch -> committed/
Eli Bendersky added the comment:
Einar, TypeError is raised because tostring/tostringlist return bytes with the
default encoding, and you can't join bytes on "" (which is unicode).
--
___
Python tracker
<http://bugs.pyt
Eli Bendersky added the comment:
Closing, since this isn't a bug and append's behavior is properly documented.
Regarding the error message, yes it could probably be better but you would need
to enable input validation for that. Since Python is duck typed, often when
argumen
Changes by Eli Bendersky :
--
title: Optimize BytesIO to so less reallocations when written, similarly to
StringIO -> Optimize BytesIO to do less reallocations when written, similarly
to StringIO
___
Python tracker
<http://bugs.pyth
Changes by Eli Bendersky :
Removed file: http://bugs.python.org/file22406/unnamed
___
Python tracker
<http://bugs.python.org/issue12321>
___
___
Python-bugs-list mailin
Changes by Eli Bendersky :
--
versions: +Python 3.4
___
Python tracker
<http://bugs.python.org/issue12321>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eli Bendersky added the comment:
I think this may be intentional. Absolute searches on a ElementTree are
discouraged with a warning:
def find(self, path, namespaces=None):
# assert self._root is not None
if path[:1] == "/":
path =
Eli Bendersky added the comment:
moijes12, why are the added names "raw" ?
--
___
Python tracker
<http://bugs.python.org/issue15442>
___
___
Python-b
Eli Bendersky added the comment:
I tend to agree with Éric here.
moijes12, would you like to send an updated patch without the raw literals, and
with added tests for the new/changed functionality?
--
___
Python tracker
<http://bugs.python.
Changes by Eli Bendersky :
--
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Eli Bendersky added the comment:
Finally found time to look at this, sorry for the delay.
I agree with Amaury, and don't think any change is necessary in 2.7, the
behavior there is quite consistent with what was usually done in 2.x. For
porting or keeping the code 2/3 compatible, Ama
Eli Bendersky added the comment:
Moving to 3.4
In 3.3 we won't add functionality to filecmp, but in 3.4 we will, so the new
tests should go there.
--
nosy: +eli.bendersky
versions: +Python 3.4 -Python 3.3
___
Python tracker
<http://bugs.py
Eli Bendersky added the comment:
Chris Calloway, let's move this forward. I want to see more tests for filecmp
ASAP.
Please address Chris Jerdonek's points in a new patch made vs. fresh default
branch (3.4), at this point "cd"ing (before the test_cwd thing is done
Changes by Eli Bendersky :
--
nosy: +eli.bendersky
___
Python tracker
<http://bugs.python.org/issue15351>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eli Bendersky added the comment:
Revised patch LGTM.
--
___
Python tracker
<http://bugs.python.org/issue14332>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eli Bendersky added the comment:
There were no serious objections bar the pre-release timing. Now that we're
safely in 3.5 territory, can I go ahead and create a patch?
Note that for purposes of review, the Github project linked in the original
message is more convenient,
Eli Bendersky added the comment:
Attaching patch that implements this. To make it easier, the patch only
replaces the ASDL parser - not touching anything else and leaving the output
intact.
With this patch applied, when the Makefile is rerun it regenerates the actual
AST code in:
Include
Eli Bendersky added the comment:
The patch appears to contain code (tests) along with the documentation. Is this
intended? This issue is not tagged properly if it is.
I'd suggest to split them to separate patches.
--
versions: +Python 3.5 -Python 2.7, Python 3.3, Pytho
Eli Bendersky added the comment:
Raymond, you are right that the APIs presented by Element and ElementTree are
somewhat different. As Stefan mentioned, they were really meant to represent
different things, but with time some "convenience" features crept in and made
the differenc
Eli Bendersky added the comment:
I left some comments in Rietveld.
There shouldn't be a problem getting these into 3.4 too - doc changes are
usually excempt from most restrictions.
--
___
Python tracker
<http://bugs.python.org/is
Eli Bendersky added the comment:
> Do you have concrete suggestions? Make the tree iterable?
> > Add all element methods to the tree, implicitly forwarding to the root?
>
> Yes, that is the feature request. Add all the element methods to the
> elementtree object.
>
>
Eli Bendersky added the comment:
Thanks. Doc patch committed with some slight rewording.
Would you like to prepare a separate patch for the tests, default branch only
this time?
--
versions: -Python 3.4
___
Python tracker
<http://bugs.python.
Eli Bendersky added the comment:
Since there has mostly been support for this, I'll wait a couple more days and
commit it unless someones objects or asks for more time for review.
--
___
Python tracker
<http://bugs.python.org/is
Eli Bendersky added the comment:
On Thu, Apr 3, 2014 at 1:19 PM, Nikolaus Rath wrote:
>
> Nikolaus Rath added the comment:
>
> Thanks for the commit!
>
> My intention is to fix the behavior itself for 3.5 (see issue 9521), so I
> think adding testcases for the old behavior
Eli Bendersky added the comment:
On Fri, Apr 4, 2014 at 6:10 AM, Serhiy Storchaka wrote:
>
> Serhiy Storchaka added the comment:
>
> Now make fails when system Python is older than 3.4.
>
>
This is why the .h & .c files are checked in - someone just building Python
doesn&#
Eli Bendersky added the comment:
Nick, it shouldn't be hard to drop to 3.3, but I'm curious why would the 3.4
requirement break Fedora, or anything for that matter? Does Fedora regenerate
the C implementation of the AST for some reason on every build? AFAIU, building
Python from s
Eli Bendersky added the comment:
Updated patch attached:
1. Python 3.3+ supported (I suspect 3.2 will work too)
2. Incorporated Serhiy's suggestions (thanks for the review!)
--
Added file: http://bugs.python.org/file34742/new-asdl-parser.issue19655.2.
Eli Bendersky added the comment:
> Note that this has been fixed in Py3 already (Py3.3, I guess). The only
> question is whether the behaviour will be changed in Py2.7.
>
I don't think this issue is acute enough to warrant fixes in 2.7; however,
a documentation patch wo
Changes by Eli Bendersky :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Eli Bendersky added the comment:
Stefan, you need to run `make touch` if you want to avoid rebuilding. See
#15964 for more details.
[all bots run `make touch` before building now]
--
___
Python tracker
<http://bugs.python.org/issue19
Eli Bendersky added the comment:
This is also described in the Dev Guide:
https://docs.python.org/devguide/setup.html
--
___
Python tracker
<http://bugs.python.org/issue19
Eli Bendersky added the comment:
Skip, PTAL at the devguide.
https://docs.python.org/devguide/setup.html#avoiding-re-creating-auto-generated-files
--
___
Python tracker
<http://bugs.python.org/issue21
Eli Bendersky added the comment:
Is it really worthwhile to complicate the API for the sake of providing a less
flexible solution for rare cases that saves a few keystrokes?
--
___
Python tracker
<http://bugs.python.org/issue21
Eli Bendersky added the comment:
Thanks for working on it, Daniel. Unfortunately I won't have time to look at it
in the near future, but I will definitely look at the patch once I get some
free time to hack on Python again.
--
___
Python tr
Eli Bendersky added the comment:
I have no plans adding this feature to etree.
--
___
Python tracker
<http://bugs.python.org/issue16798>
___
___
Python-bugs-list m
Changes by Eli Bendersky :
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue16219>
___
___
Python-bugs-list mailing list
Unsubscri
Eli Bendersky added the comment:
Daniel, is your patch made vs. the 3.3 branch? I'll need to apply there first,
and then merge up to default (3.4).
[Also, removing the 3.2 tag here. 3.2 won't be fixed to make _elementtree
pickleable - it never was].
--
versions: -
Eli Bendersky added the comment:
Also, could you explain what makes test___all__ start failing with this patch?
What are you adding that makes that happen?
P.S. I suspect the root reason is the bad way etree tests are structured in
general. See issue 15083
Eli Bendersky added the comment:
Thanks for the patch. I'll take a look.
--
assignee: -> eli.bendersky
___
Python tracker
<http://bugs.python.org
Eli Bendersky added the comment:
I think I understand what's going on there. Pickle, to make sure an object can
be picked, looks at the module it comes from and tries to import its class, to
make sure they're the same.
What happens since 3.3 is that for the Python Element class,
801 - 900 of 1229 matches
Mail list logo
