Eli Bendersky added the comment: Chris Calloway, let's move this forward. I want to see more tests for filecmp ASAP.
Please address Chris Jerdonek's points in a new patch made vs. fresh default branch (3.4), at this point "cd"ing (before the test_cwd thing is done). For testing code, practicality beats purity. Having these tests in place will help moving other issues forward (i.e. #15454). Also, as Chris Jerdonek has mentioned, having as little as possible in each test_ method is a good practice, and older test code that doesn't follow it can be fixed later (patches welcome). ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue15518> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
