[issue44517] test__xxsubinterpreters: AMD64 Fedora Stable 3.x buildbot aborts at test_still_running

2021-07-10 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- status: open -> pending ___ Python tracker <https://bugs.python.org/issue44517> ___ ___ Python-bugs-list mailing list Un

[issue44517] test__xxsubinterpreters: AMD64 Fedora Stable 3.x buildbot aborts at test_still_running

2021-07-14 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: The AMD64 Fedora Stable 3.x buildbot has not been red for one week. Closing this now. Victor/Pablo, please reopen if you disagree. -- resolution: -> not a bug stage: -> resolved status: pending -&g

[issue44639] [sqlite3] Confusing typo "transation"

2021-07-14 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Thanks John, for the report, and Jack, for the fix! -- nosy: +erlendaasland resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue42064] Convert sqlite3 to multi-phase initialisation (PEP 489)

2021-07-14 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +25692 pull_request: https://github.com/python/cpython/pull/27155 ___ Python tracker <https://bugs.python.org/issue42

[issue42064] Convert sqlite3 to multi-phase initialisation (PEP 489)

2021-07-14 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +25693 pull_request: https://github.com/python/cpython/pull/27156 ___ Python tracker <https://bugs.python.org/issue42

[issue44641] [sqlite3] Use vectorcall in pysqlite_collation_callback

2021-07-14 Thread Erlend E. Aasland
New submission from Erlend E. Aasland : pysqlite_collation_callback() currently uses the variable argument function PyObject_CallFunctionObjArgs(). Suggesting micro-optimise this by using PyObject_Vectorcall instead. -- components: Extension Modules messages: 397521 nosy

[issue44641] [sqlite3] Use vectorcall in pysqlite_collation_callback

2021-07-14 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- keywords: +patch pull_requests: +25695 stage: -> patch review pull_request: https://github.com/python/cpython/pull/27158 ___ Python tracker <https://bugs.python.org/issu

[issue44641] [sqlite3] Use vectorcall in pysqlite_collation_callback

2021-07-15 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue34828] sqlite.iterdump does not work for (most) databases with autoincrement

2021-07-15 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- nosy: +erlendaasland ___ Python tracker <https://bugs.python.org/issue34828> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue44688] [sqlite3] Remove ASCII limitation from sqlite3.Connection.create_collation()

2021-07-20 Thread Erlend E. Aasland
New submission from Erlend E. Aasland : The sqlite3.Connection.create_collation() function limits collation names to ASCII characters only. As sqlite3_create_collation_v2() (and sqlite3_create_collation()) support UTF8, there is no need for this limitation anymore. See https://github.com

[issue42064] Convert sqlite3 to multi-phase initialisation (PEP 489)

2021-07-20 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +25818 pull_request: https://github.com/python/cpython/pull/27273 ___ Python tracker <https://bugs.python.org/issue42

[issue44688] [sqlite3] Remove ASCII limitation from sqlite3.Connection.create_collation()

2021-07-27 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- keywords: +patch pull_requests: +25928 stage: -> patch review pull_request: https://github.com/python/cpython/pull/27395 ___ Python tracker <https://bugs.python.org/issu

[issue3783] dbm.sqlite proof of concept

2021-07-28 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- nosy: +erlendaasland ___ Python tracker <https://bugs.python.org/issue3783> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue31746] crashes in sqlite3.Connection in case it is uninitialized or partially initialized

2021-07-28 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- nosy: +erlendaasland nosy_count: 1.0 -> 2.0 pull_requests: +25960 pull_request: https://github.com/python/cpython/pull/27431 ___ Python tracker <https://bugs.python.org/issu

[issue44688] [sqlite3] Remove ASCII limitation from sqlite3.Connection.create_collation()

2021-07-29 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue42064] Convert sqlite3 to multi-phase initialisation (PEP 489)

2021-07-29 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +25982 pull_request: https://github.com/python/cpython/pull/27456 ___ Python tracker <https://bugs.python.org/issue42

[issue31746] crashes in sqlite3.Connection in case it is uninitialized or partially initialized

2021-07-29 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +25987 pull_request: https://github.com/python/cpython/pull/27464 ___ Python tracker <https://bugs.python.org/issue31

[issue31746] crashes in sqlite3.Connection in case it is uninitialized or partially initialized

2021-07-29 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +25988 pull_request: https://github.com/python/cpython/pull/27465 ___ Python tracker <https://bugs.python.org/issue31

[issue31746] crashes in sqlite3.Connection in case it is uninitialized or partially initialized

2021-07-29 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +25991 pull_request: https://github.com/python/cpython/pull/27472 ___ Python tracker <https://bugs.python.org/issue31

[issue31746] crashes in sqlite3.Connection in case it is uninitialized or partially initialized

2021-07-30 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- assignee: -> erlendaasland status: open -> pending versions: +Python 3.10, Python 3.11, Python 3.9 -Python 3.7 ___ Python tracker <https://bugs.python.org/i

[issue31746] crashes in sqlite3.Connection in case it is uninitialized or partially initialized

2021-07-30 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue42698] Deadlock in pysqlite_connection_dealloc()

2021-07-30 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: hydroflask, can you provide a reproducer? -- nosy: +erlendaasland versions: +Python 3.11 -Python 3.6, Python 3.7, Python 3.8 ___ Python tracker <https://bugs.python.org/issue42

[issue42698] Deadlock in pysqlite_connection_dealloc()

2021-08-02 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Thanks! I had to comment out the reg_func() call (it is not defined in test.py, and I don't know what it's supposed to do), and change "with lock.shared_context():" to "with lock:", but I'm unable get a deadlock. I&#x

[issue42698] Deadlock in pysqlite_connection_dealloc()

2021-08-02 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: > In production the error was happening after 30 minutes of so. Great, thanks. > The major problem is that I don't exactly know how to provoke SQLite to > acquire an internal lock. IIRC, you can provoke the internal SQLite lock s

[issue44822] [sqlite3] Micro-optimisation: pass string size to sqlite3_result_text()

2021-08-04 Thread Erlend E. Aasland
New submission from Erlend E. Aasland : The third argument to sqlite3_result_text() is the length of the string passed as the second argument. Currently, we pass -1, so SQLite has to invoke strlen() to compute the length of the passed string. Suggesting to use PyUnicode_AsUTF8AndSize() iso

[issue44822] [sqlite3] Micro-optimisation: pass string size to sqlite3_result_text()

2021-08-04 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- keywords: +patch pull_requests: +26090 stage: -> patch review pull_request: https://github.com/python/cpython/pull/27588 ___ Python tracker <https://bugs.python.org/issu

[issue44822] [sqlite3] Micro-optimisation: pass string size to sqlite3_result_text()

2021-08-04 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: > Could you please add a test for string containing embedded NUL? Of course, thanks for the heads up. > I think that we should raise explicit error if sz > INT_MAX. Yes, I thought about this. I do agree that raising OverflowError would be bette

[issue44822] [sqlite3] Micro-optimisation: pass string size to sqlite3_result_text()

2021-08-04 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Serhiy, I've updated the PR, if you want to take a look. Thanks for your feedback. -- ___ Python tracker <https://bugs.python.org/is

[issue44818] '\t' (tab) support

2021-08-04 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: I'm guessing this has to do with mixing spaces and tabs when indenting code. This can be fixed in your text editor. -- nosy: +erlendaasland status: open -> pending ___ Python tracker <https://bugs

[issue44818] '\t' (tab) support

2021-08-05 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue44818] '\t' (tab) support

2021-08-05 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: > I guess Python can't support tab AFAIK, it was a deliberate decision during the Python 2 => Python 3 transition. > [...] it sounds Gnu nano mix spaces and tabs! You can set up GNU nano to expand tabs: $ echo "set tabstos

[issue20587] sqlite3 converter not being called

2021-08-05 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Closing as out-of-date. If anyone disagrees, please reopen :) -- resolution: -> out of date stage: -> resolved status: pending -> closed ___ Python tracker <https://bugs.python.or

[issue21465] sqlite3 Row can return duplicate keys when using adapters

2021-08-05 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Closing this for now. If anyone disagrees, please reopen :) -- resolution: -> not a bug stage: -> resolved status: pending -> closed ___ Python tracker <https://bugs.python.or

[issue38411] SQLITE_MISUSE race condition in sqlite3 is misleadingly raised as a binding error

2021-08-06 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- nosy: +erlendaasland ___ Python tracker <https://bugs.python.org/issue38411> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue44848] Upgrade macOS and Windows installers to use SQLite 3.36.0

2021-08-06 Thread Erlend E. Aasland
New submission from Erlend E. Aasland : Upgrade macOS and Windows installers to use SQLite 3.36.0. SQLite 3.36.0 was released June 18 2021. https://www.sqlite.org/releaselog/3_36_0.html -- components: Windows, macOS messages: 399061 nosy: erlendaasland, ned.deily, paul.moore

[issue44848] Upgrade macOS and Windows installers to use SQLite 3.36.0

2021-08-06 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- keywords: +patch pull_requests: +26115 stage: -> patch review pull_request: https://github.com/python/cpython/pull/27621 ___ Python tracker <https://bugs.python.org/issu

[issue44848] Upgrade macOS and Windows installers to use SQLite 3.36.0

2021-08-06 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +26116 pull_request: https://github.com/python/cpython/pull/27622 ___ Python tracker <https://bugs.python.org/issue44

[issue38411] SQLITE_MISUSE race condition in sqlite3 is misleadingly raised as a binding error

2021-08-06 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: I've been trying to provoke this on my Mac (macOS 11.4) with Python 3.8 though 3.11 (dev) without success. Are you still able to reproduce this, Jack? If you can attach the output of python3.10 -m test.pythoninfo, I could try to set up a si

[issue43853] [sqlite3] Improve sqlite3_value_text() error handling

2021-08-06 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +26121 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/27627 ___ Python tracker <https://bugs.python.org/issu

[issue43853] [sqlite3] Improve sqlite3_value_text() error handling

2021-08-06 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: I'll add extra tests in a separate PR, so we can easily backport it to 3.10 and 3.9. -- ___ Python tracker <https://bugs.python.org/is

[issue43853] [sqlite3] Improve sqlite3_value_text() error handling

2021-08-06 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue43853> ___ ___ Pyth

[issue43853] [sqlite3] Improve sqlite3_value_text() error handling

2021-08-06 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- resolution: fixed -> status: closed -> open ___ Python tracker <https://bugs.python.org/issue43853> ___ ___ Python-bugs-

[issue44822] [sqlite3] Do not truncate results of user functions and aggregates on the first NUL

2021-08-06 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +26133 pull_request: https://github.com/python/cpython/pull/27639 ___ Python tracker <https://bugs.python.org/issue44

[issue43853] [sqlite3] Improve sqlite3_value_text() error handling

2021-08-06 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Serhiy, what's the preferred way to append to existing NEWS entries: should I update the existing NEWS entries tied to this issue, or add new entries (with the same bpo number)? -- ___ Python tracker &

[issue43853] [sqlite3] Improve sqlite3_value_text() error handling

2021-08-06 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +26136 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/27642 ___ Python tracker <https://bugs.python.org/issu

[issue44855] [DOC] some sqlite3 exceptions are not documented

2021-08-06 Thread Erlend E. Aasland
New submission from Erlend E. Aasland : sqlite3.InterfaceError, sqlite3.DataError, and sqlite3.InternalError are not documented. -- assignee: docs@python components: Documentation messages: 399139 nosy: docs@python, erlendaasland priority: normal severity: normal status: open title

[issue44855] [DOC] some sqlite3 exceptions are not documented

2021-08-06 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- keywords: +patch pull_requests: +26139 stage: -> patch review pull_request: https://github.com/python/cpython/pull/27645 ___ Python tracker <https://bugs.python.org/issu

[issue44855] [doc] some sqlite3 exceptions are not documented

2021-08-06 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- title: [DOC] some sqlite3 exceptions are not documented -> [doc] some sqlite3 exceptions are not documented ___ Python tracker <https://bugs.python.org/issu

[issue44855] [doc] some sqlite3 exceptions are not documented

2021-08-06 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Also, the documentation of sqlite3.Warning could be improved. Currently, it reads "A subclass of Exception". Suggesting to simply sync the descriptions of the exceptions with PEP 249. -- ___ Pyth

[issue44855] [doc] Complete the sqlite3 exception documentation

2021-08-06 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- title: [doc] some sqlite3 exceptions are not documented -> [doc] Complete the sqlite3 exception documentation ___ Python tracker <https://bugs.python.org/issu

[issue41576] document BaseException in favour of bare except in error tutorial

2021-08-06 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- nosy: -erlendaasland ___ Python tracker <https://bugs.python.org/issue41576> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue44822] [sqlite3] Do not truncate results of user functions and aggregates on the first NUL

2021-08-06 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Thanks, Serhiy! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue16379] SQLite error code not exposed to python

2021-08-06 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: > What would it take to get this merged? I've rebased Aviv's PR (GH-1108) onto main and resolved the conflicts. If I get his blessing, I'll open a PR try to land this. -- ___ Pyth

[issue44859] Improve some sqlite3 errors

2021-08-08 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: * sqlite3.ProgrammingError is raised for SQLITE_MISUSE. IMO, sqlite3.InterfaceError, is more appropriate. * In case of too large integer values, OverflowError is raised on bind, but sqlite3.DataError is raised on UDF return. Using sqlite3.DataError in

[issue44859] Improve some sqlite3 errors

2021-08-09 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Also, for SQLite 3.7.17 and above, we should raise sqlite3.Warning for error codes SQLITE_NOTICE and SQLITE_WARNING. -- ___ Python tracker <https://bugs.python.org/issue44

[issue44859] Improve some sqlite3 errors

2021-08-09 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +26181 pull_request: https://github.com/python/cpython/pull/27695 ___ Python tracker <https://bugs.python.org/issue44

[issue30952] [Windows] include Math extension in SQlite

2021-08-11 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: This was fixed in bpo-42686. Closing as duplicate. -- nosy: +erlendaasland resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> include built-in Math functions in SQLite to 3.35.0 of

[issue35398] SQLite incorrect row count for UPDATE

2021-08-11 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: See also bpo-36859. -- nosy: +erlendaasland ___ Python tracker <https://bugs.python.org/issue35398> ___ ___ Python-bug

[issue36859] sqlite3 dml statement detection does not account for CTEs

2021-08-11 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: See also bpo-35398 -- ___ Python tracker <https://bugs.python.org/issue36859> ___ ___ Python-bugs-list mailing list Unsub

[issue44859] Improve some sqlite3 errors

2021-08-12 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: > Also, for SQLite 3.7.17 and above, we should raise sqlite3.Warning for error > codes SQLITE_NOTICE and SQLITE_WARNING. Er, forget that. Neither are returned by any SQLite C interface, at the moment. They can (currently) only be used as the

[issue41930] Wrap sqlite3_serialize API in sqlite3 module

2021-08-12 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: I've been fiddling with this between others projects lately; the PR is mostly ready. The only remaining issue is how to include this in the Connection object: - The serialize API was added as a compile-time option (SQLITE_ENABLE_DESERIALIZE) in S

[issue44079] [sqlite3] remove superfluous statement weak ref list from connection object

2021-08-13 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Berker: > My understanding is that their usages is a bit different: > one is for performance reasons (and it can configurable by users) and the > other is to keep track of statements inside a connection. > > I'm not fully sure that th

[issue44927] [sqlite3] insert

2021-08-16 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- nosy: +erlendaasland ___ Python tracker <https://bugs.python.org/issue44927> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue16379] SQLite error code not exposed to python

2021-08-16 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: >> What would it take to get this merged? > > I've rebased Aviv's PR (GH-1108) onto main and resolved the conflicts. > If I get his blessing, I'll open a PR try to land this. I asked Aviv on GH eight days ago, and I have

[issue16379] SQLite error code not exposed to python

2021-08-16 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +26255 pull_request: https://github.com/python/cpython/pull/27786 ___ Python tracker <https://bugs.python.org/issue16

[issue44927] [sqlite3] insert

2021-08-16 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: The INSERT statement comes in many varieties. What about INSERT OR [ABORT,FAIL,IGNORE,REPLACE,ROLLBACK], INSERT WITH RECURSIVE, INSERT INTO table SELECT, etc.? Why only add such an API for insert; why not replace() as well? I'm not convinced this

[issue44927] [sqlite3] proposal: add sqlite3.Cursor.insert() method

2021-08-16 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- title: [sqlite3] insert -> [sqlite3] proposal: add sqlite3.Cursor.insert() method ___ Python tracker <https://bugs.python.org/issu

[issue44079] [sqlite3] remove superfluous statement weak ref list from connection object

2021-08-19 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Thanks Pablo for merging, and Berker for pushing me to investigate further. Highly appreciated! -- ___ Python tracker <https://bugs.python.org/issue44

[issue44958] [sqlite3] only reset statements when needed

2021-08-19 Thread Erlend E. Aasland
New submission from Erlend E. Aasland : Ref. Serhiy's msg387858 in bpo-43350: "Maybe the code could be rewritten in more explicit way and call pysqlite_statement_reset() only when it is necessary [...]" Currently, we try to reset statements in all "statement exit"

[issue44958] [sqlite3] only reset statements when needed

2021-08-19 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- keywords: +patch pull_requests: +26307 stage: -> patch review pull_request: https://github.com/python/cpython/pull/27844 ___ Python tracker <https://bugs.python.org/issu

[issue44073] [sqlite3] drop statement in_use field in favour of sqlite3_stmt_busy()

2021-08-19 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: See also bpo-44958 -- ___ Python tracker <https://bugs.python.org/issue44073> ___ ___ Python-bugs-list mailing list Unsub

[issue43350] [sqlite3] Active statements are reset twice in _pysqlite_query_execute()

2021-08-19 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: msg387858 (Serhiy): > Maybe the code could be rewritten in more explicit way and call > pysqlite_statement_reset() only when it is necessary [...] I've opened bpo-44958 for such an enhancement. Closing this issue. -- resolution: -

[issue44958] [sqlite3] only reset statements when needed

2021-08-20 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Ref. Serhiy's msg387858 in bpo-43350: "Maybe the code could be rewritten in more explicit way and call pysqlite_statement_reset() only when it is necessary [...]" Currently, we try to reset statements in all "statement exit"

[issue44958] [sqlite3] only reset statements when needed

2021-08-20 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- Removed message: https://bugs.python.org/msg399931 ___ Python tracker <https://bugs.python.org/issue44958> ___ ___ Python-bug

[issue44958] [sqlite3] only reset statements when needed

2021-08-20 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: I did a quick count of sqlite3_reset()s in the sqlite3 test suite: - main: 2976 calls - PR 27844: 1730 calls Since we never call sqlite3_reset() with a NULL pointer, all sqlite3_reset() calls we execute hold the SQLite db mutex; reducing the number of

[issue44965] [sqlite3] early exit for non-DML statements in executemany()

2021-08-20 Thread Erlend E. Aasland
New submission from Erlend E. Aasland : Currently, if a non-DML statement is executed with executemany(), we only bail as late as possible: just before the call to _pysqlite_fetch_one_row(). This means that we've already stepped through the statement once (!), and possibly bound v

[issue44965] [sqlite3] early exit for non-DML statements in executemany()

2021-08-20 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- keywords: +patch pull_requests: +26320 stage: -> patch review pull_request: https://github.com/python/cpython/pull/27865 ___ Python tracker <https://bugs.python.org/issu

[issue44976] [sqlite3] lazy creation of result rows

2021-08-22 Thread Erlend E. Aasland
New submission from Erlend E. Aasland : Currently, we build the first result row in the _pysqlite_query_execute() loop if sqlite3_step() returned SQLITE_ROW. When the user asks for a row (for example, using sqlite3.Cursor.fetchone()), this pre-built row is returned, and the next row is

[issue44976] [sqlite3] lazy creation of result rows

2021-08-22 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- keywords: +patch pull_requests: +26339 stage: -> patch review pull_request: https://github.com/python/cpython/pull/27884 ___ Python tracker <https://bugs.python.org/issu

[issue44976] [sqlite3] lazy creation of result rows

2021-08-22 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Historical note: The current behaviour was introduced in pysqlite v2.0.2 (May 21 2005), in order to be able to finalise statements and thus close cursors as soon as possible. However, that effect was cancelled just after a couple of months, by the

[issue44972] Add workflow_dispatch trigger for GitHub Actions jobs

2021-08-23 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: > first-time contributors need a maintainer to approve the workflows for their > PRs How is manually dispatched workflows different from just opening a PR to your own fork? I do that from time to time in order to run the CI before opening a PR a

[issue43853] [sqlite3] Improve sqlite3_value_text() error handling

2021-08-23 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +26374 pull_request: https://github.com/python/cpython/pull/27922 ___ Python tracker <https://bugs.python.org/issue43

[issue43853] [sqlite3] Improve sqlite3_value_text() error handling

2021-08-23 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- Removed message: https://bugs.python.org/msg399133 ___ Python tracker <https://bugs.python.org/issue43853> ___ ___ Python-bug

[issue43853] [sqlite3] Improve sqlite3_value_text() error handling

2021-08-23 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: > What about new tests and NEWS update? See PR 27642 for the expanded tests, and PR 27922 for amending news entries. I didn't combine the two, as I figured you might have more comments on the fo

[issue44991] [sqlite3] cleanup GIL handling

2021-08-24 Thread Erlend E. Aasland
New submission from Erlend E. Aasland : Quoting msg400205 by Petr in bpo-42064: I think the module could use a more comprehensive review for GIL handling, rather than doing it piecewise in individual PRs. I recommend that any function passed to SQLite (and only those) should - be named

[issue42064] Convert sqlite3 to multi-phase initialisation (PEP 489)

2021-08-24 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Petr: > I think the module could use a more comprehensive review for GIL handling > [...] I agree. I created bpo-44991 for this. -- ___ Python tracker <https://bugs.python.org/i

[issue44991] [sqlite3] cleanup GIL handling

2021-08-24 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- keywords: +patch pull_requests: +26383 stage: -> patch review pull_request: https://github.com/python/cpython/pull/27934 ___ Python tracker <https://bugs.python.org/issu

[issue44991] [sqlite3] cleanup callbacks (GIL handling, naming, ...)

2021-08-24 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: I'd like to propose further enhancements: - use intermingled declarations in the affected functions; this will make GIL acquisition stand more out, and it also improves readability and makes it easier to trace refs - take the naming step further

[issue42064] Convert sqlite3 to multi-phase initialisation (PEP 489)

2021-08-25 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +26385 pull_request: https://github.com/python/cpython/pull/27940 ___ Python tracker <https://bugs.python.org/issue42

[issue27334] [sqlite3] context manager leaves db locked if commit fails in __exit__

2021-08-25 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +26388 pull_request: https://github.com/python/cpython/pull/27942 ___ Python tracker <https://bugs.python.org/issue27

[issue27334] [sqlite3] context manager leaves db locked if commit fails in __exit__

2021-08-25 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +26389 pull_request: https://github.com/python/cpython/pull/27943 ___ Python tracker <https://bugs.python.org/issue27

[issue27334] [sqlite3] context manager leaves db locked if commit fails in __exit__

2021-08-25 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +26390 pull_request: https://github.com/python/cpython/pull/27944 ___ Python tracker <https://bugs.python.org/issue27

[issue44997] _sqlite3 extention failed to build

2021-08-25 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- nosy: +erlendaasland ___ Python tracker <https://bugs.python.org/issue44997> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue44997] [sqlite3] build fails on macOS 11.5.1

2021-08-25 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- title: _sqlite3 extention failed to build -> [sqlite3] build fails on macOS 11.5.1 ___ Python tracker <https://bugs.python.org/issu

[issue44997] [sqlite3] build fails on macOS 11.5.1

2021-08-25 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- nosy: +ronaldoussoren ___ Python tracker <https://bugs.python.org/issue44997> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue44997] [sqlite3] build fails on macOS 11.5.1

2021-08-25 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: IIRC, macOS deprecated this functionality some releases ago. Seems like they've now removed it completely. I guess we could wrap this functionality with some preprocessor conditionals, and/or adjust the configure script to not accept --enable-loa

[issue44991] [sqlite3] cleanup callbacks (GIL handling, naming, ...)

2021-08-25 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: We'll do the changes Petr proposed first, and then I'll see how invasive the other changes will be. If the diffs end up being concise, I'll put them up for review :) -- ___ Python

[issue43853] [sqlite3] Improve sqlite3_value_text() error handling

2021-08-25 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +26399 pull_request: https://github.com/python/cpython/pull/27952 ___ Python tracker <https://bugs.python.org/issue43

[issue43853] [sqlite3] Improve sqlite3_value_text() error handling

2021-08-25 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +26400 pull_request: https://github.com/python/cpython/pull/27953 ___ Python tracker <https://bugs.python.org/issue43

[issue44997] [sqlite3] build fails on macOS 11.5.1

2021-08-26 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: > FTR, this is only a problem if you link with the Apple-supplied system > libsqlite3 [...] Sure, but that should be relatively trivial to detect. AFAIK, the SQLite command line shell seems to be located at the same path every release, so I would

<    4   5   6   7   8   9   10   11   12   >