[issue34222] Email message serialization enters an infinite loop when folding non-ASCII headers with long words

Cheryl Sabella added the comment: Thanks for the report, @maxking. -- nosy: +cheryl.sabella ___ Python tracker <https://bugs.python.org/issue34222> ___ ___ Pytho

[issue35551] Encoding and alias issues

Cheryl Sabella added the comment: New changeset c4c15ed7a2c7c2a1983e88b89c244d121eb3e512 by Cheryl Sabella (Ashwin Ramaswami) in branch 'master': bpo-35551: encodings update (GH-11446) https://github.com/python/cpython/commit/c4c15ed7a2c7c2a1983e88b89c244d121eb3e512 -

[issue35551] Encoding and alias issues

Change by Cheryl Sabella : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue2661] Mapping tests cannot be passed by user implementations

Change by Cheryl Sabella : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.9 -Python 2.7, Python 3.2, Python 3.3 ___ Python tracker <https://bugs.python.o

[issue33071] Document that PyPI no longer requires 'register'

Change by Cheryl Sabella : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.7, Python 3.8 ___ Python tracker <https://bugs.python.or

[issue11122] bdist_rpm should use rpmbuild, not rpm

Change by Cheryl Sabella : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue11122] bdist_rpm should use rpmbuild, not rpm

Cheryl Sabella added the comment: New changeset 45a14942c969ed508b35abd5e116cb18f84ce5b4 by Cheryl Sabella (Marcin Niemira) in branch 'master': bpo-11122: fix hardcoded path checking for rpmbuild in bdist_rpm.py (GH-10594) https://github.com/python/cpyt

[issue34677] Event scheduler page example

Cheryl Sabella added the comment: Thank you for the report. As others have said, the actual time.time() value for the two `s.enter` events is different even though the `delay` value of 5 seems like it should be the same. As @xtreak pointed out, the example is clever in showing that using

[issue37298] IDLE: Revise html to tkinker converter for help.html

Cheryl Sabella added the comment: tl;dr I think it's a difference in the CSS for the HTML5 writer. In the HTMLTranslator class for docutils writer [1], I found the following docstring, specifically the line "The html5_polyglot writer s

[issue37298] IDLE: Revise html to tkinker converter for help.html

Cheryl Sabella added the comment: Adding on to my last post, it's not in the CSS, but it's that Sphinx 2.0 switches from a default of HTML4 to HTML5. The docutils comments explain the difference between the two. https://github.com/sphinx-doc/sph

[issue37071] HTMLParser mistakenly inventing new tags while parsing

Cheryl Sabella added the comment: Thank you for the report. Looking at the BeautifulSoup source, there is a comment about this scenario: # Unlike other parsers, html.parser doesn't send separate end tag # events for empty-element tags. (It's

[issue30052] URL Quoting page links to function Bytes instead of defintion

Cheryl Sabella added the comment: Hi @wim.glenn, Thanks for the report. It looks like the same issue applies to all the built-in functions that are handled this way, not just bytearray and bytes. So, dict, frozenset, list, memoryview, range, set, str, and tuple too. I'm not sure

[issue36167] DOC: Incorrect capitalization in Programming FAQ

Change by Cheryl Sabella : -- versions: +Python 3.9 -Python 3.7 ___ Python tracker <https://bugs.python.org/issue36167> ___ ___ Python-bugs-list mailin

[issue36167] DOC: Incorrect capitalization in Programming FAQ

Change by Cheryl Sabella : -- keywords: +easy ___ Python tracker <https://bugs.python.org/issue36167> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36168] DOC: Fix capitalization in string.rst

Change by Cheryl Sabella : -- keywords: +easy versions: +Python 3.9 -Python 3.7 ___ Python tracker <https://bugs.python.org/issue36168> ___ ___ Python-bugs-list m

[issue32631] IDLE: revise zzdummy.py

Change by Cheryl Sabella : -- keywords: +patch pull_requests: +14308 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/14491 ___ Python tracker <https://bugs.python.org/issu

[issue27452] IDLE: Cleanup config code

Change by Cheryl Sabella : -- pull_requests: +14396 stage: test needed -> patch review pull_request: https://github.com/python/cpython/pull/14577 ___ Python tracker <https://bugs.python.org/issu

[issue27452] IDLE: Cleanup config code

Change by Cheryl Sabella : -- versions: +Python 3.8, Python 3.9 -Python 3.6 ___ Python tracker <https://bugs.python.org/issue27452> ___ ___ Python-bugs-list m

[issue32178] Some invalid email address groups cause an IndexError instead of a HeaderParseError

Cheryl Sabella added the comment: Based on @maxking's comment, I'm going to close this issue. Thank you! -- nosy: +cheryl.sabella resolution: -> out of date stage: patch review -> resolved status: open -> closed ___ Pyt

[issue32179] Empty email address in headers triggers an IndexError

Cheryl Sabella added the comment: Closing this per @maxking's comment. If it can be recreated, please reopen. -- nosy: +cheryl.sabella resolution: -> out of date stage: -> resolved status: open -> closed ___ Python t

[issue30663] IDLE: Add lineno sidebar to editor window

Change by Cheryl Sabella : -- resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default. ___ Py

[issue27485] urllib.splitport -- is it official or not?

Cheryl Sabella added the comment: Would it be OK for me to work on this? -- nosy: +csabella ___ Python tracker <http://bugs.python.org/issue27485> ___ ___ Pytho

[issue27485] urllib.splitport -- is it official or not?

Cheryl Sabella added the comment: Thank you. >From my understanding, urllib didn't officially supported the split* functions >(splittype, splithost, splitport, splinport, splituser, splitpasswd, >splitattr, splitquery, splitvalue, splittag) even though they were migrated to

[issue30668] DOC: missing word in license.rst

New submission from Cheryl Sabella: The 'Select kqueue' section starts with: "The `select` and contains the following notice for the kqueueinterface:" And the 'SipHash24' section has: "The file Python/pyhash.c contains Marek Majkowski’ implement

[issue27485] urllib.splitport -- is it official or not?

Changes by Cheryl Sabella : -- pull_requests: +2249 ___ Python tracker <http://bugs.python.org/issue27485> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue27485] urllib.splitport -- is it official or not?

Cheryl Sabella added the comment: Martin, thank you for the information and for pointing out those other related issues. It makes sense to separate the security or bug issues from this change. -- ___ Python tracker <http://bugs.python.

[issue30674] IDLE: add docstrings to grep.py

Changes by Cheryl Sabella : -- assignee: terry.reedy components: IDLE nosy: csabella, terry.reedy priority: normal severity: normal status: open title: IDLE: add docstrings to grep.py type: enhancement versions: Python 3.7 ___ Python tracker <h

[issue30674] IDLE: add docstrings to grep.py

Changes by Cheryl Sabella : -- pull_requests: +2257 ___ Python tracker <http://bugs.python.org/issue30674> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue30674] IDLE: add docstrings to grep.py

Cheryl Sabella added the comment: Thanks. It seems like my windows pop-up all over the place. It's probably a Ubuntu thing. I was used to looking at help_about and textview, which cascade over the current window (I think because of self.geometry) and that's what prompted m

[issue694339] IDLE: Dedenting with Shift+Tab

Changes by Cheryl Sabella : -- nosy: +csabella ___ Python tracker <http://bugs.python.org/issue694339> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue30674] IDLE: add docstrings to grep.py

Cheryl Sabella added the comment: Thanks, Terry. It seems that it *is* the hidden placement algorithm and I just never noticed it before. I opened a bunch of terminal windows and they opened top left, bottom left, top right, bottom right, then continuing to follow a pattern. IDLE did the

[issue25684] ttk.OptionMenu radiobuttons aren't unique between two instances of OptionMenu

Changes by Cheryl Sabella : -- pull_requests: +2325 ___ Python tracker <http://bugs.python.org/issue25684> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue30495] IDLE: modernize textview module

Cheryl Sabella added the comment: Hi Terry, Were you waiting on me for changes to the patch or would you like me to make a PR? Thanks! -- ___ Python tracker <http://bugs.python.org/issue30

[issue25684] ttk.OptionMenu radiobuttons aren't unique between two instances of OptionMenu

Cheryl Sabella added the comment: I submitted a patch based on Bryan's original workaround on SO. Thanks. -- nosy: +csabella ___ Python tracker <http://bugs.python.org/is

[issue30495] IDLE: modernize textview module

Changes by Cheryl Sabella : -- pull_requests: +2331 ___ Python tracker <http://bugs.python.org/issue30495> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue30495] IDLE: modernize textview module

Cheryl Sabella added the comment: Thanks, Terry. I've pulled the textview changes out and made a PR. I know you had said there can be more than one PR for a bug, so I did it under this number. Hope that was the right thing to do. I'll take a look at help_about separately. On M

[issue17583] IDLE HOWTO

Cheryl Sabella added the comment: I think it's a good start, but may need some tweaking. For example, the Menu options should probably somehow stand out from the rest of the text. I think it would be useful for a beginner, depending on how much of a beginner they are and how they got to

[issue27388] IDLE configdialog: reduce multiple references to Var names

Changes by Cheryl Sabella : -- pull_requests: +2354 ___ Python tracker <http://bugs.python.org/issue27388> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue27388] IDLE configdialog: reduce multiple references to Var names

Cheryl Sabella added the comment: Created a pull request for this - "The varnames, like method names, are internal to configdialog and can lowercased (PEP8) and otherwised changed." -- nosy: +csabella ___ Python tracker <http://bu

[issue25684] ttk.OptionMenu radiobuttons aren't unique between two instances of OptionMenu

Cheryl Sabella added the comment: I've now added unittests for this change. -- nosy: +gpolo ___ Python tracker <http://bugs.python.org/issue25684> ___ ___

[issue30728] IDLE: Modernize configdialog code.

Changes by Cheryl Sabella : -- pull_requests: +2370 ___ Python tracker <http://bugs.python.org/issue30728> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue30728] IDLE: Modernize configdialog code.

Cheryl Sabella added the comment: Hi Terry, I don't have a script for the renaming. Since I was reading the code for the docstrings at the same time, I just made the changes as I went along. However, my primary intent is to save you time and work, not cause more, so I will prepar

[issue24813] Redesign Help => About IDLE, make it non-modal

Changes by Cheryl Sabella : -- pull_requests: +2379 ___ Python tracker <http://bugs.python.org/issue24813> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue24813] Redesign Help => About IDLE, make it non-modal

Cheryl Sabella added the comment: I submitted a PR for #3. In Mark's patch, he had moved the existing text, email, docs, etc to column 1 instead of column 0 for better looking alignment. I can add that part of the redesign, but for now I just added the

[issue24813] Redesign Help => About IDLE, make it non-modal

Changes by Cheryl Sabella : -- pull_requests: +2417 ___ Python tracker <http://bugs.python.org/issue24813> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue24813] Redesign Help => About IDLE, make it non-modal

Cheryl Sabella added the comment: I submitted a PR for #1. For #4, I had a question to this related to ttk widgets. When I had moved the widgets to ttk, I had to remove the fg and bg settings because the ttk versions of Label, Frame, and Widget don't have those as part of their config

[issue6739] IDLE: refuse invalid key bindings

Changes by Cheryl Sabella : -- pull_requests: +2425 ___ Python tracker <http://bugs.python.org/issue6739> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue6739] IDLE: refuse invalid key bindings

Cheryl Sabella added the comment: I've made a PR for the patch. Even though other tests need to be added, I only added a test for the call to sequence_ok(). Testing this by itself will probably allow it to be mocked in other tests. I also added a call to the unittest in config_k

[issue24813] Redesign Help => About IDLE, make it non-modal

Changes by Cheryl Sabella : -- pull_requests: +2430 ___ Python tracker <http://bugs.python.org/issue24813> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue24813] Redesign Help => About IDLE, make it non-modal

Cheryl Sabella added the comment: I had run the full test before pushing the changes without any messages. I didn't run it with any options though. -- $:~/cpython/Lib$ /home/cheryl/cpython/python -m test.test

[issue24813] Redesign Help => About IDLE, make it non-modal

Cheryl Sabella added the comment: $:~/cpython/Lib$ /home/cheryl/cpython/python -m test -ugui == CPython 3.7.0a0 (heads/bpo24813:48fbe52, Jun 23 2017, 15:42:25) [GCC 5.4.0 20160609] == Linux-4.4.0-78-generic-x86_64-with-debian-stretch-sid little-endian == hash algorithm: siphash24 64bit == cwd

[issue24813] Redesign Help => About IDLE, make it non-modal

Cheryl Sabella added the comment: Sometimes that test fails and sometimes it doesn't, even if I run it several times in a row. When it does fail, it runs a lot longer than when it doesn't. So, I'm trying to figure out the difference before reporting it. Since the failure

[issue30756] GUI tests fail on Ubuntu

New submission from Cheryl Sabella: Running the tests over up to date build on Ubuntu 16.04 64-bit. ./python -m test.test_ttk_guionly -v Sometimes this runs without failure and sometimes it 'hangs' and then produces failures. When it hangs, my computer freezes completely. As y

[issue24813] Redesign Help => About IDLE, make it non-modal

Cheryl Sabella added the comment: Created issue 30756. On Sun, Jun 25, 2017 at 2:10 PM, Terry J. Reedy wrote: > > Terry J. Reedy added the comment: > > You should have enough data to open an issue; make Serhiy Storchaka (and > me) nosy. Does the same test fail consistentl

[issue24813] Redesign Help => About IDLE, make it non-modal

Cheryl Sabella added the comment: Is this the re-arrangement? A. What the patch does not do is switch from buttons to blue-underlined links, as I have discussed elsewhere, nor do other rearrangements and changes. I want to move What's New to the top, move the Python license and copy

[issue30777] IDLE: configdialog -- add docstrings and improve comments

Changes by Cheryl Sabella : -- pull_requests: +2489 ___ Python tracker <http://bugs.python.org/issue30777> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue30777] IDLE: configdialog -- add docstrings and improve comments

Cheryl Sabella added the comment: I've made a PR for the docstrings and comments. I didn't change any of the comments separating the sections in the create* functions as I wasn't sure how you wanted those changed. When reading the code, I found the comments helpful in that

[issue30422] Add roadmap.txt section to idlelib

Cheryl Sabella added the comment: Terry, thank for posting the list of all the IDLE issues. This is extremely helpful to me and I appreciate your effort in organizing it. I'm also on board for working together on targetted areas. Without that, I was focusing on PEP8, docstrings, li

[issue30779] IDLE: configdialog -- factor out Changes class

Cheryl Sabella added the comment: If possible, I'd like to work on this. -- nosy: +csabella ___ Python tracker <http://bugs.python.org/issue30779> ___ ___

[issue6691] Support for nested classes and function for pyclbr

Cheryl Sabella added the comment: I'm working on a PR for this. It passed the existing test cases, but then I tried something that didn't pass, so I'm working on fixing that. -- nosy: +csabella ___ Python tracker <http://bugs.py

[issue30779] IDLE: configdialog -- factor out Changes class

Cheryl Sabella added the comment: Here's the beginning design. Since it's a high priority, I didn't want to wait too long to show you something. As you can see, I still had a lot of questions and things I wasn't sure about. I have some tests, but wanted to have it

[issue6691] Support for nested classes and function for pyclbr

Cheryl Sabella added the comment: I have the change ready to push. I didn't change the tests, except to fix what was failing earlier, so the tests would need to be reviewed (the test currently creates a real temporary file that it opened and read, but a Mock would be better?) Anyway, d

[issue6691] Support for nested classes and function for pyclbr

Changes by Cheryl Sabella : -- pull_requests: +2566 ___ Python tracker <http://bugs.python.org/issue6691> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue6691] Support for nested classes and function for pyclbr

Cheryl Sabella added the comment: I've created the PR. I had actually manually looked at classbrowser yesterday. It still works just as it did before this change. The patch in 1612262 is needed for it to loop through the new Object class. Also, for reference, the test that didn&#

[issue30779] IDLE: configdialog -- factor out Changes class

Changes by Cheryl Sabella : Added file: http://bugs.python.org/file46984/configdialog_tests_v1.py ___ Python tracker <http://bugs.python.org/issue30779> ___ ___ Python-bug

[issue30779] IDLE: configdialog -- factor out Changes class

Changes by Cheryl Sabella : Added file: http://bugs.python.org/file46985/changes_class_v3.py ___ Python tracker <http://bugs.python.org/issue30779> ___ ___ Python-bug

[issue30779] IDLE: configdialog -- factor out Changes class

Cheryl Sabella added the comment: Thanks for pointing out mapping protocol access. That's what I was (poorly) trying to describe in the __getitem__ docstring in v1. It's a really concept. I worked on the tests. I added some more code to the classes, so I uploaded that too (so

[issue30495] IDLE: modernize textview module

Cheryl Sabella added the comment: I have some questions about the final version: 1. `ViewWindow` still has `self.button_ok` defined, but it's not used as far as I can tell. Can that be removed? 2. `def ok` in ViewFrame calls `self.parent.destroy`. I was wondering if it shou

[issue20692] Tutorial and FAQ: how to call a method on an int

Cheryl Sabella added the comment: Sreepriya Chalakkal, Would you be able to prepare a pull request on GitHub for your patch? Thanks! -- nosy: +csabella ___ Python tracker <http://bugs.python.org/issue20

[issue16328] win_add2path.py sets wrong user path

Cheryl Sabella added the comment: Any interest in making a PR for this patch? -- nosy: +csabella ___ Python tracker <http://bugs.python.org/issue16328> ___ ___

[issue12910] urrlib.quote quotes too many chars, e.g., '()'

Cheryl Sabella added the comment: Issue 16285 updated the urllib.parse.quote() reserved list to add '~'. >From the docstring: def quote(string, safe='/', encoding=None, errors=None): """quote('abc def') -> 'abc%20def' E

[issue1612262] Class Browser doesn't show internal classes

Changes by Cheryl Sabella : -- pull_requests: +2644 ___ Python tracker <http://bugs.python.org/issue1612262> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue30779] IDLE: configdialog -- factor out Changes class

Changes by Cheryl Sabella : -- pull_requests: +2675 ___ Python tracker <http://bugs.python.org/issue30779> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue30779] IDLE: configdialog -- factor out Changes class

Cheryl Sabella added the comment: I've made the first pull request for the changes to config.py. I have to apologize because I really couldn't figure out how to do 'save_all' without including 'set_user_value' since 'set_user_value' updates userCfg wi

[issue30779] IDLE: configdialog -- factor out Changes class

Cheryl Sabella added the comment: Sorry about that. When I read msg297804, I thought your intention was for me to work on the PRs. I didn't see your other note until now. It will be good for me to learn from your changes. As far as mocking Save, I sort of did that (very basically) in

[issue30779] IDLE: configdialog -- factor out Changes class

Cheryl Sabella added the comment: Terry, Any interest on using gitter or slack (or something like that) while trying to coordinate work between you, Louie, me, and others? -- ___ Python tracker <http://bugs.python.org/issue30

[issue30851] IDLE: configdialog -- fix tkinter Variables

Changes by Cheryl Sabella : -- pull_requests: +2692 ___ Python tracker <http://bugs.python.org/issue30851> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue30851] IDLE: configdialog -- fix tkinter Variables

Cheryl Sabella added the comment: Created the pull request so it's ready once the tests are available. -- ___ Python tracker <http://bugs.python.org/is

[issue30868] IDLE: Improve configuration tests with mock Save.

Cheryl Sabella added the comment: If it's helpful, here's some history on Save and save_as in configdialog. -- Item: Code change which added the lines to always save 'highlight' and 'keys'. November 16, 2004, commit 5acdf9308191b6356fb3ed4ba691ba5cd39

[issue30881] IDLE: add docstrings to browser.py

New submission from Cheryl Sabella: Add docstrings to browser.py to aid to unit test creation. -- assignee: terry.reedy components: IDLE messages: 297973 nosy: csabella, terry.reedy priority: normal severity: normal status: open title: IDLE: add docstrings to browser.py type

[issue30881] IDLE: add docstrings to browser.py

Changes by Cheryl Sabella : -- pull_requests: +2703 ___ Python tracker <http://bugs.python.org/issue30881> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue1612262] Class Browser doesn't show internal classes

Cheryl Sabella added the comment: I created issue 30881 to add docstrings to browser.py to make creating user tests easier. -- ___ Python tracker <http://bugs.python.org/issue1612

[issue30868] IDLE: Improve configuration tests with mock Save.

Cheryl Sabella added the comment: `git log` is the magic command. I won't be able to do it justice because it has too many options, but here are a few. `git log` shows all commit message history on the current branch. `git log -p` (p for patch) shows the actual diffs `git log -p -- pa

[issue30781] IDLE: configdialog -- switch to ttk widgets.

Changes by Cheryl Sabella : -- pull_requests: +2719 ___ Python tracker <http://bugs.python.org/issue30781> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue30779] IDLE: configdialog -- factor out Changes class

Changes by Cheryl Sabella : -- pull_requests: +2733 ___ Python tracker <http://bugs.python.org/issue30779> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue30779] IDLE: configdialog -- factor out Changes class

Cheryl Sabella added the comment: I had an error when trying to delete a custom theme. Sorry for not catching this before. -- ___ Python tracker <http://bugs.python.org/issue30

[issue27099] IDLE: turn builting extensions into regular modules

Cheryl Sabella added the comment: When I download the patch and run the tests, I get a lot of warnings (mostly on custom themes and custom keysets). I also get errors in test_parenmatch like this one: ERROR: test_paren_styles (idlelib.idle_test.test_parenmatch.ParenMatchTest) (style

[issue30913] IDLE: Document tk Vars, attributes, methods by tab page

Cheryl Sabella added the comment: I had actually started doing this a little in the original docstrings and then was worried that it was too redundant with the code. Thanks for mentioning the multiple PRs. I'll take a look at it and make one change at a time for easier r

[issue30913] IDLE: Document tk Vars, attributes, methods by tab page

Cheryl Sabella added the comment: I did a first draft of the four create_page_* methods. I did one additional section called 'Widget Structure' which has the names of the widgets indented under the parent widget they are attached to. I don't know if that would be helpful. T

[issue30913] IDLE: Document tk Vars, attributes, methods by tab page

Changes by Cheryl Sabella : -- pull_requests: +2763 ___ Python tracker <http://bugs.python.org/issue30913> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue30913] IDLE: Document tk Vars, attributes, methods by tab page

Cheryl Sabella added the comment: Did you want me to do other PRs for this? I had intended that one to be the first and I would complete more information on a subsequent PR, but you've added a lot of info. -- ___ Python tracker

[issue30934] Document how to run coverage for repository idlelib files.

Cheryl Sabella added the comment: I tried out the instructions. I guess my first question is how stand alone these instructions are and how much you expect someone to already know about coverage. What I mean is, I needed to go to the devguide to read more about coverage in order to run the

[issue29284] Include thread_name_prefix in the concurrent.futures.ThreadPoolExecutor example 17.4.2.1

Cheryl Sabella added the comment: Hi John, Would you be able to make a GitHub pull request for your change? Since CPython development has moved to GitHub, you may have a better chance of a review with a PR. -- nosy: +csabella ___ Python tracker

[issue30981] IDLE: Add config dialog font page tests

Changes by Cheryl Sabella : -- pull_requests: +2856 ___ Python tracker <http://bugs.python.org/issue30981> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue30993] IDLE: Document and fix configdialog font tests.

Changes by Cheryl Sabella : -- pull_requests: +2869 ___ Python tracker <http://bugs.python.org/issue30993> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue30993] IDLE: Document and fix configdialog font tests.

Cheryl Sabella added the comment: Works on linux. I just had one question on github about a test for sizelist and moving the initialization of the Tk variables into setUp. I also deleted a second comment that was just a wrong comment, but it's led me to another question.

[issue30993] IDLE: Document and fix configdialog font tests.

Cheryl Sabella added the comment: +1 on the Font/Indent name. And I agree that the indent widget would make more sense on the General tab, or another name, like Editor/Shell Preferences. Another thought I had was Fonts should maybe be part of a Theme. At the theme level (not at the tag

[issue30993] IDLE: Document, fix, and complete configdialog font tests

Cheryl Sabella added the comment: The tests pass on linux and the htest looks good. Thank you for making all these changes. It seems much clearer now, but I do want to spend more time reading the code to understand it. Looks like you grouped all the font-related functions, so they are

[issue30853] IDLE: configdialog -- factor out Tracer subclass

Cheryl Sabella added the comment: Would you like this change for fonts and indent before the tests for the other tabs are ready or would you like to have tests for all the tabs first? -- ___ Python tracker <http://bugs.python.org/issue30

[issue30853] IDLE: configdialog -- factor out Tracer subclass

Cheryl Sabella added the comment: I would like to work on this, but I don't think I'd be able to have something ready for a few days, so I don't want to hold you up if you would like it sooner. -- ___ Python tracker <http

<    1   2   3   4   5   6   7   8   9   10   >