[issue40280] Consider supporting emscripten/webassembly as a build target

2020-04-14 Thread Simon Biggs
New submission from Simon Biggs : Since asm.js came on the scene, and now Web Assembly people have created CPython patches to support building CPython with emscripten. See: * https://github.com/PeachPy/EmCPython -- Python 2.7 * https://github.com/dgym/cpython-emscripten/tree/master/3.5.2/patch

[issue40257] Improve the use of __doc__ in pydoc

2020-04-14 Thread Vedran Čačić
Vedran Čačić added the comment: Ok, I get what you're saying. But if someone writes class B(A): # no docstring at all ... help(B) they'll still get other elements of current help? Particularly, "Methods inherited from A" (with their docstrings)? -- _

[issue40257] Improve the use of __doc__ in pydoc

2020-04-14 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Yes, of course. And if it overrides some methods, but do not specify doctrings for new methods, they will be inherited from the parent class. class A: """Base class""" def foo(self): """Some docstring""" def bar(self): """Other docstring""" cla

[issue36780] Interpreter exit blocks waiting for futures of shut-down ThreadPoolExecutors

2020-04-14 Thread Torsten Landschoff
Torsten Landschoff added the comment: I intended to file a bug because of the shutdown problem but found out there is this ticket already. In our application we sometimes run into this problem that you can't exit because of a hanging TCP connection used inside a ThreadPoolExecutor task. ex

[issue39943] Meta: Clean up various issues in C internals

2020-04-14 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Yes, it is a consequence of PR 19345. But it looks like a compiler bug. It complains about implicit conversion from `const void **` to `void *` in memcpy() and PyMem_Del(). -- ___ Python tracker

[issue29255] selects.KqueueSelector behaves incorrectly when no fds are registered

2020-04-14 Thread Russell Davis
Change by Russell Davis : -- keywords: +patch pull_requests: +18860 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19508 ___ Python tracker ___ __

[issue25680] Selector.select() hangs when there is nothing to select

2020-04-14 Thread Russell Davis
Change by Russell Davis : -- keywords: +patch pull_requests: +18861 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19508 ___ Python tracker ___ __

[issue40280] Consider supporting emscripten/webassembly as a build target

2020-04-14 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Do you want to provide a pull request? -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Py

[issue40280] Consider supporting emscripten/webassembly as a build target

2020-04-14 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue40280] Consider supporting emscripten/webassembly as a build target

2020-04-14 Thread pmp-p
pmp-p added the comment: you can add * https://github.com/pmp-p/pydk/tree/master/sources.em/Python-3.8.0b4.patchset -- Python 3.8.x (wasm not asm.js, clang-10+ required) demo https://pmp-p.github.io/python-next/test.html CPython can already run in the browser with very little patching, bu

[issue40257] Improve the use of __doc__ in pydoc

2020-04-14 Thread Vedran Čačić
Vedran Čačić added the comment: Then I'm fine with it. Thanks. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue40255] Fixing Copy on Writes from reference counting

2020-04-14 Thread hai shi
Change by hai shi : -- nosy: +shihai1991 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue40271] Allow shell like paths in

2020-04-14 Thread Gavin D'souza
Gavin D'souza added the comment: @serhiy.storchaka That makes perfect sense. Could we do something to add a parameter perhaps, to evaluate literal paths to not bread existing code? although this isn't "needed" but it'd be neat to handle this internally -- ___

[issue40268] Reorganize pycore_pystate.h header

2020-04-14 Thread STINNER Victor
STINNER Victor added the comment: New changeset 4a3fe0835310643193ea45529ab0fb45c5f8f2fd by Victor Stinner in branch 'master': bpo-40268: Include explicitly pycore_interp.h (GH-19505) https://github.com/python/cpython/commit/4a3fe0835310643193ea45529ab0fb45c5f8f2fd -- _

[issue40280] Consider supporting emscripten/webassembly as a build target

2020-04-14 Thread Simon Biggs
Simon Biggs added the comment: Hi pmp-p and Serhiy, I'd be more than happy to attempt a pull request, but I imagine a change such as this needs to be discussed first, trying not to "rush to make a patch" (https://www.youtube.com/watch?v=voXVTjwnn-U&feature=youtu.be&t=2546). Also, I doubt I wil

[issue40244] AIX: build: _PyObject_GC_TRACK Asstertion failure

2020-04-14 Thread Michael Felt
Michael Felt added the comment: With the print statements - it does not crash: ./python -E -S -m sysconfig --generate-posix-vars ; if test $? -ne 0 ; then  echo "generate-posix-vars failed" ;  rm -f ./pybuilddir.txt ;  exit 1 ;  fi Objects/genobject.c:122:537318120 Objects/genobject.c:

[issue40244] AIX: build: _PyObject_GC_TRACK Asstertion failure

2020-04-14 Thread Michael Felt
Michael Felt added the comment: Also tried this: ./python -E -S -m sysconfig --generate-posix-vars ; if test $? -ne 0 ; then  echo "generate-posix-vars failed" ;  rm -f ./pybuilddir.txt ;  exit 1 ;  fi Objects/genobject.c:127: _PyObject_GC_TRACK: Assertion "!(((PyGC_Head *)(op)-1)->_gc

[issue40268] Reorganize pycore_pystate.h header

2020-04-14 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +18862 pull_request: https://github.com/python/cpython/pull/19509 ___ Python tracker ___ __

[issue40244] AIX: build: _PyObject_GC_TRACK Asstertion failure

2020-04-14 Thread Batuhan Taskaya
Batuhan Taskaya added the comment: > With the print statements - it does not crash: I think this isn't directly relevant with prints but about re-compiling? (just guessing). Because I experienced when I compile python for the first time on a clean AIX environment, all extension modules faile

[issue40244] AIX: build: _PyObject_GC_TRACK Asstertion failure

2020-04-14 Thread Batuhan Taskaya
Batuhan Taskaya added the comment: > Also tried this: Thanks for it, that was just something that I slightly suspected but expected to see it crash. -- ___ Python tracker __

[issue40281] Add pathlib.PurePath.as_uri()

2020-04-14 Thread Antoine Pitrou
New submission from Antoine Pitrou : "file" scheme URIs are normalized: https://tools.ietf.org/html/rfc8089 Therefore it would be possible to provide a PurePath method that returns a "file" scheme URI corresponding to the given path. -- components: Library (Lib) messages: 366384 nosy:

[issue40281] Add pathlib.PurePath.as_uri()

2020-04-14 Thread Antoine Pitrou
Change by Antoine Pitrou : -- nosy: +barneygale ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue40268] Reorganize pycore_pystate.h header

2020-04-14 Thread STINNER Victor
STINNER Victor added the comment: New changeset 81a7be3fa22c983209cc0ffb3537b92b0370f83c by Victor Stinner in branch 'master': bpo-40268: Rename _PyInterpreterState_GET_UNSAFE() (GH-19509) https://github.com/python/cpython/commit/81a7be3fa22c983209cc0ffb3537b92b0370f83c --

[issue40221] Use new _at_fork_reinit() lock method in multiprocessing

2020-04-14 Thread Dong-hee Na
Dong-hee Na added the comment: New changeset e1945307d36849f8be8937144cf3dd6ebab6274c by Dong-hee Na in branch 'master': bpo-40221: Update multiprocessing to use _at_fork_reinit (GH-19477) https://github.com/python/cpython/commit/e1945307d36849f8be8937144cf3dd6ebab6274c --

[issue40255] Fixing Copy on Writes from reference counting

2020-04-14 Thread Steve Dower
Steve Dower added the comment: >> This isn't actually about removing immortal objects, but removing *mutable* >> objects that would be shared between subinterpreters. Making some objects >> immortal, such as interned strings or stateless singletons, would actually >> benefit this work, as they

[issue39511] [subinterpreters] Per-interpreter singletons (None, True, False, etc.)

2020-04-14 Thread Steve Dower
Change by Steve Dower : -- nosy: +steve.dower ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue40268] Reorganize pycore_pystate.h header

2020-04-14 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +18863 pull_request: https://github.com/python/cpython/pull/19510 ___ Python tracker ___ __

[issue39947] [C API] Make the PyThreadState structure opaque (move it to the internal C API)

2020-04-14 Thread STINNER Victor
Change by STINNER Victor : -- title: Make the PyThreadState structure opaque (move it to the internal C API) -> [C API] Make the PyThreadState structure opaque (move it to the internal C API) ___ Python tracker

[issue40281] Add pathlib.PurePath.as_uri()

2020-04-14 Thread Dong-hee Na
Dong-hee Na added the comment: +1 to add this :) -- nosy: +corona10 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue40255] Fixing Copy on Writes from reference counting

2020-04-14 Thread Antoine Pitrou
Antoine Pitrou added the comment: > I run the pyperformance test suite with PGO + LTO + full cpu isolation in the > speed.python.org machine and these were the results: Be mindful that synthetic benchmarks are probably a gentle case for branch prediction. Real-world performance on irregular

[issue40255] Fixing Copy on Writes from reference counting

2020-04-14 Thread Antoine Pitrou
Antoine Pitrou added the comment: As a separate discussion, I would be interested to know whether the original use case (Eddie's) could be satisfied differently. It probably doesn't belong to this issue, though. (Eddie, if you want to discuss this, feel free to e-mail me privately. I think

[issue39943] Meta: Clean up various issues in C internals

2020-04-14 Thread Andy Lester
Andy Lester added the comment: I remember coming across a similar error from GCC about casting from a const double pointer to a single pointer void and it said (I believe) something about having to have each cast having to be valid. I think it was implying something like that if you have

[issue40221] Use new _at_fork_reinit() lock method in multiprocessing

2020-04-14 Thread Dong-hee Na
Change by Dong-hee Na : -- pull_requests: +18864 pull_request: https://github.com/python/cpython/pull/19511 ___ Python tracker ___ _

[issue40282] random.getrandbits(0) should succeed

2020-04-14 Thread Antoine Pitrou
New submission from Antoine Pitrou : When creating variable-sized random binary strings with random.getrandbits(), you currently have to special case when the number of bytes is 0, because otherwise getrandbits() raises: ValueError: number of bits must be greater than zero It seems like it

[issue40282] random.getrandbits(0) should succeed

2020-04-14 Thread STINNER Victor
STINNER Victor added the comment: How random would be the 0 returned by getrandbits(0)? :-) -- nosy: +vstinner ___ Python tracker ___ _

[issue40282] random.getrandbits(0) should succeed

2020-04-14 Thread Antoine Pitrou
Antoine Pitrou added the comment: I think you know the answer to your question ;-) -- ___ Python tracker ___ ___ Python-bugs-list m

[issue40268] Reorganize pycore_pystate.h header

2020-04-14 Thread STINNER Victor
STINNER Victor added the comment: New changeset e5014be0497d06d78343623588a80f491a6f7b74 by Victor Stinner in branch 'master': bpo-40268: Remove a few pycore_pystate.h includes (GH-19510) https://github.com/python/cpython/commit/e5014be0497d06d78343623588a80f491a6f7b74 -- _

[issue39522] AST Unparser with unicode kinded constants

2020-04-14 Thread Batuhan Taskaya
Change by Batuhan Taskaya : -- keywords: +patch pull_requests: +18865 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19512 ___ Python tracker ___

[issue40273] mappingproxy isn't reversible

2020-04-14 Thread Zackery Spytz
Change by Zackery Spytz : -- keywords: +patch nosy: +ZackerySpytz nosy_count: 2.0 -> 3.0 pull_requests: +18866 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19513 ___ Python tracker

[issue40268] Reorganize pycore_pystate.h header

2020-04-14 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +18867 pull_request: https://github.com/python/cpython/pull/19515 ___ Python tracker ___ __

[issue40232] PyOS_AfterFork_Child() should use _PyThread_at_fork_reinit()

2020-04-14 Thread Dong-hee Na
Dong-hee Na added the comment: New changeset 62f75fe3dd138f72303814d27183aa469eefcca6 by Dong-hee Na in branch 'master': bpo-40232: Update PyOS_AfterFork_Child() to use _PyThread_at_fork_reinit() (GH-19450) https://github.com/python/cpython/commit/62f75fe3dd138f72303814d27183aa469eefcca6 -

[issue40232] PyOS_AfterFork_Child() should use _PyThread_at_fork_reinit()

2020-04-14 Thread Dong-hee Na
Dong-hee Na added the comment: This issue is now solved. Thanks, Victor for the suggestion! :) -- resolution: -> fixed stage: patch review -> resolved status: open -> closed type: -> enhancement ___ Python tracker

[issue40268] Reorganize pycore_pystate.h header

2020-04-14 Thread STINNER Victor
STINNER Victor added the comment: New changeset e560f90602870601945ea7a4f7770827608817d2 by Victor Stinner in branch 'master': bpo-40268: Move struct _gc_runtime_state to pycore_gc.h (GH-19515) https://github.com/python/cpython/commit/e560f90602870601945ea7a4f7770827608817d2 -- ___

[issue40221] Use new _at_fork_reinit() lock method in multiprocessing

2020-04-14 Thread Dong-hee Na
Dong-hee Na added the comment: New changeset a5900ecf9f22e65bef489633692e9ea6941379c5 by Dong-hee Na in branch 'master': bpo-40221: Update multiprocessing to use _at_fork_reinit (GH-19511) https://github.com/python/cpython/commit/a5900ecf9f22e65bef489633692e9ea6941379c5 --

[issue40221] Use new _at_fork_reinit() lock method in multiprocessing

2020-04-14 Thread Dong-hee Na
Dong-hee Na added the comment: Looks like we update all the methods which are related to _after_fork under Lib/multiprocessing. I am now closing this issue. Thanks for the suggestion, Victor :) -- resolution: -> fixed stage: patch review -> resolved status: open -> closed type: -> e

[issue40283] Documentation of turtle.circle()

2020-04-14 Thread guchao
New submission from guchao : refer to circle() in the url: https://docs.python.org/2/library/turtle.html#turtle.circle [current] ... Draw the arc in counterclockwise direction if radius is positive, otherwise in clockwise direction. [suggestion] ... Draw the arc in counterclockwise directio

[issue40255] Fixing Copy on Writes from reference counting

2020-04-14 Thread Carl Meyer
Carl Meyer added the comment: > Anything that is touched by the immortal object will be leaked. This can also > happen in obscure ways if reference cycles are created. I think this is simply expected behavior if you choose to create immortal objects, and not really an issue. How could you ha

[issue40255] Fixing Copy on Writes from reference counting

2020-04-14 Thread Carl Meyer
Carl Meyer added the comment: > An immortalized object will never start participating in reference counting > again after it is immortalized. Well, "passed to an extension compiled with no-immortal headers" is an exception to this. But for the "not GC tracked but later becomes GC tracked" c

[issue40255] Fixing Copy on Writes from reference counting

2020-04-14 Thread Carl Meyer
Carl Meyer added the comment: > This may break the garbage collector algorithm that relies on the balance > between strong references between objects and its reference count to do the > calculation of the isolated cycles. I don't think it really breaks anything. What happens is that the immo

[issue40244] AIX: build: _PyObject_GC_TRACK Asstertion failure

2020-04-14 Thread Michael Felt
Michael Felt added the comment: On 14/04/2020 14:54, Batuhan Taskaya wrote: > Batuhan Taskaya added the comment: > >> With the print statements - it does not crash: > I think this isn't directly relevant with prints but about re-compiling? > (just guessing). I only recompiled the one .c file

[issue40255] Fixing Copy on Writes from reference counting

2020-04-14 Thread Dino Viehland
Dino Viehland added the comment: I think there's other cases of performance related features being hidden under an ifdef. Computed gotos show up that way, although probably more because it's a compiler extension that's not supported everywhere. Pymalloc is also very similar in that it impl

[issue40255] Fixing Copy on Writes from reference counting

2020-04-14 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > I think this is simply expected behavior if you choose to create immortal > objects, and not really an issue. How could you have an immortal object that > doesn't keep its strong references alive? I think I didn't express myself very well: I am sayi

[issue40255] Fixing Copy on Writes from reference counting

2020-04-14 Thread Steve Dower
Steve Dower added the comment: There hasn't been much said about which kind of objects would be immortal. Could this be a creation-time option? Or a type object (similar to a no-op tp_dealloc)? If it's something that is known when the object is created, then some of the "infection" concern

[issue40255] Fixing Copy on Writes from reference counting

2020-04-14 Thread Steve Dower
Change by Steve Dower : -- nosy: +dino.viehland ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue37531] Fix regrtest timeout for subprocesses: regrtest -jN --timeout=SECONDS

2020-04-14 Thread STINNER Victor
STINNER Victor added the comment: New changeset 67b8a1f0f0f78ec38b8626fa9f5b2f5a55c17e15 by Victor Stinner in branch '3.8': [3.8] Update libregrtest from master (GH-19516) https://github.com/python/cpython/commit/67b8a1f0f0f78ec38b8626fa9f5b2f5a55c17e15 -- _

[issue37957] Allow regrtest to receive a file with test (and subtests) to ignore

2020-04-14 Thread STINNER Victor
STINNER Victor added the comment: New changeset 67b8a1f0f0f78ec38b8626fa9f5b2f5a55c17e15 by Victor Stinner in branch '3.8': [3.8] Update libregrtest from master (GH-19516) https://github.com/python/cpython/commit/67b8a1f0f0f78ec38b8626fa9f5b2f5a55c17e15 -- _

[issue38502] regrtest: use process groups

2020-04-14 Thread STINNER Victor
STINNER Victor added the comment: New changeset 67b8a1f0f0f78ec38b8626fa9f5b2f5a55c17e15 by Victor Stinner in branch '3.8': [3.8] Update libregrtest from master (GH-19516) https://github.com/python/cpython/commit/67b8a1f0f0f78ec38b8626fa9f5b2f5a55c17e15 -- _

[issue40255] Fixing Copy on Writes from reference counting

2020-04-14 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > There hasn't been much said about which kind of objects would be immortal. The current patch makes *all objects that are tracked by the gc* immortal, independently of their type (unless I am missing something). -- __

[issue40255] Fixing Copy on Writes from reference counting

2020-04-14 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > all objects that are tracked by the gc also, all the objects that are reachable from objects tracked by the gc. -- ___ Python tracker _

[issue40260] modulefinder traceback regression starting on Windows

2020-04-14 Thread Barry Alan Scott
Barry Alan Scott added the comment: io.open_code() used in the patch. -- components: -Windows ___ Python tracker ___ ___ Python-bu

[issue36780] Interpreter exit blocks waiting for futures of shut-down ThreadPoolExecutors

2020-04-14 Thread Antoine Pitrou
Change by Antoine Pitrou : -- nosy: +aeros ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue36780] Interpreter exit blocks waiting for futures of shut-down ThreadPoolExecutors

2020-04-14 Thread Antoine Pitrou
Antoine Pitrou added the comment: I don't think there's much ThreadPoolExecutor can do. If you drop the references to the threads, they still exist and they still be waited upon at interpreter exit. The solution is for you to avoid having hanging threads. In the particular case of TCP con

[issue40255] Fixing Copy on Writes from reference counting

2020-04-14 Thread Gregory P. Smith
Gregory P. Smith added the comment: Marking everything as immortal/eternal after you've loaded your common code & data but before you do your forking is thenorm for this kind of serving system. You already presumably have a defined lifetime for the processes so they'll likely be set to die w

[issue40170] [C API] Make PyTypeObject structure an opaque structure in the public C API

2020-04-14 Thread STINNER Victor
STINNER Victor added the comment: New changeset 675d9a3d7afc767a2818c84da7ba4bf4181dcf26 by Hai Shi in branch 'master': bpo-40170: Convert PyObject_IS_GC() macro to a function (GH-19464) https://github.com/python/cpython/commit/675d9a3d7afc767a2818c84da7ba4bf4181dcf26 -- __

[issue32033] The pwd module implementation incorrectly sets some attributes to None

2020-04-14 Thread STINNER Victor
STINNER Victor added the comment: New changeset 96515e9f6785328c52ebc5d4ce60e0087a9adc2d by Zackery Spytz in branch 'master': bpo-32033: Fix test_pwd failures on Android (GH-19502) https://github.com/python/cpython/commit/96515e9f6785328c52ebc5d4ce60e0087a9adc2d --

[issue32033] The pwd module implementation incorrectly sets some attributes to None

2020-04-14 Thread miss-islington
Change by miss-islington : -- nosy: +miss-islington nosy_count: 4.0 -> 5.0 pull_requests: +18868 pull_request: https://github.com/python/cpython/pull/19518 ___ Python tracker _

[issue36780] Interpreter exit blocks waiting for futures of shut-down ThreadPoolExecutors

2020-04-14 Thread Hrvoje Nikšić
Hrvoje Nikšić added the comment: > I don't think there's much ThreadPoolExecutor can do. If you drop the > references to the threads, they still exist and they still be waited upon at > interpreter exit. ThreadPoolExecutor introduces additional waiting of its own, and it is this wait the PR

[issue32033] The pwd module implementation incorrectly sets some attributes to None

2020-04-14 Thread miss-islington
Change by miss-islington : -- pull_requests: +18869 pull_request: https://github.com/python/cpython/pull/19519 ___ Python tracker ___ __

[issue32033] The pwd module implementation incorrectly sets some attributes to None

2020-04-14 Thread STINNER Victor
STINNER Victor added the comment: It's now fixed in master and backports to 3.7 and 3.8 will be merged as soon as the CI pass. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue36780] Interpreter exit blocks waiting for futures of shut-down ThreadPoolExecutors

2020-04-14 Thread Antoine Pitrou
Antoine Pitrou added the comment: I think there's a misunderstanding: "wait_at_exit" will make the *executor* forget about the threads, but Python itself still knows about them, and it waits for them to end at interpreter shutdown. These threads were daemon threads in 3.8, so your patch inde

[issue40255] Fixing Copy on Writes from reference counting

2020-04-14 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > But if said objects (isolated and untracked before and now tracked) acquire > strong references to immortal objects, those objects will be visited when the > gc starts calculating the isolated cycles and that requires a balanced > reference count to

[issue40255] Fixing Copy on Writes from reference counting

2020-04-14 Thread Carl Meyer
Carl Meyer added the comment: I think the concerns about "perfect" behavior in corner cases are in general irrelevant here. In the scenarios where this optimization matters, there is no quantitative change that occurs at 100% coverage. Preventing 99% of CoW is 99% as good as preventing 100%

[issue36780] Interpreter exit blocks waiting for futures of shut-down ThreadPoolExecutors

2020-04-14 Thread Hrvoje Nikšić
Hrvoje Nikšić added the comment: Thanks for the clarification, I didn't know about the change to non-daemon threads. I still think this patch is useful, and won't harm general use because it is opt-in, just like daemon threads themselves. I suggest to update the PR to specify non-waiting poo

[issue32033] The pwd module implementation incorrectly sets some attributes to None

2020-04-14 Thread miss-islington
miss-islington added the comment: New changeset 1e1dbdf23f7a18f53a3257badc3541973831f2c4 by Miss Islington (bot) in branch '3.8': bpo-32033: Fix test_pwd failures on Android (GH-19502) https://github.com/python/cpython/commit/1e1dbdf23f7a18f53a3257badc3541973831f2c4 --

[issue32033] The pwd module implementation incorrectly sets some attributes to None

2020-04-14 Thread miss-islington
miss-islington added the comment: New changeset 8821200d85657ef3bbec78dcb43694449c05e896 by Miss Islington (bot) in branch '3.7': bpo-32033: Fix test_pwd failures on Android (GH-19502) https://github.com/python/cpython/commit/8821200d85657ef3bbec78dcb43694449c05e896 --

[issue40260] modulefinder traceback regression starting on Windows

2020-04-14 Thread Steve Dower
Steve Dower added the comment: Thanks, Barry! I tweaked your NEWS entry a little, so once CI completes I'll merge and backport. -- ___ Python tracker ___ ___

[issue9216] FIPS support for hashlib

2020-04-14 Thread Miro Hrončok
Change by Miro Hrončok : -- nosy: +hroncok nosy_count: 17.0 -> 18.0 pull_requests: +18870 pull_request: https://github.com/python/cpython/pull/19520 ___ Python tracker ___ __

[issue40255] Fixing Copy on Writes from reference counting

2020-04-14 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > I'm not sure what you mean here by "balanced ref count" or by "work" :) What > will happen anytime an immortal object gets into the GC, for any reason, is > that the GC will "subtract" cyclic references and see that the immortal > object still has a

[issue40282] random.getrandbits(0) should succeed

2020-04-14 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Seconded. And I wish to add the getrandbytes() method. -- nosy: +serhiy.storchaka ___ Python tracker ___ _

[issue40267] Error message differs when an expression is in an fstring

2020-04-14 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- keywords: +patch pull_requests: +18871 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19521 ___ Python tracker _

[issue40282] random.getrandbits(0) should succeed

2020-04-14 Thread Mark Dickinson
Mark Dickinson added the comment: This was discussed previously in #37000. I agree that `getrandbits(0)` should succeed. -- ___ Python tracker ___ ___

[issue36780] Interpreter exit blocks waiting for futures of shut-down ThreadPoolExecutors

2020-04-14 Thread Kyle Stanley
Kyle Stanley added the comment: > I don't think there's much ThreadPoolExecutor can do. If you drop the > references to the threads, they still exist and they still be waited upon at > interpreter exit. > > The solution is for you to avoid having hanging threads. In the particular > case

[issue40260] modulefinder traceback regression starting on Windows

2020-04-14 Thread miss-islington
Change by miss-islington : -- nosy: +miss-islington nosy_count: 7.0 -> 8.0 pull_requests: +18872 pull_request: https://github.com/python/cpython/pull/19522 ___ Python tracker _

[issue40260] modulefinder traceback regression starting on Windows

2020-04-14 Thread Steve Dower
Steve Dower added the comment: New changeset d42e5820631cd66ee1eab8f610d4b58f3dfdd81c by Barry in branch 'master': bpo-40260: Update modulefinder to use io.open_code() and respect coding comments (GH-19488) https://github.com/python/cpython/commit/d42e5820631cd66ee1eab8f610d4b58f3dfdd81c -

[issue23082] pathlib relative_to() can give confusing error message

2020-04-14 Thread Steve Dower
Steve Dower added the comment: I agree it's worth improving the error message (and probably the docs too). It's never made clear that relative_to only looks deeper (won't ever generate leading ".." parts) - the closest hint in the docs is that os.path.relpath is different (and that isn't eve

[issue39522] AST Unparser with unicode kinded constants

2020-04-14 Thread Batuhan Taskaya
Change by Batuhan Taskaya : -- pull_requests: +18873 pull_request: https://github.com/python/cpython/pull/19523 ___ Python tracker ___ _

[issue40260] modulefinder traceback regression starting on Windows

2020-04-14 Thread miss-islington
miss-islington added the comment: New changeset 59047fab0ef37f583c9e7c3a48d67792fd10ff91 by Miss Islington (bot) in branch '3.8': bpo-40260: Update modulefinder to use io.open_code() and respect coding comments (GH-19488) https://github.com/python/cpython/commit/59047fab0ef37f583c9e7c3a48d67

[issue40260] modulefinder traceback regression starting on Windows

2020-04-14 Thread Steve Dower
Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ P

[issue40249] __import__ doesn't honour globals

2020-04-14 Thread Brett Cannon
Brett Cannon added the comment: How would you propose changing the wording found at https://docs.python.org/3/library/functions.html?highlight=__import__#__import__? -- nosy: +brett.cannon ___ Python tracker __

[issue9216] FIPS support for hashlib

2020-04-14 Thread miss-islington
Change by miss-islington : -- pull_requests: +18874 pull_request: https://github.com/python/cpython/pull/19524 ___ Python tracker ___ ___

[issue9216] FIPS support for hashlib

2020-04-14 Thread miss-islington
miss-islington added the comment: New changeset 4c0a31fb08407ba043688ad1c21102dd4cb99146 by Miro Hrončok in branch 'master': bpo-9216: Nobody expects the geohashing FIPS inquisition (GH-19520) https://github.com/python/cpython/commit/4c0a31fb08407ba043688ad1c21102dd4cb99146 -- nosy:

[issue36780] Interpreter exit blocks waiting for futures of shut-down ThreadPoolExecutors

2020-04-14 Thread Kyle Stanley
Kyle Stanley added the comment: > ThreadPoolExecutor introduces additional waiting of its own, and it is this > wait the PR adds an option to disable. [next post] > Thanks for the clarification, I didn't know about the change to non-daemon > threads. > I still think this patch is useful, a

[issue40249] __import__ doesn't honour globals

2020-04-14 Thread Stefan Seefeld
Stefan Seefeld added the comment: I'm not entirely sure, but have to admit that the sentence "The function imports the module name, potentially using the given globals and locals to determine how to interpret the name in a package context." is a bit obscure. What does "determine how to inter

[issue36780] Interpreter exit blocks waiting for futures of shut-down ThreadPoolExecutors

2020-04-14 Thread Hrvoje Nikšić
Hrvoje Nikšić added the comment: > The only way I could see this to work as intended without making any changes > to threading would be to optionally use daemon threads and avoid joining the > threads in `executor.shutdown()` if `wait_at_exit` is set to False in the > constructor for the exec

[issue40282] random.getrandbits(0) should succeed

2020-04-14 Thread Raymond Hettinger
Raymond Hettinger added the comment: +0 for having getrandbits(0) return 0. Conceptually, it is reasonable. Practically, it is a bit inconvenient because the ValueError may have to be moved upstream to the _randbelow() methods. -1 for getrandbytes(). That is feature creep and no user has

[issue39522] AST Unparser with unicode kinded constants

2020-04-14 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- nosy: +pablogsal nosy_count: 1.0 -> 2.0 pull_requests: +18875 pull_request: https://github.com/python/cpython/pull/19525 ___ Python tracker ___

[issue39522] AST Unparser with unicode kinded constants

2020-04-14 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 43aeefa41915e4d3b0e68bbd4268c1c378a72dce by Batuhan Taşkaya in branch 'master': bpo-39522: Use _PyUnicodeWriter_WriteStr instead of PyUnicode_AS_DATA (GH-19523) https://github.com/python/cpython/commit/43aeefa41915e4d3b0e68bbd4268c1c378a72

[issue39522] AST Unparser with unicode kinded constants

2020-04-14 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 33986465bde2a2188537c4ef6cdb6055e348f31f by Pablo Galindo in branch 'master': bpo-39522: Always initialise kind attribute in constant ast nodes (GH-19525) https://github.com/python/cpython/commit/33986465bde2a2188537c4ef6cdb6055e348f31f

[issue39522] AST Unparser with unicode kinded constants

2020-04-14 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue40282] random.getrandbits(0) should succeed

2020-04-14 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I do not want to open an issue if I know that the idea will be rejected. -- ___ Python tracker ___

  1   2   >