[issue38106] [2.7] Race in PyThread_release_lock on macOS - can lead to memory corruption and deadlock

2019-10-02 Thread Mariusz Wawrzonkowski
Mariusz Wawrzonkowski added the comment: I can confirm that I have the deadlock because of the reason described above. When I change the PyThread_release_lock source locally to signal before releasing the mutex, then my deadlock does not occur anymore. I have tested it on a heave multithread

[issue38342] ImportError: cannot import name 'MetadataPathFinder' from 'importlib.metadata'

2019-10-02 Thread Florimond Manca
Florimond Manca added the comment: Can confirm this on 3.8.0rc1+ / macOS Mojave: ```console $ python -c "import importlib.metadata; print(list(importlib.metadata.distributions()))" Traceback (most recent call last): File "", line 1, in File "/Users/florimond/.pyenv/versions/3.8-dev/lib/

[issue38342] ImportError: cannot import name 'MetadataPathFinder' from 'importlib.metadata'

2019-10-02 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: The library was synced with https://bugs.python.org/issue38121 which seems to be related to this. -- nosy: +xtreak ___ Python tracker

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

2019-10-02 Thread STINNER Victor
STINNER Victor added the comment: Oh, Neil missed "bpo-38006: " prefix in his commit. Here it is: commit bcda460baf25062ab68622b3f043f52b9db4d21d Author: Neil Schemenauer Date: Mon Sep 30 10:06:45 2019 -0700 Clear weakrefs in garbage found by the GC (#16495) Fix a bug due to t

[issue38346] Wrong behavior when using `assert_called_with` with mutable object

2019-10-02 Thread Jim Jeon
New submission from Jim Jeon : When `assert_called_with` is used with mutable object, test fails if the object has changed. I think this is not what it meant to do. https://docs.python.org/dev/library/unittest.mock-examples.html#coping-with-mutable-arguments The same situation is explained in

[issue38347] pathfix.py does not find Python scripts that have '-' in its filename

2019-10-02 Thread Rüdiger Plüm
New submission from Rüdiger Plüm : Tools/scripts/pathfix.py does not find Python scripts that contain a '-' in their filename when working recursively. This is caused by the regular expression used to detect whether a filename is a Python script: r'^[a-zA-Z0-9_]+\.py$' r'^[a-zA-Z0-9_-]+\.py$'

[issue38347] pathfix.py does not find Python scripts that have '-' in its filename

2019-10-02 Thread Rüdiger Plüm
Change by Rüdiger Plüm : -- keywords: +patch pull_requests: +16125 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16536 ___ Python tracker ___

[issue38347] pathfix.py does not find Python scripts that have '-' in its filename

2019-10-02 Thread STINNER Victor
Change by STINNER Victor : -- nosy: +vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

2019-10-02 Thread Łukasz Langa
Łukasz Langa added the comment: > Łukasz, is there some reason you removed old versions (2.7, 3.6, etc)? The > bug is present on those versions of Python and it should be trivial to > backport the fix. If those branches are maintained, I think we should fix it. Sorry, I did that by mistake.

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

2019-10-02 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +16126 pull_request: https://github.com/python/cpython/pull/16537 ___ Python tracker ___ __

[issue38346] Wrong behavior when using `assert_called_with` with mutable object

2019-10-02 Thread Vedran Čačić
Vedran Čačić added the comment: I don't see what the "fix" should be. Python doesn't have value semantics. Functions are called with objects, not with their values. Imagine a was global variable, and then you say: a = mutable_object() f(a) a.mutate() f.assert_called_with(a) In

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

2019-10-02 Thread miss-islington
Change by miss-islington : -- pull_requests: +16127 pull_request: https://github.com/python/cpython/pull/16538 ___ Python tracker ___ __

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

2019-10-02 Thread STINNER Victor
STINNER Victor added the comment: New changeset 2ea71a07d0a720707094ee55f78fd232c40724bc by Victor Stinner in branch 'master': bpo-36670: regrtest bug fixes (GH-16537) https://github.com/python/cpython/commit/2ea71a07d0a720707094ee55f78fd232c40724bc -- _

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

2019-10-02 Thread miss-islington
miss-islington added the comment: New changeset a72de9338882b8013a4bb8adb930fe3308682e28 by Miss Islington (bot) in branch '3.8': bpo-36670: regrtest bug fixes (GH-16537) https://github.com/python/cpython/commit/a72de9338882b8013a4bb8adb930fe3308682e28 -- __

[issue38346] Wrong behavior when using `assert_called_with` with mutable object

2019-10-02 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: As explained copy would cause backwards incompatible change on objects that depend on identity comparison. I am not sure if this can be fixed in a backwards compatible manner. > One possibility would be for mock to copy the arguments you pass in. T

[issue38346] Wrong behavior when using `assert_called_with` with mutable object

2019-10-02 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: See also https://bugs.python.org/issue28848 -- ___ Python tracker ___ ___ Python-bugs-l

[issue38342] ImportError: cannot import name 'MetadataPathFinder' from 'importlib.metadata'

2019-10-02 Thread Jason R. Coombs
Jason R. Coombs added the comment: I believe importlib/metadata/__init__ was moved to importlib.metadata. I’ll inspect the repo for correctness, but there may be another issue with the old files lingering. -- ___ Python tracker

[issue38342] ImportError: cannot import name 'MetadataPathFinder' from 'importlib.metadata'

2019-10-02 Thread Jason R. Coombs
Jason R. Coombs added the comment: I've confirmed that the `metadata` directory doesn't exist in the repo. It also doesn't appear on my Python 3.8.0b4 installation on macOS: ``` cpython master $ ls /Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/importlib/

[issue38331] Exec not recognizing global variables inside function

2019-10-02 Thread Huyston
Huyston added the comment: Ronald Oussoren, I understand your comment and it makes sense in the module perspective. However, when using 'exec', we are explicitly passing a globals dict (and locals) that the target code should consider. As the documentation states: "If globals and locals are

[issue38319] shutil.copyfile(): os.sendfile() fails with OverflowError on 32-bit system

2019-10-02 Thread STINNER Victor
STINNER Victor added the comment: 32-bit buildbots are back to green. Thanks for the fix! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker __

[issue38342] ImportError: cannot import name 'MetadataPathFinder' from 'importlib.metadata'

2019-10-02 Thread Anthony Tuininga
Anthony Tuininga added the comment: Yes. I had tried b3 earlier, installed b4 over b3 and then rc1 over b4. Removing the cruft using the command you specified caused the problem to go away. -- ___ Python tracker

[issue38338] [2.7] test_ssl fails on RHEL8

2019-10-02 Thread STINNER Victor
Change by STINNER Victor : -- keywords: +patch pull_requests: +16128 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16539 ___ Python tracker ___ _

[issue38342] ImportError: cannot import name 'MetadataPathFinder' from 'importlib.metadata'

2019-10-02 Thread Batuhan
Batuhan added the comment: https://gitlab.com/python-devs/importlib_metadata/issues/92 -- nosy: +BTaskaya ___ Python tracker ___ __

[issue38348] Make python -m ast more configurable

2019-10-02 Thread Batuhan
New submission from Batuhan : Allow user to set indent level and parsing status of type comments -- components: Library (Lib) messages: 353741 nosy: BTaskaya, serhiy.storchaka priority: normal severity: normal status: open title: Make python -m ast more configurable versions: Python 3.9

[issue38348] Make python -m ast more configurable

2019-10-02 Thread Batuhan
Change by Batuhan : -- keywords: +patch pull_requests: +16129 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16540 ___ Python tracker ___

[issue38338] [2.7] test_ssl fails on RHEL8

2019-10-02 Thread STINNER Victor
STINNER Victor added the comment: New changeset b3e7045f8314e7b62cd95861d207fe2f97e47198 by Victor Stinner in branch 'master': bpo-38338, test.pythoninfo: add more ssl infos (GH-16539) https://github.com/python/cpython/commit/b3e7045f8314e7b62cd95861d207fe2f97e47198 --

[issue38338] [2.7] test_ssl fails on RHEL8

2019-10-02 Thread miss-islington
Change by miss-islington : -- pull_requests: +16131 pull_request: https://github.com/python/cpython/pull/16542 ___ Python tracker ___ __

[issue38338] [2.7] test_ssl fails on RHEL8

2019-10-02 Thread miss-islington
Change by miss-islington : -- pull_requests: +16130 pull_request: https://github.com/python/cpython/pull/16541 ___ Python tracker ___ __

[issue38349] Email example using imaginary library installation error. The install shows that it only supports python 2.x but is listed for python 3.6+

2019-10-02 Thread jackotonye
New submission from jackotonye : https://docs.python.org/3.7/library/email.examples.html -- assignee: docs@python components: Documentation messages: 353743 nosy: docs@python, jackotonye priority: normal severity: normal status: open title: Email example using imaginary library installa

[issue38349] Email example using imaginary library installation error. The install shows that it only supports python 2.x but is listed under python 3.6+ docs.

2019-10-02 Thread jackotonye
Change by jackotonye : -- title: Email example using imaginary library installation error. The install shows that it only supports python 2.x but is listed for python 3.6+ -> Email example using imaginary library installation error. The install shows that it only supports python 2.x

[issue38338] [2.7] test_ssl fails on RHEL8

2019-10-02 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +16132 pull_request: https://github.com/python/cpython/pull/16543 ___ Python tracker ___ __

[issue38338] [2.7] test_ssl fails on RHEL8

2019-10-02 Thread miss-islington
miss-islington added the comment: New changeset ab98cd8aee5a5a7222b82ff13d61f0d33e72a889 by Miss Islington (bot) in branch '3.7': bpo-38338, test.pythoninfo: add more ssl infos (GH-16539) https://github.com/python/cpython/commit/ab98cd8aee5a5a7222b82ff13d61f0d33e72a889 -- nosy: +mis

[issue38349] Email example using imaginary library installation error. The install shows that it only supports python 2.x but is listed under python 3.6+ docs.

2019-10-02 Thread SilentGhost
SilentGhost added the comment: imaginary in the example is not meant to refer to https://pypi.org/project/Imaginary/ it's meant to refer to a module that you could write that would do all the dirty work. Perhaps, it's not the best name to use provided there is an actual module on pypi, alter

[issue38350] ./configure --with-pydebug should use -O0 rather than -Og

2019-10-02 Thread STINNER Victor
New submission from STINNER Victor : In Python 2.7, when using ./configure --with-pydebug, Python is built using -O0 compiler optimization level: disable all optimizations. The comment is quite explicit: "Optimization messes up debuggers, so turn it off for debug builds". if test "$Py_DEBUG"

[issue38338] [2.7] test_ssl fails on RHEL8

2019-10-02 Thread STINNER Victor
STINNER Victor added the comment: New changeset 403ca7ea70232e520af18511fbfb89b58ef2a046 by Victor Stinner in branch '2.7': [2.7] bpo-38338, test.pythoninfo: add more ssl infos (GH-16543) https://github.com/python/cpython/commit/403ca7ea70232e520af18511fbfb89b58ef2a046 -- _

[issue38350] ./configure --with-pydebug should use -O0 rather than -Og

2019-10-02 Thread STINNER Victor
STINNER Victor added the comment: I basically propose to revert bpo-23445 change: commit 3d6c784371bccc2407048652bce50c5bccf9b1af Author: Antoine Pitrou Date: Wed Feb 11 19:39:16 2015 +0100 Issue #23445: pydebug builds now use "gcc -Og" where possible, to make the resulting executable

[issue38351] Modernize email example from %-formatting to f-string

2019-10-02 Thread Mariatta
New submission from Mariatta : A string was formatted with %s in the code example https://github.com/python/cpython/blob/b3e7045f8314e7b62cd95861d207fe2f97e47198/Doc/includes/email-simple.py#L15 ``` msg['Subject'] = 'The contents of %s' % textfile ``` It would be great to modernize that in

[issue38350] ./configure --with-pydebug should use -O0 rather than -Og

2019-10-02 Thread STINNER Victor
STINNER Victor added the comment: test_gdb is failing in different architectures and different operating systems: * Fedora, Python 3.8, x86-64: https://bugzilla.redhat.com/show_bug.cgi?id=1734327 * RHEL8, Python 3.6, s390x https://bugzilla.redhat.com/show_bug.cgi?id=1712977 * RHEL 8, Pyt

[issue38338] [2.7] test_ssl fails on RHEL8

2019-10-02 Thread miss-islington
miss-islington added the comment: New changeset 183733dfb6b4779d1a5e47f41a2fb86c6be08dda by Miss Islington (bot) in branch '3.8': bpo-38338, test.pythoninfo: add more ssl infos (GH-16539) https://github.com/python/cpython/commit/183733dfb6b4779d1a5e47f41a2fb86c6be08dda -- _

[issue38350] ./configure --with-pydebug should use -O0 rather than -Og

2019-10-02 Thread STINNER Victor
Change by STINNER Victor : -- keywords: +patch pull_requests: +16133 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16544 ___ Python tracker ___ _

[issue38342] ImportError: cannot import name 'MetadataPathFinder' from 'importlib.metadata'

2019-10-02 Thread Brett Cannon
Brett Cannon added the comment: Closing as not a bug as this seems to be an issue from installing over a b3 or earlier build where the importlib/metadata/ directory gets left behind and thus take priority in import over importlib/metadata.py. -- nosy: +brett.cannon resolution: -> no

[issue38350] ./configure --with-pydebug should use -O0 rather than -Og

2019-10-02 Thread STINNER Victor
STINNER Victor added the comment: My use case is to debug a crash using a Python compiled in debug module, like python3-debug program in Fedora. Since the debug ABI is now compatible with the release build, the idea is to attempt to reproduce a crash in gdb using python3-debug instead of pyt

[issue23445] Use -Og for debug builds

2019-10-02 Thread STINNER Victor
STINNER Victor added the comment: I created bpo-38350 to propose to revert this change. -- ___ Python tracker ___ ___ Python-bugs-l

[issue38349] Email example using imaginary library installation error. The install shows that it only supports python 2.x but is listed under python 3.6+ docs.

2019-10-02 Thread jackotonye
jackotonye added the comment: Might be best to make it a little more obvious since most examples are considered executable code. That would require little modification. On Wed, Oct 2, 2019 at 12:20 PM SilentGhost wrote: > > SilentGhost added the comment: > > imaginary in the example is not

[issue38344] activate.bat else needs to be on the same line as the if

2019-10-02 Thread Steve Dower
Steve Dower added the comment: Should be a straightforward fix (replace the "else" with "if not defined..."), but since it slipped through testing we probably want a regression test in test_venv as well. (+RM for the 3.8 regression) -- keywords: +3.8regression nosy: +lukasz.langa pr

[issue38351] Modernize email example from %-formatting to f-string

2019-10-02 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. added the comment: Does it make sense to change just one example? I'm not sure what the long-term stance is on whether %-formatting should be replaced at this point, but shouldn't this be a matter of which string formatting approach we want overall, rather than adjusting o

[issue38344] activate.bat else needs to be on the same line as the if

2019-10-02 Thread Steve Dower
Steve Dower added the comment: Adding this to the end of test_unicode_in_batch_file seems to be sufficient to cause the test to fail: self.assertEqual(err.strip(), '') Potentially we should add that additional check throughout this test module, but I don't think that's needed for a

[issue22214] Tkinter: Don't stringify callback arguments

2019-10-02 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +16134 pull_request: https://github.com/python/cpython/pull/16545 ___ Python tracker ___

[issue38335] simplify overlaps function in ipaddress.py

2019-10-02 Thread Sanjay
Change by Sanjay : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue22214] Tkinter: Don't stringify callback arguments

2019-10-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: PR 16545 solves the problem by using OS specific methods for converting between Python and Tcl strings. It is not ideal, but is good enough for most real cases. Now you can paste, copy and print non-BMP characters. The code containing them can be displayed

[issue22214] Tkinter: Don't stringify callback arguments

2019-10-02 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- versions: +Python 3.7, Python 3.8, Python 3.9 -Python 3.6 ___ Python tracker ___ ___ Python-bugs-lis

[issue22214] Tkinter: Don't stringify callback arguments

2019-10-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Oops, it is better to attach it to issue13153. -- ___ Python tracker ___ ___ Python-bugs-list m

[issue13153] IDLE 3.x on Windows exits when pasting non-BMP unicode

2019-10-02 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +16135 pull_request: https://github.com/python/cpython/pull/16545 ___ Python tracker ___

[issue13153] IDLE 3.x on Windows exits when pasting non-BMP unicode

2019-10-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: PR 16545 solves the problem by using OS specific methods for converting between Python and Tcl strings. It is not ideal, but is good enough for most real cases. Now you can paste, copy and print non-BMP characters. The code containing them can be displayed

[issue22214] Tkinter: Don't stringify callback arguments

2019-10-02 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- Removed message: https://bugs.python.org/msg353760 ___ Python tracker ___ ___ Python-bugs-list maili

[issue22214] Tkinter: Don't stringify callback arguments

2019-10-02 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- Removed message: https://bugs.python.org/msg353759 ___ Python tracker ___ ___ Python-bugs-list maili

[issue38351] Modernize email example from %-formatting to f-string

2019-10-02 Thread Mariatta
Mariatta added the comment: I think updating one isolated code example is less invasive and easier to review, instead of one big PR to change everything from "%s" to str.format or f-string. I brought up this example code merely because I happen to be reading this page. -- _

[issue38352] In typing docs, note explicit import needed for IO and Pattern/Match

2019-10-02 Thread Karl Kornel
New submission from Karl Kornel : Hello! In https://github.com/python/cpython/blob/master/Lib/typing.py#L115-L117, there is a note about the io and re classes not being included in typing.__all__. I am a relatively new user of typing, and I did `from typing import *` in my code. I ran the

[issue38344] activate.bat else needs to be on the same line as the if

2019-10-02 Thread Steve Dower
Steve Dower added the comment: Also adding Ned - this made it into 3.7 as well. -- nosy: +ned.deily versions: +Python 3.7 ___ Python tracker ___ __

[issue13153] IDLE 3.x on Windows exits when pasting non-BMP unicode

2019-10-02 Thread Tal Einat
Tal Einat added the comment: Serhiy, this looks like a great step in the right direction! Tested on Win10 with PR GH-16545 (commit f4db0e7e00). Here is a copy/paste from an IDLE shell session: >>> '\N{PERSONAL COMPUTER}' '💻' >>> print('💻') SyntaxError: 'utf-8' codec can't encode characters

[issue13153] IDLE 3.x on Windows exits when pasting non-BMP unicode

2019-10-02 Thread Tal Einat
Tal Einat added the comment: Not sure if this helps, but a bit of experimentation brought this up: >>> '\N{PERSONAL COMPUTER}'.encode('utf-8') b'\xf0\x9f\x92\xbb' >>> '💻'.encode('utf-16le') b'\xf0\x00\x9f\x00\x92\x00\xbb\x00' >>> '💻'.encode('utf-16') b'\xff\xfe\xf0\x00\x9f\x00\x92\x00\xbb

[issue13153] IDLE 3.x on Windows exits when pasting non-BMP unicode

2019-10-02 Thread Tal Einat
Tal Einat added the comment: More info: >>> '\N{PERSONAL COMPUTER}'.encode('utf-8').decode('latin-1') == '💻' True -- ___ Python tracker ___

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

2019-10-02 Thread David Bolen
David Bolen added the comment: Just an FYI that this change is generating warnings on my Windows 10 buildbot with some regularity about a failure to parse testperf output, such as: Warning -- Failed to parse typeperf output: '"10/01/2019 07:58:50.056"' from https://buildbot.python.org/all/#/

[issue13153] IDLE 3.x on Windows exits when pasting non-BMP unicode

2019-10-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Sorry, I did not test the last version on Windows. There was a bug which caused using the Linux version on Windows. Now it should be fixed. -- ___ Python tracker

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

2019-10-02 Thread STINNER Victor
STINNER Victor added the comment: > Just an FYI that this change is generating warnings on my Windows 10 buildbot > with some regularity about a failure to parse testperf output, such as: Warning -- Failed to parse typeperf output: '"10/01/2019 07:58:50.056"' Aha, interesting. I added a warn

[issue38014] Python 3.7 does not compile

2019-10-02 Thread Matej Cepl
Matej Cepl added the comment: Isn’t https://bugzilla.suse.com/1152793 (removal of stropts.h from glibc) cause of this? -- nosy: +mcepl ___ Python tracker ___ _

[issue38014] Python 3.7 does not compile

2019-10-02 Thread Matej Cepl
Matej Cepl added the comment: Sorry, got confused. My openSUSE bug has nothing to do with it. -- ___ Python tracker ___ ___ Python-

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

2019-10-02 Thread David Bolen
David Bolen added the comment: Oh, I agree it's just a warning, and I suspect few people look into warnings, but since it's not from an actual test, I'm not sure the overall build should be flagged. The manual typeperf looks fine, but there's no way I could tell visually how the I/O is bein

[issue38353] Cleanup the path configuration implementation code (getpath.c)

2019-10-02 Thread STINNER Victor
New submission from STINNER Victor : Place holder issue for changes related to path configuration cleanup changes (Modules/getpath.c). -- components: Interpreter Core messages: 353774 nosy: vstinner priority: normal severity: normal status: open title: Cleanup the path configuration im

[issue38353] Cleanup the path configuration implementation code (getpath.c)

2019-10-02 Thread STINNER Victor
Change by STINNER Victor : -- keywords: +patch pull_requests: +16136 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16548 ___ Python tracker ___ _

[issue38354] Fix for bug 30378 regressed SysLogHandler

2019-10-02 Thread Enji Cooper
New submission from Enji Cooper : The change made for bug 30378 caused a regression in our code by making lookups for SysLogHandler addresses at init time, instead of making them more lazy. Example: >>> import logging.handlers >>> LOGGER = logging.getLogger("logger") >>> LOGGER.addHandler(logg

[issue38354] Fix for bug 30378 regressed SysLogHandler by making it resolve addresses at initialization instead of in `.emit()`

2019-10-02 Thread Enji Cooper
Change by Enji Cooper : -- title: Fix for bug 30378 regressed SysLogHandler -> Fix for bug 30378 regressed SysLogHandler by making it resolve addresses at initialization instead of in `.emit()` ___ Python tracker

[issue38333] add type signatures to library function docs

2019-10-02 Thread paul rubin
paul rubin added the comment: Yes, the suggestion was just for the docs, and since those are intended for human rather than machine consumption, it's fine if there are some blurry cases where there is no signature. Ideally in those cases, the issue should be explained in the doc text. I ac

[issue38353] Cleanup the path configuration implementation code (getpath.c)

2019-10-02 Thread STINNER Victor
STINNER Victor added the comment: New changeset 61691d833631fed42b86605b09e1535e3e8d40e5 by Victor Stinner in branch 'master': bpo-38353: Cleanup includes in the internal C API (GH-16548) https://github.com/python/cpython/commit/61691d833631fed42b86605b09e1535e3e8d40e5 -- _

[issue38353] Cleanup the path configuration implementation code (getpath.c)

2019-10-02 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +16137 pull_request: https://github.com/python/cpython/pull/16549 ___ Python tracker ___ __

[issue38333] add type signatures to library function docs

2019-10-02 Thread Guido van Rossum
Guido van Rossum added the comment: @phr To be clear, I agree that there's nothing wrong with adding signatures to docs. We just need to find a way to do it. There will definitely be some cases where it's better not to have a type rather than trying to spell out the actual type in the docs.

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

2019-10-02 Thread David Bolen
David Bolen added the comment: I've confirmed the partial read with some local modifications, and the failures are always split between time stamp and value: Warning -- Failed to parse typeperf output: '"10/02/2019 17:42:26.229"' 0.0 Warning -- Missing first field: ,"0.00" 0.0 Adding mul

[issue38354] Fix for bug 30378 regressed SysLogHandler by making it resolve addresses at initialization instead of in `.emit()`

2019-10-02 Thread Enji Cooper
Enji Cooper added the comment: Capturing more context here, based on internal discussion: other handlers are doing address resolution in `emit()` (HTTPHandler, SMTPHandler), which is expensive. In order for SysLogHandler to not regress behavior and not become expensive, performance-wise, it

[issue37631] EXTRA_CFLAGS get overrided by CFLAGS_NODIST

2019-10-02 Thread Charalampos Stratakis
Charalampos Stratakis added the comment: Dug a bit further here. The issue is that CFLAGS_NODIST will always come after normal CFLAGS (which are subsets of PY_CFLAGS and PY_CFLAGS_NODIST) [0][1]. The EXTRA_CFLAGS variable is appended at the end of PY_CFLAGS [2], hence as reported here, what

[issue38355] ntpath.realpath() fails on sys.executable

2019-10-02 Thread Steve Dower
New submission from Steve Dower : The change to error handling did not include ERROR_CANT_ACCESS_FILE, but this error occurs in the Store package install. After suppressing this error, it then occurs again when stripping the prefix - we should just check for the same error here to determine w

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

2019-10-02 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +16138 pull_request: https://github.com/python/cpython/pull/16550 ___ Python tracker ___ __

[issue38355] ntpath.realpath() fails on sys.executable

2019-10-02 Thread Steve Dower
Change by Steve Dower : -- keywords: +patch pull_requests: +16139 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16551 ___ Python tracker ___

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

2019-10-02 Thread STINNER Victor
STINNER Victor added the comment: Ok, I managed to reproduce the bug using this change: diff --git a/Lib/test/libregrtest/win_utils.py b/Lib/test/libregrtest/win_utils.py index f0c17b906f..78429faa89 100644 --- a/Lib/test/libregrtest/win_utils.py +++ b/Lib/test/libregrtest/win_utils.py @@ -14

[issue38356] test_asyncio: SubprocessThreadedWatcherTests leaks threads

2019-10-02 Thread STINNER Victor
New submission from STINNER Victor : Warning seen o AMD64 Ubuntu Shared 3.x buildbot: https://buildbot.python.org/all/#/builders/141/builds/2593 test_devnull_output (test.test_a=syncio.test_subprocess.SubprocessThreadedWatcherTests) ... Warning -- threading_cleanup() failed to cleanup 1 thread

[issue38356] test_asyncio: SubprocessThreadedWatcherTests leaks threads

2019-10-02 Thread STINNER Victor
Change by STINNER Victor : -- nosy: +pablogsal ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue37631] EXTRA_CFLAGS get overrided by CFLAGS_NODIST

2019-10-02 Thread Charalampos Stratakis
Charalampos Stratakis added the comment: Also this is due to an expected behaviour from gcc. From the documentation: "If you use multiple -O options, with or without level numbers, the last such option is the one that is effective. " -- ___ Python

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

2019-10-02 Thread STINNER Victor
STINNER Victor added the comment: New changeset 3e04cd268ee9a57f95dc78d8974b21a6fac3f666 by Victor Stinner in branch 'master': bpo-36670, regrtest: Fix WindowsLoadTracker() for partial line (GH-16550) https://github.com/python/cpython/commit/3e04cd268ee9a57f95dc78d8974b21a6fac3f666

[issue38351] Modernize email example from %-formatting to f-string

2019-10-02 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. added the comment: I agree that it's less invasive and easier to review. My question (and it's just that) is whether we've made a decision to prefer one formatting syntax over others (outside of examples discussing the formatting approaches themselves). If a decision is m

[issue38318] Issues linking with ncurses and tinfo (cannot resolve symbols)

2019-10-02 Thread Michael Everitt
Michael Everitt added the comment: Attached patch seems to fix build failure for python2.7 with uclibc-ng. -- keywords: +patch Added file: https://bugs.python.org/file48639/fix-tinfo-probably-python-2_7.patch ___ Python tracker

[issue38318] Issues linking with ncurses and tinfo (cannot resolve symbols)

2019-10-02 Thread Michael Everitt
Michael Everitt added the comment: Attached patch seems to fix build with python3.6 withh uclibc-ng. Tested on x86_64 and ARMv6zk. -- Added file: https://bugs.python.org/file48640/fix-tinfo-probably-python-3_6.patch ___ Python tracker

[issue38351] Modernize email example from %-formatting to f-string

2019-10-02 Thread Kyle Stanley
Kyle Stanley added the comment: Welcome back from the OOOS break Mariatta! > My question (and it's just that) is whether we've made a decision to prefer > one formatting syntax over others (outside of examples discussing the > formatting approaches themselves). I agree that we should reach

[issue38351] Modernize email example from %-formatting to f-string

2019-10-02 Thread Kyle Stanley
Kyle Stanley added the comment: > so it would be a good candidate for the "newcomer friendly" label Never mind, just noticed this was already labeled as newcomer friendly. I only saw the "easy" label at first. (: If consensus is reached for this, we can open a separate issue for addressing

[issue38356] test_asyncio: SubprocessThreadedWatcherTests leaks threads

2019-10-02 Thread Kyle Stanley
Kyle Stanley added the comment: I can try to work on fixing this. -- nosy: +aeros167 ___ Python tracker ___ ___ Python-bugs-list ma

[issue19683] test_minidom has many empty tests

2019-10-02 Thread karl
karl added the comment: @zach.ware @r.david.murray So I was looking at that issue. There is a lot of work. I had a couple of questions, because there are different categories # Empty tests for existing functions. This seems to be straightforward as they would complete the module. Exampl

[issue38351] Modernize email example from %-formatting to f-string

2019-10-02 Thread Eric V. Smith
Eric V. Smith added the comment: I definitely think we should not modify any code in the stdlib just to switch to f-strings. I think the code examples in the docs would benefit from a consistent style, and since f-strings are the least verbose way to format strings, I'd endorse using them e

[issue38342] ImportError: cannot import name 'MetadataPathFinder' from 'importlib.metadata'

2019-10-02 Thread Dima Tisnek
Change by Dima Tisnek : -- nosy: +Dima.Tisnek ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue38350] ./configure --with-pydebug should use -O0 rather than -Og

2019-10-02 Thread Charalampos Stratakis
Charalampos Stratakis added the comment: Do note though that if the -D_FORTIFY_SOURCE=2 hardening flag is used, the compilation will fail with an optimization level less than -Og. Haven't tried yet with -D_FORTIFY_SOURCE=1 to see if it works with -O0. -- nosy: +cstratak

[issue38357] print adding extra bytes in hex above x7F

2019-10-02 Thread Artificial
New submission from Artificial : Any hex str of value above \x7F causes an extra byte to printed. -- files: Screenshot from 2019-10-02 20-31-50.png messages: 353796 nosy: Artificial priority: normal severity: normal status: open title: print adding extra bytes in hex above x7F type: beh

[issue38351] Modernize email example from %-formatting to f-string

2019-10-02 Thread Kyle Stanley
Kyle Stanley added the comment: > I definitely think we should not modify any code in the stdlib just to switch > to f-strings. Does this also apply to updating code to use f-strings in an area that's already being modified for a functional purpose? I agree that that we shouldn't update st

[issue38350] ./configure --with-pydebug should use -O0 rather than -Og

2019-10-02 Thread Charalampos Stratakis
Charalampos Stratakis added the comment: Correction, not fail, just a ton of warnings. The same is true for -D_FORTIFY_SOURCE=1 -- ___ Python tracker ___

  1   2   >