[issue37366] Add an "onitem" callback parameter to shutil.rmtree()

Jeffrey Kintscher added the comment: Yes, onerror allows you to delete an undeletable item. But, in the case of a mount point, the contents of the mounted filesystem get deleted *before* the mount point triggers onerror. This is the case described in issue #36422. The behavior provided by

[issue37366] Add an "onitem" callback parameter to shutil.rmtree()

Christian Heimes added the comment: I'm with Giampaolo. I'm also concerned that the new callback will make the rmtree function too complicated. It's not a one-size-fits-all solution, but it covers most uses cases. -- nosy: +christian.heimes versions: -Python 3.7, Python 3.8 __

[issue36956] Calling "functions" used to implement generators/comps easily cause crash

Jeffrey Kintscher added the comment: What is the preferred behavior? Raise an exception of some kind? -- ___ Python tracker ___ ___

[issue36956] Calling "functions" used to implement generators/comps easily cause crash

Jeffrey Kintscher added the comment: Specifically, the crash occurs in Python/ceval.c function _PyEval_EvalFrameDefault() in the TARGET(FOR_ITER) case at line 3198 (master branch): PyObject *next = (*iter->ob_type->tp_iternext)(iter); It segfaults because tp_iternext is NULL. -- _

[issue36956] Calling "functions" used to implement generators/comps easily cause crash

Raymond Hettinger added the comment: ISTM this report is close to that covered by the traditional stance that word code hacks aren't protected from crashes because trying to do can be complicated, can be expensive, and isn't always possible. I'm not really sure where this falls on the grey

[issue37432] Fix a small param type in allocation.rst

Change by miss-islington : -- pull_requests: +14257 pull_request: https://github.com/python/cpython/pull/14441 ___ Python tracker ___ __

[issue37432] Fix a small param type in allocation.rst

Inada Naoki added the comment: New changeset b4bee03087a3c70cb040e2ce569c828860ed8e87 by Inada Naoki (Hai Shi) in branch 'master': bpo-37432: Doc: Fix signature of PyObject_Del() (GH-14430) https://github.com/python/cpython/commit/b4bee03087a3c70cb040e2ce569c828860ed8e87 -- nosy: +i

[issue37432] Fix a small param type in allocation.rst

Change by miss-islington : -- pull_requests: +14258 pull_request: https://github.com/python/cpython/pull/14442 ___ Python tracker ___ __

[issue37432] Fix a small param type in allocation.rst

miss-islington added the comment: New changeset 99f2f851773c6e481e80e8e157d9f5ad4fc5cbb3 by Miss Islington (bot) in branch '3.7': bpo-37432: Doc: Fix signature of PyObject_Del() (GH-14430) https://github.com/python/cpython/commit/99f2f851773c6e481e80e8e157d9f5ad4fc5cbb3 -- nosy: +mi

[issue37432] Fix a small param type in allocation.rst

miss-islington added the comment: New changeset ad00640f936956c3a19834b6cd12b04edf53a776 by Miss Islington (bot) in branch '3.8': bpo-37432: Doc: Fix signature of PyObject_Del() (GH-14430) https://github.com/python/cpython/commit/ad00640f936956c3a19834b6cd12b04edf53a776 --

[issue37438] ConfigParser.set() docs should mention allow_no_value

New submission from Nick Coghlan : Reviewing some code today, I came across a ConfigParser.set() call that only specified the section and key, with the value argument missing. If you look at the ConfigParser.set() docs, this seems like incorrect code, as those docs indicate that the value arg

[issue34022] 6 tests fail using SOURCE_DATE_EPOCH env var

STINNER Victor added the comment: > With this change, only 3 tests fail on 3.7, and all these 3 fail because of > zipimport: test_cmd_line_script, test_multiprocessing_main_handling and > test_runpy. These tests were fixed by: commit a6e956bcb0edbfe7f18af9be2215a5326ea6bf05 Author: Elvis Pr

[issue37439] Add random.binomialvariate()

New submission from Raymond Hettinger : This a small snippet of code I written dozens of times. It would be nice to have this in the library along with the other distributions. def binomialvariate(n, p): ''' Binomial distribution for the number of successes in *n* Bernoulli trials

[issue37432] Fix a small param type in allocation.rst

Change by hai shi : -- stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue37337] Add _PyObject_VectorcallMethod() function

Inada Naoki added the comment: New changeset b1263d5a60d3f7ab02dd28409fff59b3815a3f67 by Inada Naoki (Jeroen Demeyer) in branch 'master': bpo-37337: Add _PyObject_VectorcallMethod() (GH-14228) https://github.com/python/cpython/commit/b1263d5a60d3f7ab02dd28409fff59b3815a3f67 --

[issue37439] Add random.binomialvariate()

Raymond Hettinger added the comment: Instead of a O(n) simulation, an O(1) equivalent should be used. -- ___ Python tracker ___ ___

[issue37335] Fix unexpected ASCII aliases in locale coercion tests.

Change by Jakub Kulik : -- title: Add 646 ASCII alias to locale coercion tests. -> Fix unexpected ASCII aliases in locale coercion tests. ___ Python tracker ___ __

[issue37335] Fix unexpected ASCII aliases in locale coercion tests.

Change by Jakub Kulik : -- pull_requests: +14259 pull_request: https://github.com/python/cpython/pull/14443 ___ Python tracker ___ _

[issue36763] Implementation of the PEP 587

Change by STINNER Victor : -- pull_requests: +14260 pull_request: https://github.com/python/cpython/pull/1 ___ Python tracker ___ __

[issue36763] Implementation of the PEP 587

Change by STINNER Victor : -- pull_requests: +14261 pull_request: https://github.com/python/cpython/pull/14445 ___ Python tracker ___ __

[issue37428] SSLContext.post_handshake_auth implicitly enables cert validation

Christian Heimes added the comment: This issue breaks some stuff at work. I would appreciate if we can get the fix into 3.7.4. I wasn't aware that we are so close to cut-off to 3.7.4 release. What does the fix do? I moved all PHA related flags / options from SSL_CTX* to SSL*. The flags and

[issue37428] SSLContext.post_handshake_auth implicitly enables cert validation

Ned Deily added the comment: "Assuming no critical problems are found prior to 2019-06-28, no code changes are planned between these release candidates and the final releases." We were planning to start producing the final release artifacts in a couple of hours so we need to make a decision

[issue20443] __code__. co_filename should always be an absolute path

Change by STINNER Victor : -- pull_requests: +14262 pull_request: https://github.com/python/cpython/pull/14446 ___ Python tracker ___ __

[issue37432] Fix a small param type in allocation.rst

Change by SilentGhost : -- resolution: -> fixed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue37432] Fix a small param type in allocation.rst

Change by SilentGhost : -- versions: +Python 3.7, Python 3.8, Python 3.9 ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue37440] httplib should enable post-handshake authentication for TLS 1.3

New submission from Christian Heimes : httplib.client does not enable post-handshake authentication for TLS 1.3 connections. PHA is necessary for TLS 1.3 connections to servers that have conditional client cert authentication. For example Apache mod_ssl uses PHA when only certain paths or req

[issue37335] Improve encoding alias handling in locale coercion tests

Jakub Kulik added the comment: Python 3.8+ encodings are always normalized and thus no output variations handling is necessary (the code is no longer necessary). Python 3.7 (and possibly lower) can have variations in encodings - that should be fixed with codecs.lookup functions. --

[issue37335] Improve encoding alias handling in locale coercion tests

Change by Jakub Kulik : -- pull_requests: +14263 pull_request: https://github.com/python/cpython/pull/14447 ___ Python tracker ___ _

[issue37440] httplib should enable post-handshake authentication for TLS 1.3

Change by Christian Heimes : -- dependencies: +SSLContext.post_handshake_auth implicitly enables cert validation ___ Python tracker ___

[issue37337] Add _PyObject_VectorcallMethod() function

Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue24214] UTF-8 incremental decoder doesn't support surrogatepass correctly

Ned Deily added the comment: Since the latest fix (GH-14369) addresses a regression between 3.7.3 and 3.7.4rc1, I am going to cherry-pick it into 3.7.4 final. (In retrospect, this regression should have been marked as a "release blocker".) -- nosy: +ned.deily __

[issue37440] httplib should enable post-handshake authentication for TLS 1.3

Change by Christian Heimes : -- keywords: +patch pull_requests: +14264 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14448 ___ Python tracker ___

[issue20443] __code__. co_filename should always be an absolute path

STINNER Victor added the comment: New changeset 3029035ef34c9bae0c8d965290cd9b273c8de1ea by Victor Stinner in branch 'master': bpo-20443: Fix calculate_program_full_path() warning (GH-14446) https://github.com/python/cpython/commit/3029035ef34c9bae0c8d965290cd9b273c8de1ea -- __

[issue37428] SSLContext.post_handshake_auth implicitly enables cert validation

Christian Heimes added the comment: There are currently two issues with TLS 1.3 in Python. The issue https://bugs.python.org/issue37440 can be worked around easily with a custom SSLContext. This issue is a bigger problem because there is no possible workaround. The bug is going to break app

[issue37335] Improve encoding alias handling in locale coercion tests

Change by Jakub Kulik : -- pull_requests: +14265 pull_request: https://github.com/python/cpython/pull/14449 ___ Python tracker ___ _

[issue37439] Add random.binomialvariate()

Change by Raymond Hettinger : -- Removed message: https://bugs.python.org/msg346817 ___ Python tracker ___ ___ Python-bugs-list mail

[issue37369] Issue with pip in venv on Powershell in Windows

Change by Steve Dower : -- pull_requests: +14266 pull_request: https://github.com/python/cpython/pull/14450 ___ Python tracker ___ _

[issue37412] os.getcwdb() doesn't implement PEP 528 (UTF-8) on Windows

Change by miss-islington : -- pull_requests: +14267 pull_request: https://github.com/python/cpython/pull/14451 ___ Python tracker ___ __

[issue37412] os.getcwdb() doesn't implement PEP 528 (UTF-8) on Windows

STINNER Victor added the comment: New changeset ec3e20a2d1edddb0558f9d32e2b367904ccdde88 by Victor Stinner in branch 'master': bpo-37412: Fix os.getcwd() for long path on Windows (GH-14424) https://github.com/python/cpython/commit/ec3e20a2d1edddb0558f9d32e2b367904ccdde88 -- ___

[issue37412] os.getcwdb() doesn't implement PEP 528 (UTF-8) on Windows

STINNER Victor added the comment: New changeset 64580da33122a10aef75c76aa3ff87c0ee11e3d7 by Victor Stinner in branch 'master': bpo-37412: pythoninfo: add Windows long paths (GH-14434) https://github.com/python/cpython/commit/64580da33122a10aef75c76aa3ff87c0ee11e3d7 -- _

[issue37380] subprocess.Popen._cleanup() "The handle is invalid" error when some old process is gone

STINNER Victor added the comment: New changeset 042821ae3cf537e01963c9ec85d1a454d921e826 by Victor Stinner (Ruslan Kuprieiev) in branch 'master': bpo-37380: subprocess: don't use _active on win (GH-14360) https://github.com/python/cpython/commit/042821ae3cf537e01963c9ec85d1a454d921e826

[issue37380] subprocess.Popen._cleanup() "The handle is invalid" error when some old process is gone

STINNER Victor added the comment: I merged PR 14360 into master. Are Python 2.7, 3.7 and 3.8 impacted by the bug as well? Should we backport the change, or would it be too dangerous? -- ___ Python tracker _

[issue37329] [2.7] valgrind python2 -m test.regrtest test___all__: definitely lost: 324 bytes in 2 blocks

STINNER Victor added the comment: New changeset 065aff3c518a641e7a734a5b93f9ebed1b405c49 by Victor Stinner in branch '2.7': [2.7] bpo-37329: valgrind: ignore _PyWarnings_Init false alarms (GH-14202) https://github.com/python/cpython/commit/065aff3c518a641e7a734a5b93f9ebed1b405c49 --

[issue37329] [2.7] valgrind python2 -m test.regrtest test___all__: definitely lost: 324 bytes in 2 blocks

STINNER Victor added the comment: I confirm that my fix works with this manual test. I get "definitely lost: 0 bytes in 0 blocks" as expected: $ valgrind --suppressions=Misc/valgrind-python.supp ./python -m test.regrtest test___all__ (...) ==23782== LEAK SUMMARY: ==23782==definitely lost

[issue30345] test_gdb fails on Python 3.6 when built with LTO+PGO

STINNER Victor added the comment: I'm fine with relying on buildbots for test_gdb on Python 3.7 and older. Thanks for the fixes. -- ___ Python tracker ___ ___

[issue37412] os.getcwdb() doesn't implement PEP 528 (UTF-8) on Windows

STINNER Victor added the comment: New changeset 68c1c398f3534af16309a86ab815b61d2487e6db by Victor Stinner (Miss Islington (bot)) in branch '3.8': bpo-37412: Fix os.getcwd() for long path on Windows (GH-14424) (GH-14451) https://github.com/python/cpython/commit/68c1c398f3534af16309a86ab815b61

[issue37412] os.getcwdb() doesn't implement PEP 528 (UTF-8) on Windows

STINNER Victor added the comment: Ok, the regression should now be fixed and test_os now also tests os.getcwd() with a "long path" :-) Thank a lot Eryk Sun for your great advices on reviews! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed _

[issue37208] Weird exception behaviour in ProcessPoolExecutor

Change by F. Raab : -- nosy: +raabf ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/m

[issue37412] os.getcwdb() doesn't implement PEP 528 (UTF-8) on Windows

Change by STINNER Victor : -- pull_requests: +14268 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/14452 ___ Python tracker ___ __

[issue37412] os.getcwdb() doesn't implement PEP 528 (UTF-8) on Windows

STINNER Victor added the comment: Oh. Now the test fails on macOS: https://buildbot.python.org/all/#/builders/145/builds/2021 == FAIL: test_getcwd_long_path (test.test_os.MiscTests)

[issue37412] os.getcwdb() doesn't implement PEP 528 (UTF-8) on Windows

STINNER Victor added the comment: Fail on FreeBSD as well: https://buildbot.python.org/all/#/builders/168/builds/1222 == FAIL: test_getcwd_long_path (test.test_os.MiscTests) ---

[issue37287] picke cannot dump Exception subclasses with different super() args

Change by Fabian Raab : -- nosy: +raabf ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.o

[issue37441] Fix a param error in exceptions.rst

New submission from hai shi : Due to https://github.com/python/cpython/blob/master/Python/errors.c#L845-L846, `PyObject* PyErr_SetImportErrorSubclass(PyObject *msg, PyObject *name, PyObject *path)` should be `PyObject* PyErr_SetImportErrorSubclass(PyObject *exception, PyObject *msg, PyObject

[issue37411] testEnviron (test.test_wsgiref.HandlerTests) fails when environment variable X is set

Change by hai shi : -- pull_requests: +14269 pull_request: https://github.com/python/cpython/pull/14453 ___ Python tracker ___ ___ P

[issue37369] Issue with pip in venv on Powershell in Windows

Steve Dower added the comment: New changeset db4d7ddb012ef8f087a8eb2a5b8a672d04a48e1a by Steve Dower in branch '3.7': bpo-37369: Fixes path for sys.executable when running from the Microsoft Store (GH-14450) https://github.com/python/cpython/commit/db4d7ddb012ef8f087a8eb2a5b8a672d04a48e1a

[issue37441] Fix a param error in exceptions.rst

Change by hai shi : -- keywords: +patch pull_requests: +14270 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14453 ___ Python tracker ___

[issue37411] testEnviron (test.test_wsgiref.HandlerTests) fails when environment variable X is set

Change by Karthikeyan Singaravelan : -- pull_requests: -14269 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue24214] UTF-8 incremental decoder doesn't support surrogatepass correctly

Karthikeyan Singaravelan added the comment: Thanks Ned, is there a general policy on regressions to be marked as release blocker, like if a regression that was made in 3.7.3 then it acts as a release blocker for 3.7.4 or is it based on severity? ? --

[issue24214] UTF-8 incremental decoder doesn't support surrogatepass correctly

Ned Deily added the comment: "The only changes allowed to occur in a maintenance branch without debate are bug fixes. Also, a general rule for maintenance branches is that compatibility must not be broken at any point between sibling minor releases (3.5.1, 3.5.2, etc.). For both rules, only

[issue37166] inspect.findsource doesn't handle shortened files gracefully

Michael Bejda added the comment: I do not believe it is specific to the way we package things: $ cat a.py: import inspect def foo(): pass inspect.getsource(foo) $ python3 -m compileall -b a.py $ black a.py # to remove the empty lines $ python3 a.pyc # Index error Traceback (most rec

[issue23014] Don't have importlib.abc.Loader.create_module() be optional

Brett Cannon added the comment: Do realize the person who created and closed this issue is the one suggesting you open a new issue. ;) We can re-evaluate decisions and this one is 5 years old. Now I'm not making any promises that we will definitely change anything, but I'm not going to swoop

[issue24214] UTF-8 incremental decoder doesn't support surrogatepass correctly

Karthikeyan Singaravelan added the comment: Thanks Ned for the details, in future reports I will also try to add the respective release manager to the issue in case of regressions. -- ___ Python tracker ___

[issue37412] os.getcwdb() doesn't implement PEP 528 (UTF-8) on Windows

STINNER Victor added the comment: New changeset 29f609ed07aa7856741ff8b8b8b050369d0faf81 by Victor Stinner in branch 'master': bpo-37412: Fix test_os.test_getcwd_long_path() on macOS (GH-14452) https://github.com/python/cpython/commit/29f609ed07aa7856741ff8b8b8b050369d0faf81 -- ___

[issue24214] UTF-8 incremental decoder doesn't support surrogatepass correctly

Ned Deily added the comment: @xtreak, If you set the priority to "release blocker", the appropriate release managers will be nosied automatically. I'd rather see too many potential "release blocker"s than too few. -- ___ Python tracker

[issue37166] inspect.findsource doesn't handle shortened files gracefully

Michael Bejda added the comment: I don't think linecache.checkcache helps here. In your example, it would detect the modification, but I don't see how it could persist data if the compilation and execution are different processes. -- ___ Python tr

[issue37412] os.getcwdb() doesn't implement PEP 528 (UTF-8) on Windows

Change by miss-islington : -- pull_requests: +14271 pull_request: https://github.com/python/cpython/pull/14454 ___ Python tracker ___ __

[issue17239] XML vulnerabilities in Python

Change by Mitar : -- nosy: +mitar ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mai

[issue37438] ConfigParser.set() docs should mention allow_no_value

Change by Prateek Nayak : -- keywords: +patch pull_requests: +14272 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/14455 ___ Python tracker ___

[issue37369] Issue with pip in venv on Powershell in Windows

Change by Steve Dower : -- pull_requests: +14273 pull_request: https://github.com/python/cpython/pull/14456 ___ Python tracker ___ _

[issue37404] asyncio sock_recv blocks on ssl sockets.

Change by Akshay Takkar : -- keywords: +patch pull_requests: +14274 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14457 ___ Python tracker ___ __

[issue37442] Minidom should not pretty-print inside text elements

New submission from Mitar : Inside text elements both in HTML and SVG white-space is significant and introduces differences in how things are rendered. By default in general all white-space is collapsed into one space and then this is rendered, adding additional text content. I observed this

[issue37412] os.getcwdb() doesn't implement PEP 528 (UTF-8) on Windows

miss-islington added the comment: New changeset e3761ca91cda86462206d60244078f05c636dd13 by Miss Islington (bot) in branch '3.8': bpo-37412: Fix test_os.test_getcwd_long_path() on macOS (GH-14452) https://github.com/python/cpython/commit/e3761ca91cda86462206d60244078f05c636dd13 --

[issue37437] update vendorized expat to 2.2.7

Ned Deily added the comment: The expat update introduces unsightly build warnings: gcc -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3 -Wall -std=c99 -Wextra -Wno-unused-result -Wno-unused-parameter -Wno-missing-field-initializers -Wstrict-prototypes -Werror=imp

[issue37208] Weird exception behaviour in ProcessPoolExecutor

Change by Brian Quinlan : -- stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue37369] Issue with pip in venv on Powershell in Windows

Steve Dower added the comment: New changeset ed4657bd28432ace671a9e6ae38a3d485c69213d by Steve Dower in branch '3.7': bpo-37369: Fix venv and test symlinking (GH-14456) https://github.com/python/cpython/commit/ed4657bd28432ace671a9e6ae38a3d485c69213d --

[issue37294] concurrent.futures.ProcessPoolExecutor and multiprocessing.pool.Pool fail with super

Change by Brian Quinlan : -- resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> function changed when pickle bound method object ___ Python tracker __

[issue31783] Race condition in ThreadPoolExecutor when scheduling new jobs while the interpreter shuts down

Brian Quinlan added the comment: New changeset 242c26f53edb965e9808dd918089e664c0223407 by Brian Quinlan in branch 'master': bpo-31783: Fix a race condition creating workers during shutdown (#13171) https://github.com/python/cpython/commit/242c26f53edb965e9808dd918089e664c0223407 --

[issue31783] Race condition in ThreadPoolExecutor when scheduling new jobs while the interpreter shuts down

Change by Brian Quinlan : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue37403] Recommend .venv for virtual environment names

Change by Brett Cannon : -- keywords: +patch pull_requests: +14275 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/14458 ___ Python tracker

[issue37443] Python Returns NoneType when convert a string to a list and using sort() method

New submission from exploiterv : Python Returns NoneType when convert a string to a list and using sort() method # Example Code : >>> string = "python" >>> new_list = list(string.splitlines()) >>> new_list ['python'] >>> type(new_list) >>> print(type(new_list.sort()))

[issue37403] Recommend .venv for virtual environment names

Brett Cannon added the comment: New changeset f9f8e3ce709ceb15c8db8c8dde940daf1febf13d by Brett Cannon in branch 'master': bpo-37403: Touch up venv docs (GH-14458) https://github.com/python/cpython/commit/f9f8e3ce709ceb15c8db8c8dde940daf1febf13d -- _

[issue37403] Recommend .venv for virtual environment names

Change by miss-islington : -- pull_requests: +14276 pull_request: https://github.com/python/cpython/pull/14459 ___ Python tracker ___ __

[issue37443] Python Returns NoneType when convert a string to a list and using sort() method

SilentGhost added the comment: Yes, as documented .sort method mutates object in place and returns None. -- assignee: terry.reedy -> components: -IDLE nosy: +SilentGhost -terry.reedy resolution: -> not a bug stage: -> resolved status: open -> closed type: compile error -> behavior

[issue37443] Python Returns NoneType when convert a string to a list and using sort() method

Isaul Vargas added the comment: There is no bug. It's a bit confusing that the method sort on a list object returns None, but it is doing an in-place, (in memory) sort of the list, thus modifying the list. The function sorted however, will return a new list object. The following interpreter

[issue37409] relative import without parent

Change by Brett Cannon : -- versions: +Python 3.8, Python 3.9 -Python 3.7 ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue37443] Python Returns NoneType when convert a string to a list and using sort() method

Change by SilentGhost : -- assignee: terry.reedy -> components: -IDLE nosy: +SilentGhost -terry.reedy type: compile error -> behavior ___ Python tracker ___ _

[issue37444] Differing exception between builtins and importlib when importing beyond top-level package

New submission from Brett Cannon : builtins.__import__() raises ValueError (as it did in Python 2.7) while importlib.__import__() raises ImportError (which makes more sense to me). Found by Ben Lewis. -- components: Interpreter Core, Library (Lib) messages: 346855 nosy: Ben Lewis2, br

[issue37409] relative import without parent

Brett Cannon added the comment: I opened bpo-37444 for the relative import beyond top-level package issue. -- ___ Python tracker ___ __

[issue37409] relative import without parent

Brett Cannon added the comment: The code doing the sanity check for importlib can be found at https://github.com/python/cpython/blob/f9f8e3ce709ceb15c8db8c8dde940daf1febf13d/Lib/importlib/_bootstrap.py#L943-L948 . -- ___ Python tracker

[issue37444] Differing exception between builtins and importlib when importing beyond top-level package

Brett Cannon added the comment: Importllib code raising the exception is https://github.com/python/cpython/blob/f9f8e3ce709ceb15c8db8c8dde940daf1febf13d/Lib/importlib/_bootstrap.py#L874-L876 . -- ___ Python tracker

[issue37444] Differing exception between builtins and importlib when importing beyond top-level package

Brett Cannon added the comment: I think this should be an ImportError and so that means builtins.__import__() is wrong. Anyone want to argue for the other side? -- ___ Python tracker ___

[issue37409] relative import without parent succeeds with builtins.__import__

Change by Brett Cannon : -- title: relative import without parent -> relative import without parent succeeds with builtins.__import__ ___ Python tracker ___ __

[issue37444] Differing exception between builtins and importlib when importing beyond top-level package

Brett Cannon added the comment: import.c code raising the exception: https://github.com/python/cpython/blob/f9f8e3ce709ceb15c8db8c8dde940daf1febf13d/Python/import.c#L1675-L1677 -- ___ Python tracker ___

[issue37409] relative import without parent succeeds with builtins.__import__

Change by Serhiy Storchaka : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https

[issue37444] Differing exception between builtins and importlib when importing beyond top-level package

Change by Serhiy Storchaka : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https

[issue37409] relative import without parent succeeds with builtins.__import__

Brett Cannon added the comment: If you run with `-Xdev`/warnings turned on you get an idea of what's happening: >>> builtins.__import__('', globals(), locals(), ('foo',), 1) :1: ImportWarning: can't resolve package from __spec__ or __package__, falling back on __name__ and __path__ The chec

[issue37403] Recommend .venv for virtual environment names

miss-islington added the comment: New changeset 0cba121029bae0a891b02c493cb77633620701be by Miss Islington (bot) in branch '3.8': bpo-37403: Touch up venv docs (GH-14458) https://github.com/python/cpython/commit/0cba121029bae0a891b02c493cb77633620701be -- nosy: +miss-islington

[issue37403] Recommend .venv for virtual environment names

Change by Brett Cannon : -- resolution: -> fixed stage: patch review -> needs patch status: open -> closed ___ Python tracker ___ _

[issue19696] Merge all (non-syntactic) import-related tests into test_importlib

miss-islington added the comment: New changeset 80097e089ba22a42d804e65fbbcf35e5e49eed00 by Miss Islington (bot) (Kyle Stanley) in branch 'master': bpo-19696: Moved "test_pkgimport.py" to dir "test_importlib" (GH-14303) https://github.com/python/cpython/commit/80097e089ba22a42d804e65fbbcf35e5

[issue19696] Merge all (non-syntactic) import-related tests into test_importlib

Brett Cannon added the comment: Thanks for the PR, aeros167! BTW, if you want to open a new issue and modernize the tests to use importlib directly that would be great! -- ___ Python tracker ___

  1   2   >