[issue36348] test_imaplib.RemoteIMAP_STARTTLSTest.test_logout() fails randomly

2019-03-18 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Seems it used to fail randomly in past too : issue30648 -- components: +email nosy: +barry, r.david.murray, xtreak ___ Python tracker _

[issue36349] Including parentheses in a regular expression pattern enclosed by literal square bracket characters cause the square brackets not to be matched

2019-03-18 Thread Stéphane Wirtel
Stéphane Wirtel added the comment: 3.6 is in security mode and not in bugfix mode. Please, use 3.7. -- nosy: +matrixise resolution: -> out of date stage: -> resolved status: open -> closed ___ Python tracker _

[issue36349] Including parentheses in a regular expression pattern enclosed by literal square bracket characters cause the square brackets not to be matched

2019-03-18 Thread Stéphane Wirtel
Stéphane Wirtel added the comment: Python 3.7.2 (default, Jan 16 2019, 19:49:22) [GCC 8.2.1 20181215 (Red Hat 8.2.1-6)] on linux Type "help", "copyright", "credits" or "license" for more information. >>> import re >>> s = '[a]' >>> print(*re.findall(r'\[.*]', s)) [a] >>> print(*re.findall(r'\[.

[issue36348] test_imaplib.RemoteIMAP_STARTTLSTest.test_logout() fails randomly

2019-03-18 Thread STINNER Victor
Change by STINNER Victor : -- keywords: +patch pull_requests: +12365 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-

[issue36350] inspect.Signature.parameters and inspect.BoundArguments.arguments should be dicts instead of OrderedDicts

2019-03-18 Thread Rémi Lapeyre
New submission from Rémi Lapeyre : Python 3.7.2 (default, Feb 12 2019, 08:15:36) [Clang 10.0.0 (clang-1000.11.45.5)] on darwin Type "help", "copyright", "credits" or "license" for more information. >>> import inspect >>> inspect.Signature().parameters mappingproxy(OrderedDict()) >>> def foo(a):

[issue36350] inspect.Signature.parameters and inspect.BoundArguments.arguments should be dicts instead of OrderedDicts

2019-03-18 Thread Rémi Lapeyre
Change by Rémi Lapeyre : -- keywords: +patch pull_requests: +12366 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-lis

[issue36349] Including parentheses in a regular expression pattern enclosed by literal square bracket characters cause the square brackets not to be matched

2019-03-18 Thread SilentGhost
SilentGhost added the comment: Fabrod, this has nothing to do with the square brackets. It is your assumption that the return value should be the same that is wrong. Cf.: >>> re.findall(r'a.+', 'abc') ['abc'] >>> re.findall(r'a(.+)', 'abc') ['bc'] This is the correct documented behaviour. -

[issue36350] inspect.Signature.parameters and inspect.BoundArguments.arguments should be dicts instead of OrderedDicts

2019-03-18 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +yselivanov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: htt

[issue36342] test_venv fails on Android with clang

2019-03-18 Thread Xavier de Gaye
Xavier de Gaye added the comment: Too hasty again, remembering now why I linked this failure with sem_open :-( Re-opening this issue as the test does fail because Android lacks a functioning sem_open implementation. And tagging this issue as a dependency of bpo-35978 as we should wait for th

[issue36304] When using bz2 and lzma in mode 'wt', the BOM is not written

2019-03-18 Thread Gianluca
Gianluca added the comment: In case the file is not seekable, we could decide based on the file mode: - if mode='w', write the BOM - if mode='a', don't write the BOM Of course, mode "a" doesn't guarantee we are in the middle of the file, but it seems a consistent behavior not writing the BOM

[issue36010] Please provide a .zip Windows release of Python that is not crippled/for embedding only

2019-03-18 Thread Steve Dower
Steve Dower added the comment: The change in the PR should be all that's necessary - the props file you are referring to is for end-users to integrate a Python build into their application (where I still assume they don't want venvs, and if they do there's already a property there to include

[issue36348] test_imaplib.RemoteIMAP_STARTTLSTest.test_logout() fails randomly

2019-03-18 Thread STINNER Victor
STINNER Victor added the comment: > Seems it used to fail randomly in past too : issue30648 Well, test_logout() fails randomly every 6 months, but when it fails: we have zero info about the bug. The "NO" in the error means that an exception has been raised and the server didn't reply to the

[issue36320] typing.NamedTuple to switch from OrderedDict to regular dict

2019-03-18 Thread Josh Rosenberg
Josh Rosenberg added the comment: Would it make sense to convert _field_types to a property, so the method(s) that implement the property can do: warnings.warn("_field_types is deprecated; use __annotations__ instead", DeprecationWarning) to indicate the deprecation programmatically, not ju

[issue36348] test_imaplib.RemoteIMAP_STARTTLSTest.test_logout() fails randomly

2019-03-18 Thread STINNER Victor
STINNER Victor added the comment: > https://buildbot.python.org/all/#/builders/21/builds/2512 It's s390x RHEL 3.x. -- ___ Python tracker ___ _

[issue36010] Please provide a .zip Windows release of Python that is not crippled/for embedding only

2019-03-18 Thread Paul Moore
Paul Moore added the comment: I ran Tools/nuget/build.bat manually, and the resulting file didn't have lib\venv in it (I opened it in 7-zip, I don't know how to install a local nuget file...). Could you build the nuget files and check? Or suggest a better way I can check that the change has

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

2019-03-18 Thread Julien Palard
Change by Julien Palard : -- pull_requests: +12367 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue36345] Deprecate Tools/scripts/serve.py in favour of python -m http.server -d

2019-03-18 Thread STINNER Victor
STINNER Victor added the comment: I'm ok with modifying "make server" to reuse http.server, but I'm not sure about deprecating Tools/scripts/serve.py. serve.py uses wsgiref which is different than http.server. Does anyone use it? I would prefer to keep it. If you want to remove it, please se

[issue34160] ElementTree not preserving attribute order

2019-03-18 Thread Stéphane Wirtel
Stéphane Wirtel added the comment: in fact, there is no easy way for the fix for python-docutils. -- ___ Python tracker ___ ___ Pyth

[issue36214] AC_RUN_IFELSE macros not used as arguments of AC_CACHE_VAL et al

2019-03-18 Thread Xavier de Gaye
Change by Xavier de Gaye : -- keywords: +patch pull_requests: +12368 stage: needs patch -> patch review ___ Python tracker ___ ___ P

[issue36328] tstate may be used uninitialized in Py_NewInterpreter

2019-03-18 Thread STINNER Victor
Change by STINNER Victor : -- components: +Interpreter Core resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue34160] ElementTree not preserving attribute order

2019-03-18 Thread STINNER Victor
STINNER Victor added the comment: Please don't break the backward compatibility without an easy way to retrieve Python 3.7 behavior. I set the priority to release blocker until a consensus can be found, and I add Lukasz (Python 3.8 release manager) in the loop. Ned Batchelder: "I'm a bit m

[issue36351] the ipv6type variable in configure.ac may be set incorrectly when cross-compiling

2019-03-18 Thread Xavier de Gaye
New submission from Xavier de Gaye : The tests that set the 'ipv6type' variable in configure.ac check the local file system and this may give incorrect values when cross-compiling. For example the /etc/netconfig file exists on Archlinux, and configure sets ipv6type=solaris when cross-compilin

[issue36328] tstate may be used uninitialized in Py_NewInterpreter

2019-03-18 Thread STINNER Victor
STINNER Victor added the comment: New changeset 9e06d2b865beb62e54a4da39eb191f9fb8385282 by Victor Stinner (Stéphane Wirtel) in branch 'master': bpo-36328: Fix compiler warning in Py_NewInterpreter() (GH-12381) https://github.com/python/cpython/commit/9e06d2b865beb62e54a4da39eb191f9fb8385282

[issue36304] When using bz2 and lzma in mode 'wt', the BOM is not written

2019-03-18 Thread STINNER Victor
Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue36235] distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is set

2019-03-18 Thread STINNER Victor
STINNER Victor added the comment: New changeset 72c7b372cf145fded93a9a776acc742a60090f95 by Victor Stinner in branch 'master': bpo-36235: Enhance distutils test_customize_compiler() (GH-12403) https://github.com/python/cpython/commit/72c7b372cf145fded93a9a776acc742a60090f95 --

[issue36235] distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is set

2019-03-18 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +12369 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue36351] the ipv6type variable in configure.ac may be set incorrectly when cross-compiling

2019-03-18 Thread Xavier de Gaye
Change by Xavier de Gaye : -- keywords: +patch pull_requests: +12370 stage: needs patch -> patch review ___ Python tracker ___ ___ P

[issue36235] distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is set

2019-03-18 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +12371 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue36320] typing.NamedTuple to switch from OrderedDict to regular dict

2019-03-18 Thread Josh Rosenberg
Josh Rosenberg added the comment: Blech. Just remembered _field_types is a *class* attribute, not an instance attribute, so it (just) can't be a plain property on NamedTuple itself. And because NamedTuple is super-weird (AFAICT, class X(typing.NamedTuple): pass defines a class where the clas

[issue36235] distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is set

2019-03-18 Thread STINNER Victor
STINNER Victor added the comment: > Just a question: I think it should be backported to 3.7 and 2.7 (...) Right, I wrote PRs for that. I didn't use GitHub labels because the bot is currently broken. -- ___ Python tracker

[issue36318] Adding support for setting the "disabled" attribute of loggers from logging.config.dictConfig

2019-03-18 Thread Géry
Géry added the comment: > It would be better to set the level of those loggers to e.g. ERROR or > CRITICAL rather than disabling them altogether - presumably if something bad > happens in those packages, one would want to know! What if the user doesn't care anyway? Why assuming what the user

[issue36352] Modules/getpath.c should not use hardcoded buffer sizes (MAXPATHLEN)

2019-03-18 Thread STINNER Victor
STINNER Victor added the comment: New changeset 1be0d1135f5627d0525eab635cf2da441d9cbc08 by Victor Stinner in branch 'master': bpo-36352: Clarify fileutils.h documentation (GH-12406) https://github.com/python/cpython/commit/1be0d1135f5627d0525eab635cf2da441d9cbc08 -- __

[issue36352] Modules/getpath.c should not use hardcoded buffer sizes (MAXPATHLEN)

2019-03-18 Thread STINNER Victor
New submission from STINNER Victor : I'm working on a change to avoid hardcoded buffer sizes (MAXPATHLEN) in Modules/getpath.c. This issue is a place holder to discuss it. -- components: Interpreter Core messages: 338255 nosy: vstinner priority: normal severity: normal status: open tit

[issue36345] Deprecate Tools/scripts/serve.py in favour of python -m http.server -d

2019-03-18 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I disagree with deprecating serve.py. It is a demo for the wsgiref module. -- nosy: +serhiy.storchaka ___ Python tracker ___ __

[issue36320] typing.NamedTuple to switch from OrderedDict to regular dict

2019-03-18 Thread miss-islington
miss-islington added the comment: New changeset f7b57df0c09c3a04ab27ba06eb2feb989bbb16cb by Miss Islington (bot) (Raymond Hettinger) in branch 'master': bpo-36320: Switch typing.NamedTuple from OrderedDict to regular dict (GH-12396) https://github.com/python/cpython/commit/f7b57df0c09c3a04ab2

[issue36320] typing.NamedTuple to switch from OrderedDict to regular dict

2019-03-18 Thread Raymond Hettinger
Change by Raymond Hettinger : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue23984] Documentation error: Descriptors

2019-03-18 Thread Raymond Hettinger
Raymond Hettinger added the comment: FWIW, I'm in the middle of a major update to this howto add will address this example there. -- resolution: -> postponed ___ Python tracker

[issue36347] Add the constant READWRITE for PyMemberDef

2019-03-18 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: It does not follow the convention for names in the C API. All public names should have prefix Py or PY, all private user visible names should have prefix _Py or _PY. Some existing names do not follow that convention, but we should fix this and do not add

[issue36010] Please provide a .zip Windows release of Python that is not crippled/for embedding only

2019-03-18 Thread Steve Dower
Steve Dower added the comment: > I ran Tools/nuget/build.bat manually, and the resulting file didn't have > lib\venv in it (I opened it in 7-zip, I don't know how to install a local > nuget file...). Huh, Tools/nuget/make_pkg.proj doesn't use the preset for some reason. I don't remember why

[issue36353] rpath incorrectly handled on OSX by build_ext

2019-03-18 Thread Toon Verstraelen
New submission from Toon Verstraelen : When using the '-R' option of build_ext on OSX, e.g. python setup.py -R some/path it gets translated to the following clang compiler argument: -L some/path while it should be -Wl,-rpath,some/path See clang documentation for details: https://clang.ll

[issue36235] distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is set

2019-03-18 Thread STINNER Victor
STINNER Victor added the comment: New changeset dd1cfefd67f254ce44f33995922e347c9d3f7b4e by Victor Stinner in branch '3.7': bpo-36235: Enhance distutils test_customize_compiler() (GH-12403) (GH-12415) https://github.com/python/cpython/commit/dd1cfefd67f254ce44f33995922e347c9d3f7b4e

[issue969718] BASECFLAGS are not passed to module build line

2019-03-18 Thread STINNER Victor
STINNER Victor added the comment: This issue has been fixed by bpo-36235. -- nosy: +vstinner resolution: -> duplicate stage: patch review -> resolved status: open -> closed superseder: -> distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is

[issue36235] distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is set

2019-03-18 Thread STINNER Victor
STINNER Victor added the comment: New changeset 8c380e99e9b71387d5722373805fe3159e2d912c by Victor Stinner in branch '2.7': bpo-36235: Enhance distutils test_customize_compiler() (GH-12403) (GH-12417) https://github.com/python/cpython/commit/8c380e99e9b71387d5722373805fe3159e2d912c

[issue36235] distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is set

2019-03-18 Thread STINNER Victor
STINNER Victor added the comment: Thanks for the review, I merged my PR and the test enhancements. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker _

[issue36235] distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is set

2019-03-18 Thread Chih-Hsuan Yen
Chih-Hsuan Yen added the comment: Oh, I didn't know the bot is not working for now. Thank you for making the test more robust! -- ___ Python tracker ___ _

[issue34160] ElementTree not preserving attribute order

2019-03-18 Thread Stefan Behnel
Stefan Behnel added the comment: Victor, as much as I appreciate backwards compatibility, I really don't think it's a big deal in this case. In fact, it might not even apply. My (somewhat educated) gut feeling is that most users simply won't care or won't even notice the change. Out of those

[issue36353] rpath incorrectly handled on OSX by build_ext

2019-03-18 Thread Roundup Robot
Change by Roundup Robot : -- keywords: +patch pull_requests: +12372 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-l

[issue36354] Use CreateProcessW for Python 2.7 on Windows.

2019-03-18 Thread Ray Donnelly
New submission from Ray Donnelly : Hi all, I'd like to entertain some discussion around the idea of calling CreateProcessW instead of CreateProcess on Windows. I've written a patch as a proof of concept and I would love to get some feedback. I guess I've broken the normal ACP/getfilesystemen

[issue36354] Use CreateProcessW for Python 2.7 on Windows.

2019-03-18 Thread Ray Donnelly
Ray Donnelly added the comment: .. and alternative to my ACP idea would be to use `GetACP()` or `getfilesystemencoding()` .. or? Suggestions welcome! -- ___ Python tracker __

[issue32223] distutils doesn't correctly read UTF-8 content from config files

2019-03-18 Thread Éric Araujo
Éric Araujo added the comment: Repeat: `metadata` in setup.cfg is not supported directly by distutils. Can you provide a setup.py script that shows the problem without setuptools? -- ___ Python tracker

[issue36292] Coverity scan: Resource leaks in longobject.c

2019-03-18 Thread STINNER Victor
STINNER Victor added the comment: New changeset a10d426bab66a4e1f20d5e1b9aee3dbb435cf309 by Victor Stinner (stratakis) in branch 'master': bpo-36292: Mark unreachable code as such in long bitwise ops (GH-12333) https://github.com/python/cpython/commit/a10d426bab66a4e1f20d5e1b9aee3dbb435cf309

[issue36292] Coverity scan: Resource leaks in longobject.c

2019-03-18 Thread STINNER Victor
STINNER Victor added the comment: I hope that the change will satisfy the god of static analyzers :-) I discussed with Charalampos and we agreed to not backport this change, since it's a false alarm and not a real bug. I close the issue. -- resolution: -> fixed stage: patch review -

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

2019-03-18 Thread Julien Palard
Julien Palard added the comment: New changeset 869652b426bb34a30ce7b39f0a0ac242ed5b1016 by Julien Palard in branch '2.7': [2.7] bpo-35605: Fix documentation build for sphinx<1.6 (GH-12413) https://github.com/python/cpython/commit/869652b426bb34a30ce7b39f0a0ac242ed5b1016 --

[issue36345] Deprecate Tools/scripts/serve.py in favour of python -m http.server -d

2019-03-18 Thread Julien Palard
Julien Palard added the comment: If it's appreciated as a demo for wsgiref, wouldn't it be better to move it inside Doc/library/wsgiref.rst? It was written specifically for the Doc/Makefile, it's no longer needed for the Doc/Makefile, so the question pops: is it usefull to anyone? If not it'

[issue12144] cookielib.CookieJar.make_cookies fails for cookies with 'expires' set

2019-03-18 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: This issue is still reproducible on master and below is a unittest. The patch looks reasonable to me and fixes the issue. @demian.brecht, would you like to convert the patch to a PR ? diff --git a/Lib/test/test_http_cookiejar.py b/Lib/test/test_htt

[issue36318] Adding support for setting the "disabled" attribute of loggers from logging.config.dictConfig

2019-03-18 Thread Vinay Sajip
Vinay Sajip added the comment: > If the `disabled` attribute should not be part of the public API it should > have been name `_disabled`. A bit late for that now, and AFAIK it hasn't caused people insuperable problems heretofore - the code has been like this pretty much since the logging pac

[issue36010] Please provide a .zip Windows release of Python that is not crippled/for embedding only

2019-03-18 Thread Paul Moore
Paul Moore added the comment: Thanks! That seems to have done it. Update to the PR incoming once my test build completes. -- ___ Python tracker ___ __

[issue36347] Add the constant READWRITE for PyMemberDef

2019-03-18 Thread Josh Rosenberg
Josh Rosenberg added the comment: Serhiy: Problem is that READONLY already exists, so PY_READWRITE would be inconsistent. Given currently READONLY is just defined as: #define READONLY 1 I suppose a solution to maintain consistency (of a sort) would be to add the definitions: #define PY_RE

[issue24565] the f_lineno getter is broken

2019-03-18 Thread Xavier de Gaye
Change by Xavier de Gaye : -- pull_requests: +12373 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue12144] cookielib.CookieJar.make_cookies fails for cookies with 'expires' set

2019-03-18 Thread Demian Brecht
Demian Brecht added the comment: @xtreak sure, can do. May not have time to do so today but should be able to do so over the next couple days. -- ___ Python tracker ___ _

[issue36355] Remove documentation and internal use of the RESTRICTED constants for PyMemberDef's flags field

2019-03-18 Thread Josh Rosenberg
New submission from Josh Rosenberg : While looking up background info for #36347, I noticed that the docs for PyMemberDef ( https://docs.python.org/3/extending/newtypes.html#generic-attribute-management ) define the following flags: * READONLY * READ_RESTRICTED * WRITE_RESTRICTED * RESTRICTE

[issue36355] Remove documentation and internal use of the *RESTRICTED constants for PyMemberDef's flags field

2019-03-18 Thread Josh Rosenberg
Josh Rosenberg added the comment: To be clear, only the constants that include the substring RESTRICTED are useless; READONLY remains useful and should not be removed (though per my suggestion on #36347, it might be good to add an alias for it named PY_READONLY to match the Python C API nami

[issue36346] Prepare for removing the legacy Unicode C API

2019-03-18 Thread Stefan Behnel
Change by Stefan Behnel : -- nosy: +scoder ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue36346] Prepare for removing the legacy Unicode C API

2019-03-18 Thread Stefan Behnel
Stefan Behnel added the comment: Thanks for implementing this, Serhiy. Since these C macros are public, should they be named PY_* ? -- ___ Python tracker ___ _

[issue36346] Prepare for removing the legacy Unicode C API

2019-03-18 Thread Stefan Behnel
Stefan Behnel added the comment: I think this is a good preparation that makes it clear what code will eventually be removed, and allows testing without it. No idea how happy Windows users will be about all of this, but I consider it quite an overall improvement for the Unicode implementatio

[issue36333] memory leaks detected with valgrind for python -V

2019-03-18 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +12375 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue36301] Add _Py_PreInitialize() function

2019-03-18 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +12374 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue36346] Prepare for removing the legacy Unicode C API

2019-03-18 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: I'd change the title of this bpo item to "Prepare for removing the whcar_t caching in the Unicode C API". Note that the wchar_t caching was put in place to allow for external applications and C code to easily and efficiently interface with Python. By re

[issue36333] memory leaks detected with valgrind for python -V

2019-03-18 Thread STINNER Victor
STINNER Victor added the comment: New changeset c183444f7e2640b054956474d71aae6e8d31a543 by Victor Stinner in branch 'master': bpo-36301: Fix Py_Main() memory leaks (GH-12420) https://github.com/python/cpython/commit/c183444f7e2640b054956474d71aae6e8d31a543 -- _

[issue36301] Add _Py_PreInitialize() function

2019-03-18 Thread STINNER Victor
STINNER Victor added the comment: New changeset c183444f7e2640b054956474d71aae6e8d31a543 by Victor Stinner in branch 'master': bpo-36301: Fix Py_Main() memory leaks (GH-12420) https://github.com/python/cpython/commit/c183444f7e2640b054956474d71aae6e8d31a543 -- _

[issue36346] Prepare for removing the legacy Unicode C API

2019-03-18 Thread Stefan Behnel
Stefan Behnel added the comment: I had also looked through the unrelated changes, and while, yes, they are unrelated, they seemed to be correct and reasonable modernisations of the code base while touching it. They could be moved to a separate PR, but there is a relatively high risk of confl

[issue36346] Prepare for removing the legacy Unicode C API

2019-03-18 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 18.03.2019 22:33, Stefan Behnel wrote: > > I had also looked through the unrelated changes, and while, yes, they are > unrelated, they seemed to be correct and reasonable modernisations of the > code base while touching it. They could be moved to a se

[issue34160] ElementTree not preserving attribute order

2019-03-18 Thread STINNER Victor
STINNER Victor added the comment: > Victor, as much as I appreciate backwards compatibility, I really don't think > it's a big deal in this case. In short, the XML serialization is no longer deterministic. It depends in which order attributes are defined. Example: --- from xml.etree import E

[issue34160] ElementTree not preserving attribute order

2019-03-18 Thread Raymond Hettinger
Raymond Hettinger added the comment: I'll make a post to python-dev so that we can escalate the discussion and get broader participation. Personally, I'm not wedded to any one particular outcome and just want to do what is best for the users in the long run. --

[issue36207] robotsparser deny all with some rules

2019-03-18 Thread Cheryl Sabella
Cheryl Sabella added the comment: Can you provide a link to documentation showing that "Disallow: ?" shouldn't be the same as deny all? Thanks! -- nosy: +cheryl.sabella ___ Python tracker _

[issue34160] ElementTree not preserving attribute order

2019-03-18 Thread Stéphane Wirtel
Stéphane Wirtel added the comment: @raymond Here is a basic comparison between two xml streams. Maybe we could propose this solution when we want to compare an XML with xml.dom.minidom instead of the byte-to-byte comparison. -- Added file: https://bugs.python.org/file48217/test_xml_c

[issue36352] Modules/getpath.c should not use hardcoded buffer sizes (MAXPATHLEN)

2019-03-18 Thread STINNER Victor
Change by STINNER Victor : -- keywords: +patch pull_requests: +12376 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-

[issue36352] Modules/getpath.c should not use hardcoded buffer sizes (MAXPATHLEN)

2019-03-18 Thread STINNER Victor
STINNER Victor added the comment: New changeset 7b14f0c02ce9d919c503119db190dbca0e703393 by Victor Stinner in branch 'master': bpo-36352: Add error handling to getpath.c (GH-12421) https://github.com/python/cpython/commit/7b14f0c02ce9d919c503119db190dbca0e703393 --

[issue34160] ElementTree not preserving attribute order

2019-03-18 Thread Julien Palard
Julien Palard added the comment: We found two occurrences of external code breaking due to this change, and one looks tricky to fix (docutils), this indicates there are other library that will break. > My (somewhat educated) gut feeling is that most users simply won't care or > won't even n

[issue36236] Python crash on macOS when CWD is invalid

2019-03-18 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: If we set argv0 to ".": if (_Py_wgetcwd(fullpath, Py_ARRAY_LENGTH(fullpath))) { argv0 = fullpath; n = wcslen(argv0); } else { argv0 = L"."; n = 1;

[issue36207] robotsparser deny all with some rules

2019-03-18 Thread wats0ns
wats0ns added the comment: I can't find a documentation about it, but all of the robots.txt checkers I find behave like this. You can test on this site: http://www.eskimoz.fr/robots.txt, I believe that this is how it's implemented now in most parsers ? -- __

[issue34160] ElementTree not preserving attribute order

2019-03-18 Thread Raymond Hettinger
Raymond Hettinger added the comment: > one looks tricky to fix (docutils) Actually, it is really easy to fix just by updating the target comparison files (that is the procedure described in the comments for the test). What is taking more thought is coming up with a better test that verifies

[issue36236] Python crash on macOS when CWD is invalid

2019-03-18 Thread STINNER Victor
STINNER Victor added the comment: Oh. It seems like I misunderstood the issue. I read "argv0" as sys.argv[0], but _PyPathConfig_ComputeArgv0 is used to insert a value at the start of sys.path. That's different... If the current directory has been removed, sys.path should just be left unchan

[issue36301] Add _Py_PreInitialize() function

2019-03-18 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +12377 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue36315] Unable to install Python 3.7.2

2019-03-18 Thread Brett Cannon
Change by Brett Cannon : -- nosy: +paul.moore, steve.dower, tim.golden, zach.ware ___ Python tracker ___ ___ Python-bugs-list mailin

[issue36236] Python crash on macOS when CWD is invalid

2019-03-18 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Yup. But what is the best way to signal the caller that _PyPathConfig_ComputeArgv0 has failed because _Py_wgetcwd has failed without changing the API massively? Right now if _PyPathConfig_ComputeArgv0 returns null is assumed that is due to a memory

[issue36309] Remove tempfile.mktemp()

2019-03-18 Thread Brett Cannon
Brett Cannon added the comment: Unfortunately not because there is no warning being raised currently about the deprecation (it's only documented as deprecated; https://github.com/python/cpython/commit/44f602dd3b452bbacd3c85b1e5f9873c892b46e3). A PR raising an appropriate deprecation for at l

[issue36352] Modules/getpath.c should not use hardcoded buffer sizes (MAXPATHLEN)

2019-03-18 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +12378 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue36301] Add _Py_PreInitialize() function

2019-03-18 Thread STINNER Victor
STINNER Victor added the comment: New changeset 5f9cf23502febe0eb3bc02e45c7d2bfc79424757 by Victor Stinner in branch 'master': bpo-36301: Error if decoding pybuilddir.txt fails (GH-12422) https://github.com/python/cpython/commit/5f9cf23502febe0eb3bc02e45c7d2bfc79424757 -- _

[issue36309] Remove tempfile.mktemp()

2019-03-18 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: There was a warning, but it was suppressed by this commit: commit 44f602dd3b452bbacd3c85b1e5f9873c892b46e3 Author: Guido van Rossum Date: Fri Nov 22 15:56:29 2002 + Comment out the warnings about mktemp(). These are too annoying, and of

[issue36309] Remove tempfile.mktemp()

2019-03-18 Thread John Hagen
John Hagen added the comment: Should it be a DeprecationWarning instead of a RuntimeWarning? (or both since it's both deprecated and a security issue?) -- ___ Python tracker

[issue36324] Inverse cumulative normal distribution function

2019-03-18 Thread Steven D'Aprano
Steven D'Aprano added the comment: Looks good to me. Later I will do some spot checks against the results returned by the Nspire calculator, but in the meantime I think this can go in. Thanks for your efforts Raymond, I think this NormalDist is shaping up to be a great addition. --

[issue36337] Use socket.sendall()/send() send data larger than 2GB will be truncated and return None, without exception raised.

2019-03-18 Thread STINNER Victor
STINNER Victor added the comment: New changeset f70b884ad70e2ce762842ae469f88bd48fe13998 by Victor Stinner (Stéphane Wirtel) in branch '2.7': bpo-36337: socket.send()/sendall() use Py_ssize_t (GH-12397) https://github.com/python/cpython/commit/f70b884ad70e2ce762842ae469f88bd48fe13998 ---

[issue36337] Use socket.sendall()/send() send data larger than 2GB will be truncated and return None, without exception raised.

2019-03-18 Thread STINNER Victor
STINNER Victor added the comment: Thanks Stéphane for the quick fix, I merged your PR. Thanks kmiku7 for your bug report. Until the next Python 2.7 version is released, you can use Python 3 which is already fixed ;-) -- resolution: -> fixed stage: patch review -> resolved status: op

[issue36352] Modules/getpath.c should not use hardcoded buffer sizes (MAXPATHLEN)

2019-03-18 Thread STINNER Victor
STINNER Victor added the comment: These changes are intrusive. I don't think that it's worth it to backport them to 3.7 (or 2.7). Just don't play with paths close to MAXPATHLEN bytes on Python 2.7 or 3.7 :-) I close the issue. -- resolution: -> fixed stage: patch review -> resolved

[issue36352] Modules/getpath.c should not use hardcoded buffer sizes (MAXPATHLEN)

2019-03-18 Thread STINNER Victor
STINNER Victor added the comment: New changeset faddaedd05ca81a9fed3f315e7bc8dcf455824a2 by Victor Stinner in branch 'master': bpo-36352: Avoid hardcoded MAXPATHLEN size in getpath.c (GH-12423) https://github.com/python/cpython/commit/faddaedd05ca81a9fed3f315e7bc8dcf455824a2 -- ___

[issue36236] Python crash on macOS when CWD is invalid

2019-03-18 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +12379 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue36131] test.test_urllib2net.TimeoutTest ftp related tests fail due to ftp://www.pythontest.net/ being unavailable

2019-03-18 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: A similar issue happened again on s390x SLES 2.7: https://buildbot.python.org/all/#/builders/66/builds/373 -- ___ Python tracker ___

[issue36344] install_certificates.command too complicated, copy from pip's dir instead

2019-03-18 Thread Ned Deily
Ned Deily added the comment: Thanks for the suggestion but that is not a workable solution for two reasons. One, pip is an optional install with the python.org installer so we cannot depend on it being available. More importantly, from a packaging point of view, the internal composition of

[issue36324] Inverse cumulative normal distribution function

2019-03-18 Thread Raymond Hettinger
Raymond Hettinger added the comment: New changeset 714c60d7aca6d0f6d73ad2d7c876d2d683a7fce3 by Raymond Hettinger in branch 'master': bpo-36324: Add inv_cdf() to statistics.NormalDist() (GH-12377) https://github.com/python/cpython/commit/714c60d7aca6d0f6d73ad2d7c876d2d683a7fce3 -- _

<    1   2   3   >