[issue29309] Interpreter hang when interrupting a loop.run_in_executor() future

2017-01-19 Thread Rémi Cardona
Changes by Rémi Cardona : -- nosy: +RemiCardona ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue29312] Use FASTCALL in dict.update()

2017-01-19 Thread STINNER Victor
STINNER Victor added the comment: Oops, I forgot a DECREF: fixed in the patch version 2. -- Oh wait, I misunderstood how dict.update() is called. In fact, they are two bytecodes to call a function with keyword arguments. (1) Using **kwargs: >>> def f(): ... d.update(**d2) ... >>> dis.dis(f

[issue28595] shlex.shlex should not augment wordchars

2017-01-19 Thread Evan Andrews
Evan Andrews added the comment: Attaching an updated patch now that the two linked issues are resolved. -- Added file: http://bugs.python.org/file46335/shlex2.diff ___ Python tracker ___

[issue26865] Meta-issue: support of the android platform

2017-01-19 Thread Xavier de Gaye
Xavier de Gaye added the comment: issue #28180: sys.getfilesystemencoding() should default to utf-8 -- dependencies: +sys.getfilesystemencoding() should default to utf-8 ___ Python tracker _

[issue29318] Optimize _PyFunction_FastCallDict() for **kwargs

2017-01-19 Thread STINNER Victor
New submission from STINNER Victor: Example: --- def func(x, y): print(x, y) def proxy2(func, **kw): func(**kw) def proxy1(func, **kw): proxy2(func, **kw) --- The "proxy2(func, **kw)" call in proxy1() is currently inefficient: _PyFunction_FastCallDict() converts the dictionary int

[issue29312] Use FASTCALL in dict.update()

2017-01-19 Thread STINNER Victor
STINNER Victor added the comment: When analyzing how FASTCALL handles "func(**kwargs)" calls for Python functions, I identified a missed optimization. I created the issue #29318: "Optimize _PyFunction_FastCallDict() for **kwargs". -- resolution: -> rejected __

[issue29259] Add tp_fastcall to PyTypeObject: support FASTCALL calling convention for all callable objects

2017-01-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset bf6728085b01 by Victor Stinner in branch 'default': _PyStack_AsDict() now checks kwnames != NULL https://hg.python.org/cpython/rev/bf6728085b01 -- ___ Python tracker _

[issue29311] Argument Clinic: convert dict methods

2017-01-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset 00c63ee66e0c by Victor Stinner in branch 'default': dict.get() and dict.setdefault() now use AC https://hg.python.org/cpython/rev/00c63ee66e0c -- nosy: +python-dev ___ Python tracker

[issue29318] Optimize _PyFunction_FastCallDict() for **kwargs

2017-01-19 Thread INADA Naoki
INADA Naoki added the comment: Since mutating kw dict shouldn't affect caller's dict, caller and callee can't share the dict. One possible optimization is using PyDict_Copy() to copy the dict. It can reduce number of hash() calls. -- ___ Python trac

[issue29312] Use FASTCALL in dict.update()

2017-01-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset e371686229e7 by Victor Stinner in branch 'default': Add a note explaining why dict_update() doesn't use METH_FASTCALL https://hg.python.org/cpython/rev/e371686229e7 -- nosy: +python-dev ___ Python tracker

[issue20291] Argument Clinic should understand *args and **kwargs parameters

2017-01-19 Thread STINNER Victor
STINNER Victor added the comment: Once this feature will be implemented, print() should be modified to use Argument Clinic: see the issue #29296. -- ___ Python tracker ___ _

[issue29296] convert print() to METH_FASTCALL

2017-01-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset 0327171f05dd by INADA Naoki in branch 'default': Issue #29296: convert print() to METH_FASTCALL https://hg.python.org/cpython/rev/0327171f05dd -- nosy: +python-dev ___ Python tracker

[issue29296] convert print() to METH_FASTCALL

2017-01-19 Thread STINNER Victor
STINNER Victor added the comment: I pushed print-fastcall.patch since it's simple and has a significant impact on bm_telco benchmark (especially when tp_fastcall slot will be added). I added a reminder (msg285779) in #20291 to convert print() once AC will support **kwargs. Can we close the is

[issue29318] Optimize _PyFunction_FastCallDict() for **kwargs

2017-01-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > It can reduce number of hash() calls. Keys are strings (even interned strings), and hashes are cached. In most cases kw is empty or very small. I doubt any optimization can have significant effect. -- nosy: +serhiy.storchaka _

[issue29319] Embedded 3.6.0 distribution cannot run pyz files

2017-01-19 Thread Paul Moore
New submission from Paul Moore: Trying to run a pyz file using the embedded distribution for 3.6.0, I get an error "Could not import runpy module". To reproduce, see below: >type .\__main__.py print('Hello, world') >zip test.pyz __main__.py adding: __main__.py (172 bytes security) (stored 0%

[issue29296] convert print() to METH_FASTCALL

2017-01-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > Why can't we start with METH_FASTCALL and convert to AC later? It increases the maintenance burden. When the fastcall protocol be changed, this would require changing more handwritten code. -- ___ Python tracker

[issue29319] Embedded 3.6.0 distribution cannot run pyz files

2017-01-19 Thread Paul Moore
Paul Moore added the comment: I just checked, and 3.6.0b1 (the only prerelease version I had available) has the same problem. 3.5.2 works fine. I thought I'd had similar code working during the beta cycle, but I can't demonstrate that any more, so maybe my recollection is wrong :-( --

[issue29320] bdist_msi install_script fail to execute if alt python location specified

2017-01-19 Thread eszense
New submission from eszense: if install-script specified and alternative python location selected during installation, msiexec will fail with: "There is a problem with this Windows Installer package. A program required for this install to complete could not be run. Contact your s

[issue29320] bdist_msi install_script fail to execute if alt python location specified

2017-01-19 Thread eszense
Changes by eszense : -- components: +Distutils nosy: +dstufft, eric.araujo ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue28911] Clarify the behaviour of assert_called_once_with

2017-01-19 Thread Arne de Laat
Arne de Laat added the comment: Unfortunately there cant be commas in the method name, that would clarify the name. It should be read as 'assert called once, with ...' not 'assert called once with ...'. I have often used the method to test something was called only once, and with the specifie

[issue29313] msi by bdist_msi will fail execute install-scripts if space in present in python path

2017-01-19 Thread eszense
eszense added the comment: This issue can be fixed together with Issue 15797. Patch attached for your consideration -- Added file: http://bugs.python.org/file46337/patch.txt ___ Python tracker

[issue29313] msi by bdist_msi will fail execute install-scripts if space in present in python path

2017-01-19 Thread eszense
Changes by eszense : Removed file: http://bugs.python.org/file46337/patch2.diff ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue29313] msi by bdist_msi will fail execute install-scripts if space in present in python path

2017-01-19 Thread eszense
Changes by eszense : Added file: http://bugs.python.org/file46338/patch.diff ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue29319] Embedded 3.6.0 distribution cannot run pyz files

2017-01-19 Thread Paul Moore
Paul Moore added the comment: Confirmed that it works with alpha 2, 3 and 4. But fails with beta 1 and the release version. -- ___ Python tracker ___ ___

[issue29321] Wrong documentation for unicode and str comparison

2017-01-19 Thread RK-5wWm9h
New submission from RK-5wWm9h: PROBLEM (IN BRIEF): In the currently published 2.7.13 The Python Language Reference manual, section 5.9 "Comparisons" (https://docs.python.org/2/reference/expressions.html#comparisons): "If both are numbers, they are converted to a common type. Otherwise, o

[issue29322] SimpleCV error on Raspberry Pi

2017-01-19 Thread Michael J
New submission from Michael J: Hello, I'm using a Microsoft LifeCam with SimpleCV on the ipython interpreter(or shell) on a Raspberry Pi 3 model B(with Raspbian, tell me if you need the exact OS version as it's quite complicated). I'm following the directions of a book: Raspberry Pi Cookbook

[issue29323] Wrong documentation (Library) for unicode and str comparison

2017-01-19 Thread RK-5wWm9h
New submission from RK-5wWm9h: PROBLEM (IN BRIEF): In the currently published 2.7.13 The Python Standard Library (Library Reference manual) section 5.6 "Sequence Types" (https://docs.python.org/2/library/stdtypes.html#sequence-types-str-unicode-list-tuple-bytearray-buffer-xrange): "to comp

[issue29321] Wrong documentation (Language Ref) for unicode and str comparison

2017-01-19 Thread RK-5wWm9h
Changes by RK-5wWm9h : -- title: Wrong documentation for unicode and str comparison -> Wrong documentation (Language Ref) for unicode and str comparison ___ Python tracker ___ _

[issue21628] 2to3 does not fix zip in some cases

2017-01-19 Thread Stuart Berg
Stuart Berg added the comment: Already closed, but FWIW, I think this was incorrectly marked as a duplicate. Issue 20742 discusses a different issue related to lib2to3 and zip. Meanwhile, this issue has been raised again in 28837, so I will continue the discussion there. (I have a patch.) -

[issue29324] test_aead_aes_gcm fails on Kernel 4.9

2017-01-19 Thread Christian Heimes
New submission from Christian Heimes: $ ./python -m test -m test_aead_aes_gcm test_socket Run tests sequentially 0:00:00 [1/1] test_socket test test_socket failed -- Traceback (most recent call last): File "/home/heimes/dev/python/cpython/Lib/test/support/__init__.py", line 556, in wrapper

[issue29322] SimpleCV error on Raspberry Pi

2017-01-19 Thread Xiang Zhang
Xiang Zhang added the comment: Hi Michael, this bug tracker is meant for developing CPython. Your problem exists in your own codes or third party applications. You'd better report to the related parties. -- nosy: +xiang.zhang resolution: -> third party stage: -> resolved status: open

[issue29324] test_aead_aes_gcm fails on Kernel 4.9

2017-01-19 Thread Charalampos Stratakis
Changes by Charalampos Stratakis : -- nosy: +cstratak ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue28837] 2to3 does not wrap zip correctly

2017-01-19 Thread Stuart Berg
Stuart Berg added the comment: In addition to zip(), this problem also affects map() and filter(). The problem is that the match patterns in FixZip, FixMap, and FixFilter do not allow for more than one "trailer" node. (And even if they did, their transform() methods aren't expecting it.) For

[issue20186] Derby #18: Convert 31 sites to Argument Clinic across 23 files

2017-01-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset 3713f7de576d by Serhiy Storchaka in branch 'default': Issue #20186: Converted the _operator module to Argument Clinic. https://hg.python.org/cpython/rev/3713f7de576d -- ___ Python tracker

[issue29324] test_aead_aes_gcm fails on Kernel 4.9

2017-01-19 Thread Christian Heimes
Christian Heimes added the comment: recv(64) works. I need to figure out why 64 and what's in the extra bytes. -- ___ Python tracker ___ _

[issue29319] Embedded 3.6.0 distribution cannot run pyz files

2017-01-19 Thread Steve Dower
Steve Dower added the comment: Does running with -v provide any more hints? I'm also interested in whether the alphas work when you don't have a full install on the same machine. PC/getpathp.c changed for b1. But that's probably less important. Perhaps runpy just never made it into the python

[issue20186] Derby #18: Convert 31 sites to Argument Clinic across 23 files

2017-01-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: The only change I made is used the return converter in length_hint(). -- versions: +Python 3.7 -Python 3.6 ___ Python tracker ___

[issue29319] Embedded 3.6.0 distribution cannot run pyz files

2017-01-19 Thread Paul Moore
Paul Moore added the comment: Sorry I should have thought of trying -v. The output (included below) doesn't seem to offer many hints, though. runpy.pyc is in python36.zip, I checked that. I'll see if I can find a machine without Python installed to test that case. >.\python.exe -v .\test.pyz i

[issue20186] Derby #18: Convert 31 sites to Argument Clinic across 23 files

2017-01-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset 112f27b8c8ea by Serhiy Storchaka in branch 'default': Issue #20186: Converted the math module to Argument Clinic. https://hg.python.org/cpython/rev/112f27b8c8ea -- ___ Python tracker

[issue20186] Derby #18: Convert 31 sites to Argument Clinic across 23 files

2017-01-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: issue20186.mathmodule.v2.patch needed just synchronizing docstrings. -- ___ Python tracker ___ ___

[issue12067] Doc: remove errors about mixed-type comparisons.

2017-01-19 Thread Martin Panter
Changes by Martin Panter : -- dependencies: +Wrong documentation (Language Ref) for unicode and str comparison ___ Python tracker ___

[issue29325] pysqlite: Evaluate removal of sqlite3_stmt_readonly

2017-01-19 Thread Brian Vandenberg
New submission from Brian Vandenberg: I'm not sure where to request changes to pysqlite, so my apologies if this isn't the right place. To begin with: I'll either end up building a newer version of sqlite myself or just accepting that pysqlite won't be part of this python installation. Howev

[issue29321] Wrong documentation (Language Ref) for unicode and str comparison

2017-01-19 Thread Martin Panter
Martin Panter added the comment: The Python 3 version of this was rewritten in Issue 12067. It would be good to port the new text to the Python 2 version, although that is not straightforward because of various differences between Python 2 and 3. That doesn’t rule out making smaller more speci

[issue20186] Derby #18: Convert 31 sites to Argument Clinic across 23 files

2017-01-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: issue20186.enumobject.patch LGTM too. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue20186] Derby #18: Convert 31 sites to Argument Clinic across 23 files

2017-01-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset e3db9bccff3f by Serhiy Storchaka in branch 'default': Issue #20186: Converted builtins enumerate() and reversed() to Argument Clinic. https://hg.python.org/cpython/rev/e3db9bccff3f -- ___ Python tracker

[issue20186] Derby #18: Convert 31 sites to Argument Clinic across 23 files

2017-01-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Sorry for committing patches for you Tal, but they were hanging so long time. -- ___ Python tracker ___ __

[issue29326] Blank lines in ._pth file are not ignored

2017-01-19 Thread Steve Dower
New submission from Steve Dower: If a python._pth file includes a blank line, it gets treated as '\n' which is then appended to the directory and used as an entry in sys.path. Empty lines should be ignored completely. -- components: Windows messages: 285809 nosy: paul.moore, steve.dowe

[issue13886] readline-related test_builtin failure

2017-01-19 Thread Xavier de Gaye
Xavier de Gaye added the comment: With input-readline.v3.patch, test_builtin runs with success on Android api 21. With pep538_coerce_legacy_c_locale_v4.diff that implements PEP 538 in issue 28180, and with input-readline.v3.patch modified to have 'readline_encoding = locale.getpreferredencodin

[issue29319] Embedded 3.6.0 distribution cannot run pyz files

2017-01-19 Thread Steve Dower
Steve Dower added the comment: I just tried it and it makes no difference. Omitting the "._pth" file seems to fix it, but apart from issue29326 (benign) sys.path is fine. Still digging, but don't worry about testing on other machines. -- ___ Python

[issue29311] Argument Clinic: convert dict methods

2017-01-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset fe1d83fe29d6 by Serhiy Storchaka in branch 'default': Issue #29311: Argument Clinic generates reasonable name for the parameter "default". https://hg.python.org/cpython/rev/fe1d83fe29d6 -- ___ Python tra

[issue29311] Argument Clinic: convert dict methods

2017-01-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: There are same problems with docstrings as in OrderedDict. The name "D" is not defined. -- nosy: +serhiy.storchaka ___ Python tracker ___ ___

[issue29319] Embedded 3.6.0 distribution cannot run pyz files

2017-01-19 Thread Steve Dower
Steve Dower added the comment: Found it in Modules/main.c in RunMainFromImporter(): /* argv0 is usable as an import source, so put it in sys.path[0] and import __main__ */ sys_path = PySys_GetObject("path"); if (sys_path == NULL) { PyErr_SetString(PyExc_RuntimeError, "

[issue29323] Wrong documentation (Library) for unicode and str comparison

2017-01-19 Thread R. David Murray
R. David Murray added the comment: Unicode and string *are* of the same type: basestring. This is a specific example of the liskov substitution principle, so I don't think it should be called out explicitly in this section. -- nosy: +r.david.murray ___

[issue29323] Wrong documentation (Library) for unicode and str comparison

2017-01-19 Thread R. David Murray
R. David Murray added the comment: As per your other issue, though, the real issue is that the two objects must be *comparable*, not that they be of the same type, and the language should probably be updated to reflect that. -- ___ Python tracker <

[issue29311] Argument Clinic: convert dict methods

2017-01-19 Thread STINNER Victor
STINNER Victor added the comment: > Argument Clinic generates reasonable name for the parameter "default". > -default as failobj: object = None > +default: object = None Thanks, that's a better name :-) FYI I wanted to limit changes when converting to AC, the change is already big enou

[issue29327] SystemError in sorted(iterable=[])

2017-01-19 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: In Python 3.6: >>> sorted(iterable=[]) Traceback (most recent call last): File "", line 1, in SystemError: Objects/tupleobject.c:81: bad argument to internal function In Python 3.5 and 2.7: >>> sorted(iterable=[]) Traceback (most recent call last): Fi

[issue29311] Argument Clinic: convert dict methods

2017-01-19 Thread STINNER Victor
STINNER Victor added the comment: > There are same problems with docstrings as in OrderedDict. The name "D" is > not defined. I copied the old docstring to AC. Python 3.6 doc: --- get(...) D.get(k[,d]) -> D[k] if k in D, else d. d defaults to None. --- D was already implicitly "self".

[issue28837] 2to3 does not wrap zip correctly

2017-01-19 Thread Stuart Berg
Changes by Stuart Berg : Removed file: http://bugs.python.org/file46339/fix-28837.patch ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue29289] Convert OrderedDict methods to Argument Clinic

2017-01-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset c144bf6c0ff7 by Serhiy Storchaka in branch 'default': Issue #29289: Argument Clinic generates reasonable name for the parameter "default". https://hg.python.org/cpython/rev/c144bf6c0ff7 -- ___ Python tra

[issue28837] 2to3 does not wrap zip correctly

2017-01-19 Thread Stuart Berg
Changes by Stuart Berg : Added file: http://bugs.python.org/file46341/fix-28837.patch ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue29311] Argument Clinic: convert dict methods

2017-01-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: There was a context in old docstrings removed in new docstrings. It is not always possible just to copy docstrings in Argument Clinic. Sometimes rewriting docstrings is the hardest part of converting to Argument Clinic. I suggest either restore the context t

[issue29319] Embedded 3.6.0 distribution cannot run pyz files

2017-01-19 Thread Paul Moore
Paul Moore added the comment: Nice! Thanks for finding this. I don't suppose there's any chance this would qualify as a bugfix for 3.6.1? I've been holding off on working on https://github.com/pfmoore/pylaunch until 3.6 because 3.5 doesn't handle being in a subdirectory very well. It'd be a sh

[issue28837] 2to3 does not wrap zip correctly

2017-01-19 Thread Stuart Berg
Stuart Berg added the comment: Sorry for re-uploading the patch; I made some pep8 fixes. -- Added file: http://bugs.python.org/file46342/fix-28837.patch ___ Python tracker ___ __

[issue28837] 2to3 does not wrap zip correctly

2017-01-19 Thread Stuart Berg
Changes by Stuart Berg : Removed file: http://bugs.python.org/file46341/fix-28837.patch ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue29316] Can we keep typing.py provisional for the duration of the Python 3.6 release cycle?

2017-01-19 Thread Brett Cannon
Brett Cannon added the comment: Keeping it provisional sounds reasonable to me, especially if it helps land protocol support. -- nosy: +brett.cannon ___ Python tracker ___ _

[issue29319] Embedded 3.6.0 distribution cannot run pyz files

2017-01-19 Thread Steve Dower
Steve Dower added the comment: I'd say it definitely qualifies as a bug fix, even in 3.5 (which repros), assuming we don't break any existing APIs in the process. -- versions: +Python 3.5 ___ Python tracker __

[issue28837] 2to3 does not wrap zip correctly

2017-01-19 Thread Stuart Berg
Changes by Stuart Berg : Removed file: http://bugs.python.org/file46342/fix-28837.patch ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue28837] 2to3 does not wrap zip correctly

2017-01-19 Thread Stuart Berg
Changes by Stuart Berg : Added file: http://bugs.python.org/file46343/fix-28837.patch ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue2771] Test issue

2017-01-19 Thread Brett Cannon
Changes by Brett Cannon : -- pull_requests: +19 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue29327] SystemError in sorted(iterable=[])

2017-01-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Seems this regression was introduced in issue27809. -- ___ Python tracker ___ ___ Python-bugs-list

[issue29327] SystemError in sorted(iterable=[])

2017-01-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: In debug build Python is crashed. >>> sorted(iterable=[]) python: Objects/abstract.c:2317: _PyObject_FastCallDict: Assertion `nargs >= 0' failed. Aborted (core dumped) -- type: behavior -> crash ___ Python tracker

[issue29328] struct module should support variable-length strings

2017-01-19 Thread Elizabeth Myers
New submission from Elizabeth Myers: There was some discussion on python-ideas about this, and I figured it would be more productive to bring it here since to me this appears to be a glaring omission. The struct module has no capability to support variable-length strings; this includes null-t

[issue29327] SystemError or crash in sorted(iterable=[])

2017-01-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Proposed patch fixes the bug. -- keywords: +patch nosy: +haypo stage: -> patch review title: SystemError in sorted(iterable=[]) -> SystemError or crash in sorted(iterable=[]) Added file: http://bugs.python.org/file46344/sorted.diff _

[issue29328] struct module should support variable-length strings

2017-01-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Could you provide some examples of using these format specifiers? I suppose that due to limitations of the struct module the way in which they can be implemented would be not particularly useful for you. -- nosy: +serhiy.storchaka __

[issue13285] signal module ignores external signal changes

2017-01-19 Thread Thomas Kluyver
Thomas Kluyver added the comment: I'd like to make the case for a fix in the code again. Our use case is, I believe, the same as Vilya's. We want to temporarily set a signal handler from Python and then restore the previous handler. This is fairly straightforward for Python handler functions,

[issue29329] Incorrect documentation for custom `hex()` support on Python 2

2017-01-19 Thread Pekka Klärck
New submission from Pekka Klärck: Documentation of `hex()` on Python 2 says that custom objects need to implement `__index__` to support it. Based on my tests that doesn't work but `__hex__` is needed instead. Docs are at https://docs.python.org/2/library/functions.html?highlight=hex#hex and h

[issue29328] struct module should support variable-length strings

2017-01-19 Thread Ethan Furman
Changes by Ethan Furman : -- nosy: +ethan.furman ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue20186] Derby #18: Convert 31 sites to Argument Clinic across 23 files

2017-01-19 Thread Tal Einat
Tal Einat added the comment: Serhiy, no apology is required. On the contrary, thank you for the taking the time to review this and commit, I don't have time available for this these days. -- ___ Python tracker ___

[issue29328] struct module should support variable-length strings

2017-01-19 Thread Mark Dickinson
Mark Dickinson added the comment: IMO, as one of the previous maintainers of the struct module, this feature request isn't compatible with the current design and purpose of the struct module. I agree that there's an important problem to solve (and one I've had to solve many times for various f

[issue29329] Incorrect documentation for custom `hex()` support on Python 2

2017-01-19 Thread Eryk Sun
Eryk Sun added the comment: Python 3 uses __index__ for bin(), oct(), and hex(), but Python 2 only uses __index__ for bin() and otherwise uses __oct__ and __hex__. Antoine overlooked this when updating the 2.7 docs for hex() in issue 16665. -- nosy: +eryksun __

[issue29282] Fused multiply-add: proposal to add math.fma()

2017-01-19 Thread Mark Dickinson
Mark Dickinson added the comment: Serhiy, Victor: thanks for the reviews. Here's a new patch. Differences w.r.t. the old one: - Converted to argument clinic. - Updated docstring to talk about special cases. - More tests, as suggested by Serhiy. - whatsnew entry and ..versionadded in docs.

[issue29282] Fused multiply-add: proposal to add math.fma()

2017-01-19 Thread Mark Dickinson
Mark Dickinson added the comment: Whoops; looks like I failed to attach the updated patch. Here it is. -- Added file: http://bugs.python.org/file46345/math_fma2.patch ___ Python tracker

[issue29329] Incorrect documentation for custom `hex()` support on Python 2

2017-01-19 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- assignee: -> docs@python components: +Documentation keywords: +easy nosy: +docs@python stage: -> needs patch versions: +Python 2.7 ___ Python tracker _

[issue29282] Fused multiply-add: proposal to add math.fma()

2017-01-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Have you missed the patch? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue29282] Fused multiply-add: proposal to add math.fma()

2017-01-19 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- Removed message: http://bugs.python.org/msg285838 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue29282] Fused multiply-add: proposal to add math.fma()

2017-01-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: LGTM except that lines in What's New are too long. -- assignee: -> mark.dickinson stage: patch review -> commit review ___ Python tracker ___

[issue29282] Fused multiply-add: proposal to add math.fma()

2017-01-19 Thread Mark Dickinson
Mark Dickinson added the comment: > lines in What's New are too long. Thanks. Fixed (I think). I'm not sure what the limit is, but the lines are now all <= 79 characters long. -- Added file: http://bugs.python.org/file46346/math_fma3.patch ___ Pytho

[issue29282] Fused multiply-add: proposal to add math.fma()

2017-01-19 Thread Mark Dickinson
Mark Dickinson added the comment: Ah, the dev guide says 80 characters. (https://docs.python.org/devguide/documenting.html) -- ___ Python tracker ___ ___

[issue13285] signal module ignores external signal changes

2017-01-19 Thread R. David Murray
R. David Murray added the comment: IMO the signal handler context manager would be useful (I have existing code where I wrote one that didn't quite work right :). I suggest you propose this on python-ideas. -- nosy: +r.david.murray ___ Python track

[issue29282] Fused multiply-add: proposal to add math.fma()

2017-01-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Then LGTM unconditionally. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue29282] Fused multiply-add: proposal to add math.fma()

2017-01-19 Thread Mark Dickinson
Mark Dickinson added the comment: Thanks, Serhiy. I'm going to hold off committing this for 24 hours or so, because I want to follow the buildbots when I do (and I don't have time for that right now). I wouldn't be at all surprised to see platform-specific test failures. -- _

[issue29311] Argument Clinic: convert dict methods

2017-01-19 Thread Martin Panter
Martin Panter added the comment: D.get(key[, default]) -> D[key] if key in D, else default. There is no big problem with that. D is defined at the start. The only thing I would have suggested is avoid using square brackets to mean two things in the one expression. Since it is no longer the sig

[issue29328] struct module should support variable-length strings

2017-01-19 Thread Ethan Furman
Ethan Furman added the comment: >From Yury Selivanov: --- This is a neat idea, but this will only work for parsing framed binary protocols. For example, if you protocol prefixes all packets with a length field, you can write an efficient read buffer and use your proposal to decod

[issue29296] convert print() to METH_FASTCALL

2017-01-19 Thread STINNER Victor
STINNER Victor added the comment: Serhiy Storchaka: > When the fastcall protocol be changed, this would require changing more > handwritten code. I don't plan to modify the fastcall protocol. I'm not sure that it's really possible to modify it anymore. It would probably be simpler to add a new

[issue29327] SystemError or crash in sorted(iterable=[])

2017-01-19 Thread Raymond Hettinger
Raymond Hettinger added the comment: Please be careful with all of these AC changes. They need to have tests. They need to not change APIs. They need to not introduce bugs. The whole effort seems to be being pushed forward in a cavalier and aggressive manner. In this case, there was an API

[issue29327] SystemError or crash in sorted(iterable=[])

2017-01-19 Thread STINNER Victor
STINNER Victor added the comment: Oh, this issue is very subtle. Since the list.sorted() class method became a builtin sorted() method (Python 2.4.0, change c06b570adf12 by Raymond Hettinger), the sorted() function accepts an iterable as a keyword argument, whereas list.sort() doesn't. sorted

[issue29330] __slots__ needs documentation

2017-01-19 Thread saumitra paul
New submission from saumitra paul: As you said..assiging it to you :) -- messages: 285850 nosy: rhettinger, saumitra1978 priority: normal severity: normal status: open title: __slots__ needs documentation versions: Python 2.7 ___ Python tracker

[issue29327] SystemError or crash in sorted(iterable=[])

2017-01-19 Thread STINNER Victor
STINNER Victor added the comment: While Python 3.5 doesn't crash, I consider that it has also the bug. So I added Python 3.5 in Versions. sorted.diff LGTM. And thank you for the unit test! -- versions: +Python 3.5 ___ Python tracker

[issue29323] Wrong documentation (Library) for unicode and str comparison

2017-01-19 Thread Martin Panter
Martin Panter added the comment: If you read the whole paragraph carefully, I don't think it is too misleading. "In particular, tuples and lists . . ." suggests the author was just trying to say that a tuple never compares equal to a list. Maybe we just need to make that more obvious? However

[issue27596] Build failure with Xcode 8 beta on OSX 10.11

2017-01-19 Thread Maxime Belanger
Maxime Belanger added the comment: We're hitting this issue with Python 2.7 (which we deploy on Mac OS X 10.6-10.12). We've worked around it by manually patching `pyconfig.h` to un-define `HAVE_GETENTROPY` before `make`ing. Is a patch is in the works to support weak-linking this symbol (and th

  1   2   >