[issue27113] sqlite3 connect parameter "check_same_thread" not documented

2016-06-03 Thread Senthil Kumaran
Senthil Kumaran added the comment: Thanks for the explanation, Dave. Completely agree with those points. Let's go ahead with the latest patch. -- ___ Python tracker ___

[issue27113] sqlite3 connect parameter "check_same_thread" not documented

2016-06-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset af1752e51a89 by Senthil Kumaran in branch '3.5': issue27113 - Document "check_same_thread" parameter in sqlite3.connect api. https://hg.python.org/cpython/rev/af1752e51a89 New changeset 17c8da643065 by Senthil Kumaran in branch 'default': [merge fro

[issue27113] sqlite3 connect parameter "check_same_thread" not documented

2016-06-03 Thread Senthil Kumaran
Senthil Kumaran added the comment: Thanks for your contribution. It's now documented. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker _

[issue15476] Index "code object" and link to code object definition

2016-06-03 Thread Martin Panter
Martin Panter added the comment: I left some minor review suggestions. But a more serious problem is that the change to Doc/reference/datamodel.rst breaks the formatting for me. Instead of a HTML , I get a followed by a . Unfortunately I don’t know of a way to get index entries to point to th

[issue20699] Document that binary IO classes work with bytes-likes objects

2016-06-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Since the _pyio implementation doesn't support general memoryview-like objects, I consider using the new buffer protocol in the C implementation an implementation detail. Other implementations can lack this support. I think it would be better to left the wor

[issue16182] readline: Wrong tab completion scope indices in Unicode terminals

2016-06-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you for your comments and updated patches, and especially for tests Martin. Added some comments on Rietveld. -- ___ Python tracker ___

[issue27185] Clarify Test Coverage for the String Module (test_pep292 is not easily discoverable)

2016-06-03 Thread Martin Panter
Martin Panter added the comment: IMO I wouldn’t bother. David has already done the change a different way, which is simpler to understand commit-by-commit, even if it messes with the Mercurial annotate history. FWIW I guess you could do a similar merge with an old version to restore the delet

[issue20699] Document that binary IO classes work with bytes-likes objects

2016-06-03 Thread Martin Panter
Martin Panter added the comment: Actually this bug report was opened because an implementation that lacked memoryview support was broken by 2.7. The point is to document that (a subset of) memoryview objects may be passed to custom implementations. Does this need a “changed in 2.7” notice? I a

[issue27185] Clarify Test Coverage for the String Module (test_pep292 is not easily discoverable)

2016-06-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 70e19b014d2f by Serhiy Storchaka in branch '3.5': Issue #27185: Rename test_string.py to test_string_merged.py. https://hg.python.org/cpython/rev/70e19b014d2f New changeset 0da07e73451d by Serhiy Storchaka in branch '3.5': Issue #27185: Rename test_

[issue26359] CPython build options for out-of-the box performance

2016-06-03 Thread Alecsandru Patrascu
Alecsandru Patrascu added the comment: I've updated the patch for 2.7 branch to contain the LTO part merged by Gregory. -- Added file: http://bugs.python.org/file43142/cpython2_with_optimizations_v02.patch ___ Python tracker

[issue27185] Clarify Test Coverage for the String Module (test_pep292 is not easily discoverable)

2016-06-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Now the history is restored. -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___ __

[issue26359] CPython build options for out-of-the box performance

2016-06-03 Thread Alecsandru Patrascu
Alecsandru Patrascu added the comment: The patches in discussions are the v02 ones. -- ___ Python tracker ___ ___ Python-bugs-list mai

[issue24759] Idle: require tk 8.5 and ttk widgets, and drop unneeded code.

2016-06-03 Thread Terry J. Reedy
Terry J. Reedy added the comment: Given what Serhiy said, the core of this patch is the original patch with a test of TkVersion instead of importing ttk. Code that only ran for 8.4- is removed. Some minimal new tests are added, and I may add some more. None of the changes should depend on O

[issue27196] Eliminate 'ThemeChanged' warning when running IDLE tests

2016-06-03 Thread Terry J. Reedy
New submission from Terry J. Reedy: When running "python_d.exe -m test_idle from console or when running test file from IDLE after starting it in either console or by import, the following sometimes appears. can't invoke "event" command: application has been destroyed while executing "even

[issue20699] Document that binary IO classes work with bytes-likes objects

2016-06-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: array is supported explicitly in the Python implementation of readinto(). What if write not "usable with memoryview", but mention memoryview as an example? The object *b* should be a pre-allocated, writable array of bytes, such as :class:`bytearray`, :

[issue24759] Idle: require tk 8.5 and ttk widgets, and drop unneeded code.

2016-06-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Do you forgot to attach a patch? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue27196] Eliminate 'ThemeChanged' warning when running IDLE tests

2016-06-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This looks as a duplicate of issue20567. -- ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue15243] Misleading documentation for __prepare__

2016-06-03 Thread Mark Lawrence
Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue19489] move quick search box above TOC

2016-06-03 Thread Mark Lawrence
Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue20408] memoryview() constructor documentation error

2016-06-03 Thread Mark Lawrence
Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue20408] memoryview() constructor documentation error

2016-06-03 Thread Stefan Krah
Stefan Krah added the comment: Or pretend in the documentation that it's a positional arg and make it one later. There is a slight performance difference. I agree with Damien that probably no one uses the keyword arg. -- ___ Python tracker

[issue20408] memoryview() constructor documentation error

2016-06-03 Thread Stefan Krah
Stefan Krah added the comment: Sorry, I meant *Demian*. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue20699] Document that binary IO classes work with bytes-likes objects

2016-06-03 Thread Martin Panter
Martin Panter added the comment: I don’t see the point of mentioning array() objects at all. It’s hard to support array in a Python 2 implementation, as demonstrated by readinto(). And the special support for array('b') won’t help if you pass in array('B') with values 128–255. I see this as an

[issue2466] os.path.ismount doesn't work for mounts the user doesn't have permission to see

2016-06-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: What if use os.stat(dirname(path)) instead of os.lstat(parent)? -if isinstance(path, bytes): -parent = join(path, b'..') -else: -parent = join(path, '..') try: -s2 = os.lstat(parent) +s2 = os.stat(dirname(path))

[issue20699] Document that binary IO classes work with bytes-likes objects

2016-06-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Why :class:`str` and not :class:`bytes`? -- ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue20699] Document that binary IO classes work with bytes-likes objects

2016-06-03 Thread Martin Panter
Martin Panter added the comment: I thought :class:`str` is better documented in Python 2, but I can write bytes if you prefer. I guess it is more consistent with the rest of io.rst. -- ___ Python tracker _

[issue20699] Document that binary IO classes work with bytes-likes objects

2016-06-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Current docs use "bytes or bytearray object" (without references). "bytes" is just an alias to "str" in 2.7, but I prefer to use this name, for consistency with 3.x and for accenting the binary nature of the data. Your new wording LGTM. --

[issue2466] os.path.ismount doesn't work for mounts the user doesn't have permission to see

2016-06-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Ah, forget, this doesn't work with path like "./.". Agreed, using realpath() is the simplest solution. -- ___ Python tracker ___ _

[issue27179] subprocess uses wrong encoding on Windows

2016-06-03 Thread Eryk Sun
Eryk Sun added the comment: > I would say almost all Windows console programs does use > console's encoding for input/output because otherwise > user wouldn't be able to read it. While some programs do use the console codepage, even when writing to a pipe or disk file -- such as more.com, reg

[issue27179] subprocess uses wrong encoding on Windows

2016-06-03 Thread Eryk Sun
Changes by Eryk Sun : -- Removed message: http://bugs.python.org/msg267090 ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue27179] subprocess uses wrong encoding on Windows

2016-06-03 Thread Eryk Sun
Eryk Sun added the comment: > I would say almost all Windows console programs does use > console's encoding for input/output because otherwise > user wouldn't be able to read it. While some programs do use the console codepage, even when writing to a pipe or disk file -- such as more.com, reg

[issue23670] Modifications to support iOS as a cross-compilation target

2016-06-03 Thread Luke Taylor
Luke Taylor added the comment: Ok, great! On Fri, Jun 3, 2016 at 7:34 AM Luke Taylor wrote: > Ah, cool! > On Fri, Jun 3, 2016 at 2:58 AM Russell Keith-Magee > wrote: > >> >> Russell Keith-Magee added the comment: >> >> Yes - I'm aware of Pythonista; the author of that app contracted me to >>

[issue27073] redundant checks in long_add and long_sub

2016-06-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: It would be nice. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue26915] Test identity first in membership operation of ItemsView, ValuesView and Sequence in collections.abc

2016-06-03 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- resolution: fixed -> stage: patch review -> needs patch ___ Python tracker ___ ___ Python-bugs-list

[issue20041] TypeError when f_trace is None and tracing.

2016-06-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I think the code would be simpler if convert the argument of frame_settrace() to NULL if it is Py_None. -- ___ Python tracker ___ ___

[issue26293] Embedded zipfile fields dependent on absolute position

2016-06-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: spoo, can you confirm that the patch fixes your issue? -- ___ Python tracker ___ ___ Python-bugs-l

[issue26983] float() can return not exact float instance

2016-06-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Ping. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue24291] Many servers (wsgiref, http.server, etc) can truncate large output blobs

2016-06-03 Thread Martin Panter
Martin Panter added the comment: In wsgiref-only.v2.patch I added deprecated support for continuing when a partial write is detected. I don’t think it needs documenting though. -- Added file: http://bugs.python.org/file43143/wsgiref-only.v2.patch ___

[issue27073] redundant checks in long_add and long_sub

2016-06-03 Thread Oren Milman
Changes by Oren Milman : Added file: http://bugs.python.org/file43145/patchedCPythonTestOutput2.txt ___ Python tracker ___ ___ Python-bugs-lis

[issue23680] Sporadic freeze in test_interrupted_write_retry_text

2016-06-03 Thread Martin Panter
Martin Panter added the comment: Here is my suggested change to use setitimer(). I also closed the pipe, which means there is no need to time out the read, speeding the test up a bit more. -- keywords: +patch stage: -> patch review versions: +Python 2.7 Added file: http://bugs.python.o

[issue27073] redundant checks in long_add and long_sub

2016-06-03 Thread Oren Milman
Oren Milman added the comment: All right. The updated diff file is attached. I compiled and ran the tests again. They are quite the same. The test output is attached. -- Added file: http://bugs.python.org/file43144/issue27073.diff ___ Python tracker

[issue22331] test_io.test_interrupted_write_text() hangs on the buildbot FreeBSD 7.2

2016-06-03 Thread Martin Panter
Martin Panter added the comment: Here is a patch with my suggestion to send the signal only when read() returns, and also closing the read end of the pipe before the write end. -- keywords: +patch stage: -> patch review Added file: http://bugs.python.org/file43147/int-write.patch

[issue26983] float() can return not exact float instance

2016-06-03 Thread Mark Dickinson
Mark Dickinson added the comment: float_exact2.patch LGTM -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue27145] long_add and long_sub might return a new int where &small_ints[x] could be returned

2016-06-03 Thread Oren Milman
Oren Milman added the comment: I just realized I had forgotten to check for a failure after using _PyLong_Negate. The updated diff file is attached. -- Added file: http://bugs.python.org/file43148/proposedPatches.diff ___ Python tracker

[issue27145] long_add and long_sub might return a new int where &small_ints[x] could be returned

2016-06-03 Thread Oren Milman
Oren Milman added the comment: After giving it some more thought, I feel somewhat uncertain about that check for a failure after using _PyLong_Negate. At first I noticed that after every call to _PyLong_Negate there is such a check. But then I realized that in my patch, and also in long_mul (i

[issue27184] Support path objects in the ntpath module

2016-06-03 Thread Ethan Furman
Ethan Furman added the comment: @Serhy: Isn't that backwards? I would think that by doing os.path first most other libraries would not have to change. -- ___ Python tracker __

[issue27186] add os.fspath()

2016-06-03 Thread Ethan Furman
Ethan Furman added the comment: Note: My schedule changed -- I won't be at the sprints today, but tomorrow. I'll finish reviewing these patches and commit this afternoon if no one beats me to it. -- ___ Python tracker

[issue26915] Test identity first in membership operation of ItemsView, ValuesView and Sequence in collections.abc

2016-06-03 Thread Xiang Zhang
Xiang Zhang added the comment: Serhiy, actually the patch(issue26915_s2.patch) I uploaded early has tried to make Sequence.index and Sequence.count consistent. Maybe the issue stage is not right. -- ___ Python tracker

[issue26293] Embedded zipfile fields dependent on absolute position

2016-06-03 Thread spoo
spoo added the comment: On 06/03/2016 09:27 PM, Serhiy Storchaka wrote: > > Serhiy Storchaka added the comment: > > spoo, can you confirm that the patch fixes your issue? > > -- > > ___ > Python tracker > > _

[issue24759] Idle: require tk 8.5 and ttk widgets, and drop unneeded code.

2016-06-03 Thread Terry J. Reedy
Terry J. Reedy added the comment: Trying again. And yes, I would like a review. I don't think there is anything system specific, but some deletions required a minor rewrite. -- keywords: +patch Added file: http://bugs.python.org/file43149/require85.diff __

[issue19611] inspect.getcallargs doesn't properly interpret set comprehension code objects.

2016-06-03 Thread Jelle Zijlstra
Jelle Zijlstra added the comment: This new patch makes the inspect module treat .0-type names as positional-only and renames them to implicit0. Includes a documentation patch too. I'm not too happy with the wording in the documentation, so suggestions for better naming are appreciated. --

[issue25548] Show the address in the repr for class objects

2016-06-03 Thread Kushal Das
Kushal Das added the comment: Uploading the new patch with a new test case for the same. -- Added file: http://bugs.python.org/file43151/issue25548v2.patch ___ Python tracker ___

[issue27051] Create PIP gui

2016-06-03 Thread Upendra Kumar
Upendra Kumar added the comment: @Terry and @Lorenzo, As shown in the GUI of "install_pyPI_v1.png", I needed to add some tkinter widget into treeview. For example, adding a checkbox to the treeview so that multiple selections are possible. In figure "install_pyPI_v1.png", a checkbox in each r

[issue24617] os.makedirs()'s [mode] not correct

2016-06-03 Thread Tommy Beadle
Changes by Tommy Beadle : -- nosy: +tbeadle ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue25548] Show the address in the repr for class objects

2016-06-03 Thread Emanuel Barry
Emanuel Barry added the comment: I'd probably change all instances of ".*" in the regex matches to be "0x.+" instead. For the docstrings that have "..." in them, I would probably make those " at ..." as well (although you get decide if it hinders readability too much). Other than that patch L

[issue25548] Show the address in the repr for class objects

2016-06-03 Thread Brett Cannon
Brett Cannon added the comment: Patch LGTM. Just needs doc and What's New updates. -- assignee: -> kushal.das nosy: +brett.cannon stage: patch review -> commit review ___ Python tracker ___

[issue27197] mock.patch interactions with "from" imports

2016-06-03 Thread Clark Breyman
New submission from Clark Breyman: Unclear if this is a code bug or a gotcha that should be documented: Cross posted to https://github.com/testing-cabal/mock/issues/365 Since "from"-style imports in modules bind names on the first execution of the import, there is a subtle interaction with patc

[issue15476] Index "code object" and link to code object definition

2016-06-03 Thread Tommy Beadle
Changes by Tommy Beadle : Added file: http://bugs.python.org/file43152/0001-Issue-15476-Make-code-object-its-own-entry-in-the-do.patch ___ Python tracker ___ ___

[issue20567] test_idle causes test_ttk_guionly 'can't invoke "event" command: application has been destroyed' messages from Tk

2016-06-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 8090931ba850 by Terry Jan Reedy in branch '2.7': Issue 20567: Revise idle_test/README.txt and some tests to match new advice. https://hg.python.org/cpython/rev/8090931ba850 -- ___ Python tracker

[issue22797] urllib.request.urlopen documentation falsely guarantees that a URLError will be raised on errors

2016-06-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset aed4b9981fca by R David Murray in branch '3.5': #22797: clarify when URLErrors are raised by urlopen. https://hg.python.org/cpython/rev/aed4b9981fca New changeset d085b4f779af by R David Murray in branch '3.5': Merge: #22797: clarify when URLErrors

[issue20567] test_idle causes test_ttk_guionly 'can't invoke "event" command: application has been destroyed' messages from Tk

2016-06-03 Thread Terry J. Reedy
Terry J. Reedy added the comment: This and the followup for 3.x full the TODOs in msg219528, revise README.txt, and in msg221467, change delete order to match new advice. This issue was about conflict between test_idle and test_ttk-guionly and that has apparently been solved. After the 3.x c

[issue15476] Index "code object" and link to code object definition

2016-06-03 Thread R. David Murray
R. David Murray added the comment: There are entries for code with object as a subentry? That's not what I was talking about, I was talking about preserving the sub entries for 'code' under the 'object' main entry. -- ___ Python tracker

[issue25548] Show the address in the repr for class objects

2016-06-03 Thread Raymond Hettinger
Raymond Hettinger added the comment: Kushal. If you don't mind, I would like Nofar to be able to do this patch. She's been working on it since before the sprints and was slowed down by a schoolwork crunch. -- ___ Python tracker

[issue22558] Missing doc links to source code for Python-coded modules.

2016-06-03 Thread Nathan Harold
Nathan Harold added the comment: I'll give this a go, per Terry's instructions in msg266846. I've noticed up front that, due to other changes near the headers of a couple of files (specifically fcntl.rst and termios.rst), the patch doesn't apply cleanly anymore. Is it permissible for me to fi

[issue25548] Show the address in the repr for class objects

2016-06-03 Thread Raymond Hettinger
Raymond Hettinger added the comment: Nofar is about to upload her patch as well (she's been working on this for a while). Perhaps the two can be compared and reconciled so that both can be credited on the commit. -- ___ Python tracker

[issue25548] Show the address in the repr for class objects

2016-06-03 Thread Kushal Das
Kushal Das added the comment: Hey Raymond, I am uploading the patch which I almost committed along with whats new update :) I am also reassigning the ticket to you so that you can decide the next steps. -- assignee: kushal.das -> rhettinger Added file: http://bugs.python.org/file43153/i

[issue27182] PEP 519 support in the stdlib

2016-06-03 Thread Jelle Zijlstra
Jelle Zijlstra added the comment: FYI, I'm working on a patch for builtins.open to call PyOS_FSPath. -- nosy: +Jelle Zijlstra ___ Python tracker ___ _

[issue26915] Test identity first in membership operation of ItemsView, ValuesView and Sequence in collections.abc

2016-06-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Oh, sorry, I was absentminded. In general the patch LGTM. But I think that using list subclass for tests is not a good idea. If we make a typo in CustomSequence method name (__contain__, inedx, coumt), the test is still passed. It would be better to use a cl

[issue26915] Test identity first in membership operation of ItemsView, ValuesView and Sequence in collections.abc

2016-06-03 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue27073] redundant checks in long_add and long_sub

2016-06-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Maybe add an assert for the second size negation? -- ___ Python tracker ___ ___ Python-bugs-list m

[issue5124] IDLE - pasting text doesn't delete selection

2016-06-03 Thread Terry J. Reedy
Terry J. Reedy added the comment: I just got a complaint from a Linux user who says IDLE is the only application she uses on Linux that has this augment rather than replace behavior. She also uses IDLE on Windows, so this unique IDLE-Linux behavior is quite annoying. Replace at least needs t

[issue27186] add os.fspath()

2016-06-03 Thread Dusty Phillips
Dusty Phillips added the comment: Adding a glossary entry for path-like. The references are all correct except: :class:`os.PathLike` doesn't link to anything because PathLike hasn't been added to the os module yet. Similarly, :meth:`__fspath__` does not link to anything, although I think this

[issue27186] add os.fspath()

2016-06-03 Thread Dusty Phillips
Changes by Dusty Phillips : Removed file: http://bugs.python.org/file43154/issue27186-glossary.buchuki.patch ___ Python tracker ___ ___ Python

[issue27186] add os.fspath()

2016-06-03 Thread Dusty Phillips
Changes by Dusty Phillips : Added file: http://bugs.python.org/file43155/issue27186-glossary.buchuki.patch ___ Python tracker ___ ___ Python-b

[issue5124] IDLE - pasting text doesn't delete selection

2016-06-03 Thread R. David Murray
R. David Murray added the comment: For what it is worth, as a dedicated X11 user, *if* the target is already hilighted by the application I expect the replace behavior. But in my usage I never select the target myself, since that would replace my selection buffer. So in essence I'm seeing th

[issue26983] float() can return not exact float instance

2016-06-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you for your review Mark. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue26983] float() can return not exact float instance

2016-06-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 050e5f803999 by Serhiy Storchaka in branch 'default': Issue #26983: float() now always return an instance of exact float. https://hg.python.org/cpython/rev/050e5f803999 -- nosy: +python-dev ___ Python tra

[issue27182] PEP 519 support in the stdlib

2016-06-03 Thread Ethan Furman
Ethan Furman added the comment: Sorry, Serhiy, I had my module names mixed up. `nt` and `posix` are the same, but `ntpath` and `posixpath` are not (I may have those first two names wrong again, but hopefully you get the idea). -- ___ Python tracker

[issue27182] PEP 519 support in the stdlib

2016-06-03 Thread Jelle Zijlstra
Jelle Zijlstra added the comment: This patch makes the Python and C versions of open()/io.open() support the fspath protocol. -- keywords: +patch Added file: http://bugs.python.org/file43156/issue27182-open.patch ___ Python tracker

[issue27198] Adding an assertClose() method to unittest.TestCase

2016-06-03 Thread Chris Barker
New submission from Chris Barker: In py3.5, the math.isclose() function was added to the standard library. It can be used to compare floating point numbers to see if they are close to each other, rather than exactly equal. It's not a lot of code, but there are nuances that not every python use

[issue26983] float() can return not exact float instance

2016-06-03 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue27199] TarFile expose copyfileobj bufsize to improve throughput

2016-06-03 Thread Jason Fried
New submission from Jason Fried: The default of 16k while good for memory usage it is not well suited for all cases. if we increased this to 4MB we saw a pretty large improvement to tar file creation and extraction on linux servers. For a 1gb tar file containing 1024 random files each of 10MB

[issue27199] TarFile expose copyfileobj bufsize to improve throughput

2016-06-03 Thread Jason Fried
Changes by Jason Fried : -- keywords: +patch Added file: http://bugs.python.org/file43159/copybufsize.patch ___ Python tracker ___ ___

[issue24459] Mention PYTHONFAULTHANDLER in the man page

2016-06-03 Thread Joshua Jay Herman
Joshua Jay Herman added the comment: Ping. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue5124] IDLE - pasting text doesn't delete selection

2016-06-03 Thread Terry J. Reedy
Terry J. Reedy added the comment: Thank you David, that does help. Your comment emphasizes that on other systems and many other X-11 apps, the user already chooses 'replace' versus 'insert' by selecting a replacement or not. I presume the 'selection buffer' you refer to is different from th

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

2016-06-03 Thread Kaushik N
Changes by Kaushik N : Removed file: http://bugs.python.org/file43121/Issue16484_python3.6.patch ___ Python tracker ___ ___ Python-bugs-list m

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

2016-06-03 Thread Kaushik N
Kaushik N added the comment: Applied patch from sean.rodman. Created a tests. Incorporated comments from rdmurray -- Added file: http://bugs.python.org/file43160/Issue16484_rev_python3.6.patch ___ Python tracker __

[issue27184] Support path objects in the ntpath module

2016-06-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I think that if some high-level function uses os.path, it likely should convert Path argument to str either because the path should be saved as a string, or for performance if multiple os.path functions are called with the same argument. Note, that some os.p

[issue27190] Check sqlite3_version before allowing check_same_thread = False

2016-06-03 Thread Dave Sawyer
Dave Sawyer added the comment: This can go into bugfix branches. In fact, it's most likely to be helpful there because they are more likely to be running with a version of sqlite 10 years old. I use the sqlite3_libversion_number() call because I'm testing against the version of sqlite actually

[issue27167] subprocess reports signal as negative exit status, not documented

2016-06-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 365b5e6163a6 by Gregory P. Smith in branch 'default': signal, socket, and ssl module IntEnum constant name lookups now return a https://hg.python.org/cpython/rev/365b5e6163a6 -- ___ Python tracker

[issue27198] Adding an assertClose() method to unittest.TestCase

2016-06-03 Thread R. David Murray
R. David Murray added the comment: The word description of the meaning of the tolerance attributes told me absolutely nothing. The equation from the math.islcose docs makes it prefectly clear. So I think the formula should be included in the documentation. assertAlomstEqual has a delta attri

[issue15476] Index "code object" and link to code object definition

2016-06-03 Thread Tommy Beadle
Tommy Beadle added the comment: Using .. index:: object: code puts a 'code' entry under 'object' as well as 'object' under 'code'. That's the way it is for every other item that uses "object: XXX". So if you want a new 'code object' top-level item and keep 'object -> code', you're going

[issue27167] subprocess reports signal as negative exit status, not documented

2016-06-03 Thread Gregory P. Smith
Changes by Gregory P. Smith : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue27113] sqlite3 connect parameter "check_same_thread" not documented

2016-06-03 Thread Dave Sawyer
Dave Sawyer added the comment: hurray! My first commit -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https

[issue27184] Support path objects in the ntpath module

2016-06-03 Thread Ethan Furman
Ethan Furman added the comment: The expected scenario, and the purpose of os.fspath(), is to enable high-level libraries to not know or care if they receive a pathlib object or a string. In other words, they already have os.path.join() and os.path.split() calls, and currently break noisily if

[issue24759] Idle: require tk 8.5 and ttk widgets, and drop unneeded code.

2016-06-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Did you try to run tests with Tk 8.4? -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue27113] sqlite3 connect parameter "check_same_thread" not documented

2016-06-03 Thread Thomas Kluyver
Thomas Kluyver added the comment: Congrats! :-) -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue27051] Create PIP gui

2016-06-03 Thread Terry J. Reedy
Terry J. Reedy added the comment: There is apparently no way to insert widgets in a Treeview -- text only. See for instance https://stackoverflow.com/questions/16755176/tkinter-insert-a-combobox-inside-a-treeview-widget. I don't know whether clicks on a row can be pinpointed to a specific fi

[issue17888] docs: more information on documentation team

2016-06-03 Thread Laura Rupprecht
Laura Rupprecht added the comment: I've updated the patch from Terry with Berker's suggestion. -- nosy: +laura Added file: http://bugs.python.org/file43162/issue17888_2.patch ___ Python tracker

[issue22558] Missing doc links to source code for Python-coded modules.

2016-06-03 Thread Terry J. Reedy
Terry J. Reedy added the comment: For me, the issue is willingness, not permission ;-). Reviewing a patch includes somehow indicating changes needed to apply it 'today', and a revised patch is the best way. Please say whether the header changes are in 3.6 only (in which case a separate 3.5 p

  1   2   3   >