Oren Milman added the comment:

After giving it some more thought, I feel somewhat uncertain about that check 
for a failure after using _PyLong_Negate.

At first I noticed that after every call to _PyLong_Negate there is such a 
check. But then I realized that in my patch, and also in long_mul (in the 
default branch of CPython), the check is unnecessary, as z is just returned 
after the call to _PyLong_Negate.

Is adding such a check anyway (e.g. in long_mul) a convention? Or should such 
checks be removed?

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue27145>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to