[issue15379] Charmap decoding of no-BMP characters

2012-11-17 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- stage: commit review -> committed/rejected ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue9742] Python 2.7: math module fails to build on Solaris 9

2012-11-17 Thread Roundup Robot
Roundup Robot added the comment: New changeset ff300ccd119d by Mark Dickinson in branch '2.7': Issue #9742: Sneaky fix for build failure on Solaris 9. http://hg.python.org/cpython/rev/ff300ccd119d -- nosy: +python-dev ___ Python tracker

[issue9742] Python 2.7: math module fails to build on Solaris 9

2012-11-17 Thread Mark Dickinson
Mark Dickinson added the comment: Matt: thanks for testing. Patch applied---this should be fixed now. I'm a little bit nervous about this one, since it may introduce new failures on systems with a buggy round implementation (Linux / alpha, for example). Still, we have tests for that, so I'l

[issue16487] Allow ssl certificates to be speficfied from memory rather than files.

2012-11-17 Thread Kristján Valur Jónsson
Kristján Valur Jónsson added the comment: The please don't. I'm actually growing tired of the way you seem to always latch onto every submission I make almost with hostility. I will find someone else to look this over. -- ___ Python tracker

[issue2953] _zip_directory_cache untested and undocumented

2012-11-17 Thread Éric Araujo
Éric Araujo added the comment: Eric, as you know importlib, can you comment about this? If zipimport now works with the invalidate_caches system, then we do have a documented way of clearing the cache, and I would recommend closing this bug (the existing attribute should stay for compat, but

[issue2953] _zip_directory_cache untested and undocumented

2012-11-17 Thread Eric Snow
Eric Snow added the comment: I'll take a look but can't say when. My wife's is having a baby in the next couple days so I'm a bit swamped. :) -- ___ Python tracker ___

[issue16487] Allow ssl certificates to be speficfied from memory rather than files.

2012-11-17 Thread Antoine Pitrou
Antoine Pitrou added the comment: > The please don't. I'm actually growing tired of the way you seem to > always latch onto every submission I make almost with hostility. I > will find someone else to look this over. I fully realize my reply was blunt. But perhaps you could try to understand tha

[issue2953] _zip_directory_cache untested and undocumented

2012-11-17 Thread Éric Araujo
Éric Araujo added the comment: No problem (and congratulations :) -- nosy: +ncoghlan ___ Python tracker ___ ___ Python-bugs-list mailin

[issue16495] bytes_decode() unnecessarily examines encoding

2012-11-17 Thread Chris Jerdonek
New submission from Chris Jerdonek: The code below in bytes_decode() is unnecessary: if (encoding == NULL) encoding = PyUnicode_GetDefaultEncoding(); (from http://hg.python.org/cpython/file/e9af9b1ca67e/Objects/bytesobject.c#l2230 ) because PyUnicode_FromEncodedObject() already ha

[issue16496] Simplify and optimize random_seed()

2012-11-17 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: Now random_seed() use an ineffective quadratic-time algorithm. It can reuse _PyLong_AsByteArray(), decreasing code size and increasing performance. -- components: Extension Modules files: random_seed.patch keywords: patch messages: 175812 nosy: mar

[issue16495] bytes_decode() unnecessarily examines encoding

2012-11-17 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- stage: -> needs patch ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://

[issue16495] bytes_decode() unnecessarily examines encoding

2012-11-17 Thread Chris Jerdonek
Chris Jerdonek added the comment: For the record, there is a test for the default encoding: http://hg.python.org/cpython/file/e9af9b1ca67e/Lib/test/test_bytes.py#l209 -- ___ Python tracker

[issue16464] urllib.request: opener not resetting content-length

2012-11-17 Thread Alexey Kachayev
Alexey Kachayev added the comment: This is special case for more "general" problem. When request is executed with HTTP client and data is not None, it calculates content length and adds special header to request. Then one can change request.data attribute value, but header "Content-length" is

[issue8627] Unchecked PyErr_WarnPy3k return value in Objects/typeobject.c

2012-11-17 Thread Brett Cannon
Brett Cannon added the comment: Go ahead and reopen. I just couldn't find the lines anymore when I closed it. On Nov 17, 2012 3:07 PM, "Mark Dickinson" wrote: > > Mark Dickinson added the comment: > > To clarify, here's the bug: the following code should raise an exception, > but doesn't: > >

[issue16215] Possible double memory free in str.replace

2012-11-17 Thread Roundup Robot
Roundup Robot added the comment: New changeset 26e5234239ae by Antoine Pitrou in branch '3.3': Issue #16215: Fix potential double memory free in str.replace(). http://hg.python.org/cpython/rev/26e5234239ae New changeset 5f2624db78bd by Antoine Pitrou in branch 'default': Issue #16215: Fix potent

[issue16215] Possible double memory free in str.replace

2012-11-17 Thread Antoine Pitrou
Antoine Pitrou added the comment: Committed, thank you. -- nosy: +pitrou resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___

[issue10182] match_start truncates large values

2012-11-17 Thread Antoine Pitrou
Antoine Pitrou added the comment: Patch looks good to me. Do you think it's possible to add some bigmem tests for this? -- ___ Python tracker ___ ___

[issue13572] import _curses fails because of UnicodeDecodeError('utf8' codec can't decode byte 0xb5 ...') on ARM Ubuntu 3.x

2012-11-17 Thread STINNER Victor
STINNER Victor added the comment: > The issue obviously in PyUnicode_FromString() call from > PyCursesWindow_GetKey(). > We can try latin1 encoding, locale encoding or utf-8 with surrogateescape > error handler. PyUnicode_FromString() uses the UTF-8 decoder. I don't think that curses uses any

[issue16496] Simplify and optimize random_seed()

2012-11-17 Thread Martin v . Löwis
Martin v. Löwis added the comment: Why is this a problem? -- nosy: +loewis ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue16496] Simplify and optimize random_seed()

2012-11-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This is not a problem at all. This just a code cleanup. Removing a code duplicate. Performance boost is a side effect. I confused by an old code comment about _PyLong_AsByteArray(). I don't see any difficulties. -- _

[issue10182] match_start truncates large values

2012-11-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I can't write a test, because I have no such big memory. -- ___ Python tracker ___ ___ Python-bugs

[issue16475] Support object instancing and recursion in marshal

2012-11-17 Thread Martin v . Löwis
Martin v. Löwis added the comment: When I added interning support to marshal, I specifically cared about the size of pyc. I find it sad that this support was thrown out, so I support restoring it. I'm also skeptical about general sharing, and would like to see some specific numbers pointing o

[issue16408] FD leaks in zipfile

2012-11-17 Thread Roundup Robot
Roundup Robot added the comment: New changeset d51d95c9ea81 by Antoine Pitrou in branch '3.2': Issue #16408: Fix file descriptors not being closed in error conditions in the zipfile module. http://hg.python.org/cpython/rev/d51d95c9ea81 New changeset 27cb1a3d57c8 by Antoine Pitrou in branch '3.3

[issue16408] FD leaks in zipfile

2012-11-17 Thread Roundup Robot
Roundup Robot added the comment: New changeset eba28506eed3 by Antoine Pitrou in branch '2.7': Issue #16408: Fix file descriptors not being closed in error conditions in the zipfile module. http://hg.python.org/cpython/rev/eba28506eed3 -- ___ Python

[issue16408] FD leaks in zipfile

2012-11-17 Thread Antoine Pitrou
Antoine Pitrou added the comment: Thank you for the patches. They looked fine, so I committed them. -- nosy: +pitrou resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker

[issue16496] Simplify and optimize random_seed()

2012-11-17 Thread Martin v . Löwis
Martin v. Löwis added the comment: Ah. The cleanup looks good, from a shallow glance. I haven't verified yet that the change is actually correct. -- ___ Python tracker ___ _

[issue16477] tarfile fails to close file handles in case of exception

2012-11-17 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue16423] urllib data URL

2012-11-17 Thread Antoine Pitrou
Antoine Pitrou added the comment: A couple of comments: - the patch needs a test (and docs too) - are you sure ignoring POSTed data is the right thing to do? Shouldn't we forbid it instead? - I think it would be nice to reference the RFC number somewhere - not sure why you raise IOError on a ba

[issue16497] zipimport.zipimporter.find_module() does not work with dotted module names

2012-11-17 Thread Berker Peksag
New submission from Berker Peksag: I am trying to write a test for issue 8585. The `zipimport.zipimporter.find_module()` docs says: "Search for a module specified by fullname. fullname must be the fully qualified (dotted) module name." (from http://docs.python.org/3.4/library/zipimport.html#z

[issue15031] Split .pyc parsing from module loading

2012-11-17 Thread Nick Coghlan
Nick Coghlan added the comment: "parse_cache_contents" is my last proposed colour for the shed, but I can live with "parse_bytecode_container" -- ___ Python tracker ___ _

[issue16423] urllib data URL

2012-11-17 Thread Mathias Panzenböck
Mathias Panzenböck added the comment: On 11/18/2012 12:36 AM, Antoine Pitrou wrote: > > Antoine Pitrou added the comment: > > A couple of comments: > > - the patch needs a test (and docs too) Will do (when I have time). > - are you sure ignoring POSTed data is the right thing to do? Shouldn't w

[issue16497] zipimport.zipimporter.find_module() does not work with dotted module names

2012-11-17 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: +brett.cannon, ncoghlan ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue16335] Integer overflow in unicode-escape decoder

2012-11-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Terry, can you measure how much memory tests really needed (3.2 and 3.3 should want different quantity)? Looks as I wrong in my assumptions. -- ___ Python tracker __

[issue16423] urllib data URL

2012-11-17 Thread Antoine Pitrou
Antoine Pitrou added the comment: > > - are you sure ignoring POSTed data is the right thing to do? Shouldn't we > > forbid it instead? > > - I think it would be nice to reference the RFC number somewhere > > - not sure why you raise IOError on a bad URL; I would say ValueError is > > the right

[issue2005] posixmodule expects sizeof(pid_t/gid_t/uid_t) <= sizeof(long)

2012-11-17 Thread Antoine Pitrou
Antoine Pitrou added the comment: > I think the patch will break on Unix systems that don't have uid_t or > gid_t types. Do these exist? uid_t and gid_t are part of POSIX: http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/sys_types.h.html --

[issue2005] posixmodule expects sizeof(pid_t/gid_t/uid_t) <= sizeof(long)

2012-11-17 Thread STINNER Victor
STINNER Victor added the comment: > On some OSes and combination of 64bit typess and 32bit long > it's an invalid assumption. Can you give an example of OS where pid_t, gid_t or uid_t type are longer than the long type? (If I remember correctly, the "identifier" of a Windows process is an addr

[issue11679] readline interferes with characters beginning with byte \xe9

2012-11-17 Thread Éric Araujo
Éric Araujo added the comment: Original bug report: https://github.com/ipython/ipython/issues/58 -- nosy: +eric.araujo stage: -> needs patch versions: +Python 3.4 ___ Python tracker ___

[issue11679] readline interferes with characters beginning with byte \xe9

2012-11-17 Thread STINNER Victor
STINNER Victor added the comment: I confirm that the issue exists, but I don't think that it comes from Python. I bet that the readline library uses *byte* string, not *character* string, and so is unable to handle correctly multibyte characters like the chinese character U+9000. --

[issue2005] posixmodule expects sizeof(pid_t/gid_t/uid_t) <= sizeof(long)

2012-11-17 Thread Trent Nelson
Changes by Trent Nelson : -- nosy: +trent ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org

[issue16497] zipimport.zipimporter.find_module() does not work with dotted module names

2012-11-17 Thread Brett Cannon
Brett Cannon added the comment: It actually does work, you just have to embed the subdirectory in the path you pass to zipimport.zipimporter(): >>> importer = zipimport.zipimporter('zipimport_example.zip/package/') >>> importer.find_module('package.eggs') -- resolution: -> invalid st

[issue15031] Split .pyc parsing from module loading

2012-11-17 Thread Brett Cannon
Brett Cannon added the comment: I can go with parse_cache_contents() as that aligns with imp.cache_from_source(). Does the API look reasonable (other than the parameter names since those would have to be renamed to be more in line with "cache")? Only thing I'm worried about. --

[issue16423] urllib data URL

2012-11-17 Thread Mathias Panzenböck
Mathias Panzenböck added the comment: On 11/18/2012 12:36 AM, Antoine Pitrou wrote: > > - the patch needs a test (and docs too) > - are you sure ignoring POSTed data is the right thing to do? Shouldn't we > forbid it instead? Btw.: The file:// protocol handler also just ignores posted data, so

[issue10966] eliminate use of ImportError implicitly representing SkipTest

2012-11-17 Thread Roundup Robot
Roundup Robot added the comment: New changeset eb3714863872 by Brett Cannon in branch 'default': Issue #10966: Remove the concept of unexpected skipped tests. http://hg.python.org/cpython/rev/eb3714863872 -- nosy: +python-dev ___ Python tracker

[issue10966] eliminate use of ImportError implicitly representing SkipTest

2012-11-17 Thread Brett Cannon
Changes by Brett Cannon : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue10966] eliminate use of ImportError implicitly representing SkipTest

2012-11-17 Thread Brett Cannon
Changes by Brett Cannon : -- stage: patch review -> committed/rejected ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue16423] urllib data URL

2012-11-17 Thread Mathias Panzenböck
Mathias Panzenböck added the comment: Ok, I've added a documentation and some tests. Is it ok this way? More tests? More/other documentation? -- Added file: http://bugs.python.org/file28017/urllib.request-data-url.patch ___ Python tracker

[issue16423] urllib data URL

2012-11-17 Thread Mathias Panzenböck
Changes by Mathias Panzenböck : Removed file: http://bugs.python.org/file28017/urllib.request-data-url.patch ___ Python tracker ___ ___ Python

[issue16423] urllib data URL

2012-11-17 Thread Mathias Panzenböck
Changes by Mathias Panzenböck : Added file: http://bugs.python.org/file28018/urllib.request-data-url.patch ___ Python tracker ___ ___ Python-b

[issue16423] urllib data URL

2012-11-17 Thread Mathias Panzenböck
Changes by Mathias Panzenböck : Removed file: http://bugs.python.org/file27994/urllib.request-data-url.patch ___ Python tracker ___ ___ Python

[issue16335] Integer overflow in unicode-escape decoder

2012-11-17 Thread Terry J. Reedy
Terry J. Reedy added the comment: Serhiy, please be more specific as to 'measure' and 'how much' for what effect. I ran two examples, one ran (with error), the other raised. -- ___ Python tracker _

<    1   2