[issue14053] Make patchcheck work with MQ

Nadeem Vawda added the comment: Patch looks good; I've just got one more small suggestion. The variable 'some_applied' in mq_patches_applied isn't really necessary - it would be clearer if you just said: return st.returncode == 0 and bstdout after the call to st.communicate(). > Interes

[issue13866] {urllib, urllib.parse}.urlencode should not use quote_plus

Changes by Michele Orrù : -- nosy: +maker ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.or

[issue14072] urlparse on tel: URI-s misses the scheme in some cases

Changes by Ivan Herman : -- components: None nosy: ivan_herman priority: normal severity: normal status: open title: urlparse on tel: URI-s misses the scheme in some cases type: behavior versions: Python 2.7 ___ Python tracker

[issue14072] urlparse on tel: URI-s misses the scheme in some cases

New submission from Ivan Herman : I think that the screen dump below is fairly clear: 10:41 Ivan> python Python 2.7.2 (v2.7.2:8527427914a2, Jun 11 2011, 15:22:34) [GCC 4.2.1 (Apple Inc. build 5666) (dot 3)] on darwin Type "help", "copyright", "credits" or "license" for more information. >>> imp

[issue13703] Hash collision security issue

STINNER Victor added the comment: > Question: Should sys.flags.hash_randomization be True (1) when > PYTHONHASHSEED=0?  It is now. > > Saying yes "working as intended" is fine by me. It is documented that PYTHONHASHSEED=0 disables the randomization, so sys.flags.hash_randomization must be Fals

[issue13703] Hash collision security issue

Marc-Andre Lemburg added the comment: Gregory P. Smith wrote: > > Gregory P. Smith added the comment: > > Question: Should sys.flags.hash_randomization be True (1) when > PYTHONHASHSEED=0? It is now. The flag should probably be removed - simply because the env var is not a flag, it's a con

[issue14072] urlparse on tel: URI-s misses the scheme in some cases

Changes by Senthil Kumaran : -- assignee: -> orsenthil nosy: +orsenthil ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue13703] Hash collision security issue

Marc-Andre Lemburg added the comment: STINNER Victor wrote: > > STINNER Victor added the comment: > >> Question: Should sys.flags.hash_randomization be True (1) when >> PYTHONHASHSEED=0? It is now. >> >> Saying yes "working as intended" is fine by me. > > It is documented that PYTHONHASHSE

[issue14068] problem with re split

Ramchandra Apte added the comment: 启朗.杨, are you using text.split() in the second case? text.split() splits on any whitespace character including newlines while re.split(text," ") splits on a space. -- nosy: +ramchandra.apte ___ Python tracker

[issue14068] problem with re split

harvey yang added the comment: i am not use it to split whitespace or newline. i use it to split Chinese full stop. and the result is showed at the earlier message. -- ___ Python tracker _

[issue14068] problem with re split

Amaury Forgeot d'Arc added the comment: When you used str split, you had to use a unicode string: content.split(u'。') It's the same with re.split: when I use pattern = re.compile('。') nothing is split, it works much better with: pattern = re.compile(u'。') -- nosy: +amaury.forgeotd

[issue14070] Idea: Add a flag to reload from source, e.g. reload(module, ignore_pyc=True)

Changes by Tim McNamara : -- title: reload(module, ignore_pyc=True) flag -> Idea: Add a flag to reload from source, e.g. reload(module, ignore_pyc=True) ___ Python tracker ___ _

[issue14034] Add argparse howto

Steven Bethard added the comment: I have no objections on adding a howto, and something like the attached patch would be fine with me (though I don't have time to review it in full and trust you to). You might want to coordinate with Issue 13850 a bit - they want a quick reference table befo

[issue14068] problem with re split

Ramchandra Apte added the comment: The problem is not in re, it is because you are passing '。' to re.split which in Python 2.x is actually passed as '\xe3\x80\x82'. You should pass u'。' to re.compile. Could we raise a SyntaxError when in a progam a unicode character is in a bytes string? Pytho

[issue13703] Hash collision security issue

Antoine Pitrou added the comment: > That is a good question. I don't really care either way, but let's > say +0 for turning it off when seed == 0. +1 -- ___ Python tracker ___

[issue8033] sqlite: broken long integer handling for arguments to user-defined functions

Roundup Robot added the comment: New changeset e67715b87131 by Petri Lehtinen in branch '3.2': sqlite3: Fix 64-bit integer handling in user functions on 32-bit architectures http://hg.python.org/cpython/rev/e67715b87131 New changeset cf12fe9ce2b0 by Petri Lehtinen in branch 'default': Merge bra

[issue14071] allow more than one hash seed per process (move _Py_HashSecret into PyInterpreterState)

Changes by Antoine Pitrou : -- nosy: +grahamd ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue10181] Problems with Py_buffer management in memoryobject.c (and elsewhere?)

Nick Coghlan added the comment: Latest version looks good to me - I vote for landing it whenever you're ready :) -- ___ Python tracker ___ __

[issue14073] allow per-thread atexit()

New submission from Tarek Ziadé : If you try to run the code below and stop it with ctrl+C, it will lock because atexit is never reached. Antoine proposed to add a way to have one atexit() per thread, so we can call some cleanup code when the app shuts down and there are running threads. {{{

[issue14073] allow per-thread atexit()

Changes by Tarek Ziadé : -- nosy: +pitrou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.or

[issue14073] allow per-thread atexit()

Changes by Antoine Pitrou : -- components: +Interpreter Core, Library (Lib) nosy: +neologix type: behavior -> enhancement versions: -Python 3.2, Python 3.4 ___ Python tracker __

[issue13703] Hash collision security issue

Barry A. Warsaw added the comment: On Feb 21, 2012, at 09:48 AM, Marc-Andre Lemburg wrote: >Exposing the seed value as sys.hashseed would be better and more useful >to applications. That makes the most sense to me. -- ___ Python tracker

[issue13703] Hash collision security issue

Barry A. Warsaw added the comment: On Feb 21, 2012, at 09:48 AM, Marc-Andre Lemburg wrote: >The flag should probably be removed - simply because >the env var is not a flag, it's a configuration parameter. > >Exposing the seed value as sys.hashseed would be better and more useful >to application

[issue10580] Minor grammar change in Python’s MSI installer

Roundup Robot added the comment: New changeset d9e895d07396 by Martin v. Löwis in branch '2.7': Issue #10580: Minor grammar change in Windows installer. http://hg.python.org/cpython/rev/d9e895d07396 -- nosy: +python-dev ___ Python tracker

[issue10580] Minor grammar change in Python’s MSI installer

Roundup Robot added the comment: New changeset b349c932765a by Martin v. Löwis in branch '3.2': Issue #10580: Minor grammar change in Windows installer. http://hg.python.org/cpython/rev/b349c932765a -- ___ Python tracker

[issue10580] Minor grammar change in Python’s MSI installer

Martin v. Löwis added the comment: This is now fixed in all relevant branches. -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___

[issue13703] Hash collision security issue

Gregory P. Smith added the comment: +1 to what barry and __ap__ discussed and settled on. -- ___ Python tracker ___ ___ Python-bugs-l

[issue13863] import.c sometimes generates incorrect timestamps on Windows + NTFS

Martin v. Löwis added the comment: For some reason that I'm unable to follow right now, fstat in the crt does this dance to obtain st_mtime: - obtain time stamps using GetFileInformationByHandle - convert ftLastWriteTime using FileTimeToLocalFileTime to LocalFTime - convert LocalFTime using Fil

[issue6807] No such file or directory: 'msisupport.dll' in msi.py

Roundup Robot added the comment: New changeset bc66484b0d73 by Martin v. Löwis in branch '3.2': Issue #6807: Run msisupport.mak earlier. http://hg.python.org/cpython/rev/bc66484b0d73 -- nosy: +python-dev ___ Python tracker

[issue6807] No such file or directory: 'msisupport.dll' in msi.py

Roundup Robot added the comment: New changeset e78acdb54841 by Martin v. Löwis in branch '2.7': Issue #6807: Run msisupport.mak earlier. http://hg.python.org/cpython/rev/e78acdb54841 -- ___ Python tracker _

[issue6807] No such file or directory: 'msisupport.dll' in msi.py

Martin v. Löwis added the comment: This is now fixed, though in a different way. -- resolution: -> fixed status: open -> closed ___ Python tracker ___ __

[issue1521950] shlex.split() does not tokenize like the shell

Changes by Vinay Sajip : Added file: http://bugs.python.org/file24590/079ab75d29a4.diff ___ Python tracker ___ ___ Python-bugs-list mailing

[issue1521950] shlex.split() does not tokenize like the shell

Vinay Sajip added the comment: I updated the patch to reflect Éric's comments on Rietveld, but there are also some other changes: Previously when punctuation chars were set, wordchars was being augmented by '-'. This was incomplete, so the augmentation is now with '~-./*?=' which allows for

[issue1521950] shlex.split() does not tokenize like the shell

Vinay Sajip added the comment: Plus I also changed a few instances of the anachronism a = a + b to a += b -- ___ Python tracker ___

[issue14074] argparse does not allow nargs>1 for positional arguments but doesn't allow metavar to be a tuple

New submission from Tshepang Lekhonkhobe : Here's four commands to demonstrate my problem: My sample code: $ cat prog.py import argparse parse = argparse.ArgumentParser() parse.add_argument("foo", nargs=2, metavar=("foo", "bar")) args = parse.parse_args() print(args) This output could be frien

[issue12406] msi.py needs updating for Python 3.3

Roundup Robot added the comment: New changeset 2fed68cf102a by Martin v. Löwis in branch 'default': Issue #12406: prevent case where shortened name could conflict with short name. http://hg.python.org/cpython/rev/2fed68cf102a -- ___ Python tracker <

[issue14060] Implement a CSP-style channel

Guido van Rossum added the comment: I'd like to veto changing the meaning of 0, it's going to break somebody's code. It's easy enough to add some other keyword argument to request an unbuffered queue. Other than that, (1) and (2) seem fine to me. Please consider making these changes for mul

[issue8942] __path__ attribute of modules loaded by zipimporter is untested

Changes by Brett Cannon : -- nosy: -brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue14070] Idea: Add a flag to reload from source, e.g. reload(module, ignore_pyc=True)

Brett Cannon added the comment: I don't quite follow what you want. You say you want to *ignore* changes to source files, but that's the whole point of a reload. And I don't see how ignoring bytecode changes anything unless you are mucking with bytecode formats and don't want to have to conti

[issue14070] Idea: Add a flag to reload from source, e.g. reload(module, ignore_pyc=True)

Tim McNamara added the comment: No no, I don't want to ignore source files. I want to be able to change a .py file, then reload in the Python shell and for the changes to be applied. At the moment, .pyc files within a project complicate this. -- __

[issue14075] argparse: unused method?

New submission from Tshepang Lekhonkhobe : It appears to me that the function I removed (see attached patch) is unused. Since I wasn't sure, I ran the entire test suite, and there wasn't a regression. -- components: Library (Lib) files: rm-unused-function.patch keywords: patch messages:

[issue9098] MSYS build fails with `S_IXGRP' undeclared

mewalig added the comment: If I am reading this right, then in the below part of the patch, slave_name does not get set before it is used if __MINGW32__ is not defined. this can be fixed by moving the "#endif" up to the line before slave_name = ptsname(master_fd); /* get name of slave */

[issue14067] Avoid more stat() calls in importlib

Antoine Pitrou added the comment: > While I don't think the delay in noticing filesystem changes is > reasonable as the default behaviour, it might be interesting to see how > tricky it would be to create a custom importer (for either meta_path or > path_hooks) that did this. Mmmh. Then I thi

[issue14070] Idea: Add a flag to reload from source, e.g. reload(module, ignore_pyc=True)

Brett Cannon added the comment: Then I'm not understanding the problem as changes to source trump .pyc files in a reload(). It should make no difference that .pyc files even exist to a reload() as long as source is around. -- status: open -> pending __

[issue12406] msi.py needs updating for Python 3.3

Roundup Robot added the comment: New changeset 75990a013d4d by Martin v. Löwis in branch 'default': Issue #12406: Update list of files. http://hg.python.org/cpython/rev/75990a013d4d -- ___ Python tracker _

[issue12406] msi.py needs updating for Python 3.3

Martin v. Löwis added the comment: msi.py is now up-to-date as of 75990a013d4d. If further changes are made to the tree that require further changes to msi.py, a new issue should be opened. -- resolution: -> fixed status: open -> closed ___ Python

[issue8033] sqlite: broken long integer handling for arguments to user-defined functions

Petri Lehtinen added the comment: Thanks for the patches, Philippe! I committed the latest one after some modifications. -- ___ Python tracker ___ __

[issue14075] argparse: unused method?

Changes by Nadeem Vawda : -- nosy: +bethard ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue14076] sqlite3 module ignores placeholers in CREATE TRIGGER code

New submission from GuGu : When I try to use placeholders in CREATE TRIGGER (for django-denorm module) SQLite module just ignores placeholders and sends `None` to it. For example: In [11]: c.cursor().execute('CREATE TRIGGER test1 after insert on a for each row begin UPDATE a SET b=?; END',

[issue14075] argparse: unused method?

Petri Lehtinen added the comment: The _get_args() looks like an obsolete function indeed. However, _AttributeHolder is a base class for other classes, so the function was probably meant to be overridden by a subclass. Steven probably knows the best whether it should be kept or not. -

[issue14077] sporadic test_multiprocessing failure

New submission from Antoine Pitrou : Just saw this on a buildbot: == ERROR: test_rapid_restart (test.test_multiprocessing.WithProcessesTestManagerRestart) -- T

[issue14006] Improve the documentation of xml.etree.ElementTree

Leon Matthews added the comment: The ElementTree.py module has good JavaDoc-style function-level documentation, but as it's not in docstring format, it can't be seen from the interactive help. I'd be willing to convert the current comments into docstrings, as long as I wouldn't be stepping on

[issue14077] sporadic test_multiprocessing failure

Antoine Pitrou added the comment: I am proposing the following patch to have a better unique filename: diff --git a/Lib/importlib/_bootstrap.py b/Lib/importlib/_bootstrap.py --- a/Lib/importlib/_bootstrap.py +++ b/Lib/importlib/_bootstrap.py @@ -129,8 +129,8 @@ def _path_absolute(path): def

[issue14075] argparse: unused method?

Changes by Geoffrey Spear : -- nosy: +geoffreyspear ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue14077] sporadic test_multiprocessing failure

Brett Cannon added the comment: LGTM -- stage: -> commit review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue14071] allow more than one hash seed per process (move _Py_HashSecret into PyInterpreterState)

STINNER Victor added the comment: I'm not sure that it could work because many C functions use caches using static variables. Just a random example: int _PyUnicode_HasNULChars(PyObject* s) { static PyObject *nul = NULL; if (nul == NULL) nul = PyUnicode_FromStringAndSize("\0",

[issue14053] Make patchcheck work with MQ

Francisco Martín Brugué added the comment: Ok! I haven't added NEWS as I thing is easier for the person that applies the patch to simply write the line directly there instead of merging. Is that ok? let me know if something has to be improved. Thanks again for your mentoring this! -

[issue14077] sporadic test_multiprocessing failure

Charles-François Natali added the comment: > I am proposing the following patch to have a better unique > filename: It's unneeded, O_EXCL ensures the file won't be corrupted. It's actually a regression introduced by de6703671386. My bad. Here's a patch. -- keywords: +patch Added file:

[issue14073] allow per-thread atexit()

Graham Dumpleton added the comment: My take on this is that if wanting to interact with a thread from an atexit callback, you are supposed to call setDaemon(True) on the thread. This is to ensure that on interpreter shutdown it doesn't try and wait on the thread completing before getting to a

[issue14077] sporadic test_multiprocessing failure

Antoine Pitrou added the comment: > > I am proposing the following patch to have a better unique > > filename: > > It's unneeded, O_EXCL ensures the file won't be corrupted. > It's actually a regression introduced by de6703671386. My bad. > Here's a patch. But is there still a reason to use id

[issue14078] Add 'sourceline' property to xml.etree Elements

New submission from Leon Matthews : The lxml implementation of the ElementTree API puts a `sourceline` property onto every Element object, which I recently found useful when producing diagnostic messages. I think it would be a useful improvement to make the standard library's ElementTree impl

[issue14077] sporadic test_multiprocessing failure

Charles-François Natali added the comment: > But is there still a reason to use id(path) then? IIRC, the reason is to avoid having a stale pyc file indefinitely in case of crash: if we always used, let's say, path + '.tmp', if the process crashes before the rename, then all subsequent attempts

[issue14075] argparse: unused method?

Steven Bethard added the comment: Yeah, the intention was that you could just override _get_args in a subclass to get a better __repr__. I think these days all the argparse classes only have keyword arguments, so _get_args probably isn't necessary anymore. --

[issue14077] sporadic test_multiprocessing failure

Antoine Pitrou added the comment: > IIRC, the reason is to avoid having a stale pyc file indefinitely in > case of crash: > if we always used, let's say, path + '.tmp', if the process crashes > before the rename, then all subsequent attempts to write the bytecode > will fail because of the stale

[issue14077] sporadic test_multiprocessing failure

Charles-François Natali added the comment: > But that will also fail if id(path) happens to be fairly > deterministic Well, if you always get the same id(path), then yes, but I really doubt it, especially with CPython where it's the object's address (I guess there's the same chance of having

[issue14079] Problems with recent test_subprocess changes

New submission from Vinay Sajip : There appears to be a problem with a recent change made to test_subprocess to try and speed it up a bit. The commit with a problem seems to be 834650d63130 by Ross Lagerwall on 12 Feb 2012, and the problem is in test_poll(), which now looks like this: def

[issue14052] importlib mixes up '.' and os.getcwd()

Stefan Krah added the comment: It just happened again on the new FreeBSD-9.0 bot: http://www.python.org/dev/buildbot/all/builders/AMD64%20FreeBSD%208.2%203.x/builds/1845/steps/test/logs/stdio == FAIL: test_package___file__ (te

[issue14057] Speedup sysconfig startup

STINNER Victor added the comment: Updated patch: continue to simplify the config parser. Using this patch, Python startup is ~20% faster on my computer. Use http://bugs.python.org/file24447/bench_startup.py to measure startup time. -- Added file: http://bugs.python.org/file24595/sysco

[issue14057] Speedup sysconfig startup

Changes by STINNER Victor : Removed file: http://bugs.python.org/file24572/sysconfig_parser.patch ___ Python tracker ___ ___ Python-bugs-list

[issue13405] Add DTrace probes

Jesús Cea Avión added the comment: Dave, I am in Europe (Spain), and I can't afford (money and time) to go to PyCon. If you are going and are interested in pushing this, we can talk about our respectives ideas and plans, to present a consensus plan. -- ___

[issue12801] C realpath not used by os.path.realpath

STINNER Victor added the comment: realpath.patch: - Add os.realpath() - posixpath.realpath() uses os.realpath(), or os.getcwd() if the path is an empty string - os.realpath() uses canonicalize_file_name() if available, or use realpath() with a buffer of MAXPATHLEN bytes Don't use realpath

[issue14080] Sporadic test_imp failure

New submission from Antoine Pitrou : http://www.python.org/dev/buildbot/all/builders/AMD64%20FreeBSD%208.2%203.x/builds/1845/steps/test/logs/stdio == FAIL: test_package___file__ (test.test_imp.PEP3147Tests) -

[issue14080] Sporadic test_imp failure

Antoine Pitrou added the comment: Updated build URL (the buildbot changed name): http://www.python.org/dev/buildbot/all/builders/AMD64%20FreeBSD%209.0%203.x/builds/1845/steps/test/logs/stdio -- ___ Python tracker

[issue14068] problem with re split

harvey yang added the comment: i see. thanks :) -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue14081] Allow "maxsplit" argument to str.split() to be passed as a keyword argument

New submission from Nick Coghlan : Currently, setting maxsplit for the default "any whitespace" behaviour requires the following cryptic incantation: 'do re mi fa'.split(None, 1) That would be significantly more comprehensible as: 'do re mi fa'.split(maxsplit=1) (I noticed this when

[issue14068] problem with re split

Ezio Melotti added the comment: As long as you don't mix str and unicode everything works. With strings: >>> s = '与清新。阿德莱' >>> re.split('。', s) ['\xe4\xb8\x8e\xe6\xb8\x85\xe6\x96\xb0', '\xe9\x98\xbf\xe5\xbe\xb7\xe8\x8e\xb1'] >>> s.split('。') ['\xe4\xb8\x8e\xe6\xb8\x85\xe6\x96\xb0', '\xe9\x98\xb

[issue5411] Add xz support to shutil

Changes by Antoine Pitrou : -- nosy: +hynek ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue14082] shutil doesn't support extended attributes

New submission from Antoine Pitrou : shutil doesn't provide any function which copies extended attributes on files. Note that "cp -a" does copy xattrs, but "cp -p" doesn't (and copy2() claims to work like "cp -p"). -- components: Library (Lib) messages: 153922 nosy: benjamin.peterson,

[issue14083] Use local timezone offset by default in datetime.timezone

New submission from Nick Coghlan : Currently, datetime.timezone requires that the offset be specified explicitly. It would be more convenient if the local offset was used by default. Since the time module already exposes the offset details for the local timezone, this would just make: local

[issue14081] Allow "maxsplit" argument to str.split() to be passed as a keyword argument

Ezio Melotti added the comment: +1 Patch attached. -- assignee: -> ezio.melotti keywords: +patch nosy: +ezio.melotti stage: needs patch -> commit review Added file: http://bugs.python.org/file24597/issue14081.diff ___ Python tracker

[issue14083] Use local timezone offset by default in datetime.timezone

Alexander Belopolsky added the comment: The problem with this idea is that while evaluating datetime.datetime.now(datetime.timezone()), python will have to query the real time clock twice (first in timezone() and then in now()). At a particularly unfortunate time this may result in an error.

[issue14079] Problems with recent test_subprocess changes

Ross Lagerwall added the comment: This was hopefully fixed in e5a94b56d6bc. Was it one of the buildbots that was failing? -- ___ Python tracker ___

[issue14083] Use local timezone offset by default in datetime.timezone

Nick Coghlan added the comment: Marking as a duplicate of #9527. If that API is added, the local fixed offset timezone will be accessible as datetime.datetime.localtime().tzinfo which would be simple enough. -- resolution: -> duplicate superseder: -> Add aware local time support to

[issue14083] Use local timezone offset by default in datetime.timezone

Changes by Nick Coghlan : -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue9527] Add aware local time support to datetime module

Nick Coghlan added the comment: One important thing to remember is that once a time is in the past, whether or not DST was in effect for that time *is never going to change*. That means converting a DST aware timezone to a fixed offset timezone will work just fine for historical times. It's

[issue13405] Add DTrace probes

Marc Abramowitz added the comment: Jesús said he was focusing on Solaris and couldn't help with OS X. Not sure if anyone else was going to try tackling that... Just tried the patch `issue13405_4027.diff` on OS X 10.6.8. First problem I ran into was: gcc -fno-strict-aliasing -DNDEBUG -g -fwra