[issue9612] setobject.c warnings under 64-bit Windows

2010-08-17 Thread Antoine Pitrou
Antoine Pitrou added the comment: > I'm not sure whether backporting it to 3.1 is a good idea. It's > potentially an ABI change (although a minor one, as the field offsets > remain the same, only the interpretation of the padding may change). Well, it is unlikely that anyone is accessing setent

[issue9612] setobject.c warnings under 64-bit Windows

2010-08-17 Thread Martin v . Löwis
Martin v. Löwis added the comment: I'm not sure whether backporting it to 3.1 is a good idea. It's potentially an ABI change (although a minor one, as the field offsets remain the same, only the interpretation of the padding may change). -- ___ Pyt

[issue9612] setobject.c warnings under 64-bit Windows

2010-08-17 Thread Antoine Pitrou
Antoine Pitrou added the comment: This is now fixed in r84146 (py3k) and r84151 (3.1). I've made the "hash" field a Py_ssize_t, consistently with the dict implementation. -- resolution: -> fixed status: open -> closed ___ Python tracker

[issue9612] setobject.c warnings under 64-bit Windows

2010-08-15 Thread Antoine Pitrou
Antoine Pitrou added the comment: There is also a similar warning for deque iterators' __length_hint__ (line 1124 in _collectionsmodule.c). -- ___ Python tracker ___ ___

[issue9612] setobject.c warnings under 64-bit Windows

2010-08-15 Thread Raymond Hettinger
Raymond Hettinger added the comment: Antoine, thanks for posting these. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue9612] setobject.c warnings under 64-bit Windows

2010-08-15 Thread Martin v . Löwis
Martin v. Löwis added the comment: For the length hint, it would be best to use PyLong_FromSize_t, as in dictobject.c. It would be sad if __length_hint__ would return a much-too-small value (or even a negative number). For the search finger, dictobject has opted to make me_hash of type Py_ssi

[issue9612] setobject.c warnings under 64-bit Windows

2010-08-15 Thread Antoine Pitrou
New submission from Antoine Pitrou : None of these warnings look critical (one affects the "search finger" optimization of pop(), one affects the result from __length_hint__ on set iterators, and the other the hash value of frozensets without any obviously bad consequences), but you might want