[issue9584] Allow curly brace expansion

Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever versions: +Python 3.5 -Python 3.4 ___ Python tracker ___ ___ Python

[issue9584] Allow curly brace expansion

Changes by Julian Berman : -- nosy: +Julian ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue9584] Allow curly brace expansion

Changes by Janus Troelsen : -- nosy: +ysangkok ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue9584] Allow curly brace expansion

Changes by Serhiy Storchaka : -- stage: patch review -> ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://

[issue9584] Allow curly brace expansion

Tim Golden added the comment: Given that this isn't going to go ahead in its current form, and will need wider discussion on python-dev, I'm unassigning myself and I've removed the flawed version of the patch which I'd posted. -- assignee: tim.golden -> __

[issue9584] Allow curly brace expansion

Changes by Tim Golden : Removed file: http://bugs.python.org/file27894/0003-reworked-issue9584.patch ___ Python tracker ___ ___ Python-bugs-lis

[issue9584] Allow curly brace expansion

Serhiy Storchaka added the comment: > Given the backward compatibility concerns, and the fact that brace expansion > and wildcard expansion are conceptually separate operations, perhaps what we > should have a is a glob.expand_braces (or some such name) function? In this case it may be appropr

[issue9584] Allow curly brace expansion

R. David Murray added the comment: Given the backward compatibility concerns, and the fact that brace expansion and wildcard expansion are conceptually separate operations, perhaps what we should have a is a glob.expand_braces (or some such name) function? (Note: I haven't looked at whether o

[issue9584] Allow curly brace expansion

Serhiy Storchaka added the comment: > This may make this change untenable as no-one will want a series of > use_feature_xxx flags, one for each change we introduce to glob.glob. > Unless we throw in every known expansion / matching right now and have a > single use-extended-features flag. This i

[issue9584] Allow curly brace expansion

Tim Golden added the comment: Sorry, I misunderstood the point you were making with the os.listdir/makedirs examples. Fair point about backwards compatibility. This may make this change untenable as no-one will want a series of use_feature_xxx flags, one for each change we introduce to glob.glob.

[issue9584] Allow curly brace expansion

Serhiy Storchaka added the comment: I'm talking about glob.glob(), not about os.listdir(). Bakward incompatible features should be off by default. -- ___ Python tracker ___ _

[issue9584] Allow curly brace expansion

Tim Golden added the comment: Well even in the original [working] version, the scope of this change was limited to glob.glob. os.listdir doesn't currently support any form of expansion (at least not on Windows) and nor does os.makedirs. I don't see any problem in restricting this change -- and an

[issue9584] Allow curly brace expansion

Serhiy Storchaka added the comment: > I am absolutely sure this was working in my original submission, I had even > added unit tests for it: It can't be working in any implementation. >>> os.makedirs('a{b,c}d/e') >>> os.listdir('a{b,c}d') ['e'] >>> glob.glob('a{b,c}d/*') [] Was ['a{b,c}d/e']

[issue9584] Allow curly brace expansion

Roundup Robot added the comment: New changeset ec897bb38708 by Tim Golden in branch 'default': Reversed changes from issue9584 http://hg.python.org/cpython/rev/ec897bb38708 -- ___ Python tracker

[issue9584] Allow curly brace expansion

Tim Golden added the comment: Must have been something I did. I'll revert the commit and re-test. -- ___ Python tracker ___ ___ Python-

[issue9584] Allow curly brace expansion

Mathieu Bridon added the comment: >>> glob.glob('*.{sub,ac}') ['config.sub'] I'm surprised this broke, this is one of the behaviour I thought I had implemented in my original patch. :-/ > (and moreover, now it is impossible to glob for paths that contain braces) I am absolutely sure this was

[issue9584] Allow curly brace expansion

Serhiy Storchaka added the comment: >>> glob.glob('*.ac') ['configure.ac'] >>> glob.glob('*.sub') ['config.sub'] >>> glob.glob('*.{sub,ac}') ['config.sub'] And since these changes are backward incompatible (and moreover, now it is impossible to glob for paths that contain braces), I would prefe

[issue9584] Allow curly brace expansion

Roundup Robot added the comment: New changeset dafca4714298 by Tim Golden in branch 'default': issue9584: Add {} list expansion to glob. Original patch by Mathieu Bridon http://hg.python.org/cpython/rev/dafca4714298 -- nosy: +python-dev ___ Python tra

[issue9584] Allow curly brace expansion

Tim Golden added the comment: Scratch that last comment: the patch does apply. I've tested it against Windows & Ubuntu. If no one comes in with any objections I'll commit it within the next day. -- ___ Python tracker

[issue9584] Allow curly brace expansion

Tim Golden added the comment: Something went wrong with that patch; it doesn't include all the changes to test_glob. I'll upload a newer patch later. -- ___ Python tracker ___ __

[issue9584] Allow curly brace expansion

Tim Golden added the comment: Attached is a refactored version of Mathieu's patch which, when applied to tip, passes all tests. -- Added file: http://bugs.python.org/file27894/0003-reworked-issue9584.patch ___ Python tracker

[issue9584] Allow curly brace expansion

Mathieu Bridon added the comment: > " IIUC you're implementing comma-separated lists {abc,def} and nested braces > {a{b,c}d,efg} but not ranges {a..z}." Exactly. Although that's just because at the time I sent the patch, I didn't know about ranges in shells. So I just implemented the part of

[issue9584] Allow curly brace expansion

Tim Golden added the comment: I'm planning to refactor the tests and the code very slightly. When I've got a reworked patch I'll ping it back to you to ensure it matches your intent. IIUC you're implementing comma-separated lists {abc,def} and nested braces {a{b,c}d,efg} but not ranges {a..z}. -

[issue9584] Allow curly brace expansion

Mathieu Bridon added the comment: I have to apologize for not following up on this patch. At first I had no time to go on pushing for it, and then (after a change of job), I completely forgot about it. :( I guess rebasing the patch on the latest tip is not that useful if you already have done

[issue9584] Allow curly brace expansion

Tim Golden added the comment: I've got a patch for this which applies cleanly to the 3.4 tip. I still need to sort out the Windows issues (which I don't think will be difficult; it looks like a test issue, not a code issue) -- assignee: -> tim.golden _

[issue9584] Allow curly brace expansion

A.M. Kuchling added the comment: Help is still needed to debug the failing test_glob.py on Windows. I just tried this patch against 3.4trunk. The first hunk of the glob.py patch doesn't apply because 'for name in glob1(None, basename): yield name' was changed to 'yield from glob1(None, basena

[issue9584] Allow curly brace expansion

Changes by A.M. Kuchling : -- versions: +Python 3.4 -Python 3.3 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue9584] Allow curly brace expansion

Ezio Melotti added the comment: +if sub.find(',') != -1: Please use the 'in' operator here. -- nosy: +ezio.melotti ___ Python tracker ___

[issue9584] Allow curly brace expansion

Tim Golden added the comment: I've just rebuilt on Windows against tip. test_glob is failing: test test_glob failed -- Traceback (most recent call last): File "c:\work-in-progress\python\cpython-9584\lib\test\test_glob.py", line 135, in test_glob_curly_braces os.path.join('a', 'bcd', 'ef

[issue9584] Allow curly brace expansion

Mathieu Bridon added the comment: Is anybody still reading this? :-/ Could somebody commit the patch, reject it, or tell me what else I need to do? -- ___ Python tracker ___ ___

[issue9584] Allow curly brace expansion

Eric Smith added the comment: Yes, we recently switched to Mercurial. See http://docs.python.org/devguide/faq.html You shouldn't need to change your patches just because of the switch from svn. -- ___ Python tracker

[issue9584] Allow curly brace expansion

Mathieu Bridon added the comment: > "I removed the unused import (mostly as a simple test of mercurial, it's my > first commit there)." Does it mean that Python development is not being done in SVN, as the documentations state it? My patches have all been based on the SVN py3k branch, please

[issue9584] Allow curly brace expansion

Eric Smith added the comment: I removed the unused import (mostly as a simple test of mercurial, it's my first commit there). -- ___ Python tracker ___ _

[issue9584] Allow curly brace expansion

Mathieu Bridon added the comment: The sys module is imported in glob but never used. It's not related to this feature request but I saw it when implementing the patch, so here is a second patch removing the import. -- Added file: http://bugs.python.org/file21002/0002-Remove-unused-imp

[issue9584] Allow curly brace expansion

Changes by Mathieu Bridon : Removed file: http://bugs.python.org/file20129/0001-Curly-brace-expansion-in-glob.patch ___ Python tracker ___ ___

[issue9584] Allow curly brace expansion

Mathieu Bridon added the comment: So, now that Python 3.2 was released, here is a patch rebased on top of the py3k branch. -- Added file: http://bugs.python.org/file21001/0001-Curly-brace-expansion-in-glob.patch ___ Python tracker

[issue9584] Allow curly brace expansion

R. David Murray added the comment: Nope, you've got it. After the final release of Python 3.2, please post to the issue to remind us about it, and someone will commit the patch. (For future Python releases we expect that the delays in our ability to commit feature patches will be much short

[issue9584] Allow curly brace expansion

Mathieu Bridon added the comment: > Thanks for the research and the updated patch. Unfortunately as > a feature request this is going to have to wait for 3.3 since we > missed the pre-beta window. Ok. This is my first patch to Python, so I'm not sure what I should do to get this in. Is keep

[issue9584] Allow curly brace expansion

R. David Murray added the comment: Thanks for the research and the updated patch. Unfortunately as a feature request this is going to have to wait for 3.3 since we missed the pre-beta window. -- versions: +Python 3.3 -Python 3.2 ___ Python tracker

[issue9584] Allow curly brace expansion

Mathieu Bridon added the comment: This is the right patch, sorry for all the mail spam. :-/ -- Added file: http://bugs.python.org/file20129/0001-Curly-brace-expansion-in-glob.patch ___ Python tracker _

[issue9584] Allow curly brace expansion

Changes by Mathieu Bridon : Removed file: http://bugs.python.org/file20128/0001-Curly-brace-expansion-in-glob.patch.old ___ Python tracker ___ ___

[issue9584] Allow curly brace expansion

Mathieu Bridon added the comment: Same patch, but rebased to the current trunk so it still applies. -- Added file: http://bugs.python.org/file20128/0001-Curly-brace-expansion-in-glob.patch.old ___ Python tracker _

[issue9584] Allow curly brace expansion

Changes by Mathieu Bridon : Removed file: http://bugs.python.org/file19451/0001-Curly-brace-expansion-in-glob.patch ___ Python tracker ___ ___

[issue9584] Allow curly brace expansion

Éric Araujo added the comment: Latest patch looks good. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue9584] Allow curly brace expansion

Changes by Mathieu Bridon : Removed file: http://bugs.python.org/file18497/curly-fnmatch.patch ___ Python tracker ___ ___ Python-bugs-list mail

[issue9584] Allow curly brace expansion

Mathieu Bridon added the comment: I finally found the time to follow up on this issue, sorry for the absence of response. The thread on Python-Ideas didn't really lead to a consensus (nor did it generate a lot of discussion). Some wanted to see this in fnmatch, others in glob and others in s