[issue9251] Test for the import lock

Changes by Antoine Pitrou : -- resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed ___ Python tracker ___ ___

[issue9251] Test for the import lock

Changes by Antoine Pitrou : Removed file: http://bugs.python.org/file18605/issue9251_threadimp_py3k_head.patch ___ Python tracker ___ ___ Pyth

[issue9251] Test for the import lock

Changes by Antoine Pitrou : Removed file: http://bugs.python.org/file18003/threadimp2.patch ___ Python tracker ___ ___ Python-bugs-list mailing

[issue9251] Test for the import lock

Changes by Antoine Pitrou : Removed file: http://bugs.python.org/file17995/threadimp.patch ___ Python tracker ___ ___ Python-bugs-list mailing

[issue9251] Test for the import lock

Antoine Pitrou added the comment: The new patch was committed in r84258, thanks Nick. -- ___ Python tracker ___ ___ Python-bugs-list m

[issue9251] Test for the import lock

Antoine Pitrou added the comment: > Was I meant to still be looking at mtimport or threadimp, or have both > of those been applied? threadimp has already been committed. As for mtimport, I'll try to refactor it into a proper unit test. -- ___ Pytho

[issue9251] Test for the import lock

Nick Coghlan added the comment: With the new setUp and tearDown methods, the threadedimp2 patch doesn't apply cleanly any more. Looks good and passes for me - fixed patch attached. Was I meant to still be looking at mtimport or threadimp, or have both of those been applied? -- Added

[issue9251] Test for the import lock

Antoine Pitrou added the comment: Ping? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue9251] Test for the import lock

Antoine Pitrou added the comment: Here is another patch that also tests that calls to path hooks and meta_path entries are serialized. Again, they pass in normal conditions and fail when the import lock is disabled. -- Added file: http://bugs.python.org/file18003/threadimp2.patch ___

[issue9251] Test for the import lock

Antoine Pitrou added the comment: I've committed the fix in r82885 (3.2) and r82886 (3.1). The reliance on random still looks a bit quirky to me, but at least the test now does what it should do, and has a cleaned up coding style. I'm leaving this issue open, for the other test might be inter

[issue9251] Test for the import lock

Antoine Pitrou added the comment: Ok, here is a patch for test_threaded_import that makes it work for regrtest too. I've removed all global variables and converted it to unittest. -- keywords: +patch Added file: http://bugs.python.org/file17995/threadimp.patch

[issue9251] Test for the import lock

Antoine Pitrou added the comment: > test_threaded_import is designed to check the import lock (and it does > at least to some degree - I changed runpy's handling of the import > lock because my original approach broke that test). Apparently, Lib/test/test_threaded_import only works if run direc

[issue9251] Test for the import lock

Nick Coghlan added the comment: test_threaded_import is designed to check the import lock (and it does at least to some degree - I changed runpy's handling of the import lock because my original approach broke that test). (Haven't looked at this patch in detail as yet) --

[issue9251] Test for the import lock

Changes by Antoine Pitrou : Added file: http://bugs.python.org/file17991/mtimport.py ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue9251] Test for the import lock

Changes by Antoine Pitrou : Removed file: http://bugs.python.org/file17990/mtimport.py ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue9251] Test for the import lock

New submission from Antoine Pitrou : The import lock is lacking tests that it functions properly. Coming up with a way of checking it was unexpectedly hard. I finally managed to write a script which quite reliably fails if you patch Python/import.c to not take the import lock. The script relie